January 2023 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: network_create: put SUBNET in NET_NAME

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30995 ) Change subject: network_create: put SUBNET in NET_NAME ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifcd384272c56d585e220e2588f2186dc110902ed Gerrit-Change-Number: 30995 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 09:06:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: network_create: put SUBNET in NET_NAME

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30995 ) Change subject: network_create: put SUBNET in NET_NAME ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifcd384272c56d585e220e2588f2186dc110902ed Gerrit-Change-Number: 30995 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 08:54:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in docker-playground[master]: network_create: put SUBNET in NET_NAME

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30995 ) Change subject: network_create: put SUBNET in NET_NAME ...................................................................... network_create: put SUBNET in NET_NAME Fix the bug that running a test twice on the same host results in the second test stopping the containers and network of the first test: * Have the subnet name in the network name, so there's no collision of network names when cleaning up the network. * Don't clean up the network when creating a new network. Rely on the clean up trap to clean up the network instead. * Don't set NET_NAME when sourcing jenkins-common.sh anymore, as network_create will set it. There's also network_bridge_create, which only gets used by osmo-ran (which we don't run in jenkins). Add a check to this function to ensure NET_NAME is set before calling it, which osmo-ran is already doing. Related: OS#5802 Change-Id: Ifcd384272c56d585e220e2588f2186dc110902ed --- M jenkins-common.sh M ttcn3-bsc-test/jenkins-sccplite.sh M ttcn3-ggsn-test/jenkins-ogs.sh 3 files changed, 9 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/95/30995/1 diff --git a/jenkins-common.sh b/jenkins-common.sh index 758c4d0..c7c282c 100644 --- a/jenkins-common.sh +++ b/jenkins-common.sh @@ -195,19 +195,12 @@ docker network inspect $NET_NAME | grep Name | cut -d : -f2 | awk -F\" 'NR>1{print $2}' | xargs -rn1 docker kill } -# Create network and find a free subnet automatically. The global variable -# SUBNET gets set to the subnet number that has been used. +# Create network and find a free subnet automatically. The global variables +# SUBNET (subnet number) and NET_NAME (name of the docker network) get set. network_create() { - if docker network ls | grep -q $NET_NAME; then - set +x - echo "Removing stale network and containers..." - set -x - network_clean - network_remove - fi - SUBNET="$PPID" for i in $(seq 1 30); do + NET_NAME="$SUITE_NAME-$SUBNET" SUBNET="$(echo "($SUBNET + 1) % 256" | bc)" SUB4="172.18.$SUBNET.0/24" SUB6="fd02:db8:$SUBNET::/64" @@ -235,6 +228,12 @@ } network_bridge_create() { + if [ -z "$NET_NAME" ]; then + set +x + echo "ERROR: network_bridge_create: NET_NAME needs to be set" + exit 1 + fi + NET=$1 if docker network ls | grep -q $NET_NAME; then set +x @@ -518,5 +517,3 @@ fi SUITE_NAME=`basename $PWD` - -NET_NAME=$SUITE_NAME diff --git a/ttcn3-bsc-test/jenkins-sccplite.sh b/ttcn3-bsc-test/jenkins-sccplite.sh index 2343b4a..7ba8c9e 100755 --- a/ttcn3-bsc-test/jenkins-sccplite.sh +++ b/ttcn3-bsc-test/jenkins-sccplite.sh @@ -10,9 +10,6 @@ set_clean_up_trap set -e -#Make sure NET_NAME doesn't clash with the AoIP BSC test -NET_NAME=ttcn3-bsc_sccplite-test - mkdir $VOL_BASE_DIR/bsc-tester cp sccplite/BSC_Tests.cfg $VOL_BASE_DIR/bsc-tester/ write_mp_osmo_repo "$VOL_BASE_DIR/bsc-tester/BSC_Tests.cfg" diff --git a/ttcn3-ggsn-test/jenkins-ogs.sh b/ttcn3-ggsn-test/jenkins-ogs.sh index 93cc33a..5875b75 100755 --- a/ttcn3-ggsn-test/jenkins-ogs.sh +++ b/ttcn3-ggsn-test/jenkins-ogs.sh @@ -11,9 +11,6 @@ set_clean_up_trap set -e -#Make sure NET_NAME doesn't clash with the AoIP BSC test -NET_NAME=ttcn3-ggsn-test-ogs - mkdir $VOL_BASE_DIR/ggsn-tester cp ogs/GGSN_Tests.cfg $VOL_BASE_DIR/ggsn-tester/ write_mp_osmo_repo "$VOL_BASE_DIR/ggsn-tester/GGSN_Tests.cfg" -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30995 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ifcd384272c56d585e220e2588f2186dc110902ed Gerrit-Change-Number: 30995 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen()

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30986 ) Change subject: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen() ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File tests/socket/socket_test.c: https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/25668f19_0ff3f175 PS2, Line 420: chcking checking, same below -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I75e75e251c6776801fffdde745aebedf21c68799 Gerrit-Change-Number: 30986 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 08:13:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmo-hlr[master]: fix memleak of proxy_subscr_listentry

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/30981 ) Change subject: fix memleak of proxy_subscr_listentry ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/30981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ic1ec4911fa5ae91cc75aa865c8201edd83af41ed Gerrit-Change-Number: 30981 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Jan 2023 07:03:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: generate config.h

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30991 ) Change subject: layer23: generate config.h ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > You should also add 'config.h.in' and 'config.h' to .gitignore. They are already there -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic779a3168012780feef8d173371387d09d383bfd Gerrit-Change-Number: 30991 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 20:13:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in osmocom-bb[master]: layer23: generate config.h

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30991 ) Change subject: layer23: generate config.h ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: You should also add 'config.h.in' and 'config.h' to .gitignore. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30991 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic779a3168012780feef8d173371387d09d383bfd Gerrit-Change-Number: 30991 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 18:36:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmocore[master]: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen()

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30986 ) Change subject: socket.h: Introduce API osmo_sockaddr_netmask_to_prefixlen() ...................................................................... Patch Set 2: Code-Review+1 (6 comments) Patchset: PS2: None of my comments are critical, can be done in a subsequent patch. File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/9a603c26_fc9ddef0 PS2, Line 1304: 4 sizeof(uint32_t) https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/6dfa6aad_e012b3ba PS2, Line 1306: cosmetic: no need for a space https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/332f182b_17cb458c PS2, Line 1307: 4 sizeof(bits) or sizeof(uint32_t) https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/e76c9c92_e89eef18 PS2, Line 1323: cosmetic: no need for a space https://gerrit.osmocom.org/c/libosmocore/+/30986/comment/d93ba7e9_0eef5f5c PS2, Line 1326: 4 sizeof(bits) or sizeof(uint32_t) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30986 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I75e75e251c6776801fffdde745aebedf21c68799 Gerrit-Change-Number: 30986 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Jan 2023 18:32:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: Send raw data with mISDN as it arrives from application

by jolly

Attention is currently required from: jolly, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30450 ) Change subject: Send raw data with mISDN as it arrives from application ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Are you sure this won't break any existing applications? So far we did not push this responsibility […] I am sure that it won't break any existing applications, because raw data did not work with libosmo-abis at all. -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib311331fbbeff3661f6745e3474918987a8aa460 Gerrit-Change-Number: 30450 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 Jan 2023 17:46:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

Change in libosmo-abis[master]: Send raw data with mISDN as it arrives from application

by pespin

Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30450 ) Change subject: Send raw data with mISDN as it arrives from application ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30450 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: Ib311331fbbeff3661f6745e3474918987a8aa460 Gerrit-Change-Number: 30450 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Mon, 16 Jan 2023 17:43:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2023