September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-hnbgw[master]: Workaround bug where old hnb_context from same remote addr+port is kept

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536 ) Change subject: Workaround bug where old hnb_context from same remote addr+port is kept ...................................................................... Patch Set 2: (3 comments) File src/osmo-hnbgw/hnbgw_hnbap.c: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536/comment/dbed6eb0_e9d57d1e PS2, Line 426: if (hnb->hnb_registered && ctx != hnb && memcmp(&ctx->id, &hnb->id, sizeof(ctx->id)) == 0) { (early-exit coding style would be nicer like if (!(...)) continue; ... then the new code block would need less indenting) https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536/comment/6184dee5_2e036efb PS2, Line 428: bug is it really a bug?? from the commit log it sounds like it is handling a hnb peer that opens a second conn for the same context? if it's a bug it should be possible to figure out how such bug is possible? https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536/comment/738ca6fc_1f96b35e PS2, Line 434: LOGHNB(ctx, DHNBAP, LOGL_ERROR, "BUG! Found old registered HNB with invalid socket, releasing it\n"); IMHO the error logs could more clearly indicate that the same HNB is registering a second time, that we have an old record of the *same* HNB that is requesting to register now. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I33ae901cc37646eca90bf06953e44fcc25f4d6c6 Gerrit-Change-Number: 29536 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 14:48:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Drop unneeded comment block

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29533 ) Change subject: osmux: Drop unneeded comment block ...................................................................... osmux: Drop unneeded comment block Change-Id: Iae04a7c4b496492ce5b363a56fdd871b210012ed --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 706de07..8d8fcd8 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -448,13 +448,6 @@ endp = conn_src->conn->endp; mgcp_conn_watchdog_kick(conn_src->conn); - /*conn_dst = mgcp_find_dst_conn(conn_src->conn); - if (!conn_dst) { - LOGP(DOSMUX, LOGL_ERROR, - "Cannot find a dst conn for circuit_id=%d\n", - osmuxh->circuit_id); - goto out; - }*/ if (endp_osmux_state_check(endp, conn_src, false) == 0) { rtpconn_osmux_rate_ctr_inc(conn_src, OSMUX_CHUNKS_RX_CTR); rtpconn_osmux_rate_ctr_add(conn_src, OSMUX_OCTETS_RX_CTR, -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29533 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iae04a7c4b496492ce5b363a56fdd871b210012ed Gerrit-Change-Number: 29533 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Lower log level when osmux batch received for unknown CID

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29534 ) Change subject: osmux: Lower log level when osmux batch received for unknown CID ...................................................................... osmux: Lower log level when osmux batch received for unknown CID This is actually quite common, since our peer may be sending some osmux packets to us a while after we have closed the conn on our side, specially if latency is high in the network (eg satellite links). Related: SYS#5987 Change-Id: Idffd91b68d1f98ac906d78e7fbc0e6eaa1962f9e --- M src/libosmo-mgcp/mgcp_osmux.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/libosmo-mgcp/mgcp_osmux.c b/src/libosmo-mgcp/mgcp_osmux.c index 8d8fcd8..c3c8427 100644 --- a/src/libosmo-mgcp/mgcp_osmux.c +++ b/src/libosmo-mgcp/mgcp_osmux.c @@ -285,7 +285,7 @@ } } - LOGP(DOSMUX, LOGL_ERROR, "Cannot find osmux conn with rem_addr=%s local_cid=%d\n", + LOGP(DOSMUX, LOGL_DEBUG, "Cannot find osmux conn with rem_addr=%s local_cid=%d\n", osmo_sockaddr_to_str(rem_addr), local_cid); return NULL; @@ -395,7 +395,7 @@ conn = osmux_conn_lookup(trunk, osmux_cid, rem_addr); if (!conn) { - LOGP(DOSMUX, LOGL_ERROR, + LOGP(DOSMUX, LOGL_DEBUG, "Cannot find conn for Osmux CID %d\n", osmux_cid); goto out; } @@ -440,7 +440,7 @@ conn_src = osmux_conn_lookup(trunk, osmuxh->circuit_id, &rem_addr); if (!conn_src) { - LOGP(DOSMUX, LOGL_ERROR, + LOGP(DOSMUX, LOGL_DEBUG, "Cannot find a src conn for circuit_id=%d\n", osmuxh->circuit_id); goto out; -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idffd91b68d1f98ac906d78e7fbc0e6eaa1962f9e Gerrit-Change-Number: 29534 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 11 months

1
0
0 0

Change in osmo-hnbgw[master]: Close conn when receiving SCTP_ASSOC_CHANGE notification

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547 ) Change subject: Close conn when receiving SCTP_ASSOC_CHANGE notification ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547/comment/dd5562a4_db59b8a1 PS1, Line 9: It was seen on a real pcap trace (sctp & gsmtap_log) that the kernel > i read this before and commented it, can you "link" the patches by a […] Related: SYS#6113, it's already there. The patches (his and the other one) you mention are ortoghonal/independent. Other patch: The libosmo-netif patch returns 0 in order for callers not wishing to take care of SCTP notification flags closing properly the conn when receiving return code 0. This pach: This is the only caller which make use of flags, and hence must also take that one into account. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If35efd404405f926a4a6cc45862eeadd1b04e08c Gerrit-Change-Number: 29547 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 14:40:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-hnbgw[master]: Fix handling of sctp SCTP_SHUTDOWN_EVENT notification

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29546 ) Change subject: Fix handling of sctp SCTP_SHUTDOWN_EVENT notification ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I7fa648142c07f63c55091d2a15b9d7312bcd4cec Gerrit-Change-Number: 29546 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 14:37:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-hnbgw[master]: hnb_read_cb: use local var to reduce get_ofd() calls

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29548 to look at the new patch set (#2). Change subject: hnb_read_cb: use local var to reduce get_ofd() calls ...................................................................... hnb_read_cb: use local var to reduce get_ofd() calls Change-Id: Ic7058b5a05b0d34b80617006d4e929a523212221 --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/48/29548/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29548 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ic7058b5a05b0d34b80617006d4e929a523212221 Gerrit-Change-Number: 29548 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-hnbgw[master]: hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-...

by pespin

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29549 to look at the new patch set (#2). Change subject: hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-after-free ...................................................................... hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-after-free Otherwise the libosmo-netif stream API may continue accessing the conn after returning if the socket has the WRITE flag active in the same main loop iteration. Change-Id: I628c59a88d94d299f432f405b37fbe602381d47e --- M src/osmo-hnbgw/hnbgw.c 1 file changed, 4 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hnbgw refs/changes/49/29549/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I628c59a88d94d299f432f405b37fbe602381d47e Gerrit-Change-Number: 29549 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 11 months

1
0
0 0

Change in osmo-hnbgw[master]: hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-...

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29549 ) Change subject: hnb_read_cb(): -EBADF must be returned if conn is freed to avoid use-after-free ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29549/comment/41070233_2ad1aa52 PS1, Line 11: loop iteration. > sounds like adapting the api implementation to fix a problem that should be fixed in the calling cod […] This is a historical usual way of handling this in lots of osmocom code, so I'm simply sticking to existing convention in place. I'm doing nothing new here. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29549 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I628c59a88d94d299f432f405b37fbe602381d47e Gerrit-Change-Number: 29549 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 14:36:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in osmo-hnbgw[master]: Close conn when receiving SCTP_ASSOC_CHANGE notification

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547 ) Change subject: Close conn when receiving SCTP_ASSOC_CHANGE notification ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547/comment/3e6e5a02_34b7c31a PS1, Line 9: It was seen on a real pcap trace (sctp & gsmtap_log) that the kernel i read this before and commented it, can you "link" the patches by a Related: <change-id> and explain how they relate Patchset: PS1: (looks like this function also fails to put() to msgb if sctp_revmsg() rc > 0 in case of NOTIFICATION, like seen in that other patch) -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/29547 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: If35efd404405f926a4a6cc45862eeadd1b04e08c Gerrit-Change-Number: 29547 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 30 Sep 2022 14:36:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 11 months

1
0
0 0

Change in libosmo-netif[master]: stream: Document osmo_stream_srv_recv() SCTP specialties

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29550 ) Change subject: stream: Document osmo_stream_srv_recv() SCTP specialties ...................................................................... stream: Document osmo_stream_srv_recv() SCTP specialties Change-Id: I47b066f26e63afd4bdb135f822667d1cd9479920 --- M src/stream.c 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/50/29550/1 diff --git a/src/stream.c b/src/stream.c index 38d24fe..68de30c 100644 --- a/src/stream.c +++ b/src/stream.c @@ -1524,6 +1524,16 @@ * \param[in] conn Stream Server from which to receive * \param msg pre-allocate message buffer to which received data is appended * \returns number of bytes read, negative on error. + * + * If conn is an SCTP connection, additional specific considerations shall be taken: + * - msg->cb is always filled with SCTP ppid, and SCTP stream values, see msgb_sctp_*() APIs. + * - If an SCTP notification was received when reading from the SCTP socket, + * msgb_sctp_msg_flags(msg) will contain bit flag + * OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION set, and he msgb will + * contain a "union sctp_notification" instead of user data. In this case the + * return code will be either 0 (if conn is considered dead after the + * notification) or -EAGAIN (if conn is considered still alive after the + * notification) resembling the standard recv() API. */ int osmo_stream_srv_recv(struct osmo_stream_srv *conn, struct msgb *msg) { -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29550 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I47b066f26e63afd4bdb135f822667d1cd9479920 Gerrit-Change-Number: 29550 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 11 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022