September 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: library/AMR: Add RTP AMR helper structs and functions

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 ) Change subject: library/AMR: Add RTP AMR helper structs and functions ...................................................................... Patch Set 3: (1 comment) File library/AMR_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277/comment/28f2237f_44bf… PS3, Line 46: FIELDORDER We may want to have this set globally at the end of module, near the 'encode "RAW"'. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40cd999badeeefa38a393af9008d8ce047e3c778 Gerrit-Change-Number: 29277 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:30:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library/AMR: Add RTP AMR helper structs and functions

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 to look at the new patch set (#3). Change subject: library/AMR: Add RTP AMR helper structs and functions ...................................................................... library/AMR: Add RTP AMR helper structs and functions Change-Id: I40cd999badeeefa38a393af9008d8ce047e3c778 --- M library/AMR_Types.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/29277/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40cd999badeeefa38a393af9008d8ce047e3c778 Gerrit-Change-Number: 29277 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

Change in osmo-sgsn[master]: llc: gprs_llc_hdr_parse(): make the input data pointer const

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 ) Change subject: llc: gprs_llc_hdr_parse(): make the input data pointer const ...................................................................... Patch Set 1: (1 comment) File src/gprs/gprs_llc_parse.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/29279/comment/616fe2e4_efc4bb53 PS1, Line 138: ghp->data = (uint8_t *)&ctrl[3]; > The main point of using const is *not* to assist the compiler in optimizations but to protect yourse […] You are also telling the user that calling the function won't make any kind of modification at any time to contents of that address at any time. What if the user passes a const pointer coming from a write-protected memory region? Yes, you are supposed, according to your change API, to store a *readonly* address, not a write one. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9757d2be5af589ccbe4d3d406637a33690284754 Gerrit-Change-Number: 29279 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-sgsn[master]: llc: gprs_llc_hdr_parse(): make the input data pointer const

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 ) Change subject: llc: gprs_llc_hdr_parse(): make the input data pointer const ...................................................................... Patch Set 1: (1 comment) File src/gprs/gprs_llc_parse.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/29279/comment/cf293d55_660c0822 PS1, Line 138: ghp->data = (uint8_t *)&ctrl[3]; > The compiler may make optimizations based on what passed to the function. […] The main point of using const is *not* to assist the compiler in optimizations but to protect yourself from mistakes... I am telling the API user that gprs_llc_hdr_parse() does not modify the given buffer, that's it. I would agree with you if I were actually changing the given buffer here via a const pointer, or were passing it to some other function which does so. What I am doing here and below is storing an address. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9757d2be5af589ccbe4d3d406637a33690284754 Gerrit-Change-Number: 29279 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:19:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-sgsn[master]: llc: gprs_llc_hdr_parse(): make the input data pointer const

by pespin

Attention is currently required from: osmith, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 ) Change subject: llc: gprs_llc_hdr_parse(): make the input data pointer const ...................................................................... Patch Set 1: (1 comment) File src/gprs/gprs_llc_parse.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/29279/comment/5d198a3d_6d1a71a1 PS1, Line 138: ghp->data = (uint8_t *)&ctrl[3]; > Yes, but why doing this is wrong? gprs_llc_hdr_parse() itself does not modify *llc_hdr, so it's cons […] The compiler may make optimizations based on what passed to the function. If a const pointer is passed to a function, that means it can be inferred that the content of array remains invariable regardless of whether the function was called or not. You are actually telling the compiler one thing while actually sneakily changing what you announced. That's why casting should be done carefully and with a good reason. If the data content being passed here will need to be writeable, bear with it and don't announce it's const. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9757d2be5af589ccbe4d3d406637a33690284754 Gerrit-Change-Number: 29279 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:07:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-sgsn[master]: llc: gprs_llc_hdr_parse(): make the input data pointer const

by fixeria

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 ) Change subject: llc: gprs_llc_hdr_parse(): make the input data pointer const ...................................................................... Patch Set 1: (1 comment) File src/gprs/gprs_llc_parse.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/29279/comment/052775ba_13b4f07d PS1, Line 138: ghp->data = (uint8_t *)&ctrl[3]; > Then you are breaking the const constraints here, so you shouldn't be doing this ;) Yes, but why doing this is wrong? gprs_llc_hdr_parse() itself does not modify *llc_hdr, so it's const here. The caller does modify the payload, so it's not const in struct gprs_llc_hdr_parsed. I see no problems here. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9757d2be5af589ccbe4d3d406637a33690284754 Gerrit-Change-Number: 29279 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:00:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-gsm-tester[master]: contrib: osmo-bts now depends on libosmo-netif

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/29282 ) Change subject: contrib: osmo-bts now depends on libosmo-netif ...................................................................... contrib: osmo-bts now depends on libosmo-netif Since osmo-bts.git a2dc808acc5b99122e97c9013cb1ec2ae0c4a2a1, osmo-bts depends on libosmo-netif. Let's add the dependency when building. Change-Id: I8e40b2de19ecfca084780f69808c7030817e43d7 --- M contrib/jenkins-build-osmo-bts-oc2g.sh M contrib/jenkins-build-osmo-bts-sysmo.sh M contrib/jenkins-build-osmo-bts.sh 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/contrib/jenkins-build-osmo-bts-oc2g.sh b/contrib/jenkins-build-osmo-bts-oc2g.sh index 41eac19..6d660ef 100755 --- a/contrib/jenkins-build-osmo-bts-oc2g.sh +++ b/contrib/jenkins-build-osmo-bts-oc2g.sh @@ -26,6 +26,7 @@ build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug build_repo libosmo-abis --disable-dahdi +build_repo libosmo-netif --disable-doxygen build_repo osmo-bts --disable-sysmocom-bts --enable-oc2g --with-oc2g="$L1_OC2G_HEADERS" create_bin_tgz osmo-bts-oc2g diff --git a/contrib/jenkins-build-osmo-bts-sysmo.sh b/contrib/jenkins-build-osmo-bts-sysmo.sh index 731867f..67681c3 100755 --- a/contrib/jenkins-build-osmo-bts-sysmo.sh +++ b/contrib/jenkins-build-osmo-bts-sysmo.sh @@ -20,6 +20,7 @@ build_repo libosmocore --disable-pcsc --disable-libmnl --disable-doxygen --disable-gnutls --disable-detect-tls-gcc-arm-bug build_repo libosmo-abis --disable-dahdi +build_repo libosmo-netif --disable-doxygen build_repo osmo-bts --enable-sysmocom-bts --with-openbsc=$base/openbsc/openbsc/include create_bin_tgz osmo-bts-sysmo diff --git a/contrib/jenkins-build-osmo-bts.sh b/contrib/jenkins-build-osmo-bts.sh index 182dbf7..27f82cc 100755 --- a/contrib/jenkins-build-osmo-bts.sh +++ b/contrib/jenkins-build-osmo-bts.sh @@ -8,6 +8,7 @@ build_repo libosmocore ${SANITIZE_FLAGS} --disable-doxygen build_repo libosmo-abis ${SANITIZE_FLAGS} --disable-dahdi +build_repo libosmo-netif ${SANITIZE_FLAGS} --disable-doxygen build_repo osmo-bts ${SANITIZE_FLAGS} --enable-trx --with-openbsc=$base/openbsc/openbsc/include --enable-octphy --with-octsdr-2g=$base/octphy-2g-headers create_bin_tgz "osmo-bts-trx osmo-bts-octphy osmo-bts-virtual" -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/29282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I8e40b2de19ecfca084780f69808c7030817e43d7 Gerrit-Change-Number: 29282 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: merged

2 years, 9 months

1
0
0 0

Change in osmo-gsm-tester[master]: contrib: osmo-bts now depends on libosmo-netif

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/29282 ) Change subject: contrib: osmo-bts now depends on libosmo-netif ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/29282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I8e40b2de19ecfca084780f69808c7030817e43d7 Gerrit-Change-Number: 29282 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 07 Sep 2022 08:59:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-gsm-tester[master]: contrib: osmo-bts now depends on libosmo-netif

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/29282 ) Change subject: contrib: osmo-bts now depends on libosmo-netif ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/29282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I8e40b2de19ecfca084780f69808c7030817e43d7 Gerrit-Change-Number: 29282 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 07 Sep 2022 08:59:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 9 months

1
0
0 0

Change in osmo-gsm-tester[master]: contrib: osmo-bts now depends on libosmo-netif

by pespin

pespin has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/29282 ) Change subject: contrib: osmo-bts now depends on libosmo-netif ...................................................................... contrib: osmo-bts now depends on libosmo-netif Since osmo-bts.git a2dc808acc5b99122e97c9013cb1ec2ae0c4a2a1, osmo-bts depends on libosmo-netif. Let's add the dependency when building. Change-Id: I8e40b2de19ecfca084780f69808c7030817e43d7 --- M contrib/jenkins-build-osmo-bts-oc2g.sh M contrib/jenkins-build-osmo-bts-sysmo.sh M contrib/jenkins-build-osmo-bts.sh 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/82/29282/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/29282 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I8e40b2de19ecfca084780f69808c7030817e43d7 Gerrit-Change-Number: 29282 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 9 months

1
0
0 0

2025

2024

2023

2022

gerrit-log September 2022