lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

September 2022

  • 2 participants
  • 1860 discussions
Change in osmo-sgsn[master]: llc: gprs_llc_hdr_parse(): make the input data pointer const
by fixeria 07 Sep '22

07 Sep '22
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 ) Change subject: llc: gprs_llc_hdr_parse(): make the input data pointer const ...................................................................... Patch Set 1: (1 comment) File src/gprs/gprs_llc_parse.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/29279/comment/5c75eb8a_83f99ee4 PS1, Line 138: ghp->data = (uint8_t *)&ctrl[3]; > You are also telling the user that calling the function won't make any kind of modification at any time to contents of that address at any time. Not at any time, but only during the function exec time. > What if the user passes a const pointer coming from a write-protected memory region? Then it's still responsibility of the user to not modify a write-protected memory region. There exist functions in glibc internally casting const to non-const, e.g. memchr(), strchr(), or strstr(). Do you also consider them wrong? -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9757d2be5af589ccbe4d3d406637a33690284754 Gerrit-Change-Number: 29279 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:46:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-sgsn[master]: llc: gprs_llc_hdr_rx(): avoid using 'struct gprs_llc_hdr'
by osmith 07 Sep '22

07 Sep '22
Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29281 ) Change subject: llc: gprs_llc_hdr_rx(): avoid using 'struct gprs_llc_hdr' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29281 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Idc6262f61971e13545fab884ce401e2b78505f01 Gerrit-Change-Number: 29281 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:41:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in docker-playground[master]: osmo-bts-master: Depend on libosmo-netif
by pespin 07 Sep '22

07 Sep '22
pespin has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29283 ) Change subject: osmo-bts-master: Depend on libosmo-netif ...................................................................... osmo-bts-master: Depend on libosmo-netif Since osmo-bts.git a2dc808acc5b99122e97c9013cb1ec2ae0c4a2a1, osmo-bts depends on libosmo-netif. Let's add the dependency when building. Change-Id: If033ed7f25bb69a66ecff56b2a1781d6339a6d7e --- M osmo-bts-master/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/osmo-bts-master/Dockerfile b/osmo-bts-master/Dockerfile index 77c1e51..67dd75f 100644 --- a/osmo-bts-master/Dockerfile +++ b/osmo-bts-master/Dockerfile @@ -25,6 +25,7 @@ "pkgconfig(libosmoctrl)" \ "pkgconfig(libosmogb)" \ "pkgconfig(libosmogsm)" \ + "pkgconfig(libosmo-netif)" \ "pkgconfig(libosmotrau)" \ "pkgconfig(libosmovty)" \ ;; \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If033ed7f25bb69a66ecff56b2a1781d6339a6d7e Gerrit-Change-Number: 29283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in docker-playground[master]: osmo-bts-master: Depend on libosmo-netif
by osmith 07 Sep '22

07 Sep '22
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29283 ) Change subject: osmo-bts-master: Depend on libosmo-netif ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If033ed7f25bb69a66ecff56b2a1781d6339a6d7e Gerrit-Change-Number: 29283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:38:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
Change in docker-playground[master]: osmo-bts-master: Depend on libosmo-netif
by pespin 07 Sep '22

07 Sep '22
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29283 ) Change subject: osmo-bts-master: Depend on libosmo-netif ...................................................................... osmo-bts-master: Depend on libosmo-netif Since osmo-bts.git a2dc808acc5b99122e97c9013cb1ec2ae0c4a2a1, osmo-bts depends on libosmo-netif. Let's add the dependency when building. Change-Id: If033ed7f25bb69a66ecff56b2a1781d6339a6d7e --- M osmo-bts-master/Dockerfile 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/83/29283/1 diff --git a/osmo-bts-master/Dockerfile b/osmo-bts-master/Dockerfile index 77c1e51..67dd75f 100644 --- a/osmo-bts-master/Dockerfile +++ b/osmo-bts-master/Dockerfile @@ -25,6 +25,7 @@ "pkgconfig(libosmoctrl)" \ "pkgconfig(libosmogb)" \ "pkgconfig(libosmogsm)" \ + "pkgconfig(libosmo-netif)" \ "pkgconfig(libosmotrau)" \ "pkgconfig(libosmovty)" \ ;; \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29283 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: If033ed7f25bb69a66ecff56b2a1781d6339a6d7e Gerrit-Change-Number: 29283 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange
1 0
0 0
Change in osmo-sgsn[master]: llc: gprs_llc_hdr_parse(): make the input data pointer const
by osmith 07 Sep '22

07 Sep '22
Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 ) Change subject: llc: gprs_llc_hdr_parse(): make the input data pointer const ...................................................................... Patch Set 1: (1 comment) File src/gprs/gprs_llc_parse.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/29279/comment/6103887f_c49caa1f PS1, Line 138: ghp->data = (uint8_t *)&ctrl[3]; > What if the user passes a const pointer coming from a write-protected memory region? I agree with Pau, this illustrates well why this is a problem IMHO -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/29279 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9757d2be5af589ccbe4d3d406637a33690284754 Gerrit-Change-Number: 29279 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:37:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment
1 0
0 0
Change in osmo-ttcn3-hacks[master]: Osmux_Emulation: Add DATA port
by pespin 07 Sep '22

07 Sep '22
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29273 ) Change subject: Osmux_Emulation: Add DATA port ...................................................................... Osmux_Emulation: Add DATA port Similar to what's already present in RTPEM_Emulation, this allows tests to retrieve the Osmux messages received. Related: OS#5987 Change-Id: Id9aa3a0a02ef5a5e39b4df8a1c165f35255829ab --- M library/OSMUX_Emulation.ttcn 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/library/OSMUX_Emulation.ttcn b/library/OSMUX_Emulation.ttcn index 10338d2..c6999de 100644 --- a/library/OSMUX_Emulation.ttcn +++ b/library/OSMUX_Emulation.ttcn @@ -67,6 +67,8 @@ /* user-facing port for controlling the binding */ port OsmuxEM_CTRL_PT CTRL; + /* user-facing port for sniffing Osmux frames */ + port OsmuxEM_DATA_PT DATA; /* configurable by user, should be fixed */ var OsmuxemConfig g_cfg := c_OsmuxemDefaultCfg; @@ -190,6 +192,10 @@ OsmuxEM_stats_get, OsmuxEM_register_rxhandle, OsmuxEM_register_txhandle; } with { extension "internal" }; +type port OsmuxEM_DATA_PT message { + inout OSMUX_PDU; +} with { extension "internal" }; + function f_osmuxem_bind(OsmuxEM_CTRL_PT pt, in HostName local_host, inout PortNumber local_port) { pt.call(OsmuxEM_bind:{local_host, local_port}) { [] pt.getreply(OsmuxEM_bind:{local_host, ?}) -> param (local_port) {}; @@ -556,6 +562,9 @@ if (ispresent(g_cfg.rx_fixed_payload) and rx_osmux.msg.osmux_amr.data != payload_truncated) { g_stat.num_pkts_rx_err_payload := g_stat.num_pkts_rx_err_payload + 1; } + if (DATA.checkstate("Connected")) { + DATA.send(rx_osmux.msg); + } } /* process received Osmux Dummy if receiver enabled */ [g_rx_enabled] OSMUX.receive(tr_osmux_dummy) -> value rx_osmux { 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29273 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id9aa3a0a02ef5a5e39b4df8a1c165f35255829ab Gerrit-Change-Number: 29273 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmo-ttcn3-hacks[master]: library/AMR: Add RTP AMR helper structs and functions
by pespin 07 Sep '22

07 Sep '22
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 ) Change subject: library/AMR: Add RTP AMR helper structs and functions ...................................................................... library/AMR: Add RTP AMR helper structs and functions Change-Id: I40cd999badeeefa38a393af9008d8ce047e3c778 --- M library/AMR_Types.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/library/AMR_Types.ttcn b/library/AMR_Types.ttcn index 3ef2fbc..b4f044d 100644 --- a/library/AMR_Types.ttcn +++ b/library/AMR_Types.ttcn @@ -11,6 +11,7 @@ module AMR_Types { import from General_Types all; +import from Osmocom_Types all; /* AMR voice frame type identifiers * See also 3GPP TS 26.101, Table 1a: Interpretation of Frame Type, Mode @@ -35,4 +36,29 @@ return c_AMRFT_len[amr_ft]; } +type record RTP_AMR_Hdr { + uint4_t cmr, + BIT4 padding1, + BIT1 f, + uint4_t ft, + BIT1 q, + BIT2 padding2 +} with { variant "FIELDORDER(msb)" }; + +template (value) RTP_AMR_Hdr ts_RTP_AMR_Hdr(template (value) uint4_t cmr, + template (value) uint4_t ft, + template (value) BIT1 q := '1'B, + template (value) BIT1 f := '0'B) := { + cmr := cmr, + padding1 := '0000'B, + f := f, + ft := ft, + q := q, + padding2 := '00'B +} +external function enc_RTP_AMR_Hdr(in RTP_AMR_Hdr amr_hdr) return octetstring + with { extension "prototype(convert) encode(RAW)" }; +external function dec_RTP_AMR_Hdr(in octetstring stream) return RTP_AMR_Hdr + with { extension "prototype(convert) decode(RAW)" }; + } with { encode "RAW"} -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40cd999badeeefa38a393af9008d8ce047e3c778 Gerrit-Change-Number: 29277 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmo-ttcn3-hacks[master]: bts: Test AMR in TC_speech_rtp_tch{h,f}()
by pespin 07 Sep '22

07 Sep '22
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29272 ) Change subject: bts: Test AMR in TC_speech_rtp_tch{h,f}() ...................................................................... bts: Test AMR in TC_speech_rtp_tch{h,f}() Related: SYS#5987 Requires: osmocom-bb.git Ib80be434c06d07b3611bd18ae25dff8b14a7aad9 (trxcon) Change-Id: I8cf7792a00b0a858f6a02bf5cb0d283484b820eb --- M bts/BTS_Tests.ttcn M bts/gen_links.sh 2 files changed, 48 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 646e5bf..68e5cf1 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -47,6 +47,8 @@ import from RSL_Emulation all; import from RTP_Emulation all; +import from AMR_Types all; + import from IPL4asp_Types all; import from TRXC_Types all; import from TRXC_CodecPort all; @@ -2542,6 +2544,28 @@ g_first_meas_res := true; } +private function get_start_amr_ft() runs on ConnHdlr return integer { + var integer start_nth; + if (g_pars.mr_conf.icmi) { + start_nth := 0; /* FIXME: implement 3GPP TS 45.009 3.4.3 */ + } else { + start_nth := g_pars.mr_conf.start_mode; + } + + var integer n := 0; + for (var integer i:= 7; i >= 0; i := i - 1) { + if (g_pars.mr_conf.amr_codec_modes[i] == '1'B) { + if (n == start_nth) { + return 7 - i; + } + n := n + 1; + } + } + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("mr_conf is wrong! ", g_pars.mr_conf)); + return 0; +} + /* Initialize and start the RTP emulation component for a ConnHdlr */ friend function f_rtpem_activate(inout octetstring payload, RtpemConfig cfg := c_RtpemDefaultCfg, @@ -2566,7 +2590,19 @@ { payload_len := 15; hdr := '00'O; } case (tr_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM2)) /* TCH/EFS */ { payload_len := 31; hdr := 'C0'O; } - case else { /* FIXME: also handle TCH/AFS and TCH/AHS */ + case (tr_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM3)) /* TCH/AFS */ + { + var integer amr_ft := get_start_amr_ft(); + payload_len := f_amrft_payload_len(amr_ft) + 2; + hdr := enc_RTP_AMR_Hdr(valueof(ts_RTP_AMR_Hdr(amr_ft, amr_ft, '1'B))); + } + case (tr_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_SP_GSM3)) /* TCH/AHS */ + { + var integer amr_ft := get_start_amr_ft(); + payload_len := f_amrft_payload_len(amr_ft) + 2; + hdr := enc_RTP_AMR_Hdr(valueof(ts_RTP_AMR_Hdr(amr_ft, amr_ft, '1'B))); + } + case else { setverdict(fail, "Unhandled RSL channel mode := ", g_pars.chan_mode); Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } @@ -8147,7 +8183,11 @@ vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); vc_conn.done; - /* TODO: also test V3 (AMR codec) */ + /* TS1, TCH/F, V3 (AMR codec) */ + pars := valueof(t_Pars(ts_RslChanNr_Bm(1), ts_RSL_ChanMode(RSL_CHRT_TCH_F, RSL_CMOD_SP_GSM3))); + pars.mr_conf := valueof(ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } @@ -8162,7 +8202,11 @@ vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); vc_conn.done; - /* TODO: also test V3 (AMR codec) */ + /* TS1, TCH/H0, V3 (AMR codec) */ + pars := valueof(t_Pars(ts_RslChanNr_Lm(5, 0), ts_RSL_ChanMode(RSL_CHRT_TCH_H, RSL_CMOD_SP_GSM3))); + pars.mr_conf := valueof(ts_RSL_MultirateCfg(false, 0, '00000100'B /* 5,90k */)); + vc_conn := f_start_handler(refers(f_TC_speech_rtp), pars); + vc_conn.done; Misc_Helpers.f_shutdown(__BFILE__, __LINE__); } diff --git a/bts/gen_links.sh b/bts/gen_links.sh index c8c2b98..b7ba2cc 100755 --- a/bts/gen_links.sh +++ b/bts/gen_links.sh @@ -44,6 +44,7 @@ FILES+="L3_Templates.ttcn L3_Common.ttcn " FILES+="Native_Functions.ttcn Native_FunctionDefs.cc " FILES+="TRXC_Types.ttcn TRXC_CodecPort.ttcn TRXC_CodecPort_CtrlFunct.ttcn TRXC_CodecPort_CtrlFunctDef.cc " +FILES+="AMR_Types.ttcn " FILES+="RTP_CodecPort.ttcn RTP_Emulation.ttcn IuUP_Types.ttcn IuUP_Emulation.ttcn IuUP_EncDec.cc " FILES+="RTP_CodecPort_CtrlFunct.ttcn RTP_CodecPort_CtrlFunctDef.cc " FILES+="PCUIF_Types.ttcn PCUIF_CodecPort.ttcn " 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29272 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8cf7792a00b0a858f6a02bf5cb0d283484b820eb Gerrit-Change-Number: 29272 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged
1 0
0 0
Change in osmo-ttcn3-hacks[master]: library/AMR: Add RTP AMR helper structs and functions
by pespin 07 Sep '22

07 Sep '22
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 ) Change subject: library/AMR: Add RTP AMR helper structs and functions ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29277 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I40cd999badeeefa38a393af9008d8ce047e3c778 Gerrit-Change-Number: 29277 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 07 Sep 2022 09:32:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 161
  • 162
  • 163
  • 164
  • 165
  • 166
  • 167
  • ...
  • 186
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.