August 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: BTS_Tests: f_est_rll_mo(): add waiting timeout (2s)

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28832 ) Change subject: BTS_Tests: f_est_rll_mo(): add waiting timeout (2s) ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: do we really want this in our codebaes? The function is probably executed many times during the test suite, so we're easily adding minutes to the total test execution. The commit log reads a bit like this is just for debugging / finding a problem. If so, then that could/should be done outside of master, right? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28832 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I71ab69d85f453964749270d970c55e6f577a73a1 Gerrit-Change-Number: 28832 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 10:01:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-msc[master]: Introduce libsmpputil

by laforge

Attention is currently required from: pespin, msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28844 ) Change subject: Introduce libsmpputil ...................................................................... Patch Set 7: (1 comment) File src/utils/Makefile.am: https://gerrit.osmocom.org/c/osmo-msc/+/28844/comment/61592573_180398a3 PS2, Line 32: $(top_srcdir)/src/libmsc/smpp_smsc.h \ > Given it's internal build-time optional library I don't think it's worth the effort. it doesn't need to be a new SMPP_UTIL_HEADERS, but I actually think it would even make sense to move it to a separate sub-directory like src/smpp/ or the like. I'd agree with pespin that it's best to somehow have a logical grouping for both source and header files, so it's clear which belongs where. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28844 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I61910651bc7c188dc2fb67d96189a66a47e7e8fb Gerrit-Change-Number: 28844 Gerrit-PatchSet: 7 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 10:00:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Log info about messages received and trasmitted

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 ) Change subject: sbcap: Log info about messages received and trasmitted ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/0aa5e733_16e87242 PS2, Line 8: > it's about a hint to me where i can account the review work to agreed with Neels, it's very helpful to have a ticket for figuring out the related account, makes code review process easier. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ifd1eca79bf4fac63de8066cd6a18004138d51d04 Gerrit-Change-Number: 28819 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 09:59:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

by laforge

Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 3: Code-Review-1 (3 comments) Patchset: PS3: IMHO the (value|omit) template designators are mandatory. We use them everywhere, except maybe code written in the first few months of TTCN-3 usage in Osmocom, when we didn't understand them yet. File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/244062b0_ec1a… PS1, Line 18: type enumerated e_PFCP_Cause { > I thought it was in our library/ dir, then it's fine you can keep it in Templates. Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/dc716423_0162… PS1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP { > marking as (value) means you cannot pass a template containing a field which is not set to a value, […] I agree that those annotations are a very useful tool and allow to detect a number of issues already at compile time, which otherwise are only caught at runtime (if at all). Just like the use of "const" in C, or the use of type annotations in python. There are good reasons to use them, and hence we use all of the above, in the respective language. Nobody has ever started to debate about it until this discussion here. Another way to think of it is something like "compile-time invariant checks", if that helps. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 09:54:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-ci[master]: obs-mirror-include.txt: drop latest/Debian_9.0

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28879 ) Change subject: obs-mirror-include.txt: drop latest/Debian_9.0 ...................................................................... obs-mirror-include.txt: drop latest/Debian_9.0 Don't attempt to sync Debian_9.0, as we are not building for it anymore and it doesn't exist anymore. https://download.opensuse.org/repositories/network:/osmocom:/latest/ This should fix the verify-obs-mirror job. Change-Id: I25ba2790a8ae6a54068b8ad4035a669f48795509 --- M contrib/obs-mirror/obs-mirror-include.txt 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/79/28879/1 diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt index ba1b3f3..6427401 100644 --- a/contrib/obs-mirror/obs-mirror-include.txt +++ b/contrib/obs-mirror/obs-mirror-include.txt @@ -1,6 +1,5 @@ latest/CentOS_7 latest/CentOS_8 -latest/Debian_9.0 latest/Debian_10 latest/Debian_11 latest/Raspbian_10 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28879 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I25ba2790a8ae6a54068b8ad4035a669f48795509 Gerrit-Change-Number: 28879 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 10 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: add library/PFCP_*, deps/PFCP

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 ) Change subject: add library/PFCP_*, deps/PFCP ...................................................................... Patch Set 3: (3 comments) File library/PFCP_CodecPort_CtrlFunct.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/76f2f4d3_d395… PS1, Line 7: inout PFCP_PT portRef, > yes, i most definitely copied it, because i would not have had a clue how to structure a new kind of […] Ack File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/bfea1ff6_5ca4… PS1, Line 18: type enumerated e_PFCP_Cause { > was going to move now but noticed that PFCP_Types.ttcn is from deps/titan.ProtocolModules.PFCP_v15. […] I thought it was in our library/ dir, then it's fine you can keep it in Templates. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/1c12fe40_6612… PS1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP { > honestly i'd like to know. i don't see constrictions nor errors with these templates. […] marking as (value) means you cannot pass a template containing a field which is not set to a value, aka ? or *, which means the compiler shouldn't allow you passing a tr_ template in there. Similarly, (present) prevents people from passing omit to a function not expecting it. Furthermore, it clarifies to the reader what is expected to be passed there. This kinda "nullable" mark some languages have, which allows knowing whether passing a null pointer is accepted or not. Having correct restrictions properly written also translate to work hours spent by all others. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0723b931b3f755ea291bffa2f27c34ba446c2f2f Gerrit-Change-Number: 28817 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 09:38:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Log info about messages received and trasmitted

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28819 ) Change subject: sbcap: Log info about messages received and trasmitted ...................................................................... Patch Set 3: (1 comment) File src/sbcap/sbcap_common.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28819/comment/12274a88_474e90cb PS2, Line 162: static char pdu_name[256] = "<unknown>"; > hmm. […] One thing is building up library APIs on top of static buffers and the other one is adding a small static buffer at the application level. I see no problem with this here. It can later be changed by anybody if really feels it's a problem since it's in the app itself. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28819 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ifd1eca79bf4fac63de8066cd6a18004138d51d04 Gerrit-Change-Number: 28819 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 09:32:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: sbcap: Fix NULL pointer dereference

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28877 ) Change subject: sbcap: Fix NULL pointer dereference ...................................................................... sbcap: Fix NULL pointer dereference Related: Coverity CID#275347 Change-Id: I9ae1cad4ce4e3fe6cfd67ac6058fb7345a3dd49e --- M src/sbcap_link_fsm.c 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/sbcap_link_fsm.c b/src/sbcap_link_fsm.c index 685ce7d..3b929ed 100644 --- a/src/sbcap_link_fsm.c +++ b/src/sbcap_link_fsm.c @@ -302,12 +302,13 @@ LOGPSBCAPC(link, LOGL_ERROR, "SBcAP initiatingMessage procedure=%ld not implemented?\n", pdu->choice.initiatingMessage.procedureCode); err_ind_pdu = sbcap_gen_error_ind(link, SBcAP_Cause_valid_message_not_identified, pdu); - if (err_ind_pdu) - cbc_sbcap_link_tx(link, err_ind_pdu); - else + if (!err_ind_pdu) { LOGPSBCAPC(link, LOGL_ERROR, - "Tx SBc-AP %s: msg gen failed\n", - sbcap_pdu_get_name(err_ind_pdu)); + "Tx SBc-AP Error-Indication: msg gen failed\n"); + } else if (cbc_sbcap_link_tx(link, err_ind_pdu) < 0) { + LOGPSBCAPC(link, LOGL_ERROR, + "Tx SBc-AP Error-Indication failed\n"); + } return 0; } break; -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28877 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I9ae1cad4ce4e3fe6cfd67ac6058fb7345a3dd49e Gerrit-Change-Number: 28877 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: cbsp/sbcap: Fix memleak in error condition (tx without link)

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28878 ) Change subject: cbsp/sbcap: Fix memleak in error condition (tx without link) ...................................................................... cbsp/sbcap: Fix memleak in error condition (tx without link) Change-Id: I95f6ab4e642529afc583b0747450b83af1e8f32e --- M src/cbsp_link.c M src/sbcap_link.c 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/cbsp_link.c b/src/cbsp_link.c index a6462ee..5587f58 100644 --- a/src/cbsp_link.c +++ b/src/cbsp_link.c @@ -325,6 +325,7 @@ if (!link) { LOGP(DCBSP, LOGL_NOTICE, "Cannot transmit %s: no connection\n", get_value_string(cbsp_msg_type_names, cbsp->msg_type)); + talloc_free(cbsp); return -ENOLINK; } diff --git a/src/sbcap_link.c b/src/sbcap_link.c index b2a5aa2..07ada0c 100644 --- a/src/sbcap_link.c +++ b/src/sbcap_link.c @@ -392,7 +392,8 @@ if (!link) { LOGP(DSBcAP, LOGL_NOTICE, "Cannot transmit msg %s: no connection\n", sbcap_pdu_get_name(pdu)); - return -ENOLINK; + rc = -ENOLINK; + goto ret_free; } LOGPSBCAPC(link, LOGL_INFO, "Tx msg %s\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28878 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I95f6ab4e642529afc583b0747450b83af1e8f32e Gerrit-Change-Number: 28878 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 10 months

1
0
0 0

Change in osmo-cbc[master]: cbsp/sbcap: Fix memleak in error condition (tx without link)

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28878 ) Change subject: cbsp/sbcap: Fix memleak in error condition (tx without link) ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28878 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I95f6ab4e642529afc583b0747450b83af1e8f32e Gerrit-Change-Number: 28878 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 01 Aug 2022 09:29:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022