laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28974 )
Change subject: bts_nokia_site: Implement channel config for CBCH
......................................................................
bts_nokia_site: Implement channel config for CBCH
Thanks to manawyrm for pointing out that the comments of the file
actually contained the numeric codes for the CBCH variants, but the
cases in the switch statements were missing.
Change-Id: Id5b4da6838f9a34db39fff5c23ad18822cd3347b
---
M src/osmo-bsc/bts_nokia_site.c
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
manawyrm: Looks good to me, approved; Verified
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c
index 4895e6e..2028009 100644
--- a/src/osmo-bsc/bts_nokia_site.c
+++ b/src/osmo-bsc/bts_nokia_site.c
@@ -797,6 +797,9 @@
case GSM_PCHAN_CCCH_SDCCH4:
chan_config = 1;
break;
+ case GSM_PCHAN_CCCH_SDCCH4_CBCH:
+ chan_config = 3;
+ break;
case GSM_PCHAN_TCH_F:
chan_config = 6; /* 9 should work too */
break;
@@ -806,6 +809,9 @@
case GSM_PCHAN_SDCCH8_SACCH8C:
chan_config = 4;
break;
+ case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
+ chan_config = 5;
+ break;
case GSM_PCHAN_PDCH:
chan_config = 11;
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28974
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id5b4da6838f9a34db39fff5c23ad18822cd3347b
Gerrit-Change-Number: 28974
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: manawyrm <osmocom.account(a)tbspace.de>
Gerrit-MessageType: merged
laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28974 )
Change subject: bts_nokia_site: Implement channel config for CBCH
......................................................................
bts_nokia_site: Implement channel config for CBCH
Thanks to manawyrm for pointing out that the comments of the file
actually contained the numeric codes for the CBCH variants, but the
cases in the switch statements were missing.
Change-Id: Id5b4da6838f9a34db39fff5c23ad18822cd3347b
---
M src/osmo-bsc/bts_nokia_site.c
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/74/28974/1
diff --git a/src/osmo-bsc/bts_nokia_site.c b/src/osmo-bsc/bts_nokia_site.c
index 4895e6e..2028009 100644
--- a/src/osmo-bsc/bts_nokia_site.c
+++ b/src/osmo-bsc/bts_nokia_site.c
@@ -797,6 +797,9 @@
case GSM_PCHAN_CCCH_SDCCH4:
chan_config = 1;
break;
+ case GSM_PCHAN_CCCH_SDCCH4_CBCH:
+ chan_config = 3;
+ break;
case GSM_PCHAN_TCH_F:
chan_config = 6; /* 9 should work too */
break;
@@ -806,6 +809,9 @@
case GSM_PCHAN_SDCCH8_SACCH8C:
chan_config = 4;
break;
+ case GSM_PCHAN_SDCCH8_SACCH8C_CBCH:
+ chan_config = 5;
+ break;
case GSM_PCHAN_PDCH:
chan_config = 11;
break;
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28974
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id5b4da6838f9a34db39fff5c23ad18822cd3347b
Gerrit-Change-Number: 28974
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: newchange
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28972 )
Change subject: Depend on libosmocsn1 and libosmo-gprs-rlcmac
......................................................................
Depend on libosmocsn1 and libosmo-gprs-rlcmac
Change-Id: Icba62ad8649e78acab711392dfd74fe571474381
---
M configure.ac
M contrib/osmo-pcu.spec.in
M debian/control
M src/Makefile.am
M src/bts.cpp
M src/bts.h
D src/csn1.c
D src/csn1.h
D src/csn1_dec.c
D src/csn1_enc.c
M src/decoding.h
M src/encoding.h
M src/gprs_bssgp_pcu.c
M src/gprs_ms.h
M src/gprs_rlcmac.h
D src/gsm_rlcmac.c
D src/gsm_rlcmac.h
M src/nacc_fsm.c
M src/pdch.cpp
M src/pdch.h
M src/tbf.cpp
M src/tbf_dl_ass_fsm.c
M src/tbf_ul_ass_fsm.c
D src/wireshark_compat.h
M tests/Makefile.am
D tests/rlcmac/RLCMACTest.cpp
D tests/rlcmac/RLCMACTest.err
D tests/rlcmac/RLCMACTest.ok
M tests/tbf/TbfTest.cpp
M tests/testsuite.at
30 files changed, 55 insertions(+), 16,265 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/72/28972/1
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28972
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Icba62ad8649e78acab711392dfd74fe571474381
Gerrit-Change-Number: 28972
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/28967 )
Change subject: Makefile.am: add 'debian' to EXTRA_DIST
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/28967
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Idbadc505b4149ea16f86cb4afcf6c9d291a8524c
Gerrit-Change-Number: 28967
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 07 Aug 2022 15:09:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: fixeria.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/28966 )
Change subject: debian: fix a typo in 'rules': s/csn10/csn1-0/
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/28966
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: Ic28ed41f076b460e3f89d0754c1c70ff239642f8
Gerrit-Change-Number: 28966
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 07 Aug 2022 15:08:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment