August 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-pfcp[master]: contrib/libosmo-pfcp.spec.in: do not disable LTO

by pespin

Attention is currently required from: osmith, neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/28961 ) Change subject: contrib/libosmo-pfcp.spec.in: do not disable LTO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/28961 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I632cfd8deaaaa50f0ffba04aca4d422b7b51034e Gerrit-Change-Number: 28961 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 08:21:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: allow populating global SACCH cache via L1CTL

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28874 ) Change subject: trxcon: allow populating global SACCH cache via L1CTL ...................................................................... Patch Set 2: (2 comments) File src/host/trxcon/src/l1ctl.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28874/comment/997a23e7_91a1e721 PS1, Line 655: if (!traffic && req.link_id == 0x40) > can you describe this 0x40? I'm sure we may have some sort of defines for it? I added a comment: 0x40 means SACCH. Unfortunately there is no macro in libosmocore... File src/host/trxcon/src/trxcon_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28874/comment/1045c3cc_b52c168d PS1, Line 90: LOGPFSML(fi, LOGL_ERROR, "Unexpected link_id=%u\n", req->link_id); > probably want to print as hex Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0f467fc07cf844cc73465f235b36ba7d00788c9f Gerrit-Change-Number: 28874 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 08:04:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: rework TRXC/TRXD cleanup logic, add trx_fsm_cleanup_cb()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28861 ) Change subject: trxcon: rework TRXC/TRXD cleanup logic, add trx_fsm_cleanup_cb() ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/trx_if.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28861/comment/e3dad05e_831131c2 PS1, Line 746: talloc_reparent(trxcon, trx->fi, trx); > This is all a bit convoluted. […] I am fine with the current approach. Given that nobody else commented, I will keep the patch as is. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ic599b51067cb5a331fca521a5b46ab0a2804e499 Gerrit-Change-Number: 28861 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 07:58:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: improve L1CTL connection related logging

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28864 ) Change subject: trxcon: improve L1CTL connection related logging ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/l1ctl_server.c: https://gerrit.osmocom.org/c/osmocom-bb/+/28864/comment/816728b3_39761571 PS1, Line 56: "L1CTL connection closed by remote peer\n"); > I think you are taking for granted too much in here saying it was closed by remote peer. Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie932513f93fd7f1a5f5e70f4d78235551f7599c8 Gerrit-Change-Number: 28864 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 08 Aug 2022 07:56:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: cosmetic: rename TRXCON_EV_{L1IF->PHYIF}_FAILURE

by fixeria

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28860 to look at the new patch set (#2). Change subject: trxcon: cosmetic: rename TRXCON_EV_{L1IF->PHYIF}_FAILURE ...................................................................... trxcon: cosmetic: rename TRXCON_EV_{L1IF->PHYIF}_FAILURE Basically, everything below layer 2 is layer 1. Let's clarify the domain of TRXCON_EV_L1IF_FAILURE by saying 'PHYIF' instead of 'L1IF'. Change-Id: I9159492a04bc071b7b04d9b88d4e6fd13cc3af31 --- M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/trx_if.c M src/host/trxcon/src/trxcon_fsm.c 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/60/28860/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28860 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9159492a04bc071b7b04d9b88d4e6fd13cc3af31 Gerrit-Change-Number: 28860 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: improve L1CTL connection related logging

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28864 to look at the new patch set (#2). Change subject: trxcon: improve L1CTL connection related logging ...................................................................... trxcon: improve L1CTL connection related logging * l1ctl_client_conn_close(): log "Closing L1CTL connection"; * l1ctl_client_read_cb(): more precise logging, use strerror(). Change-Id: Ie932513f93fd7f1a5f5e70f4d78235551f7599c8 Related: OS#5599 --- M src/host/trxcon/src/l1ctl_server.c 1 file changed, 11 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/64/28864/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie932513f93fd7f1a5f5e70f4d78235551f7599c8 Gerrit-Change-Number: 28864 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: cosmetic: rename TRXCON_EV_SET_{PHY_}CONFIG_REQ

by fixeria

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28859 to look at the new patch set (#2). Change subject: trxcon: cosmetic: rename TRXCON_EV_SET_{PHY_}CONFIG_REQ ...................................................................... trxcon: cosmetic: rename TRXCON_EV_SET_{PHY_}CONFIG_REQ Make it clear that this event is used for setting *PHY* configuration. Change-Id: Ib70ff0352b6fcb045d0f49535dfb0d273856f3c3 --- M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/trxcon_fsm.c 3 files changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/59/28859/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28859 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ib70ff0352b6fcb045d0f49535dfb0d273856f3c3 Gerrit-Change-Number: 28859 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: allow populating global SACCH cache via L1CTL

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28874 to look at the new patch set (#2). Change subject: trxcon: allow populating global SACCH cache via L1CTL ...................................................................... trxcon: allow populating global SACCH cache via L1CTL Change-Id: I0f467fc07cf844cc73465f235b36ba7d00788c9f Related: OS#5635, OS#5599 --- M src/host/trxcon/include/osmocom/bb/l1sched/l1sched.h M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/sched_prim.c M src/host/trxcon/src/sched_trx.c M src/host/trxcon/src/trxcon_fsm.c 6 files changed, 75 insertions(+), 63 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/74/28874/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28874 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I0f467fc07cf844cc73465f235b36ba7d00788c9f Gerrit-Change-Number: 28874 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: handle l1sched_config_req via TRXCON_EV_SET_PHY_CONFIG_REQ

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/28863 to look at the new patch set (#2). Change subject: trxcon: handle l1sched_config_req via TRXCON_EV_SET_PHY_CONFIG_REQ ...................................................................... trxcon: handle l1sched_config_req via TRXCON_EV_SET_PHY_CONFIG_REQ Calling l1sched_free() from trxcon_fsm_pre_term_cb() may result in l1sched_handle_config_req() being called when trxcon->phyif is NULL. Handling l1sched_config_req via TRXCON_EV_SET_PHY_CONFIG_REQ guards us against NULL pointer dereference during teardown of a trxcon_fsm instance, if it's caused by TRXCON_EV_PHYIF_FAILURE. Change-Id: I44bbc695e8a406a7acb9c163bf223f4ea966ea12 Related: OS#5599 --- M src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/src/l1ctl.c M src/host/trxcon/src/trxcon.c M src/host/trxcon/src/trxcon_fsm.c 4 files changed, 43 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/63/28863/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I44bbc695e8a406a7acb9c163bf223f4ea966ea12 Gerrit-Change-Number: 28863 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 10 months

1
0
0 0

Build failure of network:osmocom:latest/libgtpnl in openSUSE_Factory_ARM/aarch64

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:latest/li… Package network:osmocom:latest/libgtpnl failed to build in openSUSE_Factory_ARM/aarch64 Check out the package for editing: osc checkout network:osmocom:latest libgtpnl Last lines of build log: [ 58s] libtool: warning: '../src/libgtpnl.la' has not been installed in '/usr/lib64' [ 58s] libtool: install: /usr/bin/install -c .libs/gtp-link /home/abuild/rpmbuild/BUILDROOT/libgtpnl-1.2.3-1.3.aarch64/usr/bin/gtp-link [ 58s] libtool: warning: '../src/libgtpnl.la' has not been installed in '/usr/lib64' [ 58s] libtool: install: /usr/bin/install -c .libs/gtp-tunnel /home/abuild/rpmbuild/BUILDROOT/libgtpnl-1.2.3-1.3.aarch64/usr/bin/gtp-tunnel [ 58s] make[2]: Nothing to be done for 'install-data-am'. [ 58s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/libgtpnl-1.2.3/tools' [ 58s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/libgtpnl-1.2.3/tools' [ 58s] make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/libgtpnl-1.2.3' [ 58s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/libgtpnl-1.2.3' [ 58s] make[2]: Nothing to be done for 'install-exec-am'. [ 58s] /usr/bin/mkdir -p '/home/abuild/rpmbuild/BUILDROOT/libgtpnl-1.2.3-1.3.aarch64/usr/lib64/pkgconfig' [ 58s] /usr/bin/install -c -m 644 libgtpnl.pc '/home/abuild/rpmbuild/BUILDROOT/libgtpnl-1.2.3-1.3.aarch64/usr/lib64/pkgconfig' [ 58s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/libgtpnl-1.2.3' [ 58s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/libgtpnl-1.2.3' [ 58s] + find /home/abuild/rpmbuild/BUILDROOT/libgtpnl-1.2.3-1.3.aarch64 -type f -name '*.la' -delete -print [ 58s] /home/abuild/rpmbuild/BUILDROOT/libgtpnl-1.2.3-1.3.aarch64/usr/lib64/libgtpnl.la [ 58s] + /usr/lib/rpm/find-debuginfo -j4 --build-id-seed 1.2.3-1.3 --unique-debug-suffix -1.2.3-1.3.aarch64 --unique-debug-src-base libgtpnl-1.2.3-1.3.aarch64 --run-dwz --dwz-low-mem-die-limit 10000000 --dwz-max-die-limit 50000000 -S debugsourcefiles.list /home/abuild/rpmbuild/BUILD/libgtpnl-1.2.3 [ 58s] /var/tmp/rpm-tmp.6ihEZK: line 39: /usr/lib/rpm/find-debuginfo: No such file or directory [ 58s] error: Bad exit status from /var/tmp/rpm-tmp.6ihEZK (%install) [ 58s] [ 58s] RPM build errors: [ 58s] Bad exit status from /var/tmp/rpm-tmp.6ihEZK (%install) [ 58s] ### VM INTERACTION START ### [ 59s] [ 51.674582][ T1] sysrq: Power Off [ 59s] [ 51.675253][ T386] reboot: Power down [ 59s] ### VM INTERACTION END ### [ 59s] [ 59s] obs-arm-7 failed "build libgtpnl.spec" at Mon Aug 8 07:42:37 UTC 2022. [ 59s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 10 months

1
0
0 0

2025

2024

2023

2022

gerrit-log August 2022