July 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by laforge

Attention is currently required from: pespin, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Jul 2022 12:27:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by laforge

Attention is currently required from: pespin, fixeria. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... Removed Code-Review-1 by fixeria <vyanitskiy(a)sysmocom.de> -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: deleteVote

1 year, 10 months

1
0
0 0

Change in libosmo-netif[master]: rtp: Delay rtph ptr assign after validating length

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28479 ) Change subject: rtp: Delay rtph ptr assign after validating length ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-netif/+/28479/comment/1baeb40d_896b8b4a PS1, Line 9: Make coverity happy > It still makes more sense to do it this way from procedural/logical point of view, so I don't see wh […] Agreed with Pau. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I5d457183043d4c902f473b828815b9c62a01d47d Gerrit-Change-Number: 28479 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 05 Jul 2022 11:44:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-cbc[master]: Move header files to include/osmocom/cbc/ dir

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28516 ) Change subject: Move header files to include/osmocom/cbc/ dir ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > would be interesting to state why (I guess for consistency with our other projects?) […] Yes, consistency with all other projects. Furthermore, we'll have more headers soon (include/osmocom/sbcap) so it made everything more aligned. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3 Gerrit-Change-Number: 28516 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 05 Jul 2022 08:16:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28515 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... fixup: coverity: compile tests, but not execute them In change 82265bc46df2f5c54be71274330e43664cf6c7fc [1] I attempted to fix aaeab8c976a478309477e4200c1aef51407f6152 [2], however both pushd and popd commands are not available in plain shell. Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Fixes: [1] I92b648cd1e80399561067eae99426faed1ff1e25 Fixes: [2] Idf0714a59356633021be21acc47f9471d059b7fe --- M coverity/prepare_source_Osmocom.sh 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index ba5f13a..11b7e5c 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -52,9 +52,7 @@ # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. files="$(git -C $proj grep -l check_PROGRAMS)" if [ -n "$files" ]; then - pushd $proj - sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files - popd + (cd $proj && sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files) fi done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Gerrit-Change-Number: 28515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28515 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > you could also simply have switched to bash? That would indeed make scripting a bit more comfortable. But most of the existing scripts seem to be using '/bin/sh', so I don't want to introduce inconsistency. I can tolerate the limits of '/bin/sh' given the low amount of my occasional contributions to osmo-ci :) -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Gerrit-Change-Number: 28515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:43:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28515 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: you could also simply have switched to bash? -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Gerrit-Change-Number: 28515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:27:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-cbc[master]: Move header files to include/osmocom/cbc/ dir

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28516 ) Change subject: Move header files to include/osmocom/cbc/ dir ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: would be interesting to state why (I guess for consistency with our other projects?) I personally think they should actually all be in src and only public (library) headers should be in include/osmocom/* :P -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3 Gerrit-Change-Number: 28516 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:26:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc/Makefile.am: fix undefined reference to symbol pow()

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28519 ) Change subject: osmo-bsc/Makefile.am: fix undefined reference to symbol pow() ...................................................................... osmo-bsc/Makefile.am: fix undefined reference to symbol pow() When trying to build osmo-bsc using clang 14, I am getting this error: make[3]: Entering directory 'src/osmo-bsc' CCLD osmo-bsc /usr/bin/ld: ./.libs/libbsc.a(handover_decision_2.o): undefined reference to symbol 'pow@@GLIBC_2.29' /usr/bin/ld: /usr/lib/libm.so.6: error adding symbols: DSO missing from command line clang-14: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [Makefile:656: osmo-bsc] Error 1 We need to link with the math library to resolve this. Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 --- M src/osmo-bsc/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am index 557178e..f075580 100644 --- a/src/osmo-bsc/Makefile.am +++ b/src/osmo-bsc/Makefile.am @@ -122,6 +122,7 @@ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ $(LIBOSMOMGCPCLIENT_LIBS) \ + -lm \ $(NULL) bin_PROGRAMS = \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 Gerrit-Change-Number: 28519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmo-bsc[master]: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28518 ) Change subject: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized ...................................................................... lchan_select: fix 'chan_alloc_reverse' may be used uninitialized GCC 12.1.0 emits -Wmaybe-uninitialized when building with '-O2'. In function 'populate_ts_list', inlined from 'lchan_avail_by_type' at src/osmo-bsc/lchan_select.c:356:2: src/osmo-bsc/lchan_select.c:248:12: warning: 'chan_alloc_reverse' may be used uninitialized [-Wmaybe-uninitialized] 248 | if (chan_alloc_reverse) { | ^ src/osmo-bsc/lchan_select.c: In function 'lchan_avail_by_type': src/osmo-bsc/lchan_select.c:326:14: note: 'chan_alloc_reverse' was declared here 326 | bool chan_alloc_reverse; | ^~~~~~~~~~~~~~~~~~ This could only happen if in 'enum lchan_select_reason' we had items that are not handled in lchan_avail_by_type(), but this is not the case. Make GCC happy by initializing chan_alloc_reverse to false. Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 --- M src/osmo-bsc/lchan_select.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c index ebc7ede..0ccdb6a 100644 --- a/src/osmo-bsc/lchan_select.c +++ b/src/osmo-bsc/lchan_select.c @@ -323,7 +323,7 @@ enum gsm_phys_chan_config first, first_cbch, second, second_cbch; struct lchan_select_ts_list ts_list; bool sort_by_trx_power = false; - bool chan_alloc_reverse; + bool chan_alloc_reverse = false; if (log) { LOG_BTS(bts, DRLL, LOGL_DEBUG, "lchan_avail_by_type(type=%s, reason=%s)\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 Gerrit-Change-Number: 28518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc/Makefile.am: fix undefined reference to symbol pow()

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28519 ) Change subject: osmo-bsc/Makefile.am: fix undefined reference to symbol pow() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 Gerrit-Change-Number: 28519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:25:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-bsc[master]: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28518 ) Change subject: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 Gerrit-Change-Number: 28518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 18:25:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc/Makefile.am: fix undefined reference to symbol pow()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28519 ) Change subject: osmo-bsc/Makefile.am: fix undefined reference to symbol pow() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 Gerrit-Change-Number: 28519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 16:25:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-bsc[master]: osmo-bsc/Makefile.am: fix undefined reference to symbol pow()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28519 ) Change subject: osmo-bsc/Makefile.am: fix undefined reference to symbol pow() ...................................................................... osmo-bsc/Makefile.am: fix undefined reference to symbol pow() When trying to build osmo-bsc using clang 14, I am getting this error: make[3]: Entering directory 'src/osmo-bsc' CCLD osmo-bsc /usr/bin/ld: ./.libs/libbsc.a(handover_decision_2.o): undefined reference to symbol 'pow@@GLIBC_2.29' /usr/bin/ld: /usr/lib/libm.so.6: error adding symbols: DSO missing from command line clang-14: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [Makefile:656: osmo-bsc] Error 1 We need to link with the math library to resolve this. Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 --- M src/osmo-bsc/Makefile.am 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/28519/1 diff --git a/src/osmo-bsc/Makefile.am b/src/osmo-bsc/Makefile.am index 557178e..f075580 100644 --- a/src/osmo-bsc/Makefile.am +++ b/src/osmo-bsc/Makefile.am @@ -122,6 +122,7 @@ $(LIBOSMOABIS_LIBS) \ $(LIBOSMOSIGTRAN_LIBS) \ $(LIBOSMOMGCPCLIENT_LIBS) \ + -lm \ $(NULL) bin_PROGRAMS = \ -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28519 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4137cad07a3343882ca77d5ebd5137083941dc11 Gerrit-Change-Number: 28519 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 10 months

1
0
0 0

Change in osmo-bsc[master]: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28518 ) Change subject: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 Gerrit-Change-Number: 28518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 14:28:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-bsc[master]: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28518 ) Change subject: lchan_select: fix 'chan_alloc_reverse' may be used uninitialized ...................................................................... lchan_select: fix 'chan_alloc_reverse' may be used uninitialized GCC 12.1.0 emits -Wmaybe-uninitialized when building with '-O2'. In function 'populate_ts_list', inlined from 'lchan_avail_by_type' at src/osmo-bsc/lchan_select.c:356:2: src/osmo-bsc/lchan_select.c:248:12: warning: 'chan_alloc_reverse' may be used uninitialized [-Wmaybe-uninitialized] 248 | if (chan_alloc_reverse) { | ^ src/osmo-bsc/lchan_select.c: In function 'lchan_avail_by_type': src/osmo-bsc/lchan_select.c:326:14: note: 'chan_alloc_reverse' was declared here 326 | bool chan_alloc_reverse; | ^~~~~~~~~~~~~~~~~~ This could only happen if in 'enum lchan_select_reason' we had items that are not handled in lchan_avail_by_type(), but this is not the case. Make GCC happy by initializing chan_alloc_reverse to false. Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 --- M src/osmo-bsc/lchan_select.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/18/28518/1 diff --git a/src/osmo-bsc/lchan_select.c b/src/osmo-bsc/lchan_select.c index ebc7ede..0ccdb6a 100644 --- a/src/osmo-bsc/lchan_select.c +++ b/src/osmo-bsc/lchan_select.c @@ -323,7 +323,7 @@ enum gsm_phys_chan_config first, first_cbch, second, second_cbch; struct lchan_select_ts_list ts_list; bool sort_by_trx_power = false; - bool chan_alloc_reverse; + bool chan_alloc_reverse = false; if (log) { LOG_BTS(bts, DRLL, LOGL_DEBUG, "lchan_avail_by_type(type=%s, reason=%s)\n", -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28518 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I3956621a6ec14ca5ff0ba0b11d2c956e2538efd8 Gerrit-Change-Number: 28518 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 10 months

1
0
0 0

Change in libosmocore[master]: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28517 ) Change subject: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() ...................................................................... gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() Jumping to label 'error' before allocating memory and storing an address to pointer 'rim_cont_buf' would result in passing garbage to talloc_free(). Found with clang 14. Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b --- M src/gb/gprs_bssgp_rim.c 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c index 63b303e..71f7ea8 100644 --- a/src/gb/gprs_bssgp_rim.c +++ b/src/gb/gprs_bssgp_rim.c @@ -1064,7 +1064,6 @@ struct msgb *msg = bssgp_msgb_alloc(); struct bssgp_normal_hdr *bgph; uint8_t rim_ri_buf[BSSGP_RIM_ROUTING_INFO_MAXLEN]; - uint8_t *rim_cont_buf; int rc; if (!msg) @@ -1105,7 +1104,7 @@ /* Put RIM container */ if (pdu->decoded_present) { - rim_cont_buf = talloc_zero_size(msg, msg->data_len); + uint8_t *rim_cont_buf = talloc_zero_size(msg, msg->data_len); if (!rim_cont_buf) goto error; @@ -1130,8 +1129,10 @@ /* The API user must set the iei properly! */ OSMO_ASSERT(false); } - if (rc < 0) + if (rc < 0) { + talloc_free(rim_cont_buf); goto error; + } msgb_tvlv_put(msg, pdu->rim_cont_iei, rc, rim_cont_buf); talloc_free(rim_cont_buf); @@ -1143,7 +1144,6 @@ return msg; error: - talloc_free(rim_cont_buf); msgb_free(msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b Gerrit-Change-Number: 28517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in libosmocore[master]: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28517 ) Change subject: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b Gerrit-Change-Number: 28517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 13:56:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in libosmocore[master]: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/28517 ) Change subject: gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() ...................................................................... gb: fix uninitialized ptr access in bssgp_encode_rim_pdu() Jumping to label 'error' before allocating memory and storing an address to pointer 'rim_cont_buf' would result in passing garbage to talloc_free(). Found with clang 14. Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b --- M src/gb/gprs_bssgp_rim.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/17/28517/1 diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c index 63b303e..71f7ea8 100644 --- a/src/gb/gprs_bssgp_rim.c +++ b/src/gb/gprs_bssgp_rim.c @@ -1064,7 +1064,6 @@ struct msgb *msg = bssgp_msgb_alloc(); struct bssgp_normal_hdr *bgph; uint8_t rim_ri_buf[BSSGP_RIM_ROUTING_INFO_MAXLEN]; - uint8_t *rim_cont_buf; int rc; if (!msg) @@ -1105,7 +1104,7 @@ /* Put RIM container */ if (pdu->decoded_present) { - rim_cont_buf = talloc_zero_size(msg, msg->data_len); + uint8_t *rim_cont_buf = talloc_zero_size(msg, msg->data_len); if (!rim_cont_buf) goto error; @@ -1130,8 +1129,10 @@ /* The API user must set the iei properly! */ OSMO_ASSERT(false); } - if (rc < 0) + if (rc < 0) { + talloc_free(rim_cont_buf); goto error; + } msgb_tvlv_put(msg, pdu->rim_cont_iei, rc, rim_cont_buf); talloc_free(rim_cont_buf); @@ -1143,7 +1144,6 @@ return msg; error: - talloc_free(rim_cont_buf); msgb_free(msg); return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28517 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9420615b64d3755fd9131e8561c516c39f83a15b Gerrit-Change-Number: 28517 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 10 months

1
0
0 0

Change in osmo-cbc[master]: Move header files to include/osmocom/cbc/ dir

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28516 ) Change subject: Move header files to include/osmocom/cbc/ dir ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3 Gerrit-Change-Number: 28516 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 11:56:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-cbc[master]: Move header files to include/osmocom/cbc/ dir

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-cbc/+/28516 to look at the new patch set (#2). Change subject: Move header files to include/osmocom/cbc/ dir ...................................................................... Move header files to include/osmocom/cbc/ dir Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3 --- M Makefile.am M configure.ac A include/Makefile.am A include/osmocom/Makefile.am A include/osmocom/cbc/Makefile.am R include/osmocom/cbc/cbc_data.h R include/osmocom/cbc/cbsp_server.h R include/osmocom/cbc/charset.h R include/osmocom/cbc/internal.h R include/osmocom/cbc/rest_it_op.h M src/Makefile.am M src/cbc_data.c M src/cbc_main.c M src/cbc_vty.c M src/cbsp_server.c M src/cbsp_server_fsm.c M src/charset.c M src/message_handling.c M src/rest_api.c M src/rest_it_op.c M src/smscb_message_fsm.c M src/smscb_peer_fsm.c 22 files changed, 47 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/16/28516/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3 Gerrit-Change-Number: 28516 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 10 months

1
0
0 0

Change in osmo-cbc[master]: Move header files to include/osmocom/cbc/ dir

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28516 ) Change subject: Move header files to include/osmocom/cbc/ dir ...................................................................... Move header files to include/osmocom/cbc/ dir Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3 --- M configure.ac A include/Makefile.am A include/osmocom/Makefile.am A include/osmocom/cbc/Makefile.am R include/osmocom/cbc/cbc_data.h R include/osmocom/cbc/cbsp_server.h R include/osmocom/cbc/charset.h R include/osmocom/cbc/internal.h R include/osmocom/cbc/rest_it_op.h M src/Makefile.am M src/cbc_data.c M src/cbc_main.c M src/cbc_vty.c M src/cbsp_server.c M src/cbsp_server_fsm.c M src/charset.c M src/message_handling.c M src/rest_api.c M src/rest_it_op.c M src/smscb_message_fsm.c M src/smscb_peer_fsm.c 21 files changed, 46 insertions(+), 42 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/16/28516/1 diff --git a/configure.ac b/configure.ac index 3f5eaf8..180ab96 100644 --- a/configure.ac +++ b/configure.ac @@ -169,6 +169,9 @@ AC_OUTPUT( src/Makefile + include/Makefile + include/osmocom/Makefile + include/osmocom/cbc/Makefile contrib/Makefile contrib/osmo-cbc.spec tests/Makefile diff --git a/include/Makefile.am b/include/Makefile.am new file mode 100644 index 0000000..3578a80 --- /dev/null +++ b/include/Makefile.am @@ -0,0 +1 @@ +SUBDIRS = osmocom diff --git a/include/osmocom/Makefile.am b/include/osmocom/Makefile.am new file mode 100644 index 0000000..a8e8b9b --- /dev/null +++ b/include/osmocom/Makefile.am @@ -0,0 +1 @@ +SUBDIRS = cbc diff --git a/include/osmocom/cbc/Makefile.am b/include/osmocom/cbc/Makefile.am new file mode 100644 index 0000000..1135800 --- /dev/null +++ b/include/osmocom/cbc/Makefile.am @@ -0,0 +1,7 @@ +noinst_HEADERS = \ + cbc_data.h \ + cbsp_server.h \ + charset.h \ + internal.h \ + rest_it_op.h \ + $(NULL) diff --git a/src/cbc_data.h b/include/osmocom/cbc/cbc_data.h similarity index 100% rename from src/cbc_data.h rename to include/osmocom/cbc/cbc_data.h diff --git a/src/cbsp_server.h b/include/osmocom/cbc/cbsp_server.h similarity index 97% rename from src/cbsp_server.h rename to include/osmocom/cbc/cbsp_server.h index 21367c4..1576864 100644 --- a/src/cbsp_server.h +++ b/include/osmocom/cbc/cbsp_server.h @@ -3,7 +3,7 @@ #include <osmocom/gsm/cbsp.h> #include <osmocom/netif/stream.h> -#include "cbc_data.h" +#include <osmocom/cbc/cbc_data.h> #define LOGPCC(client, level, fmt, args...) \ LOGP(DCBSP, level, "%s: " fmt, cbsp_cbc_client_name(client), ## args) diff --git a/src/charset.h b/include/osmocom/cbc/charset.h similarity index 100% rename from src/charset.h rename to include/osmocom/cbc/charset.h diff --git a/src/internal.h b/include/osmocom/cbc/internal.h similarity index 98% rename from src/internal.h rename to include/osmocom/cbc/internal.h index 29093b5..e3521bd 100644 --- a/src/internal.h +++ b/include/osmocom/cbc/internal.h @@ -5,7 +5,7 @@ #include <osmocom/core/logging.h> #include <osmocom/core/fsm.h> -#include "cbc_data.h" +#include <osmocom/cbc/cbc_data.h> enum { DCBSP, diff --git a/src/rest_it_op.h b/include/osmocom/cbc/rest_it_op.h similarity index 96% rename from src/rest_it_op.h rename to include/osmocom/cbc/rest_it_op.h index f7cc808..94a617e 100644 --- a/src/rest_it_op.h +++ b/include/osmocom/cbc/rest_it_op.h @@ -7,7 +7,7 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/it_q.h> -#include "cbc_data.h" +#include <osmocom/cbc/cbc_data.h> enum rest_it_operation { REST_IT_OP_NONE, diff --git a/src/Makefile.am b/src/Makefile.am index 6f82a54..b59dc1a 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,18 +1,10 @@ -AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/src +AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include AM_CFLAGS=-Wall -g $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOVTY_CFLAGS) \ $(LIBOSMONETIF_CFLAGS) \ $(ULFIUS_CFLAGS) $(JANSSON_CFLAGS) $(ORCANIA_CFLAGS) \ $(COVERAGE_CFLAGS) AM_LDFLAGS=$(COVERAGE_LDFLAGS) -EXTRA_DIST = \ - cbc_data.h \ - cbsp_server.h \ - charset.h \ - internal.h \ - rest_it_op.h \ - $(NULL) - bin_PROGRAMS = osmo-cbc osmo_cbc_SOURCES = \ diff --git a/src/cbc_data.c b/src/cbc_data.c index 60c0998..4b2c831 100644 --- a/src/cbc_data.c +++ b/src/cbc_data.c @@ -28,8 +28,8 @@ #include <osmocom/core/talloc.h> #include <osmocom/core/utils.h> -#include "cbc_data.h" -#include "cbsp_server.h" +#include <osmocom/cbc/cbc_data.h> +#include <osmocom/cbc/cbsp_server.h> const struct value_string cbc_peer_proto_name[] = { { CBC_PEER_PROTO_CBSP, "CBSP" }, diff --git a/src/cbc_main.c b/src/cbc_main.c index 2ce5287..c49514b3 100644 --- a/src/cbc_main.c +++ b/src/cbc_main.c @@ -44,9 +44,9 @@ #include <osmocom/vty/logging.h> #include <osmocom/vty/misc.h> -#include "internal.h" -#include "cbsp_server.h" -#include "cbc_data.h" +#include <osmocom/cbc/internal.h> +#include <osmocom/cbc/cbsp_server.h> +#include <osmocom/cbc/cbc_data.h> static void *tall_cbc_ctx; struct cbc *g_cbc; diff --git a/src/cbc_vty.c b/src/cbc_vty.c index 5d154c6..b07bf70 100644 --- a/src/cbc_vty.c +++ b/src/cbc_vty.c @@ -30,9 +30,9 @@ #include <osmocom/vty/buffer.h> #include <osmocom/vty/vty.h> -#include "cbc_data.h" -#include "internal.h" -#include "cbsp_server.h" +#include <osmocom/cbc/cbc_data.h> +#include <osmocom/cbc/internal.h> +#include <osmocom/cbc/cbsp_server.h> static void dump_one_cbc_peer(struct vty *vty, const struct cbc_peer *peer) { diff --git a/src/cbsp_server.c b/src/cbsp_server.c index c6312dc..215f643 100644 --- a/src/cbsp_server.c +++ b/src/cbsp_server.c @@ -31,8 +31,8 @@ #include <osmocom/gsm/protocol/gsm_48_049.h> #include <osmocom/netif/stream.h> -#include "internal.h" -#include "cbsp_server.h" +#include <osmocom/cbc/internal.h> +#include <osmocom/cbc/cbsp_server.h> #if 0 struct osmo_cbsp_bsc { diff --git a/src/cbsp_server_fsm.c b/src/cbsp_server_fsm.c index b99a80a..903e08a 100644 --- a/src/cbsp_server_fsm.c +++ b/src/cbsp_server_fsm.c @@ -22,8 +22,8 @@ #include <osmocom/gsm/cbsp.h> -#include "cbsp_server.h" -#include "internal.h" +#include <osmocom/cbc/cbsp_server.h> +#include <osmocom/cbc/internal.h> #define S(x) (1 << (x)) diff --git a/src/charset.c b/src/charset.c index efaff8e..2ca4aa3 100644 --- a/src/charset.c +++ b/src/charset.c @@ -24,7 +24,7 @@ #include <osmocom/gsm/gsm_utils.h> #include <osmocom/core/utils.h> -#include "charset.h" +#include <osmocom/cbc/charset.h> /* pad the entire "remainder" of a buffer with repeated instances of the given pad character */ static void pad_with_septets(uint8_t *buf, size_t buf_len, int num_septets, char pad_char) diff --git a/src/message_handling.c b/src/message_handling.c index 8d66d01..a8c8368 100644 --- a/src/message_handling.c +++ b/src/message_handling.c @@ -27,10 +27,10 @@ #include <osmocom/core/utils.h> #include <osmocom/gsm/cbsp.h> -#include "cbc_data.h" -#include "cbsp_server.h" -#include "rest_it_op.h" -#include "internal.h" +#include <osmocom/cbc/cbc_data.h> +#include <osmocom/cbc/cbsp_server.h> +#include <osmocom/cbc/rest_it_op.h> +#include <osmocom/cbc/internal.h> /* convert cbc_message to osmo_cbsp_cell_list */ static int cbcmsg_to_cbsp_cell_list(const void *ctx, struct osmo_cbsp_cell_list *list, diff --git a/src/rest_api.c b/src/rest_api.c index 52bf25e..a779f3d 100644 --- a/src/rest_api.c +++ b/src/rest_api.c @@ -37,10 +37,10 @@ #define PREFIX "/api/ecbe/v1" -#include "internal.h" -#include "charset.h" -#include "cbc_data.h" -#include "rest_it_op.h" +#include <osmocom/cbc/internal.h> +#include <osmocom/cbc/charset.h> +#include <osmocom/cbc/cbc_data.h> +#include <osmocom/cbc/rest_it_op.h> /* get an integer value for field "key" in object "parent" */ static int json_get_integer(int *out, json_t *parent, const char *key) diff --git a/src/rest_it_op.c b/src/rest_it_op.c index a91c758..ae1aaff 100644 --- a/src/rest_it_op.c +++ b/src/rest_it_op.c @@ -26,8 +26,8 @@ #include <osmocom/core/linuxlist.h> #include <osmocom/core/it_q.h> -#include "rest_it_op.h" -#include "internal.h" +#include <osmocom/cbc/rest_it_op.h> +#include <osmocom/cbc/internal.h> /*********************************************************************** * HTTP THREAD diff --git a/src/smscb_message_fsm.c b/src/smscb_message_fsm.c index 0dd1f13..04b0718 100644 --- a/src/smscb_message_fsm.c +++ b/src/smscb_message_fsm.c @@ -30,10 +30,10 @@ #include <osmocom/gsm/gsm0808_utils.h> #include <osmocom/gsm/cbsp.h> -#include "cbc_data.h" -#include "cbsp_server.h" -#include "internal.h" -#include "rest_it_op.h" +#include <osmocom/cbc/cbc_data.h> +#include <osmocom/cbc/cbsp_server.h> +#include <osmocom/cbc/internal.h> +#include <osmocom/cbc/rest_it_op.h> #define S(x) (1 << (x)) diff --git a/src/smscb_peer_fsm.c b/src/smscb_peer_fsm.c index 21f17e6..510c198 100644 --- a/src/smscb_peer_fsm.c +++ b/src/smscb_peer_fsm.c @@ -32,9 +32,9 @@ #include <osmocom/gsm/gsm0808_utils.h> #include <osmocom/gsm/cbsp.h> -#include "cbc_data.h" -#include "cbsp_server.h" -#include "internal.h" +#include <osmocom/cbc/cbc_data.h> +#include <osmocom/cbc/cbsp_server.h> +#include <osmocom/cbc/internal.h> #define S(x) (1 << (x)) -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28516 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Id6c9f99805169d624a2c6e001fe1983e24fdc5c3 Gerrit-Change-Number: 28516 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28515 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Gerrit-Change-Number: 28515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 10:27:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28515 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... fixup: coverity: compile tests, but not execute them In change 82265bc46df2f5c54be71274330e43664cf6c7fc [1] I attempted to fix aaeab8c976a478309477e4200c1aef51407f6152 [2], however both pushd and popd commands are not available in plain shell. Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Fixes: [1] I92b648cd1e80399561067eae99426faed1ff1e25 Fixes: [2] Idf0714a59356633021be21acc47f9471d059b7fe --- M coverity/prepare_source_Osmocom.sh 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/15/28515/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index ba5f13a..11b7e5c 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -52,9 +52,7 @@ # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. files="$(git -C $proj grep -l check_PROGRAMS)" if [ -n "$files" ]; then - pushd $proj - sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files - popd + (cd $proj && sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files) fi done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28515 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ib63ded66781c774e16773537c3b943237904b03e Gerrit-Change-Number: 28515 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 10 months

1
0
0 0

Change in osmo-msc[master]: Turn off secure_delete in sqlite

by fixeria

Attention is currently required from: keith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28341 ) Change subject: Turn off secure_delete in sqlite ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28341 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9da6499a38096c8df2025bb9d35ec789864b7c5e Gerrit-Change-Number: 28341 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 04 Jul 2022 09:00:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28514 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... fixup: coverity: compile tests, but not execute them Change-Id: I92b648cd1e80399561067eae99426faed1ff1e25 Fixes: Idf0714a59356633021be21acc47f9471d059b7fe --- M coverity/prepare_source_Osmocom.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 22d72e7..ba5f13a 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -52,7 +52,9 @@ # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. files="$(git -C $proj grep -l check_PROGRAMS)" if [ -n "$files" ]; then + pushd $proj sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files + popd fi done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I92b648cd1e80399561067eae99426faed1ff1e25 Gerrit-Change-Number: 28514 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28514 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I92b648cd1e80399561067eae99426faed1ff1e25 Gerrit-Change-Number: 28514 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 08:52:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28514 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I92b648cd1e80399561067eae99426faed1ff1e25 Gerrit-Change-Number: 28514 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 08:52:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: fixup: coverity: compile tests, but not execute them

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28514 ) Change subject: fixup: coverity: compile tests, but not execute them ...................................................................... fixup: coverity: compile tests, but not execute them Change-Id: I92b648cd1e80399561067eae99426faed1ff1e25 Fixes: Idf0714a59356633021be21acc47f9471d059b7fe --- M coverity/prepare_source_Osmocom.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/14/28514/1 diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 22d72e7..ba5f13a 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -52,7 +52,9 @@ # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. files="$(git -C $proj grep -l check_PROGRAMS)" if [ -n "$files" ]; then + pushd $proj sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files + popd fi done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28514 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I92b648cd1e80399561067eae99426faed1ff1e25 Gerrit-Change-Number: 28514 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Makefile.am: fix make {dist,distcheck} targets

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28501 ) Change subject: trxcon: Makefile.am: fix make {dist,distcheck} targets ...................................................................... trxcon: Makefile.am: fix make {dist,distcheck} targets File '.version' must be also listed in EXTRA_DIST, otherwise I get: echo 0.0.0 > ../../.version-t && mv ../../.version-t ../../.version /bin/sh: line 1: ../../.version-t: Permission denied Change-Id: I65f7c505f5a231bab114c45f5fdd7421601dfbc0 Related: OS#5599, OS#3761 --- M src/host/trxcon/Makefile.am 1 file changed, 7 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/host/trxcon/Makefile.am b/src/host/trxcon/Makefile.am index 0c71e97..893d9ab 100644 --- a/src/host/trxcon/Makefile.am +++ b/src/host/trxcon/Makefile.am @@ -44,8 +44,14 @@ $(LIBOSMOGSM_LIBS) \ $(NULL) +BUILT_SOURCES = \ + $(top_srcdir)/.version \ + $(NULL) +EXTRA_DIST = \ + .version \ + $(NULL) + # versioning magic -BUILT_SOURCES = $(top_srcdir)/.version $(top_srcdir)/.version: echo $(VERSION) > $@-t && mv $@-t $@ dist-hook: -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28501 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I65f7c505f5a231bab114c45f5fdd7421601dfbc0 Gerrit-Change-Number: 28501 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: group header files into 'include/osmocom/bb/trxcon'

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28502 ) Change subject: trxcon: group header files into 'include/osmocom/bb/trxcon' ...................................................................... trxcon: group header files into 'include/osmocom/bb/trxcon' This is the first step towards the goal of moving the scheduler into a separate library. Change-Id: Ifa6137c239c215a3d323213ee74d34b419622be4 Related: OS#5599, OS#3761 --- M src/host/trxcon/Makefile.am M src/host/trxcon/configure.ac A src/host/trxcon/include/Makefile.am A src/host/trxcon/include/osmocom/Makefile.am A src/host/trxcon/include/osmocom/bb/Makefile.am A src/host/trxcon/include/osmocom/bb/trxcon/Makefile.am R src/host/trxcon/include/osmocom/bb/trxcon/l1ctl.h R src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h A src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_proto.h R src/host/trxcon/include/osmocom/bb/trxcon/logging.h R src/host/trxcon/include/osmocom/bb/trxcon/sched_trx.h R src/host/trxcon/include/osmocom/bb/trxcon/scheduler.h R src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h R src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h M src/host/trxcon/l1ctl.c M src/host/trxcon/l1ctl_link.c D src/host/trxcon/l1ctl_proto.h M src/host/trxcon/logging.c M src/host/trxcon/sched_clck.c M src/host/trxcon/sched_lchan_common.c M src/host/trxcon/sched_lchan_desc.c M src/host/trxcon/sched_lchan_pdtch.c M src/host/trxcon/sched_lchan_rach.c M src/host/trxcon/sched_lchan_sch.c M src/host/trxcon/sched_lchan_tchf.c M src/host/trxcon/sched_lchan_tchh.c M src/host/trxcon/sched_lchan_xcch.c M src/host/trxcon/sched_mframe.c M src/host/trxcon/sched_prim.c M src/host/trxcon/sched_trx.c M src/host/trxcon/trx_if.c M src/host/trxcon/trxcon.c 32 files changed, 116 insertions(+), 89 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/host/trxcon/Makefile.am b/src/host/trxcon/Makefile.am index 893d9ab..aa0ae56 100644 --- a/src/host/trxcon/Makefile.am +++ b/src/host/trxcon/Makefile.am @@ -1,5 +1,9 @@ AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6 +SUBDIRS = \ + include \ + $(NULL) + AM_CPPFLAGS = \ $(all_includes) \ -I$(top_srcdir)/include \ diff --git a/src/host/trxcon/configure.ac b/src/host/trxcon/configure.ac index 1f24260..0e5ce6f 100644 --- a/src/host/trxcon/configure.ac +++ b/src/host/trxcon/configure.ac @@ -31,5 +31,9 @@ dnl Checks for typedefs, structures and compiler characteristics -AC_OUTPUT( - Makefile) +AC_CONFIG_FILES([include/Makefile + include/osmocom/Makefile + include/osmocom/bb/Makefile + include/osmocom/bb/trxcon/Makefile + Makefile]) +AC_OUTPUT diff --git a/src/host/trxcon/include/Makefile.am b/src/host/trxcon/include/Makefile.am new file mode 100644 index 0000000..9d963a0 --- /dev/null +++ b/src/host/trxcon/include/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + osmocom \ + $(NULL) diff --git a/src/host/trxcon/include/osmocom/Makefile.am b/src/host/trxcon/include/osmocom/Makefile.am new file mode 100644 index 0000000..83c6385 --- /dev/null +++ b/src/host/trxcon/include/osmocom/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + bb \ + $(NULL) diff --git a/src/host/trxcon/include/osmocom/bb/Makefile.am b/src/host/trxcon/include/osmocom/bb/Makefile.am new file mode 100644 index 0000000..008a966 --- /dev/null +++ b/src/host/trxcon/include/osmocom/bb/Makefile.am @@ -0,0 +1,3 @@ +SUBDIRS = \ + trxcon \ + $(NULL) diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/Makefile.am b/src/host/trxcon/include/osmocom/bb/trxcon/Makefile.am new file mode 100644 index 0000000..e506520 --- /dev/null +++ b/src/host/trxcon/include/osmocom/bb/trxcon/Makefile.am @@ -0,0 +1,10 @@ +noinst_HEADERS = \ + l1ctl_proto.h \ + l1ctl_link.h \ + l1ctl.h \ + scheduler.h \ + sched_trx.h \ + trx_if.h \ + logging.h \ + trxcon.h \ + $(NULL) diff --git a/src/host/trxcon/l1ctl.h b/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl.h similarity index 90% rename from src/host/trxcon/l1ctl.h rename to src/host/trxcon/include/osmocom/bb/trxcon/l1ctl.h index 48bbe09..f93908d 100644 --- a/src/host/trxcon/l1ctl.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl.h @@ -3,8 +3,8 @@ #include <stdint.h> #include <osmocom/core/msgb.h> -#include "l1ctl_link.h" -#include "l1ctl_proto.h" +#include <osmocom/bb/trxcon/l1ctl_link.h> +#include <osmocom/bb/trxcon/l1ctl_proto.h> /* Event handlers */ int l1ctl_rx_cb(struct l1ctl_link *l1l, struct msgb *msg); diff --git a/src/host/trxcon/l1ctl_link.h b/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h similarity index 100% rename from src/host/trxcon/l1ctl_link.h rename to src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_link.h diff --git a/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_proto.h b/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_proto.h new file mode 120000 index 0000000..7ab0f41 --- /dev/null +++ b/src/host/trxcon/include/osmocom/bb/trxcon/l1ctl_proto.h @@ -0,0 +1 @@ +../../../../../../../include/l1ctl_proto.h \ No newline at end of file diff --git a/src/host/trxcon/logging.h b/src/host/trxcon/include/osmocom/bb/trxcon/logging.h similarity index 100% rename from src/host/trxcon/logging.h rename to src/host/trxcon/include/osmocom/bb/trxcon/logging.h diff --git a/src/host/trxcon/sched_trx.h b/src/host/trxcon/include/osmocom/bb/trxcon/sched_trx.h similarity index 98% rename from src/host/trxcon/sched_trx.h rename to src/host/trxcon/include/osmocom/bb/trxcon/sched_trx.h index 74b41e3..ab8ef34 100644 --- a/src/host/trxcon/sched_trx.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/sched_trx.h @@ -9,8 +9,8 @@ #include <osmocom/gsm/gsm_utils.h> #include <osmocom/core/linuxlist.h> -#include "logging.h" -#include "scheduler.h" +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/scheduler.h> #define GSM_BURST_LEN 148 #define GSM_BURST_PL_LEN 116 diff --git a/src/host/trxcon/scheduler.h b/src/host/trxcon/include/osmocom/bb/trxcon/scheduler.h similarity index 100% rename from src/host/trxcon/scheduler.h rename to src/host/trxcon/include/osmocom/bb/trxcon/scheduler.h diff --git a/src/host/trxcon/trx_if.h b/src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h similarity index 95% rename from src/host/trxcon/trx_if.h rename to src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h index fa66d4a..89c7dd0 100644 --- a/src/host/trxcon/trx_if.h +++ b/src/host/trxcon/include/osmocom/bb/trxcon/trx_if.h @@ -5,8 +5,8 @@ #include <osmocom/core/timer.h> #include <osmocom/core/fsm.h> -#include "scheduler.h" -#include "sched_trx.h" +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> #define TRXC_BUF_SIZE 1024 #define TRXD_BUF_SIZE 512 diff --git a/src/host/trxcon/trxcon.h b/src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h similarity index 100% rename from src/host/trxcon/trxcon.h rename to src/host/trxcon/include/osmocom/bb/trxcon/trxcon.h diff --git a/src/host/trxcon/l1ctl.c b/src/host/trxcon/l1ctl.c index 94a4d18..ca78e9b 100644 --- a/src/host/trxcon/l1ctl.c +++ b/src/host/trxcon/l1ctl.c @@ -35,12 +35,12 @@ #include <osmocom/gsm/gsm_utils.h> #include <osmocom/gsm/protocol/gsm_08_58.h> -#include "logging.h" -#include "l1ctl_link.h" -#include "l1ctl_proto.h" +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/l1ctl_link.h> +#include <osmocom/bb/trxcon/l1ctl_proto.h> -#include "trx_if.h" -#include "sched_trx.h" +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/sched_trx.h> static const char *arfcn2band_name(uint16_t arfcn) { diff --git a/src/host/trxcon/l1ctl_link.c b/src/host/trxcon/l1ctl_link.c index 552fc8b..b10d9da 100644 --- a/src/host/trxcon/l1ctl_link.c +++ b/src/host/trxcon/l1ctl_link.c @@ -36,10 +36,10 @@ #include <osmocom/core/socket.h> #include <osmocom/core/write_queue.h> -#include "trxcon.h" -#include "logging.h" -#include "l1ctl_link.h" -#include "l1ctl.h" +#include <osmocom/bb/trxcon/trxcon.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/l1ctl_link.h> +#include <osmocom/bb/trxcon/l1ctl.h> static struct value_string l1ctl_evt_names[] = { { 0, NULL } /* no events? */ diff --git a/src/host/trxcon/l1ctl_proto.h b/src/host/trxcon/l1ctl_proto.h deleted file mode 120000 index 75862ba..0000000 --- a/src/host/trxcon/l1ctl_proto.h +++ /dev/null @@ -1 +0,0 @@ -../../../include/l1ctl_proto.h \ No newline at end of file diff --git a/src/host/trxcon/logging.c b/src/host/trxcon/logging.c index 8352e6a..04f3568 100644 --- a/src/host/trxcon/logging.c +++ b/src/host/trxcon/logging.c @@ -21,7 +21,7 @@ #include <osmocom/core/logging.h> #include <osmocom/core/utils.h> -#include "logging.h" +#include <osmocom/bb/trxcon/logging.h> static struct log_info_cat trx_log_info_cat[] = { [DAPP] = { diff --git a/src/host/trxcon/sched_clck.c b/src/host/trxcon/sched_clck.c index 9476ccd..1e962aa 100644 --- a/src/host/trxcon/sched_clck.c +++ b/src/host/trxcon/sched_clck.c @@ -38,9 +38,9 @@ #include <osmocom/core/timer_compat.h> #include <osmocom/gsm/a5.h> -#include "scheduler.h" -#include "logging.h" -#include "trx_if.h" +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/trx_if.h> #define MAX_FN_SKEW 50 #define TRX_LOSS_FRAMES 400 diff --git a/src/host/trxcon/sched_lchan_common.c b/src/host/trxcon/sched_lchan_common.c index ac6d262..f5ee866 100644 --- a/src/host/trxcon/sched_lchan_common.c +++ b/src/host/trxcon/sched_lchan_common.c @@ -36,13 +36,13 @@ #include <osmocom/gsm/protocol/gsm_04_08.h> #include <osmocom/gsm/protocol/gsm_08_58.h> -#include "l1ctl_proto.h" -#include "scheduler.h" -#include "sched_trx.h" -#include "logging.h" -#include "trxcon.h" -#include "trx_if.h" -#include "l1ctl.h" +#include <osmocom/bb/trxcon/l1ctl_proto.h> +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/trxcon.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/l1ctl.h> /* GSM 05.02 Chapter 5.2.3 Normal Burst (NB) */ const uint8_t sched_nb_training_bits[8][26] = { diff --git a/src/host/trxcon/sched_lchan_desc.c b/src/host/trxcon/sched_lchan_desc.c index b6a72b3..ed7b141 100644 --- a/src/host/trxcon/sched_lchan_desc.c +++ b/src/host/trxcon/sched_lchan_desc.c @@ -26,7 +26,7 @@ #include <osmocom/gsm/protocol/gsm_08_58.h> #include <osmocom/core/gsmtap.h> -#include "sched_trx.h" +#include <osmocom/bb/trxcon/sched_trx.h> /* Forward declaration of handlers */ int rx_data_fn(struct trx_instance *trx, struct trx_ts *ts, diff --git a/src/host/trxcon/sched_lchan_pdtch.c b/src/host/trxcon/sched_lchan_pdtch.c index ad6a736..3dabc6b 100644 --- a/src/host/trxcon/sched_lchan_pdtch.c +++ b/src/host/trxcon/sched_lchan_pdtch.c @@ -30,12 +30,12 @@ #include <osmocom/gsm/protocol/gsm_04_08.h> #include <osmocom/coding/gsm0503_coding.h> -#include "l1ctl_proto.h" -#include "scheduler.h" -#include "sched_trx.h" -#include "logging.h" -#include "trx_if.h" -#include "l1ctl.h" +#include <osmocom/bb/trxcon/l1ctl_proto.h> +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/l1ctl.h> int rx_pdtch_fn(struct trx_instance *trx, struct trx_ts *ts, struct trx_lchan_state *lchan, uint32_t fn, uint8_t bid, diff --git a/src/host/trxcon/sched_lchan_rach.c b/src/host/trxcon/sched_lchan_rach.c index 76c0abb..33c0022 100644 --- a/src/host/trxcon/sched_lchan_rach.c +++ b/src/host/trxcon/sched_lchan_rach.c @@ -30,12 +30,12 @@ #include <osmocom/gsm/gsm_utils.h> #include <osmocom/coding/gsm0503_coding.h> -#include "l1ctl_proto.h" -#include "scheduler.h" -#include "sched_trx.h" -#include "logging.h" -#include "trx_if.h" -#include "l1ctl.h" +#include <osmocom/bb/trxcon/l1ctl_proto.h> +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/l1ctl.h> /* 3GPP TS 05.02, section 5.2.7 "Access burst (AB)" */ #define RACH_EXT_TAIL_BITS_LEN 8 diff --git a/src/host/trxcon/sched_lchan_sch.c b/src/host/trxcon/sched_lchan_sch.c index 4d7804e..ed914a0 100644 --- a/src/host/trxcon/sched_lchan_sch.c +++ b/src/host/trxcon/sched_lchan_sch.c @@ -31,12 +31,12 @@ #include <osmocom/gsm/gsm_utils.h> #include <osmocom/coding/gsm0503_coding.h> -#include "l1ctl_proto.h" -#include "scheduler.h" -#include "sched_trx.h" -#include "logging.h" -#include "trx_if.h" -#include "l1ctl.h" +#include <osmocom/bb/trxcon/l1ctl_proto.h> +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/l1ctl.h> static void decode_sb(struct gsm_time *time, uint8_t *bsic, uint8_t *sb_info) { diff --git a/src/host/trxcon/sched_lchan_tchf.c b/src/host/trxcon/sched_lchan_tchf.c index caf3586..6669bb0 100644 --- a/src/host/trxcon/sched_lchan_tchf.c +++ b/src/host/trxcon/sched_lchan_tchf.c @@ -32,12 +32,12 @@ #include <osmocom/coding/gsm0503_coding.h> #include <osmocom/codec/codec.h> -#include "l1ctl_proto.h" -#include "scheduler.h" -#include "sched_trx.h" -#include "logging.h" -#include "trx_if.h" -#include "l1ctl.h" +#include <osmocom/bb/trxcon/l1ctl_proto.h> +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/l1ctl.h> int rx_tchf_fn(struct trx_instance *trx, struct trx_ts *ts, struct trx_lchan_state *lchan, uint32_t fn, uint8_t bid, diff --git a/src/host/trxcon/sched_lchan_tchh.c b/src/host/trxcon/sched_lchan_tchh.c index ae67de4..3be3a59 100644 --- a/src/host/trxcon/sched_lchan_tchh.c +++ b/src/host/trxcon/sched_lchan_tchh.c @@ -35,12 +35,12 @@ #include <osmocom/coding/gsm0503_coding.h> #include <osmocom/codec/codec.h> -#include "l1ctl_proto.h" -#include "scheduler.h" -#include "sched_trx.h" -#include "logging.h" -#include "trx_if.h" -#include "l1ctl.h" +#include <osmocom/bb/trxcon/l1ctl_proto.h> +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/l1ctl.h> static const uint8_t tch_h0_traffic_block_map[3][4] = { /* B0(0,2,4,6), B1(4,6,8,10), B2(8,10,0,2) */ diff --git a/src/host/trxcon/sched_lchan_xcch.c b/src/host/trxcon/sched_lchan_xcch.c index 9fdbcc7..e3accf3 100644 --- a/src/host/trxcon/sched_lchan_xcch.c +++ b/src/host/trxcon/sched_lchan_xcch.c @@ -30,12 +30,12 @@ #include <osmocom/gsm/protocol/gsm_04_08.h> #include <osmocom/coding/gsm0503_coding.h> -#include "l1ctl_proto.h" -#include "scheduler.h" -#include "sched_trx.h" -#include "logging.h" -#include "trx_if.h" -#include "l1ctl.h" +#include <osmocom/bb/trxcon/l1ctl_proto.h> +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/l1ctl.h> int rx_data_fn(struct trx_instance *trx, struct trx_ts *ts, struct trx_lchan_state *lchan, uint32_t fn, uint8_t bid, diff --git a/src/host/trxcon/sched_mframe.c b/src/host/trxcon/sched_mframe.c index 9b759af..f5fb6c9 100644 --- a/src/host/trxcon/sched_mframe.c +++ b/src/host/trxcon/sched_mframe.c @@ -25,7 +25,7 @@ #include <osmocom/gsm/gsm_utils.h> -#include "sched_trx.h" +#include <osmocom/bb/trxcon/sched_trx.h> /* Non-combined CCCH */ static const struct trx_frame frame_bcch[51] = { diff --git a/src/host/trxcon/sched_prim.c b/src/host/trxcon/sched_prim.c index e5554ea..847ebd3 100644 --- a/src/host/trxcon/sched_prim.c +++ b/src/host/trxcon/sched_prim.c @@ -29,10 +29,10 @@ #include <osmocom/gsm/protocol/gsm_04_08.h> -#include "scheduler.h" -#include "sched_trx.h" -#include "trx_if.h" -#include "logging.h" +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/logging.h> /** * Initializes a new primitive by allocating memory diff --git a/src/host/trxcon/sched_trx.c b/src/host/trxcon/sched_trx.c index 828787e..618ce8b 100644 --- a/src/host/trxcon/sched_trx.c +++ b/src/host/trxcon/sched_trx.c @@ -31,11 +31,11 @@ #include <osmocom/core/logging.h> #include <osmocom/core/linuxlist.h> -#include "l1ctl_proto.h" -#include "scheduler.h" -#include "sched_trx.h" -#include "trx_if.h" -#include "logging.h" +#include <osmocom/bb/trxcon/l1ctl_proto.h> +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/logging.h> static void sched_trx_a5_burst_enc(struct trx_lchan_state *lchan, struct sched_burst_req *br); diff --git a/src/host/trxcon/trx_if.c b/src/host/trxcon/trx_if.c index 8dbbd12..7528609 100644 --- a/src/host/trxcon/trx_if.c +++ b/src/host/trxcon/trx_if.c @@ -39,11 +39,11 @@ #include <osmocom/gsm/gsm_utils.h> -#include "l1ctl.h" -#include "trxcon.h" -#include "trx_if.h" -#include "logging.h" -#include "scheduler.h" +#include <osmocom/bb/trxcon/l1ctl.h> +#include <osmocom/bb/trxcon/trxcon.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/scheduler.h> static struct value_string trx_evt_names[] = { { 0, NULL } /* no events? */ diff --git a/src/host/trxcon/trxcon.c b/src/host/trxcon/trxcon.c index d6ba0c4..998fdde 100644 --- a/src/host/trxcon/trxcon.c +++ b/src/host/trxcon/trxcon.c @@ -39,14 +39,14 @@ #include <osmocom/gsm/gsm_utils.h> -#include "trxcon.h" -#include "trx_if.h" -#include "logging.h" -#include "l1ctl.h" -#include "l1ctl_link.h" -#include "l1ctl_proto.h" -#include "scheduler.h" -#include "sched_trx.h" +#include <osmocom/bb/trxcon/trxcon.h> +#include <osmocom/bb/trxcon/trx_if.h> +#include <osmocom/bb/trxcon/logging.h> +#include <osmocom/bb/trxcon/l1ctl.h> +#include <osmocom/bb/trxcon/l1ctl_link.h> +#include <osmocom/bb/trxcon/l1ctl_proto.h> +#include <osmocom/bb/trxcon/scheduler.h> +#include <osmocom/bb/trxcon/sched_trx.h> #define COPYRIGHT \ "Copyright (C) 2016-2020 by Vadim Yanitskiy <axilirator(a)gmail.com>\n" \ -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifa6137c239c215a3d323213ee74d34b419622be4 Gerrit-Change-Number: 28502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Makefile.am: move versioning magic to the bottom

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28500 ) Change subject: trxcon: Makefile.am: move versioning magic to the bottom ...................................................................... trxcon: Makefile.am: move versioning magic to the bottom This is a more usual place for manually added targets. Change-Id: I69892f8689fd7062ca26b6f1337c972b11b1906e Related: OS#5599, OS#3761 --- M src/host/trxcon/Makefile.am 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/src/host/trxcon/Makefile.am b/src/host/trxcon/Makefile.am index b51db02..0c71e97 100644 --- a/src/host/trxcon/Makefile.am +++ b/src/host/trxcon/Makefile.am @@ -1,12 +1,5 @@ AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6 -# versioning magic -BUILT_SOURCES = $(top_srcdir)/.version -$(top_srcdir)/.version: - echo $(VERSION) > $@-t && mv $@-t $@ -dist-hook: - echo $(VERSION) > $(distdir)/.tarball-version - AM_CPPFLAGS = \ $(all_includes) \ -I$(top_srcdir)/include \ @@ -50,3 +43,10 @@ $(LIBOSMOCODING_LIBS) \ $(LIBOSMOGSM_LIBS) \ $(NULL) + +# versioning magic +BUILT_SOURCES = $(top_srcdir)/.version +$(top_srcdir)/.version: + echo $(VERSION) > $@-t && mv $@-t $@ +dist-hook: + echo $(VERSION) > $(distdir)/.tarball-version -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I69892f8689fd7062ca26b6f1337c972b11b1906e Gerrit-Change-Number: 28500 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: group header files into 'include/osmocom/bb/trxcon'

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28502 ) Change subject: trxcon: group header files into 'include/osmocom/bb/trxcon' ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifa6137c239c215a3d323213ee74d34b419622be4 Gerrit-Change-Number: 28502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 08:01:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: coverity: compile tests, but not execute them

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28512 ) Change subject: coverity: compile tests, but not execute them ...................................................................... coverity: compile tests, but not execute them Compiling unit tests would allow Coverity to analyze them too and thus find more bugs. The problem is that binaries listed in check_PROGRAMS are not compiled during 'make all', but only during 'make check'. One approach [1] is to run 'make check' in do_build(), however it breaks 'Coverity-Upload' job because some unit tests are failing. This is why I had to revert bf84ba9f69a0a2125bfd4327519b0e6fa212d664 together with ae41942214ef43bbb6aeb257bad2985765035ad7 that was supposed to fix it. Even if all unit tests were passing, we still don't want to execute them because running tests is beyond the scope of 'Coverity-Upload' job. Another approach is to patch Makefile.am files replacing check_PROGRAMS with noinst_PROGRAMS, so that the test binaries are compiled during 'make all' but not executed. Change-Id: Idf0714a59356633021be21acc47f9471d059b7fe Related: [1] I3f3149a61df96646798c72d0ad31c41b97e6b81f --- M coverity/prepare_source_Osmocom.sh 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/coverity/prepare_source_Osmocom.sh b/coverity/prepare_source_Osmocom.sh index 452af3e..22d72e7 100755 --- a/coverity/prepare_source_Osmocom.sh +++ b/coverity/prepare_source_Osmocom.sh @@ -47,6 +47,13 @@ else git clone git://git.osmocom.org/$proj fi + + # We want to compile tests, but not execute them. Using 'noinst_PROGRAMS' + # instead of 'check_PROGRAMS' allows building test binaries during 'make all'. + files="$(git -C $proj grep -l check_PROGRAMS)" + if [ -n "$files" ]; then + sed -i "s/check_PROGRAMS/noinst_PROGRAMS/" $files + fi done if ! [ -d layer1-api ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf0714a59356633021be21acc47f9471d059b7fe Gerrit-Change-Number: 28512 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: Revert "coverity/build_Osmocom.sh: don't do check for all"

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28510 ) Change subject: Revert "coverity/build_Osmocom.sh: don't do check for all" ...................................................................... Revert "coverity/build_Osmocom.sh: don't do check for all" This reverts commit ae41942214ef43bbb6aeb257bad2985765035ad7. Change-Id: I5018e0da020f32e3a46a2772e79794e5a3a686ca --- M coverity/build_Osmocom.sh 1 file changed, 3 insertions(+), 17 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index ec764be..fe9806c 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -5,7 +5,6 @@ base_dir="$PWD" src_dir="$base_dir/source-Osmocom" prefix="$base_dir/install-Osmocom" -check="check" install -d "$prefix" @@ -19,16 +18,10 @@ --disable-doxygen \ $* - make $PARALLEL_MAKE $check + make $PARALLEL_MAKE check make install } -do_build_no_check() { - check="" - do_build "$@" - check="check" -} - build_default() { pushd $1 shift @@ -36,13 +29,6 @@ popd } -build_no_check() { - pushd $1 - shift - do_build_no_check $* - popd -} - build_layer1api() { pushd layer1-api install -d "$prefix/include/sysmocom/femtobts/" @@ -83,10 +69,10 @@ rm -rf "$prefix" build_layer1api -build_no_check asn1c +build_default asn1c build_default libosmocore build_libasn1c -build_no_check libusrp +build_libusrp build_default libosmo-abis build_default libosmo-netif build_default libosmo-sccp 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5018e0da020f32e3a46a2772e79794e5a3a686ca Gerrit-Change-Number: 28510 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: Revert "coverity/build_Osmocom.sh: run 'make check' in do_build()"

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28511 ) Change subject: Revert "coverity/build_Osmocom.sh: run 'make check' in do_build()" ...................................................................... Revert "coverity/build_Osmocom.sh: run 'make check' in do_build()" This reverts commit bf84ba9f69a0a2125bfd4327519b0e6fa212d664. Change-Id: I722f8cbb1934a4f5ce2969e243f223019f123777 --- M coverity/build_Osmocom.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index fe9806c..a7f8cdd 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -18,7 +18,7 @@ --disable-doxygen \ $* - make $PARALLEL_MAKE check + make $PARALLEL_MAKE make install } 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I722f8cbb1934a4f5ce2969e243f223019f123777 Gerrit-Change-Number: 28511 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in simtrace2[master]: host/cardem: fix integer overflow in process_do_rx_da()

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/28513 to look at the new patch set (#3). Change subject: host/cardem: fix integer overflow in process_do_rx_da() ...................................................................... host/cardem: fix integer overflow in process_do_rx_da() osmo_apdu_segment_in() may return a negative number on receipt of "unknown APDU case", and that would crash simtrace2-cardem-pcsc: msgb(0x55d2cf7aa8a0): Not enough tailroom msgb_put (allocated 920, head at 0, len 7, tailroom 1017 < want tailroom 65534) backtrace() returned 19 addresses Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 Related: OS#5600 --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/13/28513/3 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/28513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 Gerrit-Change-Number: 28513 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 10 months

1
0
0 0

Change in simtrace2[master]: host/cardem: fix integer overflow in process_do_rx_da()

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/28513 to look at the new patch set (#2). Change subject: host/cardem: fix integer overflow in process_do_rx_da() ...................................................................... host/cardem: fix integer overflow in process_do_rx_da() osmo_apdu_segment_in() may return a negative number on receipt of "unknown APDU case", and that would crash simtrace2-cardem-pcsc: msgb(0x55d2cf7aa8a0): Not enough tailroom msgb_put (allocated 920, head at 0, len 7, tailroom 1017 < want tailroom 65534) backtrace() returned 19 addresses Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 Related: OS#5600 --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/13/28513/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/28513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 Gerrit-Change-Number: 28513 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: coverity: compile tests, but not execute them

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28512 ) Change subject: coverity: compile tests, but not execute them ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf0714a59356633021be21acc47f9471d059b7fe Gerrit-Change-Number: 28512 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:51:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: group header files into 'include/osmocom/bb/trxcon'

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28502 ) Change subject: trxcon: group header files into 'include/osmocom/bb/trxcon' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28502 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ifa6137c239c215a3d323213ee74d34b419622be4 Gerrit-Change-Number: 28502 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:51:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in simtrace2[master]: host/cardem: fix integer overflow in process_do_rx_da()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/simtrace2/+/28513 ) Change subject: host/cardem: fix integer overflow in process_do_rx_da() ...................................................................... host/cardem: fix integer overflow in process_do_rx_da() osmo_apdu_segment_in() may return a negative number on receipt of "unknown APDU case", and that would crash simtrace2-cardem-pcsc: msgb(0x55d2cf7aa8a0): Not enough tailroom msgb_put (allocated 920, head at 0, len 7, tailroom 1017 < want tailroom 65534) backtrace() returned 19 addresses Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 --- M host/src/simtrace2-cardem-pcsc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/13/28513/1 diff --git a/host/src/simtrace2-cardem-pcsc.c b/host/src/simtrace2-cardem-pcsc.c index 4820f36..096bc7b 100644 --- a/host/src/simtrace2-cardem-pcsc.c +++ b/host/src/simtrace2-cardem-pcsc.c @@ -168,7 +168,7 @@ rc = osmo_apdu_segment_in(&ac, data->data, data->data_len, data->flags & CEMU_DATA_F_TPDU_HDR); - if (rc & APDU_ACT_TX_CAPDU_TO_CARD) { + if (rc > 0 & APDU_ACT_TX_CAPDU_TO_CARD) { struct msgb *tmsg = msgb_alloc(1024, "TPDU"); struct osim_reader_hdl *rh = ci->chan->card->reader; uint8_t *cur; -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/28513 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I9e97b955a28ec886a429d744f9316e7e71be4481 Gerrit-Change-Number: 28513 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 10 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: Makefile.am: move versioning magic to the bottom

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/28500 ) Change subject: trxcon: Makefile.am: move versioning magic to the bottom ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/28500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I69892f8689fd7062ca26b6f1337c972b11b1906e Gerrit-Change-Number: 28500 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:46:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: coverity: compile tests, but not execute them

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28512 ) Change subject: coverity: compile tests, but not execute them ...................................................................... Patch Set 2: (1 comment) File coverity/prepare_source_Osmocom.sh: https://gerrit.osmocom.org/c/osmo-ci/+/28512/comment/4c3c3984_e208b7c9 PS1, Line 54: if [ ! -z "$files" ]; then > if [ -n "$files ]; then […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf0714a59356633021be21acc47f9471d059b7fe Gerrit-Change-Number: 28512 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:39:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: coverity: compile tests, but not execute them

by fixeria

Attention is currently required from: fixeria. Hello osmith, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/28512 to look at the new patch set (#2). Change subject: coverity: compile tests, but not execute them ...................................................................... coverity: compile tests, but not execute them Compiling unit tests would allow Coverity to analyze them too and thus find more bugs. The problem is that binaries listed in check_PROGRAMS are not compiled during 'make all', but only during 'make check'. One approach [1] is to run 'make check' in do_build(), however it breaks 'Coverity-Upload' job because some unit tests are failing. This is why I had to revert bf84ba9f69a0a2125bfd4327519b0e6fa212d664 together with ae41942214ef43bbb6aeb257bad2985765035ad7 that was supposed to fix it. Even if all unit tests were passing, we still don't want to execute them because running tests is beyond the scope of 'Coverity-Upload' job. Another approach is to patch Makefile.am files replacing check_PROGRAMS with noinst_PROGRAMS, so that the test binaries are compiled during 'make all' but not executed. Change-Id: Idf0714a59356633021be21acc47f9471d059b7fe Related: [1] I3f3149a61df96646798c72d0ad31c41b97e6b81f --- M coverity/prepare_source_Osmocom.sh 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/12/28512/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf0714a59356633021be21acc47f9471d059b7fe Gerrit-Change-Number: 28512 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: Revert "coverity/build_Osmocom.sh: run 'make check' in do_build()"

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28511 ) Change subject: Revert "coverity/build_Osmocom.sh: run 'make check' in do_build()" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28511 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I722f8cbb1934a4f5ce2969e243f223019f123777 Gerrit-Change-Number: 28511 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:29:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: Revert "coverity/build_Osmocom.sh: don't do check for all"

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28510 ) Change subject: Revert "coverity/build_Osmocom.sh: don't do check for all" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28510 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5018e0da020f32e3a46a2772e79794e5a3a686ca Gerrit-Change-Number: 28510 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:29:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: coverity: compile tests, but not execute them

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28512 ) Change subject: coverity: compile tests, but not execute them ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File coverity/prepare_source_Osmocom.sh: https://gerrit.osmocom.org/c/osmo-ci/+/28512/comment/27e10552_8d2421aa PS1, Line 54: if [ ! -z "$files" ]; then if [ -n "$files ]; then Otherwise LGTM! -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28512 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Idf0714a59356633021be21acc47f9471d059b7fe Gerrit-Change-Number: 28512 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:29:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: lint: ignore symlinks (no newline at end of file)

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28503 ) Change subject: lint: ignore symlinks (no newline at end of file) ...................................................................... lint: ignore symlinks (no newline at end of file) Change-Id: I6db6ebb51cdfd54e8f9c2c5cc7affef60a7dec32 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index 2194caa..a12d0a1 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -10,6 +10,8 @@ echo '--exclude ^debian/changelog$' # Patch files echo '--exclude \.patch$' + # Symlinks (no newline at end of file) + find -type l -printf '--exclude ^%P$\n' } exclude_paths_common_asn1c() { -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28503 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6db6ebb51cdfd54e8f9c2c5cc7affef60a7dec32 Gerrit-Change-Number: 28503 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: lint: simplify find command in exclude_paths_common_asn1c()

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28504 ) Change subject: lint: simplify find command in exclude_paths_common_asn1c() ...................................................................... lint: simplify find command in exclude_paths_common_asn1c() The purpose of "cut -d / -f 2-" is to strip off leading "./" in the paths. The same can be achieved by doing "-printf '%P\n'". Matching "*.c" and "*.h" files can be expressed as "-name *.[hc]". Change-Id: Iae3fc5c8842df6926e6ff16a41be5663f1dedd1b --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index a12d0a1..b0c3985 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -16,7 +16,7 @@ exclude_paths_common_asn1c() { local pattern="^ \* Generated by asn1c-" - local files="$(find -name '*.c' -o -name '*.h' | cut -d / -f 2-)" + local files="$(find -name '*.[hc]' -printf '%P\n')" local i if [ -z "$files" ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iae3fc5c8842df6926e6ff16a41be5663f1dedd1b Gerrit-Change-Number: 28504 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 10 months

1
0
0 0

Change in osmo-ci[master]: lint: simplify find command in exclude_paths_common_asn1c()

by osmith

Attention is currently required from: fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28504 ) Change subject: lint: simplify find command in exclude_paths_common_asn1c() ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Nice, thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28504 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iae3fc5c8842df6926e6ff16a41be5663f1dedd1b Gerrit-Change-Number: 28504 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Jul 2022 07:23:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 10 months

1
0
0 0

2024

2023

2022

gerrit-log July 2022