Attention is currently required from: pespin.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/docker-playground/+/28528
to look at the new patch set (#2).
Change subject: Remove several unused containers
......................................................................
Remove several unused containers
* alpine-*: looks like they were never used
* debian-{jessie,stretch}-*: EOL
* debian9-repo-install-test: EOL
* gitolite: never used? / upstream container last updated 3 years ago
* osmo-gerrit-libosmo: unused example from 2017, based on jessie
* patchwork: looks like never used, ancient version
* public-inbox: added in 2018 for playing around, apparently unused
* tmp: unfinished and unused
* ubuntu-zesty-build: was added for testing ubuntu 17.04, unused
Related: OS#5601
Change-Id: Ic09046379ddff049629bb66850ead7ba479c4450
---
D alpine-build/Dockerfile
D alpine-build/Makefile
D alpine-lighttpd/Dockerfile
D alpine-lighttpd/Makefile
D alpine-lighttpd/index.html
D alpine-lighttpd/ipv6.conf
D debian-jessie-build/Dockerfile
D debian-jessie-build/Makefile
D debian-jessie-buildslave-st/Dockerfile
D debian-jessie-buildslave-st/Makefile
D debian-jessie-buildslave/Dockerfile
D debian-jessie-buildslave/Makefile
D debian-jessie-osmocom/Dockerfile
D debian-jessie-osmocom/Makefile
D debian-stretch-build/Dockerfile
D debian-stretch-build/Makefile
D debian-stretch-jenkins/Dockerfile
D debian-stretch-jenkins/Makefile
D debian-stretch-obs-latest/Dockerfile
D debian-stretch-obs-latest/Makefile
D debian9-repo-install-test/Dockerfile
D debian9-repo-install-test/Makefile
D gitolite/Dockerfile
D gitolite/Makefile
D osmo-gerrit-libosmo/Dockerfile
D osmo-gerrit-libosmo/Makefile
D patchwork/Dockerfile
D patchwork/Dockerfile.fdo
D patchwork/Dockerfile.upstream
D patchwork/Makefile
D patchwork/docker-entrypoint.sh
D patchwork/production.py
D public-inbox/Dockerfile
D public-inbox/Makefile
D tmp/docker-compose.yml
D ubuntu-zesty-build/Dockerfile
D ubuntu-zesty-build/Makefile
37 files changed, 0 insertions(+), 1,130 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/28/28528/2
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic09046379ddff049629bb66850ead7ba479c4450
Gerrit-Change-Number: 28528
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28528 )
Change subject: _unmaintained: add dir for old containers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Why not simply dropping them if they are not used? git history exists for a reason, they can be reco […]
My reasoning was that it's easier to recover them that way / one could even still build them if they needed them from the _unmaintained directory. But on the other hand, it's unlikely that somebody will need them again and if they do they can pull it out of the git history as you say. You're right, I'll just delete them, will update the patch.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic09046379ddff049629bb66850ead7ba479c4450
Gerrit-Change-Number: 28528
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Jul 2022 11:54:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/28528 )
Change subject: _unmaintained: add dir for old containers
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Why not simply dropping them if they are not used? git history exists for a reason, they can be recovered.
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic09046379ddff049629bb66850ead7ba479c4450
Gerrit-Change-Number: 28528
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Jul 2022 11:46:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28528 )
Change subject: _unmaintained: add dir for old containers
......................................................................
_unmaintained: add dir for old containers
Prepare to clean up the root dir of docker-playground with a new
_unmaintained directory, where we can move all containers that either
are not used anymore or were never used.
Add _unmaintained/make/Makefile, so one can still run 'make' in the
moved directories to build these.
Change-Id: Ic09046379ddff049629bb66850ead7ba479c4450
---
A _unmaintained/make/Makefile
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/28/28528/1
diff --git a/_unmaintained/make/Makefile b/_unmaintained/make/Makefile
new file mode 100644
index 0000000..94836ab
--- /dev/null
+++ b/_unmaintained/make/Makefile
@@ -0,0 +1 @@
+include ../../make/Makefile
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ic09046379ddff049629bb66850ead7ba479c4450
Gerrit-Change-Number: 28528
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28529 )
Change subject: _unmaintained: move several containers
......................................................................
_unmaintained: move several containers
* alpine-*: looks like they were never used
* debian-{jessie,stretch}-*: EOL
* debian9-repo-install-test: EOL
* gitolite: never used? / upstream container last updated 3 years ago
* patchwork: looks like never used, ancient version
* public-inbox: added in 2018 for playing around, apparently unused
* tmp: unfinished and unused
* ubuntu-zesty-build: was added for testing ubuntu 17.04, unused
Related: OS#5601
Change-Id: I8c066de0fb90cf7ca356322c64c081ec40e746c1
---
R _unmaintained/alpine-build/Dockerfile
R _unmaintained/alpine-build/Makefile
R _unmaintained/alpine-lighttpd/Dockerfile
R _unmaintained/alpine-lighttpd/Makefile
R _unmaintained/alpine-lighttpd/index.html
R _unmaintained/alpine-lighttpd/ipv6.conf
R _unmaintained/debian-jessie-build/Dockerfile
R _unmaintained/debian-jessie-build/Makefile
R _unmaintained/debian-jessie-buildslave-st/Dockerfile
R _unmaintained/debian-jessie-buildslave-st/Makefile
R _unmaintained/debian-jessie-buildslave/Dockerfile
R _unmaintained/debian-jessie-buildslave/Makefile
R _unmaintained/debian-jessie-osmocom/Dockerfile
R _unmaintained/debian-jessie-osmocom/Makefile
R _unmaintained/debian-stretch-build/Dockerfile
R _unmaintained/debian-stretch-build/Makefile
R _unmaintained/debian-stretch-jenkins/Dockerfile
R _unmaintained/debian-stretch-jenkins/Makefile
R _unmaintained/debian-stretch-obs-latest/Dockerfile
R _unmaintained/debian-stretch-obs-latest/Makefile
R _unmaintained/debian9-repo-install-test/Dockerfile
R _unmaintained/debian9-repo-install-test/Makefile
R _unmaintained/gitolite/Dockerfile
R _unmaintained/gitolite/Makefile
R _unmaintained/patchwork/Dockerfile
R _unmaintained/patchwork/Dockerfile.fdo
R _unmaintained/patchwork/Dockerfile.upstream
R _unmaintained/patchwork/Makefile
R _unmaintained/patchwork/docker-entrypoint.sh
R _unmaintained/patchwork/production.py
R _unmaintained/public-inbox/Dockerfile
R _unmaintained/public-inbox/Makefile
R _unmaintained/tmp/docker-compose.yml
R _unmaintained/ubuntu-zesty-build/Dockerfile
R _unmaintained/ubuntu-zesty-build/Makefile
35 files changed, 0 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/29/28529/1
diff --git a/alpine-build/Dockerfile b/_unmaintained/alpine-build/Dockerfile
similarity index 100%
rename from alpine-build/Dockerfile
rename to _unmaintained/alpine-build/Dockerfile
diff --git a/alpine-build/Makefile b/_unmaintained/alpine-build/Makefile
similarity index 100%
rename from alpine-build/Makefile
rename to _unmaintained/alpine-build/Makefile
diff --git a/alpine-lighttpd/Dockerfile b/_unmaintained/alpine-lighttpd/Dockerfile
similarity index 100%
rename from alpine-lighttpd/Dockerfile
rename to _unmaintained/alpine-lighttpd/Dockerfile
diff --git a/alpine-lighttpd/Makefile b/_unmaintained/alpine-lighttpd/Makefile
similarity index 100%
rename from alpine-lighttpd/Makefile
rename to _unmaintained/alpine-lighttpd/Makefile
diff --git a/alpine-lighttpd/index.html b/_unmaintained/alpine-lighttpd/index.html
similarity index 100%
rename from alpine-lighttpd/index.html
rename to _unmaintained/alpine-lighttpd/index.html
diff --git a/alpine-lighttpd/ipv6.conf b/_unmaintained/alpine-lighttpd/ipv6.conf
similarity index 100%
rename from alpine-lighttpd/ipv6.conf
rename to _unmaintained/alpine-lighttpd/ipv6.conf
diff --git a/debian-jessie-build/Dockerfile b/_unmaintained/debian-jessie-build/Dockerfile
similarity index 100%
rename from debian-jessie-build/Dockerfile
rename to _unmaintained/debian-jessie-build/Dockerfile
diff --git a/debian-jessie-build/Makefile b/_unmaintained/debian-jessie-build/Makefile
similarity index 100%
rename from debian-jessie-build/Makefile
rename to _unmaintained/debian-jessie-build/Makefile
diff --git a/debian-jessie-buildslave-st/Dockerfile b/_unmaintained/debian-jessie-buildslave-st/Dockerfile
similarity index 100%
rename from debian-jessie-buildslave-st/Dockerfile
rename to _unmaintained/debian-jessie-buildslave-st/Dockerfile
diff --git a/debian-jessie-buildslave-st/Makefile b/_unmaintained/debian-jessie-buildslave-st/Makefile
similarity index 100%
rename from debian-jessie-buildslave-st/Makefile
rename to _unmaintained/debian-jessie-buildslave-st/Makefile
diff --git a/debian-jessie-buildslave/Dockerfile b/_unmaintained/debian-jessie-buildslave/Dockerfile
similarity index 100%
rename from debian-jessie-buildslave/Dockerfile
rename to _unmaintained/debian-jessie-buildslave/Dockerfile
diff --git a/debian-jessie-buildslave/Makefile b/_unmaintained/debian-jessie-buildslave/Makefile
similarity index 100%
rename from debian-jessie-buildslave/Makefile
rename to _unmaintained/debian-jessie-buildslave/Makefile
diff --git a/debian-jessie-osmocom/Dockerfile b/_unmaintained/debian-jessie-osmocom/Dockerfile
similarity index 100%
rename from debian-jessie-osmocom/Dockerfile
rename to _unmaintained/debian-jessie-osmocom/Dockerfile
diff --git a/debian-jessie-osmocom/Makefile b/_unmaintained/debian-jessie-osmocom/Makefile
similarity index 100%
rename from debian-jessie-osmocom/Makefile
rename to _unmaintained/debian-jessie-osmocom/Makefile
diff --git a/debian-stretch-build/Dockerfile b/_unmaintained/debian-stretch-build/Dockerfile
similarity index 100%
rename from debian-stretch-build/Dockerfile
rename to _unmaintained/debian-stretch-build/Dockerfile
diff --git a/debian-stretch-build/Makefile b/_unmaintained/debian-stretch-build/Makefile
similarity index 100%
rename from debian-stretch-build/Makefile
rename to _unmaintained/debian-stretch-build/Makefile
diff --git a/debian-stretch-jenkins/Dockerfile b/_unmaintained/debian-stretch-jenkins/Dockerfile
similarity index 100%
rename from debian-stretch-jenkins/Dockerfile
rename to _unmaintained/debian-stretch-jenkins/Dockerfile
diff --git a/debian-stretch-jenkins/Makefile b/_unmaintained/debian-stretch-jenkins/Makefile
similarity index 100%
rename from debian-stretch-jenkins/Makefile
rename to _unmaintained/debian-stretch-jenkins/Makefile
diff --git a/debian-stretch-obs-latest/Dockerfile b/_unmaintained/debian-stretch-obs-latest/Dockerfile
similarity index 100%
rename from debian-stretch-obs-latest/Dockerfile
rename to _unmaintained/debian-stretch-obs-latest/Dockerfile
diff --git a/debian-stretch-obs-latest/Makefile b/_unmaintained/debian-stretch-obs-latest/Makefile
similarity index 100%
rename from debian-stretch-obs-latest/Makefile
rename to _unmaintained/debian-stretch-obs-latest/Makefile
diff --git a/debian9-repo-install-test/Dockerfile b/_unmaintained/debian9-repo-install-test/Dockerfile
similarity index 100%
rename from debian9-repo-install-test/Dockerfile
rename to _unmaintained/debian9-repo-install-test/Dockerfile
diff --git a/debian9-repo-install-test/Makefile b/_unmaintained/debian9-repo-install-test/Makefile
similarity index 100%
rename from debian9-repo-install-test/Makefile
rename to _unmaintained/debian9-repo-install-test/Makefile
diff --git a/gitolite/Dockerfile b/_unmaintained/gitolite/Dockerfile
similarity index 100%
rename from gitolite/Dockerfile
rename to _unmaintained/gitolite/Dockerfile
diff --git a/gitolite/Makefile b/_unmaintained/gitolite/Makefile
similarity index 100%
rename from gitolite/Makefile
rename to _unmaintained/gitolite/Makefile
diff --git a/patchwork/Dockerfile b/_unmaintained/patchwork/Dockerfile
similarity index 100%
rename from patchwork/Dockerfile
rename to _unmaintained/patchwork/Dockerfile
diff --git a/patchwork/Dockerfile.fdo b/_unmaintained/patchwork/Dockerfile.fdo
similarity index 100%
rename from patchwork/Dockerfile.fdo
rename to _unmaintained/patchwork/Dockerfile.fdo
diff --git a/patchwork/Dockerfile.upstream b/_unmaintained/patchwork/Dockerfile.upstream
similarity index 100%
rename from patchwork/Dockerfile.upstream
rename to _unmaintained/patchwork/Dockerfile.upstream
diff --git a/patchwork/Makefile b/_unmaintained/patchwork/Makefile
similarity index 100%
rename from patchwork/Makefile
rename to _unmaintained/patchwork/Makefile
diff --git a/patchwork/docker-entrypoint.sh b/_unmaintained/patchwork/docker-entrypoint.sh
similarity index 100%
rename from patchwork/docker-entrypoint.sh
rename to _unmaintained/patchwork/docker-entrypoint.sh
diff --git a/patchwork/production.py b/_unmaintained/patchwork/production.py
similarity index 100%
rename from patchwork/production.py
rename to _unmaintained/patchwork/production.py
diff --git a/public-inbox/Dockerfile b/_unmaintained/public-inbox/Dockerfile
similarity index 100%
rename from public-inbox/Dockerfile
rename to _unmaintained/public-inbox/Dockerfile
diff --git a/public-inbox/Makefile b/_unmaintained/public-inbox/Makefile
similarity index 100%
rename from public-inbox/Makefile
rename to _unmaintained/public-inbox/Makefile
diff --git a/tmp/docker-compose.yml b/_unmaintained/tmp/docker-compose.yml
similarity index 100%
rename from tmp/docker-compose.yml
rename to _unmaintained/tmp/docker-compose.yml
diff --git a/ubuntu-zesty-build/Dockerfile b/_unmaintained/ubuntu-zesty-build/Dockerfile
similarity index 100%
rename from ubuntu-zesty-build/Dockerfile
rename to _unmaintained/ubuntu-zesty-build/Dockerfile
diff --git a/ubuntu-zesty-build/Makefile b/_unmaintained/ubuntu-zesty-build/Makefile
similarity index 100%
rename from ubuntu-zesty-build/Makefile
rename to _unmaintained/ubuntu-zesty-build/Makefile
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28529
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I8c066de0fb90cf7ca356322c64c081ec40e746c1
Gerrit-Change-Number: 28529
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28520 )
Change subject: stream: assert params are not NULL in send/recv functions
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> Makes sense to me, but wouldn't the functions crash anyway when one of the parameters in questions i […]
Yes, crashing is fine since it should not happen and if it happens it means the caller has some several problem, hence it's good to catch it early during develop time.
That's what I encountered while extending osmo-cbc, with the problem that the crash happened when accessing the null pointer so it was no obvious at all when the sigsegv was occuring. If instead of that, an assert is hit, then it's immediatelly obvios when looking at the program's output.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28520
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie9e67396973128aba87b584be1a36e2a94dd0998
Gerrit-Change-Number: 28520
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Jul 2022 11:43:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ci/+/28527
to look at the new patch set (#2).
Change subject: jobs/registry-update-base-images: drop old images
......................................................................
jobs/registry-update-base-images: drop old images
No need to mirror these images if we don't use them anymore.
Remove debian 8 and 9, and ubuntu zesty. The latter is the codename for
ubuntu 17.04, which is a non-LTS and was unsupported since 2018-01-13.
Related: OS#5601
Change-Id: If1c198038b0fd5faf0763172447962969448940e
---
M jobs/registry-update-base-images.yml
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/27/28527/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: If1c198038b0fd5faf0763172447962969448940e
Gerrit-Change-Number: 28527
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-MessageType: newpatchset
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/28522 )
Change subject: release-tarball-build-dist/Makefile: update
......................................................................
release-tarball-build-dist/Makefile: update
Adjust the Makefile as well after the docker container has been migrated
to debian 11 in Ib6039724a7200abce5252f95407047296b72cd51.
Change-Id: Ibebca7be7daccd17bbf1b382108d87eb5a93ecf1
---
M release-tarball-build-dist/Makefile
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/22/28522/1
diff --git a/release-tarball-build-dist/Makefile b/release-tarball-build-dist/Makefile
index 10f0e20..736769d 100644
--- a/release-tarball-build-dist/Makefile
+++ b/release-tarball-build-dist/Makefile
@@ -1,3 +1,3 @@
-UPSTREAM_DISTRO=debian:stretch
-DISTRO=debian-stretch
+UPSTREAM_DISTRO=debian:bullseye
+DISTRO=debian-bullseye
include ../make/Makefile
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/28522
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: Ibebca7be7daccd17bbf1b382108d87eb5a93ecf1
Gerrit-Change-Number: 28522
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/28520 )
Change subject: stream: assert params are not NULL in send/recv functions
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Makes sense to me, but wouldn't the functions crash anyway when one of the parameters in questions is NULL?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/28520
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie9e67396973128aba87b584be1a36e2a94dd0998
Gerrit-Change-Number: 28520
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Jul 2022 09:49:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin, dexter.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494 )
Change subject: MGCP_Test: fix TC_dlcx_wildcarded
......................................................................
Patch Set 1:
(1 comment)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494/comment/b4528d2c_63b9…
PS1, Line 1121: /* Query a the statsd once to ensure that intermediate results are pulled from the
> I don't know that exactly, but I remember we had the exact same problem (at another place) some time […]
I agree with Pau that the second call shouldn't be necessary. I would have expected a race condition, but there was already a sleep there.
Then, I think the stats reported are the maximum number during that reporting interval (it was changed some time ago). That would explain why you're seeing this behaviour. In that case I would rather call f_statsd_reset after the mgcp_transceive_mgw to clear the values.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5fe18e433b32c364778b515ed37fcbcf443b3cb3
Gerrit-Change-Number: 28494
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 06 Jul 2022 09:47:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495 )
Change subject: MGCP_Test: add testcase TC_e1_dlcx_wildcarded
......................................................................
Patch Set 2:
(1 comment)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495/comment/5643a9df_41fe…
PS2, Line 2454: /* Query a the statsd once to ensure that intermediate results are pulled from the
> See my comment on previous patch.
(see my response in the previous patch)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28495
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6cfbd24982d1e72206f8237b2eaea52cdaebf9dc
Gerrit-Change-Number: 28495
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Jul 2022 15:14:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin, daniel.
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494 )
Change subject: MGCP_Test: fix TC_dlcx_wildcarded
......................................................................
Patch Set 1:
(1 comment)
File mgw/MGCP_Test.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494/comment/47a0a9ac_4802…
PS1, Line 1121: /* Query a the statsd once to ensure that intermediate results are pulled from the
> Are you sure what you say is correct? IIRC there are no intermediate results at all, statsd are only […]
I don't know that exactly, but I remember we had the exact same problem (at another place) some time ago and the fix was also the same. Maybe Daniel knows more about this.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28494
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I5fe18e433b32c364778b515ed37fcbcf443b3cb3
Gerrit-Change-Number: 28494
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Jul 2022 15:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment