June 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/28419 to look at the new patch set (#2). Change subject: VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/ ...................................................................... VTY: fix wrong enum value s/ACTIVATE_FOR_VTY/ASSIGN_FOR_VTY/ Found by clang: warning: implicit conversion from enumeration type 'enum lchan_activate_for' to different enumeration type 'enum assign_for' [-Wenum-conversion] This is indeed a bug, because both enum items have different values: * ACTIVATE_FOR_VTY (from enum lchan_activate_for) is 4, * ASSIGN_FOR_VTY (from enum assign_for) is 3. Change-Id: I44544d4577833e0aed62b07d0c7c1c2821b05dd4 --- M src/osmo-bsc/bsc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/19/28419/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I44544d4577833e0aed62b07d0c7c1c2821b05dd4 Gerrit-Change-Number: 28419 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years

1
0
0 0

Change in osmo-hlr[master]: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 ) Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... Patch Set 1: (1 comment) File src/db_auc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/28424/comment/4eb2956a_4689dc1d PS1, Line 99: return osmo_hexparse((void *)text, dst, dst_len) == col_len; > This is wrong, osmo_hexparse returns "number of parsed octets", not zero. Yes, this is why I am comparing returned value against col_len, not against 0. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 11:04:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-hlr[master]: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 ) Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/db_auc.c: https://gerrit.osmocom.org/c/osmo-hlr/+/28424/comment/0a485351_e219fe18 PS1, Line 99: return osmo_hexparse((void *)text, dst, dst_len) == col_len; This is wrong, osmo_hexparse returns "number of parsed octets", not zero. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 11:01:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-pcu[master]: encoding: fix an uninitialized field in gen_freq_params()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28423 ) Change subject: encoding: fix an uninitialized field in gen_freq_params() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c Gerrit-Change-Number: 28423 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 11:00:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-hlr[master]: db_auc: hexparse_stmt(): check value returned by osmo_hexparse()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/28424 ) Change subject: db_auc: hexparse_stmt(): check value returned by osmo_hexparse() ...................................................................... db_auc: hexparse_stmt(): check value returned by osmo_hexparse() Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Fixes: CID#272997 --- M src/db_auc.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/24/28424/1 diff --git a/src/db_auc.c b/src/db_auc.c index 975eb2d..44733d6 100644 --- a/src/db_auc.c +++ b/src/db_auc.c @@ -95,8 +95,8 @@ LOGAUC(imsi, LOGL_ERROR, "Error reading %s\n", col_name); return -EIO; } - osmo_hexparse((void *)text, dst, dst_len); - return 0; + + return osmo_hexparse((void *)text, dst, dst_len) == col_len; } /* obtain the authentication data for a given imsi -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/28424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I78bb3aff9dd57a38278bb34113ea764e0a54c439 Gerrit-Change-Number: 28424 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years

1
0
0 0

Change in osmo-pcu[master]: encoding: fix an uninitialized field in gen_freq_params()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/28423 ) Change subject: encoding: fix an uninitialized field in gen_freq_params() ...................................................................... encoding: fix an uninitialized field in gen_freq_params() This is not critical, given that we set 'ElementsOf_RFL_NUMBER' to 0. But still, let's ensure that all fields are initialized. Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c Fixes: CID#272999 --- M src/encoding.cpp 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/23/28423/1 diff --git a/src/encoding.cpp b/src/encoding.cpp index 4737137..2c13e46 100644 --- a/src/encoding.cpp +++ b/src/encoding.cpp @@ -573,6 +573,7 @@ fh_params.MAIO = pdch->fh.maio; fh_params.GPRS_Mobile_Allocation.HSN = pdch->fh.hsn; fh_params.GPRS_Mobile_Allocation.ElementsOf_RFL_NUMBER = 0; + fh_params.GPRS_Mobile_Allocation.RFL_NUMBER = { 0 }; /* Mobile Allocation bitmap */ fh_params.GPRS_Mobile_Allocation.UnionType = 0; /* MA bitmap */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/28423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I4dd5202d1c4bd75baf0ab4f88ffefcc47272bd9c Gerrit-Change-Number: 28423 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years

1
0
0 0

Change in osmo-ci[master]: coverity: add osmo-bsc-nat

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28422 ) Change subject: coverity: add osmo-bsc-nat ...................................................................... coverity: add osmo-bsc-nat Fixes: OS#5596 Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd --- M coverity/build_Osmocom.sh M coverity/prepare_source_Osmcocom.sh 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index 6a8cf59..a7f8cdd 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -100,6 +100,7 @@ build_default osmo-cbc build_default osmo-hnodeb build_default osmo-hnbgw +build_default osmo-bsc-nat # GMR build_default libosmo-dsp diff --git a/coverity/prepare_source_Osmcocom.sh b/coverity/prepare_source_Osmcocom.sh index 3b0d4d5..ab8b2bd 100755 --- a/coverity/prepare_source_Osmcocom.sh +++ b/coverity/prepare_source_Osmcocom.sh @@ -34,6 +34,7 @@ simtrace2 \ osmo-hnodeb \ osmo-hnbgw \ + osmo-bsc-nat \ ; do if [ -d $proj ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd Gerrit-Change-Number: 28422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years

1
0
0 0

Change in osmo-ci[master]: coverity: add osmo-bsc-nat

by fixeria

Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28422 ) Change subject: coverity: add osmo-bsc-nat ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd Gerrit-Change-Number: 28422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 10:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: coverity: add osmo-bsc-nat

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/28422 ) Change subject: coverity: add osmo-bsc-nat ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd Gerrit-Change-Number: 28422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 28 Jun 2022 10:33:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years

1
0
0 0

Change in osmo-ci[master]: coverity: add osmo-bsc-nat

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/28422 ) Change subject: coverity: add osmo-bsc-nat ...................................................................... coverity: add osmo-bsc-nat Fixes: OS#5596 Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd --- M coverity/build_Osmocom.sh M coverity/prepare_source_Osmcocom.sh 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/22/28422/1 diff --git a/coverity/build_Osmocom.sh b/coverity/build_Osmocom.sh index 6a8cf59..a7f8cdd 100755 --- a/coverity/build_Osmocom.sh +++ b/coverity/build_Osmocom.sh @@ -100,6 +100,7 @@ build_default osmo-cbc build_default osmo-hnodeb build_default osmo-hnbgw +build_default osmo-bsc-nat # GMR build_default libosmo-dsp diff --git a/coverity/prepare_source_Osmcocom.sh b/coverity/prepare_source_Osmcocom.sh index 3b0d4d5..ab8b2bd 100755 --- a/coverity/prepare_source_Osmcocom.sh +++ b/coverity/prepare_source_Osmcocom.sh @@ -34,6 +34,7 @@ simtrace2 \ osmo-hnodeb \ osmo-hnbgw \ + osmo-bsc-nat \ ; do if [ -d $proj ]; then -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/28422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id7cf497ea15c3ccdf76c047c6a67f17fac94e0dd Gerrit-Change-Number: 28422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years

1
0
0 0

2025

2024

2023

2022

gerrit-log June 2022