May 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: acc: Simplify start/stop by using new signal S_NM_RUNNING_CHG
by pespin 10 May '22

10 May '22

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28079 ) Change subject: acc: Simplify start/stop by using new signal S_NM_RUNNING_CHG ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/acc.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28079/comment/801f77d7_2332d104 PS1, Line 433: } > this block is the same as in nm_sig_cb. […] Not really needed imho. Specially since more object classes will emit this signal in the future, and they won't resolve to a trx object (these are the only 2 which relate to a trx struct). -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2e09bcb18a6c3bb2e88bba98579fb4854a6b0699 Gerrit-Change-Number: 28079 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 May 2022 10:28:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,b...
by pespin 10 May '22

10 May '22

Attention is currently required from: osmith, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28046 ) Change subject: Introduce new signal S_NM_RUNNING_CHG and implement it for rcarrier,bbtransc ...................................................................... Patch Set 4: (1 comment) File src/osmo-bsc/nm_bb_transc_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28046/comment/a90822e9_f344c66a PS4, Line 43: static void nm_obj_becomes_enabled_disabled(struct gsm_bts_bb_trx *bb_transc, bool running) > nm_ob_enable_disable instead of nm_ob_becomes_enabled_disabled? (Same for all other *_becomes_* func […] We are not enabling it, the BSC is not enabling it. It's the BTS announcing to us that it became enabled. So the _becomes_ looks much more clear to me. The function is not enabling, it's just a shared code path to call to do some tasks when the BTS becomes enabled. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I206d4c7863a77fbab6a600126742a6a6b8fc3614 Gerrit-Change-Number: 28046 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 May 2022 10:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Update current NM object state before signalling S_NM_STATECHG
by pespin 10 May '22

10 May '22

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28039 ) Change subject: Update current NM object state before signalling S_NM_STATECHG ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: > I suggest adding comment(s) to the respective signal handlers stating that the NM object state has a […] It's already commented in the code path dispatching the signal. I'm keeping CHG to keep it in order with existing signals. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib46234e3f3e446e866d27b0dfee65edf4af4d2ba Gerrit-Change-Number: 28039 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 May 2022 10:16:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: Add stat_item for per-bts [dynamic] T3113 timer
by pespin 10 May '22

10 May '22

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28060 ) Change subject: Add stat_item for per-bts [dynamic] T3113 timer ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28060 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I533f2ca3c8e66c143154cbf03b827c9cbbacccdf Gerrit-Change-Number: 28060 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 May 2022 10:15:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: paging: Avoid queueing more than 60 second estimated requests
by pespin 10 May '22

10 May '22

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28062 ) Change subject: paging: Avoid queueing more than 60 second estimated requests ...................................................................... paging: Avoid queueing more than 60 second estimated requests Reaching this point will only make system load (CPU, mem) grow, making it hard for the process to keep up with work to do, with no benefit since the requests will anyway be scheduled too late. Related: SYS#5922 Change-Id: I6523c6816a4d16b71084d004e979be40cf0aeeb0 --- M include/osmocom/bsc/bts.h M include/osmocom/bsc/paging.h M src/osmo-bsc/bts.c M src/osmo-bsc/paging.c M tests/paging/paging_test.ok 5 files changed, 1,517 insertions(+), 7 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6523c6816a4d16b71084d004e979be40cf0aeeb0 Gerrit-Change-Number: 28062 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

1 0

Change in osmo-bsc[master]: paging: Implement upper bound of 60s for dynamic T3113
by pespin 10 May '22

10 May '22

Attention is currently required from: osmith, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28059 ) Change subject: paging: Implement upper bound of 60s for dynamic T3113 ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28059/comment/98c4f120_559225d4 PS3, Line 394: to, estimated_to); > I think it's not obvious why in most cases you would have "expires in 5 seconds (estimated 5)". […] I think the easiest is leaving it as this. In generalthe expire is the same as the estimated, so nothing confusing. In the event they are different, one will probably see several of them in near time, and the expire will be always 60 with a higher estimate, so it's easy to infer it tops at 60. Later on if we make the 60 configurable (if we deem necessary) we can update the log to tell the user to tweak the VTY option. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28059 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib8228f8485527d34794048a9927e62b6ec8d802a Gerrit-Change-Number: 28059 Gerrit-PatchSet: 3 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 May 2022 10:14:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: paging: Avoid queueing more than 60 second estimated requests
by pespin 10 May '22

10 May '22

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28062 ) Change subject: paging: Avoid queueing more than 60 second estimated requests ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6523c6816a4d16b71084d004e979be40cf0aeeb0 Gerrit-Change-Number: 28062 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 10 May 2022 10:11:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bts[master]: measurement: fix matching of SUB frames by TDMA FN
by pespin 10 May '22

10 May '22

Attention is currently required from: laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/28086 ) Change subject: measurement: fix matching of SUB frames by TDMA FN ...................................................................... Patch Set 1: (4 comments) File src/common/measurement.c: https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/21f79b23_84dcb824 PS1, Line 23: /* TCH/H(0): 0, 2, 4, 6, 52, 54, 56, 58 */ Maybe use ";" to separate between the 2 blocks, it's easier to understand: /* TCH/H(0): 0, 2, 4, 6; 52, 54, 56, 58 */ Or is 1 block 8 FNs here? https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/33b55a18_01d7f7cb PS1, Line 26: /* TCH/H(1): 14, 16, 18, 20, 66, 68, 70, 72 */ same https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/c99c5bc8_cfc2f016 PS1, Line 65: * There is only one *complete* block in this subset starting at FN=52. So you first say there's a complete block starting at FN=52, but in next line you say the one starting at 52 is incomplete? File tests/meas/meas_test.c: https://gerrit.osmocom.org/c/osmo-bts/+/28086/comment/9f31b6f5_eb6b5008 PS1, Line 385: if (fn == 0) /* H0 block { 0, 2, 4, 6} */ As shared in another patch, switch sounds more clean here imho. Not important though. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/28086 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I8cc3a755a8ad4dc564439aab2298c1e97ac0592d Gerrit-Change-Number: 28086 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 May 2022 10:09:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: acc: Simplify start/stop by using new signal S_NM_RUNNING_CHG
by osmith 10 May '22

10 May '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28079 ) Change subject: acc: Simplify start/stop by using new signal S_NM_RUNNING_CHG ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Patchset: PS1: nice how this is less complex now File src/osmo-bsc/acc.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28079/comment/ba30917e_a32d0827 PS1, Line 433: } this block is the same as in nm_sig_cb. maybe create a function for getting the trx from nsd? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28079 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I2e09bcb18a6c3bb2e88bba98579fb4854a6b0699 Gerrit-Change-Number: 28079 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 May 2022 10:06:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in osmo-bsc[master]: paging: start/stop credit_timer based on C0 running
by osmith 10 May '22

10 May '22

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28047 ) Change subject: paging: start/stop credit_timer based on C0 running ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/osmo-bsc/paging.c: https://gerrit.osmocom.org/c/osmo-bsc/+/28047/comment/813ab5f9_68cadaa0 PS5, Line 728: } (would be more readable if there were some empty lines IMHO, maybe around the switch block and/or below the if (signal ...) return 0?) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28047 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I1b5b1a98115b4e9d821eb3330fc5b970a0e78a44 Gerrit-Change-Number: 28047 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 10 May 2022 09:58:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

2025

2024

2023

2022

gerrit-log May 2022