May 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: coding: prevent marking FACCH frames as AMR's special DTX frames

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28127 ) Change subject: coding: prevent marking FACCH frames as AMR's special DTX frames ...................................................................... coding: prevent marking FACCH frames as AMR's special DTX frames Both gsm0503_tch_a[fh]s_decode_dtx() functions accept an optional 'dtx' pointer, which is used to indicate type of a received AMR block to the caller in DTX mode of operation. If not NULL, it's expected to be updated by gsm0503_detect_a[fh]s_dtx_frame() every time one of the mentioned functions is called. However, in case of FACCH both functions return early, so the value of dtx remains unchanged and thus FACCH frames may be misinterpreted as AMR's special DTX frames. This is rather critical during the DTX silence periods, when all special DTX frames (e.g. SID_UPDATE) are being treated as SUB frames. Each unsuccessful FACCH decoding attempt will 'poison' SUB measurements, causing unexpected RxQual- SUB values in the Uplink measurement reports. Fix this by resetting *dtx to AMR_OTHER in the FACCH specific path. Change-Id: I2e6f4b748c6445725211e264ab5f3f5a2712087a Related: SYS#5853 --- M src/coding/gsm0503_coding.c 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/coding/gsm0503_coding.c b/src/coding/gsm0503_coding.c index 98439e3..e81bf02 100644 --- a/src/coding/gsm0503_coding.c +++ b/src/coding/gsm0503_coding.c @@ -2171,6 +2171,12 @@ gsm0503_tch_fr_deinterleave(cB, iB); if (steal > 0) { + /* If not NULL, dtx indicates type of previously decoded TCH/AFS frame. + * It's normally updated by gsm0503_detect_afs_dtx_frame(), which is not + * reached in case of FACCH. Reset it here to avoid FACCH/F frames being + * misinterpreted as AMR's special DTX frames. */ + if (dtx != NULL) + *dtx = AMR_OTHER; rv = _xcch_decode_cB(tch_data, cB, n_errors, n_bits_total); if (rv) { /* Error decoding FACCH frame */ @@ -2633,6 +2639,13 @@ /* if we found a stole FACCH, but only at correct alignment */ if (steal > 0) { + /* If not NULL, dtx indicates type of previously decoded TCH/AHS frame. + * It's normally updated by gsm0503_detect_ahs_dtx_frame(), which is not + * reached in case of FACCH. Reset it here to avoid FACCH/H frames being + * misinterpreted as AMR's special DTX frames. */ + if (dtx != NULL) + *dtx = AMR_OTHER; + for (i = 0; i < 6; i++) { gsm0503_tch_burst_unmap(&iB[i * 114], &bursts[i * 116], NULL, i >> 2); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2e6f4b748c6445725211e264ab5f3f5a2712087a Gerrit-Change-Number: 28127 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: prevent marking FACCH frames as AMR's special DTX frames

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28127 ) Change subject: coding: prevent marking FACCH frames as AMR's special DTX frames ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2e6f4b748c6445725211e264ab5f3f5a2712087a Gerrit-Change-Number: 28127 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 May 2022 09:08:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: tests: Remove sms.db{-wal,-shm} files, not just sms.db

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28124 ) Change subject: tests: Remove sms.db{-wal,-shm} files, not just sms.db ...................................................................... tests: Remove sms.db{-wal,-shm} files, not just sms.db ERROR: files left in build directory after distclean: ./sms.db-shm ./tests/sms.db-shm ./tests/sms.db-wal ./sms.db-wal Change-Id: Iecd380f598edbd1635361e4c340d54d092739919 --- M tests/Makefile.am 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified laforge: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/tests/Makefile.am b/tests/Makefile.am index c765158..d25fe16 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -69,7 +69,7 @@ IU=0 osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v endif $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db + rm -f $(top_builddir)/sms.db* # Run a specific transcript test with: 'make vty-transcript-test VTY_TEST=osmo-msc.vty' VTY_TEST ?= *.vty @@ -82,7 +82,7 @@ -n OsmoMSC -p 4254 \ -r "$(top_builddir)/src/osmo-msc/osmo-msc -c $(top_srcdir)/doc/examples/osmo-msc/osmo-msc.cfg" \ $(U) $(srcdir)/$(VTY_TEST) - rm -f $(builddir)/sms.db + rm -f $(builddir)/sms.db* # don't run multiple tests concurrently so that the ports don't conflict vty-test: @@ -91,7 +91,7 @@ ctrl-python-test: $(BUILT_SOURCES) $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db + rm -f $(top_builddir)/sms.db* # To update the CTRL script from current application behavior, # pass -u to ctrl_script_runner.py by doing: @@ -106,7 +106,7 @@ smpp-test: $(srcdir)/smpp_test_runner.py -w $(abs_top_builddir) -v - rm -f $(top_builddir)/sms.db + rm -f $(top_builddir)/sms.db* check-local: atconfig $(TESTSUITE) $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iecd380f598edbd1635361e4c340d54d092739919 Gerrit-Change-Number: 28124 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: tests: Remove sms.db{-wal,-shm} files, not just sms.db

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28124 ) Change subject: tests: Remove sms.db{-wal,-shm} files, not just sms.db ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28124 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iecd380f598edbd1635361e4c340d54d092739919 Gerrit-Change-Number: 28124 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 May 2022 09:07:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: sms_queue: merge sms_pending_add into sms_pending_from

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28119 ) Change subject: sms_queue: merge sms_pending_add into sms_pending_from ...................................................................... sms_queue: merge sms_pending_add into sms_pending_from Both callers would immediately execute sms_pending_add() after a successful sms_pending_from(); we can merge those two functions. Change-Id: Iaf37234b3caafd568dd4fe17739be9ec842c2a8d --- M src/libmsc/sms_queue.c 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/src/libmsc/sms_queue.c b/src/libmsc/sms_queue.c index 461b3af..d10c879 100644 --- a/src/libmsc/sms_queue.c +++ b/src/libmsc/sms_queue.c @@ -203,15 +203,12 @@ vlr_subscr_get(sms->receiver, VSUB_USE_SMS_PENDING); pending->vsub = sms->receiver; pending->sms_id = sms->id; - return pending; -} + llist_add_tail(&pending->entry, &smsq->pending_sms); -/* add (append) a gsm_sms_pending to the queue pending_sms list */ -static void sms_pending_add(struct gsm_sms_queue *smsq, struct gsm_sms_pending *pending) -{ smsq->pending += 1; smsq_stat_item_inc(smsq, SMSQ_STAT_SMS_RAM_PENDING); - llist_add_tail(&pending->entry, &smsq->pending_sms); + + return pending; } /* release a gsm_sms_pending object */ @@ -413,7 +410,6 @@ } attempted += 1; - sms_pending_add(smsq, pending); _gsm411_send_sms(smsq->network, sms->receiver, sms); } while (attempted < attempts && rounds < 1000); @@ -451,7 +447,6 @@ goto no_pending_sms; } - sms_pending_add(smsq, pending); _gsm411_send_sms(smsq->network, sms->receiver, sms); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaf37234b3caafd568dd4fe17739be9ec842c2a8d Gerrit-Change-Number: 28119 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: sms_queue: merge sms_pending_add into sms_pending_from

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28119 ) Change subject: sms_queue: merge sms_pending_add into sms_pending_from ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28119 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iaf37234b3caafd568dd4fe17739be9ec842c2a8d Gerrit-Change-Number: 28119 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 17 May 2022 09:04:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bts[master]: Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SU...

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/28129 ) Change subject: Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SUB frame" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/28129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iebe139632daf1d1f72e39fe9d1497059f68625b9 Gerrit-Change-Number: 28129 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 May 2022 08:09:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: fsm_vty: use unsigned int when left-shifting 31 bits!

by fixeria

Attention is currently required from: laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28128 ) Change subject: fsm_vty: use unsigned int when left-shifting 31 bits! ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637bce52fae947922cbb8642a0313d174c827422 Gerrit-Change-Number: 28128 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 17 May 2022 00:56:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bts[master]: Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SU...

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/28129 ) Change subject: Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SUB frame" ...................................................................... Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SUB frame" This reverts commit 1f9fbd881602f20f5d83b94f2332c18c19b680e0, which was a workaround rather than a proper fix. The root problem has been fixed in libosmocoding [1], so ~50% BER is not the case for AFS_SID_UPDATE frames anymore. Related: I813081a4c0865958eee2496fe251ae17235ac842 (libosmocore.git) Change-Id: Iebe139632daf1d1f72e39fe9d1497059f68625b9 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 1 insertion(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/29/28129/1 diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 067e31a..6a90327 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -171,11 +171,7 @@ "Received AMR DTX frame (rc=%d, BER %d/%d): %s\n", rc, n_errors, n_bits_total, gsm0503_amr_dtx_frame_name(chan_state->amr_last_dtx)); - /* ... except AFS_SID_UPDATE, which is in fact a precursor of - * the actual SID UPDATE frame (AFS_SID_UPDATE_CN) and only - * used internally by gsm0503_tch_afs_decode_dtx() */ - if (chan_state->amr_last_dtx != AFS_SID_UPDATE) - is_sub = 1; + is_sub = 1; } /* The occurrence of the following frames indicates that we -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/28129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iebe139632daf1d1f72e39fe9d1497059f68625b9 Gerrit-Change-Number: 28129 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: fsm_vty: use unsigned int when left-shifting 31 bits!

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28128 ) Change subject: fsm_vty: use unsigned int when left-shifting 31 bits! ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637bce52fae947922cbb8642a0313d174c827422 Gerrit-Change-Number: 28128 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 16 May 2022 20:46:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022