May 2022 - gerrit-log - lists.osmocom.org

Change in osmo-e1-hardware[master]: Doc Update - Build process for DAHDI on Debian 11

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27014 ) Change subject: Doc Update - Build process for DAHDI on Debian 11 ...................................................................... Doc Update - Build process for DAHDI on Debian 11 Change-Id: I0679bd14702b7b3d05c3346ce10358f45fef0301 --- M doc/manuals/chapters/host-software.adoc 1 file changed, 43 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/doc/manuals/chapters/host-software.adoc b/doc/manuals/chapters/host-software.adoc index 4c8578e..e5b0f4f 100644 --- a/doc/manuals/chapters/host-software.adoc +++ b/doc/manuals/chapters/host-software.adoc @@ -44,6 +44,49 @@ When using that DAHDI Linux kernel driver, there is no need for osmo-e1d. The USB interface is directly managed inside the kernel. + +==== Installing DAHDI driver +Example installation steps, tested on Debian 11, for installing DAHDI Linux & DAHDI Tools. +Note: Plugging in the device prior to installing may lead to issues. + +---- +$ sudo apt-get install -y linux-headers-`uname -r` git dfu-util make gcc autoconf libtool libnewt-dev +$ git clone https://git.osmocom.org/dahdi-linux/ +$ git clone https://github.com/asterisk/dahdi-tools +$ cd dahdi-linux +$ sudo make install +$ cd ../dahdi-tools +$ sudo autoreconf -i +$ ./configure +$ sudo make install +$ sudo make install-config +$ sudo modprobe icE1usb +$ sudo /etc/init.d/dahdi start +---- + +At this point you can plug in the icE1usb, which + +* should make the icE1usb enumerate on USB (dmesg, lsusb) +* should and scan for it with `sudo dahdi_scan` which should list the two E1 ports on the iCE1usb. +* see a `/proc/dahdi/N` file (with N being the span number, typically 1 unless you have other spans) +* see the device listed in `dahdi_scan` or `dahdi_tool` + +.Example `dmesg` output when icE1usb is plugged in +---- +usb 2-1: new full-speed USB device number 5 using xhci_hcd +usb 2-1: New USB device found, idVendor=1d50, idProduct=6145, bcdDevice= 0.03 +usb 2-1: New USB device strings: Mfr=2, Product=3, SerialNumber=1 +usb 2-1: Product: icE1usb +usb 2-1: Manufacturer: osmocom +usb 2-1: SerialNumber: dc697407e7682731 +---- + +.Example `lsusb` output after icE1usb is plugged in +---- +$ lsusb -d 1d50: +Bus 002 Device 005: ID 1d50:6145 OpenMoko, Inc. icE1usb +---- + === Other software you can interface 3rd party applications with osmo-e1d in the following -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I0679bd14702b7b3d05c3346ce10358f45fef0301 Gerrit-Change-Number: 27014 Gerrit-PatchSet: 2 Gerrit-Owner: nickvsnetworking <nick(a)nickvsnetworking.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: switch from libdbi to lbsqlite3

by laforge

Attention is currently required from: neels, pespin, keith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28114 ) Change subject: switch from libdbi to lbsqlite3 ...................................................................... Patch Set 8: Verified+1 (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/5a652f65_6ebad7d2 PS8, Line 7: WIP: switch from libdbi to lbsqlite3 > Is it still WIP? it is not File include/osmocom/msc/db.h: https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/030c5345_1b1e4a1a PS8, Line 43: int max_failed); > does it make sense to pass negative values here? no, it doesn't make sense. But the problem is if we pass an unsigned value, it may overflow the signed integer we're passing to sqlite3_bind_int(). There is no sqlite3_bind_uint() equivalent, and keeping it unsigned and passing UINT_MAX will lead to -1 causing failures in the related statements as attempts can never be < 0 .... File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/1d30102f_fb8b6a52 PS8, Line 489: break; > wrong indentation Done -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia334904289f92d014e7bd16b02b3b5817c12c790 Gerrit-Change-Number: 28114 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 17 May 2022 09:34:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: db: Switch from 'synchronous = FULL' to 'synchronous = NORMAL'

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/28130 ) Change subject: db: Switch from 'synchronous = FULL' to 'synchronous = NORMAL' ...................................................................... db: Switch from 'synchronous = FULL' to 'synchronous = NORMAL' As we're using WAL mode, it is not neccessary to use synchronous=FULL but rely on synchronous=NORMAL mode while still guaranteeing database consistency. To do this, we can fix the typo in one of our two PRAGMA statements, and remove the other. See https://www.sqlite.org/pragma.html#pragma_synchronous for the sqlite3 documentation on that topic. Change-Id: Ie782f0fe90e7204c4d55cdb3948b728c348367d1 Closes: OS#5566 RelateD: OS#5564, OS#5563 --- M src/libmsc/db.c 1 file changed, 1 insertion(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/30/28130/1 diff --git a/src/libmsc/db.c b/src/libmsc/db.c index 4c272c1..aa770d6 100644 --- a/src/libmsc/db.c +++ b/src/libmsc/db.c @@ -562,7 +562,7 @@ } char *err_msg; - rc = sqlite3_exec(g_dbc->db, "PRAGMA journal_mode=WAL; PRAGMA synchonous = NORMAL;", 0, 0, &err_msg); + rc = sqlite3_exec(g_dbc->db, "PRAGMA journal_mode=WAL; PRAGMA synchronous = NORMAL;", 0, 0, &err_msg); if (rc != SQLITE_OK) { LOGP(DDB, LOGL_ERROR, "Unable to set Write-Ahead Logging: %s\n", err_msg); sqlite3_free(err_msg); @@ -624,13 +624,6 @@ return rc; } -static int db_configure(struct db_context *dbc) -{ - const char *sync_stmts[] = { "PRAGMA synchronous = FULL" }; - - return db_run_statements(dbc, sync_stmts, ARRAY_SIZE(sync_stmts)); -} - int db_prepare(void) { unsigned int i; @@ -649,8 +642,6 @@ return -1; } - db_configure(g_dbc); - /* prepare all SQL statements */ for (i = 0; i < ARRAY_SIZE(g_dbc->stmt); i++) { rc = sqlite3_prepare_v2(g_dbc->db, stmt_sql[i], -1, -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28130 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie782f0fe90e7204c4d55cdb3948b728c348367d1 Gerrit-Change-Number: 28130 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: switch from libdbi to lbsqlite3

by laforge

Attention is currently required from: neels, laforge, keith. Hello Jenkins Builder, neels, pespin, keith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28114 to look at the new patch set (#9). Change subject: switch from libdbi to lbsqlite3 ...................................................................... switch from libdbi to lbsqlite3 The choice of libdbi was one of the biggest early mistakes in (back then) OpenBSC development. A database abstraction library that prevents you from using proper prepared statements. Let's finally abandon it and use sqlite3 directly, just like we do in osmo-hlr. I decided to remove the database migration code as it would be relatively cumbersome to port all of it to direct sqlite3 with prepared statements, and it is prone to introduction of all kinds of errors. Since we don't have a body of older database files and comprehensive migration tests, it is safer to not offer migration code of uncertain quality. The last schema revision (5) was introduced 5 years ago in 2017 (osmo-msc v1.1.0), so it is considered an exceptionally rare case. People can install osmo-msc 1.1.0 through 1.8.0 to upgrade to v5 before using this new 'direct sqlite3' version of osmo-msc. Change-Id: Ia334904289f92d014e7bd16b02b3b5817c12c790 Related: OS#5559, OS#5563, OS#5564 --- M configure.ac M contrib/osmo-msc.spec.in M debian/control M include/osmocom/msc/db.h M src/libmsc/db.c M src/libmsc/sms_queue.c M src/osmo-msc/Makefile.am M src/osmo-msc/msc_main.c M tests/db_sms/Makefile.am M tests/db_sms/db_sms_test.c M tests/sms_queue/Makefile.am 11 files changed, 670 insertions(+), 721 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/14/28114/9 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia334904289f92d014e7bd16b02b3b5817c12c790 Gerrit-Change-Number: 28114 Gerrit-PatchSet: 9 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: WIP: switch from libdbi to lbsqlite3

by pespin

Attention is currently required from: neels, laforge, keith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28114 ) Change subject: WIP: switch from libdbi to lbsqlite3 ...................................................................... Patch Set 8: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/839b3016_be3a276c PS8, Line 7: WIP: switch from libdbi to lbsqlite3 Is it still WIP? File include/osmocom/msc/db.h: https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/f9610b13_2f83cb08 PS8, Line 43: int max_failed); does it make sense to pass negative values here? File src/libmsc/db.c: https://gerrit.osmocom.org/c/osmo-msc/+/28114/comment/87c1e049_d2dd35eb PS8, Line 489: break; wrong indentation -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28114 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ia334904289f92d014e7bd16b02b3b5817c12c790 Gerrit-Change-Number: 28114 Gerrit-PatchSet: 8 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Tue, 17 May 2022 09:22:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-e1-hardware[master]: Doc Update - Build process for DAHDI on Debian 11

by laforge

Attention is currently required from: nickvsnetworking. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27014 ) Change subject: Doc Update - Build process for DAHDI on Debian 11 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS1: > hi nick, would you mind incorporating the requested feedback so we can get this merged? thanks! decided to update it myself due to lack of response for months. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I0679bd14702b7b3d05c3346ce10358f45fef0301 Gerrit-Change-Number: 27014 Gerrit-PatchSet: 2 Gerrit-Owner: nickvsnetworking <nick(a)nickvsnetworking.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: nickvsnetworking <nick(a)nickvsnetworking.com> Gerrit-Comment-Date: Tue, 17 May 2022 09:17:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-e1-hardware[master]: Doc Update - Build process for DAHDI on Debian 11

by laforge

Attention is currently required from: nickvsnetworking. laforge has uploaded a new patch set (#2) to the change originally created by nickvsnetworking. ( https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27014 ) Change subject: Doc Update - Build process for DAHDI on Debian 11 ...................................................................... Doc Update - Build process for DAHDI on Debian 11 Change-Id: I0679bd14702b7b3d05c3346ce10358f45fef0301 --- M doc/manuals/chapters/host-software.adoc 1 file changed, 43 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1-hardware refs/changes/14/27014/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1-hardware/+/27014 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1-hardware Gerrit-Branch: master Gerrit-Change-Id: I0679bd14702b7b3d05c3346ce10358f45fef0301 Gerrit-Change-Number: 27014 Gerrit-PatchSet: 2 Gerrit-Owner: nickvsnetworking <nick(a)nickvsnetworking.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: nickvsnetworking <nick(a)nickvsnetworking.com> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-bts[master]: Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SU...

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/28129 ) Change subject: Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SUB frame" ...................................................................... Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SUB frame" This reverts commit 1f9fbd881602f20f5d83b94f2332c18c19b680e0, which was a workaround rather than a proper fix. The root problem has been fixed in libosmocoding [1], so ~50% BER is not the case for AFS_SID_UPDATE frames anymore. Related: I813081a4c0865958eee2496fe251ae17235ac842 (libosmocore.git) Change-Id: Iebe139632daf1d1f72e39fe9d1497059f68625b9 --- M src/osmo-bts-trx/sched_lchan_tchf.c 1 file changed, 1 insertion(+), 5 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_tchf.c b/src/osmo-bts-trx/sched_lchan_tchf.c index 067e31a..6a90327 100644 --- a/src/osmo-bts-trx/sched_lchan_tchf.c +++ b/src/osmo-bts-trx/sched_lchan_tchf.c @@ -171,11 +171,7 @@ "Received AMR DTX frame (rc=%d, BER %d/%d): %s\n", rc, n_errors, n_bits_total, gsm0503_amr_dtx_frame_name(chan_state->amr_last_dtx)); - /* ... except AFS_SID_UPDATE, which is in fact a precursor of - * the actual SID UPDATE frame (AFS_SID_UPDATE_CN) and only - * used internally by gsm0503_tch_afs_decode_dtx() */ - if (chan_state->amr_last_dtx != AFS_SID_UPDATE) - is_sub = 1; + is_sub = 1; } /* The occurrence of the following frames indicates that we -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/28129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iebe139632daf1d1f72e39fe9d1497059f68625b9 Gerrit-Change-Number: 28129 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

Change in osmo-bts[master]: Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SU...

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/28129 ) Change subject: Revert "osmo-bts-trx: rx_tchf_fn(): do not treat AFS_SID_UPDATE as SUB frame" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/28129 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iebe139632daf1d1f72e39fe9d1497059f68625b9 Gerrit-Change-Number: 28129 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 May 2022 09:09:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: fsm_vty: use unsigned int when left-shifting 31 bits!

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28128 ) Change subject: fsm_vty: use unsigned int when left-shifting 31 bits! ...................................................................... fsm_vty: use unsigned int when left-shifting 31 bits! fsm_vty.c:64:8: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Change-Id: I637bce52fae947922cbb8642a0313d174c827422 --- M src/vty/fsm_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/vty/fsm_vty.c b/src/vty/fsm_vty.c index 025d0d8..777d38c 100644 --- a/src/vty/fsm_vty.c +++ b/src/vty/fsm_vty.c @@ -61,7 +61,7 @@ if (fsm->event_names) { for (evt_name = fsm->event_names; evt_name->str != NULL; evt_name++) { vty_out(vty, "%s Event %02u (0x%08x): '%s'%s", prefix, evt_name->value, - (1 << evt_name->value), evt_name->str, VTY_NEWLINE); + (1U << evt_name->value), evt_name->str, VTY_NEWLINE); } } else vty_out(vty, "%s No event names are defined for this FSM! Please fix!%s", prefix, VTY_NEWLINE); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/28128 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I637bce52fae947922cbb8642a0313d174c827422 Gerrit-Change-Number: 28128 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022