May 2022 - gerrit-log - lists.osmocom.org

Change in osmo-msc[master]: sms: Give smsc its own VTY config node

by laforge

Attention is currently required from: keith. Hello Jenkins Builder, pespin, keith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28133 to look at the new patch set (#4). Change subject: sms: Give smsc its own VTY config node ...................................................................... sms: Give smsc its own VTY config node The pre-historic sms_queue code used to have very strange aspects, such as having some parameters (max-failure, max-pending) which could only be sent from the 'enable' node, but not from a config file. Before adding more configuration parameters, let's clean this up by introducing a proper VTY config node for the 'smsc'; move the existing config commands there and add new ones for max-failure and max-pending. As the sms_queue data structure is only allocated after the config file parsing happens, we are introducing a new 'sms_queue_config' data structure. This encapsulates the public readable/writable config parameters. Change-Id: Ie8e0ab1a9f979337ff06544b9ab3820954d9804a --- M include/osmocom/msc/sms_queue.h M include/osmocom/msc/vty.h M src/libmsc/Makefile.am M src/libmsc/msc_vty.c M src/libmsc/sms_queue.c A src/libmsc/smsc_vty.c M src/osmo-msc/msc_main.c M tests/test_nodes.vty 8 files changed, 178 insertions(+), 73 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/33/28133/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28133 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie8e0ab1a9f979337ff06544b9ab3820954d9804a Gerrit-Change-Number: 28133 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: sms_queue: Make deletion of messages from DB VTY-configurable

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28135 to look at the new patch set (#2). Change subject: sms_queue: Make deletion of messages from DB VTY-configurable ...................................................................... sms_queue: Make deletion of messages from DB VTY-configurable This introduces some VTY settings that determine if delivered or expired messages should be removed from he SQL database or not. Change-Id: Id6174875d5c01c40d987077651b27ae1acbcaa93 --- M include/osmocom/msc/sms_queue.h M src/libmsc/sms_queue.c M src/libmsc/smsc_vty.c M tests/test_nodes.vty 4 files changed, 39 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/35/28135/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28135 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id6174875d5c01c40d987077651b27ae1acbcaa93 Gerrit-Change-Number: 28135 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: keith <keith(a)rhizomatica.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: smpp: Parse and use SMPP-provided validity period

by laforge

Attention is currently required from: keith. Hello Jenkins Builder, keith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28136 to look at the new patch set (#6). Change subject: smpp: Parse and use SMPP-provided validity period ...................................................................... smpp: Parse and use SMPP-provided validity period Before this patch, we always ignored any SMPP-provided validity period and used '0' which is now, and means it expires immediately. As SMPP allows for validity_period of NULL, use 7 days as SMSC default in such situations. Change-Id: Iad9f2697f045ed3bc0eb74c3a9730861f82e6c48 Closes: OS#5567 --- M configure.ac M src/libmsc/smpp_openbsc.c M src/libmsc/smpp_smsc.h M src/libmsc/smpp_utils.c M tests/smpp/smpp_test.c M tests/smpp/smpp_test.ok 6 files changed, 165 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/36/28136/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iad9f2697f045ed3bc0eb74c3a9730861f82e6c48 Gerrit-Change-Number: 28136 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: sms: Make default SMS validity period configurable via VTY

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28137 to look at the new patch set (#4). Change subject: sms: Make default SMS validity period configurable via VTY ...................................................................... sms: Make default SMS validity period configurable via VTY Change-Id: Ie2c81c1d5795dd9aaf07b9766013f20b01abc762 --- M include/osmocom/msc/sms_queue.h M src/libmsc/smpp_openbsc.c M src/libmsc/sms_queue.c M src/libmsc/smsc_vty.c M tests/test_nodes.vty 5 files changed, 18 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/37/28137/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28137 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie2c81c1d5795dd9aaf07b9766013f20b01abc762 Gerrit-Change-Number: 28137 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: sms: Introduce VTY-configurable minimum SMS validity period

by laforge

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/28138 to look at the new patch set (#4). Change subject: sms: Introduce VTY-configurable minimum SMS validity period ...................................................................... sms: Introduce VTY-configurable minimum SMS validity period This is meant as a safeguard against users or user equipment which doesn't set a reasonable validity period. Using this setting, the SMSC administrator can set a minimum SMS validity period. Any SMS submitted with lower validity period will be extended to that minimum. Change-Id: I192528a6f9059d158fa12876a247d61bd7edaec8 Related: OS#5567 --- M include/osmocom/msc/sms_queue.h M src/libmsc/gsm_04_11.c M src/libmsc/smpp_openbsc.c M src/libmsc/sms_queue.c M src/libmsc/smsc_vty.c M tests/test_nodes.vty 6 files changed, 24 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/38/28138/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28138 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I192528a6f9059d158fa12876a247d61bd7edaec8 Gerrit-Change-Number: 28138 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newpatchset

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: GSUP: add f_unregister_imsi() to unregister an imsi/connhdlr

by pespin

Attention is currently required from: laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28140 ) Change subject: GSUP: add f_unregister_imsi() to unregister an imsi/connhdlr ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28140 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I13f6784533fe0e1f42d9595f028861d4645ec1a9 Gerrit-Change-Number: 28140 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 17 May 2022 18:04:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: smpp: Parse and use SMPP-provided validity period

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28136 ) Change subject: smpp: Parse and use SMPP-provided validity period ...................................................................... Patch Set 5: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iad9f2697f045ed3bc0eb74c3a9730861f82e6c48 Gerrit-Change-Number: 28136 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 17 May 2022 18:03:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: smpp: Parse and use SMPP-provided validity period

by laforge

Attention is currently required from: laforge. laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/28136 ) Change subject: smpp: Parse and use SMPP-provided validity period ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/28136 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Iad9f2697f045ed3bc0eb74c3a9730861f82e6c48 Gerrit-Change-Number: 28136 Gerrit-PatchSet: 5 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-MessageType: deleteVote

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: DIAMETER_Types_ttcn: Generate types for TS 32.299 (Gy)

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28143 ) Change subject: DIAMETER_Types_ttcn: Generate types for TS 32.299 (Gy) ...................................................................... DIAMETER_Types_ttcn: Generate types for TS 32.299 (Gy) Change-Id: I8413781a28362816a1f93790951c125defbbaf6b --- M library/DIAMETER_Types.ttcn M library/regen-DIAMETER_Types_ttcn.sh 2 files changed, 4,649 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/28143/1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8413781a28362816a1f93790951c125defbbaf6b Gerrit-Change-Number: 28143 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Add script to regen library/DIAMETER_Types.ttcn

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28142 ) Change subject: Add script to regen library/DIAMETER_Types.ttcn ...................................................................... Add script to regen library/DIAMETER_Types.ttcn This way we have a reproducible way to generate the same library/DIAMETER_Types.ttcn file. Change-Id: Ie6fdb8003a0faf25a5bf4027b672da73f788988e --- M Makefile A library/regen-DIAMETER_Types_ttcn.sh 2 files changed, 24 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/42/28142/1 diff --git a/Makefile b/Makefile index 1d5e670..fbd380c 100644 --- a/Makefile +++ b/Makefile @@ -110,9 +110,12 @@ $(eval $(call DIR_all_template,$(dir))) \ ) -.PHONY: tags +.PHONY: tags regen-diameter-types-ttcn tags: find $(shell pwd) \ -type f -name "*.ttcn" -o \ -type f -name "*.ttcnpp" | \ xargs ctags + +regen-diameter-types-ttcn: + (cd library/ && ./regen-DIAMETER_Types_ttcn.sh) diff --git a/library/regen-DIAMETER_Types_ttcn.sh b/library/regen-DIAMETER_Types_ttcn.sh new file mode 100755 index 0000000..5f701c8 --- /dev/null +++ b/library/regen-DIAMETER_Types_ttcn.sh @@ -0,0 +1,20 @@ +#!/bin/sh -e + +SELF_DIR="$(CDPATH= cd -- "$(dirname -- "$0")" && pwd)" # dirname of this script (library/) +AVP_SH_DIR="$SELF_DIR/../deps/titan.ProtocolModules.DIAMETER_ProtocolModule_Generator/src" +AVP_SH_PATH="$AVP_SH_DIR/AVP.sh" +cd $AVP_SH_DIR +$AVP_SH_PATH \ + Base_IETF_RFC3588.ddf \ + BaseTypes_IETF_RFC3588.ddf \ + AAAInterface_3GPP_TS29272_f10.ddf \ + GxInterface_PCC_3GPP_TS29212_f10.ddf \ + S6Interfaces_3GPP_TS29336_f00.ddf \ + MobileIPv6_HA_IETF_RFC5778.ddf \ + RxInterface_PCC_3GPP_TS29214_f20.ddf \ + NetworkAccessServer_IETF_RFC4005.ddf \ + CreditControl_IETF_RFC4006.ddf \ + CxDxInterface_3GPP_TS29229_c30.ddf \ + GiSGiInterface_3GPP_TS29061_d70.ddf + +mv -v $AVP_SH_DIR/DIAMETER_Types.ttcn $SELF_DIR/ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28142 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie6fdb8003a0faf25a5bf4027b672da73f788988e Gerrit-Change-Number: 28142 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log May 2022