April 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: coding: fix wrong comments for detect_afs_sid_{first,update,onset}

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/27938 ) Change subject: coding: fix wrong comments for detect_afs_sid_{first,update,onset} ...................................................................... coding: fix wrong comments for detect_afs_sid_{first,update,onset} Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Related: SYS#5853 --- M src/coding/gsm0503_amr_dtx.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/38/27938/1 diff --git a/src/coding/gsm0503_amr_dtx.c b/src/coding/gsm0503_amr_dtx.c index 7069b96..56056eb 100644 --- a/src/coding/gsm0503_amr_dtx.c +++ b/src/coding/gsm0503_amr_dtx.c @@ -163,19 +163,19 @@ return *n_errors < *n_bits_total / 8; } -/* Detect a an FR AMR SID_FIRST frame by its identifcation marker */ +/* Detect a TCH/AFS SID_FIRST frame by its identifcation marker */ static bool detect_afs_sid_first(int *n_errors, int *n_bits_total, const ubit_t * ubits) { return detect_afs_id_marker(n_errors, n_bits_total, ubits, 32, 53, id_marker_0, 9); } -/* Detect an FR AMR SID_FIRST frame by its identification marker */ +/* Detect a TCH/AFS SID_UPDATE frame by its identification marker */ static bool detect_afs_sid_update(int *n_errors, int *n_bits_total, const ubit_t * ubits) { return detect_afs_id_marker(n_errors, n_bits_total, ubits, 36, 53, id_marker_0, 9); } -/* Detect an FR AMR SID_FIRST frame by its repeating coded inband data */ +/* Detect a TCH/AFS SID_ONSET frame by its repeating coded inband data */ static bool detect_afs_onset(int *n_errors, int *n_bits_total, const ubit_t * ubits) { bool rc; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-msc[master]: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE

by neels

neels has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/12349 ) Change subject: improve handling of BSC-chosen algo in CIPHER MODE COMPLETE ...................................................................... Abandoned timeout -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/12349 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I3260bee43cfe135ebfc33c13aee3c4ba43466c81 Gerrit-Change-Number: 12349 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Sperling <stsp(a)stsp.name> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <suraev(a)alumni.ntnu.no> Gerrit-Reviewer: Stefan Sperling <stsp(a)stsp.name> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: abandon

3 years, 2 months

1
0
0 0

Change in osmo-msc[master]: CM Serv Rej: do not crash on use count mismatch

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/27916 ) Change subject: CM Serv Rej: do not crash on use count mismatch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > does it make sense to send a CM Serv Rej despite no CM Serv Request was sent in first place? Probabl […] IIUC the sequence of events is: CM Serv Req received, MSC does not allow CM Serv Req for some reason (hence no use count), still wants to send CM Serv Rej message, there is no use count to decrease, entire MSC shuts down. I think some time could be spent on reviewing the CM Service use tokens, but that's likely nontrivial (IOW i'm lazy). What I'm sure of is that we don't want to shut down the entire MSC just because some minor use count got confused. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/27916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2009df42d1f27ec0d011e22bfc46dbc17afe7239 Gerrit-Change-Number: 27916 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 25 Apr 2022 21:31:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: TC_emerg_premption: test RR rel cause

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27906 ) Change subject: bsc: TC_emerg_premption: test RR rel cause ...................................................................... bsc: TC_emerg_premption: test RR rel cause Related: OS#5534 Depends: I0423621d15ace11a53ae1653e5e7f5cb93605edb (osmo-bsc) Change-Id: I47e919edc25a8427f49d654f97f05e46a89da16d --- M bsc/BSC_Tests.ttcn 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 33f4796..59b87dd 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9024,12 +9024,17 @@ f_ctrl_get_exp_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:total", chreq_total + NUM_TCHF_PER_BTS + NUM_TCHH_PER_BTS + NUM_SDCCH_PER_BTS); + /* Send EST IND for the first TCH, so we get to test the RR release cause */ + var RslChannelNr first_tch := valueof(t_RslChanNr_Bm(1)); + var octetstring l3 := '00010203040506'O; + f_ipa_tx(0, ts_RSL_EST_IND(first_tch, valueof(ts_RslLinkID_DCCH(0)), l3)); + /* Send Channel request for emegergency call */ f_ipa_tx(0, ts_RSL_CHAN_RQD('A5'O, 23)); /* Expect the BSC to release one (the first) TCH/F on the BTS */ - var RslChannelNr first_tch := valueof(t_RslChanNr_Bm(1)); - f_expect_chan_rel(0, first_tch, expect_rr_chan_rel := false, expect_rll_rel_req := false); + f_expect_chan_rel(0, first_tch, expect_rr_chan_rel := true, expect_rll_rel_req := false, + expect_rr_cause := GSM48_RR_CAUSE_PREMPTIVE_REL); /* Expect the BSC to send activate/assign the channel for the emergency call */ rx_rsl := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27906 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I47e919edc25a8427f49d654f97f05e46a89da16d Gerrit-Change-Number: 27906 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: TC_emerg_premption: check BSSMAP Clear Req cause

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27915 ) Change subject: bsc: TC_emerg_premption: check BSSMAP Clear Req cause ...................................................................... bsc: TC_emerg_premption: check BSSMAP Clear Req cause On the first TCH, establish Layer 3 so that the BSC will issue a Clear Request at all. Verify the cause value of the Clear Request. Tear down the established Layer 3: clean up for the leak check. Related: OS#5535 Depends: I20108f7b4769400b89b7b0d65c8dab883bf87c46 (osmo-bsc) Change-Id: Ib13be73119cfc96712f32899c02e655e1751d547 --- M bsc/BSC_Tests.ttcn 1 file changed, 21 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve neels: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 59b87dd..5779990 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9029,6 +9029,12 @@ var octetstring l3 := '00010203040506'O; f_ipa_tx(0, ts_RSL_EST_IND(first_tch, valueof(ts_RslLinkID_DCCH(0)), l3)); + /* Accept BSSAP conn, so we get to test the Clear Request cause */ + var BSSAP_N_CONNECT_ind rx_c_ind; + BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(l3))) -> value rx_c_ind; + var integer sccp_conn_id := rx_c_ind.connectionId; + BSSAP.send(ts_BSSAP_CONNECT_res(rx_c_ind.connectionId)); + /* Send Channel request for emegergency call */ f_ipa_tx(0, ts_RSL_CHAN_RQD('A5'O, 23)); @@ -9036,6 +9042,15 @@ f_expect_chan_rel(0, first_tch, expect_rr_chan_rel := true, expect_rll_rel_req := false, expect_rr_cause := GSM48_RR_CAUSE_PREMPTIVE_REL); + /* Also expect a BSSMAP Clear Request with PREEMPTION */ + var BSSAP_N_DATA_ind rx_clear_req; + const myBSSMAP_Cause preemption := GSM0808_CAUSE_PREEMPTION; + BSSAP.receive(tr_BSSAP_DATA_ind(sccp_conn_id, tr_BSSMAP_ClearRequest)) -> value rx_clear_req; + log("XXX ", rx_clear_req); + if (rx_clear_req.userData.pdu.bssmap.clearRequest.cause.causeValue != int2bit(enum2int(preemption), 7)) { + setverdict(fail, "BSSMAP Clear Request: expected cause PREEMPTION"); + } + /* Expect the BSC to send activate/assign the channel for the emergency call */ rx_rsl := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); if (first_tch != rx_rsl.ies[0].body.chan_nr) { @@ -9044,6 +9059,12 @@ f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(first_tch, 33)); rx_rsl := f_exp_ipa_rx(0, tr_RSL_IMM_ASSIGN(0)); + /* complete the BSSMAP Clear to satisfy the conn leak check */ + BSSAP.send(ts_BSSAP_DATA_req(sccp_conn_id, ts_BSSMAP_ClearCommand(enum2int(preemption)))); + BSSAP.receive(tr_BSSAP_DATA_ind(sccp_conn_id, tr_BSSMAP_ClearComplete)) { + BSSAP.send(ts_BSSAP_DISC_req(sccp_conn_id, 0)); + } + f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27915 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib13be73119cfc96712f32899c02e655e1751d547 Gerrit-Change-Number: 27915 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: TC_emerg_premption: clarify chan_nr

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27905 ) Change subject: bsc: TC_emerg_premption: clarify chan_nr ...................................................................... bsc: TC_emerg_premption: clarify chan_nr Rename chan_nr to first_tch, and more clearly show that the TCH that is released gets assigned to the emergency call. Related: OS#5534 Change-Id: I0c540d76eedfd4115b410921bf5a0b6c2d00b5c2 --- M bsc/BSC_Tests.ttcn 1 file changed, 8 insertions(+), 7 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index e17285e..33f4796 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -9007,7 +9007,6 @@ var integer i; var integer chreq_total, chreq_nochan; var RSL_Message rx_rsl; - var RslChannelNr chan_nr; f_init(1); f_sleep(1.0); @@ -9019,7 +9018,7 @@ chreq_total := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:total"); chreq_nochan := f_ctrl_get_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:no_channel"); for (i := 0; i < NUM_TCHF_PER_BTS + NUM_TCHH_PER_BTS + NUM_SDCCH_PER_BTS; i := i+1) { - chan_nr := f_chreq_act_ack('33'O, i); + f_chreq_act_ack('33'O, i); } IPA_RSL[0].clear; f_ctrl_get_exp_ratectr_abs(IPA_CTRL, "bts", 0, "chreq:total", @@ -9029,13 +9028,15 @@ f_ipa_tx(0, ts_RSL_CHAN_RQD('A5'O, 23)); /* Expect the BSC to release one (the first) TCH/F on the BTS */ - chan_nr := valueof(t_RslChanNr_Bm(1)); - f_expect_chan_rel(0, chan_nr, expect_rr_chan_rel := false, expect_rll_rel_req := false); + var RslChannelNr first_tch := valueof(t_RslChanNr_Bm(1)); + f_expect_chan_rel(0, first_tch, expect_rr_chan_rel := false, expect_rll_rel_req := false); - /* Expect the BSC to send activate/assign the a channel for the emergency call */ + /* Expect the BSC to send activate/assign the channel for the emergency call */ rx_rsl := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_CHAN_ACTIV)); - chan_nr := rx_rsl.ies[0].body.chan_nr; - f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(chan_nr, 33)); + if (first_tch != rx_rsl.ies[0].body.chan_nr) { + setverdict(fail, "different TCH lchan activated than expected"); + } + f_ipa_tx(0, ts_RSL_CHAN_ACT_ACK(first_tch, 33)); rx_rsl := f_exp_ipa_rx(0, tr_RSL_IMM_ASSIGN(0)); f_shutdown_helper(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27905 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0c540d76eedfd4115b410921bf5a0b6c2d00b5c2 Gerrit-Change-Number: 27905 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call deny: log on LOGL_ERROR

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27904 ) Change subject: emerg call deny: log on LOGL_ERROR ...................................................................... emerg call deny: log on LOGL_ERROR Change-Id: Id6ea25484479bfc1728124df8fe8e2e03bcee3ec --- M src/osmo-bsc/gsm_04_08_rr.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c index e2bcaa9..761a801 100644 --- a/src/osmo-bsc/gsm_04_08_rr.c +++ b/src/osmo-bsc/gsm_04_08_rr.c @@ -1060,14 +1060,14 @@ * VTY configuration does not permit. */ if (msg_type == GSM48_MT_CC_EMERG_SETUP) { if (msg->lchan->ts->trx->bts->si_common.rach_control.t2 & 0x4) { - LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP although EMERGENCY CALLS" + LOG_LCHAN(msg->lchan, LOGL_ERROR, "MS attempts EMERGENCY SETUP although EMERGENCY CALLS" " are not allowed in sysinfo (cfg: network / bts / rach emergency call allowed 0)\n"); lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PROT_ERROR_UNSPC, gscon_last_eutran_plmn(msg->lchan->conn)); break; } if (!conn->sccp.msc->allow_emerg) { - LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP, but EMERGENCY CALLS are" + LOG_LCHAN(msg->lchan, LOGL_ERROR, "MS attempts EMERGENCY SETUP, but EMERGENCY CALLS are" " denied on MSC %d (cfg: msc %d / allow-emergency deny)\n", conn->sccp.msc->nr, conn->sccp.msc->nr); lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PROT_ERROR_UNSPC, -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27904 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id6ea25484479bfc1728124df8fe8e2e03bcee3ec Gerrit-Change-Number: 27904 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call: send BSSMAP Clear Req cause as preemption

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27914 ) Change subject: emerg call: send BSSMAP Clear Req cause as preemption ...................................................................... emerg call: send BSSMAP Clear Req cause as preemption After the lchan release, the gscon would go into the Clear dance with an arbitrary cause value. Instead, explicitly ask for a Clear upon pre-emption, with the proper cause value. Related: OS#5535 Change-Id: I20108f7b4769400b89b7b0d65c8dab883bf87c46 --- M include/osmocom/bsc/bsc_subscr_conn_fsm.h M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/bsc_subscr_conn_fsm.c 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/bsc/bsc_subscr_conn_fsm.h b/include/osmocom/bsc/bsc_subscr_conn_fsm.h index 0e495aa..0ab4843 100644 --- a/include/osmocom/bsc/bsc_subscr_conn_fsm.h +++ b/include/osmocom/bsc/bsc_subscr_conn_fsm.h @@ -66,6 +66,7 @@ void gscon_submit_rsl_dtap(struct gsm_subscriber_connection *conn, struct msgb *msg, int link_id, int allow_sacch); int gscon_sigtran_send(struct gsm_subscriber_connection *conn, struct msgb *msg); +void gscon_bssmap_clear(struct gsm_subscriber_connection *conn, enum gsm0808_cause cause); struct osmo_mgcpc_ep *gscon_ensure_mgw_endpoint(struct gsm_subscriber_connection *conn, uint16_t msc_assigned_cic, struct gsm_lchan *for_lchan); diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index c50cfeb..627af11 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -2058,6 +2058,11 @@ "CHAN RQD/EMERGENCY-PRIORITY: inducing termination of lchan %s (state:%s) in favor of incoming EMERGENCY CALL!\n", gsm_lchan_name(release_lchan), osmo_fsm_inst_state_name(release_lchan->fi)); + /* Make sure the Clear Request to the MSC has the proper cause */ + if (release_lchan->conn) + gscon_bssmap_clear(release_lchan->conn, GSM0808_CAUSE_PREEMPTION); + /* The gscon FSM would only release the lchan after the MSC responds with a Clear Command. + * But we need it released right now. Also with the right RR cause. */ lchan_release(release_lchan, !!(release_lchan->conn), true, GSM48_RR_CAUSE_PREMPTIVE_REL, gscon_last_eutran_plmn(release_lchan->conn)); diff --git a/src/osmo-bsc/bsc_subscr_conn_fsm.c b/src/osmo-bsc/bsc_subscr_conn_fsm.c index bb96aeb..428d200 100644 --- a/src/osmo-bsc/bsc_subscr_conn_fsm.c +++ b/src/osmo-bsc/bsc_subscr_conn_fsm.c @@ -144,8 +144,7 @@ return rc; } -static void gscon_bssmap_clear(struct gsm_subscriber_connection *conn, - enum gsm0808_cause cause) +void gscon_bssmap_clear(struct gsm_subscriber_connection *conn, enum gsm0808_cause cause) { /* already clearing? */ switch (conn->fi->state) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27914 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I20108f7b4769400b89b7b0d65c8dab883bf87c46 Gerrit-Change-Number: 27914 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call: tweak log, comments

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27901 ) Change subject: emerg call: tweak log, comments ...................................................................... emerg call: tweak log, comments Change-Id: I01e457ae6a9a951a2525c2159cb5979a0cb8bd95 --- M src/osmo-bsc/abis_rsl.c M src/osmo-bsc/gsm_04_08_rr.c 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/abis_rsl.c b/src/osmo-bsc/abis_rsl.c index 94b6349..c50cfeb 100644 --- a/src/osmo-bsc/abis_rsl.c +++ b/src/osmo-bsc/abis_rsl.c @@ -1960,7 +1960,7 @@ if (rqd->reason == GSM_CHREQ_REASON_EMERG) { if (bts->si_common.rach_control.t2 & 0x4) { LOG_BTS(bts, DRSL, LOGL_NOTICE, "CHAN RQD: MS attempts EMERGENCY CALL although EMERGENCY CALLS " - "are not allowed in sysinfo (spec violation by MS!)\n"); + "are not allowed in sysinfo (cfg: network / bts / rach emergency call allowed 0)\n"); rsl_tx_imm_ass_rej(bts, &rqd->ref); talloc_free(rqd); return 0; @@ -2067,7 +2067,7 @@ lchan_release(release_lchan, !!(release_lchan->conn), true, GSM48_RR_CAUSE_PREMPTIVE_REL, gscon_last_eutran_plmn(release_lchan->conn)); } else { - /* BTS is shutting down, give up... */ + /* if BTS has shut down, give up... */ if (rqd->release_lchan->ts->fi->state == TS_ST_NOT_INITIALIZED) return false; diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c index d1d61d6..02bb996 100644 --- a/src/osmo-bsc/gsm_04_08_rr.c +++ b/src/osmo-bsc/gsm_04_08_rr.c @@ -1061,14 +1061,15 @@ if (msg_type == GSM48_MT_CC_EMERG_SETUP) { if (msg->lchan->ts->trx->bts->si_common.rach_control.t2 & 0x4) { LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP although EMERGENCY CALLS" - " are not allowed in sysinfo (spec violation by MS!)\n"); + " are not allowed in sysinfo (cfg: network / bts / rach emergency call allowed 0)\n"); lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PREMPTIVE_REL, gscon_last_eutran_plmn(msg->lchan->conn)); break; } if (!conn->sccp.msc->allow_emerg) { LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP, but EMERGENCY CALLS are" - " denied on this BSC (check BTS config!)\n"); + " denied on MSC %d (cfg: msc %d / allow-emergency deny)\n", + conn->sccp.msc->nr, conn->sccp.msc->nr); lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PREMPTIVE_REL, gscon_last_eutran_plmn(msg->lchan->conn)); break; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27901 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I01e457ae6a9a951a2525c2159cb5979a0cb8bd95 Gerrit-Change-Number: 27901 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-bsc[master]: emerg call deny: fix RR release cause

by neels

neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27902 ) Change subject: emerg call deny: fix RR release cause ...................................................................... emerg call deny: fix RR release cause So far the we indicated pre-emption in the release cause of denying an emergency setup, instead indicate protocol error. When emergency calls are disallowed, it is not pre-emption (making room for an emergency call) but a protocol error (MS asks for emergency call when the network does not allow it). Related: OS#5534 Change-Id: Ia195621165cb7bbe33e6c2e915abc42ab16a2a4f --- M src/osmo-bsc/gsm_04_08_rr.c 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/gsm_04_08_rr.c b/src/osmo-bsc/gsm_04_08_rr.c index 02bb996..e2bcaa9 100644 --- a/src/osmo-bsc/gsm_04_08_rr.c +++ b/src/osmo-bsc/gsm_04_08_rr.c @@ -1062,7 +1062,7 @@ if (msg->lchan->ts->trx->bts->si_common.rach_control.t2 & 0x4) { LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP although EMERGENCY CALLS" " are not allowed in sysinfo (cfg: network / bts / rach emergency call allowed 0)\n"); - lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PREMPTIVE_REL, + lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PROT_ERROR_UNSPC, gscon_last_eutran_plmn(msg->lchan->conn)); break; } @@ -1070,7 +1070,7 @@ LOG_LCHAN(msg->lchan, LOGL_NOTICE, "MS attempts EMERGENCY SETUP, but EMERGENCY CALLS are" " denied on MSC %d (cfg: msc %d / allow-emergency deny)\n", conn->sccp.msc->nr, conn->sccp.msc->nr); - lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PREMPTIVE_REL, + lchan_release(msg->lchan, true, true, GSM48_RR_CAUSE_PROT_ERROR_UNSPC, gscon_last_eutran_plmn(msg->lchan->conn)); break; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27902 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia195621165cb7bbe33e6c2e915abc42ab16a2a4f Gerrit-Change-Number: 27902 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022