April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchh,tchf}_fn(): improve logging of AMR DTX frames

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27940 ) Change subject: osmo-bts-trx: rx_{tchh,tchf}_fn(): improve logging of AMR DTX frames ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0ec06113fff2a89d7810cd4d8c26d6e0c74f93bd Gerrit-Change-Number: 27940 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:57:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: simplify detect_ahs_id_marker()

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27939 ) Change subject: coding: simplify detect_ahs_id_marker() ...................................................................... Patch Set 3: (1 comment) File src/coding/gsm0503_amr_dtx.c: https://gerrit.osmocom.org/c/libosmocore/+/27939/comment/5af88ee6_c3fcf1b5 PS3, Line 104: /* Check first identification marker bits (23*9 bits) */ > 23*9 = 207. You do 212 now. […] 23 * 9 = 207 in this loop, plus 5 bits from the loop below, so 212 is correct. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8 Gerrit-Change-Number: 27939 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:57:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: fix comments for detect_afs_sid_{first,update,onset}

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27938 ) Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ...................................................................... Patch Set 2: (1 comment) File src/coding/gsm0503_amr_dtx.c: https://gerrit.osmocom.org/c/libosmocore/+/27938/comment/c52a552b_5d0380ac PS2, Line 179: static bool detect_afs_onset(int *n_errors, int *n_bits_total, const ubit_t * ubits) > shouldn't this function be renamed to detect_afs_sid_onset to be like the others? Actually, it should be just 'ONSET' in the comment without 'SID', because this is how the spec. defines this frame. And no, the function name is correct. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:53:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: simplify detect_ahs_id_marker()

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27939 ) Change subject: coding: simplify detect_ahs_id_marker() ...................................................................... Patch Set 3: (1 comment) File src/coding/gsm0503_amr_dtx.c: https://gerrit.osmocom.org/c/libosmocore/+/27939/comment/b19f73d9_8589d83d PS3, Line 104: /* Check first identification marker bits (23*9 bits) */ 23*9 = 207. You do 212 now. This patch really needs a better description than it currently has. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27939 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I240bac2725d6544b609f7f288071d3a431132fd8 Gerrit-Change-Number: 27939 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:47:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: coding: fix comments for detect_afs_sid_{first,update,onset}

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27938 ) Change subject: coding: fix comments for detect_afs_sid_{first,update,onset} ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/coding/gsm0503_amr_dtx.c: https://gerrit.osmocom.org/c/libosmocore/+/27938/comment/e14873b9_09560f15 PS2, Line 179: static bool detect_afs_onset(int *n_errors, int *n_bits_total, const ubit_t * ubits) shouldn't this function be renamed to detect_afs_sid_onset to be like the others? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I42edc3caee09c1a4bebecc41e8be46914dc7f8ef Gerrit-Change-Number: 27938 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:44:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in libosmocore[master]: Use internal <osmocom/core/talloc.h> everywhere

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/27937 ) Change subject: Use internal <osmocom/core/talloc.h> everywhere ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: what's the rationale/need behind this patch? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/27937 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: If40e1eefcfa88a2b376becfe057836acdd3a1cc2 Gerrit-Change-Number: 27937 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:43:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-msc[master]: CM Serv Rej: do not crash on use count mismatch

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/27916 ) Change subject: CM Serv Rej: do not crash on use count mismatch ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > IIUC the sequence of events is: […] That's my point, this shutdown is done because something is wrong in the code. Your patch is basically silencing the bug, not fixing it. IMHO we should fix the CM Serv Rej with usecount if CM Serv Req was not done. At least it should be investigated. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/27916 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I2009df42d1f27ec0d011e22bfc46dbc17afe7239 Gerrit-Change-Number: 27916 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:42:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-mgw[master]: rework the counters and stats so they work with the threaded mgw

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/26190 ) Change subject: rework the counters and stats so they work with the threaded mgw ...................................................................... Patch Set 13: (9 comments) File include/osmocom/mgcp/mgcp_trunk.h: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/comment/241577c6_fb79c067 PS13, Line 38: struct mgcp_ratectr_trunk ratectr; /* NULL for the threads! */ And this kind of stuff is what makes me speak again about having different structs for the global state and one for each worker thread. File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/comment/3f1d0163_347537f3 PS13, Line 128: if (endp->callid) { So these stats are being dropped? why? I don't recall reading about it in the commit description. File src/libosmo-mgcp/mgcp_stat.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/comment/e4e8553e_45ecaa82 PS13, Line 84: atomic_uint_least64_t packets_rx = conn->atomic_counters[RTP_PACKETS_RX_CTR]; AFAIU these don't need to be atomic, since they are basically copied locally and used here, no synchonization needs to happen back. File src/libosmo-mgcp/mgcp_threads.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/comment/43193be7_c55f3b34 PS13, Line 428: for (int i = 0; i < _MGCP_GENERAL_NUM_ENUMS; i++) { This kind of loops make me thing whether we'd be better using a mutex rather than accessing crazy amounts of atomic variables (barriers, etc.) https://gerrit.osmocom.org/c/osmo-mgw/+/26190/comment/2dbf0814_e82c8eff PS13, Line 433: atomic_uint_least64_t endpoints_used = 0; why does this need to be atomic? It's just a local variable not being accessed by other threads? https://gerrit.osmocom.org/c/osmo-mgw/+/26190/comment/e891b57e_33e1722b PS13, Line 490: /* wait for the threads to be done with init, so main thread can safely read atomics*/ space: atomics */ File src/libosmo-mgcp/mgcp_threads_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/comment/271344c9_1f30c61f PS13, Line 34: atomic_uint_least64_t tx_packets, tx_bytes; same ehre, why are these atomic? File src/libosmo-mgcp/mgcp_trunk.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/comment/fa73d7f9_686e2888 PS13, Line 143: trunk->number_endpoints = number_endpoints; another stat being removed here? File tests/mgcp/mgcp_test.c: https://gerrit.osmocom.org/c/osmo-mgw/+/26190/comment/008d4859_bb485834 PS13, Line 1315: atomic_uint_least64_t test_ctr_in; no need to be atomic? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/26190 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Iaab3fc262649cb5fb886f0297a60286bde1ffeb0 Gerrit-Change-Number: 26190 Gerrit-PatchSet: 13 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: dexter <pmaier(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:39:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: TC_paging_500req: Validate initial transmissions have higher prio

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27927 ) Change subject: bsc: TC_paging_500req: Validate initial transmissions have higher prio ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27927 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5876f828b43e1e51bd892ce3c9a4dbed6b53f066 Gerrit-Change-Number: 27927 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:23:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

Change in osmo-bsc[master]: Introduce VTY command 'ccch load-indication-period <0-255>'

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27933 ) Change subject: Introduce VTY command 'ccch load-indication-period <0-255>' ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/osmo-bsc/bts_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/27933/comment/dc36d12b_6fd4fc90 PS1, Line 932: 256 > You cannot store 256 in a uint8_t. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27933 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id9d23238863c02a72bcf32942f6b0d40be127904 Gerrit-Change-Number: 27933 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 26 Apr 2022 09:23:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 1 month

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022