April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: pdch is_enabled: Use API getter instead of accessing field directly

by pespin

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27637 ) Change subject: pdch is_enabled: Use API getter instead of accessing field directly ...................................................................... Patch Set 1: (1 comment) File src/gprs_bssgp_pcu.c: https://gerrit.osmocom.org/c/osmo-pcu/+/27637/comment/bb45530a_97e31695 PS1, Line 785: m_is_enabled > Hmm, I would expect it to be private. it's probably half way towards being C. Maybe I added the C API afterwards. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I389f42ef2e95d28643ec51771e46d083d4e20057 Gerrit-Change-Number: 27637 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Fri, 01 Apr 2022 16:31:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-pcu[master]: ms: validate codel enabled against proper define

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27634 ) Change subject: ms: validate codel enabled against proper define ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7c4bda5977a94c2aaf01ca368570f80fd6ebae00 Gerrit-Change-Number: 27634 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Apr 2022 16:31:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-pcu[master]: pdch is_enabled: Use API getter instead of accessing field directly

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27637 ) Change subject: pdch is_enabled: Use API getter instead of accessing field directly ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File src/gprs_bssgp_pcu.c: https://gerrit.osmocom.org/c/osmo-pcu/+/27637/comment/651277c9_b7715933 PS1, Line 785: m_is_enabled Hmm, I would expect it to be private. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I389f42ef2e95d28643ec51771e46d083d4e20057 Gerrit-Change-Number: 27637 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Apr 2022 16:30:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-pcu[master]: pdch is_enabled: Use API getter instead of accessing field directly

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27637 ) Change subject: pdch is_enabled: Use API getter instead of accessing field directly ...................................................................... pdch is_enabled: Use API getter instead of accessing field directly Change-Id: I389f42ef2e95d28643ec51771e46d083d4e20057 --- M src/gprs_bssgp_pcu.c M src/pcu_l1_if.cpp 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/37/27637/1 diff --git a/src/gprs_bssgp_pcu.c b/src/gprs_bssgp_pcu.c index bf82fc4..8fd6d85 100644 --- a/src/gprs_bssgp_pcu.c +++ b/src/gprs_bssgp_pcu.c @@ -782,7 +782,7 @@ for (ts_no = 0; ts_no < ARRAY_SIZE(trx->pdch); ++ts_no) { const struct gprs_rlcmac_pdch *pdch = &trx->pdch[ts_no]; - if (pdch->m_is_enabled) + if (pdch_is_enabled(pdch)) num_pdch += 1; } } diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp index d0698d9..221a1f7 100644 --- a/src/pcu_l1_if.cpp +++ b/src/pcu_l1_if.cpp @@ -540,7 +540,7 @@ /* Make sure PDCH time-slot is enabled */ pdch = &bts->trx[trx].pdch[ts]; - if (!pdch->m_is_enabled) + if (!pdch_is_enabled(pdch)) return -EAGAIN; /* If there's no TBF attached to this PDCH, we can skip Tx of PTCCH -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27637 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I389f42ef2e95d28643ec51771e46d083d4e20057 Gerrit-Change-Number: 27637 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-pcu[master]: gprs_ms_storage: MS always has non NULL ms->bts

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27636 ) Change subject: gprs_ms_storage: MS always has non NULL ms->bts ...................................................................... gprs_ms_storage: MS always has non NULL ms->bts An MS object is always attached to a BTS through its lifespan. Change-Id: Ie9ed9341a82b5edaee09da9156e95a616088f950 --- M src/gprs_ms_storage.cpp 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/36/27636/1 diff --git a/src/gprs_ms_storage.cpp b/src/gprs_ms_storage.cpp index aa0fc9e..b98104d 100644 --- a/src/gprs_ms_storage.cpp +++ b/src/gprs_ms_storage.cpp @@ -28,8 +28,7 @@ static void ms_storage_ms_idle_cb(struct GprsMs *ms) { llist_del(&ms->list); - if (ms->bts) - bts_stat_item_add(ms->bts, STAT_MS_PRESENT, -1); + bts_stat_item_add(ms->bts, STAT_MS_PRESENT, -1); if (ms_is_idle(ms)) talloc_free(ms); } -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27636 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie9ed9341a82b5edaee09da9156e95a616088f950 Gerrit-Change-Number: 27636 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-pcu[master]: ms: validate codel enabled against proper define

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27634 ) Change subject: ms: validate codel enabled against proper define ...................................................................... ms: validate codel enabled against proper define This is a cosmetic change, since LLC_CODEL_DISABLE is defined as 0. It clarifies though the meaning of the if condition. Change-Id: I7c4bda5977a94c2aaf01ca368570f80fd6ebae00 --- M src/gprs_ms.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/34/27634/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index c10eda7..3167dee 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -119,7 +119,7 @@ if (ms->bts) codel_interval = the_pcu->vty.llc_codel_interval_msec; - if (codel_interval) { + if (codel_interval != LLC_CODEL_DISABLE) { if (codel_interval == LLC_CODEL_USE_DEFAULT) codel_interval = GPRS_CODEL_SLOW_INTERVAL_MS; ms->codel_state = talloc(ms, struct gprs_codel); -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27634 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I7c4bda5977a94c2aaf01ca368570f80fd6ebae00 Gerrit-Change-Number: 27634 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-pcu[master]: ms: Remove unneeded bts!=NULL check

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27635 ) Change subject: ms: Remove unneeded bts!=NULL check ...................................................................... ms: Remove unneeded bts!=NULL check The ms_alloc function is expected to always have a proper bts object passed, since an ms is always attached at a BTS. Change-Id: I10b3c94dcb2fed4bff40b1ab7ea455175cf77ce4 --- M src/gprs_ms.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/35/27635/1 diff --git a/src/gprs_ms.c b/src/gprs_ms.c index 3167dee..63f454f 100644 --- a/src/gprs_ms.c +++ b/src/gprs_ms.c @@ -90,6 +90,7 @@ struct GprsMs *ms_alloc(struct gprs_rlcmac_bts *bts, uint32_t tlli) { struct GprsMs *ms = talloc_zero(tall_pcu_ctx, struct GprsMs); + OSMO_ASSERT(bts); talloc_set_destructor(ms, ms_talloc_destructor); @@ -116,8 +117,7 @@ ms_set_mode(ms, GPRS); - if (ms->bts) - codel_interval = the_pcu->vty.llc_codel_interval_msec; + codel_interval = the_pcu->vty.llc_codel_interval_msec; if (codel_interval != LLC_CODEL_DISABLE) { if (codel_interval == LLC_CODEL_USE_DEFAULT) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27635 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I10b3c94dcb2fed4bff40b1ab7ea455175cf77ce4 Gerrit-Change-Number: 27635 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-pcu[master]: WIP: llc: schedule frames to MS based on SAPI priority

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-pcu/+/27627 to look at the new patch set (#2). Change subject: WIP: llc: schedule frames to MS based on SAPI priority ...................................................................... WIP: llc: schedule frames to MS based on SAPI priority Related: OS#5508 Related: SYS#5908 Change-Id: Ie8bd91eeac4fa7487d4f11b808dea95737041c7e --- M src/llc.c M src/llc.h 2 files changed, 90 insertions(+), 37 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/27/27627/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie8bd91eeac4fa7487d4f11b808dea95737041c7e Gerrit-Change-Number: 27627 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: Introduce test TC_dl_llc_sapi_priority

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27633 ) Change subject: pcu: Introduce test TC_dl_llc_sapi_priority ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27633 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I26308a59718a6470853c964583a39986006e59c0 Gerrit-Change-Number: 27633 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Apr 2022 15:02:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: RLCMAC_EncDec: Fix bug decoding LI[0]=0

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27632 ) Change subject: RLCMAC_EncDec: Fix bug decoding LI[0]=0 ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27632 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86c1b48c922f50013257c8dce405cbad1d77d868 Gerrit-Change-Number: 27632 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 01 Apr 2022 14:56:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022