April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-pcu[master]: WIP: llc: schedule frames to MS based on SAPI priority

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/27627 ) Change subject: WIP: llc: schedule frames to MS based on SAPI priority ...................................................................... Patch Set 2: (1 comment) File src/llc.h: https://gerrit.osmocom.org/c/osmo-pcu/+/27627/comment/b1148993_cb3cf60f PS1, Line 37: union > This line as well as the address field can be moved out of the conditional block to avoid duplicatio […] I'm just leaving it as autogenerated from the script. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/27627 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: Ie8bd91eeac4fa7487d4f11b808dea95737041c7e Gerrit-Change-Number: 27627 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 09:15:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-upf[master]: libosmo-pfcp: implement PFCP header and msg handling

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/27631 ) Change subject: libosmo-pfcp: implement PFCP header and msg handling ...................................................................... Patch Set 3: (7 comments) File include/osmocom/pfcp/pfcp_msg.h: https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/9bd8f6d3_249ab9dd PS3, Line 44: #define OSMO_LOG_PFCP_MSG_SRC(M, LEVEL, file, line, FMT, ARGS...) do { \ This starts to look as too much for a macro imho, it may make sense to move it to a variadic function https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/c6227464_17a86ef5 PS3, Line 69: static inline uint32_t osmo_pfcp_next_seq(uint32_t *seq_state) This function will return 1 on first call most probably. Are you sure that's accepted per spec? or it needs to starts with 0? https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/2d00fcc1_188ddd66 PS3, Line 110: struct osmo_fsm_inst *peer_fi; Looks like these 2 groups can be in a union? https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/a4266ec8_93fcbdcb PS3, Line 123: #define OSMO_PFCP_MSG_FOR_IES(IES_P) ((struct osmo_pfcp_msg *)((char *)IES_P - offsetof(struct osmo_pfcp_msg, ies))) what's the meaning of FOR here? https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/6d8ae394_271aff96 PS3, Line 149: #define OSMO_PFCP_MSG_MEMB(M, OFS) ((OFS) <= 0 ? NULL : (void *)((uint8_t *)(M) + OFS)) write it as a static inline, where you can set type of OFS to unsigned, you can then drop the first check. Or you reall expect to pass -1 to it? File src/libosmo-pfcp/pfcp_msg.c: https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/7e3ccae4_d05fa19f PS3, Line 72: uint16_t message_length; You may want to use here: union { struct osmo_pfcp_header_no_seid hdr_no_seid[0]; struct osmo_pfcp_header_seid hdr_seid[0]; } https://gerrit.osmocom.org/c/osmo-upf/+/27631/comment/063ee253_e4e1f759 PS3, Line 338: /* Append the encoded PFCP message to the message buffer. I see a lot of stuff to put several messages into one buffer. Is there a specific reason to need that? -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/27631 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I3f85ea052a6b7c064244a8093777e53a47c8c61e Gerrit-Change-Number: 27631 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 09:08:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchh,tchf}_fn(): use AMR CMI lookup tables

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27557 ) Change subject: osmo-bts-trx: rx_{tchh,tchf}_fn(): use AMR CMI lookup tables ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27557 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I46def864729c8f9063af201750456771ea5558d5 Gerrit-Change-Number: 27557 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 09:03:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchf,tchh}_fn(): get TDMA FN from meas history

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27556 ) Change subject: osmo-bts-trx: rx_{tchf,tchh}_fn(): get TDMA FN from meas history ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id9a2b7b0f1a1ad7cfbbab862faf521e135c90605 Gerrit-Change-Number: 27556 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 09:03:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchf,tchh}_fn(): shift Rx burst buffer on bid=0

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27554 ) Change subject: osmo-bts-trx: rx_{tchf,tchh}_fn(): shift Rx burst buffer on bid=0 ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0bd69f5a8f5c665fb5f00c127bc3fe1d91167abb Gerrit-Change-Number: 27554 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 09:03:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_{tchf,tchh}_fn(): also use meas_avg for BFI

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27553 ) Change subject: osmo-bts-trx: rx_{tchf,tchh}_fn(): also use meas_avg for BFI ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I23f767364a018d30d04885990adf69b50b2c9738 Gerrit-Change-Number: 27553 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 09:02:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): indicate BER10k=0 for FACCH BFIs

by fixeria

Attention is currently required from: pespin, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27551 ) Change subject: osmo-bts-trx: rx_tchh_fn(): indicate BER10k=0 for FACCH BFIs ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: 1+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I24d12892760dca0ad0a5c2abca9fc66523d9e614 Gerrit-Change-Number: 27551 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 04 Apr 2022 09:02:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: fix sgsn and hnbgw test issue introduced in 49888a65dcf1f8d94411aa072...

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27640 ) Change subject: fix sgsn and hnbgw test issue introduced in 49888a65dcf1f8d94411aa0724530b8c188c3237 ...................................................................... fix sgsn and hnbgw test issue introduced in 49888a65dcf1f8d94411aa0724530b8c188c3237 ranops was not isvalue because bssap_reset_retries was not set and not explicitly omitted either, so the ran adapter decided not to create a ran emulation... Change-Id: Ib2d3f1fbcfbd53af1e627bd2cf36c3153fa7d012 --- M hnbgw/HNBGW_Tests.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Hoernchen: Looks good to me, approved Jenkins Builder: Verified diff --git a/hnbgw/HNBGW_Tests.ttcn b/hnbgw/HNBGW_Tests.ttcn index 745e333..b2c491e 100644 --- a/hnbgw/HNBGW_Tests.ttcn +++ b/hnbgw/HNBGW_Tests.ttcn @@ -107,6 +107,7 @@ protocol := RAN_PROTOCOL_RANAP, transport := RANAP_TRANSPORT_IuCS, use_osmux := false, + bssap_reset_retries := 1, sccp_addr_local := omit, sccp_addr_peer := omit } @@ -324,6 +325,7 @@ protocol := RAN_PROTOCOL_RANAP, transport := RANAP_TRANSPORT_IuCS, use_osmux := false, + bssap_reset_retries := 1, sccp_addr_local := omit, sccp_addr_peer := omit }; diff --git a/sgsn/SGSN_Tests.ttcn b/sgsn/SGSN_Tests.ttcn index 981e924..5238068 100644 --- a/sgsn/SGSN_Tests.ttcn +++ b/sgsn/SGSN_Tests.ttcn @@ -457,6 +457,7 @@ protocol := RAN_PROTOCOL_RANAP, transport := RANAP_TRANSPORT_IuCS, use_osmux := false, + bssap_reset_retries := 1, sccp_addr_local := omit, sccp_addr_peer := omit }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2d3f1fbcfbd53af1e627bd2cf36c3153fa7d012 Gerrit-Change-Number: 27640 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: fix sgsn and hnbgw test issue introduced in 49888a65dcf1f8d94411aa072...

by Hoernchen

Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27640 ) Change subject: fix sgsn and hnbgw test issue introduced in 49888a65dcf1f8d94411aa0724530b8c188c3237 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2d3f1fbcfbd53af1e627bd2cf36c3153fa7d012 Gerrit-Change-Number: 27640 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sat, 02 Apr 2022 19:39:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: fix sgsn and hnbgw test issue introduced in 49888a65dcf1f8d94411aa072...

by Hoernchen

Hoernchen has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27640 ) Change subject: fix sgsn and hnbgw test issue introduced in 49888a65dcf1f8d94411aa0724530b8c188c3237 ...................................................................... fix sgsn and hnbgw test issue introduced in 49888a65dcf1f8d94411aa0724530b8c188c3237 ranops was not isvalue because bssap_reset_retries was not set and not explicitly omitted either, so the ran adapter decided not to create a ran emulation... Change-Id: Ib2d3f1fbcfbd53af1e627bd2cf36c3153fa7d012 --- M hnbgw/HNBGW_Tests.ttcn M sgsn/SGSN_Tests.ttcn 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/40/27640/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27640 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib2d3f1fbcfbd53af1e627bd2cf36c3153fa7d012 Gerrit-Change-Number: 27640 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022