April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc-nat[master]: Make subscr_conn_get_next_id RAN specific

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 ) Change subject: Make subscr_conn_get_next_id RAN specific ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc-nat/subscr_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711/comment/40934572_29ce0302 PS2, Line 31: { > I think it makes much more sense to have 3 separate functions, other than having a 1 more complex fu […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I77b0ef33f94c401d24f38eb8d79e1007234e0ab4 Gerrit-Change-Number: 27711 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:24:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Parse BSSMAP in conn-oriented data

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27710 ) Change subject: Parse BSSMAP in conn-oriented data ...................................................................... Patch Set 3: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27710/comment/90662c39_537a630d PS2, Line 9: Add functions the parse the BSSMAP part of BSSAP messages, and in theory > to parse? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3e2599a9a07925afdbe69f7b8dbcec227681dfa2 Gerrit-Change-Number: 27710 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:24:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Proper exit if bsc_nat_fsm fails to start

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708 ) Change subject: Proper exit if bsc_nat_fsm fails to start ...................................................................... Patch Set 3: (2 comments) File src/osmo-bsc-nat/bsc_nat_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708/comment/e6e110a5_37196e57 PS2, Line 479: osmo_fsm_inst_dispatch(bsc_nat->fi, BSC_NAT_FSM_EV_START, NULL); > int bsc_nat_fsm_start(struct bsc_nat *bsc_nat) { […] Done File src/osmo-bsc-nat/main.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708/comment/40bc92b0_0b27eea6 PS2, Line 202: if (!bsc_nat_fsm_is_started(g_bsc_nat)) { > This looks weird. Why not: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ia8bbe6ae908d5c3ce49f71b43c950497aeebb6d6 Gerrit-Change-Number: 27708 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:24:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Add subscr_conn_fsm

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 ) Change subject: Add subscr_conn_fsm ...................................................................... Patch Set 3: (7 comments) File include/osmocom/bsc_nat/bssap.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/00c102bf_20721566 PS2, Line 30: struct bssmap_assignment_rqst { > bssmap_ass_req? Done https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/03790ba0_9b9cba3d PS2, Line 47: struct bssmap_assignment_complete { > bssmap_ass_compl? Done File src/osmo-bsc-nat/bssap_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/2e653571_9d03d99b PS2, Line 69: static int bssmap_cn_handle_assignment_rqst(struct subscr_conn *subscr_conn, struct msgb *msg, unsigned int length) > bssmap_cn_handle_ass_req? Done File src/osmo-bsc-nat/subscr_conn.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/85bb7e60_ea5bbadf PS2, Line 32: int subscr_conn_get_next_id(enum subscr_conn_id_type id_type) > I'd rather split in 3 functions, using a macro if necessary. Done File src/osmo-bsc-nat/subscr_conn_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/02e773ca_62f00c8a PS2, Line 72: case SUBSCR_CONN_FSM_EV_BSSMAP_CLEAR_COMMAND: > missing break. Probably not affecting in behavior but I don't see an intended fall-through here. This was intentional, but added a break to make it explicit. https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/e545b812_a5b5d305 PS2, Line 172: static int tx_assignment_request_to_ran(const struct subscr_conn *subscr_conn) > If possible please move helper functions to the top, and put all the state FM functions together. Done https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712/comment/d8535d82_7b0a4c30 PS2, Line 351: , > nice style to lose one an extra line for no good reason :D (j/k) Neels invented this, but I like how it's diff friendly :) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b Gerrit-Change-Number: 27712 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:23:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: check for error from get_next_id_ran

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27728 ) Change subject: bsc_nat_fsm: check for error from get_next_id_ran ...................................................................... bsc_nat_fsm: check for error from get_next_id_ran Related: SYS#5560 Change-Id: Ic55ba119e9c736c396f06a58ec9bc1f4682e9b11 --- M src/osmo-bsc-nat/bsc_nat_fsm.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/28/27728/1 diff --git a/src/osmo-bsc-nat/bsc_nat_fsm.c b/src/osmo-bsc-nat/bsc_nat_fsm.c index 2a32c9d..d7f8aa3 100644 --- a/src/osmo-bsc-nat/bsc_nat_fsm.c +++ b/src/osmo-bsc-nat/bsc_nat_fsm.c @@ -200,7 +200,12 @@ goto error; } - subscr_conn = subscr_conn_alloc(msc, bsc, subscr_conn_get_next_id_ran(), prim->u.connect.conn_id); + rc = subscr_conn_get_next_id_ran(); + if (rc < 0) { + LOGP(DMAIN, LOGL_ERROR, "Failed to get next_id_ran\n"); + goto error; + } + subscr_conn = subscr_conn_alloc(msc, bsc, rc, prim->u.connect.conn_id); LOGP(DMAIN, LOGL_DEBUG, "Fwd via %s\n", talloc_get_name(subscr_conn)); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ic55ba119e9c736c396f06a58ec9bc1f4682e9b11 Gerrit-Change-Number: 27728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Proper exit if bsc_nat_fsm fails to start

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708 to look at the new patch set (#3). Change subject: Proper exit if bsc_nat_fsm fails to start ...................................................................... Proper exit if bsc_nat_fsm fails to start Instead of segfaulting later on, properly exit if the bsc_nat_fsm does not start. One reason for having it fail could be a missing mgw pool config block. Related: SYS#5560 Change-Id: Ia8bbe6ae908d5c3ce49f71b43c950497aeebb6d6 --- M include/osmocom/bsc_nat/bsc_nat_fsm.h M src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/main.c 3 files changed, 14 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/08/27708/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ia8bbe6ae908d5c3ce49f71b43c950497aeebb6d6 Gerrit-Change-Number: 27708 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Parse BSSMAP in conn-oriented data

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27710 to look at the new patch set (#3). Change subject: Parse BSSMAP in conn-oriented data ...................................................................... Parse BSSMAP in conn-oriented data Add functions to parse the BSSMAP part of BSSAP messages, and in theory do other things than just forwarding the messages depending on the BSSMAP message type. This will be used in follow-up patches to change the AoIP transport layer address in Assignment Request and related messages. Related: SYS#5560 Change-Id: I3e2599a9a07925afdbe69f7b8dbcec227681dfa2 --- M include/osmocom/bsc_nat/bssap.h M src/osmo-bsc-nat/Makefile.am M src/osmo-bsc-nat/bsc_nat_fsm.c A src/osmo-bsc-nat/bssap_conn.c 4 files changed, 129 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/10/27710/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3e2599a9a07925afdbe69f7b8dbcec227681dfa2 Gerrit-Change-Number: 27710 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Make subscr_conn_get_next_id RAN specific

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 to look at the new patch set (#3). Change subject: Make subscr_conn_get_next_id RAN specific ...................................................................... Make subscr_conn_get_next_id RAN specific Instead of having RAN/CN as parameter, make the function a bit simpler and only allow RAN. The motivation for this change is, that for MGW a similar function is required, and it was recommended in code review to rather duplicate the short function instead of making it more complex. I'm dropping the CN part here since it wasn't used anyway, and if used in the future, the function could be duplicated for CN as well. Related: SYS#5560 Change-Id: I77b0ef33f94c401d24f38eb8d79e1007234e0ab4 --- M include/osmocom/bsc_nat/subscr_conn.h M src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/subscr_conn.c 3 files changed, 5 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/11/27711/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I77b0ef33f94c401d24f38eb8d79e1007234e0ab4 Gerrit-Change-Number: 27711 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Add subscr_conn_fsm

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 to look at the new patch set (#3). Change subject: Add subscr_conn_fsm ...................................................................... Add subscr_conn_fsm Insert the BSCNAT's MGW into phone calls by replacing the AoIP transport layer address IE inside BSSMAP Assignment Request and Assignment Confirm. Accomplish this with a new subscr_conn_fsm that parses and stores the original ass_req / ass_conf messages, communicates with the BSCNAT MGW, and then creates new ass_req / ass_conf messages based on the original ones but with new RTP information. With this patch it is possible to do a successful voice call with the following network: MS1 --- BTS1 --- BSC1 --. | | BSCNAT ----------- MSC | | | | | '-- MGW-BSC1 --|-- MGW-BSCNAT --- MGW-MSC | | MS2 --- BTS2 --- BSC2 --' | | | | '-- MGW-BSC2 ------' Related: SYS#5560 Related: https://osmocom.org/projects/osmo-bscnat/wiki/Ladder_diagrams_for_key_proce… Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b --- M include/osmocom/bsc_nat/Makefile.am M include/osmocom/bsc_nat/bsc_nat.h M include/osmocom/bsc_nat/bssap.h M include/osmocom/bsc_nat/subscr_conn.h A include/osmocom/bsc_nat/subscr_conn_fsm.h M src/osmo-bsc-nat/Makefile.am M src/osmo-bsc-nat/bssap_conn.c M src/osmo-bsc-nat/subscr_conn.c A src/osmo-bsc-nat/subscr_conn_fsm.c 9 files changed, 846 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/12/27712/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b Gerrit-Change-Number: 27712 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Initial testing of open5gs Gy interface

by daniel

Attention is currently required from: osmith, laforge, pespin, fixeria. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423 ) Change subject: ggsn: Initial testing of open5gs Gy interface ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10027d4f8adc6b47ce97b90514d1f13e9aa3d40d Gerrit-Change-Number: 27423 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 09:39:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022