April 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: pgw: Wait for component to get out of SUT's Diameter SUSPECt list

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27732 ) Change subject: pgw: Wait for component to get out of SUT's Diameter SUSPECt list ...................................................................... pgw: Wait for component to get out of SUT's Diameter SUSPECt list Similar fix was applied to GGSN_Tests when adding Diameter support in commit 0bcfd9de8ff359673ddb71e013dbad44bf9510cc. Change-Id: I95ddf6c1048f0bfd6590bae574aea15c4fc2710b --- M pgw/PGW_Tests.ttcn 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/32/27732/1 diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn index 9846dab..2b74418 100644 --- a/pgw/PGW_Tests.ttcn +++ b/pgw/PGW_Tests.ttcn @@ -146,6 +146,12 @@ vc_DIAMETER.start(DIAMETER_Emulation.main(ops, pars, id)); f_diameter_wait_capability(DIAMETER_UNIT); + /* Give some time for our emulation to get out of SUSPECT list of SUT (3 watchdong ping-pongs): + * RFC6733 sec 5.1 + * RFC3539 sec 3.4.1 [5] + * https://github.com/freeDiameter/freeDiameter/blob/master/libfdcore/p_psm.c#… + */ + f_sleep(1.0); } private function f_init(float guard_timeout := 60.0) runs on PGW_Test_CT { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27732 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95ddf6c1048f0bfd6590bae574aea15c4fc2710b Gerrit-Change-Number: 27732 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ggsn: Initial testing of open5gs Gy interface

by osmith

Attention is currently required from: laforge, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423 ) Change subject: ggsn: Initial testing of open5gs Gy interface ...................................................................... Patch Set 3: Code-Review+1 (2 comments) File ggsn_tests/GGSN_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423/comment/f63efc20_1b0f… PS3, Line 2229: /* Sent some data and validate it is reported in the TERMINATION_REQUEST (triggered by PFCP Session Deletion Response): */ very long line File library/DIAMETER_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423/comment/e968996f_7fc2… PS3, Line 1226: /* FIXME: change this to use "Validity-Time" instead of "CC-Time" */ Is the unresolved fixme here kept on purpose? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I10027d4f8adc6b47ce97b90514d1f13e9aa3d40d Gerrit-Change-Number: 27423 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:46:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Make subscr_conn_get_next_id RAN specific

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 ) Change subject: Make subscr_conn_get_next_id RAN specific ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27711 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I77b0ef33f94c401d24f38eb8d79e1007234e0ab4 Gerrit-Change-Number: 27711 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:42:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Parse BSSMAP in conn-oriented data

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27710 ) Change subject: Parse BSSMAP in conn-oriented data ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27710 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3e2599a9a07925afdbe69f7b8dbcec227681dfa2 Gerrit-Change-Number: 27710 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:41:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Proper exit if bsc_nat_fsm fails to start

by pespin

Attention is currently required from: osmith, laforge, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708 ) Change subject: Proper exit if bsc_nat_fsm fails to start ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27708 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ia8bbe6ae908d5c3ce49f71b43c950497aeebb6d6 Gerrit-Change-Number: 27708 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:40:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: Add subscr_conn_fsm

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 ) Change subject: Add subscr_conn_fsm ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27712 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I7e491aada6f5db0eb35ef2039869c6ba07f9ca3b Gerrit-Change-Number: 27712 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:39:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: check for error from get_next_id_ran

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27728 ) Change subject: bsc_nat_fsm: check for error from get_next_id_ran ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ic55ba119e9c736c396f06a58ec9bc1f4682e9b11 Gerrit-Change-Number: 27728 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 11 Apr 2022 10:38:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: DIAMETER_Emulation: Fix typo in comment

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27730 ) Change subject: DIAMETER_Emulation: Fix typo in comment ...................................................................... DIAMETER_Emulation: Fix typo in comment Change-Id: I6163fc9153082598c7211b16a7c18fb95cf3d08a --- M library/DIAMETER_Emulation.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/27730/1 diff --git a/library/DIAMETER_Emulation.ttcn b/library/DIAMETER_Emulation.ttcn index e53f4e5..0f1b9fe 100644 --- a/library/DIAMETER_Emulation.ttcn +++ b/library/DIAMETER_Emulation.ttcn @@ -399,7 +399,7 @@ inout DIAMETEREM_register; } with { extension "internal" }; -/* Function that can be used as create_cb and will usse the expect table */ +/* Function that can be used as create_cb and will use the expect table */ function ExpectedCreateCallback(PDU_DIAMETER msg, hexstring imsi, charstring id) runs on DIAMETER_Emulation_CT return DIAMETER_ConnHdlr { var DIAMETER_ConnHdlr ret := null; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6163fc9153082598c7211b16a7c18fb95cf3d08a Gerrit-Change-Number: 27730 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: DIAMETER_Emulation: Allow up to 256 IMSI Diameter components

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27731 ) Change subject: DIAMETER_Emulation: Allow up to 256 IMSI Diameter components ...................................................................... DIAMETER_Emulation: Allow up to 256 IMSI Diameter components TC_createSession_ping4_256 requries 256 concurrent connections. Change-Id: Idc305a868f827dee63a476979fc9de9fc12580c5 --- M library/DIAMETER_Emulation.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/27731/1 diff --git a/library/DIAMETER_Emulation.ttcn b/library/DIAMETER_Emulation.ttcn index 0f1b9fe..8fb7230 100644 --- a/library/DIAMETER_Emulation.ttcn +++ b/library/DIAMETER_Emulation.ttcn @@ -78,9 +78,9 @@ * to send where with CLIENT.send() to vc_conn */ port DIAMETER_Conn_PT DIAMETER_CLIENT; /* currently tracked connections */ - var AssociationData DiameterAssocTable[16]; + var AssociationData DiameterAssocTable[256]; /* pending expected CRCX */ - var ExpectData DiameterExpectTable[8]; + var ExpectData DiameterExpectTable[256]; /* procedure based port to register for incoming connections */ port DIAMETEREM_PROC_PT DIAMETER_PROC; /* test port for unit data messages */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27731 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc305a868f827dee63a476979fc9de9fc12580c5 Gerrit-Change-Number: 27731 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: DIAMETER_Emulation: Rename association table

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27729 ) Change subject: DIAMETER_Emulation: Rename association table ...................................................................... DIAMETER_Emulation: Rename association table The table has no direct relation to SGSAP, it tracks IMSI connections in a generic way. Change-Id: I12399465549739fb99af193e7071fff8bc452b0b --- M library/DIAMETER_Emulation.ttcn 1 file changed, 23 insertions(+), 23 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/27729/1 diff --git a/library/DIAMETER_Emulation.ttcn b/library/DIAMETER_Emulation.ttcn index 73fc87c..e53f4e5 100644 --- a/library/DIAMETER_Emulation.ttcn +++ b/library/DIAMETER_Emulation.ttcn @@ -78,7 +78,7 @@ * to send where with CLIENT.send() to vc_conn */ port DIAMETER_Conn_PT DIAMETER_CLIENT; /* currently tracked connections */ - var AssociationData SgsapAssociationTable[16]; + var AssociationData DiameterAssocTable[16]; /* pending expected CRCX */ var ExpectData DiameterExpectTable[8]; /* procedure based port to register for incoming connections */ @@ -131,8 +131,8 @@ private function f_imsi_known(hexstring imsi) runs on DIAMETER_Emulation_CT return boolean { var integer i; - for (i := 0; i < sizeof(SgsapAssociationTable); i := i+1) { - if (SgsapAssociationTable[i].imsi == imsi) { + for (i := 0; i < sizeof(DiameterAssocTable); i := i+1) { + if (DiameterAssocTable[i].imsi == imsi) { return true; } } @@ -142,8 +142,8 @@ private function f_comp_known(DIAMETER_ConnHdlr client) runs on DIAMETER_Emulation_CT return boolean { var integer i; - for (i := 0; i < sizeof(SgsapAssociationTable); i := i+1) { - if (SgsapAssociationTable[i].comp_ref == client) { + for (i := 0; i < sizeof(DiameterAssocTable); i := i+1) { + if (DiameterAssocTable[i].comp_ref == client) { return true; } } @@ -153,9 +153,9 @@ private function f_comp_by_imsi(hexstring imsi) runs on DIAMETER_Emulation_CT return DIAMETER_ConnHdlr { var integer i; - for (i := 0; i < sizeof(SgsapAssociationTable); i := i+1) { - if (SgsapAssociationTable[i].imsi == imsi) { - return SgsapAssociationTable[i].comp_ref; + for (i := 0; i < sizeof(DiameterAssocTable); i := i+1) { + if (DiameterAssocTable[i].imsi == imsi) { + return DiameterAssocTable[i].comp_ref; } } setverdict(fail, "DIAMETER Association Table not found by IMSI", imsi); @@ -165,9 +165,9 @@ private function f_imsi_by_comp(DIAMETER_ConnHdlr client) runs on DIAMETER_Emulation_CT return hexstring { var integer i; - for (i := 0; i < sizeof(SgsapAssociationTable); i := i+1) { - if (SgsapAssociationTable[i].comp_ref == client) { - return SgsapAssociationTable[i].imsi; + for (i := 0; i < sizeof(DiameterAssocTable); i := i+1) { + if (DiameterAssocTable[i].comp_ref == client) { + return DiameterAssocTable[i].imsi; } } setverdict(fail, "DIAMETER Association Table not found by component ", client); @@ -177,10 +177,10 @@ private function f_imsi_table_add(DIAMETER_ConnHdlr comp_ref, hexstring imsi) runs on DIAMETER_Emulation_CT { var integer i; - for (i := 0; i < sizeof(SgsapAssociationTable); i := i+1) { - if (not isvalue(SgsapAssociationTable[i].imsi)) { - SgsapAssociationTable[i].imsi := imsi; - SgsapAssociationTable[i].comp_ref := comp_ref; + for (i := 0; i < sizeof(DiameterAssocTable); i := i+1) { + if (not isvalue(DiameterAssocTable[i].imsi)) { + DiameterAssocTable[i].imsi := imsi; + DiameterAssocTable[i].comp_ref := comp_ref; return; } } @@ -190,11 +190,11 @@ private function f_imsi_table_del(DIAMETER_ConnHdlr comp_ref, hexstring imsi) runs on DIAMETER_Emulation_CT { var integer i; - for (i := 0; i < sizeof(SgsapAssociationTable); i := i+1) { - if (SgsapAssociationTable[i].comp_ref == comp_ref and - SgsapAssociationTable[i].imsi == imsi) { - SgsapAssociationTable[i].imsi := omit; - SgsapAssociationTable[i].comp_ref := null; + for (i := 0; i < sizeof(DiameterAssocTable); i := i+1) { + if (DiameterAssocTable[i].comp_ref == comp_ref and + DiameterAssocTable[i].imsi == imsi) { + DiameterAssocTable[i].imsi := omit; + DiameterAssocTable[i].comp_ref := null; return; } } @@ -205,9 +205,9 @@ private function f_imsi_table_init() runs on DIAMETER_Emulation_CT { - for (var integer i := 0; i < sizeof(SgsapAssociationTable); i := i+1) { - SgsapAssociationTable[i].comp_ref := null; - SgsapAssociationTable[i].imsi := omit; + for (var integer i := 0; i < sizeof(DiameterAssocTable); i := i+1) { + DiameterAssocTable[i].comp_ref := null; + DiameterAssocTable[i].imsi := omit; } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27729 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I12399465549739fb99af193e7071fff8bc452b0b Gerrit-Change-Number: 27729 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 2 months

1
0
0 0

2025

2024

2023

2022

gerrit-log April 2022