March 2022 - gerrit-log - lists.osmocom.org

Change in pysim[master]: ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM

by laforge

Attention is currently required from: astrid smith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27575 ) Change subject: ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd572ab064ea38e74dffd583c27ea505b23214a2 Gerrit-Change-Number: 27575 Gerrit-PatchSet: 2 Gerrit-Owner: astrid smith <astrid(a)shady.tel> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: astrid smith <astrid(a)shady.tel> Gerrit-Comment-Date: Sun, 27 Mar 2022 11:47:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in pysim[master]: ts_31_102: Avoid pylint false positive

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/27576 ) Change subject: ts_31_102: Avoid pylint false positive ...................................................................... ts_31_102: Avoid pylint false positive This should avoid the following pylint error: ************* Module pySim.ts_31_102 pySim/ts_31_102.py:621:100: E0601: Using variable 'sw' before assignment (used-before-assignment) Change-Id: I0bb9607cdab0e6e3cd17b4d27129a51a607bc0f2 --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index fec81bf..fa3af75 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -609,6 +609,7 @@ should_exist = f.should_exist_for_services(active_services) try: cmd.rs.select_file(f) + sw = None exists = True except SwMatchError as e: sw = str(e) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0bb9607cdab0e6e3cd17b4d27129a51a607bc0f2 Gerrit-Change-Number: 27576 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in pysim[master]: ts_31_102: Avoid pylint false positive

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27576 ) Change subject: ts_31_102: Avoid pylint false positive ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0bb9607cdab0e6e3cd17b4d27129a51a607bc0f2 Gerrit-Change-Number: 27576 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 27 Mar 2022 10:43:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in docker-playground[master]: gr-gsm-master: migrate from archlinux to debian-bullseye-build

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27574 ) Change subject: gr-gsm-master: migrate from archlinux to debian-bullseye-build ...................................................................... gr-gsm-master: migrate from archlinux to debian-bullseye-build Arch Linux ships gnuradio-3.9.4.0, while gr-gsm has not been migrated to 3.9 yet. Let's use debian:bullseye, which ships gnuradio-3.8.2.0. Change-Id: I9900addf152fd254283ef340cea16583ee5ac1c5 --- M gr-gsm-master/Dockerfile 1 file changed, 14 insertions(+), 70 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/gr-gsm-master/Dockerfile b/gr-gsm-master/Dockerfile index 71dc610..5e878c1 100644 --- a/gr-gsm-master/Dockerfile +++ b/gr-gsm-master/Dockerfile @@ -1,85 +1,29 @@ -ARG REGISTRY=docker.io -FROM ${REGISTRY}/archlinux/base +ARG REGISTRY=docker.io +ARG USER +FROM $USER/debian-bullseye-build MAINTAINER Vadim Yanitskiy <axilirator(a)gmail.com> -ARG LIBOSMOCORE_BRANCH="master" +RUN apt-get update && \ + apt-get install -y --no-install-recommends \ + libosmocore-dev \ + gnuradio-dev \ + gr-osmosdr \ + cmake \ + swig + ARG GR_GSM_BRANCH="master" -# Build dependencies -ENV BUILD_DEPS \ - automake \ - autoconf \ - libtool \ - pkgconf \ - cmake \ - make \ - swig \ - gcc - -# Sync pacman -RUN pacman -Syyu --noconfirm - -# Install persistent packages -RUN pacman -S --needed --noconfirm \ - gnuradio \ - python2 \ - python2-scipy \ - python2-requests \ - talloc \ - boost - -# Download USRP firmware -RUN uhd_images_downloader - -# Install build dependencies -RUN pacman -S --needed --noconfirm \ - $BUILD_DEPS - -# Make Python2 default -RUN ln -s /usr/bin/python2 /usr/bin/python - -# Install and configure git -RUN pacman -S --needed --noconfirm git \ - && git config --global user.email docker(a)dock.er \ - && git config --global user.name "Dock Er" - -WORKDIR /tmp - -# Download, build and install libosmocore -RUN git clone git://git.osmocom.org/libosmocore -ADD http://git.osmocom.org/libosmocore/patch?h=$LIBOSMOCORE_BRANCH /tmp/commit-libosmocore - -RUN cd libosmocore \ - && git fetch && git checkout -f -B $LIBOSMOCORE_BRANCH origin/$LIBOSMOCORE_BRANCH \ - && git rev-parse --abbrev-ref HEAD && git rev-parse HEAD \ - && autoreconf -fi \ - && ./configure \ - --disable-doxygen \ - --disable-pcsc \ - --prefix=/usr \ - && make "-j$(nproc)" \ - && make install \ - && make distclean - RUN git clone git://git.osmocom.org/gr-gsm ADD http://git.osmocom.org/gr-gsm/patch?h=$GR_GSM_BRANCH /tmp/commit-gr-gsm RUN cd gr-gsm \ && git fetch && git checkout -f -B $GR_GSM_BRANCH origin/$GR_GSM_BRANCH \ - && git rev-parse HEAD \ + && git rev-parse --abbrev-ref HEAD && git rev-parse HEAD \ && mkdir build/ \ && cd build/ \ - && cmake \ + && cmake .. \ -DCMAKE_INSTALL_PREFIX=/usr \ -Wno-dev \ - -DENABLE_GRCC=OFF \ - ../ \ && make "-j$(nproc)" \ - && make install \ - && cd ../ \ - && rm -rf build/ - -# Remove build dependencies -RUN pacman -Rs --noconfirm \ - $BUILD_DEPS + && make install -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9900addf152fd254283ef340cea16583ee5ac1c5 Gerrit-Change-Number: 27574 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in docker-playground[master]: gr-gsm-master: migrate from archlinux to debian-bullseye-build

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27574 ) Change subject: gr-gsm-master: migrate from archlinux to debian-bullseye-build ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27574 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I9900addf152fd254283ef340cea16583ee5ac1c5 Gerrit-Change-Number: 27574 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 27 Mar 2022 10:37:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in pysim[master]: ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM

by laforge

Attention is currently required from: astrid smith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27575 ) Change subject: ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I suspect that the sysmoISIM-SJA2 in the testbed has an EF. […] The actual error from the log file is ************* Module pySim.ts_31_102 pySim/ts_31_102.py:621:100: E0601: Using variable 'sw' before assignment (used-before-assignment) So it appears that the most recent pylint is detecting a false positive here. I'm tryng to fix this in https://gerrit.osmocom.org/c/pysim/+/27576 and we can rebase your patch afterwards. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd572ab064ea38e74dffd583c27ea505b23214a2 Gerrit-Change-Number: 27575 Gerrit-PatchSet: 1 Gerrit-Owner: astrid smith <astrid(a)shady.tel> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: astrid smith <astrid(a)shady.tel> Gerrit-Comment-Date: Sun, 27 Mar 2022 10:35:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: astrid smith <astrid(a)shady.tel> Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in pysim[master]: ts_31_102: Avoid pylint false positive

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27576 ) Change subject: ts_31_102: Avoid pylint false positive ...................................................................... ts_31_102: Avoid pylint false positive This should avoid the following pylint error: ************* Module pySim.ts_31_102 pySim/ts_31_102.py:621:100: E0601: Using variable 'sw' before assignment (used-before-assignment) Change-Id: I0bb9607cdab0e6e3cd17b4d27129a51a607bc0f2 --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/76/27576/1 diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index fec81bf..fa3af75 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -609,6 +609,7 @@ should_exist = f.should_exist_for_services(active_services) try: cmd.rs.select_file(f) + sw = None exists = True except SwMatchError as e: sw = str(e) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27576 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0bb9607cdab0e6e3cd17b4d27129a51a607bc0f2 Gerrit-Change-Number: 27576 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in pysim[master]: ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM

by astrid smith

astrid smith has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/27575 ) Change subject: ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I suspect that the sysmoISIM-SJA2 in the testbed has an EF.DOMAIN file that is something other than "Not available", but I don't have access to see what's in it. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd572ab064ea38e74dffd583c27ea505b23214a2 Gerrit-Change-Number: 27575 Gerrit-PatchSet: 1 Gerrit-Owner: astrid smith <astrid(a)shady.tel> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Sun, 27 Mar 2022 06:50:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in pysim[master]: ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM

by astrid smith

astrid smith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27575 ) Change subject: ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM ...................................................................... ts_31_103: Correct file-id of EF.DOMAIN in ADF.ISIM While the short ID of this file is 05, the actual file-id is 6f03. Reference to TS 31.103 section 4.2.3. Change-Id: Idd572ab064ea38e74dffd583c27ea505b23214a2 --- M pySim/ts_31_103.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/75/27575/1 diff --git a/pySim/ts_31_103.py b/pySim/ts_31_103.py index fb164ef..a4f7983 100644 --- a/pySim/ts_31_103.py +++ b/pySim/ts_31_103.py @@ -91,7 +91,7 @@ class domain(BER_TLV_IE, tag=0x80): _construct = GreedyString("utf8") - def __init__(self, fid='6f05', sfid=0x05, name='EF.DOMAIN', desc='Home Network Domain Name', **kwargs): + def __init__(self, fid='6f03', sfid=0x05, name='EF.DOMAIN', desc='Home Network Domain Name', **kwargs): super().__init__(fid=fid, sfid=sfid, name=name, desc=desc, **kwargs) self._tlv = EF_DOMAIN.domain -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27575 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idd572ab064ea38e74dffd583c27ea505b23214a2 Gerrit-Change-Number: 27575 Gerrit-PatchSet: 1 Gerrit-Owner: astrid smith <astrid(a)shady.tel> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Build failure of network:osmocom:nightly/osmo-trx in openSUSE_Leap_15.1_ARM/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-trx failed to build in openSUSE_Leap_15.1_ARM/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-trx Last lines of build log: [ 108s] checking for byteswap.h... yes [ 109s] checking for an ANSI C-conforming const... yes [ 109s] checking for inline... inline [ 109s] checking for size_t... yes [ 109s] checking whether time.h and sys/time.h may both be included... yes [ 110s] checking whether byte ordering is bigendian... no [ 110s] checking for libosmocore >= 1.6.0... no [ 110s] configure: error: Package requirements (libosmocore >= 1.6.0) were not met: [ 110s] [ 110s] Package 'libsctp', required by 'libosmocore', not found [ 110s] [ 110s] Consider adjusting the PKG_CONFIG_PATH environment variable if you [ 110s] installed software in a non-standard prefix. [ 110s] [ 110s] Alternatively, you may set the environment variables LIBOSMOCORE_CFLAGS [ 110s] and LIBOSMOCORE_LIBS to avoid the need to call pkg-config. [ 110s] See the pkg-config man page for more details. [ 110s] error: Bad exit status from /var/tmp/rpm-tmp.IeNWoD (%build) [ 110s] [ 110s] [ 110s] RPM build errors: [ 110s] Bad exit status from /var/tmp/rpm-tmp.IeNWoD (%build) [ 110s] ### VM INTERACTION START ### [ 110s] [ 94.125343] sysrq: SysRq : Power Off [ 110s] [ 94.127776] reboot: Power down [ 111s] ### VM INTERACTION END ### [ 111s] [ 111s] obs-arm-6 failed "build osmo-trx.spec" at Sun Mar 27 01:05:05 UTC 2022. [ 111s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022