March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: tcpdump capture script: check permissions to fix running in a netns

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 ) Change subject: tcpdump capture script: check permissions to fix running in a netns ...................................................................... Patch Set 1: (1 comment) File ttcn3-tcpdump-start.sh: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604/comment/f974b6e9_4f75… PS1, Line 48: getpcaps doesntmatter 2>&1 | grep -e cap_net_admin | grep -q -e cap_net_raw Where does this "getpcaps" come from? I'm not really understanding this patch tbh. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d Gerrit-Change-Number: 27604 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:12:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: msc tests: fix test so they don't depend on previous test runs

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 ) Change subject: msc tests: fix test so they don't depend on previous test runs ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Can you describe better the issue you are fixing here? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebaecd28a426b15baf4729f40b46dd33da79cbae Gerrit-Change-Number: 27603 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:08:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-sccp[master]: Add ss7 instances to osmo_ss7_instances in creation order

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 ) Change subject: Add ss7 instances to osmo_ss7_instances in creation order ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > should not cause downstream test fallout. […] All tests on all projects run fine here after applying the patch -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c Gerrit-Change-Number: 27599 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 14:07:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ran emulation: allow multiple reset attempts

by fixeria

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 ) Change subject: ran emulation: allow multiple reset attempts ...................................................................... Patch Set 1: Code-Review-1 (3 comments) Patchset: PS1: CR-1 due to missing 'mp_' prefix. File library/RAN_Emulation.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602/comment/4ea2ef22_7356… PS1, Line 526: while (attempts > 0) { > This is usually implemented in TTCN3 by means of "repeat;" keyword in the alt. IMO, the loop approach is easier to read. Not only you would need to 'repeat', but also restart the timer and send the ts_BSSMAP_Reset again in the timeout altstep. But personally I would rather use 'for' here, it's a bit shorter: for (var integer i := 0; i < g_ran_ops.bssap_reset_retries; i := i + 1) { ... } Not critical, just a matter of preferences. You can keep this code as is. File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602/comment/4f7665eb_dd38… PS1, Line 143: bssap_reset_retries All module parameters star with 'mp_', please align the naming. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9f6db2a24e984eef31e76f9d42a80eb6a1bb6928 Gerrit-Change-Number: 27602 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 13:50:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ran emulation: allow multiple reset attempts

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 ) Change subject: ran emulation: allow multiple reset attempts ...................................................................... Patch Set 1: (1 comment) File library/RAN_Emulation.ttcnpp: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602/comment/5572de80_283b… PS1, Line 526: while (attempts > 0) { This is usually implemented in TTCN3 by means of "repeat;" keyword in the alt. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9f6db2a24e984eef31e76f9d42a80eb6a1bb6928 Gerrit-Change-Number: 27602 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 12:50:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-sccp[master]: Add ss7 instances to osmo_ss7_instances in creation order

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 ) Change subject: Add ss7 instances to osmo_ss7_instances in creation order ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: should not cause downstream test fallout. did you check that? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/27599 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Id4d0a20cc5b0811b505b2d1051d496f8bd17d54c Gerrit-Change-Number: 27599 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 12:02:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-bsc[master]: hodec2: show reported ho oscillation from bad rxqual

by neels

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27595 ) Change subject: hodec2: show reported ho oscillation from bad rxqual ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/27595 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I51f3101901492ae742d8e56d6eed2725408216cb Gerrit-Change-Number: 27595 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 30 Mar 2022 11:56:16 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27605 ) Change subject: BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num ...................................................................... BSC_Tests_CBSP: add a new testcase TC_cbsp_write_rep_period_num Change-Id: I169c482ea5de040df63db4c605ac9cae19f8d28f Related: SYS#5905 --- M bsc/BSC_Tests_CBSP.ttcn 1 file changed, 56 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/05/27605/1 diff --git a/bsc/BSC_Tests_CBSP.ttcn b/bsc/BSC_Tests_CBSP.ttcn index 25f00d8..0d8fb38 100644 --- a/bsc/BSC_Tests_CBSP.ttcn +++ b/bsc/BSC_Tests_CBSP.ttcn @@ -696,6 +696,61 @@ setverdict(pass); } +/* Verify handling of the Repetition Period and the Number of Broadcasts */ +testcase TC_cbsp_write_rep_period_num() runs on cbsp_test_CT { + var CBSP_IE page := f_gen_page(); + const integer rep_period := 2; /* units of 1.883s */ + const integer rep_number := 5; + var integer msg_count := 0; + var float last_time := 0.0; + timer T; + + g_pars := valueof(ts_CBSP_Pars_default(false, 9001, 9501)); + f_init(guard_timeout := 60.0); + + f_cbsp_write(g_cbsp_msg_id, g_cbsp_ser_no, + cell_list := ts_BSSMAP_CIL_LAC_CI({bssmap_lac_ci(mp_cgi_bts0)}), + rep_period := rep_period, num_bcast_req := rep_number, + content := { page }, success_list := ?, fail_list := omit); + + /* Count SMSCB messages during N=rep_number+2 repetition periods */ + T.start(int2float(rep_period * (rep_number + 2)) * 1.883); + alt { + [] IPA_RSL[0].receive(tr_ASP_RSL_UD(f_page2rsl(page, g_cbsp_msg_id, g_cbsp_ser_no))) { + var float exp_period := int2float(rep_period) * 1.883; + var float calc_period := T.read - last_time; + + log("Rx SMSCB message: count := ", msg_count + 1, ", ", + "elapsed := ", T.read, "s, diff := ", calc_period, "s"); + + if (msg_count > 0) { + /* Check the actual repetition period (+/- 0.5s) */ + var template float tr_exp_period := (exp_period - 0.5 .. exp_period + 0.5); + if (not match(calc_period, tr_exp_period)) { + setverdict(fail, "Repetition period mismatch: ", + "calculated := ", calc_period, "s vs ", + "expected := ", tr_exp_period, "s"); + } + } + + msg_count := msg_count + 1; + last_time := T.read; + repeat; + } + [] T.timeout { + log("Received ", msg_count, " messages during ", last_time, "s"); + } + } + + if (msg_count != rep_number) { + setverdict(fail, "Received ", msg_count, " messages, ", + "while we expected ", rep_number); + } + + f_sleep(1.0); + setverdict(pass); +} + /* Replace a message that doesn't exist: failure */ testcase TC_cbsp_replace_nonexist() runs on cbsp_test_CT { var CBSP_IEs pages := {f_gen_page()}; @@ -945,6 +1000,7 @@ execute( TC_cbsp_write_lac() ); execute( TC_cbsp_write_then_replace() ); + execute( TC_cbsp_write_rep_period_num() ); execute( TC_cbsp_replace_nonexist() ); execute( TC_cbsp_write_too_many() ); execute( TC_cbsp_kill_nonexist() ); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27605 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I169c482ea5de040df63db4c605ac9cae19f8d28f Gerrit-Change-Number: 27605 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: msc tests: fix test so they don't depend on previous test runs

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 ) Change subject: msc tests: fix test so they don't depend on previous test runs ...................................................................... msc tests: fix test so they don't depend on previous test runs Change-Id: Iebaecd28a426b15baf4729f40b46dd33da79cbae --- M msc/MSC_Tests.ttcn 1 file changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/03/27603/1 diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 73029d8..0e4a2a2 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -1170,7 +1170,7 @@ f_expect_mm_info(); /* wait for normal teardown */ - f_expect_clear(); + f_expect_clear(verify_vlr_cell_id := false); /* Now the same IMSI is still attached in the VLR, and a LU with an unknown TMSI reveals the same IMSI only * later during ID Response. osmo-msc first creates a new vlr_subscr for the unknown TMSI, and as soon as the @@ -1207,7 +1207,7 @@ f_expect_mm_info(); /* wait for normal teardown */ - f_expect_clear(); + f_expect_clear(verify_vlr_cell_id := false); } testcase TC_attached_imsi_lu_unknown_tmsi() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -4410,7 +4410,7 @@ mtc.stop; } } - f_expect_clear(); + f_expect_clear(verify_vlr_cell_id:=false); } testcase TC_lu_with_invalid_mcc_mnc() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -6386,7 +6386,7 @@ f_msc_lu_hlr(); f_mm_imei(); f_expect_lu_reject(); - f_expect_clear(); + f_expect_clear(verify_vlr_cell_id:=false); } testcase TC_lu_imsi_auth_tmsi_check_imei_nack() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -6416,7 +6416,7 @@ f_msc_lu_hlr(); f_mm_imei(); f_expect_lu_reject(); - f_expect_clear(); + f_expect_clear(verify_vlr_cell_id:=false); } testcase TC_lu_imsi_auth_tmsi_check_imei_err() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -6507,7 +6507,7 @@ f_mm_imei_early(); f_expect_lu_reject(); - f_expect_clear(); + f_expect_clear(verify_vlr_cell_id:=false); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_nack() runs on MTC_CT { var BSC_ConnHdlr vc_conn; @@ -6535,7 +6535,7 @@ f_mm_imei_early(); f_expect_lu_reject(); - f_expect_clear(); + f_expect_clear(verify_vlr_cell_id:=false); } testcase TC_lu_imsi_auth_tmsi_check_imei_early_err() runs on MTC_CT { var BSC_ConnHdlr vc_conn; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27603 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebaecd28a426b15baf4729f40b46dd33da79cbae Gerrit-Change-Number: 27603 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: tcpdump capture script: check permissions to fix running in a netns

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 ) Change subject: tcpdump capture script: check permissions to fix running in a netns ...................................................................... tcpdump capture script: check permissions to fix running in a netns Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d --- M ttcn3-tcpdump-start.sh 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/27604/1 diff --git a/ttcn3-tcpdump-start.sh b/ttcn3-tcpdump-start.sh index 9b7a8b5..16a4714 100755 --- a/ttcn3-tcpdump-start.sh +++ b/ttcn3-tcpdump-start.sh @@ -42,6 +42,13 @@ /sbin/setcap -q -v 'cap_net_admin,cap_net_raw=pie' $DUMPCAP CAP_ERR="$?" fi + + # did we implicitly inherit all those caps because we're root in a netns? + if [ -u $DUMPCAP -o "$CAP_ERR" = "1" ]; then + getpcaps doesntmatter 2>&1 | grep -e cap_net_admin | grep -q -e cap_net_raw + CAP_ERR="$?" + fi + if [ -u $DUMPCAP -o "$CAP_ERR" = "0" ]; then CMD="$DUMPCAP -q" else -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27604 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I75f7af6cc67e96ffb7b002591f7f7d1da9b5a51d Gerrit-Change-Number: 27604 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

2024

2023

2022

gerrit-log March 2022