March 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc-nat[master]: sccp_sap_up_ran: ignore RAN until MSC is connected

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475 to look at the new patch set (#2). Change subject: sccp_sap_up_ran: ignore RAN until MSC is connected ...................................................................... sccp_sap_up_ran: ignore RAN until MSC is connected Related: SYS#5560 Change-Id: Idf9501412484fa92e8836952609fba7c5443d6c9 --- M include/osmocom/bsc_nat/msc.h M src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/msc_fsm.c 3 files changed, 15 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/75/27475/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Idf9501412484fa92e8836952609fba7c5443d6c9 Gerrit-Change-Number: 27475 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-bsc-nat[master]: Support forwarding messages with multiple BSCs

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476 to look at the new patch set (#2). Change subject: Support forwarding messages with multiple BSCs ...................................................................... Support forwarding messages with multiple BSCs Implement a proper subscriber connection mapping. Create a new subscr_conn when one of the stored BSCs sends a conn.ind and use that subscr_conn for all related connection-oriented messages with the same RAN-side conn_id to send messages back and forth between BSC and MSC. Add subscr_conn_get_next_id based on OsmoBSC's bsc_sccp_inst_next_conn_id. With this patch, it's possible to do a successful Location Updating procedure between MS2 and MSC in the following network: MS1 --- BTS1 --- BSC1 --. BSCNAT --- MSC MS2 --- BTS2 --- BSC2 --' Related: SYS#5560 Change-Id: I1556aa665fbb0a97507f98794e74820731fa6935 --- M doc/examples/osmo-bsc-nat/osmo-bsc-nat.cfg M include/osmocom/bsc_nat/Makefile.am M include/osmocom/bsc_nat/bsc_nat.h A include/osmocom/bsc_nat/subscr_conn.h M src/osmo-bsc-nat/Makefile.am M src/osmo-bsc-nat/bsc.c M src/osmo-bsc-nat/bsc_nat.c M src/osmo-bsc-nat/bsc_nat_fsm.c M src/osmo-bsc-nat/msc.c A src/osmo-bsc-nat/subscr_conn.c 10 files changed, 249 insertions(+), 85 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/76/27476/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27476 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I1556aa665fbb0a97507f98794e74820731fa6935 Gerrit-Change-Number: 27476 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-bsc-nat[master]: bsc_nat_fsm: tweak get_peer_addr

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27477 to look at the new patch set (#2). Change subject: bsc_nat_fsm: tweak get_peer_addr ...................................................................... bsc_nat_fsm: tweak get_peer_addr Rename the function from sccp_sap_get_peer_addr_in to get_peer_addr to make the code using it slightly more readable. The _in at the end of the function is not needed anymore, this was used to differentiate from peer_addr_out which was used in the caller code before the connection mapping was implemented in I1556aa665fbb0a97507f98794e74820731fa6935. Now instead of peer_addr_out, subscr_conn->bsc->addr or subscr_conn->msc->addr are used. Rename variable arguments to sccp_inst and addr to be consistent with the variable names in the callers. Related: SYS#5560 Change-Id: Ie023360724254be54cbaac4490b0341dfe68399f --- M src/osmo-bsc-nat/bsc_nat_fsm.c 1 file changed, 10 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc-nat refs/changes/77/27477/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: Ie023360724254be54cbaac4490b0341dfe68399f Gerrit-Change-Number: 27477 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: rsl: fix wrong IE being checked in rsl_rx_chan_activ()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/27486 ) Change subject: rsl: fix wrong IE being checked in rsl_rx_chan_activ() ...................................................................... rsl: fix wrong IE being checked in rsl_rx_chan_activ() According to 3GPP TS 48.058, section 4.1.4, BTS shall start transmission on SACCH if both MS Power and *Timing Advance* IEs are present. There can be no Access Delay IE in the RSL CHANnel ACTIVation message. Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Fixes: I170b63c9856230d5f1a10654a9d950ada8e730d7 Related: SYS#5838 --- M src/common/rsl.c 1 file changed, 9 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/86/27486/1 diff --git a/src/common/rsl.c b/src/common/rsl.c index 7d6621a..5112ee5 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -1902,21 +1902,21 @@ /* Indicate which SAPIs should be enabled before the first RACH is received, for handover. See 3GPP TS 48.058 * 4.1.3 and 4.1.4. * - * | | Access || transmit | activate | This implementation - * | MS Power | Delay || on main channel | dl SACCH | activates DL SACCH + * | | Timing || transmit | activate | This implementation + * | MS Power | Advance || on main channel | dl SACCH | activates DL SACCH * ----------------------------------------------------------------------------------------- - * async ho no * --> yes no no - * async ho yes * --> yes may be started no - * async ho yes yes --> yes may be started yes - * sync ho no no --> yes no no - * sync ho yes no --> yes may be started no - * sync ho yes yes --> yes shall be started yes + * async ho no * --> yes no no + * async ho yes * --> yes may be started no + * async ho yes yes --> yes may be started yes + * sync ho no no --> yes no no + * sync ho yes no --> yes may be started no + * sync ho yes yes --> yes shall be started yes */ switch (type) { case RSL_ACT_INTER_ASYNC: case RSL_ACT_INTER_SYNC: lchan->want_dl_sacch_active = (TLVP_PRES_LEN(&tp, RSL_IE_MS_POWER, 1) - && TLVP_PRES_LEN(&tp, RSL_IE_ACCESS_DELAY, 1)); + && TLVP_PRES_LEN(&tp, RSL_IE_TIMING_ADVANCE, 1)); break; default: lchan->want_dl_sacch_active = true; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Icd8ccfd6e37ded8966125a473b5003845ba87fec Gerrit-Change-Number: 27486 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-dev[master]: ttcn3/tmux/ttcn3-bts-test.sh: fix incorrectly passed --trx arguments

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/27485 ) Change subject: ttcn3/tmux/ttcn3-bts-test.sh: fix incorrectly passed --trx arguments ...................................................................... ttcn3/tmux/ttcn3-bts-test.sh: fix incorrectly passed --trx arguments For some reason, on Arch Linux: $ file /bin/sh /bin/sh: symbolic link to bash $ sh --version GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu) the '--trx' arguments are getting passed incorrectly: $ ./fake_trx.py TRX1@127.0.0.1:5700/1 TRX2@127.0.0.1:5700/2 TRX3@127.0.0.1:5700/3 fake_trx: error: unrecognized arguments: TRX1@127.0.0.1:5700/1 TRX2@127.0.0.1:5700/2 TRX3@127.0.0.1:5700/3 Let's send each argument separately. Change-Id: Ibf28ac013c426baba491af45e2ae46f37685a402 --- M ttcn3/tmux/ttcn3-bts-test.sh 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/85/27485/1 diff --git a/ttcn3/tmux/ttcn3-bts-test.sh b/ttcn3/tmux/ttcn3-bts-test.sh index e506071..4d05d07 100755 --- a/ttcn3/tmux/ttcn3-bts-test.sh +++ b/ttcn3/tmux/ttcn3-bts-test.sh @@ -46,9 +46,10 @@ tmux send-keys -t $SESSION:1.1 "./trxcon -s /tmp/osmocom_l2" C-m # Start fake_trx.py tmux send-keys -t $SESSION:1.2 "cd $OBB_DIR/src/target/trx_toolkit" C-m -tmux send-keys -t $SESSION:1.2 "./fake_trx.py \ - --trx TRX1@127.0.0.1:5700/1 \ - --trx TRX2@127.0.0.1:5700/2 \ - --trx TRX3@127.0.0.1:5700/3" C-m +tmux send-keys -t $SESSION:1.2 "./fake_trx.py" +tmux send-keys -t $SESSION:1.2 " --trx TRX1@127.0.0.1:5700/1" +tmux send-keys -t $SESSION:1.2 " --trx TRX2@127.0.0.1:5700/2" +tmux send-keys -t $SESSION:1.2 " --trx TRX3@127.0.0.1:5700/3" +tmux send-keys -t $SESSION:1.2 C-m tmux attach -t $SESSION:0 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27485 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: Ibf28ac013c426baba491af45e2ae46f37685a402 Gerrit-Change-Number: 27485 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-dev[master]: ttcn3/tmux/ttcn3-bts-test.sh: fix copy-pasted TRX names

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-dev/+/27484 ) Change subject: ttcn3/tmux/ttcn3-bts-test.sh: fix copy-pasted TRX names ...................................................................... ttcn3/tmux/ttcn3-bts-test.sh: fix copy-pasted TRX names Change-Id: I5959acdf07caa1e9003662b0c11c3df68ca933fe --- M ttcn3/tmux/ttcn3-bts-test.sh 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-dev refs/changes/84/27484/1 diff --git a/ttcn3/tmux/ttcn3-bts-test.sh b/ttcn3/tmux/ttcn3-bts-test.sh index 78acad9..e506071 100755 --- a/ttcn3/tmux/ttcn3-bts-test.sh +++ b/ttcn3/tmux/ttcn3-bts-test.sh @@ -48,7 +48,7 @@ tmux send-keys -t $SESSION:1.2 "cd $OBB_DIR/src/target/trx_toolkit" C-m tmux send-keys -t $SESSION:1.2 "./fake_trx.py \ --trx TRX1@127.0.0.1:5700/1 \ - --trx TRX1@127.0.0.1:5700/2 \ - --trx TRX1@127.0.0.1:5700/3" C-m + --trx TRX2@127.0.0.1:5700/2 \ + --trx TRX3@127.0.0.1:5700/3" C-m tmux attach -t $SESSION:0 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27484 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I5959acdf07caa1e9003662b0c11c3df68ca933fe Gerrit-Change-Number: 27484 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

3 years, 3 months

1
0
0 0

Change in osmo-bts[master]: osmo-bts-trx: rx_tchh_fn(): fix HR SID detection (wrong offset)

by fixeria

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/27430 ) Change subject: osmo-bts-trx: rx_tchh_fn(): fix HR SID detection (wrong offset) ...................................................................... Patch Set 4: (1 comment) File src/osmo-bts-trx/sched_lchan_tchh.c: https://gerrit.osmocom.org/c/osmo-bts/+/27430/comment/6be32387_cfe70153 PS4, Line 316: tch_data[0] = 0x70; /* F = 0, FT = 111 */ As can be seen, this additional header is actually needed and used in the code. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/27430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ie5fa776dcb2b2203a97aed56ecbf2450af7d87c1 Gerrit-Change-Number: 27430 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Mar 2022 08:15:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: MGCP_Test: ensure PT translation works when converting AMR bwe/oa

by fixeria

Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27384 ) Change subject: MGCP_Test: ensure PT translation works when converting AMR bwe/oa ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27384 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id734b6954098130bba02f8cdf1b06e0080c3e915 Gerrit-Change-Number: 27384 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Mar 2022 08:10:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 3 months

1
0
0 0

Change in osmo-dev[master]: net/templates/run.sh: change prefix from CN to NET

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27459 ) Change subject: net/templates/run.sh: change prefix from CN to NET ...................................................................... net/templates/run.sh: change prefix from CN to NET osmo-dev's net scripts can be used to run components from RAN too, so change the title prefix and tmux session name from CN to NET. Change-Id: I3f46d5a4c7bd20861735c4e01f7cafbc5db08aae --- M net/templates/run.sh 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/net/templates/run.sh b/net/templates/run.sh index a7b0f9a..6b8a324 100755 --- a/net/templates/run.sh +++ b/net/templates/run.sh @@ -1,7 +1,7 @@ #!/usr/bin/env bash # tmux: start this script inside a new session -tmux_session="CN" +tmux_session="NET" if [ "${TERMINAL}" = "tmux" ] && [ "$1" != "inside-tmux" ]; then echo "Starting tmux session '$tmux_session'" unset TMUX @@ -145,7 +145,7 @@ *) sleep .2 $terminal \ - -title "CN:$title" \ + -title "NET:$title" \ -e sh -c "$launcher" \ & -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I3f46d5a4c7bd20861735c4e01f7cafbc5db08aae Gerrit-Change-Number: 27459 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

Change in osmo-dev[master]: net/templates/osmo-bsc-nat.cfg: omit PC for bsc

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-dev/+/27460 ) Change subject: net/templates/osmo-bsc-nat.cfg: omit PC for bsc ...................................................................... net/templates/osmo-bsc-nat.cfg: omit PC for bsc With most recent OsmoBSCNAT patches, the addresses from the connecting BSCs get used, no need to hardcode them in the config anymore. Depends: osmo-bsc-nat I1556aa665fbb0a97507f98794e74820731fa6935 Change-Id: I78ef36c72ff9a7b801e922eccc89dc44fbba7f23 --- M net/templates/osmo-bsc-nat.cfg 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: osmith: Looks good to me, approved; Verified diff --git a/net/templates/osmo-bsc-nat.cfg b/net/templates/osmo-bsc-nat.cfg index 38ac647..41187a3 100644 --- a/net/templates/osmo-bsc-nat.cfg +++ b/net/templates/osmo-bsc-nat.cfg @@ -14,10 +14,6 @@ asp asp-clnt-OsmoBSCNAT-RAN 2905 0 m3ua remote-ip ${STP_RAN_IP} local-ip ${BSCNAT_RAN_IP} - sccp-address bsc - routing-indicator PC - point-code ${BSC0_PC} - subsystem-number 254 bsc-nat cs7-instance-cn 0 -- To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/27460 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-dev Gerrit-Branch: master Gerrit-Change-Id: I78ef36c72ff9a7b801e922eccc89dc44fbba7f23 Gerrit-Change-Number: 27460 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: merged

3 years, 3 months

1
0
0 0

2025

2024

2023

2022

gerrit-log March 2022