February 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: scripts/osmocom-packages-docker: docker run --rm

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27148 ) Change subject: scripts/osmocom-packages-docker: docker run --rm ...................................................................... scripts/osmocom-packages-docker: docker run --rm Change-Id: I357ae8071d27088a2c0a74f962ac1589bff43a70 --- M scripts/osmocom-packages-docker.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/scripts/osmocom-packages-docker.sh b/scripts/osmocom-packages-docker.sh index a7a804b..a541a87 100755 --- a/scripts/osmocom-packages-docker.sh +++ b/scripts/osmocom-packages-docker.sh @@ -25,6 +25,7 @@ esac docker run \ + --rm \ -e "FEED=$FEED" \ -e "OSMO_OBS_CONFLICT_PKGVER=$OSMO_OBS_CONFLICT_PKGVER" \ -e "PACKAGES=$PACKAGES" \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27148 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I357ae8071d27088a2c0a74f962ac1589bff43a70 Gerrit-Change-Number: 27148 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: editorconfig: new file

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27147 ) Change subject: editorconfig: new file ...................................................................... editorconfig: new file Auto-configure editors with editorconfig plugin installed to indent yaml files with two spaces in this repository. Change-Id: I008ee040e2c15db11a35a061faa4270bacdbd10d --- A .editorconfig 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 0000000..23fbc8d --- /dev/null +++ b/.editorconfig @@ -0,0 +1,12 @@ +; This file is for unifying the coding style for different editors and IDEs. +; See http://editorconfig.org for details. + +# Top-most EditorConfig file. +root = true + +[**/*.yml] +indent_size = 2 +indent_style = space +end_of_line = lf +insert_final_newline = true +trim_trailing_whitespace = true -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I008ee040e2c15db11a35a061faa4270bacdbd10d Gerrit-Change-Number: 27147 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: ansible/setup-jenkins-slave: accept rel-change

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27151 ) Change subject: ansible/setup-jenkins-slave: accept rel-change ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27151 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I90ee8dd49001d6810f2118e9feff3375e87052ea Gerrit-Change-Number: 27151 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 15:36:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: ansible/ansible.cfg: make command output readable

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27150 ) Change subject: ansible/ansible.cfg: make command output readable ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27150 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I88d584a1808d82d75906b350e3bffe9bc73a8c67 Gerrit-Change-Number: 27150 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 15:36:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: lint: catch missing --rm flag for 'docker run'

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27149 ) Change subject: lint: catch missing --rm flag for 'docker run' ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27149 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8ab9c291504475d670bdefc50c4524c5bdd4c880 Gerrit-Change-Number: 27149 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 15:35:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Add hnbgw tests

by pespin

Attention is currently required from: daniel, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 ) Change subject: Add hnbgw tests ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File library/RUA_Emulation.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106/comment/79bbf2e5_e3a6… PS4, Line 76: type bitstring ContextId length(24); // with { variant "FIELDLENGTH(24)" }; I see lots of commented stuff in this file. Give it a look. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27106 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a2fb795aec83337eda8d9972e6ff264ead61076 Gerrit-Change-Number: 27106 Gerrit-PatchSet: 4 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 15:35:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: common/pipework: deduplicate

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27159 ) Change subject: common/pipework: deduplicate ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27159 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I88ff40ca69c9ee76bef9bb8f24f66ca9d5ac751a Gerrit-Change-Number: 27159 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 15:35:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in docker-playground[master]: make/Makefile: always use docker run --rm

by laforge

Attention is currently required from: osmith, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/27158 ) Change subject: make/Makefile: always use docker run --rm ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/27158 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Iea063aa39a08397ea64d2018b433991a130e7f56 Gerrit-Change-Number: 27158 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 15:34:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in osmo-ci[master]: scripts/docker-cleanup.sh: conditional img clean

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/27156 ) Change subject: scripts/docker-cleanup.sh: conditional img clean ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/27156 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I1cef0833c096de0fa5acf77156bb5dd362e2ef9c Gerrit-Change-Number: 27156 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 11 Feb 2022 15:33:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 4 months

1
0
0 0

Change in pysim[master]: filesystem: Don't pass empty string to parse_select_response()

by laforge

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/27166 ) Change subject: filesystem: Don't pass empty string to parse_select_response() ...................................................................... filesystem: Don't pass empty string to parse_select_response() This happens e.g. when selecting the ARA-M applet on sysmoISIM-SJA2: pySIM-shell (MF)> select ADF.ARA-M -> 00a4040409 a00000015141434c00 <- 9000: Traceback (most recent call last): File "/space/home/laforge/.local/lib/python3.9/site-packages/cmd2/cmd2.py", line 2064, in onecmd_plus_hooks stop = self.onecmd(statement, add_to_history=add_to_history) File "/space/home/laforge/.local/lib/python3.9/site-packages/cmd2/cmd2.py", line 2494, in onecmd stop = func(statement) File "/space/home/laforge/projects/git/pysim/./pySim-shell.py", line 750, in do_select fcp_dec = self._cmd.rs.select(path, self._cmd) File "/space/home/laforge/projects/git/pysim/pySim/filesystem.py", line 1314, in select select_resp = f.decode_select_response(data) File "/space/home/laforge/projects/git/pysim/pySim/filesystem.py", line 193, in decode_select_response return self.parent.decode_select_response(data_hex) File "/space/home/laforge/projects/git/pysim/pySim/filesystem.py", line 378, in decode_select_response return profile.decode_select_response(data_hex) File "/space/home/laforge/projects/git/pysim/pySim/ts_102_221.py", line 796, in decode_select_response t.from_tlv(h2b(resp_hex)) File "/space/home/laforge/projects/git/pysim/pySim/tlv.py", line 231, in from_tlv (rawtag, remainder) = self.__class__._parse_tag_raw(do) File "/space/home/laforge/projects/git/pysim/pySim/tlv.py", line 258, in _parse_tag_raw return bertlv_parse_tag_raw(do) File "/space/home/laforge/projects/git/pysim/pySim/utils.py", line 208, in bertlv_parse_tag_raw if binary[0] == 0xff and len(binary) == 1 or binary[0] == 0xff and binary[1] == 0xff: IndexError: bytearray index out of range EXCEPTION of type 'IndexError' occurred with message: 'bytearray index out of range' Change-Id: I910e6deba27d1483dff1e986c89f1a1b2165f49b --- M pySim/filesystem.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/66/27166/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index a323c5b..e5c56fc 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -372,6 +372,9 @@ install specific decoding. """ + if data_hex == None or data_hex == '': + return data_hex + profile = self.get_profile() if profile: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/27166 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I910e6deba27d1483dff1e986c89f1a1b2165f49b Gerrit-Change-Number: 27166 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-MessageType: newchange

3 years, 4 months

1
0
0 0

2025

2024

2023

2022

gerrit-log February 2022