December 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-gprs[master]: sndcp: Initial libosmo-gprs-sndcp support

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30490 ) Change subject: sndcp: Initial libosmo-gprs-sndcp support ...................................................................... Patch Set 12: Code-Review-1 (5 comments) File include/osmocom/gprs/sndcp/sndcp.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/faa04f12_8862d943 PS12, Line 8: osmocom/core/msgb.h You're not using msgb API in this file, why including it here? https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/a711d9cf_f7b8ed3b PS12, Line 13: GPRS_ missing OSMO_ prefix in public API File include/osmocom/gprs/sndcp/sndcp_prim.h: https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/1c613d94_56746455 PS12, Line 117: OSMO_GPRS_SNDCP_BSSGP_ OSMO_GPRS_SNDCP_SNSM_ File tests/sndcp/Makefile.am: https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/df0dd715_afe7bd72 PS12, Line 53: $(NULL) " No newline at end of revision file. " File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/f2a9aeb4_d0bc99d8 PS12, Line 56: AT_CLEANUP " No newline at end of revision file. " -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30490 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ie05b5d721cf0a6147ed45c1feb75ad829865252b Gerrit-Change-Number: 30490 Gerrit-PatchSet: 12 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Dec 2022 15:37:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in libosmo-gprs[master]: osmo_gprs_llc_bssgp_prim: cell_id is always RAI + CI

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30787 ) Change subject: osmo_gprs_llc_bssgp_prim: cell_id is always RAI + CI ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/30787 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: I1efcdbe3e42be35e191bcb1ae513c768d63096aa Gerrit-Change-Number: 30787 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Dec 2022 15:15:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: add OML tests for bts_setup_ramp

by lynxis lazus

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 ) Change subject: BSC_Tests: add OML tests for bts_setup_ramp ...................................................................... Patch Set 2: (1 comment) File bsc/BSC_Tests_OML.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356/comment/842af31f_74be… PS1, Line 3: OsmoBTS > OsmoBSC Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30356 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0934ea26db359b0a6649c613f01de134a3a372ee Gerrit-Change-Number: 30356 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Dec 2022 14:09:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: osmo-bts: add simple run_fake_trx.sh

by lynxis lazus

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30700 ) Change subject: osmo-bts: add simple run_fake_trx.sh ...................................................................... osmo-bts: add simple run_fake_trx.sh Most BTS_Tests require to run fake_trx. Add a simple run_fake_trx.sh script when running these test without docker. Change-Id: Ie3a68931bd52f55570409bb35962cebbfd58d168 --- A bts/run_fake_trx.sh 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/run_fake_trx.sh b/bts/run_fake_trx.sh new file mode 100755 index 0000000..2209972 --- /dev/null +++ b/bts/run_fake_trx.sh @@ -0,0 +1,11 @@ +#!/bin/bash + +# Most BTS_Tests require to have fake_trx running. +# fake trx is part of osmo-trx +FAKE_TRX_DIR="${FAKE_TRX_DIR:-../../osmo-trx/osmocom-bb/src/target/trx_toolkit}" + +if [ -n "$FAKE_TRX_DIR" ] ; then + cd "$FAKE_TRX_DIR" +fi + +exec ./fake_trx.py --trx TRX1@127.0.0.1:5700/1 --trx TRX2@127.0.0.1:5700/2 --trx TRX3@127.0.0.1:5700/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30700 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie3a68931bd52f55570409bb35962cebbfd58d168 Gerrit-Change-Number: 30700 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-sgsn[master]: Move some functions gprs_gb.[c,h] -> gprs_gmm.[c,h]

by lynxis lazus

Attention is currently required from: osmith, pespin, fixeria, msuraev. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30785 ) Change subject: Move some functions gprs_gb.[c,h] -> gprs_gmm.[c,h] ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/sgsn/gprs_sndcp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/30785/comment/3ce4c788_f10b78cc PS4, Line 44: > It's better to keep the empty line separating includes from defines - makes it easier to read. +1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30785 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3dcbe1d0f75cb91ec8b700e239e2ba16fff030a2 Gerrit-Change-Number: 30785 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Dec 2022 14:07:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-sgsn[master]: Create new specific file for BSSGP code

by lynxis lazus

Attention is currently required from: osmith, pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30784 ) Change subject: Create new specific file for BSSGP code ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30784 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I816396ab5ccb86032bbc21b41a959934a7768780 Gerrit-Change-Number: 30784 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Dec 2022 14:06:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-sgsn[master]: Rename gprs_gb.[c,h] -> gprs_ns.[c,h]

by lynxis lazus

Attention is currently required from: osmith, pespin, fixeria. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30786 ) Change subject: Rename gprs_gb.[c,h] -> gprs_ns.[c,h] ...................................................................... Patch Set 4: Code-Review+1 (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/30786/comment/30ab7467_9d9dadaa PS4, Line 8: A simple commit description it is all NS code would be great and no gb related code. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I8312c8a70d60cab48764950c5b57ca02964e9db2 Gerrit-Change-Number: 30786 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sun, 25 Dec 2022 14:05:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix "Timeout waiting for L1CTL_FBSB_CONF"

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30789 to look at the new patch set (#3). Change subject: BTS_Tests: fix "Timeout waiting for L1CTL_FBSB_CONF" ...................................................................... BTS_Tests: fix "Timeout waiting for L1CTL_FBSB_CONF" Since [1] was merged, sending the L1CTL_DM_REL_REQ message alone is not enough to be able to tune back to BCCH. We also need to send L1CTL_RESET_REQ, so the trxcon's state is reset properly. This patch fixes the following testcases: * TC_sacch_chan_act_ho_async, * TC_sacch_chan_act_ho_sync, * TC_conn_fail_crit. Change-Id: I07192e8a3127f8d9557a4b8aac3ca002f511a1d5 Related: [1] I5bbe6ca4cc6299f9faf343822c992a6872a45081 (osmocom-bb.git) --- M bts/BTS_Tests.ttcn 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/30789/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07192e8a3127f8d9557a4b8aac3ca002f511a1d5 Gerrit-Change-Number: 30789 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix "Timeout waiting for L1CTL_FBSB_CONF"

by fixeria

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30789 to look at the new patch set (#2). Change subject: BTS_Tests: fix "Timeout waiting for L1CTL_FBSB_CONF" ...................................................................... BTS_Tests: fix "Timeout waiting for L1CTL_FBSB_CONF" Since [1] was merged, sending the L1CTL_DM_REL_REQ message alone is not enough to be able to tune back to BCCH. We also need to send L1CTL_RESET_REQ, so the trxcon's state is reset properly. This patch fixes the following testcases: * TC_sacch_chan_act_ho_async, * TC_sacch_chan_act_ho_sync, * TC_conn_fail_crit. Change-Id: I07192e8a3127f8d9557a4b8aac3ca002f511a1d5 Related: [1] I5bbe6ca4cc6299f9faf343822c992a6872a45081 (osmocom-bb.git) --- M bts/BTS_Tests.ttcn 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/30789/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07192e8a3127f8d9557a4b8aac3ca002f511a1d5 Gerrit-Change-Number: 30789 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BTS_Tests: fix TC_conn_fail_crit: send L1CTL RESET.req

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30789 ) Change subject: BTS_Tests: fix TC_conn_fail_crit: send L1CTL RESET.req ...................................................................... BTS_Tests: fix TC_conn_fail_crit: send L1CTL RESET.req Since [1] was merged, sending the L1CTL_DM_REL_REQ message alone is not enough to be able to tune back to BCCH. We also need to send L1CTL_RESET_REQ, so the trxcon's state is reset properly. Change-Id: I07192e8a3127f8d9557a4b8aac3ca002f511a1d5 Related: [1] I5bbe6ca4cc6299f9faf343822c992a6872a45081 (osmocom-bb.git) --- M bts/BTS_Tests.ttcn 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/89/30789/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 9baee40..57c2397 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -3944,7 +3944,8 @@ f_est_dchan(); f_sleep(2.0); - L1CTL.send(ts_L1CTL_DM_REL_REQ(g_chan_nr)); + f_L1CTL_DM_REL_REQ(L1CTL, g_chan_nr); + f_L1CTL_RESET(L1CTL); f_l1_tune(L1CTL); /* tune back to BCCH */ timer T := 40.0; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I07192e8a3127f8d9557a4b8aac3ca002f511a1d5 Gerrit-Change-Number: 30789 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022