Change in osmo-trx[master]: ignore vscode dirs
by Hoernchen
Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30410 )
Change subject: ignore vscode dirs
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30410
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c
Gerrit-Change-Number: 30410
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 13:28:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans
by pespin
Attention is currently required from: laforge, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 )
Change subject: paging: Split paging queue into 2 queues: initial and retrans
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/osmo-bsc/bsc_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/b75d13f9_13897a75
PS1, Line 1045: static void paging_dump_vty(struct vty *vty, struct gsm_paging_request *pag)
: {
: vty_out(vty, "Paging on BTS %u%s", pag->bts->nr, VTY_NEWLINE);
: bsc_subscr_dump_vty(vty, pag->bsub);
: }
:
: static void bts_paging_dump_vty(struct vty *vty, struct gsm_bts *bts)
: {
: struct gsm_paging_request *pag;
:
: llist_for_each_entry(pag, &bts->paging.initial_req_list, entry)
: paging_dump_vty(vty, pag);
: llist_for_each_entry(pag, &bts->paging.retrans_req_list, entry)
: paging_dump_vty(vty, pag);
> minor (can be follow-up patch): It might make sense to extend the vty dumping with some information […]
Will be submitted as Change-ID I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747
Gerrit-Change-Number: 30363
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 13:27:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ms-trx support
by fixeria
Attention is currently required from: Hoernchen, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 3: Code-Review-1
(16 comments)
File Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b149085f_86bef51a
PS3, Line 37: osmocom-bb/src/host/trxcon \
> osmocom-bb/src/host/trxcon is added twice? here and above
Ack. Most likely he forgot to remove this line.
File Transceiver52M/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d979a6e9_746c2026
PS3, Line 26: AM_CPPFLAGS
'-I' stuff should be in CPPFLAGS only, it makes no sense to have it in CFLAGS/CXXFLAGS.
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c6880f67_88b3bfc7
PS3, Line 77: LIBOSMOCODING_LIBS
Having LIBOSMOCODING_LIBS in COMMON_LDADD makes all osmo-trx-* binaries depend on libosmocoding, while it's only needed for osmo-trx-ms-* and osmo-prbs-tool.
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83a2d0fc_dd0a1d18
PS3, Line 90: noinst_HEADERS
This should be done conditionally too, but not critical I guess.
File Transceiver52M/ms/itrq.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16aab7e0_8f217ba5
PS3, Line 34: /*
weird comment formatting, please make it consistent with the copyright header
File Transceiver52M/ms/l1ctl_server_cb.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0c228dc_35756759
PS3, Line 65: osmocom_l2
TODO: make path configurable
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2921f8c4_7e180c4a
PS3, Line 74: return
so the app keeps running if l1ctl_server_alloc() fails?
File Transceiver52M/ms/logging.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d82e3853_8e6bb5aa
PS3, Line 54: loglevel = LOGL_NOTICE
spacing issues
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8293fbce_b4ab0313
PS3, Line 57: DTRXC
not used by libtrxcon nor needed
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/98faf6d8_0b0b4d10
PS3, Line 64: DTRXD
not used by libtrxcon nor needed
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ac236f1_1832c8bf
PS3, Line 75: .loglevel = LOGL_NOTICE,
spacing issues
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/577062e9_90eb9294
PS3, Line 76: enabled = 0,
why disabled?
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40fa09ba_dd2d7c09
PS3, Line 82: .loglevel = LOGL_NOTICE,
spacing issues
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/668f1798_05ce8f1c
PS3, Line 330: test -d osmocom-bb
A proper approach would be making this configurable: --enable-ms or --with-ms.
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/552f7b86_a9ccfcd7
PS3, Line 333: AC_MSG_NOTICE(["Enabling ms-trx..."])
spacing issues
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd88649c_69bebf3b
PS3, Line 364: doc/manuals/Makefile \
> This looks like a separate patch.
Ack, it's one of my fixups: https://cgit.osmocom.org/osmo-trx/commit/?h=fixeria/ms&id=8ed86879c4ea9a0ed…
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 13:26:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans
by fixeria
Attention is currently required from: laforge, pespin, daniel.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 )
Change subject: paging: Split paging queue into 2 queues: initial and retrans
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/2862818f_ac66d84c
PS1, Line 216: page_ms(request);
> Ack
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747
Gerrit-Change-Number: 30363
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 13:13:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans
by osmith
Attention is currently required from: fixeria, pespin, daniel.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 )
Change subject: paging: Split paging queue into 2 queues: initial and retrans
......................................................................
Patch Set 2: Code-Review+1
(4 comments)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/da8d2c5e_062f6abb
PS1, Line 216:
> Is there a way to include this in our lint job?
it could probably extended for that, but I don't think it's worth investigating right now. it's a perl script from the linux kernel (checkpatch).
https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/215193ae_5e983785
PS1, Line 263: bts_pag_st->initial_req_list_len--;
> Yeah, same behavior, just more encapsulated. […]
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/e8e95c19_df47880a
PS1, Line 279: static unsigned int step_page_retrans_reqs(struct gsm_bts_paging_state *bts_pag_st, unsigned int max_page_req_per_iter, const struct timespec *now)
> This line exceeds the 120 chars-per-line limit.
Done
https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/211fc5b0_7b325c6e
PS1, Line 532:
> indentation
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747
Gerrit-Change-Number: 30363
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 13:03:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: vita demod by piotr krysik, modified
by fixeria
Attention is currently required from: Hoernchen.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 )
Change subject: vita demod by piotr krysik, modified
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dca47a9d_0effbb4b
PS2, Line 7: by piotr krysik
Commit message should ideally state where the code is imported from, including the commit hash if it's a repository. AFAICS it's from gr-gsm.git?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f
Gerrit-Change-Number: 30415
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:51:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: osmocom-bb for ms-trx side trxcon integration
by pespin
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30412 )
Change subject: osmocom-bb for ms-trx side trxcon integration
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File .gitmodules:
https://gerrit.osmocom.org/c/osmo-trx/+/30412/comment/5c8397f0_d47ef551
PS1, Line 4: branch = a4aac5c3554559c2c994609f90b92a9daf6e8a89
I wonder shouldn't this be set to track master in general?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30412
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61
Gerrit-Change-Number: 30412
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:42:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: osmocom-bb for ms-trx side trxcon integration
by fixeria
Attention is currently required from: Hoernchen.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30412 )
Change subject: osmocom-bb for ms-trx side trxcon integration
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30412
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61
Gerrit-Change-Number: 30412
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:39:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ignore vscode dirs
by fixeria
Attention is currently required from: Hoernchen.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30410 )
Change subject: ignore vscode dirs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30410
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c
Gerrit-Change-Number: 30410
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:38:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: rename noisevector class -> avgvector
by fixeria
Attention is currently required from: Hoernchen.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30411 )
Change subject: rename noisevector class -> avgvector
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927
Gerrit-Change-Number: 30411
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:38:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: rename noisevector class -> avgvector
by fixeria
Attention is currently required from: Hoernchen.
fixeria has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30411 )
Change subject: rename noisevector class -> avgvector
......................................................................
Removed Verified-1 by Jenkins Builder (1000002)
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927
Gerrit-Change-Number: 30411
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: deleteVote
1 year, 5 months
- 1
- 0
Change in osmo-ci[master]: hosts: update coverity-slaves
by pespin
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30419 )
Change subject: hosts: update coverity-slaves
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30419
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0
Gerrit-Change-Number: 30419
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:34:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-ci[master]: ansible/coverity: extract into subdirectory
by pespin
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30418 )
Change subject: ansible/coverity: extract into subdirectory
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30418
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b
Gerrit-Change-Number: 30418
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:34:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-ci[master]: ansible: coverity: update version to 22.06
by pespin
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30417 )
Change subject: ansible: coverity: update version to 22.06
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30417
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4
Gerrit-Change-Number: 30417
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:33:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ms-trx support
by pespin
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 3:
(10 comments)
File .gitignore:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0086bac1_ac4d05be
PS3, Line 10: Transceiver52M/osmo-trx-ipc2
This doesn't belong to this commit afaiu.
Patchset:
PS3:
Why is the ms-trx put into a subdir under Transceiver52M?
Can we have the Transceiver52M directory converted to libtransceiver.la or alike, then have an osmo-trx and osmo-trx-ms directories so that we don't merged stuf even more?
File Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0296f7c1_dc193b65
PS3, Line 37: osmocom-bb/src/host/trxcon \
osmocom-bb/src/host/trxcon is added twice? here and above
File Transceiver52M/Makefile.am:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9911755_990eb911
PS3, Line 27: AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/
Is it OK if the submodule isn't there and the patch doesn't exist? I guess it's fine, the compiler just ignores that one.
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2448b1a0_d64369bb
PS3, Line 28: AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/
What about filling a LIBTRXCON_CFLAGS/LIBS in configure? It would be way more cleaner.
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3233721a_fa3176d3
PS3, Line 82: $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libl1sched.a \
LIBTRXCON_LIBS in configure.ac
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f68ebf93_26c3e026
PS3, Line 115: $(TRXCON_LDADD)
LIBTRXCON_LIBS in configure.ac
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2c867b9e_ec7f24a0
PS3, Line 124: $(TRXCON_LDADD)
LIBTRXCON_LIBS in configure.ac
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3405ad0d_6ed50393
PS3, Line 187: # bin_PROGRAMS += osmo-trx-ipc2
This doesn't belong to this patch.
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f629f50e_a7357ce6
PS3, Line 364: doc/manuals/Makefile \
This looks like a separate patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:33:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: vita demod by piotr krysik, modified
by pespin
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 )
Change subject: vita demod by piotr krysik, modified
......................................................................
Patch Set 2:
(5 comments)
File Transceiver52M/grgsm_vitac/constants.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc5d57fe_d5da79bd
PS2, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second
Having "//" comments in a define looks dangerous to me, I'm not sure if first the comments are dropped or firt the preprocessor is run.
In any case, I think we tend to use /**/ everywhere.
File Transceiver52M/grgsm_vitac/grgsm_vitac.h:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6ba59ef2_8eef2d3b
PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
> Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Please fix.
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29c865ad_68bde2ad
PS2, Line 38: void initvita();
> Bad function definition - void initvita() should probably be void initvita(void)
Please fix.
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2bd6c0cd_05adc4da
PS2, Line 62: };
> adding a line without newline at end of file
Please fix.
File Transceiver52M/grgsm_vitac/viterbi_detector.cc:
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3fd9ef39_33dcc2b5
PS2, Line 1: /* -*- c++ -*- */
All files are named ".cpp", why is this one named ".cc"?
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f
Gerrit-Change-Number: 30415
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:22:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ill-fated ipcv2 for mstrx
by pespin
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 )
Change subject: ill-fated ipcv2 for mstrx
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a0027ad1_fde20f25
PS2, Line 10: inteval to a few fn/ts on the trx side to work at all, but scheduling
interval
Patchset:
PS2:
so the outcome is that this is actually not going to be used for now?
Then let's better keep it in a separate branch to avoid having to maintain even more interfaces, implementations, etc.
Let's also avoid this way someone using it to implement a a device without us knowing and having to keep the interface around in the future until it has been proven to be useful.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:16:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: bladerf xa4 support
by pespin
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 )
Change subject: bladerf xa4 support
......................................................................
Patch Set 1: Code-Review-1
(10 comments)
Patchset:
PS1:
Few small things to clean up, otherwise good.
File Transceiver52M/device/bladerf/bladerf.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a41e15f3_d229b0e7
PS1, Line 51: fprintf(stderr, "%s:%s:%d %s\n", __FILE__, __FUNCTION__, __LINE__, bladerf_strerror(status)); \
LOGP?
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ae39cbd3_dc96c1cd
PS1, Line 240: ts_offset = 60; //static_cast<TIMESTAMP>(desc.offset * rx_rate);
maybe add some TODO/FIXME comment about this?
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/8f9ea403_7a982311
PS1, Line 422: // Create receive buffer
use comment style: /* */
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0d9e8324_13d8a4da
PS1, Line 427: // Create vector buffer
use comment style: /* */
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/f4eadbb4_36ab525f
PS1, Line 432: // Initialize and shadow gain values
use comment style: /* */
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/54b3a7f1_8a827c2b
PS1, Line 466: // Start streaming
use comment style: /* */
Check all the file below for same type of issues.
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/26354d52_2909b7d4
PS1, Line 701: relatively recent machines shows that the B100 will underrun when
B100? is this a BladeRF?
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/71228494_9e196583
PS1, Line 727: #ifndef IPCMAGIC
what's this for?
File configure.ac:
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/28c1f574_ab1bcdf3
PS1, Line 346: Transceiver52M/device/ipc2/Makefile \
ipc2? this is probably not related to this patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac
Gerrit-Change-Number: 30413
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:12:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-ci[master]: hosts: update coverity-slaves
by osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30419 )
Change subject: hosts: update coverity-slaves
......................................................................
hosts: update coverity-slaves
Remove the deb9 lxcs as they are being retired, and add two deb11 lxcs.
Coverity is quite big with 1.2 GiB, so deploying and upgrading this
takes some time. Having it on two hosts should be enough.
Related: OS#5793
Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0
---
M ansible/hosts
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/19/30419/1
diff --git a/ansible/hosts b/ansible/hosts
index e1756be..cc19dfe 100644
--- a/ansible/hosts
+++ b/ansible/hosts
@@ -3,9 +3,8 @@
osmo-gsm-tester-prod ansible_host=10.9.25.107
[coverity-slaves]
-admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300
-build2-deb9build-ansible ansible_host=2a01:4f8:10b:2ad9::1:6
-host2-deb9build-ansible ansible_host=2a01:4f8:120:8470::1:3
+build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13
+build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3
[jenkins-slaves]
admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 osmocom_jenkins_slave_fstrim=True
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30419
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0
Gerrit-Change-Number: 30419
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-ci[master]: ansible: coverity: update version to 22.06
by osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30417 )
Change subject: ansible: coverity: update version to 22.06
......................................................................
ansible: coverity: update version to 22.06
Coverity doesn't make the old version available for download and will
probably deprecate the previous version at some point. I'm about to
install it on new hosts, so upgrade to the latest version while at it.
Related: OS#5793
Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4
---
M ansible/roles/install-coverity/defaults/main.yml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/17/30417/1
diff --git a/ansible/roles/install-coverity/defaults/main.yml b/ansible/roles/install-coverity/defaults/main.yml
index d7a8082..4a74887 100644
--- a/ansible/roles/install-coverity/defaults/main.yml
+++ b/ansible/roles/install-coverity/defaults/main.yml
@@ -1,4 +1,4 @@
---
-coverity_version: 2021.12.1
+coverity_version: 2022.06
coverity_installer_file: "cov-analysis-linux64-{{ coverity_version }}.tar.gz"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30417
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4
Gerrit-Change-Number: 30417
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-ci[master]: ansible/coverity: extract into subdirectory
by osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30418 )
Change subject: ansible/coverity: extract into subdirectory
......................................................................
ansible/coverity: extract into subdirectory
The tarball provided by coverity doesn't have the same version in the
name as in the directory inside the tarball.
Tarball:
cov-analysis-linux64-2022.06.tar.gz
Directory:
cov-analysis-linux64-2022.6.0
Work around this by extracting it into a subdirectory and using glob to
match the directory name.
Related: OS#5793
Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b
---
M ansible/roles/install-coverity/tasks/main.yml
1 file changed, 7 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/18/30418/1
diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml
index 5baf6f3..4047fb8 100644
--- a/ansible/roles/install-coverity/tasks/main.yml
+++ b/ansible/roles/install-coverity/tasks/main.yml
@@ -13,9 +13,9 @@
ignore_errors: yes
tags: [coverity]
-- name: create /opt/coverity
+- name: create /opt/coverity/{{ coverity_version }}/
file:
- path: /opt/coverity/
+ path: /opt/coverity/{{ coverity_version }}/
state: directory
when: coverity_copy.failed == False
tags: [coverity]
@@ -23,16 +23,15 @@
- name: unpack coverity
unarchive:
src: "/tmp/{{ coverity_installer_file }}"
- dest: /opt/coverity/
+ dest: /opt/coverity/{{ coverity_version }}
remote_src: yes
when: coverity_copy.failed == False
tags: [coverity]
-- name: create link /opt/coverity/last
- file:
- src: /opt/coverity/cov-analysis-linux64-{{ coverity_version }}
- dest: /opt/coverity/current
- state: link
+- name: create link /opt/coverity/current
+ shell: ln -sf /opt/coverity/{{ coverity_version }}/* /opt/coverity/current
+ args:
+ warn: false
when: coverity_copy.failed == False
tags: [coverity]
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30418
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b
Gerrit-Change-Number: 30418
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: rename noisevector class -> avgvector
by pespin
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30411 )
Change subject: rename noisevector class -> avgvector
......................................................................
Patch Set 1: Verified+1 Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927
Gerrit-Change-Number: 30411
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:05:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ignore vscode dirs
by pespin
Attention is currently required from: Hoernchen.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30410 )
Change subject: ignore vscode dirs
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30410
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c
Gerrit-Change-Number: 30410
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:04:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in libosmo-pfcp[master]: bitmask to string: shorten
by pespin
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30408 )
Change subject: bitmask to string: shorten
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30408
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I38426d6381e96d4a683e46eba1bdd29c73d3f027
Gerrit-Change-Number: 30408
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:03:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in libosmo-pfcp[master]: fix coding of Network Instance IE
by pespin
Attention is currently required from: neels, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406 )
Change subject: fix coding of Network Instance IE
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/a6083bac_3c46af10
PS1, Line 13: These qualify for moving to libosmocore utils
> BTW, libosmocore already offers some APN conversion API: https://cgit.osmocom. […]
SO IIUC the code that neels proposes here is not needed since the same is already implemented in libosmocore?
File src/libosmo-pfcp/pfcp_ies_custom.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406/comment/e1f9af35_922dc52e
PS1, Line 86: static int strncpy_buf(char *buf, size_t buflen, const char *src, size_t len)
len is "srclen"?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30406
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I9d67464ef0f92b0512cfd6e48d203f8828a82a19
Gerrit-Change-Number: 30406
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 12:01:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in libosmo-pfcp[master]: pfcp coding errmsgs: drop extra newlines
by pespin
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30405 )
Change subject: pfcp coding errmsgs: drop extra newlines
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30405
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I4eea1efc9bd67676b6202e50d41974b2717a2511
Gerrit-Change-Number: 30405
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:57:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in libosmo-pfcp[master]: add osmo_pfcp_ie_outer_header_creation_to_str_*()
by pespin
Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30403 )
Change subject: add osmo_pfcp_ie_outer_header_creation_to_str_*()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30403
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: I4ad1570485c8081b82284e4e6b4de4d7eed414b0
Gerrit-Change-Number: 30403
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:57:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ms-trx support
by Jenkins Builder
Attention is currently required from: Hoernchen.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 3:
(408 comments)
File Transceiver52M/ms/bladerf_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba8b0baa_cc5224e6
PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ea5a549_5e132e96
PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1171cda_c5a690a8
PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a227c8ce_9c3eb6c4
PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d1390a7_2fd4c30b
PS3, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e01b625a_c1744783
PS3, Line 44: out << '(' << std::forward<Arg>(arg);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1feed99_d573da8b
PS3, Line 44: out << '(' << std::forward<Arg>(arg);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c994dd2f_ac76abde
PS3, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... };
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b37c0ad_3f397823
PS3, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... };
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29fcfe2c_12eb8da6
PS3, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2f9048eb_2485c549
PS3, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54d4576e_51378b22
PS3, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4bd5af4_6aaad064
PS3, Line 52: template <class R, class... Args>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5feefac5_a07a24a5
PS3, Line 52: template <class R, class... Args>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/990925f3_d997a82c
PS3, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16d85c35_d6839e2b
PS3, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line,
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55f935b3_8f1f7261
PS3, Line 56: R rval = func(std::forward<Args>(args)...);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/691bf1e1_ca297b28
PS3, Line 56: R rval = func(std::forward<Args>(args)...);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca1f471a_0123b27d
PS3, Line 57: if (rval != 0) {
suspect code indent for conditional statements (8, 26)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daf3b8ac_0cf13f09
PS3, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':'
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d3326e0_dd27a2f7
PS3, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__)
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5f6c7d9_c4fccb2b
PS3, Line 69: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec0b9219_6bb24672
PS3, Line 69: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd886d35_8e006dd9
PS3, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a1491bb_0ddfe138
PS3, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/981325ad_a475ddbc
PS3, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!");
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c68e9996_8b126a4b
PS3, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!");
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bb7e3f3_6ce98626
PS3, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!");
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75029840_7841d8d9
PS3, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!");
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c4879256_cc0d47b5
PS3, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0a917ac_0f5bbe43
PS3, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ebb64aba_7ad26910
PS3, Line 82: blade_usb_message<T> m[SZ];
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d0b57cd_c409917d
PS3, Line 82: blade_usb_message<T> m[SZ];
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b0f881f_b7366e7e
PS3, Line 83: int actual_samples_per_msg()
Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6931c674_bf35d054
PS3, Line 83: int actual_samples_per_msg()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d36167f7_d4262f3f
PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f81910fd_db9b9691
PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02d8b1ef_cdef212e
PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1041f7e_03662dc3
PS3, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ded46a75_4e8244fe
PS3, Line 87: int actual_samples_per_buffer()
Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b36b03b3_c26a3a3f
PS3, Line 87: int actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ad0f057_c673f117
PS3, Line 91: int samples_per_buffer()
Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f79c4051_50e75fd4
PS3, Line 91: int samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39abcdb8_5fded511
PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad0e3eb6_7cb9145e
PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c64d23d_e773b03f
PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9674b9e7_bd870d1d
PS3, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d544a74a_86f6e043
PS3, Line 95: int num_msgs_per_buffer()
Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0eb47131_06b66f43
PS3, Line 95: int num_msgs_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc9b7289_513d9183
PS3, Line 99: auto get_first_ts()
Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f73c6c4_67b3edc3
PS3, Line 99: auto get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a2c8415_cdd50fe3
PS3, Line 103: constexpr auto *getsampleoffset(int ofs)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4034d376_285b9bbd
PS3, Line 109: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6ee28aa_e4d2c9d3
PS3, Line 118: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7a0061f_02a27a43
PS3, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0cfba239_a4207e81
PS3, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/657a6cfd_75bb5b36
PS3, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0260057_077b235f
PS3, Line 178: static blade_otw_buffer<SZ / 512, T> x;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1beaf79_33ccdf24
PS3, Line 178: static blade_otw_buffer<SZ / 512, T> x;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f051ce8_cc48d68c
PS3, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29329646_6c8d99c0
PS3, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86ca7775_6812e59c
PS3, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc345c1a_cce44b35
PS3, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f47cc868_1895eeb1
PS3, Line 185: template <typename T> struct blade_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3214031c_d7efc070
PS3, Line 185: template <typename T> struct blade_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc44a38c_7fabb7f1
PS3, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddeb7121_f16328df
PS3, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b82b7796_04223e41
PS3, Line 202: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec08b7ae_debe9d0c
PS3, Line 223: void close_device()
Bad function definition - void close_device() should probably be void close_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bab2c6d_7f3e1e93
PS3, Line 223: void close_device()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42a65e8a_6abb3023
PS3, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24ebeb49_30800d27
PS3, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff697468_d3417e60
PS3, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual;
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e846e1e4_4c6f3a24
PS3, Line 250: std::cerr << "open failed, device missing?" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/119dc541_2c0ed57e
PS3, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d354ab4_24deabf0
PS3, Line 271: std::cerr << "unable to lock refclk!" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/117fb990_e2f8e338
PS3, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49590da0_ff770364
PS3, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0445a94c_e5911f13
PS3, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25362f18_6346e42c
PS3, Line 316: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27e770bd_aa56f365
PS3, Line 318: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42ba2f14_c63b9c44
PS3, Line 320: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e51145d_f8f36aa1
PS3, Line 323: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3610503_042fc96e
PS3, Line 325: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a6ef1a8_f4fa6aae
PS3, Line 327: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/821fa3e5_3b06513a
PS3, Line 330: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a15c78ac_1c0a22ca
PS3, Line 335: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/390992bc_1f130e0f
PS3, Line 338: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5be12e54_60191e4a
PS3, Line 340: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/923b289f_132d9225
PS3, Line 343: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba084ab9_3bf5a1c6
PS3, Line 346: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8566624f_7d22d454
PS3, Line 348: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b292305_a4471848
PS3, Line 351: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/287a7c2d_8fbb49da
PS3, Line 356: static void check_timestamp(dev_buf_t *rcd)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18bd6c62_8512d5e0
PS3, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) {
suspect code indent for conditional statements (16, 34)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4bf690c_0668cd2c
PS3, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " "
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40f4c20f_8f1f005b
PS3, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2eb06af3_1f75154c
PS3, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1249c3b9_4f577da2
PS3, Line 377: void *samples, size_t num_samples, void *user_data) -> void * {
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/640852e3_61ca29bd
PS3, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0019793b_c364da36
PS3, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6d0805d_f1234cbe
PS3, Line 397: void *samples, size_t num_samples, void *user_data) -> void * {
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37866471_03c18272
PS3, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe00b8cc_ff49cc04
PS3, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec06a734_9896ef53
PS3, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aef59f4e_da266579
PS3, Line 410: auto fn = [this] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11132b87_e1b03d57
PS3, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d4eb73e_728c0516
PS3, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ad52825_01ef6467
PS3, Line 422: auto fn = [this] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0dc16bbd_ec80111f
PS3, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba3e7025_d6cdd5ca
PS3, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbbb7d6b_bff63695
PS3, Line 435: //get empty bufer from list
'bufer' may be misspelled - perhaps 'buffer'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcb52d46_3c5b391b
PS3, Line 436: tx_buf_q_type::elem_t rcd;
labels should not be indented
File Transceiver52M/ms/ipc_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/914548e4_6cfec982
PS3, Line 38: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4e1cd58_686b327c
PS3, Line 38: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7edcf6e3_57ca4c37
PS3, Line 45: auto actual_samples_per_buffer()
Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ffceee11_6b59f90d
PS3, Line 45: auto actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66196f55_533c4cb3
PS3, Line 49: long get_first_ts()
Bad function definition - long get_first_ts() should probably be long get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd96e752_f398f0f2
PS3, Line 49: long get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bbc627c_eb69c788
PS3, Line 53: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3e506ed_0a4b3d3b
PS3, Line 58: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb0b01f3_4a4c1507
PS3, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55a1f448_6cd64b3e
PS3, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c04aeb8d_b86bb002
PS3, Line 71: template <typename T> struct ipc_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af9b8f93_8d0147be
PS3, Line 71: template <typename T> struct ipc_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26a9e62a_a7034855
PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c2e0f29c_c4582754
PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a136e69_cc4b306a
PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/deab6179_bdb67879
PS3, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f02102b9_be01c97b
PS3, Line 92: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da14af62_34ee9566
PS3, Line 99: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14cbe96b_3188668e
PS3, Line 106: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/41519892_cd3937c1
PS3, Line 111: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f2beeed_86859d26
PS3, Line 119: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/becf3c31_1654ff46
PS3, Line 127: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4f9fd20_a08996bf
PS3, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4428091_102e6d57
PS3, Line 137: void *rx_cb(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8f2d068_e240070a
PS3, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf };
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f99df907_8d85636f
PS3, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf };
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3222a247_3c7ae87a
PS3, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c59289ee_50d68ac7
PS3, Line 166: auto fn = [this, burst_handler] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/839b7491_a930c174
PS3, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31343549_a46ac0a1
PS3, Line 177: auto fn = [] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd0e1b8c_f7bd9940
PS3, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/140e10c9_0648d5b2
PS3, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f921479a_3380381b
PS3, Line 193: void signal_start()
Bad function definition - void signal_start() should probably be void signal_start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/231f3f5c_07d6310b
PS3, Line 193: void signal_start()
open brace '{' following function definitions go on the next line
File Transceiver52M/ms/itrq.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c82aec61_39991c07
PS3, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c2bb9a2_d975b158
PS3, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e74b49c_246238c0
PS3, Line 52: std::condition_variable cond_r, cond_w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c944dff1_d38376db
PS3, Line 53: std::mutex lr, lw;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60d3bb97_2eda81dc
PS3, Line 54: std::atomic_int r_flag, w_flag;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f3c8a6c_49cdfe42
PS3, Line 56: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/150cabb2_814ac186
PS3, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0)
Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87ab023b_049880b1
PS3, Line 65: ssize_t spsc_check_r()
Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5da13b7c_26e856d5
PS3, Line 65: ssize_t spsc_check_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ad57fe6_b9b2bf96
PS3, Line 67: std::unique_lock<std::mutex> lk(lr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78db5da9_355c999b
PS3, Line 67: std::unique_lock<std::mutex> lk(lr);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d31a1b3d_40323c31
PS3, Line 67: std::unique_lock<std::mutex> lk(lr);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd0492ef_5ff6b31b
PS3, Line 73: ssize_t spsc_check_w()
Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e86920b_e633b0f8
PS3, Line 73: ssize_t spsc_check_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf73cf7b_258b5d71
PS3, Line 75: std::unique_lock<std::mutex> lk(lw);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76ff7026_072913b1
PS3, Line 75: std::unique_lock<std::mutex> lk(lw);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d283347_cf89dcb4
PS3, Line 75: std::unique_lock<std::mutex> lk(lw);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11d83567_bc6dd09c
PS3, Line 81: void spsc_notify_r()
Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c4108089_44011c20
PS3, Line 81: void spsc_notify_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cd34243_60a3917b
PS3, Line 83: std::unique_lock<std::mutex> lk(lr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50a73c19_97eb9038
PS3, Line 83: std::unique_lock<std::mutex> lk(lr);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec33dd04_9c39d3ff
PS3, Line 83: std::unique_lock<std::mutex> lk(lr);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c996c184_ae7f06b4
PS3, Line 87: void spsc_notify_w()
Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b41cf42_be3ae62b
PS3, Line 87: void spsc_notify_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87e9395d_c3b97e37
PS3, Line 89: std::unique_lock<std::mutex> lk(lw);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a979ef5_5fd5f50f
PS3, Line 89: std::unique_lock<std::mutex> lk(lw);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d087f75_3e2b035c
PS3, Line 89: std::unique_lock<std::mutex> lk(lw);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5447f3b_c40efb11
PS3, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/909805c3_cb26d06d
PS3, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74f817d1_965b9057
PS3, Line 99: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/69d429f5_aef5217a
PS3, Line 100: explicit spsc_efd_detail()
Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ededf509_8ad31777
PS3, Line 111: ssize_t spsc_check_r()
Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/291b5beb_f3ce3c4e
PS3, Line 111: ssize_t spsc_check_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7325abb_14a22683
PS3, Line 116: ssize_t spsc_check_w()
Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3a1dcc9_962c42e2
PS3, Line 116: ssize_t spsc_check_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/12b28d8c_4e8238ee
PS3, Line 121: void spsc_notify_r()
Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99b1025f_2ad1e918
PS3, Line 121: void spsc_notify_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e97e714a_073182e0
PS3, Line 126: void spsc_notify_w()
Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05d71af1_0f79790b
PS3, Line 126: void spsc_notify_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c0c25c1_5716bb37
PS3, Line 131: int get_r_efd()
Bad function definition - int get_r_efd() should probably be int get_r_efd(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd03e987_e49774e9
PS3, Line 131: int get_r_efd()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72424a9e_31ec39fd
PS3, Line 135: int get_w_efd()
Bad function definition - int get_w_efd() should probably be int get_w_efd(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/872613ad_69e513c8
PS3, Line 135: int get_w_efd()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cc4aaf2_1d95ff34
PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bde04339_af3c4eae
PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95ee10a7_7f669cc1
PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1e068dbf_9f4f59df
PS3, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c0b58272_93487ec3
PS3, Line 142: class spsc : public T<block_read, block_write> {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f115708_44edfe3c
PS3, Line 142: class spsc : public T<block_read, block_write> {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0b1e36a_d7234f23
PS3, Line 144: std::atomic<unsigned int> readptr;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ca3d48f_52ccd40b
PS3, Line 144: std::atomic<unsigned int> readptr;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/befa5b65_10b9e525
PS3, Line 144: std::atomic<unsigned int> readptr;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d53fa5fb_5ae9c976
PS3, Line 145: std::atomic<unsigned int> writeptr;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e17028e_5093dd33
PS3, Line 145: std::atomic<unsigned int> writeptr;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b144b74_b26dcd8c
PS3, Line 145: std::atomic<unsigned int> writeptr;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cbe724ea_51cb83c5
PS3, Line 149: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/88740775_d51ad6f3
PS3, Line 150: using base_t = T<block_read, block_write>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/122ee559_75d81dc3
PS3, Line 150: using base_t = T<block_read, block_write>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf8199de_635cc276
PS3, Line 152: explicit spsc() : readptr(0), writeptr(0)
Bad function definition - explicit spsc() should probably be explicit spsc(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d750a72a_e552cb37
PS3, Line 163: bool spsc_push(const ELEM *elem)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d4403e7_44baed4e
PS3, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b1eeda1c_9766fcc4
PS3, Line 176: base_t::spsc_notify_r(); /* fine after release */
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d497c6e_04e82351
PS3, Line 183: bool spsc_pop(ELEM *elem)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d3a33b7_d038e2d9
PS3, Line 195: base_t::spsc_notify_w();
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/016e3712_a9710798
PS3, Line 202: ssize_t spsc_prep_pop()
Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bb90ecc_3d5ee3cb
PS3, Line 202: ssize_t spsc_prep_pop()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e62776c7_99781c02
PS3, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/91490d62_ca30fa0a
PS3, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3729b56a_cda98f39
PS3, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {};
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/630dc86d_23edd8d6
PS3, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {};
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/901693b1_ed64a3a1
PS3, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59c30d55_22caf92b
PS3, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d0076a18_57aa73d3
PS3, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
adding a line without newline at end of file
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a5f23dae_187a71de
PS3, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3b74d98_0b7de752
PS3, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
spaces required around that '>' (ctx:VxW)
File Transceiver52M/ms/logging.cpp:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/292183b6_e8f5f6ad
PS3, Line 83: .enabled = 0,
trailing whitespace
File Transceiver52M/ms/ms.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/def84da7_5f05856e
PS3, Line 34: #define BASET blade_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/974f1c41_d35cc072
PS3, Line 34: #define BASET blade_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f59ab076_431b6db1
PS3, Line 37: #define BASET uhd_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35ead75f_37b48e3b
PS3, Line 37: #define BASET uhd_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f70a63c3_5c396af4
PS3, Line 40: #define BASET ipc_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1ef85f0_ebcda613
PS3, Line 40: #define BASET ipc_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/881a1726_0a2d9da3
PS3, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ccdd3bcd_642b4295
PS3, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bed1ad5_af09eb8f
PS3, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8e6dd14c_27cd1583
PS3, Line 60: template <typename DST_T, typename SRC_T, typename ST>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/522d36dd_c053b192
PS3, Line 60: template <typename DST_T, typename SRC_T, typename ST>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5378f472_67925f82
PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ca8ce5a_58a5e74e
PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a148bfa6_02c2b616
PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea11c0ca_92ba2446
PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b2d6da55_95291b70
PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ee1edf5_346bc3ad
PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/203596a9_442c5ed1
PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd25bb29_378ff782
PS3, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78f02691_f82ed62c
PS3, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fbca279d_e7f89242
PS3, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/becc925c_5a0c8ba6
PS3, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c88d7811_dd9ef5dc
PS3, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b91cf46_5ad22f46
PS3, Line 75: GSM::Time gsmts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddc2b7bf_61038c45
PS3, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03b32806_ddc649f4
PS3, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bfb83da9_60bc59f7
PS3, Line 87: std::ostream null_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f49cebff_7cb2fc14
PS3, Line 89: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ae44a51_3d3d520e
PS3, Line 90: dummylog() : null_stream(this){};
space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef0d20c2_8e1f2044
PS3, Line 92: std::ostream &operator()()
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a1a031d2_e6e3dde4
PS3, Line 92: std::ostream &operator()()
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/98104e1c_59eab598
PS3, Line 104: GSM::Time global_time_keeper;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92d58ab7_d385fbd8
PS3, Line 106: std::mutex m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e56a1a3_f1cd1eba
PS3, Line 108: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b4aaa0b_ac8daee6
PS3, Line 113: void set(GSM::Time t, int64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9fd2791f_a0138377
PS3, Line 115: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7ef1500_9f3403a3
PS3, Line 115: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/479a4e99_77e14e32
PS3, Line 115: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/415a31af_399b900b
PS3, Line 119: void inc_both()
Bad function definition - void inc_both() should probably be void inc_both(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b29dbcbc_37d4f1f9
PS3, Line 119: void inc_both()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a9b6cba7_cb624fbd
PS3, Line 121: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eee747c1_88976980
PS3, Line 121: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/73363a15_79b99341
PS3, Line 121: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6019d3cd_11daceec
PS3, Line 125: void inc_and_update(int64_t new_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35a1a464_83151c80
PS3, Line 127: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71d1029a_de5380f3
PS3, Line 127: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a84c970_01dc5e05
PS3, Line 127: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0b9b8900_ab1a2a75
PS3, Line 132: void inc_and_update_safe(int64_t new_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c331074_6f3ecf89
PS3, Line 134: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fba5ebc_35ed12c9
PS3, Line 134: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/751517b4_e093f141
PS3, Line 134: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/413dc058_14c3beae
PS3, Line 142: void dec_by_one()
Bad function definition - void dec_by_one() should probably be void dec_by_one(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/100a0551_6d50d4b9
PS3, Line 142: void dec_by_one()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df41448a_193b2d68
PS3, Line 144: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/be070ad4_c1ecb94d
PS3, Line 144: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61f41ecf_c11a9d17
PS3, Line 144: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e2635164_bde694bd
PS3, Line 148: auto get_ts()
Bad function definition - auto get_ts() should probably be auto get_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31cee22a_797e5ae5
PS3, Line 148: auto get_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8936b739_40ece684
PS3, Line 150: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba220657_76f5dde9
PS3, Line 150: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37ca4dd4_7c46c952
PS3, Line 150: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0173f6f8_c6d1f491
PS3, Line 153: auto gsmtime()
Bad function definition - auto gsmtime() should probably be auto gsmtime(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c98ae15b_8b16b147
PS3, Line 153: auto gsmtime()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e963e5dc_f60732e2
PS3, Line 155: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a4e12f8_598a047c
PS3, Line 155: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f0f83fc_285cb21d
PS3, Line 155: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/757d5cfb_f6e29b94
PS3, Line 158: void get_both(GSM::Time *t, int64_t *ts)
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6faf43fa_90157638
PS3, Line 158: void get_both(GSM::Time *t, int64_t *ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/220b2e39_292584d5
PS3, Line 160: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4dd9f888_7282f6c1
PS3, Line 160: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68b93fbf_ec0f1a24
PS3, Line 160: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6763e05_0932e1c0
PS3, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28c5d133_674e839c
PS3, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78c518fd_63734e76
PS3, Line 176: std::thread rx_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1957d217_f0afc88c
PS3, Line 177: std::thread tx_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83e7ffc5_027f9875
PS3, Line 178: std::thread *calcrval_task;
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee9850b8_f7ba7d51
PS3, Line 178: std::thread *calcrval_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/880df032_6e41dbb1
PS3, Line 189: std::atomic<bool> rcv_done;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/503e01bb_4de997be
PS3, Line 189: std::atomic<bool> rcv_done;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f047c94b_30cf9ae1
PS3, Line 189: std::atomic<bool> rcv_done;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce18034b_82b910b6
PS3, Line 190: std::atomic<bool> sch_thread_done;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9da56b4_7cc36a77
PS3, Line 190: std::atomic<bool> sch_thread_done;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bbb3661d_64439466
PS3, Line 190: std::atomic<bool> sch_thread_done;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8189c25_9a7de424
PS3, Line 197: void start();
Bad function definition - void start() should probably be void start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/98f0fcc5_ec3c0fdf
PS3, Line 198: std::atomic<bool> upper_is_ready;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9767233_824d76f2
PS3, Line 198: std::atomic<bool> upper_is_ready;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50b3cb49_2fe63ddb
PS3, Line 198: std::atomic<bool> upper_is_ready;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/057d4741_38cd68a6
PS3, Line 201: bool handle_sch_or_nb();
Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6fa91560_d5392a55
PS3, Line 207: int init_device();
Bad function definition - int init_device() should probably be int init_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c31b0de_6d6cdee6
PS3, Line 208: int init_dev_and_streams();
Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34c1c93c_72d737ab
PS3, Line 209: void stop_threads();
Bad function definition - void stop_threads() should probably be void stop_threads(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80c2182a_00cf7053
PS3, Line 211: void *tx_cb();
Bad function definition - void *tx_cb() should probably be void *tx_cb(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/819f9785_68de1ebb
PS3, Line 212: void maybe_update_gain(one_burst &brst);
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a4c4c7f_a02d11bb
PS3, Line 225: bh_fn_t rx_bh();
Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a0729f2_13db89e0
PS3, Line 226: bh_fn_t tx_bh();
Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/835e6a73_7a248542
PS3, Line 229: void set_ta(int val)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66a6ab17_23a8770f
PS3, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f4af43cd_7d4f91c2
PS3, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype,
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/adab125f_be6623f8
PS3, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32e33cdb_cfccdb54
PS3, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno);
labels should not be indented
File Transceiver52M/ms/ms_rx_burst.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f140d94_984a9526
PS3, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale);
adding a line without newline at end of file
File Transceiver52M/ms/ms_upper.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3740eb6_24ce1e63
PS3, Line 44: bool driveControl();
Bad function definition - bool driveControl() should probably be bool driveControl(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb2822ee_9538b166
PS3, Line 45: void driveReceiveFIFO();
Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d477f08f_64ac9533
PS3, Line 46: void driveTx();
Bad function definition - void driveTx() should probably be void driveTx(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b3b2180_4e57e97d
PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76ab6e59_15abdc8c
PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f808a82_9c774059
PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21d4ef33_2b28d9ae
PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
function definition argument 'int' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34d1d772_ade734de
PS3, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
function definition argument 'int' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9fb048a_568f398d
PS3, Line 50: std::thread thr_control, thr_rx, thr_tx;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b208705b_6d8d8dc5
PS3, Line 52: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f67c2fd_bcae3013
PS3, Line 53: void start_threads();
Bad function definition - void start_threads() should probably be void start_threads(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28faa287_c4bb8ef2
PS3, Line 54: void start_lower_ms();
Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8b9766e_e2536a58
PS3, Line 56: upper_trx(){};
space required before the open brace '{'
File Transceiver52M/ms/sch.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21b7825c_88b2206f
PS3, Line 130: int gsm_fcch_check_ts(int ts, int fn) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c4cf00c0_373b7d93
PS3, Line 134: int gsm_sch_check_ts(int ts, int fn) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/668f8388_fb4863d8
PS3, Line 205: #if 1
Consider removing the #if 1 and its #endif
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ea69fe2_12e201d4
PS3, Line 210: float a, b, c, d, ang, avg = 0.0f;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f86444f4_f3f92a2e
PS3, Line 235: ang = b - a;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1cb901d8_451f40da
PS3, Line 237: if (ang > M_PI)
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b9622ad_cfd6f7f0
PS3, Line 238: ang -= 2 * M_PI;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96c5b166_22212a38
PS3, Line 239: else if (ang < -M_PI)
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbd5e655_538499fb
PS3, Line 240: ang += 2 * M_PI;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e61359f3_209372ee
PS3, Line 242: avg += ang;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fec44201_f9c122ba
PS3, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b76eab7f_f9434c11
PS3, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ff3e00c_d85118c0
PS3, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c98a68c6_05f3ece8
PS3, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/052a04cc_a7cde47f
PS3, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d38a68dc_b2ee1b0e
PS3, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35976b64_6d39afcd
PS3, Line 314: static __attribute__((constructor)) void init()
Bad function definition - void init() should probably be void init(void)
File Transceiver52M/ms/uhd_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/88b0cf87_62584e99
PS3, Line 35: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bcb6f7f5_6b24c3a6
PS3, Line 35: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c52a074_943ac956
PS3, Line 41: uhd::rx_metadata_t *md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b6dfc13_75069efd
PS3, Line 43: auto actual_samples_per_buffer()
Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/318d8ee7_5a74b8ca
PS3, Line 43: auto actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7c70d1e4_dce6868c
PS3, Line 47: long get_first_ts()
Bad function definition - long get_first_ts() should probably be long get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d03a74a_9fccc848
PS3, Line 47: long get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c57063f9_79333734
PS3, Line 51: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19a67292_7243580b
PS3, Line 56: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f1695fc_000bb28c
PS3, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8a27374_40c31769
PS3, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f7486b23_42b54dbe
PS3, Line 69: template <typename T> struct uhd_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f66f54a1_e47caa1e
PS3, Line 69: template <typename T> struct uhd_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36edfbd0_996103fa
PS3, Line 70: uhd::usrp::multi_usrp::sptr dev;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60d5f432_b6706ee7
PS3, Line 71: uhd::rx_streamer::sptr rx_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff8ba3a9_87a4d4e4
PS3, Line 72: uhd::tx_streamer::sptr tx_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06f46b9b_f5c791c4
PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76f956cb_4536441d
PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/847fff0d_ddab50e9
PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71310bcc_3b397a9e
PS3, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26bb493f_919cafc9
PS3, Line 90: void close_device()
Bad function definition - void close_device() should probably be void close_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58d07258_13d09f46
PS3, Line 90: void close_device()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/40901927_d80296a6
PS3, Line 95: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31a4d114_f4da6b00
PS3, Line 102: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3e18785_6bab3abd
PS3, Line 109: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0adc7b29_8921f047
PS3, Line 114: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19be2193_a29cc58d
PS3, Line 122: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e53d965_7515a6d3
PS3, Line 130: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55dc7dce_0048da9f
PS3, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/249bc39a_8c59dc3d
PS3, Line 145: std::string args = {};
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b6a97b95_fe46214b
PS3, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86cde646_62b5aaef
PS3, Line 153: uhd::tune_request_t tune_request(freq, 0);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72dc2a0d_d005d898
PS3, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms));
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9deb4645_4b368ac8
PS3, Line 164: uhd::stream_args_t stream_args("sc16", "sc16");
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c97274e_a9933aa4
PS3, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16");
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d1edce7_07c3abcc
PS3, Line 177: void *rx_cb(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7916fb56_3f968e8b
PS3, Line 182: uhd::rx_metadata_t md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d796734_289225cc
PS3, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bd6a3e4_4ec7755f
PS3, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e52c55be_c3a46247
PS3, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror());
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7222a21d_a1f0578c
PS3, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/398ab124_d6b5fed7
PS3, Line 211: auto fn = [this, burst_handler] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6a27e87_aa3eb4c3
PS3, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b68f1cfe_698ba958
PS3, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7066c193_84905e34
PS3, Line 227: auto fn = [] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d56dca20_6c37339d
PS3, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71fafa62_5d1064bc
PS3, Line 234: uhd::tx_metadata_t m = {};
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4cfc7dbd_76814509
PS3, Line 239: std::vector<void *> ptrs(1, buffer);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df19065b_07710025
PS3, Line 239: std::vector<void *> ptrs(1, buffer);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/399f02af_cc39508d
PS3, Line 239: std::vector<void *> ptrs(1, buffer);
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3ccccf9_9d527358
PS3, Line 239: std::vector<void *> ptrs(1, buffer);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d71ce1b_4cfd38d4
PS3, Line 243: uhd::async_metadata_t async_md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3eb52d04_53904dcd
PS3, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1512):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6b75c43_b3568ea6
PS3, Line 251: };
adding a line without newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:38:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: vita demod by piotr krysik, modified
by Jenkins Builder
Attention is currently required from: Hoernchen.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 )
Change subject: vita demod by piotr krysik, modified
......................................................................
Patch Set 2:
(946 comments)
File Transceiver52M/grgsm_vitac/constants.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/322593ec_5d0b0394
PS2, Line 1: #pragma once
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a308c129_5d92b397
PS2, Line 2: /* -*- c++ -*- */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bbc8cd5_23ec81e2
PS2, Line 3: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/575a4d11_5efb79c2
PS2, Line 4: * @file
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a8219c7d_b5f75f17
PS2, Line 5: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed6cf8f1_702d41be
PS2, Line 6: * @section LICENSE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86d77e8d_e34430ea
PS2, Line 7: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d87d35f0_52a3e43e
PS2, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58a14e4d_2fb1fb62
PS2, Line 9: * it under the terms of the GNU General Public License as published by
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8843a62_5be6c06b
PS2, Line 10: * the Free Software Foundation; either version 3, or (at your option)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b26ed69_aaca3b79
PS2, Line 11: * any later version.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45108c59_f367bb37
PS2, Line 12: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b2071c1_4ebb6428
PS2, Line 13: * Gr-gsm is distributed in the hope that it will be useful,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ab066d9_f4906bca
PS2, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b5ddcfc2_a2595bca
PS2, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/def879b2_99e419a4
PS2, Line 16: * GNU General Public License for more details.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e40cce53_52832359
PS2, Line 17: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ddfa9e2c_86a8a83b
PS2, Line 18: * You should have received a copy of the GNU General Public License
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78209566_d5c61897
PS2, Line 19: * along with gr-gsm; see the file COPYING. If not, write to
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/081c94b9_825c722e
PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/720dcaa6_acb9f0aa
PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99640bc0_5f6a7ce8
PS2, Line 21: * Boston, MA 02110-1301, USA.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0486f24_49687faf
PS2, Line 22: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1f57d1b_f42a543a
PS2, Line 23:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/638129c5_5771f2ee
PS2, Line 24: #include <complex>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0d7d6e8c_a2e35649
PS2, Line 25:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af5dfd65_e784f012
PS2, Line 26: #define gr_complex std::complex<float>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2080a61_001edee8
PS2, Line 26: #define gr_complex std::complex<float>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f43562eb_fe15cb31
PS2, Line 26: #define gr_complex std::complex<float>
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f338741_3324c942
PS2, Line 27:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0f17738_ae4cec7a
PS2, Line 28:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/def350ee_9f58fb4f
PS2, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f77ec7b6_c57ef9f9
PS2, Line 30: #define GSM_SYMBOL_PERIOD (1.0/GSM_SYMBOL_RATE) //seconds per symbol
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/997e7902_5e4382d1
PS2, Line 31:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c060efeb_a80d07fa
PS2, Line 32: //Burst timing
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/012113f5_7368a011
PS2, Line 33: #define TAIL_BITS 3
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a17334b_03db13bc
PS2, Line 34: #define GUARD_BITS 8
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6cc4fcc7_ff6d0089
PS2, Line 35: #define GUARD_FRACTIONAL 0.25 //fractional part of guard period
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbf75f4c_06f67817
PS2, Line 36: #define GUARD_PERIOD GUARD_BITS + GUARD_FRACTIONAL
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b13d0b7a_438da698
PS2, Line 37: #define DATA_BITS 57 //size of 1 data block in normal burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40c0a781_58af3954
PS2, Line 38: #define STEALING_BIT 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1dcd4e95_049efd35
PS2, Line 39: #define N_TRAIN_BITS 26
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9c7ed3a_0cc4305e
PS2, Line 40: #define N_SYNC_BITS 64
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3986ffe_6fa59174
PS2, Line 41: #define USEFUL_BITS 142 //(2*(DATA_BITS+STEALING_BIT) + N_TRAIN_BITS )
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bfbfaba_b284e4a0
PS2, Line 42: #define FCCH_BITS USEFUL_BITS
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0242fe0d_64af96dd
PS2, Line 43: #define BURST_SIZE (USEFUL_BITS+2*TAIL_BITS)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf50e4bc_611d164f
PS2, Line 44: #define ACCESS_BURST_SIZE 88
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e67b47ac_47799c75
PS2, Line 45: #define PROCESSED_CHUNK BURST_SIZE+2*GUARD_PERIOD
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64652455_042f0478
PS2, Line 46:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4aabdd2f_e761d50e
PS2, Line 47: #define SCH_DATA_LEN 39
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6f58f98b_97de7a24
PS2, Line 48: #define TS_BITS (TAIL_BITS+USEFUL_BITS+TAIL_BITS+GUARD_BITS) //a full TS (156 bits)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acdd1930_c3f17d6b
PS2, Line 49: #define TS_PER_FRAME 8
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6757fb6b_7f13a20f
PS2, Line 50: #define FRAME_BITS (TS_PER_FRAME * TS_BITS + 2) // 156.25 * 8
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0684b360_d8ffc025
PS2, Line 51: #define FCCH_POS TAIL_BITS
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d4626d2_43144fa8
PS2, Line 52: #define SYNC_POS (TAIL_BITS + 39)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c2b505d_8123f694
PS2, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2a046dd_d2fcf6c9
PS2, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f44a9b8c_48595216
PS2, Line 54: //aren't used for channel impulse response estimation
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d21ae8f6_6fdaad3f
PS2, Line 55: #define TRAIN_BEGINNING 5
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21048e80_cb3ca857
PS2, Line 56: #define SAFETY_MARGIN 6 //
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e743e96d_67226310
PS2, Line 57:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9ddb925_a4694223
PS2, Line 58: #define FCCH_HITS_NEEDED (USEFUL_BITS - 4)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84eb07b8_aac18bd0
PS2, Line 59: #define FCCH_MAX_MISSES 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed999ca5_bde67488
PS2, Line 60: #define FCCH_MAX_FREQ_OFFSET 100
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f409e1b_0cc38011
PS2, Line 61:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a674add_6a227c65
PS2, Line 62: #define CHAN_IMP_RESP_LENGTH 5
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d8df6e2_91fd05f5
PS2, Line 63:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/065c16b7_432ec99b
PS2, Line 64: #define MAX_SCH_ERRORS 10 //maximum number of subsequent sch errors after which gsm receiver goes to find_next_fcch state
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a98bb8db_bd6e8188
PS2, Line 65:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3479e1b_e57fc750
PS2, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ba0f07a_38147b64
PS2, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type;
do not add new typedefs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5fddbfb4_d5677f1e
PS2, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ded9505_33bff5cf
PS2, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type;
do not add new typedefs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7c09303_5e985860
PS2, Line 68:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51e1ca82_3a633586
PS2, Line 69: static const unsigned char SYNC_BITS[] = {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db6f3c49_776a543a
PS2, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66083918_35310a18
PS2, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f85e5d76_7ffb21bb
PS2, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d5027d61_172e1b0c
PS2, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1207d769_85250e8f
PS2, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4843d77_74c593f6
PS2, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/491fcd8c_e760c342
PS2, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83958ae3_eb62a06d
PS2, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acdedb7c_08f3ab05
PS2, Line 74: };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c50a83c_95019385
PS2, Line 75:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a61c84b_b6955b63
PS2, Line 76: const unsigned FCCH_FRAMES[] = { 0, 10, 20, 30, 40 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d757e3b_5fca85b1
PS2, Line 77: const unsigned SCH_FRAMES[] = { 1, 11, 21, 31, 41 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3eaa5e4e_be9ffe06
PS2, Line 78:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f0792d4_abb06f68
PS2, Line 79: const unsigned BCCH_FRAMES[] = { 2, 3, 4, 5 }; //!!the receiver shouldn't care about logical
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98568501_dc605f91
PS2, Line 80: //!!channels so this will be removed from this header
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfe9f6ac_61f614b4
PS2, Line 81: const unsigned TEST_CCH_FRAMES[] = { 2, 3, 4, 5, 6, 7, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 22, 23, 24, 25, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39, 42, 43, 44, 45, 46, 47, 48, 49 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fde6a217_fce85ffc
PS2, Line 82: const unsigned TRAFFIC_CHANNEL_F[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b872eb17_54c73021
PS2, Line 83: const unsigned TEST51[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a61794e_10b370d7
PS2, Line 84:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d28a829b_b181d1b6
PS2, Line 85:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f39b3d0_157e844f
PS2, Line 86: #define TSC0 0
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/345558f5_e890908c
PS2, Line 87: #define TSC1 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84533531_73bbf8c9
PS2, Line 88: #define TSC2 2
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9d1e2e3_72f45131
PS2, Line 89: #define TSC3 3
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68a1a8bc_53e46ec5
PS2, Line 90: #define TSC4 4
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6bda7e94_3cd2bfe6
PS2, Line 91: #define TSC5 5
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb0910a8_b0a6984b
PS2, Line 92: #define TSC6 6
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43cf1280_fdd48d40
PS2, Line 93: #define TSC7 7
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8b27f3c1_1f838c50
PS2, Line 94: #define TS_DUMMY 8
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dca0803_ef5e08e4
PS2, Line 95:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c99e8823_f5296ee9
PS2, Line 96: #define TRAIN_SEQ_NUM 9
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4ea35f8_b72c70bc
PS2, Line 97:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bba21af2_f652a489
PS2, Line 98: #define TIMESLOT0 0
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2730cb0e_467786bf
PS2, Line 99: #define TIMESLOT1 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c04f94a5_c8c980cc
PS2, Line 100: #define TIMESLOT2 2
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1930b07b_f60330b4
PS2, Line 101: #define TIMESLOT3 3
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b9c342a_39146955
PS2, Line 102: #define TIMESLOT4 4
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f488c498_72d203d6
PS2, Line 103: #define TIMESLOT5 5
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3cd1b5cb_44817048
PS2, Line 104: #define TIMESLOT6 6
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c05aca46_0678b6bd
PS2, Line 105: #define TIMESLOT7 7
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef42da19_3d38ec57
PS2, Line 106:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c909a8bf_753c7692
PS2, Line 107:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38115b5d_bfadc3b9
PS2, Line 108: static const unsigned char train_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS] = {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ed1589a_706654da
PS2, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b760cb72_a3453b3a
PS2, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a6b65e2_612332ba
PS2, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b6115b0_adcf6db6
PS2, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ee4ba3b_287880d5
PS2, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29c5fa31_7378eeee
PS2, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ecdb68e_e9808715
PS2, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf97ec50_892513b2
PS2, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e222dbd2_ed4895e3
PS2, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8eed6c35_0a973f20
PS2, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d0948cd_b292c96b
PS2, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8943596_66a67bdc
PS2, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94845f1f_b935eb0b
PS2, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/956b6c02_139b65a0
PS2, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f6bfeb6_077bedb2
PS2, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63c5991e_c4717c1f
PS2, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce099397_ca168d4c
PS2, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d754b58d_5bfefe5e
PS2, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dbf0bb64_f9756a49
PS2, Line 118: };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/961d8fc1_a73ad667
PS2, Line 119:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/873a1dba_d200f2a2
PS2, Line 120:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95422e91_3f19ddd9
PS2, Line 121: //Dummy burst 0xFB 76 0A 4E 09 10 1F 1C 5C 5C 57 4A 33 39 E9 F1 2F A8
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff27cc91_1461eb64
PS2, Line 122: static const unsigned char dummy_burst[] = {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36ae0da7_3f045cec
PS2, Line 123: 0, 0, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/879b5961_388aa647
PS2, Line 123: 0, 0, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c00797d_95358a0b
PS2, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d5a8a80_fd90a2c6
PS2, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd1075f4_5cff83c7
PS2, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2a4b97c_9e43187c
PS2, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/50171c05_6dfab3d7
PS2, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c228bba_d8c3de76
PS2, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e8565c2_b02b997e
PS2, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1abfca62_583e30bb
PS2, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f442f03_51370aaa
PS2, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f03dc313_a5abec04
PS2, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/878402f0_fc229acf
PS2, Line 129: 0, 1, 1, 1, 1, 1, 0, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64455f0d_f8d255f9
PS2, Line 129: 0, 1, 1, 1, 1, 1, 0, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54a92586_a70991bc
PS2, Line 130:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ac60ebf2_8f0b8a95
PS2, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4ca4dc4_2a760388
PS2, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f295ce7e_53f42c77
PS2, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acea8625_ff46834b
PS2, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ce66951_c77ad155
PS2, Line 133: 0, 0, 0, 1, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17b97556_dae5b8b5
PS2, Line 133: 0, 0, 0, 1, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7ce2887_f6a34c03
PS2, Line 134:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/799ae95a_d92052f2
PS2, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7682f2b2_eda845b8
PS2, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49fb59e3_1cc11dce
PS2, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cddcbfc_8aead84c
PS2, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e24ac8c_41919b0a
PS2, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/027f2b3b_efe46ebd
PS2, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/55446c74_26cbfe0a
PS2, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5636d416_fdad2bff
PS2, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb9e599d_ec4dd38d
PS2, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6b34e81a_71d2d737
PS2, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e2c3034_b8fe905a
PS2, Line 140: 1, 1, 1, 0, 1, 0, 1, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9751a887_aa28f31e
PS2, Line 140: 1, 1, 1, 0, 1, 0, 1, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e253f4ea_84091e9f
PS2, Line 141: 0, 0, 0
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1af75d5a_19901f7e
PS2, Line 141: 0, 0, 0
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3eb5c486_afd1501c
PS2, Line 142: };
DOS line endings
File Transceiver52M/grgsm_vitac/grgsm_vitac.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be88dbee_64f02d2d
PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/24e43cf2_ceb3fcd4
PS2, Line 38: void initvita();
Bad function definition - void initvita() should probably be void initvita(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/418b240d_0665c00e
PS2, Line 59: std::string fpath;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26d0baa1_ad7a73aa
PS2, Line 60: std::vector<gr_complex> data;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/55eda7ce_8bcea424
PS2, Line 60: std::vector<gr_complex> data;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/545882a2_b11ee329
PS2, Line 60: std::vector<gr_complex> data;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89d43193_db4a7a35
PS2, Line 62: };
adding a line without newline at end of file
File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/414f972c_a09c45fc
PS2, Line 1: /* -*- c++ -*- */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35c52c00_7eb24dcb
PS2, Line 2: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52605bb0_66d592d2
PS2, Line 3: * @file
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/024e5e3c_9984d0b3
PS2, Line 4: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/690d3124_521ebc68
PS2, Line 5: * @author Contributions by sysmocom - s.f.m.c. GmbH / Eric Wild <ewild(a)sysmocom.de>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/448b2dff_a2469425
PS2, Line 6: * @section LICENSE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e67d61e_3ef20283
PS2, Line 7: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1863108_ac01961e
PS2, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6009c345_ba1cca39
PS2, Line 9: * it under the terms of the GNU General Public License as published by
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/59fee2ad_c52e463b
PS2, Line 10: * the Free Software Foundation; either version 3, or (at your option)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b017a4dd_13384a75
PS2, Line 11: * any later version.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c6c9cc4_089e20b3
PS2, Line 12: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2823ea35_d4863a9a
PS2, Line 13: * Gr-gsm is distributed in the hope that it will be useful,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3adebc32_17d57a7f
PS2, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a36bef9b_20f8aaad
PS2, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df4c37f7_63b9c233
PS2, Line 16: * GNU General Public License for more details.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0191f2f1_854f4f01
PS2, Line 17: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29821671_858398d8
PS2, Line 18: * You should have received a copy of the GNU General Public License
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23df2001_9ee74458
PS2, Line 19: * along with gr-gsm; see the file COPYING. If not, write to
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01c8ff98_7486a545
PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc442523_c67eb68c
PS2, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bc83e8c_102f3113
PS2, Line 21: * Boston, MA 02110-1301, USA.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7cfd5f38_626a9014
PS2, Line 22: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef908324_5f149f2c
PS2, Line 23:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9411010_a055c52f
PS2, Line 24: #include "constants.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3f1d051_4578f7b6
PS2, Line 25:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/821f0200_12e5b643
PS2, Line 26: #ifdef HAVE_CONFIG_H
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0ff4242_172d6d79
PS2, Line 27: #include "config.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58560035_cc5e3d59
PS2, Line 28: #endif
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/150bf6a2_104c50c4
PS2, Line 29: #include <complex>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ddd3d058_262ce3cd
PS2, Line 30:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9af6c70a_66a569f0
PS2, Line 31:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/524c8f78_2e99b604
PS2, Line 32: #include <algorithm>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/002a5d06_9d22588b
PS2, Line 33: #include <string.h>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5074fa8_54240036
PS2, Line 34: #include <iostream>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e77d6a78_98777dea
PS2, Line 35: #include <numeric>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26596589_f455f118
PS2, Line 36: #include <vector>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/603cd00b_04f2600f
PS2, Line 37: #include <fstream>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec5624c5_57d407c3
PS2, Line 38:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f180c0c4_e484c429
PS2, Line 39: #include "viterbi_detector.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1074c4e_d0fd73cc
PS2, Line 40: #include "grgsm_vitac.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9a53d9c_3c7b3a2f
PS2, Line 41:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d3ac5e4_5a7cf572
PS2, Line 42: //signalVector mChanResp;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2624d918_ad6cfe8c
PS2, Line 43: gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a99b3e2_0ef376af
PS2, Line 44: gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0af2c1ef_589c0d40
PS2, Line 45: const int d_chan_imp_length = CHAN_IMP_RESP_LENGTH;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b442146a_1ff228f6
PS2, Line 46:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/baf47aca_0e69b0fb
PS2, Line 47: void initvita() {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/355ebfb4_f65f0257
PS2, Line 48:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69e9c682_ca1f2bde
PS2, Line 49: /**
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/413d2a0d_93253d16
PS2, Line 50: * Prepare SCH sequence bits
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/976d7fed_726c2eb3
PS2, Line 51: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa1cb3f2_643051e3
PS2, Line 52: * (TS_BITS + 2 * GUARD_PERIOD)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cd789410_9397358f
PS2, Line 53: * Burst and two guard periods
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f892b19_4955a7f6
PS2, Line 54: * (one guard period is an arbitrary overlap)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb65aa6b_caf69314
PS2, Line 55: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/256893d4_a92653d1
PS2, Line 56: gmsk_mapper(SYNC_BITS, N_SYNC_BITS,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab9e38e4_7c321b41
PS2, Line 57: d_sch_training_seq, gr_complex(0.0, -1.0));
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8521238_c8815857
PS2, Line 58: for (auto &i : d_sch_training_seq)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75af89cb_33263745
PS2, Line 59: i = conj(i);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2ed7679_97d843b0
PS2, Line 60:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2443ef48_8d388084
PS2, Line 61: /* Prepare bits of training sequences */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bd068aa_b790207f
PS2, Line 62: for (int i = 0; i < TRAIN_SEQ_NUM; i++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d1b1606_26c6851e
PS2, Line 63: /**
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3843da2c_0dfb91eb
PS2, Line 64: * If first bit of the sequence is 0
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6feeb70_7f4c46d5
PS2, Line 65: * => first symbol is 1, else -1
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c4dfff3_dd4e7af7
PS2, Line 66: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f24bf315_4a8c876e
PS2, Line 67: gr_complex startpoint = train_seq[i][0] == 0 ?
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8725c3d_b6e7ff6e
PS2, Line 68: gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95a78ea6_511f33d9
PS2, Line 69: gmsk_mapper(train_seq[i], N_TRAIN_BITS,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfbf9397_0a24484f
PS2, Line 70: d_norm_training_seq[i], startpoint);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/250c4b29_aa6aaedc
PS2, Line 71: for (auto &i : d_norm_training_seq[i])
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82677a06_557513ac
PS2, Line 72: i = conj(i);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f7f7895_9b55f42f
PS2, Line 73: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/051415d7_20610004
PS2, Line 74:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfe559c6_8789bc37
PS2, Line 75: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3bde1af7_2da0d626
PS2, Line 76:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79e752a8_fd185227
PS2, Line 77: MULTI_VER_TARGET_ATTR
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dd673a8a_6e8bf004
PS2, Line 78: void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d313d663_7219c926
PS2, Line 79: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1f3f745_b65bfb33
PS2, Line 80: std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40eada7b_3cc31d4f
PS2, Line 81: unsigned int stop_states[2] = { 4, 12 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9af80762_f7b50378
PS2, Line 82: gr_complex filtered_burst[BURST_SIZE];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea20e96e_5c23e504
PS2, Line 83: gr_complex rhh[CHAN_IMP_RESP_LENGTH];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a42490ef_6a54791c
PS2, Line 84: float output[BURST_SIZE];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d00ca77_4b00458b
PS2, Line 85: int start_state = 3;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/260bff6e_b7a71c43
PS2, Line 86:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/958667ef_6d52aad5
PS2, Line 87: // if(burst_start < 0 ||burst_start > 10)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4b1d67f_8eeb3797
PS2, Line 88: // fprintf(stderr, "bo %d\n", burst_start);
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af752f1f_acece406
PS2, Line 89:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca7f6bc7_319fff9b
PS2, Line 90: // burst_start = burst_start >= 0 ? burst_start : 0;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/182e3718_ea84b2f2
PS2, Line 91:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1b8d13ac_c133f0eb
PS2, Line 92: autocorrelation(chan_imp_resp, &rhh_temp[0], d_chan_imp_length * d_OSR);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca998df2_6e4343a8
PS2, Line 93: for (int ii = 0; ii < d_chan_imp_length; ii++)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26839e07_66b04ae6
PS2, Line 94: rhh[ii] = conj(rhh_temp[ii * d_OSR]);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64381507_7114b0f2
PS2, Line 95:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ea77aa8_d00623a6
PS2, Line 96: mafi(&input[burst_start], BURST_SIZE, chan_imp_resp,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0b5cf0f_c7928e45
PS2, Line 97: d_chan_imp_length * d_OSR, filtered_burst);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26a426db_552cba2f
PS2, Line 98:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/268a3909_4dc38c6c
PS2, Line 99: viterbi_detector(filtered_burst, BURST_SIZE, rhh,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7801c01c_952472e2
PS2, Line 100: start_state, stop_states, 2, output);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc385f87_ceb446c9
PS2, Line 101:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71453e24_91275d61
PS2, Line 102: for (int i = 0; i < BURST_SIZE; i++)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d146dcb0_55579480
PS2, Line 103: output_binary[i] = output[i] * -127; // pre flip bits!
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72b27196_f21d45e3
PS2, Line 104: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49ab04fd_3031e28f
PS2, Line 105:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63b7bfcd_00817f71
PS2, Line 106: void
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/885b8fdc_b64c28a1
PS2, Line 107: gmsk_mapper(const unsigned char* input,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e62acb2_df4037ae
PS2, Line 108: int nitems, gr_complex* gmsk_output, gr_complex start_point)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87b4d812_d65bfb3c
PS2, Line 109: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1db0f482_994b3620
PS2, Line 110: gr_complex j = gr_complex(0.0, 1.0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19e16a5f_59ecc68f
PS2, Line 111: gmsk_output[0] = start_point;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db65bd6e_2a82e56c
PS2, Line 112:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3a02c32a_49b1a089
PS2, Line 113: int previous_symbol = 2 * input[0] - 1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de45d096_9312d0ea
PS2, Line 114: int current_symbol;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/96b60472_1ec5fb14
PS2, Line 115: int encoded_symbol;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dba13ecb_43e29d3e
PS2, Line 116:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c042a34_a916a471
PS2, Line 117: for (int i = 1; i < nitems; i++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf27d404_1df990fb
PS2, Line 118: /* Change bits representation to NRZ */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df12c1d2_bb46a65e
PS2, Line 119: current_symbol = 2 * input[i] - 1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d74045a3_89aaa076
PS2, Line 120:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfb833ff_a5b6b263
PS2, Line 121: /* Differentially encode */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/282efc69_f3744197
PS2, Line 122: encoded_symbol = current_symbol * previous_symbol;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bae50c10_7eeee2ae
PS2, Line 123:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d12e015_a6f89e7e
PS2, Line 124: /* And do GMSK mapping */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e186f540_0473c6e4
PS2, Line 125: gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf9cf2f1_a5c4226a
PS2, Line 126: * gmsk_output[i - 1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67833d78_e4e7d82f
PS2, Line 127:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c1180c1_9d222749
PS2, Line 128: previous_symbol = current_symbol;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e779bf88_b73bf030
PS2, Line 129: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b24387b0_47fedb76
PS2, Line 130: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/496b92b8_7704d56e
PS2, Line 131:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57d652d2_b72d3a83
PS2, Line 132: gr_complex
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed8cf6ea_6c9c0d6c
PS2, Line 133: correlate_sequence(const gr_complex* sequence,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53e5699a_ce1b60ac
PS2, Line 134: int length, const gr_complex* input)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2831fd6f_9ff1a0c4
PS2, Line 135: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41cd000d_9a9e6784
PS2, Line 136: gr_complex result(0.0, 0.0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98e40f03_37725da1
PS2, Line 137:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4efae0de_baafa6dd
PS2, Line 138: for (int ii = 0; ii < length; ii++)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa27213f_95485964
PS2, Line 139: result += sequence[ii] * input[ii * d_OSR];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e238b207_09d18bfe
PS2, Line 140:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bed254c1_b5a1e823
PS2, Line 141: return conj(result) / gr_complex(length, 0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52a38925_c931964b
PS2, Line 142: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2f335bc_acfa7c80
PS2, Line 143:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5391e810_4a881e39
PS2, Line 144: /* Computes autocorrelation for positive arguments */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/061df6c3_f78f4d50
PS2, Line 145: inline void
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/269a6671_66eb8fab
PS2, Line 146: autocorrelation(const gr_complex* input,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e28a1767_220b7b56
PS2, Line 147: gr_complex* out, int nitems)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c86a3865_be0f9231
PS2, Line 148: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7e4821e_ea02dcb1
PS2, Line 149: for (int k = nitems - 1; k >= 0; k--) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/714af8b8_e289411d
PS2, Line 150: out[k] = gr_complex(0, 0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/861ae240_1aade934
PS2, Line 151: for (int i = k; i < nitems; i++)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48454fcd_a49a7ad8
PS2, Line 152: out[k] += input[i] * conj(input[i - k]);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8723254c_207c9f65
PS2, Line 153: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0c0b688_40320990
PS2, Line 154: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56118f00_2314cc8c
PS2, Line 155:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71bbbd1d_daa9f13a
PS2, Line 156: inline void
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/627159e4_b0b7827c
PS2, Line 157: mafi(const gr_complex* input, int nitems,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0039065_fb75f52b
PS2, Line 158: gr_complex* filter, int filter_length, gr_complex* output)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8985e34_a1e5ff55
PS2, Line 159: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e974f64_1a29f78c
PS2, Line 160: for (int n = 0; n < nitems; n++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/092740d8_6b11f2e5
PS2, Line 161: int a = n * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1acdc928_418bfebd
PS2, Line 162: output[n] = 0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/159f3d4f_655091fb
PS2, Line 163:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2413335_4bafc558
PS2, Line 164: for (int ii = 0; ii < filter_length; ii++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/833a353a_b8412f76
PS2, Line 165: if ((a + ii) >= nitems * d_OSR)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/44ed3846_f2718af5
PS2, Line 166: break;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f5cf3cb_75477e5d
PS2, Line 167:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8bbd75c4_4c72abc3
PS2, Line 168: output[n] += input[a + ii] * filter[ii];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e48d59ad_09ebf5ef
PS2, Line 169: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88364202_7a73291f
PS2, Line 170: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d40f189d_bbfd2601
PS2, Line 171: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70c39134_3906d7e2
PS2, Line 172:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c6799b08_f4531c67
PS2, Line 173: int get_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, int search_center, int search_start_pos,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/584c84ce_1be5a0eb
PS2, Line 174: int search_stop_pos, gr_complex *tseq, int tseqlen, float *corr_max)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98f5db55_bb86a733
PS2, Line 175: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eb3feaa_e1b5808f
PS2, Line 176: std::vector<gr_complex> correlation_buffer;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8140326_052e1fcb
PS2, Line 177: std::vector<float> window_energy_buffer;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8ba311ae_3eb6d8aa
PS2, Line 178: std::vector<float> power_buffer;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bff55401_940e539a
PS2, Line 179:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9b1f6fb_9fad2878
PS2, Line 180: for (int ii = search_start_pos; ii < search_stop_pos; ii++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ce3fdd2_34f4ae09
PS2, Line 181: gr_complex correlation = correlate_sequence(tseq, tseqlen, &input[ii]);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/16653094_93dc0bad
PS2, Line 182: correlation_buffer.push_back(correlation);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84249996_8e0fbb40
PS2, Line 183: power_buffer.push_back(std::pow(abs(correlation), 2));
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f912ab75_7572d0b2
PS2, Line 184: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b749561_83bddacd
PS2, Line 185:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2022f4c_b075b331
PS2, Line 186: int strongest_corr_nr = max_element(power_buffer.begin(), power_buffer.end()) - power_buffer.begin();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae9f362c_da1e75d6
PS2, Line 187:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ab35979_dad3e595
PS2, Line 188: /* Compute window energies */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce9ebad8_75e5f7ea
PS2, Line 189: auto window_energy_start_offset = strongest_corr_nr - 6 * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f47c97d_3205c122
PS2, Line 190: window_energy_start_offset = window_energy_start_offset < 0 ? 0 : window_energy_start_offset; //can end up out of range..
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4784eb3_06a0ec01
PS2, Line 191: auto window_energy_end_offset = strongest_corr_nr + 6 * d_OSR + d_chan_imp_length * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ae9c5f9_00bc90c1
PS2, Line 192: auto iter = power_buffer.begin() + window_energy_start_offset;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0045676a_4a3aa790
PS2, Line 193: auto iter_end = power_buffer.begin() + window_energy_end_offset;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b76834a_ad9bbfab
PS2, Line 194: while (iter != iter_end) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63434c2e_b6762ba6
PS2, Line 195: std::vector<float>::iterator iter_ii = iter;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41b2f892_31454b97
PS2, Line 196: bool loop_end = false;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f2b549e_4a498597
PS2, Line 197: float energy = 0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dca945f4_17ff79c3
PS2, Line 198:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6da41dd7_57194058
PS2, Line 199: int len = d_chan_imp_length * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb91881d_4866c120
PS2, Line 200: for (int ii = 0; ii < len; ii++, iter_ii++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5de69bb5_295fd0d5
PS2, Line 201: if (iter_ii == power_buffer.end()) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a556d73e_baef2e14
PS2, Line 202: loop_end = true;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c2491fe_d3915c13
PS2, Line 203: break;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8bb97e2_0ef6c3aa
PS2, Line 204: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92ad3608_c22d03bd
PS2, Line 205:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b57e47f1_3ee849e7
PS2, Line 206: energy += (*iter_ii);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54ed5296_46a5ca02
PS2, Line 207: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0bf516f_c041a695
PS2, Line 208:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8802f83_1b587d46
PS2, Line 209: if (loop_end)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e371f08b_d0f524d6
PS2, Line 210: break;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4be2b31_6782e8b3
PS2, Line 211:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94876ef2_5371db97
PS2, Line 212: window_energy_buffer.push_back(energy);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08e3cd2c_932fae36
PS2, Line 213: iter++;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4697ef3e_c91aca24
PS2, Line 214: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a68dce1e_e96e36ac
PS2, Line 215:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cb553c3_a1716b49
PS2, Line 216: /* Calculate the strongest window number */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b764f9a_0bbd1f70
PS2, Line 217: int strongest_window_nr = window_energy_start_offset +
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/777c1a1b_cfa20aeb
PS2, Line 218: max_element(window_energy_buffer.begin(), window_energy_buffer.end()) -
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f580ec67_a0caa59c
PS2, Line 219: window_energy_buffer.begin();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/496c7347_6c98f744
PS2, Line 220:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3ae57d8_1ea29abb
PS2, Line 221: // auto window_search_start = window_energy_buffer.begin() + strongest_corr_nr - 5* d_OSR;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93b12981_00245c08
PS2, Line 222: // auto window_search_end = window_energy_buffer.begin() + strongest_corr_nr + 10* d_OSR;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7892d551_89818f51
PS2, Line 223: // window_search_end = window_search_end >= window_energy_buffer.end() ? window_energy_buffer.end() : window_search_end;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a8cb1e5_75ee557a
PS2, Line 224:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab0bdebd_fc004e73
PS2, Line 225: // /* Calculate the strongest window number */
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a9fc476_4f595dd0
PS2, Line 226: // int strongest_window_nr = max_element(window_search_start, window_search_end /* - d_chan_imp_length * d_OSR*/) - window_energy_buffer.begin();
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a0a5a2d_2367151a
PS2, Line 227:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94f66c4e_2554ffe4
PS2, Line 228: // if (strongest_window_nr < 0)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76e238be_8cd51982
PS2, Line 229: // strongest_window_nr = 0;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0cf060d_03038705
PS2, Line 230:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93afa4b4_cf3d6abf
PS2, Line 231: float max_correlation = 0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3051e531_08dd04d9
PS2, Line 232: for (int ii = 0; ii < d_chan_imp_length * d_OSR; ii++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0759c57d_58ad5339
PS2, Line 233: gr_complex correlation = correlation_buffer[strongest_window_nr + ii];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d641dd4_e07c6e1a
PS2, Line 234: if (abs(correlation) > max_correlation)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f4fe5490_5bcbbf07
PS2, Line 235: max_correlation = abs(correlation);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92be661a_f0122346
PS2, Line 236: chan_imp_resp[ii] = correlation;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2494fc0_0883b8f0
PS2, Line 237: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60ca1135_a3da8f02
PS2, Line 238:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86ec2a48_6fd5f09a
PS2, Line 239: *corr_max = max_correlation;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec0b0b22_98b6c75a
PS2, Line 240:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7a33092_36cb089e
PS2, Line 241: /**
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4137c19_13a269b7
PS2, Line 242: * Compute first sample position, which corresponds
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/33b25a9f_8de20c52
PS2, Line 243: * to the first sample of the impulse response
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/582dea18_3e3391f3
PS2, Line 244: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32c129c0_84490318
PS2, Line 245: return search_start_pos + strongest_window_nr - search_center * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb6f4e09_a8c47228
PS2, Line 246: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4fc449d_402026b0
PS2, Line 247:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8af24a92_48418167
PS2, Line 248: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6ed7789_d7bfa7cb
PS2, Line 249:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9014e059_f451e92c
PS2, Line 250: 3 + 57 + 1 + 26 + 1 + 57 + 3 + 8.25
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/14620605_0226868f
PS2, Line 251:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cdce852c_c4e1f717
PS2, Line 252: search center = 3 + 57 + 1 + 5 (due to tsc 5+16+5 split)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5527936a_47d6a8b1
PS2, Line 253: this is +-5 samples around (+5 beginning) of truncated t16 tsc
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/34ecf7b4_789eb48f
PS2, Line 254:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11208750_a7712023
PS2, Line 255: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6355c88c_88ff85f3
PS2, Line 256: int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8e86cef0_bc5d0c0b
PS2, Line 257: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/865ef4c7_7e253669
PS2, Line 258: const int search_center = TRAIN_POS;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d98aa050_39d94067
PS2, Line 259: const int search_start_pos = (search_center - 5) * d_OSR + 1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69c970a0_7f14eef9
PS2, Line 260: const int search_stop_pos = (search_center + 5 + d_chan_imp_length) * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d525bdb1_2e4ae1e3
PS2, Line 261: const auto tseq = &d_norm_training_seq[bcc][TRAIN_BEGINNING];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12737bd2_9a8ff5e5
PS2, Line 262: const auto tseqlen = N_TRAIN_BITS - (2 * TRAIN_BEGINNING);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8c5efa9_6e04750a
PS2, Line 263: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/891eda51_d82b0df4
PS2, Line 264: corr_max);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19ca6a5d_8270cb7d
PS2, Line 265: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de4bee85_2a32980e
PS2, Line 266:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc1d0a1e_bcc65024
PS2, Line 267: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ebf9bab_25e8a117
PS2, Line 268:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fb8a956_9eb841d7
PS2, Line 269: 3 tail | 39 data | 64 tsc | 39 data | 3 tail | 8.25 guard
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02e25c91_dad5dff6
PS2, Line 270: start 3+39 - 10
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6973cfcb_2489cb98
PS2, Line 271: end 3+39 + SYNC_SEARCH_RANGE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0290757_9539734b
PS2, Line 272:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/abe61aa0_44f16445
PS2, Line 273: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c432bf57_9fe313c4
PS2, Line 274: int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/311bcd60_2a7404f3
PS2, Line 275: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c4dfd24_f44ee54a
PS2, Line 276: const int search_center = SYNC_POS + TRAIN_BEGINNING;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/295d39db_e64ca420
PS2, Line 277: const int search_start_pos = (search_center - 10) * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/207b95df_7f63745f
PS2, Line 278: const int search_stop_pos = (search_center + SYNC_SEARCH_RANGE) * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08d53b1e_b4f4c219
PS2, Line 279: const auto tseq = &d_sch_training_seq[TRAIN_BEGINNING];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aaf3543d_c6ef4e0d
PS2, Line 280: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2131722_3fec9b07
PS2, Line 281:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c9828a4_57916d9a
PS2, Line 282: // strongest_window_nr + chan_imp_resp_center + SYNC_POS *d_OSR - 48 * d_OSR - 2 * d_OSR + 2 ;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5de6070a_cc197920
PS2, Line 283: float corr_max;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b02f0a4d_4ba86232
PS2, Line 284: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61eae032_f2422e25
PS2, Line 285: &corr_max);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce71dc8c_ff9f2c08
PS2, Line 286: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aa73f80f_1cc9b5a4
PS2, Line 287:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b08fd195_e8d2dc83
PS2, Line 288: int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c64e395b_e11ba70f
PS2, Line 289: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6debf3a2_457b711c
PS2, Line 290: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1aaf46d9_5cd6bef0
PS2, Line 291: const int search_center = SYNC_POS + TRAIN_BEGINNING;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5546cf23_214442b2
PS2, Line 292: const int search_start_pos = 0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d53cac52_5160ddeb
PS2, Line 293: // FIXME: proper end offset
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c3200bb_33cb53c5
PS2, Line 294: const int search_stop_pos = len - (N_SYNC_BITS*8);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b0de97e_d7ceaede
PS2, Line 295: auto tseq = &d_sch_training_seq[TRAIN_BEGINNING];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d87277d6_1dfb85a0
PS2, Line 296:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af0b9752_f4498b9e
PS2, Line 297: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c70a6d2_93026856
PS2, Line 298: corr_max);
DOS line endings
File Transceiver52M/grgsm_vitac/viterbi_detector.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c623c58_c0fdf09a
PS2, Line 1: /* -*- c++ -*- */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/62e4e61c_8e99e164
PS2, Line 2: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c3fd98e_81f242d1
PS2, Line 3: * @file
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/96ee41c5_198c2259
PS2, Line 4: * @author (C) 2009 Piotr Krysik <ptrkrysik(a)gmail.com>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65306923_e37aec6f
PS2, Line 5: * @section LICENSE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc7ef19d_24846f15
PS2, Line 6: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/daf638cf_06adbd31
PS2, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1058463e_3561a26b
PS2, Line 8: * it under the terms of the GNU General Public License as published by
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41cdc45b_a8d56397
PS2, Line 9: * the Free Software Foundation; either version 3, or (at your option)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4247d286_9c9f4d1d
PS2, Line 10: * any later version.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42e691bd_028cbbe7
PS2, Line 11: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a44be30d_5e63b8f7
PS2, Line 12: * Gr-gsm is distributed in the hope that it will be useful,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da07b282_3ac20db0
PS2, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71a1f95e_469c5408
PS2, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54296cdc_ec311ac3
PS2, Line 15: * GNU General Public License for more details.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26afdaa0_3b3ba30e
PS2, Line 16: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/62d030d2_69cbd881
PS2, Line 17: * You should have received a copy of the GNU General Public License
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9726424_33b8311b
PS2, Line 18: * along with gr-gsm; see the file COPYING. If not, write to
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c312bf98_672af5bd
PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f393144_f4d26294
PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c6b51ab_6269d309
PS2, Line 20: * Boston, MA 02110-1301, USA.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f1eec0d_ac189a4d
PS2, Line 21: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/90dc07cf_1b003cb9
PS2, Line 22:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72982f62_4c5e3939
PS2, Line 23: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b32792aa_2e5acd51
PS2, Line 24: * viterbi_detector:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ec21bbd_8e19c4e9
PS2, Line 25: * This part does the detection of received sequnece.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be3ec68b_15482483
PS2, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2dcfa1c0_c12b1d27
PS2, Line 27: * At this moment it gives hard decisions on the output, but
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f41fb318_dd3e0e98
PS2, Line 28: * it was designed with soft decisions in mind.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3380678e_9969a396
PS2, Line 29: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a86421d_9df44925
PS2, Line 30: * SYNTAX: void viterbi_detector(
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ae4ee04_572057b5
PS2, Line 31: * const gr_complex * input,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3babcb2_80b89762
PS2, Line 32: * unsigned int samples_num,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/59602858_27701523
PS2, Line 33: * gr_complex * rhh,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d191940a_bd1dcde3
PS2, Line 34: * unsigned int start_state,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5081b459_c41e56eb
PS2, Line 35: * const unsigned int * stop_states,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ab9fc1e_0336a56f
PS2, Line 36: * unsigned int stops_num,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4026303c_fe3c548f
PS2, Line 37: * float * output)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f40ff196_9c38e19a
PS2, Line 38: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/238e86e9_07eb6085
PS2, Line 39: * INPUT: input: Complex received signal afted matched filtering.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0f555c1_fab23b8a
PS2, Line 40: * samples_num: Number of samples in the input table.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b6e76f5c_0df1dfb5
PS2, Line 41: * rhh: The autocorrelation of the estimated channel
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/498e2e6c_495bb13b
PS2, Line 42: * impulse response.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10094083_3c1e4ed9
PS2, Line 43: * start_state: Number of the start point. In GSM each burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3434cf36_2042d0ad
PS2, Line 44: * starts with sequence of three bits (0,0,0) which
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5dff827_a04b89ef
PS2, Line 45: * indicates start point of the algorithm.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5dc2ba9_818d54cc
PS2, Line 46: * stop_states: Table with numbers of possible stop states.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fbf3db56_9575815d
PS2, Line 47: * stops_num: Number of possible stop states
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11563be0_a398d71c
PS2, Line 48: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2fb660a6_4f3ff1e4
PS2, Line 49: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9eb8a9aa_52b777ca
PS2, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3eb6493_77d13bbe
PS2, Line 51: * -1 for logical "0" and 1 for logical "1"
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5442ea1a_4db31ec7
PS2, Line 52: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30653fc6_eea5a15a
PS2, Line 53: * SUB_FUNC: none
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e53ebee_cb8bf546
PS2, Line 54: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/745e22bf_afa178f4
PS2, Line 55: * TEST(S): Tested with real world normal burst.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f11dfb5_ee380245
PS2, Line 56: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f3554f2_6d1166f8
PS2, Line 57:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3359007f_1e8bd124
PS2, Line 58: #ifndef INCLUDED_VITERBI_DETECTOR_H
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b31f3e7_40c7f991
PS2, Line 59: #define INCLUDED_VITERBI_DETECTOR_H
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6607c979_b07f2b5e
PS2, Line 60: #include "constants.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7179b3c5_adcfa63e
PS2, Line 61:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b57c1458_0d26e29a
PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f576c6cd_efbb80e1
PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d72bc681_36d95fa0
PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc160b85_0abaff67
PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0bae58b_0ff87a04
PS2, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a9e1404_75a5ad4c
PS2, Line 63:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de93af2d_57d46b2f
PS2, Line 64: #endif /* INCLUDED_VITERBI_DETECTOR_H */
DOS line endings
File Transceiver52M/grgsm_vitac/viterbi_detector.cc:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc04ebde_021355b1
PS2, Line 1: /* -*- c++ -*- */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a431b13_eec16fe6
PS2, Line 2: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4219d9b7_e0762416
PS2, Line 3: * @file
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5636539c_c16bd9dd
PS2, Line 4: * @author (C) 2009 by Piotr Krysik <ptrkrysik(a)gmail.com>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b43e870b_1b8bc300
PS2, Line 5: * @section LICENSE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad47af75_bb369bd1
PS2, Line 6: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/302452d9_7068813c
PS2, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9faa189_631fcaa9
PS2, Line 8: * it under the terms of the GNU General Public License as published by
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/698f579e_a7e41d89
PS2, Line 9: * the Free Software Foundation; either version 3, or (at your option)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2825f863_add84186
PS2, Line 10: * any later version.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bf03c30_486be42f
PS2, Line 11: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8e8f9397_fc88951d
PS2, Line 12: * Gr-gsm is distributed in the hope that it will be useful,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d70d8d1_3b853e31
PS2, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5082c09e_fabf5a5d
PS2, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03f5ef18_afeee957
PS2, Line 15: * GNU General Public License for more details.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64b876d0_aa28dbad
PS2, Line 16: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/253fbf55_9e7e913a
PS2, Line 17: * You should have received a copy of the GNU General Public License
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc8c3b45_97a62634
PS2, Line 18: * along with gr-gsm; see the file COPYING. If not, write to
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4707db8c_640434d6
PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0048b50f_600146fc
PS2, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97b64ed7_20c46039
PS2, Line 20: * Boston, MA 02110-1301, USA.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3fd15f62_419668a7
PS2, Line 21: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6faa9390_e54fdeb0
PS2, Line 22:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7f09e61_eb32c883
PS2, Line 23: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/819830e9_77271fad
PS2, Line 24: * viterbi_detector:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f33c0a4_f9c2a63d
PS2, Line 25: * This part does the detection of received sequnece.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70ed75e5_fd56f0ce
PS2, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3b9a521_8eeb10b5
PS2, Line 27: * At this moment it gives hard decisions on the output, but
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5238d8cc_fc89be97
PS2, Line 28: * it was designed with soft decisions in mind.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a449fa2_4afe32f5
PS2, Line 29: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72f9cb76_08edd544
PS2, Line 30: * SYNTAX: void viterbi_detector(
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf53c04a_95eb0e34
PS2, Line 31: * const gr_complex * input,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b95b1ef_8a6b7fa3
PS2, Line 32: * unsigned int samples_num,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2ec3ed5_accf841a
PS2, Line 33: * gr_complex * rhh,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d816e8d1_05a19314
PS2, Line 34: * unsigned int start_state,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3ef5b49_55eef8ec
PS2, Line 35: * const unsigned int * stop_states,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/173b18a6_e8ba9a47
PS2, Line 36: * unsigned int stops_num,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4560e92f_5a51130f
PS2, Line 37: * float * output)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68e4b0ed_499c3711
PS2, Line 38: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e179d493_56a83d13
PS2, Line 39: * INPUT: input: Complex received signal afted matched filtering.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/400048fe_225efc5b
PS2, Line 40: * samples_num: Number of samples in the input table.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/33e85216_6a042029
PS2, Line 41: * rhh: The autocorrelation of the estimated channel
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2065c050_1f449b62
PS2, Line 42: * impulse response.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3dc8cbed_51c44c63
PS2, Line 43: * start_state: Number of the start point. In GSM each burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da706529_3364054b
PS2, Line 44: * starts with sequence of three bits (0,0,0) which
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef7e7360_538afd74
PS2, Line 45: * indicates start point of the algorithm.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be9af8a0_f20bdd2c
PS2, Line 46: * stop_states: Table with numbers of possible stop states.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e5974ed_19688c0d
PS2, Line 47: * stops_num: Number of possible stop states
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e981ad7_ff67e430
PS2, Line 48: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/440cb688_0f8ac430
PS2, Line 49: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7433065_91d84f39
PS2, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d10c90bc_5cda359f
PS2, Line 51: * -1 for logical "0" and 1 for logical "1"
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61a7fc74_df3dc71f
PS2, Line 52: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/674feb0f_c509ce51
PS2, Line 53: * SUB_FUNC: none
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a29e3309_51edde61
PS2, Line 54: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eca89a1_d74c8149
PS2, Line 55: * TEST(S): Tested with real world normal burst.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/22922396_79c81b7f
PS2, Line 56: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6abf775e_4c383d37
PS2, Line 57:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3cb97103_7691b881
PS2, Line 58: #include "constants.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c4694fa_31366f4b
PS2, Line 59: #include <cmath>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78b017cf_26837483
PS2, Line 60:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf72937c_7e47f63f
PS2, Line 61: #define PATHS_NUM (1 << (CHAN_IMP_RESP_LENGTH-1))
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4318937_f714b726
PS2, Line 62:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9667a00_60f1e1ac
PS2, Line 63: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74d62202_10cf182f
PS2, Line 64: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/916aa0ac_7022bb34
PS2, Line 65: float increment[8];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c72e77a_263ea8cd
PS2, Line 66: float path_metrics1[16];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ade2a744_b2967a60
PS2, Line 67: float path_metrics2[16];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2f5621f2_218a2f57
PS2, Line 68: float paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0976f82d_790cf349
PS2, Line 69: float * new_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12cbc750_aa0ede7b
PS2, Line 70: float * old_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e6e10f09_afbddd57
PS2, Line 71: float * tmp;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f2afbe1_d132b2e1
PS2, Line 72: float trans_table[BURST_SIZE][16];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a53a87a0_81007f3c
PS2, Line 73: float pm_candidate1, pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21c3c1cf_048f5163
PS2, Line 74: bool real_imag;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/949431f6_f87e28f6
PS2, Line 75: float input_symbol_real, input_symbol_imag;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4731ace7_76164040
PS2, Line 76: unsigned int i, sample_nr;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c46db8b_609c49f7
PS2, Line 77:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0ccdada_b1c7ed08
PS2, Line 78: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/950b203a_d8dd0ffe
PS2, Line 79: * Setup first path metrics, so only state pointed by start_state is possible.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e219638_8b015bcf
PS2, Line 80: * Start_state metric is equal to zero, the rest is written with some very low value,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c337127_85f31b66
PS2, Line 81: * which makes them practically impossible to occur.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/373100ff_f11a3d10
PS2, Line 82: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f930d391_bfdcbeca
PS2, Line 83: for(i=0; i<PATHS_NUM; i++){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5ec0073_10cac1f3
PS2, Line 84: path_metrics1[i]=(-10e30);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0245da7_f9792bd6
PS2, Line 85: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47dd04d1_8497190b
PS2, Line 86: path_metrics1[start_state]=0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0112194c_bd10946e
PS2, Line 87:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92cfd1fe_5463ab3b
PS2, Line 88: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf0b0f74_7e685184
PS2, Line 89: * Compute Increment - a table of values which does not change for subsequent input samples.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ebd52c2_71ee14f1
PS2, Line 90: * Increment is table of reference levels for computation of branch metrics:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d91e1a5f_be13f94b
PS2, Line 91: * branch metric = (+/-)received_sample (+/-) reference_level
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1db81eb_cce51d50
PS2, Line 92: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f2fd93_0f0cb2c6
PS2, Line 93: increment[0] = -rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6044b24_ca43e4ce
PS2, Line 94: increment[1] = rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c24cb3d6_3aea0d79
PS2, Line 95: increment[2] = -rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21537003_08aec9b4
PS2, Line 96: increment[3] = rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf830e57_881eab32
PS2, Line 97: increment[4] = -rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ceeab1b9_06399b64
PS2, Line 98: increment[5] = rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9270e46b_a749e5f5
PS2, Line 99: increment[6] = -rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d31a486_40e1b822
PS2, Line 100: increment[7] = rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23ccb7bd_f623b229
PS2, Line 101:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/885e927a_2731f854
PS2, Line 102:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efba4f87_7673f91c
PS2, Line 103: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c21fbd8a_0ab720a4
PS2, Line 104: * Computation of path metrics and decisions (Add-Compare-Select).
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ed35a0d_ffb4480b
PS2, Line 105: * It's composed of two parts: one for odd input samples (imaginary numbers)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0db49c31_065f5664
PS2, Line 106: * and one for even samples (real numbers).
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad811fd2_e0401fb1
PS2, Line 107: * Each part is composed of independent (parallelisable) statements like
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4515d5a1_d6494e00
PS2, Line 108: * this one:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6f057d3_f4035507
PS2, Line 109: * pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2];
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49fccf7f_f41ce239
PS2, Line 110: * pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5];
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c41d84f3_5f11f6f1
PS2, Line 111: * paths_difference=pm_candidate2-pm_candidate1;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88b5a4ca_6fc721a5
PS2, Line 112: * new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eb03c87_780f3a83
PS2, Line 113: * trans_table[sample_nr][1] = paths_difference;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/adbe8da2_2b59ab4d
PS2, Line 114: * This is very good point for optimisations (SIMD or OpenMP) as it's most time
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bac61b7e_d79773cc
PS2, Line 115: * consuming part of this function.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfbb3284_ac44977b
PS2, Line 116: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0fd32232_02e29f44
PS2, Line 117: sample_nr=0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ef22a13_98332cef
PS2, Line 118: old_path_metrics=path_metrics1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8115928_ac827029
PS2, Line 119: new_path_metrics=path_metrics2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e70dd00_53702bb8
PS2, Line 120: while(sample_nr<samples_num){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e6be6c1b_d9c8858a
PS2, Line 121: //Processing imag states
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/873052bb_7877e6f9
PS2, Line 122: real_imag=1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a87ab81_abf9008e
PS2, Line 123: input_symbol_imag = input[sample_nr].imag();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e2f5347e_ba57be00
PS2, Line 124:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1d93d15_e14a5c0f
PS2, Line 125: pm_candidate1 = old_path_metrics[0] +input_symbol_imag -increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/029985b5_6da858aa
PS2, Line 126: pm_candidate2 = old_path_metrics[8] +input_symbol_imag +increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05ddeca5_4cc99647
PS2, Line 127: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18fa8fa4_430cfc3e
PS2, Line 128: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0389fc2d_b1d38a6c
PS2, Line 129: trans_table[sample_nr][0] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8ed2e100_c5712e74
PS2, Line 130:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa43bfa5_1bef1ec0
PS2, Line 131: pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c410bc06_df85fec8
PS2, Line 132: pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11d2c1c0_be4d4117
PS2, Line 133: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a038a491_0eb2b56a
PS2, Line 134: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1df2f367_7db04406
PS2, Line 135: trans_table[sample_nr][1] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6b26d22_ec7a5990
PS2, Line 136:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6b844d20_f5cf3307
PS2, Line 137: pm_candidate1 = old_path_metrics[1] +input_symbol_imag -increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efafc8e6_c715772d
PS2, Line 138: pm_candidate2 = old_path_metrics[9] +input_symbol_imag +increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64a7cdbf_1646a64a
PS2, Line 139: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf16e85d_1cd1a8d2
PS2, Line 140: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc668099_63e3f026
PS2, Line 141: trans_table[sample_nr][2] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02aacb14_16f5471f
PS2, Line 142:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bce688e9_304a2fb7
PS2, Line 143: pm_candidate1 = old_path_metrics[1] -input_symbol_imag +increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2beb671_be61ec4e
PS2, Line 144: pm_candidate2 = old_path_metrics[9] -input_symbol_imag -increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ac89e4a_3238ffe1
PS2, Line 145: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1efe3799_1a8011e7
PS2, Line 146: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f94f9a5_34dd0f01
PS2, Line 147: trans_table[sample_nr][3] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff854304_d1afffb6
PS2, Line 148:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fdffc65b_21a25693
PS2, Line 149: pm_candidate1 = old_path_metrics[2] +input_symbol_imag -increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6835d625_d32a45d9
PS2, Line 150: pm_candidate2 = old_path_metrics[10] +input_symbol_imag +increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e85a381b_9a022197
PS2, Line 151: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99afc4db_48e98fa0
PS2, Line 152: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cb72145_4c978279
PS2, Line 153: trans_table[sample_nr][4] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec2dedcc_943427c4
PS2, Line 154:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1220705_55996237
PS2, Line 155: pm_candidate1 = old_path_metrics[2] -input_symbol_imag +increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e5e85ad_edf99f86
PS2, Line 156: pm_candidate2 = old_path_metrics[10] -input_symbol_imag -increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5a285f5_da5d865e
PS2, Line 157: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a58023f_5980b528
PS2, Line 158: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6151009e_ec46b8b1
PS2, Line 159: trans_table[sample_nr][5] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6bf3fcea_5e9339ef
PS2, Line 160:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebcf668b_ddaa27f5
PS2, Line 161: pm_candidate1 = old_path_metrics[3] +input_symbol_imag -increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f52903_24cc297f
PS2, Line 162: pm_candidate2 = old_path_metrics[11] +input_symbol_imag +increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/345668b4_5d192e69
PS2, Line 163: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/958874f9_e25d3931
PS2, Line 164: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b15f89e_6531789c
PS2, Line 165: trans_table[sample_nr][6] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56d0ef03_f45df79d
PS2, Line 166:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/642d74d6_9772f8b6
PS2, Line 167: pm_candidate1 = old_path_metrics[3] -input_symbol_imag +increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9504855_b2e8e3df
PS2, Line 168: pm_candidate2 = old_path_metrics[11] -input_symbol_imag -increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b25c7f6_e2432f0a
PS2, Line 169: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e529294d_4d43dc47
PS2, Line 170: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f9d5c10_f47e594e
PS2, Line 171: trans_table[sample_nr][7] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9c5fdd6_b0de5144
PS2, Line 172:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5fd9bb89_c0c1f782
PS2, Line 173: pm_candidate1 = old_path_metrics[4] +input_symbol_imag -increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b5b6fd1_1a2d1383
PS2, Line 174: pm_candidate2 = old_path_metrics[12] +input_symbol_imag +increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc04b7ef_045a9e47
PS2, Line 175: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/023767aa_72930671
PS2, Line 176: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/80d9ca01_c3c1f88f
PS2, Line 177: trans_table[sample_nr][8] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cd6f7496_8006f729
PS2, Line 178:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0541ae1_249039d3
PS2, Line 179: pm_candidate1 = old_path_metrics[4] -input_symbol_imag +increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b58c726e_22292867
PS2, Line 180: pm_candidate2 = old_path_metrics[12] -input_symbol_imag -increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a50b68f6_bdd0c431
PS2, Line 181: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42232426_cf18fdf3
PS2, Line 182: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4647c84_211baf75
PS2, Line 183: trans_table[sample_nr][9] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c111e70_c8196225
PS2, Line 184:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f66120cd_0e6cec5e
PS2, Line 185: pm_candidate1 = old_path_metrics[5] +input_symbol_imag -increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9abbff0_b2828809
PS2, Line 186: pm_candidate2 = old_path_metrics[13] +input_symbol_imag +increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfa5bc56_0a1a9d20
PS2, Line 187: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/584c82db_53342f73
PS2, Line 188: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/052f0983_f5391273
PS2, Line 189: trans_table[sample_nr][10] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3856ca77_9e6eeac7
PS2, Line 190:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9ddcc1d_6d5d6de9
PS2, Line 191: pm_candidate1 = old_path_metrics[5] -input_symbol_imag +increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32856c54_4261b11a
PS2, Line 192: pm_candidate2 = old_path_metrics[13] -input_symbol_imag -increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf89f191_98b66baf
PS2, Line 193: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2cb3a4c_03fdb1c4
PS2, Line 194: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/384e1cec_4abe3c19
PS2, Line 195: trans_table[sample_nr][11] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/832bde5f_3fa895f4
PS2, Line 196:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c71accad_7aa4f17f
PS2, Line 197: pm_candidate1 = old_path_metrics[6] +input_symbol_imag -increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/431c699a_58fde763
PS2, Line 198: pm_candidate2 = old_path_metrics[14] +input_symbol_imag +increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/008c2851_c2e3bd30
PS2, Line 199: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bde6818d_7d2bcbc5
PS2, Line 200: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4873a45_de170cab
PS2, Line 201: trans_table[sample_nr][12] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7f5b567_9e763355
PS2, Line 202:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba826ad8_977cb4fb
PS2, Line 203: pm_candidate1 = old_path_metrics[6] -input_symbol_imag +increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63e065dc_dfedeadc
PS2, Line 204: pm_candidate2 = old_path_metrics[14] -input_symbol_imag -increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13f816db_f7ec9eda
PS2, Line 205: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd973d7c_bb7f431e
PS2, Line 206: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9d5c04d_6820a079
PS2, Line 207: trans_table[sample_nr][13] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0cca0e12_54d46a36
PS2, Line 208:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/402ca9e8_d981ec51
PS2, Line 209: pm_candidate1 = old_path_metrics[7] +input_symbol_imag -increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc178b3a_135732af
PS2, Line 210: pm_candidate2 = old_path_metrics[15] +input_symbol_imag +increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0790d2c_90c81d65
PS2, Line 211: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3210f2ef_9e88e7d2
PS2, Line 212: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3a099896_b7866b7b
PS2, Line 213: trans_table[sample_nr][14] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d27cc067_cda544ab
PS2, Line 214:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95413569_b37b5680
PS2, Line 215: pm_candidate1 = old_path_metrics[7] -input_symbol_imag +increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58d15de8_7a9d1785
PS2, Line 216: pm_candidate2 = old_path_metrics[15] -input_symbol_imag -increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/90f2557d_3c4dc985
PS2, Line 217: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69b52a4a_37a500a5
PS2, Line 218: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87bc80ab_9a69f0c7
PS2, Line 219: trans_table[sample_nr][15] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/000bc266_dda2bd18
PS2, Line 220: tmp=old_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79b69ce3_8fe4e952
PS2, Line 221: old_path_metrics=new_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e6465af_83597879
PS2, Line 222: new_path_metrics=tmp;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6308b1c2_dd1d00f6
PS2, Line 223:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c41b0e9d_dfa524af
PS2, Line 224: sample_nr++;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b459f88_b8e14e0c
PS2, Line 225: if(sample_nr==samples_num)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2dca96db_50d41d85
PS2, Line 226: break;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0a258bf_9e024e07
PS2, Line 227:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a179653a_b6d6209b
PS2, Line 228: //Processing real states
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f48596e_18a54a12
PS2, Line 229: real_imag=0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d0b8d38_18081dff
PS2, Line 230: input_symbol_real = input[sample_nr].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e013d597_1d5bc2b2
PS2, Line 231:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/422ab2ce_836df58f
PS2, Line 232: pm_candidate1 = old_path_metrics[0] -input_symbol_real -increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94d46ddc_09221c27
PS2, Line 233: pm_candidate2 = old_path_metrics[8] -input_symbol_real +increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4eb3655b_5824d3ad
PS2, Line 234: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bbee17e_24615ead
PS2, Line 235: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8310ff7_b268fe45
PS2, Line 236: trans_table[sample_nr][0] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72bdb613_51f34cda
PS2, Line 237:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/adf152bb_bdc51703
PS2, Line 238: pm_candidate1 = old_path_metrics[0] +input_symbol_real +increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ffca4a6b_5a2fd9d0
PS2, Line 239: pm_candidate2 = old_path_metrics[8] +input_symbol_real -increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d27a7547_88765d61
PS2, Line 240: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebc47d61_67ff024b
PS2, Line 241: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff6b3f6f_2cc54f19
PS2, Line 242: trans_table[sample_nr][1] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0d84634_c99680ee
PS2, Line 243:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1743cfa_3cd62672
PS2, Line 244: pm_candidate1 = old_path_metrics[1] -input_symbol_real -increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26e7f107_2c30d37a
PS2, Line 245: pm_candidate2 = old_path_metrics[9] -input_symbol_real +increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de5b7134_58ea690b
PS2, Line 246: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2672c2d_1d41f8df
PS2, Line 247: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb64a506_15fcaafb
PS2, Line 248: trans_table[sample_nr][2] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/902337c9_b1d96948
PS2, Line 249:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52e1c734_5b77d082
PS2, Line 250: pm_candidate1 = old_path_metrics[1] +input_symbol_real +increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3719268c_69a3a6ab
PS2, Line 251: pm_candidate2 = old_path_metrics[9] +input_symbol_real -increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1523674_4cb730d5
PS2, Line 252: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec9c2d7b_815dde6a
PS2, Line 253: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8bea1baa_3d35353d
PS2, Line 254: trans_table[sample_nr][3] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02695e48_ec196933
PS2, Line 255:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3816ffac_b1926cc0
PS2, Line 256: pm_candidate1 = old_path_metrics[2] -input_symbol_real -increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/051002a5_12c91e62
PS2, Line 257: pm_candidate2 = old_path_metrics[10] -input_symbol_real +increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bd957a9_62dcc2f1
PS2, Line 258: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf7b5c94_a24b81d5
PS2, Line 259: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/41724c00_5eca79c8
PS2, Line 260: trans_table[sample_nr][4] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b0c90fc_ded4dd39
PS2, Line 261:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30403e4f_cc0baca1
PS2, Line 262: pm_candidate1 = old_path_metrics[2] +input_symbol_real +increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e1a9b51_bd580567
PS2, Line 263: pm_candidate2 = old_path_metrics[10] +input_symbol_real -increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42e37ced_1fa6167a
PS2, Line 264: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29e1699e_b996cb80
PS2, Line 265: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ac6212b_002a8334
PS2, Line 266: trans_table[sample_nr][5] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/891b46d8_6bad8f7d
PS2, Line 267:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc44745a_a0a3076f
PS2, Line 268: pm_candidate1 = old_path_metrics[3] -input_symbol_real -increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/407d7d21_af3f550b
PS2, Line 269: pm_candidate2 = old_path_metrics[11] -input_symbol_real +increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7de9d0c9_645887bf
PS2, Line 270: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3eee8f66_de3ad06e
PS2, Line 271: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/929247d8_8f3f60c5
PS2, Line 272: trans_table[sample_nr][6] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/935f7535_aab102ce
PS2, Line 273:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c4cdade_71d5b744
PS2, Line 274: pm_candidate1 = old_path_metrics[3] +input_symbol_real +increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e7dd481_205f5843
PS2, Line 275: pm_candidate2 = old_path_metrics[11] +input_symbol_real -increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff36c88a_607bb23e
PS2, Line 276: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67535253_561455a1
PS2, Line 277: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f26094ce_7c68b072
PS2, Line 278: trans_table[sample_nr][7] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ec1a6e4_37049d53
PS2, Line 279:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efe86f61_e1328a74
PS2, Line 280: pm_candidate1 = old_path_metrics[4] -input_symbol_real -increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30f8f786_0fed0194
PS2, Line 281: pm_candidate2 = old_path_metrics[12] -input_symbol_real +increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6167440_d6acf2e9
PS2, Line 282: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53ed12e1_1997c1f0
PS2, Line 283: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86479557_230eda83
PS2, Line 284: trans_table[sample_nr][8] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43ed253e_bee8e6f4
PS2, Line 285:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/868e1fab_3e437966
PS2, Line 286: pm_candidate1 = old_path_metrics[4] +input_symbol_real +increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f3055e2_38426aa6
PS2, Line 287: pm_candidate2 = old_path_metrics[12] +input_symbol_real -increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/160db78f_faa37840
PS2, Line 288: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12ca9f4b_2ad940a3
PS2, Line 289: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68732a27_23023b7b
PS2, Line 290: trans_table[sample_nr][9] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f80bf6a9_fde1b085
PS2, Line 291:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fa8470f_cf09cd1f
PS2, Line 292: pm_candidate1 = old_path_metrics[5] -input_symbol_real -increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5066ea20_0c370212
PS2, Line 293: pm_candidate2 = old_path_metrics[13] -input_symbol_real +increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3bd491c_a132d42d
PS2, Line 294: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93f9709a_1c5955ee
PS2, Line 295: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f1be962_5605a657
PS2, Line 296: trans_table[sample_nr][10] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea1fba33_d2a6de41
PS2, Line 297:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7977a4f4_f89c014d
PS2, Line 298: pm_candidate1 = old_path_metrics[5] +input_symbol_real +increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad334b06_82b81949
PS2, Line 299: pm_candidate2 = old_path_metrics[13] +input_symbol_real -increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/424b1f8f_6dd578b2
PS2, Line 300: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b6ba883_4b3df351
PS2, Line 301: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89805ac3_ca3b9672
PS2, Line 302: trans_table[sample_nr][11] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db8e6784_a276158f
PS2, Line 303:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f6ea85a_f0f04c68
PS2, Line 304: pm_candidate1 = old_path_metrics[6] -input_symbol_real -increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0d10a7c_0e5bc7dd
PS2, Line 305: pm_candidate2 = old_path_metrics[14] -input_symbol_real +increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a07571a5_55f5d0c3
PS2, Line 306: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bcffd453_8f706ea8
PS2, Line 307: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2264f1b9_ac92c0f2
PS2, Line 308: trans_table[sample_nr][12] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2bd8be14_6e9d0a9e
PS2, Line 309:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21f34d2b_f0c05478
PS2, Line 310: pm_candidate1 = old_path_metrics[6] +input_symbol_real +increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cd4b69f7_f9e71ef2
PS2, Line 311: pm_candidate2 = old_path_metrics[14] +input_symbol_real -increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97b2cf3b_032ceec4
PS2, Line 312: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f7660db_ecae6c32
PS2, Line 313: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e1cec17_c647d4ca
PS2, Line 314: trans_table[sample_nr][13] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/293c4368_e2478eb2
PS2, Line 315:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d0ffbb9c_ae321365
PS2, Line 316: pm_candidate1 = old_path_metrics[7] -input_symbol_real -increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/996edd06_3a152812
PS2, Line 317: pm_candidate2 = old_path_metrics[15] -input_symbol_real +increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d50fb25b_bd46a4c6
PS2, Line 318: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8cd001c6_f81632e9
PS2, Line 319: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/690449f9_2e937c84
PS2, Line 320: trans_table[sample_nr][14] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11958998_d3745c7c
PS2, Line 321:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a340d57b_03ec149c
PS2, Line 322: pm_candidate1 = old_path_metrics[7] +input_symbol_real +increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e70d9e6_1c063e49
PS2, Line 323: pm_candidate2 = old_path_metrics[15] +input_symbol_real -increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1741b036_b9939b86
PS2, Line 324: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4abd28b_31a4acd7
PS2, Line 325: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93578efd_801dc9b4
PS2, Line 326: trans_table[sample_nr][15] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9caa6199_6f7a306c
PS2, Line 327:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dd50192_ef818950
PS2, Line 328: tmp=old_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1aa72876_dfd6e0d4
PS2, Line 329: old_path_metrics=new_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74351c9e_ae59317e
PS2, Line 330: new_path_metrics=tmp;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ef084d9_1f34fbbc
PS2, Line 331:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0e48429_fe9a4a95
PS2, Line 332: sample_nr++;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/207372f9_a3eef8df
PS2, Line 333: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf29e22e_1ba94a7a
PS2, Line 334:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/235a0004_267c78e0
PS2, Line 335: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2eae96b2_f90b55cd
PS2, Line 336: * Find the best from the stop states by comparing their path metrics.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4445792b_62709909
PS2, Line 337: * Not every stop state is always possible, so we are searching in
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7ee8ea8_12b85e24
PS2, Line 338: * a subset of them.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f24188f9_b592a6db
PS2, Line 339: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3bec72de_2287a20e
PS2, Line 340: unsigned int best_stop_state;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10f4d59d_25d24d33
PS2, Line 341: float stop_state_metric, max_stop_state_metric;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c92ba95_06ffdc57
PS2, Line 342: best_stop_state = stop_states[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f96e79d_a93f361a
PS2, Line 343: max_stop_state_metric = old_path_metrics[best_stop_state];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce538895_18ffb4ed
PS2, Line 344: for(i=1; i< stops_num; i++){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a49b47cf_8bb6401c
PS2, Line 345: stop_state_metric = old_path_metrics[stop_states[i]];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0fa6f8bb_0b459d13
PS2, Line 346: if(stop_state_metric > max_stop_state_metric){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7db4a93b_c8f066f3
PS2, Line 347: max_stop_state_metric = stop_state_metric;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4eb7f996_c8a1c40a
PS2, Line 348: best_stop_state = stop_states[i];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/31a8984b_baecd700
PS2, Line 349: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/119c92ca_da35633a
PS2, Line 350: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ca0630e_8aba8405
PS2, Line 351:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64662e52_eda4fd69
PS2, Line 352: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f8ac0a0_c769eff4
PS2, Line 353: * This table was generated with hope that it gives a litle speedup during
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d651cda3_9533d5f8
PS2, Line 354: * traceback stage.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f092de25_8e09ee1e
PS2, Line 355: * Received bit is related to the number of state in the trellis.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51c332b0_4755c715
PS2, Line 356: * I've numbered states so their parity (number of ones) is related
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/784c0511_54a67d37
PS2, Line 357: * to a received bit.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d4d08ba_c3006891
PS2, Line 358: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca702d3e_27533fb2
PS2, Line 359: static const unsigned int parity_table[PATHS_NUM] = { 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/011155be_e253073c
PS2, Line 360:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e41c12b9_b6a91ac0
PS2, Line 361: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b24edb7_b3e304c1
PS2, Line 362: * Table of previous states in the trellis diagram.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66bf3ffd_514f1885
PS2, Line 363: * For GMSK modulation every state has two previous states.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b684734e_f0143d49
PS2, Line 364: * Example:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb9c71f3_c9b52bfe
PS2, Line 365: * previous_state_nr1 = prev_table[current_state_nr][0]
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d5cde8d6_3596a3b6
PS2, Line 366: * previous_state_nr2 = prev_table[current_state_nr][1]
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a022fdd8_cac044ea
PS2, Line 367: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc469627_408067fb
PS2, Line 368: static const unsigned int prev_table[PATHS_NUM][2] = { {0,8}, {0,8}, {1,9}, {1,9}, {2,10}, {2,10}, {3,11}, {3,11}, {4,12}, {4,12}, {5,13}, {5,13}, {6,14}, {6,14}, {7,15}, {7,15}, };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68e7acd2_14bbf0de
PS2, Line 369:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0742122_ec51659b
PS2, Line 370: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af121191_d21f5098
PS2, Line 371: * Traceback and differential decoding of received sequence.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/342ce7d2_53141672
PS2, Line 372: * Decisions stored in trans_table are used to restore best path in the trellis.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58c19bcc_b7af9b7b
PS2, Line 373: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d86a2985_82aae718
PS2, Line 374: sample_nr=samples_num;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad04b727_fee3ea90
PS2, Line 375: unsigned int state_nr=best_stop_state;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6befa393_038b9c8e
PS2, Line 376: unsigned int decision;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a5330b0_66e9578d
PS2, Line 377: bool out_bit=0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27f73019_6f742e81
PS2, Line 378:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e8c31e6_845867ea
PS2, Line 379: while(sample_nr>0){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/049b4662_f2e1868e
PS2, Line 380: sample_nr--;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8508af6e_57e34af4
PS2, Line 381: decision = (trans_table[sample_nr][state_nr]>0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c251cf75_e1da3f2d
PS2, Line 382:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9abcadd9_a1a93e07
PS2, Line 383: if(decision != out_bit)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/16f86cd9_66152f86
PS2, Line 384: output[sample_nr]=-trans_table[sample_nr][state_nr];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2467bf22_49e9fbf9
PS2, Line 385: else
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e3dec2f3_39e89f36
PS2, Line 386: output[sample_nr]=trans_table[sample_nr][state_nr];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29c4e5e3_041bddc8
PS2, Line 387:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce87ba0e_170a4348
PS2, Line 388: out_bit = out_bit ^ real_imag ^ parity_table[state_nr];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a7dbab3_cf2cb96f
PS2, Line 389: state_nr = prev_table[state_nr][decision];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6da62953_37a882f5
PS2, Line 390: real_imag = !real_imag;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b88674a_a078a257
PS2, Line 391: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1511):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e54f75c2_997b5000
PS2, Line 392: }
DOS line endings
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f
Gerrit-Change-Number: 30415
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ill-fated ipcv2 for mstrx
by Jenkins Builder
Attention is currently required from: Hoernchen.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 )
Change subject: ill-fated ipcv2 for mstrx
......................................................................
Patch Set 2:
(237 comments)
File Transceiver52M/device/ipc2/IPCDevice.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5eb0c714_10ee29c1
PS2, Line 40: protected:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6651161_e98b5749
PS2, Line 41: std::vector<smpl_buf *> rx_buffers;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d1c36682_941a2da2
PS2, Line 41: std::vector<smpl_buf *> rx_buffers;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0309d99f_d325d12e
PS2, Line 41: std::vector<smpl_buf *> rx_buffers;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/181f24ff_3c81b73c
PS2, Line 41: std::vector<smpl_buf *> rx_buffers;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6390f5a_84f02b55
PS2, Line 48: std::vector<double> tx_gains, rx_gains;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/74f0c2d7_3b8f6326
PS2, Line 48: std::vector<double> tx_gains, rx_gains;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e28c3717_0e5bc19f
PS2, Line 48: std::vector<double> tx_gains, rx_gains;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/14970ee1_c6aa8d34
PS2, Line 57: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c3b16b05_6d030687
PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ebba5fff_4b269633
PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5a91daa5_9433bcd3
PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0ac42c66_8d16cffb
PS2, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/389dc8c4_9fd06a79
PS2, Line 64: virtual int open(const std::string &args, int ref, bool swap_channels) override;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/60f3b4d1_f8c4a67c
PS2, Line 67: virtual bool start() override;
Bad function definition - virtual bool start() should probably be virtual bool start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01cdc5de_098ffd82
PS2, Line 70: virtual bool stop() override;
Bad function definition - virtual bool stop() should probably be virtual bool stop(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b0e01f01_2c6b7faa
PS2, Line 73: enum TxWindowType getWindowType() override
Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d448e734_fc23cd20
PS2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/aaa757a1_87ad6be3
PS2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b512702_3e193375
PS2, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/280e3c99_4ec715d6
PS2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/313b4380_8034db45
PS2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d890133c_55ca5193
PS2, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2e1e8e0b_7910299f
PS2, Line 98: TIMESTAMP timestamp = 0xffffffff) override;
Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/05623a62_f45b2370
PS2, Line 116: virtual double fullScaleInputValue() override
Bad function definition - virtual double fullScaleInputValue() should probably be virtual double fullScaleInputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e6fe73b2_79acfa36
PS2, Line 122: virtual double fullScaleOutputValue() override
Bad function definition - virtual double fullScaleOutputValue() should probably be virtual double fullScaleOutputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/563a6b6b_eadaa9a7
PS2, Line 154: virtual bool setRxAntenna(const std::string &ant, size_t chan = 0) override;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3f3fe317_ffcfd8d4
PS2, Line 160: virtual bool setTxAntenna(const std::string &ant, size_t chan = 0) override;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1900fd3a_275c0587
PS2, Line 166: virtual bool requiresRadioAlign() override;
Bad function definition - virtual bool requiresRadioAlign() should probably be virtual bool requiresRadioAlign(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c4f8a6e9_f0f8af19
PS2, Line 180: virtual inline double getSampleRate() override
Bad function definition - virtual inline double getSampleRate() should probably be virtual inline double getSampleRate(void)
File Transceiver52M/device/ipc2/ipcif.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7156ba40_b312c199
PS2, Line 35: using sample_t = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fee2edef_3cac70b9
PS2, Line 35: using sample_t = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7c9d33b7_95085a2e
PS2, Line 37: std::atomic<bool> ms_connected;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/59a78da7_77505797
PS2, Line 37: std::atomic<bool> ms_connected;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6904fbb_07150c9b
PS2, Line 37: std::atomic<bool> ms_connected;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b3974ff_e5789b98
PS2, Line 39: shm::sema r;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89a3fffe_65643b9a
PS2, Line 40: shm::sema w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/beb8ed7b_acf6fac7
PS2, Line 41: std::atomic<uint64_t> ts;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/38fb8844_2dcfabdf
PS2, Line 41: std::atomic<uint64_t> ts;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7cfbbf69_ec0c6aee
PS2, Line 41: std::atomic<uint64_t> ts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fbf1e6ae_43c98e90
PS2, Line 42: std::atomic<uint64_t> ts_req;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a8efd569_60c5b775
PS2, Line 42: std::atomic<uint64_t> ts_req;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/593e0c8f_1844ba23
PS2, Line 42: std::atomic<uint64_t> ts_req;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/194837c0_8000ed00
PS2, Line 43: std::atomic<size_t> len_written_sps; // ->
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ce257af0_156038c6
PS2, Line 43: std::atomic<size_t> len_written_sps; // ->
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9a845225_9f4ac600
PS2, Line 43: std::atomic<size_t> len_written_sps; // ->
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1ba05bc2_7435f43b
PS2, Line 47: shm::sema r;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/22053d07_5810e706
PS2, Line 48: shm::sema w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/44b3db41_65b7ce63
PS2, Line 49: std::atomic<uint64_t> ts;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9f3ed677_2174adcf
PS2, Line 49: std::atomic<uint64_t> ts;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8c048fe0_42ba4889
PS2, Line 49: std::atomic<uint64_t> ts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/36599d53_564249b6
PS2, Line 50: std::atomic<uint64_t> ts_req;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/bae00da5_75f5e75b
PS2, Line 50: std::atomic<uint64_t> ts_req;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/28ec1a63_da15a818
PS2, Line 50: std::atomic<uint64_t> ts_req;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9086905a_01283fd8
PS2, Line 51: std::atomic<size_t> len_written_sps;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0d0cff4f_9af47237
PS2, Line 51: std::atomic<size_t> len_written_sps;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ed36f073_52466fa0
PS2, Line 51: std::atomic<size_t> len_written_sps;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/184a26e8_b330aaf8
PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5ce200e0_2d92dc62
PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/abfdc864_72902c5f
PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8cad5dfd_28ca9436
PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/88498a7c_28c05de3
PS2, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6c0d245d_e49e9a50
PS2, Line 60: using stype = typename std::make_signed<A>::type;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f2912444_75bbc1ed
PS2, Line 60: using stype = typename std::make_signed<A>::type;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5aab985a_e2c132df
PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/45d777bb_3cba3886
PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd47cd47_57d9fbd5
PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2842c9d1_7d08a76d
PS2, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0fce91ef_17a02c37
PS2, Line 90: template <unsigned int num_bursts> class ulburstprovider {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/59d7ca3a_ba0a7c36
PS2, Line 90: template <unsigned int num_bursts> class ulburstprovider {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d0d7963b_00d5eb89
PS2, Line 91: std::mutex ul_q_m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/646c55cd_bcf6b799
PS2, Line 98: void cur_buf_done()
Bad function definition - void cur_buf_done() should probably be void cur_buf_done(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8814733c_6624eced
PS2, Line 98: void cur_buf_done()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d2123386_6029ea20
PS2, Line 103: bool is_empty()
Bad function definition - bool is_empty() should probably be bool is_empty(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f7d4b763_7d26bf38
PS2, Line 103: bool is_empty()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4d4b6121_04cb1d91
PS2, Line 107: void reset()
Bad function definition - void reset() should probably be void reset(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/685009e0_61ee5fde
PS2, Line 107: void reset()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ac466315_88346419
PS2, Line 109: for (auto &i : foo)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9ca3ae6d_61f2063f
PS2, Line 113: ulentry &find_free_at_end()
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9708e2ed_08ffb55b
PS2, Line 123: void push_back(ulentry &e)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/afdb222e_0b15a608
PS2, Line 123: void push_back(ulentry &e)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01e5f853_6b5c4ccd
PS2, Line 130: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/08b6858e_3879250f
PS2, Line 131: void add(ulentry &e)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fe53ecb5_f45ca93f
PS2, Line 131: void add(ulentry &e)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1525b4c3_a519002e
PS2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/87a23cd3_2fcd6dfc
PS2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e03c7c7a_05ce8b37
PS2, Line 133: std::lock_guard<std::mutex> foo(ul_q_m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b4ae76d3_453be567
PS2, Line 136: void get(uint64_t requested_ts, unsigned int req_len_in_sps, sample_t *buf, unsigned int max_buf_write_len)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a6dc104f_2162c7b2
PS2, Line 138: std::lock_guard<std::mutex> g(ul_q_m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd734b0b_27cb756e
PS2, Line 138: std::lock_guard<std::mutex> g(ul_q_m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89adcdfc_abcc80f4
PS2, Line 138: std::lock_guard<std::mutex> g(ul_q_m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b209e52_8e8a9dc8
PS2, Line 149: memset((void*)buf, 0, samp2byte(req_len_in_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e2289784_ae5c19cf
PS2, Line 159: memset((void*)buf, 0, samp2byte(req_len_in_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7e8b3733_71999982
PS2, Line 171: memset((void*)buf, 0, samp2byte(req_len_in_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dc8c758b_4dd5b0e2
PS2, Line 176: memset((void*)buf, 0, samp2byte(to_pad_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ee5f6fb2_3c180621
PS2, Line 203: shm::shm<shm_if> m;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8b5bca22_4a30b325
PS2, Line 203: shm::shm<shm_if> m;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ca950797_63eb1a09
PS2, Line 203: shm::shm<shm_if> m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0d7347d_77bdf7d4
PS2, Line 206: ulburstprovider<10> p;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f91b6d2e_3a060b86
PS2, Line 206: ulburstprovider<10> p;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad1573f6_8e72f597
PS2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0566160d_cb81fae6
PS2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2ca303f5_b37008d8
PS2, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6d0b9388_85157e47
PS2, Line 217: shm::mtx_log::print_guard() << "\tr @" << direction.ts.load() << " " << readoffset_sps << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/29a83a99_ea999a57
PS2, Line 235: shm::mtx_log::print_guard() << "\tr+ " << *read_ts << " " << howmany_sps << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/07f8d3d6_dfb53bd9
PS2, Line 247: shm::mtx_log::print_guard() << "\tr++ " << *read_ts << " " << howmany_sps << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/18d29d35_593629fb
PS2, Line 249: } else {
else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ec0996e8_0b226007
PS2, Line 263: shm::mtx_log::print_guard()
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/249099cf_bcde4534
PS2, Line 270: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2dd76bb9_367bca4f
PS2, Line 275: bool create()
Bad function definition - bool create() should probably be bool create(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9b01aef9_c2337ba9
PS2, Line 275: bool create()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/590aac2a_fde9acaf
PS2, Line 281: bool connect()
Bad function definition - bool connect() should probably be bool connect(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6d2f702a_09524393
PS2, Line 281: bool connect()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cb6739b3_3f1194b1
PS2, Line 289: bool good()
Bad function definition - bool good() should probably be bool good(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2bf91492_7a597009
PS2, Line 289: bool good()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8ffd5db3_a7616ad7
PS2, Line 293: bool is_connected()
Bad function definition - bool is_connected() should probably be bool is_connected(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f9458b36_7c5c153e
PS2, Line 293: bool is_connected()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6c7c4fb6_17bad2c7
PS2, Line 299: void read_dl(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6ca99336_f48faa03
PS2, Line 305: void read_ul(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f86345d9_af441b42
PS2, Line 308: memset((void*)outbuf, 0, samp2byte(howmany_sps));
"(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/97d9771c_6ae0586d
PS2, Line 309: // return;
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fa723613_f217bc71
PS2, Line 314: void write_dl(size_t howmany_sps, uint64_t write_ts, sample_t *inbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/59c2feed_341009cd
PS2, Line 316: auto &dl = ptr->dl;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4e49cd64_45664729
PS2, Line 325: shm::sema_wait_guard g(dl.w, dl.r);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad0f71a5_91013754
PS2, Line 331: shm::mtx_log::print_guard() << std::endl
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/76bf94c7_7f935e9a
PS2, Line 336: void write_ul(size_t howmany_sps_sps, uint64_t write_ts, sample_t *inbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/54ad6f8f_706b94a4
PS2, Line 338: auto &ul = ptr->ul;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab1a9da7_5dff33dd
PS2, Line 351: shm::mtx_log::print_guard() << std::endl
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/771e2923_63e2f334
PS2, Line 356: void drive_tx()
Bad function definition - void drive_tx() should probably be void drive_tx(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b8d72181_ed656a07
PS2, Line 356: void drive_tx()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/318ad639_78ab26ac
PS2, Line 358: auto &ul = ptr->ul;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/15e6dffb_ef0d3805
PS2, Line 384: void signal_read_start()
Bad function definition - void signal_read_start() should probably be void signal_read_start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/877dc66e_62b6b41d
PS2, Line 384: void signal_read_start()
open brace '{' following function definitions go on the next line
File Transceiver52M/device/ipc2/shmif.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/eb644607_9579c6f5
PS2, Line 46: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1693b05c_4bb74683
PS2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5b5bbfa5_1c8670d1
PS2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/aebeff6b_0459d5f1
PS2, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/77c55d6f_dfef99da
PS2, Line 50: std::cerr << str();
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/12cceaea_d6c1d40b
PS2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0c928010_3bbd8cda
PS2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3c882d4b_4d36cebd
PS2, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d0c6ca60_6268763e
PS2, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &))
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd0a84ff_367f7573
PS2, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &))
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4ced4462_4170fd83
PS2, Line 73: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9afff3ef_55d2d279
PS2, Line 89: void lock()
Bad function definition - void lock() should probably be void lock(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e3520517_7b7ea85b
PS2, Line 89: void lock()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fb636e5e_faa6fd87
PS2, Line 94: bool try_lock()
Bad function definition - bool try_lock() should probably be bool try_lock(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ef6b7112_fae2cba6
PS2, Line 94: bool try_lock()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/90f7345f_c1af9d58
PS2, Line 99: void unlock()
Bad function definition - void unlock() should probably be void unlock(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/abff3ac7_ef507452
PS2, Line 99: void unlock()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/846764f3_24c01d36
PS2, Line 104: pthread_mutex_t *p()
Bad function definition - pthread_mutex_t *p() should probably be pthread_mutex_t *p(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab804f25_91c09e89
PS2, Line 104: pthread_mutex_t *p()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72c380ce_cb1fd615
PS2, Line 109: shmmutex &operator=(const shmmutex &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5dd0aec1_206f7b7e
PS2, Line 109: shmmutex &operator=(const shmmutex &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e9d9f048_bf8c7df3
PS2, Line 115: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/961dab4d_0a6761f7
PS2, Line 130: void wait(shmmutex *lock)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f61bada3_dff36445
PS2, Line 135: void signal()
Bad function definition - void signal() should probably be void signal(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b48a1d13_a81d6db7
PS2, Line 135: void signal()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1877ddc9_18b81d69
PS2, Line 140: void signal_all()
Bad function definition - void signal_all() should probably be void signal_all(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ce5524ba_d16a1e47
PS2, Line 140: void signal_all()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/219eb1cc_89d7f6ae
PS2, Line 145: shmcond &operator=(const shmcond &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/eba2bf9a_5472fe0a
PS2, Line 145: shmcond &operator=(const shmcond &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c83b8a93_a4cb8d6f
PS2, Line 149: shmmutex &m;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/12b2d928_fad62cdd
PS2, Line 150: shmcond &s;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3a30ea83_fe27cfdd
PS2, Line 152: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d121565f_fcd777b4
PS2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/734fe99f_9ca7d80e
PS2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/84dc4439_dac707f5
PS2, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c34827e1_54bbad7a
PS2, Line 165: signal_guard &operator=(const signal_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1780f1a9_9bbacec6
PS2, Line 165: signal_guard &operator=(const signal_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d3c669ff_60e5125d
PS2, Line 169: shmmutex &m;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/eeb28922_b3870366
PS2, Line 171: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1d286ccd_38f19728
PS2, Line 173: explicit mutex_guard(shmmutex &m) : m(m)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/23b6a7d0_5061701b
PS2, Line 182: mutex_guard &operator=(const mutex_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3c63ecb3_925b6fb8
PS2, Line 182: mutex_guard &operator=(const mutex_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e080a1cc_42dc1735
PS2, Line 186: std::atomic<int> value;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2da29632_3b624ac9
PS2, Line 186: std::atomic<int> value;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0d1b2f2_e029394b
PS2, Line 186: std::atomic<int> value;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/29384ff2_faa033a4
PS2, Line 190: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/82c752e2_f164c4ca
PS2, Line 198: void wait()
Bad function definition - void wait() should probably be void wait(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5d21a9b8_b4be25b3
PS2, Line 198: void wait()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f77ff0c3_e09d6eb3
PS2, Line 202: void wait(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3660db1d_67bfbc58
PS2, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/189d621f_de541083
PS2, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ee4a9e4f_edf77e3e
PS2, Line 205: mutex_guard g(m);
function definition argument 'm' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4896d3c6_d4b455a8
PS2, Line 210: void wait_and_reset()
Bad function definition - void wait_and_reset() should probably be void wait_and_reset(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b0d9ee6_a2cc2395
PS2, Line 210: void wait_and_reset()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/64dbc8eb_e1b03cf3
PS2, Line 214: void wait_and_reset(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/39b3f525_24f813c2
PS2, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/001c3da9_1e06e8cc
PS2, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01ec7353_26a6d2fb
PS2, Line 217: mutex_guard g(m);
function definition argument 'm' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6d46c281_0a713432
PS2, Line 223: void set()
Bad function definition - void set() should probably be void set(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f4c328d9_ae226303
PS2, Line 223: void set()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8a7c70f3_f161439e
PS2, Line 227: void set(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7e519b59_d35f0b65
PS2, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9f9baeb0_0826a66c
PS2, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2d07309f_8d3ee60c
PS2, Line 230: mutex_guard g(m);
function definition argument 'm' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8f33930e_101905f3
PS2, Line 234: void reset_unsafe()
Bad function definition - void reset_unsafe() should probably be void reset_unsafe(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f2064dcd_39ea23bf
PS2, Line 234: void reset_unsafe()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3bb61d37_5e091d92
PS2, Line 238: bool check_unsafe(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2f39ccde_f6b5b66f
PS2, Line 243: sema &operator=(const sema &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ada744ee_acaa6a36
PS2, Line 243: sema &operator=(const sema &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0388d9c3_795d2bf3
PS2, Line 247: sema &a;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3a94712c_d71ad545
PS2, Line 248: sema &b;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96e6a50f_e4f4a28f
PS2, Line 250: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/60f42e38_e2f5cee4
PS2, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cb60795f_d3e13d5c
PS2, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cdbf0ddd_f4cd39a0
PS2, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2dc97c45_1f6bfffe
PS2, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/214ab49f_17437e32
PS2, Line 265: sema &a;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/33074b0c_2436e030
PS2, Line 266: sema &b;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f2f06355_23f043c5
PS2, Line 268: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b232afdb_b9b3cbca
PS2, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d41cbff9_5ae783ad
PS2, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dca3451f_4ba4aa85
PS2, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/afb11ee5_fac34b8e
PS2, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/daa77e76_8048a624
PS2, Line 282: template <typename IFT> class shm {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd41f343_ae2a9602
PS2, Line 282: template <typename IFT> class shm {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2e396ae3_fb4e01bd
PS2, Line 287: int ipc_shm_setup(const char *shm_name)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/450e2df9_836fb384
PS2, Line 293: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) {
Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/742af127_911a5c4f
PS2, Line 310: shmptr = new (ptr) IFT(); //static_cast<IFT *>(ptr);
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3ada4cde_49942d79
PS2, Line 315: int ipc_shm_connect(const char *shm_name)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b865db96_0ac48435
PS2, Line 321: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR)) < 0) {
Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/36035164_70bc0a8f
PS2, Line 339: shmptr = static_cast<IFT *>(ptr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9cfe66c3_11aceee0
PS2, Line 339: shmptr = static_cast<IFT *>(ptr);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d00b8d1c_6187717b
PS2, Line 339: shmptr = static_cast<IFT *>(ptr);
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/71c58734_ccdbefc9
PS2, Line 344: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6affbb4d_01d5a5b8
PS2, Line 348: strncpy((char *)shmname, name, 512);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/48cfa4a6_a0f6af2f
PS2, Line 350: void create()
Bad function definition - void create() should probably be void create(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4f0587c0_3cb673fc
PS2, Line 350: void create()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad193449_65ce6949
PS2, Line 355: void open()
Bad function definition - void open() should probably be void open(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd360768_d3ef3120
PS2, Line 355: void open()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f64c4e21_7482d277
PS2, Line 360: bool isgood() const
Bad function definition - bool isgood() should probably be bool isgood(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5630194f_a38df97d
PS2, Line 364: void close()
Bad function definition - void close() should probably be void close(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0cf2e12_d08242a4
PS2, Line 364: void close()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d2b65f4e_7291a6d2
PS2, Line 369: IFT *p()
Bad function definition - IFT *p() should probably be IFT *p(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1510):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3548f8a3_7a1a3521
PS2, Line 369: IFT *p()
open brace '{' following function definitions go on the next line
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ill-fated ipcv2 for mstrx
by Hoernchen
Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/30414
to look at the new patch set (#2).
Change subject: ill-fated ipcv2 for mstrx
......................................................................
ill-fated ipcv2 for mstrx
The problem here is that the ipc if requires reducing the clock ind
inteval to a few fn/ts on the trx side to work at all, but scheduling
still does not work out, unless you start driving the IF using the tx
side, at which point the approach is useless, because it does not really
do more than a burst loopback that is easier to do with the higher
layers/interfaces.
The code is still useful should there be a reason to continue working on
this.
Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5
---
M Transceiver52M/device/Makefile.am
A Transceiver52M/device/ipc2/IPCDevice.cpp
A Transceiver52M/device/ipc2/IPCDevice.h
A Transceiver52M/device/ipc2/Makefile.am
A Transceiver52M/device/ipc2/ipcif.h
A Transceiver52M/device/ipc2/shmif.h
6 files changed, 1,281 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/14/30414/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newpatchset
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ms-trx support
by Jenkins Builder
Attention is currently required from: Hoernchen.
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 2:
(408 comments)
File Transceiver52M/ms/bladerf_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ac398c1c_b77b843a
PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8f013f6_0d2bcf94
PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/facaacf3_64db5128
PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b6c019d_aa7a430c
PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3493d252_16566615
PS2, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e76c7ce_defeab86
PS2, Line 44: out << '(' << std::forward<Arg>(arg);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8ad9870_e64ae3b1
PS2, Line 44: out << '(' << std::forward<Arg>(arg);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bb31d7a_b2b3951d
PS2, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... };
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2583187b_d4262b90
PS2, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... };
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10ee9772_e31f5161
PS2, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17d4672d_93ea4552
PS2, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2284c66c_7c219fa3
PS2, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c10657a_438c9110
PS2, Line 52: template <class R, class... Args>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03f16073_facafa2d
PS2, Line 52: template <class R, class... Args>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcda8fd6_5a1aeed8
PS2, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e996809d_a4100ad3
PS2, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line,
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6004ca7_23b0e7a1
PS2, Line 56: R rval = func(std::forward<Args>(args)...);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8faa3170_f373e9bb
PS2, Line 56: R rval = func(std::forward<Args>(args)...);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/06074678_b51e6280
PS2, Line 57: if (rval != 0) {
suspect code indent for conditional statements (8, 26)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/914c1e8a_8b96bf13
PS2, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':'
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8129465b_7158fe99
PS2, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__)
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c3f00b5_659efa9f
PS2, Line 69: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79cfc92f_171096ea
PS2, Line 69: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d57c7c48_7f9a0b66
PS2, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c205ac73_4a8da9ff
PS2, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79d50ad1_07733d5f
PS2, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!");
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b7aed85_d8facfa1
PS2, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!");
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58ba745a_6a570676
PS2, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!");
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ea732ac_903b1da2
PS2, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!");
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24164b66_780879ce
PS2, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c762f18_b873fae3
PS2, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a3f696b_8c2c509e
PS2, Line 82: blade_usb_message<T> m[SZ];
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a1ff4cf_7179fe65
PS2, Line 82: blade_usb_message<T> m[SZ];
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c7aea4f2_014b0c98
PS2, Line 83: int actual_samples_per_msg()
Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb633110_130cc80d
PS2, Line 83: int actual_samples_per_msg()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ffe4c6f_65caf1c2
PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5d7d863_e448474e
PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a01f779_6dc0735c
PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d503743f_d6db6b0f
PS2, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51c994f6_0fa8ffb7
PS2, Line 87: int actual_samples_per_buffer()
Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0cc504d_9a977458
PS2, Line 87: int actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f0c1c62_63da7844
PS2, Line 91: int samples_per_buffer()
Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f544051_c43a6cfb
PS2, Line 91: int samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4aafc47f_1a7f12d9
PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7076fa87_1c492939
PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8008f6e8_4595dfa4
PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4095380e_9b57b4ac
PS2, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8cf93ca0_174ce3e3
PS2, Line 95: int num_msgs_per_buffer()
Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7ca2752e_b93cea8a
PS2, Line 95: int num_msgs_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6766c182_ed789b10
PS2, Line 99: auto get_first_ts()
Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db9d4c23_3912098f
PS2, Line 99: auto get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c293f74_39d667ae
PS2, Line 103: constexpr auto *getsampleoffset(int ofs)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cc89856_2850c22d
PS2, Line 109: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/caa19eec_f21a1e03
PS2, Line 118: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c25896e6_57b28703
PS2, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08736312_ce6546c7
PS2, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9731e6da_32b8fbb7
PS2, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f83a2b9_e76b3158
PS2, Line 178: static blade_otw_buffer<SZ / 512, T> x;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/947270ed_88040ea2
PS2, Line 178: static blade_otw_buffer<SZ / 512, T> x;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef7f2b7c_0a39d7b4
PS2, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/348dda37_3f786b1b
PS2, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d89625fe_3cdf625f
PS2, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9d04593_bd5b1804
PS2, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e632f69_c83126d2
PS2, Line 185: template <typename T> struct blade_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19646b00_85d1edc9
PS2, Line 185: template <typename T> struct blade_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d8d6e43_d97c363d
PS2, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/51ce4983_99dc6d01
PS2, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63d10d14_6ebfcff3
PS2, Line 202: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5840b3c_d9146e46
PS2, Line 223: void close_device()
Bad function definition - void close_device() should probably be void close_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11e6e464_df921290
PS2, Line 223: void close_device()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23fadae6_6c2158a8
PS2, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fde03432_a765a96d
PS2, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02cf2806_d4dba24d
PS2, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual;
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/008dfa47_46b90165
PS2, Line 250: std::cerr << "open failed, device missing?" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9c3a3a61_2f54bc23
PS2, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6a57cc_aba30eb7
PS2, Line 271: std::cerr << "unable to lock refclk!" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae83c964_4fae6268
PS2, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0c5bf5b_f111079f
PS2, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ca2d6bc_46ed1b54
PS2, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/43a2fbb5_0ca9562b
PS2, Line 316: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61ee3a27_1a9d1604
PS2, Line 318: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a673fde2_939e168a
PS2, Line 320: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9553a025_ddc5d119
PS2, Line 323: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/52d928b4_e9b7bd86
PS2, Line 325: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d50a8e44_1ab699f7
PS2, Line 327: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ea57201_2a323fd5
PS2, Line 330: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1535610d_426589ed
PS2, Line 335: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a512f88_a81132d8
PS2, Line 338: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49ac56d0_9e63cb91
PS2, Line 340: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee369840_08598996
PS2, Line 343: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eba2ad04_b1417ceb
PS2, Line 346: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10882bc5_f3b13cd3
PS2, Line 348: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29940493_d0247f97
PS2, Line 351: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e46d7c81_67a44129
PS2, Line 356: static void check_timestamp(dev_buf_t *rcd)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa7a3811_9b620740
PS2, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) {
suspect code indent for conditional statements (16, 34)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c666a4b_b5b421da
PS2, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " "
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/13da38ed_ed31fb12
PS2, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b49d024_65ac478f
PS2, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11a22ff2_a4c76281
PS2, Line 377: void *samples, size_t num_samples, void *user_data) -> void * {
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4633e101_e7263baa
PS2, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02faffd6_25752bfd
PS2, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5df2a03_a8813ccf
PS2, Line 397: void *samples, size_t num_samples, void *user_data) -> void * {
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f26512e9_1b44bf0d
PS2, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b15ad8d_979a8eb0
PS2, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1a950ac_03be3621
PS2, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92fee962_138c157a
PS2, Line 410: auto fn = [this] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/732d6e9f_1fec785e
PS2, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6411ccdd_28ef651c
PS2, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8ed04a3_92e518b9
PS2, Line 422: auto fn = [this] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8639436_abcf0b72
PS2, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d96b6727_959b8f71
PS2, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/230f92f7_3aad504b
PS2, Line 435: //get empty bufer from list
'bufer' may be misspelled - perhaps 'buffer'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daee3132_12cd9c52
PS2, Line 436: tx_buf_q_type::elem_t rcd;
labels should not be indented
File Transceiver52M/ms/ipc_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fb7c401_41d2c058
PS2, Line 38: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a26047d8_9fcd12e0
PS2, Line 38: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17ede36b_383dacf7
PS2, Line 45: auto actual_samples_per_buffer()
Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cdb8fe55_9cceaf6f
PS2, Line 45: auto actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1edbfd43_6acb2f8c
PS2, Line 49: long get_first_ts()
Bad function definition - long get_first_ts() should probably be long get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56f6f013_b31bd14e
PS2, Line 49: long get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/923cb376_3aede780
PS2, Line 53: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d73c3400_41ba8b87
PS2, Line 58: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35bf31f4_5c6e0ac7
PS2, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0123dd3_8c7aebb1
PS2, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c427cf2c_71380d73
PS2, Line 71: template <typename T> struct ipc_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f35c6428_a0a84447
PS2, Line 71: template <typename T> struct ipc_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f180f9bd_caaab3b1
PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/833ad6d6_e9c0f660
PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ddae2912_94d39308
PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72c4e3a9_0cdd319f
PS2, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86fe3efa_64bcf9a0
PS2, Line 92: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bdc0968_f424f640
PS2, Line 99: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21ffd096_9e7a0930
PS2, Line 106: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a80c3a23_382c61be
PS2, Line 111: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa7158f6_ab4f12da
PS2, Line 119: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab3e3f91_86d8d264
PS2, Line 127: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/862edfd4_68c6de6f
PS2, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f5d1c2f_c1775b11
PS2, Line 137: void *rx_cb(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9846cb8d_b8177dc5
PS2, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf };
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/366bf6df_88406df1
PS2, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf };
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/097d964a_97ad66b4
PS2, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e853008_8d3647c7
PS2, Line 166: auto fn = [this, burst_handler] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f238f19b_caecb91f
PS2, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8bae041_97eb3160
PS2, Line 177: auto fn = [] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c1de663d_6fb76c7f
PS2, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/770c2ad4_aeb73237
PS2, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/43062a01_90429084
PS2, Line 193: void signal_start()
Bad function definition - void signal_start() should probably be void signal_start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74dacd07_f45e55aa
PS2, Line 193: void signal_start()
open brace '{' following function definitions go on the next line
File Transceiver52M/ms/itrq.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/805a658a_a6649f51
PS2, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fef7c90d_14c60f14
PS2, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eff8d83f_229375fd
PS2, Line 52: std::condition_variable cond_r, cond_w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49de2144_f4f258d6
PS2, Line 53: std::mutex lr, lw;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a868605c_ef0ccf44
PS2, Line 54: std::atomic_int r_flag, w_flag;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04e1704e_39d91c98
PS2, Line 56: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a88df88_769eb0bc
PS2, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0)
Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b58e43d6_9b6ac868
PS2, Line 65: ssize_t spsc_check_r()
Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6a8e76d3_a1f37664
PS2, Line 65: ssize_t spsc_check_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85d36b5a_e907779b
PS2, Line 67: std::unique_lock<std::mutex> lk(lr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5ee47da_00d44193
PS2, Line 67: std::unique_lock<std::mutex> lk(lr);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d94a142_56d3773c
PS2, Line 67: std::unique_lock<std::mutex> lk(lr);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f02b4a81_8d37af70
PS2, Line 73: ssize_t spsc_check_w()
Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef3bcd20_c001c58d
PS2, Line 73: ssize_t spsc_check_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1ab9715_9b3b370a
PS2, Line 75: std::unique_lock<std::mutex> lk(lw);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bce293ab_08bcb368
PS2, Line 75: std::unique_lock<std::mutex> lk(lw);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3021a7d5_30cbc351
PS2, Line 75: std::unique_lock<std::mutex> lk(lw);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ed5d007_c1f0d1c6
PS2, Line 81: void spsc_notify_r()
Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ebdfce0_a0c9f8c5
PS2, Line 81: void spsc_notify_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/afa06b44_acfcbe05
PS2, Line 83: std::unique_lock<std::mutex> lk(lr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6d7ef54_ff2a5b75
PS2, Line 83: std::unique_lock<std::mutex> lk(lr);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b982ee8_a8206daa
PS2, Line 83: std::unique_lock<std::mutex> lk(lr);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99ad0c14_8eaff6b7
PS2, Line 87: void spsc_notify_w()
Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0751689_02967fad
PS2, Line 87: void spsc_notify_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/65837489_e502f78b
PS2, Line 89: std::unique_lock<std::mutex> lk(lw);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e527369c_fe214f37
PS2, Line 89: std::unique_lock<std::mutex> lk(lw);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2bef5700_65c6d88e
PS2, Line 89: std::unique_lock<std::mutex> lk(lw);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f4f2f1c_9f04cdd8
PS2, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7a2e9db9_40691450
PS2, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a084cf8_22586c71
PS2, Line 99: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e36864a5_bf9a860d
PS2, Line 100: explicit spsc_efd_detail()
Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b8e8b43_a53c4989
PS2, Line 111: ssize_t spsc_check_r()
Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9dfd037b_148bb38d
PS2, Line 111: ssize_t spsc_check_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/38359cc0_9b6f5cf4
PS2, Line 116: ssize_t spsc_check_w()
Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7edd4f2_0342b6a3
PS2, Line 116: ssize_t spsc_check_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3bce982f_8c808462
PS2, Line 121: void spsc_notify_r()
Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/26303265_6b7d41dd
PS2, Line 121: void spsc_notify_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f885732_2d375112
PS2, Line 126: void spsc_notify_w()
Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8d01d9e_fd0b6db4
PS2, Line 126: void spsc_notify_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/626489da_c0b10d5a
PS2, Line 131: int get_r_efd()
Bad function definition - int get_r_efd() should probably be int get_r_efd(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f51f435_62c6e067
PS2, Line 131: int get_r_efd()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f687d017_f12730e9
PS2, Line 135: int get_w_efd()
Bad function definition - int get_w_efd() should probably be int get_w_efd(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95a220c7_88e5ca8a
PS2, Line 135: int get_w_efd()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad6294e0_6ca0bcdd
PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/807a4bda_7ecc3b84
PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b284723d_9b7d702a
PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d31d197_578aebe0
PS2, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53a4925f_75a64bed
PS2, Line 142: class spsc : public T<block_read, block_write> {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87dafb2b_31eeb866
PS2, Line 142: class spsc : public T<block_read, block_write> {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2ea72a85_e1de608a
PS2, Line 144: std::atomic<unsigned int> readptr;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/178e37b0_4381b5c8
PS2, Line 144: std::atomic<unsigned int> readptr;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86d554c2_c87ccd7f
PS2, Line 144: std::atomic<unsigned int> readptr;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b619e4d3_d9516d94
PS2, Line 145: std::atomic<unsigned int> writeptr;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/355f16db_c4d92f19
PS2, Line 145: std::atomic<unsigned int> writeptr;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bdb36439_6de575ea
PS2, Line 145: std::atomic<unsigned int> writeptr;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20b0c12e_a8dd4d78
PS2, Line 149: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1b7674ce_23faa831
PS2, Line 150: using base_t = T<block_read, block_write>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39f48482_45487798
PS2, Line 150: using base_t = T<block_read, block_write>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e0c2e7b_8dfb546f
PS2, Line 152: explicit spsc() : readptr(0), writeptr(0)
Bad function definition - explicit spsc() should probably be explicit spsc(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1afbd55d_2a08ba4a
PS2, Line 163: bool spsc_push(const ELEM *elem)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0512508_25083ab7
PS2, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95ae9c67_15be7a12
PS2, Line 176: base_t::spsc_notify_r(); /* fine after release */
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f225590_a319e27c
PS2, Line 183: bool spsc_pop(ELEM *elem)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b9c5bc56_5d91b150
PS2, Line 195: base_t::spsc_notify_w();
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab87e5ef_e0507192
PS2, Line 202: ssize_t spsc_prep_pop()
Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6042f9b_14039555
PS2, Line 202: ssize_t spsc_prep_pop()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/324e1d15_d2656793
PS2, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ca1683b_15d9a4a1
PS2, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68512c8d_3520e851
PS2, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {};
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d8c2da4_33d95ff3
PS2, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {};
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ab241d7_afdcabb3
PS2, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a6e13f4_af7c4a98
PS2, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79004e00_c6f9d6fe
PS2, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
adding a line without newline at end of file
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de4a1b43_e055b541
PS2, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0ab1582_3892f89f
PS2, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
spaces required around that '>' (ctx:VxW)
File Transceiver52M/ms/logging.cpp:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/865eb3a0_2ae3b1f1
PS2, Line 83: .enabled = 0,
trailing whitespace
File Transceiver52M/ms/ms.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/95b56a27_964f7bdc
PS2, Line 34: #define BASET blade_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b994966d_a92afde8
PS2, Line 34: #define BASET blade_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/465213ec_dfc467c8
PS2, Line 37: #define BASET uhd_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c45b81b_c860676f
PS2, Line 37: #define BASET uhd_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2999fa2c_4e8a2332
PS2, Line 40: #define BASET ipc_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c580a354_2cff24aa
PS2, Line 40: #define BASET ipc_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76a89e4a_740a5bfe
PS2, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c79096f7_b61f987b
PS2, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27d4b37e_b97de5f6
PS2, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07ce88e6_5d4885ef
PS2, Line 60: template <typename DST_T, typename SRC_T, typename ST>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5dbd9e2_9d12e084
PS2, Line 60: template <typename DST_T, typename SRC_T, typename ST>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9df6e966_c3f44a50
PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f89128a9_539a1057
PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37400f40_a8d674d8
PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78bcaffc_bd47c9bd
PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcc2b7d2_bd605cf7
PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/936da6d0_23400de3
PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b99c338f_f485964f
PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aff69de4_6e883f1f
PS2, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6228cc7e_7a0040bd
PS2, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d17ae6b_4b9add35
PS2, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f58bf6b0_a16da5fc
PS2, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01a68954_c70951df
PS2, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d4e2fe4_7eacb915
PS2, Line 75: GSM::Time gsmts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e183f15_486ceef0
PS2, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7c908880_6f49fd8a
PS2, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c6c1024_b253a743
PS2, Line 87: std::ostream null_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a7a6219_818a8466
PS2, Line 89: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96e2aa27_b6985563
PS2, Line 90: dummylog() : null_stream(this){};
space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f32615b_7b029abe
PS2, Line 92: std::ostream &operator()()
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0fc09b7_b9591198
PS2, Line 92: std::ostream &operator()()
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0e3a0f8_cea448be
PS2, Line 104: GSM::Time global_time_keeper;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5b522b7_87dd95e9
PS2, Line 106: std::mutex m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d7bac078_b76c78cd
PS2, Line 108: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b0e0ff2_de040450
PS2, Line 113: void set(GSM::Time t, int64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b10767e_328525e6
PS2, Line 115: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f4e0f3d0_4f2bf30d
PS2, Line 115: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2cd5f698_1d379f6d
PS2, Line 115: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8855f4ed_8cbc1a9a
PS2, Line 119: void inc_both()
Bad function definition - void inc_both() should probably be void inc_both(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4dda287c_eede24d7
PS2, Line 119: void inc_both()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/55b366db_4731de88
PS2, Line 121: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f3fa857_c7204759
PS2, Line 121: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3575f302_0ceb7f4a
PS2, Line 121: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19fb5fc7_54b5a7dd
PS2, Line 125: void inc_and_update(int64_t new_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8687152d_812c5c28
PS2, Line 127: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbb94964_31ebb703
PS2, Line 127: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/decee943_d584f6e2
PS2, Line 127: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9309d335_cb849bc6
PS2, Line 132: void inc_and_update_safe(int64_t new_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8cb6ab3_5db8e5ca
PS2, Line 134: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba72a718_9745abf0
PS2, Line 134: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/97162c89_9332e1b8
PS2, Line 134: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f28b6a2a_236b789f
PS2, Line 142: void dec_by_one()
Bad function definition - void dec_by_one() should probably be void dec_by_one(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d427cb21_85a48306
PS2, Line 142: void dec_by_one()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/93dfe7e0_fbe7d794
PS2, Line 144: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/39c1f362_52438e48
PS2, Line 144: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4cff87fe_95f9440a
PS2, Line 144: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/412d55c6_c341ae04
PS2, Line 148: auto get_ts()
Bad function definition - auto get_ts() should probably be auto get_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82ced194_e0c514d9
PS2, Line 148: auto get_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4d31dae_ee0c44bc
PS2, Line 150: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8ce3124_f3dd8a7c
PS2, Line 150: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8067df9c_9ed9cde3
PS2, Line 150: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b271f9c3_9b70b2a5
PS2, Line 153: auto gsmtime()
Bad function definition - auto gsmtime() should probably be auto gsmtime(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1c146e2_62fcec8d
PS2, Line 153: auto gsmtime()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9419931a_da76f90b
PS2, Line 155: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe0c13db_a94a7c2a
PS2, Line 155: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71490996_77a53e2d
PS2, Line 155: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fed0b9bb_b1071370
PS2, Line 158: void get_both(GSM::Time *t, int64_t *ts)
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f66bdf06_0bdd98aa
PS2, Line 158: void get_both(GSM::Time *t, int64_t *ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd45cce2_2dbd107d
PS2, Line 160: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a50abdf1_6538f769
PS2, Line 160: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e1fbdad_c0e174f9
PS2, Line 160: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ff5f6c5_fe629dff
PS2, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10bf98f8_17e81be0
PS2, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/414b11d5_73637894
PS2, Line 176: std::thread rx_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9755754d_6ee983c3
PS2, Line 177: std::thread tx_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aef4a099_c39f761e
PS2, Line 178: std::thread *calcrval_task;
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fd40f7c_f0a69952
PS2, Line 178: std::thread *calcrval_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a8eb9f3_5f716e79
PS2, Line 189: std::atomic<bool> rcv_done;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/89a49d0c_2b972ac8
PS2, Line 189: std::atomic<bool> rcv_done;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb61630d_1f2a8513
PS2, Line 189: std::atomic<bool> rcv_done;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce6b2be8_09ca15be
PS2, Line 190: std::atomic<bool> sch_thread_done;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3befff9_d7a44d44
PS2, Line 190: std::atomic<bool> sch_thread_done;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4c50341_5ae7c582
PS2, Line 190: std::atomic<bool> sch_thread_done;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6f2ae87_ea9e5531
PS2, Line 197: void start();
Bad function definition - void start() should probably be void start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31139cf3_7af35fa6
PS2, Line 198: std::atomic<bool> upper_is_ready;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32feaa6a_19ccb291
PS2, Line 198: std::atomic<bool> upper_is_ready;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f8289a1_ed97aafd
PS2, Line 198: std::atomic<bool> upper_is_ready;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3d91393_24acc846
PS2, Line 201: bool handle_sch_or_nb();
Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d3072fe_f11e2486
PS2, Line 207: int init_device();
Bad function definition - int init_device() should probably be int init_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53054c84_6b209720
PS2, Line 208: int init_dev_and_streams();
Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3eb711f4_a3666ea2
PS2, Line 209: void stop_threads();
Bad function definition - void stop_threads() should probably be void stop_threads(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7441feab_a3df5f5d
PS2, Line 211: void *tx_cb();
Bad function definition - void *tx_cb() should probably be void *tx_cb(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68a4e779_813e745c
PS2, Line 212: void maybe_update_gain(one_burst &brst);
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b4ccf39_d744d0b6
PS2, Line 225: bh_fn_t rx_bh();
Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1444e982_1f4c9a00
PS2, Line 226: bh_fn_t tx_bh();
Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e48b00b1_0864b183
PS2, Line 229: void set_ta(int val)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a10ffe2c_1829813d
PS2, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/074d44a2_7588e3c5
PS2, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype,
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/305bab73_b4ccbbb7
PS2, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4084a0d8_e72349a5
PS2, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno);
labels should not be indented
File Transceiver52M/ms/ms_rx_burst.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/210b7aeb_896c1b97
PS2, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale);
adding a line without newline at end of file
File Transceiver52M/ms/ms_upper.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/316c15d2_0b712f37
PS2, Line 44: bool driveControl();
Bad function definition - bool driveControl() should probably be bool driveControl(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f414477_66610c77
PS2, Line 45: void driveReceiveFIFO();
Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4ebb43ae_7155557d
PS2, Line 46: void driveTx();
Bad function definition - void driveTx() should probably be void driveTx(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bcd6f3d_f12fd28e
PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b28085a_e533507a
PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18bc8f38_68b2d62d
PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3ec9be35_c7cfb2e5
PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
function definition argument 'int' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/46bb9bb1_a656a05f
PS2, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
function definition argument 'int' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9c98d55_7e259344
PS2, Line 50: std::thread thr_control, thr_rx, thr_tx;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20883957_2648112b
PS2, Line 52: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/89f66281_6e2802d9
PS2, Line 53: void start_threads();
Bad function definition - void start_threads() should probably be void start_threads(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/452a6bf8_955ff2d1
PS2, Line 54: void start_lower_ms();
Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f9736d9_63ed5b14
PS2, Line 56: upper_trx(){};
space required before the open brace '{'
File Transceiver52M/ms/sch.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/561a1011_4fe3fd9a
PS2, Line 130: int gsm_fcch_check_ts(int ts, int fn) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3db20e4f_85f12762
PS2, Line 134: int gsm_sch_check_ts(int ts, int fn) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f6e7ae78_e412c5e6
PS2, Line 205: #if 1
Consider removing the #if 1 and its #endif
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fd1437bb_79fc71a4
PS2, Line 210: float a, b, c, d, ang, avg = 0.0f;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da78706f_1701e0c6
PS2, Line 235: ang = b - a;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c00205cf_3287c219
PS2, Line 237: if (ang > M_PI)
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aed017f7_1fa05b5a
PS2, Line 238: ang -= 2 * M_PI;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5e537e0_045f80c7
PS2, Line 239: else if (ang < -M_PI)
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae124ede_440eeb28
PS2, Line 240: ang += 2 * M_PI;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5db93485_e6721615
PS2, Line 242: avg += ang;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d20a7cc_d38ab782
PS2, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/84ce0cda_61978db2
PS2, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b16732fc_c85145b0
PS2, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3664e39_195c68a8
PS2, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8cba79be_bbf76d67
PS2, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a0c09973_6aa5e9cb
PS2, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62078d28_3a1b6a28
PS2, Line 314: static __attribute__((constructor)) void init()
Bad function definition - void init() should probably be void init(void)
File Transceiver52M/ms/uhd_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/242c1c9b_e9c1a5d4
PS2, Line 35: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75f01dec_1fe9c42c
PS2, Line 35: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f043012_a17c445f
PS2, Line 41: uhd::rx_metadata_t *md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3881609_47e19272
PS2, Line 43: auto actual_samples_per_buffer()
Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6ab496_9d7bcf64
PS2, Line 43: auto actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bde09a4b_2662aa77
PS2, Line 47: long get_first_ts()
Bad function definition - long get_first_ts() should probably be long get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa19381d_274e5151
PS2, Line 47: long get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ee3156f2_93f7671b
PS2, Line 51: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24443202_55319b90
PS2, Line 56: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a9316799_99b4a15f
PS2, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f58a521a_7a8bda6d
PS2, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/046d1195_f9c65e4d
PS2, Line 69: template <typename T> struct uhd_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7317e6fd_37c50faf
PS2, Line 69: template <typename T> struct uhd_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/294d445e_5493aa72
PS2, Line 70: uhd::usrp::multi_usrp::sptr dev;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08daf9f0_135e736a
PS2, Line 71: uhd::rx_streamer::sptr rx_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa3da926_9d8cc89b
PS2, Line 72: uhd::tx_streamer::sptr tx_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e350667_cbcaf3a7
PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d4030cb_ec8e415b
PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e9ef2b4f_5482524a
PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5cef973_45437a6b
PS2, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1163c37_6a84399b
PS2, Line 90: void close_device()
Bad function definition - void close_device() should probably be void close_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa9dcd65_ee9fa117
PS2, Line 90: void close_device()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d8c4aa0_e9e6be7a
PS2, Line 95: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c9c48af9_cf912c56
PS2, Line 102: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa37e21e_69b72f03
PS2, Line 109: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fdd81261_9285956e
PS2, Line 114: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8de6c3a0_10c428e5
PS2, Line 122: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71a36148_e4045277
PS2, Line 130: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68a4e6a5_5e7cb5f5
PS2, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72d9156b_47753f88
PS2, Line 145: std::string args = {};
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/409406e3_4f41e69e
PS2, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03560bfe_1c4a4cc5
PS2, Line 153: uhd::tune_request_t tune_request(freq, 0);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af64fcbf_1fbd3bda
PS2, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms));
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ef84a8d1_cc7d0583
PS2, Line 164: uhd::stream_args_t stream_args("sc16", "sc16");
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66dfbdd0_7c78e9e4
PS2, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16");
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b214a91a_09dcb8ef
PS2, Line 177: void *rx_cb(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc9f9cf1_817bb6f3
PS2, Line 182: uhd::rx_metadata_t md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07327356_0977f702
PS2, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c37ee65_74c183a2
PS2, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e309200_00d118c7
PS2, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror());
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/24c2261c_cd13a929
PS2, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/730873d6_6c0e7484
PS2, Line 211: auto fn = [this, burst_handler] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6bdabc96_9aebecc6
PS2, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fed190f4_a987f005
PS2, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f756c13_048d4a3a
PS2, Line 227: auto fn = [] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cc252526_f5505ce7
PS2, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f986189_730186cd
PS2, Line 234: uhd::tx_metadata_t m = {};
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/34540695_3147c90b
PS2, Line 239: std::vector<void *> ptrs(1, buffer);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a8ecf8a4_4f4c060a
PS2, Line 239: std::vector<void *> ptrs(1, buffer);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d273c053_0a1546df
PS2, Line 239: std::vector<void *> ptrs(1, buffer);
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/703a0df4_e7c8b909
PS2, Line 239: std::vector<void *> ptrs(1, buffer);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01e75ac1_3e130836
PS2, Line 243: uhd::async_metadata_t async_md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dce1bfd1_67a1843a
PS2, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1509):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49aca56e_59596b2a
PS2, Line 251: };
adding a line without newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:24:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ms-trx support
by Hoernchen
Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/30416
to look at the new patch set (#2).
Change subject: ms-trx support
......................................................................
ms-trx support
This is basically a trxcon that includes a transceiver, and can just
be used with existing and future apps supporting the trxcon interface,
i.e. mobile or ccch_scan.
Supports bladerf and uhd, binaries are automatically built if those libs
are detected + the osmocom-bb submodule exists.
Currently using hardcoded sched/prios aimed at a setup with working,
reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3,
not 2, not any other version)
Additionally builds test tools used for development: osmo-trx-syncthing*
Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
---
M .gitignore
M Makefile.am
M Transceiver52M/Makefile.am
A Transceiver52M/ms/bladerf_specific.h
A Transceiver52M/ms/ipc_specific.h
A Transceiver52M/ms/itrq.h
A Transceiver52M/ms/l1ctl_server.c
A Transceiver52M/ms/l1ctl_server_cb.cpp
A Transceiver52M/ms/logging.cpp
A Transceiver52M/ms/ms.cpp
A Transceiver52M/ms/ms.h
A Transceiver52M/ms/ms_rx_burst.h
A Transceiver52M/ms/ms_rx_burst_test.cpp
A Transceiver52M/ms/ms_rx_lower.cpp
A Transceiver52M/ms/ms_upper.cpp
A Transceiver52M/ms/ms_upper.h
A Transceiver52M/ms/sch.c
A Transceiver52M/ms/sch.h
A Transceiver52M/ms/uhd_specific.h
M configure.ac
20 files changed, 3,730 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newpatchset
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: rename noisevector class -> avgvector
by Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30411 )
Change subject: rename noisevector class -> avgvector
......................................................................
Patch Set 1:
(3 comments)
File Transceiver52M/Transceiver.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1508):
https://gerrit.osmocom.org/c/osmo-trx/+/30411/comment/7e73e6d6_d5484956
PS1, Line 83: avgVector mNoises;
please, no spaces at the start of a line
File Transceiver52M/radioVector.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1508):
https://gerrit.osmocom.org/c/osmo-trx/+/30411/comment/c30a0037_6bf461da
PS1, Line 51: class avgVector : std::vector<float> {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1508):
https://gerrit.osmocom.org/c/osmo-trx/+/30411/comment/7a4ed35c_041745c6
PS1, Line 51: class avgVector : std::vector<float> {
spaces required around that '>' (ctx:VxW)
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927
Gerrit-Change-Number: 30411
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: bladerf xa4 support
by Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 )
Change subject: bladerf xa4 support
......................................................................
Patch Set 1:
(57 comments)
File Transceiver52M/device/bladerf/bladerf.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bca2278b_a36b586f
PS1, Line 56: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/24d40c12_9293db06
PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bfceb675_607f2e6e
PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ab43e3fd_62ef6efe
PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/83db1139_040c1275
PS1, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0850ff55_ac646b5a
PS1, Line 61: int open(const std::string &args, int ref, bool swap_channels);
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/6a0e8967_7008fa3f
PS1, Line 62: bool start();
Bad function definition - bool start() should probably be bool start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5feb8566_d801bd6c
PS1, Line 63: bool stop();
Bad function definition - bool stop() should probably be bool stop(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/26820d48_de022792
PS1, Line 64: bool restart();
Bad function definition - bool restart() should probably be bool restart(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ca3a2797_3a18b370
PS1, Line 65: enum TxWindowType getWindowType()
Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/91a6d585_d69e0639
PS1, Line 65: enum TxWindowType getWindowType()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/fb491306_992d04bf
PS1, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bfed8f8d_aedb231d
PS1, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c854d89e_fa959d4f
PS1, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun);
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d3b66a52_6ee30203
PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/46b8a722_a5100a97
PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/7aeeb97b_29f6809e
PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp);
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3b5ffdb2_5ecf8684
PS1, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp);
function definition argument 'short *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/59b0a455_0cf2b4e0
PS1, Line 79: TIMESTAMP initialWriteTimestamp();
Bad function definition - TIMESTAMP initialWriteTimestamp() should probably be TIMESTAMP initialWriteTimestamp(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5d806beb_f7fec483
PS1, Line 80: TIMESTAMP initialReadTimestamp();
Bad function definition - TIMESTAMP initialReadTimestamp() should probably be TIMESTAMP initialReadTimestamp(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/03eab3ca_15ffc725
PS1, Line 82: double fullScaleInputValue();
Bad function definition - double fullScaleInputValue() should probably be double fullScaleInputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/bc1b1539_9230b2a9
PS1, Line 83: double fullScaleOutputValue();
Bad function definition - double fullScaleOutputValue() should probably be double fullScaleOutputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/23dd8e5b_2c975ba2
PS1, Line 87: double maxRxGain(void)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/416e026b_3aa5766c
PS1, Line 91: double minRxGain(void)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0af1117f_3fe8ab1d
PS1, Line 104: double getRxFreq();
Bad function definition - double getRxFreq() should probably be double getRxFreq(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/84e8dfaf_4792f18b
PS1, Line 106: bool setRxAntenna(const std::string &ant, size_t chan)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/34afb39e_0c0ccac0
PS1, Line 106: bool setRxAntenna(const std::string &ant, size_t chan)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/76a028d7_19cb6b50
PS1, Line 110: std::string getRxAntenna(size_t chan)
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/50c48b94_4eecb2e4
PS1, Line 114: bool setTxAntenna(const std::string &ant, size_t chan)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/67f2d6d4_daedd21f
PS1, Line 114: bool setTxAntenna(const std::string &ant, size_t chan)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/8d3da6cb_241defd3
PS1, Line 118: std::string getTxAntenna(size_t chan)
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3e1da1d6_67153f2a
PS1, Line 123: bool requiresRadioAlign();
Bad function definition - bool requiresRadioAlign() should probably be bool requiresRadioAlign(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d7f5a78a_e43f0222
PS1, Line 125: GSM::Time minLatency();
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a1384af4_9b1fe7a5
PS1, Line 127: inline double getSampleRate()
Bad function definition - double getSampleRate() should probably be double getSampleRate(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5f51b6ca_3cc50e9c
PS1, Line 135: bool recv_async_msg();
Bad function definition - bool recv_async_msg() should probably be bool recv_async_msg(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/36c70268_5df31bc1
PS1, Line 144: protected:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d44686cf_bcbdf7df
PS1, Line 155: std::vector<double> tx_gains, rx_gains;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/24e11f17_453353e7
PS1, Line 155: std::vector<double> tx_gains, rx_gains;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e9e8c6e1_81ef3142
PS1, Line 155: std::vector<double> tx_gains, rx_gains;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/50040567_f9317f72
PS1, Line 156: std::vector<double> tx_freqs, rx_freqs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/1ec98268_c7e3122c
PS1, Line 156: std::vector<double> tx_freqs, rx_freqs;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3799ee8b_e7c9f999
PS1, Line 156: std::vector<double> tx_freqs, rx_freqs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/49329394_fd0f1b38
PS1, Line 169: std::vector<smpl_buf *> rx_buffers;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c6943008_44cee1cc
PS1, Line 169: std::vector<smpl_buf *> rx_buffers;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0083b7c9_ea8af053
PS1, Line 169: std::vector<smpl_buf *> rx_buffers;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/768422f1_6b1dc3aa
PS1, Line 169: std::vector<smpl_buf *> rx_buffers;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/010b711e_bc7d4e65
PS1, Line 171: std::vector<std::vector<short> > pkt_bufs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/95926dc9_78d8e7c0
PS1, Line 171: std::vector<std::vector<short> > pkt_bufs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/32fe518d_9ea59c7e
PS1, Line 171: std::vector<std::vector<short> > pkt_bufs;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/eec062fd_0c681c84
PS1, Line 171: std::vector<std::vector<short> > pkt_bufs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/53dff1f5_45272f96
PS1, Line 174: std::vector<short *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/1b442535_1dc1ae89
PS1, Line 174: std::vector<short *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/0b49c0f6_c9feffd2
PS1, Line 174: std::vector<short *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e59cfb6a_1dd7943b
PS1, Line 174: std::vector<short *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/1d0122a9_76d03002
PS1, Line 176: void init_gains();
Bad function definition - void init_gains() should probably be void init_gains(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/4e8aa58f_7bf4946c
PS1, Line 178: void set_rates();
Bad function definition - void set_rates() should probably be void set_rates(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1506):
https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/97453589_e3e61b48
PS1, Line 182: void get_dev_band_desc(dev_band_desc &desc);
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac
Gerrit-Change-Number: 30413
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: vita demod by piotr krysik, modified
by Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 )
Change subject: vita demod by piotr krysik, modified
......................................................................
Patch Set 1:
(946 comments)
File Transceiver52M/grgsm_vitac/constants.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c765206_28929c41
PS1, Line 1: #pragma once
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/250b56b8_6998c832
PS1, Line 2: /* -*- c++ -*- */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a8e58380_ab353244
PS1, Line 3: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bbd76eb_8ad83e0e
PS1, Line 4: * @file
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bcc44498_f146212a
PS1, Line 5: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78ac416e_b0e69b54
PS1, Line 6: * @section LICENSE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36453a23_27b1c099
PS1, Line 7: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d9ac085_c9939edc
PS1, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a929f71_797eb401
PS1, Line 9: * it under the terms of the GNU General Public License as published by
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2e2a0ac_976a95f9
PS1, Line 10: * the Free Software Foundation; either version 3, or (at your option)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71230916_cdd72af8
PS1, Line 11: * any later version.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d3cdce5_206bc841
PS1, Line 12: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef22c058_bda85972
PS1, Line 13: * Gr-gsm is distributed in the hope that it will be useful,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a7ae5d1_2d48edc1
PS1, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bd26d71_1746d0dd
PS1, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b3a6c98_278b329b
PS1, Line 16: * GNU General Public License for more details.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15630a2a_e5dacf42
PS1, Line 17: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be3dde20_c73f9125
PS1, Line 18: * You should have received a copy of the GNU General Public License
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/791803ae_72348dce
PS1, Line 19: * along with gr-gsm; see the file COPYING. If not, write to
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1790ffec_94b444b6
PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4aff52df_96acdf98
PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/413b8940_3a2c7659
PS1, Line 21: * Boston, MA 02110-1301, USA.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c67528de_2e056cb4
PS1, Line 22: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27beaac5_0bf5c52b
PS1, Line 23:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c7e0363_0c9e4acf
PS1, Line 24: #include <complex>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5e5efaa_b581901b
PS1, Line 25:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aea7ce8f_2b5e49bb
PS1, Line 26: #define gr_complex std::complex<float>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08a2c2b3_eedce1d9
PS1, Line 26: #define gr_complex std::complex<float>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b32d756a_83a54211
PS1, Line 26: #define gr_complex std::complex<float>
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2616a319_1ac735dc
PS1, Line 27:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5893403a_ef75b046
PS1, Line 28:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/613391fc_8f2c5929
PS1, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53ca57ff_81e53370
PS1, Line 30: #define GSM_SYMBOL_PERIOD (1.0/GSM_SYMBOL_RATE) //seconds per symbol
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/622e8ead_86fa8e27
PS1, Line 31:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4841e8f_36182df7
PS1, Line 32: //Burst timing
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fe198116_b43a2b45
PS1, Line 33: #define TAIL_BITS 3
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/513fd8d2_d275fbc7
PS1, Line 34: #define GUARD_BITS 8
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37514408_b13c3517
PS1, Line 35: #define GUARD_FRACTIONAL 0.25 //fractional part of guard period
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36902134_ad2549c3
PS1, Line 36: #define GUARD_PERIOD GUARD_BITS + GUARD_FRACTIONAL
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01724171_7f26917a
PS1, Line 37: #define DATA_BITS 57 //size of 1 data block in normal burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a202eb5_eb062a70
PS1, Line 38: #define STEALING_BIT 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/966fb927_0c7bfe40
PS1, Line 39: #define N_TRAIN_BITS 26
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d434c6a1_256c57e9
PS1, Line 40: #define N_SYNC_BITS 64
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c621408_220202fa
PS1, Line 41: #define USEFUL_BITS 142 //(2*(DATA_BITS+STEALING_BIT) + N_TRAIN_BITS )
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/39f1fc5c_53b5a75a
PS1, Line 42: #define FCCH_BITS USEFUL_BITS
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/710bc0e9_462ffc89
PS1, Line 43: #define BURST_SIZE (USEFUL_BITS+2*TAIL_BITS)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9e48e15_edc84899
PS1, Line 44: #define ACCESS_BURST_SIZE 88
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/972dc4d3_78689808
PS1, Line 45: #define PROCESSED_CHUNK BURST_SIZE+2*GUARD_PERIOD
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1342ecf_08493315
PS1, Line 46:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0f52a5d_3ed2b69a
PS1, Line 47: #define SCH_DATA_LEN 39
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d198e39_d21d1e7f
PS1, Line 48: #define TS_BITS (TAIL_BITS+USEFUL_BITS+TAIL_BITS+GUARD_BITS) //a full TS (156 bits)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf394a14_3f04d6e5
PS1, Line 49: #define TS_PER_FRAME 8
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e49b753f_509985c4
PS1, Line 50: #define FRAME_BITS (TS_PER_FRAME * TS_BITS + 2) // 156.25 * 8
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7a179d2_05a6d9b4
PS1, Line 51: #define FCCH_POS TAIL_BITS
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42440848_b119a77b
PS1, Line 52: #define SYNC_POS (TAIL_BITS + 39)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/149a24f4_08598026
PS1, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d54b5ad0_93c25c9f
PS1, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e77131a5_6dd73eab
PS1, Line 54: //aren't used for channel impulse response estimation
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/297aa079_125f5791
PS1, Line 55: #define TRAIN_BEGINNING 5
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7d1aa34_b7649147
PS1, Line 56: #define SAFETY_MARGIN 6 //
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19e26741_af0c1f07
PS1, Line 57:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/443339b1_baadc3c1
PS1, Line 58: #define FCCH_HITS_NEEDED (USEFUL_BITS - 4)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77f3383e_980a48c8
PS1, Line 59: #define FCCH_MAX_MISSES 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c541c4a_c7951267
PS1, Line 60: #define FCCH_MAX_FREQ_OFFSET 100
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/593bfe4f_e742f9c4
PS1, Line 61:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1351f17_892e7d56
PS1, Line 62: #define CHAN_IMP_RESP_LENGTH 5
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f503c4d_b224b4e8
PS1, Line 63:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2c0f49a_bf2ecba6
PS1, Line 64: #define MAX_SCH_ERRORS 10 //maximum number of subsequent sch errors after which gsm receiver goes to find_next_fcch state
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/817b6e83_c4e037fc
PS1, Line 65:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5fdf0e9_36c3addd
PS1, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1adffe2f_98eff1ea
PS1, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type;
do not add new typedefs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e2af1517_5469e19e
PS1, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a41306db_2e9bf8ed
PS1, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type;
do not add new typedefs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b425568_1ba2b4f0
PS1, Line 68:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3500c1f1_d4ecce6f
PS1, Line 69: static const unsigned char SYNC_BITS[] = {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c25a2e5_337ddd6a
PS1, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dee1b668_5340f777
PS1, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0cab3188_11cc06a6
PS1, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8283ff5_48aff324
PS1, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ced30781_8d92f890
PS1, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0eb09f22_baa279ce
PS1, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02bb6a45_71633152
PS1, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/771e3d1e_2762251b
PS1, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca223170_91aec175
PS1, Line 74: };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0150c868_73d5beda
PS1, Line 75:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1ae47b8_51ab1197
PS1, Line 76: const unsigned FCCH_FRAMES[] = { 0, 10, 20, 30, 40 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/090335e9_013732c1
PS1, Line 77: const unsigned SCH_FRAMES[] = { 1, 11, 21, 31, 41 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6993f3cd_b01ad354
PS1, Line 78:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83c4d3d5_03ce16b0
PS1, Line 79: const unsigned BCCH_FRAMES[] = { 2, 3, 4, 5 }; //!!the receiver shouldn't care about logical
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21c7d31a_7948b2da
PS1, Line 80: //!!channels so this will be removed from this header
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66ef0223_41d99c89
PS1, Line 81: const unsigned TEST_CCH_FRAMES[] = { 2, 3, 4, 5, 6, 7, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 22, 23, 24, 25, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39, 42, 43, 44, 45, 46, 47, 48, 49 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e7a30ef_cdb49fbc
PS1, Line 82: const unsigned TRAFFIC_CHANNEL_F[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f476616d_dcf283ad
PS1, Line 83: const unsigned TEST51[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4469eab_6e584bcd
PS1, Line 84:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b12a5518_51e8d668
PS1, Line 85:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e81046c8_89bffc11
PS1, Line 86: #define TSC0 0
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/083aa607_729b5177
PS1, Line 87: #define TSC1 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9ceb949_e257dad6
PS1, Line 88: #define TSC2 2
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/521d7950_c975d27c
PS1, Line 89: #define TSC3 3
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46937a45_143bdc5c
PS1, Line 90: #define TSC4 4
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0dd1923_772c8d96
PS1, Line 91: #define TSC5 5
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f59c29de_b50fe42e
PS1, Line 92: #define TSC6 6
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68b09481_51c3b64e
PS1, Line 93: #define TSC7 7
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43ac62d7_2be838ac
PS1, Line 94: #define TS_DUMMY 8
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e196663b_60289e82
PS1, Line 95:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0cda597e_a50f60d3
PS1, Line 96: #define TRAIN_SEQ_NUM 9
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d99f6502_fdbaa4f2
PS1, Line 97:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d7947c0_4b684dd8
PS1, Line 98: #define TIMESLOT0 0
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/588adf83_f28bddea
PS1, Line 99: #define TIMESLOT1 1
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3be8da3a_f8357069
PS1, Line 100: #define TIMESLOT2 2
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1aa3427d_3ee7e06b
PS1, Line 101: #define TIMESLOT3 3
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db6acf66_61d96d63
PS1, Line 102: #define TIMESLOT4 4
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92699d73_95bf00f9
PS1, Line 103: #define TIMESLOT5 5
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f4228d4_574db7e7
PS1, Line 104: #define TIMESLOT6 6
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/562ea229_0de9b05a
PS1, Line 105: #define TIMESLOT7 7
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2799eb4e_ccecfb9e
PS1, Line 106:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/279fc43c_b217a68a
PS1, Line 107:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/373d978e_cf16342f
PS1, Line 108: static const unsigned char train_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS] = {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/179c0224_dae2cb90
PS1, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd39411b_467c2dac
PS1, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a8d17d3_5504f188
PS1, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a1c1d54_6f572df9
PS1, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f081c838_f080f1f7
PS1, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66a3655f_d2f8a928
PS1, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6957beb8_637a09ca
PS1, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74216fc5_c296bef4
PS1, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8410d7f6_4379b418
PS1, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3461c2e6_4336502a
PS1, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eaba18d5_d00d217c
PS1, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/68a4128b_8716da72
PS1, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/daabad89_8d5a8be4
PS1, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95cb21e9_5bfd9945
PS1, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c91e97e_6229b943
PS1, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0},
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c280b845_2f3cdb14
PS1, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0},
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56a56934_0f85b845
PS1, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a10f61f8_0c4e83d5
PS1, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a15bf9e5_5df1d822
PS1, Line 118: };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/179674a4_256d7ce1
PS1, Line 119:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/821983bf_58529e35
PS1, Line 120:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a957b17a_86f7cd7b
PS1, Line 121: //Dummy burst 0xFB 76 0A 4E 09 10 1F 1C 5C 5C 57 4A 33 39 E9 F1 2F A8
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c004521_284e3c28
PS1, Line 122: static const unsigned char dummy_burst[] = {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/470d6721_73c9d20f
PS1, Line 123: 0, 0, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94624cc5_3934d621
PS1, Line 123: 0, 0, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a02a0559_d6ffe612
PS1, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9cf91cda_2d7181a7
PS1, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1ab605f_692b4270
PS1, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23539071_453c1bbe
PS1, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d64fab7_b464cdff
PS1, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/563e3a72_1456ee59
PS1, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11e4ae72_16872808
PS1, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa7012bb_e34b1aa4
PS1, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4077095b_3e0ce536
PS1, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48f13672_6aa387fe
PS1, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6db899d0_becd5dda
PS1, Line 129: 0, 1, 1, 1, 1, 1, 0, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b936c234_10121971
PS1, Line 129: 0, 1, 1, 1, 1, 1, 0, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/593d5ee3_fbdd8b90
PS1, Line 130:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab770e95_7e0ca95c
PS1, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb6715ff_1acc5ae6
PS1, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/faf50c0c_38637a19
PS1, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e7e3dc74_31aef2a3
PS1, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1968a1d_e1c79484
PS1, Line 133: 0, 0, 0, 1, 0, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/861c3c02_a5a96e0a
PS1, Line 133: 0, 0, 0, 1, 0, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8206cd08_d7c1075f
PS1, Line 134:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6f3664c_1471e5c9
PS1, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/470305f0_c02f5109
PS1, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa56e667_dcb3a76e
PS1, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/551b49aa_96c22632
PS1, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/031d5186_7cb28672
PS1, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09fec686_68bcd2d2
PS1, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/958e19a8_66e2385e
PS1, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9a2e76d5_7bfcdd46
PS1, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9381a29_41e9007c
PS1, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b93e5a41_405c534d
PS1, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db9b8795_30c5875e
PS1, Line 140: 1, 1, 1, 0, 1, 0, 1, 0,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b6a124e_661b5c95
PS1, Line 140: 1, 1, 1, 0, 1, 0, 1, 0,
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad09e3cf_93d98360
PS1, Line 141: 0, 0, 0
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c92c6e6_734a572b
PS1, Line 141: 0, 0, 0
please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b990414_589c4398
PS1, Line 142: };
DOS line endings
File Transceiver52M/grgsm_vitac/grgsm_vitac.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1148acb5_bad53f0a
PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5bf11ce9_cfb2920c
PS1, Line 38: void initvita();
Bad function definition - void initvita() should probably be void initvita(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27dba7f0_3ad9739c
PS1, Line 59: std::string fpath;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4722701c_7ef552b2
PS1, Line 60: std::vector<gr_complex> data;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3298974a_413c4e4a
PS1, Line 60: std::vector<gr_complex> data;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f44a7eae_d69145aa
PS1, Line 60: std::vector<gr_complex> data;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/00fd018a_5e3ab623
PS1, Line 62: };
adding a line without newline at end of file
File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9e404a4_220bb2c1
PS1, Line 1: /* -*- c++ -*- */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/31021824_ef89c294
PS1, Line 2: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8fb9091_3152b7f1
PS1, Line 3: * @file
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb15089d_55a0baa6
PS1, Line 4: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/742eba2b_b1fe2445
PS1, Line 5: * @author Contributions by sysmocom - s.f.m.c. GmbH / Eric Wild <ewild(a)sysmocom.de>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1553997_e73af833
PS1, Line 6: * @section LICENSE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/598a472e_9abb75d3
PS1, Line 7: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c04ead3e_4b26b5e0
PS1, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5b38038_7d0b021e
PS1, Line 9: * it under the terms of the GNU General Public License as published by
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e1ca4c0_081865ce
PS1, Line 10: * the Free Software Foundation; either version 3, or (at your option)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65395f49_3b599d0e
PS1, Line 11: * any later version.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06a0756c_4008e2ce
PS1, Line 12: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b520ced_30692def
PS1, Line 13: * Gr-gsm is distributed in the hope that it will be useful,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9939643_48e4894c
PS1, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29735ff0_91f0ff1d
PS1, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98f37b70_a5978e62
PS1, Line 16: * GNU General Public License for more details.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab7fab40_d1f63522
PS1, Line 17: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa10b383_bb8050cd
PS1, Line 18: * You should have received a copy of the GNU General Public License
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f100b2a_9d7cb489
PS1, Line 19: * along with gr-gsm; see the file COPYING. If not, write to
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d4f628f_9800947c
PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4086fa39_44067ad6
PS1, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/724bf63c_a36a1dae
PS1, Line 21: * Boston, MA 02110-1301, USA.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2c12303_6a313ce1
PS1, Line 22: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69640a0c_dee8ac8c
PS1, Line 23:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a9765dd_49a02b6e
PS1, Line 24: #include "constants.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/555c976d_484982fe
PS1, Line 25:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cef5791f_19012566
PS1, Line 26: #ifdef HAVE_CONFIG_H
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b86cc147_edc03925
PS1, Line 27: #include "config.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8d683f0_91f70a24
PS1, Line 28: #endif
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7be12d56_ef28de9f
PS1, Line 29: #include <complex>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce6be2fa_0da118c6
PS1, Line 30:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2427629_74ac9f6a
PS1, Line 31:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0632632e_db4ef010
PS1, Line 32: #include <algorithm>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2f7cd34_a8d2ef20
PS1, Line 33: #include <string.h>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c87136c_af5af13f
PS1, Line 34: #include <iostream>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fcbfabfe_f4f6c693
PS1, Line 35: #include <numeric>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17ccb919_e5857cff
PS1, Line 36: #include <vector>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7294e941_a29053e1
PS1, Line 37: #include <fstream>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db12aa74_ce18fc9e
PS1, Line 38:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7230647_17f6b557
PS1, Line 39: #include "viterbi_detector.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f65719e_97393535
PS1, Line 40: #include "grgsm_vitac.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb4aa1fe_a91464ad
PS1, Line 41:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/116e9b2d_686de85e
PS1, Line 42: //signalVector mChanResp;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c9be3ce_13b94574
PS1, Line 43: gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5cf5952_7486067c
PS1, Line 44: gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1c3fa6d_58b3dbb7
PS1, Line 45: const int d_chan_imp_length = CHAN_IMP_RESP_LENGTH;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08e6f578_5eadd93d
PS1, Line 46:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff08f065_44c0ba89
PS1, Line 47: void initvita() {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d57ebb10_74f49821
PS1, Line 48:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a1866fc_76ca241a
PS1, Line 49: /**
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85cc1489_91d4a1b0
PS1, Line 50: * Prepare SCH sequence bits
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a6d037a_264d92cd
PS1, Line 51: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f4a3c722_5e8c206e
PS1, Line 52: * (TS_BITS + 2 * GUARD_PERIOD)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0317ceb_a9942226
PS1, Line 53: * Burst and two guard periods
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3dbf4760_6957fe1b
PS1, Line 54: * (one guard period is an arbitrary overlap)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6ecfadf6_5e22ace9
PS1, Line 55: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d043030_8288781d
PS1, Line 56: gmsk_mapper(SYNC_BITS, N_SYNC_BITS,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0ac8e5c_4619f9db
PS1, Line 57: d_sch_training_seq, gr_complex(0.0, -1.0));
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5e72d24_236b7e9f
PS1, Line 58: for (auto &i : d_sch_training_seq)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77242751_c2337426
PS1, Line 59: i = conj(i);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b94286fe_3b6eb654
PS1, Line 60:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67370989_2f770a54
PS1, Line 61: /* Prepare bits of training sequences */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d7267a3_7461436b
PS1, Line 62: for (int i = 0; i < TRAIN_SEQ_NUM; i++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d446e2a8_b539ddf2
PS1, Line 63: /**
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eaf63a51_7831cd59
PS1, Line 64: * If first bit of the sequence is 0
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43594d44_2710bc0e
PS1, Line 65: * => first symbol is 1, else -1
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f0c4151_5a483d35
PS1, Line 66: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b6478a8_1ed88113
PS1, Line 67: gr_complex startpoint = train_seq[i][0] == 0 ?
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85025519_e3644c4d
PS1, Line 68: gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fb4b8205_a6fe3c21
PS1, Line 69: gmsk_mapper(train_seq[i], N_TRAIN_BITS,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c74dfc36_91856a08
PS1, Line 70: d_norm_training_seq[i], startpoint);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b5e37e8c_1e1e280f
PS1, Line 71: for (auto &i : d_norm_training_seq[i])
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b668bab_3c412cb8
PS1, Line 72: i = conj(i);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61a4e590_b229abb5
PS1, Line 73: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/161f5af4_d13026f2
PS1, Line 74:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2fd93b40_ef3548bc
PS1, Line 75: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c35b931a_332ed84d
PS1, Line 76:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83fbad3b_e6a71bcb
PS1, Line 77: MULTI_VER_TARGET_ATTR
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b560c2b0_ceaea2d7
PS1, Line 78: void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b885f7bf_5ea964c3
PS1, Line 79: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f528346_ef12fab2
PS1, Line 80: std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77c30bbb_f4b32395
PS1, Line 81: unsigned int stop_states[2] = { 4, 12 };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d2ab2cd_017dc840
PS1, Line 82: gr_complex filtered_burst[BURST_SIZE];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/047cc16e_f0c75c48
PS1, Line 83: gr_complex rhh[CHAN_IMP_RESP_LENGTH];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7e5db3f_23f6d63b
PS1, Line 84: float output[BURST_SIZE];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74425755_56be3fa6
PS1, Line 85: int start_state = 3;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c64be620_d3e157c8
PS1, Line 86:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e46bcfe3_f4d3731d
PS1, Line 87: // if(burst_start < 0 ||burst_start > 10)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8fe6e5f6_a555936f
PS1, Line 88: // fprintf(stderr, "bo %d\n", burst_start);
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5ac5f68_54cdced1
PS1, Line 89:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d2d6f57e_285ef5de
PS1, Line 90: // burst_start = burst_start >= 0 ? burst_start : 0;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8abf6f6_603504a9
PS1, Line 91:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c18ace1_9c740b73
PS1, Line 92: autocorrelation(chan_imp_resp, &rhh_temp[0], d_chan_imp_length * d_OSR);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2280a4fe_47d8c400
PS1, Line 93: for (int ii = 0; ii < d_chan_imp_length; ii++)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0eefc283_b591397d
PS1, Line 94: rhh[ii] = conj(rhh_temp[ii * d_OSR]);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/206cc349_1913931c
PS1, Line 95:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f23305f_f027fbbc
PS1, Line 96: mafi(&input[burst_start], BURST_SIZE, chan_imp_resp,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75225d72_f21cc922
PS1, Line 97: d_chan_imp_length * d_OSR, filtered_burst);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a236678f_3d3afac0
PS1, Line 98:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1703ddae_94cf8609
PS1, Line 99: viterbi_detector(filtered_burst, BURST_SIZE, rhh,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2e7e788_80b21358
PS1, Line 100: start_state, stop_states, 2, output);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da936f22_d3252f40
PS1, Line 101:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/806e6462_18785811
PS1, Line 102: for (int i = 0; i < BURST_SIZE; i++)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1eae63d_eecb3f3b
PS1, Line 103: output_binary[i] = output[i] * -127; // pre flip bits!
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e5e4c05_abc2aed4
PS1, Line 104: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/858a7d53_0a148cb6
PS1, Line 105:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56221b57_336f2aa6
PS1, Line 106: void
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/230d302c_caaff3c6
PS1, Line 107: gmsk_mapper(const unsigned char* input,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1624464_d2c79968
PS1, Line 108: int nitems, gr_complex* gmsk_output, gr_complex start_point)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10593ae2_0ea0cbce
PS1, Line 109: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c175bc8_eb179b68
PS1, Line 110: gr_complex j = gr_complex(0.0, 1.0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3001784c_1fe391ca
PS1, Line 111: gmsk_output[0] = start_point;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03b12e64_10f7b7ab
PS1, Line 112:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8fbd021_d99f8f96
PS1, Line 113: int previous_symbol = 2 * input[0] - 1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e630620_21fc05a1
PS1, Line 114: int current_symbol;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/088c1c84_460d88d4
PS1, Line 115: int encoded_symbol;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3788ef4_d9ac705d
PS1, Line 116:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fdac0868_f61c303a
PS1, Line 117: for (int i = 1; i < nitems; i++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb639e2b_f457ebff
PS1, Line 118: /* Change bits representation to NRZ */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e445d07_2d9b59bf
PS1, Line 119: current_symbol = 2 * input[i] - 1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38173571_faf0f362
PS1, Line 120:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8eb98aa_18b253ff
PS1, Line 121: /* Differentially encode */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c8dc633_82d391d0
PS1, Line 122: encoded_symbol = current_symbol * previous_symbol;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/544ffc81_4d3d0a37
PS1, Line 123:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60563ef2_c7e3a579
PS1, Line 124: /* And do GMSK mapping */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09a70bef_ad9d739b
PS1, Line 125: gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/841317b3_88a7f4dd
PS1, Line 126: * gmsk_output[i - 1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4912945a_c0641d41
PS1, Line 127:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e18ef5e9_e28ba415
PS1, Line 128: previous_symbol = current_symbol;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63c5b308_8827a4f0
PS1, Line 129: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/455a8b76_21553993
PS1, Line 130: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5fa0e55_dde0a027
PS1, Line 131:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47d2e6e6_8d1dba84
PS1, Line 132: gr_complex
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a41b98b6_67428d81
PS1, Line 133: correlate_sequence(const gr_complex* sequence,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ebefeb3_2fbb0c9f
PS1, Line 134: int length, const gr_complex* input)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ffd4523_01c81f30
PS1, Line 135: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6689cbdd_6880a03b
PS1, Line 136: gr_complex result(0.0, 0.0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29af4bd3_8fc42b25
PS1, Line 137:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7acb0cb7_9c8a8e49
PS1, Line 138: for (int ii = 0; ii < length; ii++)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e225057d_47470d62
PS1, Line 139: result += sequence[ii] * input[ii * d_OSR];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ba97877_be69a929
PS1, Line 140:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3aa04e6_b2191241
PS1, Line 141: return conj(result) / gr_complex(length, 0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89379e99_b42231a2
PS1, Line 142: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46c4f687_136e9f7c
PS1, Line 143:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7d48bccc_4eb35635
PS1, Line 144: /* Computes autocorrelation for positive arguments */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9d1cd84_351f0596
PS1, Line 145: inline void
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e606c7db_770dcb1c
PS1, Line 146: autocorrelation(const gr_complex* input,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76016e6c_59b60b5d
PS1, Line 147: gr_complex* out, int nitems)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/44505148_7be409d9
PS1, Line 148: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8eb1c353_bba187a0
PS1, Line 149: for (int k = nitems - 1; k >= 0; k--) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0d5efdaa_c0d1794c
PS1, Line 150: out[k] = gr_complex(0, 0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45d751bd_bdf024ff
PS1, Line 151: for (int i = k; i < nitems; i++)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a75e118a_b1bd2901
PS1, Line 152: out[k] += input[i] * conj(input[i - k]);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b706f05_d969edec
PS1, Line 153: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93ed32a4_12a02f36
PS1, Line 154: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72ac2348_84916138
PS1, Line 155:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d640c407_941c6dbd
PS1, Line 156: inline void
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa36a971_0ba48c41
PS1, Line 157: mafi(const gr_complex* input, int nitems,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18f1e14f_25850106
PS1, Line 158: gr_complex* filter, int filter_length, gr_complex* output)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/702e537f_fb40650b
PS1, Line 159: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/337aa758_f5242c08
PS1, Line 160: for (int n = 0; n < nitems; n++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99d8f70b_b52021e4
PS1, Line 161: int a = n * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0177bb38_d6a457fa
PS1, Line 162: output[n] = 0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0985947b_872cc124
PS1, Line 163:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e937bc8_a0287c33
PS1, Line 164: for (int ii = 0; ii < filter_length; ii++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dabbae92_c318299d
PS1, Line 165: if ((a + ii) >= nitems * d_OSR)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0bd67994_b90fa247
PS1, Line 166: break;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32381b37_f44fefbc
PS1, Line 167:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4025de39_c35809c7
PS1, Line 168: output[n] += input[a + ii] * filter[ii];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f55cec5_8f2c3c40
PS1, Line 169: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7fbacb57_9b2de919
PS1, Line 170: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4db40936_19dc18b3
PS1, Line 171: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f59f5f63_b2bc6fd3
PS1, Line 172:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ac3e1c49_d66b7e2f
PS1, Line 173: int get_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, int search_center, int search_start_pos,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99d9e938_891f8f6c
PS1, Line 174: int search_stop_pos, gr_complex *tseq, int tseqlen, float *corr_max)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dda903c_9f49d9f6
PS1, Line 175: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7e8de0c_262f7515
PS1, Line 176: std::vector<gr_complex> correlation_buffer;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70638c2c_b95c2963
PS1, Line 177: std::vector<float> window_energy_buffer;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4423495c_61fd40b8
PS1, Line 178: std::vector<float> power_buffer;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c82f55c_b3303916
PS1, Line 179:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/546a31f1_5c55531b
PS1, Line 180: for (int ii = search_start_pos; ii < search_stop_pos; ii++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ca953a3_e3b0b8c1
PS1, Line 181: gr_complex correlation = correlate_sequence(tseq, tseqlen, &input[ii]);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88d3832f_134abc71
PS1, Line 182: correlation_buffer.push_back(correlation);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/817e81fa_ae558516
PS1, Line 183: power_buffer.push_back(std::pow(abs(correlation), 2));
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c261914_0ddb5ba6
PS1, Line 184: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98b458a3_03105150
PS1, Line 185:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f29f47e5_e77da77b
PS1, Line 186: int strongest_corr_nr = max_element(power_buffer.begin(), power_buffer.end()) - power_buffer.begin();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d51211f_f7d56857
PS1, Line 187:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c69b16e_9c026675
PS1, Line 188: /* Compute window energies */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67529bc2_2b121102
PS1, Line 189: auto window_energy_start_offset = strongest_corr_nr - 6 * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4de45a69_dc805e2d
PS1, Line 190: window_energy_start_offset = window_energy_start_offset < 0 ? 0 : window_energy_start_offset; //can end up out of range..
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/99965d58_f97f01ff
PS1, Line 191: auto window_energy_end_offset = strongest_corr_nr + 6 * d_OSR + d_chan_imp_length * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29e3f492_652d32e9
PS1, Line 192: auto iter = power_buffer.begin() + window_energy_start_offset;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/62bc3791_c85ccdaa
PS1, Line 193: auto iter_end = power_buffer.begin() + window_energy_end_offset;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4919dfaf_9c6e7ab4
PS1, Line 194: while (iter != iter_end) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/835cf9e8_60d49b7a
PS1, Line 195: std::vector<float>::iterator iter_ii = iter;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d54fdea2_d0785171
PS1, Line 196: bool loop_end = false;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b0bf954_11423535
PS1, Line 197: float energy = 0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3343352e_a2a43d0b
PS1, Line 198:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b62bbe2f_170195fe
PS1, Line 199: int len = d_chan_imp_length * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9da97551_76cdc61d
PS1, Line 200: for (int ii = 0; ii < len; ii++, iter_ii++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eda4f08a_fb43c649
PS1, Line 201: if (iter_ii == power_buffer.end()) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b5231a4_fd7f6baf
PS1, Line 202: loop_end = true;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46a44baf_9df5e5db
PS1, Line 203: break;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d060ada_2ae99286
PS1, Line 204: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08f73589_f8774aac
PS1, Line 205:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cfdd4c4a_1f001342
PS1, Line 206: energy += (*iter_ii);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6247c1f3_d959d8c5
PS1, Line 207: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5bccaa7_6ed98836
PS1, Line 208:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d2c1a409_6ee259e7
PS1, Line 209: if (loop_end)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7328f2c6_239543ff
PS1, Line 210: break;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c440e268_d9c813e2
PS1, Line 211:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f85e5830_a6564754
PS1, Line 212: window_energy_buffer.push_back(energy);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/368aea5f_a341565d
PS1, Line 213: iter++;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9805e073_6b485d55
PS1, Line 214: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9fcbd990_5e3262b1
PS1, Line 215:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/868bcf36_3c21b009
PS1, Line 216: /* Calculate the strongest window number */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3bb7195a_e24178ae
PS1, Line 217: int strongest_window_nr = window_energy_start_offset +
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35b9d108_50a190ba
PS1, Line 218: max_element(window_energy_buffer.begin(), window_energy_buffer.end()) -
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/784941e8_aaca1f5e
PS1, Line 219: window_energy_buffer.begin();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4110531d_48d1044c
PS1, Line 220:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c354686_9ff40f86
PS1, Line 221: // auto window_search_start = window_energy_buffer.begin() + strongest_corr_nr - 5* d_OSR;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26cc24c7_a4fb91e8
PS1, Line 222: // auto window_search_end = window_energy_buffer.begin() + strongest_corr_nr + 10* d_OSR;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/399cd6f4_523cadf2
PS1, Line 223: // window_search_end = window_search_end >= window_energy_buffer.end() ? window_energy_buffer.end() : window_search_end;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60ac2630_fc4a8375
PS1, Line 224:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4557be85_251577da
PS1, Line 225: // /* Calculate the strongest window number */
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/292f598d_8ff6c06f
PS1, Line 226: // int strongest_window_nr = max_element(window_search_start, window_search_end /* - d_chan_imp_length * d_OSR*/) - window_energy_buffer.begin();
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4873eb7_de85b17f
PS1, Line 227:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66625436_7d45a9c7
PS1, Line 228: // if (strongest_window_nr < 0)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfba0679_27fb2f11
PS1, Line 229: // strongest_window_nr = 0;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfa755f6_f281bd88
PS1, Line 230:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ba2f678_79a3c6b6
PS1, Line 231: float max_correlation = 0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4556d6c0_04dc8551
PS1, Line 232: for (int ii = 0; ii < d_chan_imp_length * d_OSR; ii++) {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a071c768_fbc67baa
PS1, Line 233: gr_complex correlation = correlation_buffer[strongest_window_nr + ii];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e53164d9_8a80bdf2
PS1, Line 234: if (abs(correlation) > max_correlation)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e97ac0d7_bb6736ca
PS1, Line 235: max_correlation = abs(correlation);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b140faf7_381a5f23
PS1, Line 236: chan_imp_resp[ii] = correlation;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/257c9d99_7f5b4de8
PS1, Line 237: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/248ea18a_cd10f604
PS1, Line 238:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2a94f80_a8ebd754
PS1, Line 239: *corr_max = max_correlation;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/028916d1_8bc52a61
PS1, Line 240:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a97f47c_4adf996a
PS1, Line 241: /**
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/864ce688_448dedce
PS1, Line 242: * Compute first sample position, which corresponds
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4239c1d3_086ea676
PS1, Line 243: * to the first sample of the impulse response
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/357ffb1b_0a8febbe
PS1, Line 244: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8d04f7d_e9088a03
PS1, Line 245: return search_start_pos + strongest_window_nr - search_center * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2b9e93f_8da93440
PS1, Line 246: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/00e8be9d_56ca1f41
PS1, Line 247:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82e5109c_20d38b22
PS1, Line 248: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/572bded8_ef921073
PS1, Line 249:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/921e1ca5_1758b401
PS1, Line 250: 3 + 57 + 1 + 26 + 1 + 57 + 3 + 8.25
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fed511d5_039abdb8
PS1, Line 251:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4b9e73a_92a1085f
PS1, Line 252: search center = 3 + 57 + 1 + 5 (due to tsc 5+16+5 split)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58f6453d_6247c090
PS1, Line 253: this is +-5 samples around (+5 beginning) of truncated t16 tsc
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ef37545_3bc2dcac
PS1, Line 254:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/967dbd41_021231cc
PS1, Line 255: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a79237a8_d5991adc
PS1, Line 256: int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0d33a1d_e7dc206a
PS1, Line 257: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89beaaa8_30832a0c
PS1, Line 258: const int search_center = TRAIN_POS;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa37f4cf_0faeb7a8
PS1, Line 259: const int search_start_pos = (search_center - 5) * d_OSR + 1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbe4e830_d6c3f2de
PS1, Line 260: const int search_stop_pos = (search_center + 5 + d_chan_imp_length) * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c1e5cdb_70ea18e9
PS1, Line 261: const auto tseq = &d_norm_training_seq[bcc][TRAIN_BEGINNING];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/690cf127_f7967ab8
PS1, Line 262: const auto tseqlen = N_TRAIN_BITS - (2 * TRAIN_BEGINNING);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8eb14204_8b43fd34
PS1, Line 263: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/129e3ed0_a2052e38
PS1, Line 264: corr_max);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/859cb1ab_86f60fcb
PS1, Line 265: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfdae906_e582462d
PS1, Line 266:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9ab6340_6fc46593
PS1, Line 267: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed76cca5_65768fdd
PS1, Line 268:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/543451d8_123a22ac
PS1, Line 269: 3 tail | 39 data | 64 tsc | 39 data | 3 tail | 8.25 guard
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/123e3a3c_39dc6ead
PS1, Line 270: start 3+39 - 10
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/574ecffb_18cc1f72
PS1, Line 271: end 3+39 + SYNC_SEARCH_RANGE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b823e2c_e6b626a7
PS1, Line 272:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ca8d150_32ac2e2c
PS1, Line 273: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75e33fa5_9edc9014
PS1, Line 274: int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aaba0fbb_4f35a4da
PS1, Line 275: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e4b0fd8_aa9cac34
PS1, Line 276: const int search_center = SYNC_POS + TRAIN_BEGINNING;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7d5755dc_2338c3fb
PS1, Line 277: const int search_start_pos = (search_center - 10) * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ed78992_619eef0d
PS1, Line 278: const int search_stop_pos = (search_center + SYNC_SEARCH_RANGE) * d_OSR;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/abc704d6_598a3ef6
PS1, Line 279: const auto tseq = &d_sch_training_seq[TRAIN_BEGINNING];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69db3703_ce73ea70
PS1, Line 280: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c36fe036_7bd7400a
PS1, Line 281:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec98c67e_6d47c6ce
PS1, Line 282: // strongest_window_nr + chan_imp_resp_center + SYNC_POS *d_OSR - 48 * d_OSR - 2 * d_OSR + 2 ;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b740fede_312bdb43
PS1, Line 283: float corr_max;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dcd4f0a_001f1afb
PS1, Line 284: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/662e4b36_5c9f6812
PS1, Line 285: &corr_max);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c9b874b_0f400604
PS1, Line 286: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1880709_345396ab
PS1, Line 287:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dcc13c3f_42043493
PS1, Line 288: int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/065e1095_8fe1418f
PS1, Line 289: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27fb4041_9c2302f2
PS1, Line 290: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26747407_4abd0f9b
PS1, Line 291: const int search_center = SYNC_POS + TRAIN_BEGINNING;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c96417dc_db1d7517
PS1, Line 292: const int search_start_pos = 0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b8c8dde_fb9fec1d
PS1, Line 293: // FIXME: proper end offset
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fe935329_6be24d2c
PS1, Line 294: const int search_stop_pos = len - (N_SYNC_BITS*8);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad2e1bc7_56d038d1
PS1, Line 295: auto tseq = &d_sch_training_seq[TRAIN_BEGINNING];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3cac809e_1dd1601e
PS1, Line 296:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/494b90c7_54d40315
PS1, Line 297: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen,
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ac8f901_dcd845a7
PS1, Line 298: corr_max);
DOS line endings
File Transceiver52M/grgsm_vitac/viterbi_detector.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/662c38f3_e0be7afd
PS1, Line 1: /* -*- c++ -*- */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/976087be_0aacee39
PS1, Line 2: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37797e43_4585d15c
PS1, Line 3: * @file
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1ecbb7d_2ba63274
PS1, Line 4: * @author (C) 2009 Piotr Krysik <ptrkrysik(a)gmail.com>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a250ad34_c899f019
PS1, Line 5: * @section LICENSE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9240db04_c21d9fae
PS1, Line 6: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ee3634f0_92a4e290
PS1, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e3e965f_ea0ea430
PS1, Line 8: * it under the terms of the GNU General Public License as published by
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37b2225c_5aca0a6e
PS1, Line 9: * the Free Software Foundation; either version 3, or (at your option)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b64bad2b_d4bc8aca
PS1, Line 10: * any later version.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15a37a30_1ade9ad4
PS1, Line 11: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9454edf1_f5b5b36e
PS1, Line 12: * Gr-gsm is distributed in the hope that it will be useful,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9db7e52a_eff98d53
PS1, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4c24a31_572844b6
PS1, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a11403fa_a2ab9885
PS1, Line 15: * GNU General Public License for more details.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2fe6059_33324288
PS1, Line 16: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4cc72c0_05fd07b6
PS1, Line 17: * You should have received a copy of the GNU General Public License
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9d7c7b3_d1297d7c
PS1, Line 18: * along with gr-gsm; see the file COPYING. If not, write to
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7287f36a_52eacc0f
PS1, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/253e903d_4fd2d0ec
PS1, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1164c2f9_1310a332
PS1, Line 20: * Boston, MA 02110-1301, USA.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ddbf25e_04a4fef2
PS1, Line 21: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23331ffc_25902a4c
PS1, Line 22:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e284283_565db17c
PS1, Line 23: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7601ec7_0c4b0803
PS1, Line 24: * viterbi_detector:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ffef8e3_5c1a7f13
PS1, Line 25: * This part does the detection of received sequnece.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e7f6660e_8dbb93cb
PS1, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b1f4b89_25c0c26a
PS1, Line 27: * At this moment it gives hard decisions on the output, but
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0101c8c_abf595b6
PS1, Line 28: * it was designed with soft decisions in mind.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8dc804c_6def203e
PS1, Line 29: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c2a11e3e_64c603ee
PS1, Line 30: * SYNTAX: void viterbi_detector(
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a040bc84_664197a1
PS1, Line 31: * const gr_complex * input,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ba0a889_34e29705
PS1, Line 32: * unsigned int samples_num,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf13daed_e8c803d3
PS1, Line 33: * gr_complex * rhh,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82f5a71a_3205f3f3
PS1, Line 34: * unsigned int start_state,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7d1fa5e7_cd38f709
PS1, Line 35: * const unsigned int * stop_states,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/73d3b597_b7811ac0
PS1, Line 36: * unsigned int stops_num,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/564bc931_253716c7
PS1, Line 37: * float * output)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2641bcf3_f14c1526
PS1, Line 38: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c66e296_d34673e7
PS1, Line 39: * INPUT: input: Complex received signal afted matched filtering.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48398d39_200b11b3
PS1, Line 40: * samples_num: Number of samples in the input table.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12f3e976_215d150b
PS1, Line 41: * rhh: The autocorrelation of the estimated channel
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a22e2bfd_2d1e1b72
PS1, Line 42: * impulse response.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ccac45de_19c8f274
PS1, Line 43: * start_state: Number of the start point. In GSM each burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f7d9377_1a1b5694
PS1, Line 44: * starts with sequence of three bits (0,0,0) which
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dc435d3_27d846a4
PS1, Line 45: * indicates start point of the algorithm.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a43da85_5973f853
PS1, Line 46: * stop_states: Table with numbers of possible stop states.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67c0e3a7_2861f743
PS1, Line 47: * stops_num: Number of possible stop states
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/815ab3f3_4dee3e7d
PS1, Line 48: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a10ea126_c5ff80ab
PS1, Line 49: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/529c19f8_a6fcd83d
PS1, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/232666fd_8206f9f5
PS1, Line 51: * -1 for logical "0" and 1 for logical "1"
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05dda335_009295bf
PS1, Line 52: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17d91056_105cfc84
PS1, Line 53: * SUB_FUNC: none
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52d05470_a6fb399c
PS1, Line 54: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6bec1f8_ee0be1be
PS1, Line 55: * TEST(S): Tested with real world normal burst.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f59fdb8_7f19c2f9
PS1, Line 56: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/381faa86_34062ff5
PS1, Line 57:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21225442_5442f21f
PS1, Line 58: #ifndef INCLUDED_VITERBI_DETECTOR_H
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bed1136_b614b0eb
PS1, Line 59: #define INCLUDED_VITERBI_DETECTOR_H
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/883b7a8e_e2ad83a2
PS1, Line 60: #include "constants.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4116c73d_511a7184
PS1, Line 61:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e788e12_01951a5a
PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fd208121_4e5fd3ef
PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b13bf4dc_1d3a64ce
PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75887d14_572d934c
PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6144a080_e69f4c66
PS1, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
"foo * bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d4fccee_913bad81
PS1, Line 63:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8159a93_b5794ab9
PS1, Line 64: #endif /* INCLUDED_VITERBI_DETECTOR_H */
DOS line endings
File Transceiver52M/grgsm_vitac/viterbi_detector.cc:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47100dcb_98d4e0ad
PS1, Line 1: /* -*- c++ -*- */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bba8cb5a_1c01ff96
PS1, Line 2: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75f1baa1_9e0b9139
PS1, Line 3: * @file
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a76e2e69_be2b8a07
PS1, Line 4: * @author (C) 2009 by Piotr Krysik <ptrkrysik(a)gmail.com>
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32018799_d8ecba86
PS1, Line 5: * @section LICENSE
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c277b59_8ebffdf2
PS1, Line 6: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f940e04f_c1bd61ba
PS1, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4a9343b8_9225dafa
PS1, Line 8: * it under the terms of the GNU General Public License as published by
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3aa5e09c_679cbc34
PS1, Line 9: * the Free Software Foundation; either version 3, or (at your option)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95c35409_89029d88
PS1, Line 10: * any later version.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54d21c68_b819951c
PS1, Line 11: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/695776a0_acf2200e
PS1, Line 12: * Gr-gsm is distributed in the hope that it will be useful,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6faef23a_d2f67eec
PS1, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b9db5f8_b560f21b
PS1, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be91d9d3_d5934204
PS1, Line 15: * GNU General Public License for more details.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a615c678_9c46c921
PS1, Line 16: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/513f9e68_179770e4
PS1, Line 17: * You should have received a copy of the GNU General Public License
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/130cd4da_80ff5978
PS1, Line 18: * along with gr-gsm; see the file COPYING. If not, write to
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60853de6_3ffd6743
PS1, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ea3d2b0_caa553e3
PS1, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street,
Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d0b3ebf6_4a0a3a99
PS1, Line 20: * Boston, MA 02110-1301, USA.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d278f34_3ed32355
PS1, Line 21: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/931ebd31_05021684
PS1, Line 22:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3711940d_d333a81a
PS1, Line 23: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/172281b1_850874b0
PS1, Line 24: * viterbi_detector:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f1ac61a_43feba14
PS1, Line 25: * This part does the detection of received sequnece.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b355beb_6034bde7
PS1, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/822b6b74_fcf0d5ec
PS1, Line 27: * At this moment it gives hard decisions on the output, but
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9cf71941_abe88bc3
PS1, Line 28: * it was designed with soft decisions in mind.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8e9b72ce_dc2b53ca
PS1, Line 29: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87b1ed02_4a96eb2c
PS1, Line 30: * SYNTAX: void viterbi_detector(
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e7af52b_435dd11c
PS1, Line 31: * const gr_complex * input,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dbdb93e1_54ca2faf
PS1, Line 32: * unsigned int samples_num,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b43c07d_328bb1fc
PS1, Line 33: * gr_complex * rhh,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc7e4271_96b3113d
PS1, Line 34: * unsigned int start_state,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/14ffd48c_615fcd97
PS1, Line 35: * const unsigned int * stop_states,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5215a13_be1f9731
PS1, Line 36: * unsigned int stops_num,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/053a1ed1_bfda3cdc
PS1, Line 37: * float * output)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94823fb7_0282c857
PS1, Line 38: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9eb807ca_078cdebf
PS1, Line 39: * INPUT: input: Complex received signal afted matched filtering.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d380d68_2640bb6f
PS1, Line 40: * samples_num: Number of samples in the input table.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc3a3f0c_9dd32866
PS1, Line 41: * rhh: The autocorrelation of the estimated channel
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab6bd4b9_c247c1a6
PS1, Line 42: * impulse response.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02113a4a_ccc661d8
PS1, Line 43: * start_state: Number of the start point. In GSM each burst
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c9ef86c_2f3e9a63
PS1, Line 44: * starts with sequence of three bits (0,0,0) which
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/07c6df30_5ece326c
PS1, Line 45: * indicates start point of the algorithm.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7408f587_90ba13c8
PS1, Line 46: * stop_states: Table with numbers of possible stop states.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/098f9077_aad287a6
PS1, Line 47: * stops_num: Number of possible stop states
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a5b830da_490388d3
PS1, Line 48: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c4083c9_1a25973e
PS1, Line 49: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c84b46d4_ca1c90d3
PS1, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bfc20b4_320487e3
PS1, Line 51: * -1 for logical "0" and 1 for logical "1"
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/282041d6_156fd5ea
PS1, Line 52: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1d5d7bb_bbf468af
PS1, Line 53: * SUB_FUNC: none
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e18a49ad_21d5c1eb
PS1, Line 54: *
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d688c8f6_769ee3b0
PS1, Line 55: * TEST(S): Tested with real world normal burst.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf29c01b_eaf16c59
PS1, Line 56: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e03eaf39_90347a3a
PS1, Line 57:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fda8c54f_f2e2864b
PS1, Line 58: #include "constants.h"
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c98bd7b_44caa744
PS1, Line 59: #include <cmath>
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb7c01ac_727279d6
PS1, Line 60:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0550bccd_7d661381
PS1, Line 61: #define PATHS_NUM (1 << (CHAN_IMP_RESP_LENGTH-1))
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c33d8aa_9341bf3b
PS1, Line 62:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7dd370e2_2fa8ab89
PS1, Line 63: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a6ab2f1_48eaa8ba
PS1, Line 64: {
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f69872f_a0fd0a5d
PS1, Line 65: float increment[8];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b31217a9_ffc2f0ff
PS1, Line 66: float path_metrics1[16];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b59f8ce_004c7ebe
PS1, Line 67: float path_metrics2[16];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/90d42655_2fa9ca18
PS1, Line 68: float paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4cecc630_838ad142
PS1, Line 69: float * new_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/262a1e01_68d52532
PS1, Line 70: float * old_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4687c928_3b7d9f9a
PS1, Line 71: float * tmp;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9ca21f0_0d8decc3
PS1, Line 72: float trans_table[BURST_SIZE][16];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02ef9230_56ce4398
PS1, Line 73: float pm_candidate1, pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78d0bbac_a8f3b821
PS1, Line 74: bool real_imag;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bb66eee9_bf25aa28
PS1, Line 75: float input_symbol_real, input_symbol_imag;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a79fd2ae_8146b2cf
PS1, Line 76: unsigned int i, sample_nr;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c7d549e_640a68ae
PS1, Line 77:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bcaa116_2bffb995
PS1, Line 78: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d10bb7c2_2956531d
PS1, Line 79: * Setup first path metrics, so only state pointed by start_state is possible.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1baf6be2_c1161cbd
PS1, Line 80: * Start_state metric is equal to zero, the rest is written with some very low value,
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc7d87ee_14051203
PS1, Line 81: * which makes them practically impossible to occur.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1d8c56d_3fb02ef0
PS1, Line 82: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7fc661b4_c4d90e61
PS1, Line 83: for(i=0; i<PATHS_NUM; i++){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/648dc41f_6c699e69
PS1, Line 84: path_metrics1[i]=(-10e30);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d9a6f80_d0edfec1
PS1, Line 85: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ff0c175_c9d87162
PS1, Line 86: path_metrics1[start_state]=0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2aebce47_89e918e9
PS1, Line 87:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1841d021_c3d3a2a2
PS1, Line 88: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/600271fc_22152fa8
PS1, Line 89: * Compute Increment - a table of values which does not change for subsequent input samples.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e488d1c_0f74a371
PS1, Line 90: * Increment is table of reference levels for computation of branch metrics:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dccf12c2_ffe3f3f8
PS1, Line 91: * branch metric = (+/-)received_sample (+/-) reference_level
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f1fc050_d77b0914
PS1, Line 92: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0bd679d_02413e8d
PS1, Line 93: increment[0] = -rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9fdc635_1b0feefc
PS1, Line 94: increment[1] = rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fece56a0_e7b48a8f
PS1, Line 95: increment[2] = -rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70cf5e3d_6963e5b2
PS1, Line 96: increment[3] = rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98ee6bc1_be8e6d89
PS1, Line 97: increment[4] = -rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fcac4b33_00240c08
PS1, Line 98: increment[5] = rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4d76c078_6b87074e
PS1, Line 99: increment[6] = -rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4fbcf33f_5f8502f6
PS1, Line 100: increment[7] = rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aa640ead_1084ae3a
PS1, Line 101:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c42b44e_4936da86
PS1, Line 102:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/beed48ac_564c36d3
PS1, Line 103: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03fc7661_518d5927
PS1, Line 104: * Computation of path metrics and decisions (Add-Compare-Select).
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/614313eb_9d6be5ae
PS1, Line 105: * It's composed of two parts: one for odd input samples (imaginary numbers)
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/909518a1_d46691b9
PS1, Line 106: * and one for even samples (real numbers).
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6352eadf_5b898828
PS1, Line 107: * Each part is composed of independent (parallelisable) statements like
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6492ba9a_1313d989
PS1, Line 108: * this one:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05a2d638_17ffc025
PS1, Line 109: * pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2];
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/81fb42d5_77542a76
PS1, Line 110: * pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5];
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8c761f2_f1505b73
PS1, Line 111: * paths_difference=pm_candidate2-pm_candidate1;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7acc0de2_67299dc0
PS1, Line 112: * new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0dd2f53f_22ceb4c2
PS1, Line 113: * trans_table[sample_nr][1] = paths_difference;
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8669d7e6_524cd5a4
PS1, Line 114: * This is very good point for optimisations (SIMD or OpenMP) as it's most time
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0a813eb_7258d34b
PS1, Line 115: * consuming part of this function.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ea58225_e37f7c89
PS1, Line 116: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae3ed814_720ab091
PS1, Line 117: sample_nr=0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83bbe402_317b7078
PS1, Line 118: old_path_metrics=path_metrics1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd9f060a_df4bcf7d
PS1, Line 119: new_path_metrics=path_metrics2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f52def7b_732611bb
PS1, Line 120: while(sample_nr<samples_num){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d40c2dbb_6d199cce
PS1, Line 121: //Processing imag states
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df9fb690_14a78787
PS1, Line 122: real_imag=1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/184dee4e_04f8eb79
PS1, Line 123: input_symbol_imag = input[sample_nr].imag();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b29eeca_984e52bf
PS1, Line 124:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/71c7c4a1_f9d42b5a
PS1, Line 125: pm_candidate1 = old_path_metrics[0] +input_symbol_imag -increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/00423798_727de65e
PS1, Line 126: pm_candidate2 = old_path_metrics[8] +input_symbol_imag +increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/959cfaea_3eb00a94
PS1, Line 127: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/282a822f_d6c9633f
PS1, Line 128: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/142243df_0b127503
PS1, Line 129: trans_table[sample_nr][0] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5aa86f4b_b6691b3a
PS1, Line 130:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/daca533d_1e8a9b47
PS1, Line 131: pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d52ce12_ee6bc1fd
PS1, Line 132: pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6363531_5939f7b4
PS1, Line 133: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c8f10ee_52c82707
PS1, Line 134: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01a7cbd4_555a617a
PS1, Line 135: trans_table[sample_nr][1] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97241962_6e537e59
PS1, Line 136:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db0549c1_c8a60aa1
PS1, Line 137: pm_candidate1 = old_path_metrics[1] +input_symbol_imag -increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/babe4176_ae83a43b
PS1, Line 138: pm_candidate2 = old_path_metrics[9] +input_symbol_imag +increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23bd46af_53560d5d
PS1, Line 139: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cdbb9d2b_b0c7a82f
PS1, Line 140: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a0439cc_36217136
PS1, Line 141: trans_table[sample_nr][2] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/25d0ef96_19bd8222
PS1, Line 142:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8b0ea012_5995c6c1
PS1, Line 143: pm_candidate1 = old_path_metrics[1] -input_symbol_imag +increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f912019_ac03e311
PS1, Line 144: pm_candidate2 = old_path_metrics[9] -input_symbol_imag -increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a15be528_a897bd8f
PS1, Line 145: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b37e4cb8_ee3318ab
PS1, Line 146: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/806debc8_f6d15ea2
PS1, Line 147: trans_table[sample_nr][3] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57ac6b6f_1ee4dfc5
PS1, Line 148:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c7df3b6_81cc8209
PS1, Line 149: pm_candidate1 = old_path_metrics[2] +input_symbol_imag -increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da088555_ded10c14
PS1, Line 150: pm_candidate2 = old_path_metrics[10] +input_symbol_imag +increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83157fa7_09c8f80a
PS1, Line 151: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/910e9178_7f7bcac1
PS1, Line 152: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b22d38e_9d84bce2
PS1, Line 153: trans_table[sample_nr][4] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bdf9c4a_e5522f38
PS1, Line 154:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebff2b25_83ae7f1a
PS1, Line 155: pm_candidate1 = old_path_metrics[2] -input_symbol_imag +increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bea3a47_45fd5f62
PS1, Line 156: pm_candidate2 = old_path_metrics[10] -input_symbol_imag -increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be798fa5_d5db3c77
PS1, Line 157: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e152594_5d29253e
PS1, Line 158: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ab890a8_b2954ae3
PS1, Line 159: trans_table[sample_nr][5] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8b39d07_a7678662
PS1, Line 160:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7b65f96_dbc85c37
PS1, Line 161: pm_candidate1 = old_path_metrics[3] +input_symbol_imag -increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0403357_5fcb4b9e
PS1, Line 162: pm_candidate2 = old_path_metrics[11] +input_symbol_imag +increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/73d182f2_493afaae
PS1, Line 163: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be51455b_4acb4840
PS1, Line 164: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbef8ae0_2ec335f3
PS1, Line 165: trans_table[sample_nr][6] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c32c5ccb_4054fdc7
PS1, Line 166:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be6b0ea4_7acc8d72
PS1, Line 167: pm_candidate1 = old_path_metrics[3] -input_symbol_imag +increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8075dfe_4b6fe825
PS1, Line 168: pm_candidate2 = old_path_metrics[11] -input_symbol_imag -increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/20d5aa09_644fd319
PS1, Line 169: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa50915a_8b9415bc
PS1, Line 170: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4000dd9_95ca42ad
PS1, Line 171: trans_table[sample_nr][7] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43f47227_974d5c07
PS1, Line 172:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ee23460_b328f966
PS1, Line 173: pm_candidate1 = old_path_metrics[4] +input_symbol_imag -increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/083c2998_3b4703cd
PS1, Line 174: pm_candidate2 = old_path_metrics[12] +input_symbol_imag +increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9de0a49d_f96dc466
PS1, Line 175: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98579fa0_c74e8374
PS1, Line 176: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21fd1842_d710b1b9
PS1, Line 177: trans_table[sample_nr][8] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acd0ce29_c9a54276
PS1, Line 178:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95a34f67_daeece82
PS1, Line 179: pm_candidate1 = old_path_metrics[4] -input_symbol_imag +increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/34209d5d_c5f87a0b
PS1, Line 180: pm_candidate2 = old_path_metrics[12] -input_symbol_imag -increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/940f1793_a6c21a38
PS1, Line 181: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ddcd727_853e396f
PS1, Line 182: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46d645b7_e9dfbe21
PS1, Line 183: trans_table[sample_nr][9] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df0abbb5_178b6bab
PS1, Line 184:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95d9d47a_c5c4e898
PS1, Line 185: pm_candidate1 = old_path_metrics[5] +input_symbol_imag -increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/716eadb0_74a0e045
PS1, Line 186: pm_candidate2 = old_path_metrics[13] +input_symbol_imag +increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4ae42d8_b0202cd9
PS1, Line 187: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/622e603e_bc21d87e
PS1, Line 188: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c7cf284_d11c580a
PS1, Line 189: trans_table[sample_nr][10] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff18c9df_373fc333
PS1, Line 190:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17645e49_558da642
PS1, Line 191: pm_candidate1 = old_path_metrics[5] -input_symbol_imag +increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70a3e789_e2503545
PS1, Line 192: pm_candidate2 = old_path_metrics[13] -input_symbol_imag -increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3718558c_9d735f32
PS1, Line 193: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/beb36811_4e7febc8
PS1, Line 194: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18832505_ebd4d456
PS1, Line 195: trans_table[sample_nr][11] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c951bdb8_e9bd8da7
PS1, Line 196:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3210dcc_1734a0db
PS1, Line 197: pm_candidate1 = old_path_metrics[6] +input_symbol_imag -increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9bb16f29_a845f7a1
PS1, Line 198: pm_candidate2 = old_path_metrics[14] +input_symbol_imag +increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/efec955a_5f817a20
PS1, Line 199: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0bb68bc_f16cc533
PS1, Line 200: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a673b02d_b992bf5b
PS1, Line 201: trans_table[sample_nr][12] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/430fc63f_36777a8b
PS1, Line 202:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/beaeb508_038077a5
PS1, Line 203: pm_candidate1 = old_path_metrics[6] -input_symbol_imag +increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dfa064c_9139066e
PS1, Line 204: pm_candidate2 = old_path_metrics[14] -input_symbol_imag -increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d72a8f4_9aaf8d08
PS1, Line 205: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f821ca81_f9bff86a
PS1, Line 206: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b55896d_20d90eaa
PS1, Line 207: trans_table[sample_nr][13] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df7fac54_2af5ff62
PS1, Line 208:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bc1f9df_1e56f859
PS1, Line 209: pm_candidate1 = old_path_metrics[7] +input_symbol_imag -increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/854d12db_5d979823
PS1, Line 210: pm_candidate2 = old_path_metrics[15] +input_symbol_imag +increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2f67a7e_6b152a43
PS1, Line 211: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/159fa760_85d214cf
PS1, Line 212: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a668ab0_45feb57b
PS1, Line 213: trans_table[sample_nr][14] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f49e174e_47adbe6b
PS1, Line 214:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d84a0028_c5c4bcfe
PS1, Line 215: pm_candidate1 = old_path_metrics[7] -input_symbol_imag +increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52e3ac98_7d9eeee7
PS1, Line 216: pm_candidate2 = old_path_metrics[15] -input_symbol_imag -increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ff5a5c5_0e951b2b
PS1, Line 217: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05306f47_51aa311c
PS1, Line 218: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d22827c1_52c872f0
PS1, Line 219: trans_table[sample_nr][15] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5544e3d8_588d9bed
PS1, Line 220: tmp=old_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0254f4f0_e9803d1b
PS1, Line 221: old_path_metrics=new_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce898082_d795bb2b
PS1, Line 222: new_path_metrics=tmp;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/283006b3_d457865c
PS1, Line 223:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12e3ac69_fc4f382e
PS1, Line 224: sample_nr++;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fcffc68f_a7031af2
PS1, Line 225: if(sample_nr==samples_num)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4c93154_986a997e
PS1, Line 226: break;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8971bdf4_ae47ed96
PS1, Line 227:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e28ad15e_c48a96f4
PS1, Line 228: //Processing real states
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1e0b033_47465ab8
PS1, Line 229: real_imag=0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06ccfbc5_323e1354
PS1, Line 230: input_symbol_real = input[sample_nr].real();
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d2aab164_5c239432
PS1, Line 231:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9008c217_30a48ca2
PS1, Line 232: pm_candidate1 = old_path_metrics[0] -input_symbol_real -increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2620cc69_7d71c43c
PS1, Line 233: pm_candidate2 = old_path_metrics[8] -input_symbol_real +increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8e98f06_60674545
PS1, Line 234: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9fe0008_21664d5d
PS1, Line 235: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bba38c80_711d548c
PS1, Line 236: trans_table[sample_nr][0] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0d64d6c7_2f426423
PS1, Line 237:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67e86ded_626f116e
PS1, Line 238: pm_candidate1 = old_path_metrics[0] +input_symbol_real +increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6e72e17_e8df01dc
PS1, Line 239: pm_candidate2 = old_path_metrics[8] +input_symbol_real -increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fef25226_e9018d41
PS1, Line 240: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f06adfb9_dd60ceec
PS1, Line 241: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/add3b8f4_be962251
PS1, Line 242: trans_table[sample_nr][1] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/525b6b24_c4f3395a
PS1, Line 243:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d24e69ca_dca81121
PS1, Line 244: pm_candidate1 = old_path_metrics[1] -input_symbol_real -increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d5b482f7_114d0b57
PS1, Line 245: pm_candidate2 = old_path_metrics[9] -input_symbol_real +increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a090bab_12da33e2
PS1, Line 246: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8da9bced_b590a700
PS1, Line 247: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0072efca_ae7ff7b9
PS1, Line 248: trans_table[sample_nr][2] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8565e567_61fd0c46
PS1, Line 249:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13ce4532_94c26304
PS1, Line 250: pm_candidate1 = old_path_metrics[1] +input_symbol_real +increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5169946c_a27e0328
PS1, Line 251: pm_candidate2 = old_path_metrics[9] +input_symbol_real -increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/da530a0a_f3fea4b0
PS1, Line 252: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48b85f26_0f7fae73
PS1, Line 253: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f2180431_3bd4740a
PS1, Line 254: trans_table[sample_nr][3] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f7a31500_4a20d5e8
PS1, Line 255:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a16a65eb_3bf33f36
PS1, Line 256: pm_candidate1 = old_path_metrics[2] -input_symbol_real -increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61833c9e_2bfa4fce
PS1, Line 257: pm_candidate2 = old_path_metrics[10] -input_symbol_real +increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6300a8ea_c49daace
PS1, Line 258: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9352498a_0f497f37
PS1, Line 259: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2357b0cb_63206282
PS1, Line 260: trans_table[sample_nr][4] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/91600e2d_fc86990a
PS1, Line 261:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89ac36b5_673e510d
PS1, Line 262: pm_candidate1 = old_path_metrics[2] +input_symbol_real +increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d3312dc_6ea303e5
PS1, Line 263: pm_candidate2 = old_path_metrics[10] +input_symbol_real -increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3dbe6bd_56a1c404
PS1, Line 264: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79fdb15a_47209c68
PS1, Line 265: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/292c80a1_d79da118
PS1, Line 266: trans_table[sample_nr][5] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e2d30c8f_38ba362f
PS1, Line 267:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/50072ee6_1ed8187f
PS1, Line 268: pm_candidate1 = old_path_metrics[3] -input_symbol_real -increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed4f1d97_10adaef7
PS1, Line 269: pm_candidate2 = old_path_metrics[11] -input_symbol_real +increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d0189c2f_96e06e45
PS1, Line 270: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de6a123e_a6e325e1
PS1, Line 271: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e7feaa62_2f1cb8b3
PS1, Line 272: trans_table[sample_nr][6] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c5ea70ea_1657609a
PS1, Line 273:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/792ac9fb_5a7f0fd9
PS1, Line 274: pm_candidate1 = old_path_metrics[3] +input_symbol_real +increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8693d874_c825b97e
PS1, Line 275: pm_candidate2 = old_path_metrics[11] +input_symbol_real -increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ffaa48f5_fe693c13
PS1, Line 276: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/481fddff_5a106165
PS1, Line 277: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4674531_c036e809
PS1, Line 278: trans_table[sample_nr][7] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e4f75b4_bdbc3931
PS1, Line 279:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76a0e764_06d5cf8e
PS1, Line 280: pm_candidate1 = old_path_metrics[4] -input_symbol_real -increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/64b86e89_8d880ac4
PS1, Line 281: pm_candidate2 = old_path_metrics[12] -input_symbol_real +increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6d4b857_10ff2c99
PS1, Line 282: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79b96e41_e7dd9877
PS1, Line 283: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/665397dc_bd80f6a0
PS1, Line 284: trans_table[sample_nr][8] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87c1b180_7d637587
PS1, Line 285:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7aa54df3_37101eb5
PS1, Line 286: pm_candidate1 = old_path_metrics[4] +input_symbol_real +increment[3];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3325eb4a_663d3f60
PS1, Line 287: pm_candidate2 = old_path_metrics[12] +input_symbol_real -increment[4];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b38f1735_314ba8aa
PS1, Line 288: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b793811c_ee48e7be
PS1, Line 289: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15c6850e_62f59543
PS1, Line 290: trans_table[sample_nr][9] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/973531c9_69e6db25
PS1, Line 291:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/23e228f7_fb64e813
PS1, Line 292: pm_candidate1 = old_path_metrics[5] -input_symbol_real -increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b6f1a689_f2e2e6d9
PS1, Line 293: pm_candidate2 = old_path_metrics[13] -input_symbol_real +increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/893f8180_42a69f2b
PS1, Line 294: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9ede1ca_19439b87
PS1, Line 295: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ac2e66e_69b00f62
PS1, Line 296: trans_table[sample_nr][10] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/180d112b_532653c0
PS1, Line 297:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c852c0e_9866ccce
PS1, Line 298: pm_candidate1 = old_path_metrics[5] +input_symbol_real +increment[2];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ec994e3_b9f75bae
PS1, Line 299: pm_candidate2 = old_path_metrics[13] +input_symbol_real -increment[5];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eed40f1d_cc60bedb
PS1, Line 300: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/313a0128_a62c2133
PS1, Line 301: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/81ae8055_47c038b5
PS1, Line 302: trans_table[sample_nr][11] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b9978b6_da4e6f72
PS1, Line 303:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47e13116_c97d21e6
PS1, Line 304: pm_candidate1 = old_path_metrics[6] -input_symbol_real -increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fe10866a_3237147e
PS1, Line 305: pm_candidate2 = old_path_metrics[14] -input_symbol_real +increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9df8ae59_6416091d
PS1, Line 306: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/719e552b_d5e6ea7b
PS1, Line 307: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a95b823c_89072084
PS1, Line 308: trans_table[sample_nr][12] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e5e3eeb_066dbf86
PS1, Line 309:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/039130fb_769ef6eb
PS1, Line 310: pm_candidate1 = old_path_metrics[6] +input_symbol_real +increment[1];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38d3f4c6_04a6c7f3
PS1, Line 311: pm_candidate2 = old_path_metrics[14] +input_symbol_real -increment[6];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/91b2070e_0e03f83a
PS1, Line 312: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7bfb1152_6cb75672
PS1, Line 313: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32db60e2_8b277681
PS1, Line 314: trans_table[sample_nr][13] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b991cea_5cf7d1da
PS1, Line 315:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae45cadb_76fb5235
PS1, Line 316: pm_candidate1 = old_path_metrics[7] -input_symbol_real -increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d063cb9_2a8f68c2
PS1, Line 317: pm_candidate2 = old_path_metrics[15] -input_symbol_real +increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35382050_3a03a95d
PS1, Line 318: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37cc8b7d_361f72dd
PS1, Line 319: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c2839d7_9b6e3f20
PS1, Line 320: trans_table[sample_nr][14] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75cfe80b_ff9f05a9
PS1, Line 321:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5598d564_eec28d25
PS1, Line 322: pm_candidate1 = old_path_metrics[7] +input_symbol_real +increment[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0160bd6a_a6ad917f
PS1, Line 323: pm_candidate2 = old_path_metrics[15] +input_symbol_real -increment[7];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09cc86bd_57fc06e9
PS1, Line 324: paths_difference=pm_candidate2-pm_candidate1;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1152a7fb_1196bf26
PS1, Line 325: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ac36e45d_f58ec05c
PS1, Line 326: trans_table[sample_nr][15] = paths_difference;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9bda11c_0aca7720
PS1, Line 327:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc74852d_bd448fed
PS1, Line 328: tmp=old_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6fff0e8_1749cd26
PS1, Line 329: old_path_metrics=new_path_metrics;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e9bc89f_c48367bc
PS1, Line 330: new_path_metrics=tmp;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2f3ac20_8fecb2d7
PS1, Line 331:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8a70ed1_cc719f8a
PS1, Line 332: sample_nr++;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5762bd21_63eb39c5
PS1, Line 333: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/662bbd03_5b2dbc90
PS1, Line 334:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46c904af_c3e52303
PS1, Line 335: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45c70800_7cf59a3d
PS1, Line 336: * Find the best from the stop states by comparing their path metrics.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d9ae2b6_bed11905
PS1, Line 337: * Not every stop state is always possible, so we are searching in
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebacecb4_372ee6f4
PS1, Line 338: * a subset of them.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79e302d4_01880b9f
PS1, Line 339: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d26cdf3_0ed58a4e
PS1, Line 340: unsigned int best_stop_state;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c5713a8d_20a93206
PS1, Line 341: float stop_state_metric, max_stop_state_metric;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d1ae503_ad299835
PS1, Line 342: best_stop_state = stop_states[0];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6415217a_4228fdbf
PS1, Line 343: max_stop_state_metric = old_path_metrics[best_stop_state];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/986e109d_59eb2cac
PS1, Line 344: for(i=1; i< stops_num; i++){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca1b17a0_205b534e
PS1, Line 345: stop_state_metric = old_path_metrics[stop_states[i]];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8282d8d1_3ab5ffa0
PS1, Line 346: if(stop_state_metric > max_stop_state_metric){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2dabac3_6f99830d
PS1, Line 347: max_stop_state_metric = stop_state_metric;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09d0c6cc_33fe2c50
PS1, Line 348: best_stop_state = stop_states[i];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7732e0c2_9624dead
PS1, Line 349: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae66af10_6b98677d
PS1, Line 350: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6968f787_6108eb6d
PS1, Line 351:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e54dcf13_338084ae
PS1, Line 352: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03644ff4_5c840238
PS1, Line 353: * This table was generated with hope that it gives a litle speedup during
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4575d080_0bb273a5
PS1, Line 354: * traceback stage.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c51fa26a_742f789a
PS1, Line 355: * Received bit is related to the number of state in the trellis.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/965d3147_5307f43b
PS1, Line 356: * I've numbered states so their parity (number of ones) is related
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cf8fc63_a91d84da
PS1, Line 357: * to a received bit.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53205755_b9c3d0ce
PS1, Line 358: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b1e4f9e5_ff74a1f1
PS1, Line 359: static const unsigned int parity_table[PATHS_NUM] = { 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d07b1e73_1f5c1d74
PS1, Line 360:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19737de4_a357a571
PS1, Line 361: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aba66beb_a6996d3a
PS1, Line 362: * Table of previous states in the trellis diagram.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5b8d13d1_aff6be1f
PS1, Line 363: * For GMSK modulation every state has two previous states.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/25ab5e0a_3fc0df16
PS1, Line 364: * Example:
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b87da34_56f17026
PS1, Line 365: * previous_state_nr1 = prev_table[current_state_nr][0]
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4429ed4_98a42e0f
PS1, Line 366: * previous_state_nr2 = prev_table[current_state_nr][1]
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51895b1d_bb347523
PS1, Line 367: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dd4c77b_ceb52f8a
PS1, Line 368: static const unsigned int prev_table[PATHS_NUM][2] = { {0,8}, {0,8}, {1,9}, {1,9}, {2,10}, {2,10}, {3,11}, {3,11}, {4,12}, {4,12}, {5,13}, {5,13}, {6,14}, {6,14}, {7,15}, {7,15}, };
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bbf2031d_5f48e8fb
PS1, Line 369:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85ea2a49_ab90c2aa
PS1, Line 370: /*
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/289ef068_9dbb5de0
PS1, Line 371: * Traceback and differential decoding of received sequence.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5895a578_6d2a4c30
PS1, Line 372: * Decisions stored in trans_table are used to restore best path in the trellis.
trailing whitespace
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d2814559_93038728
PS1, Line 373: */
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/067ac8a2_8031e94e
PS1, Line 374: sample_nr=samples_num;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5cca4631_d2fa6338
PS1, Line 375: unsigned int state_nr=best_stop_state;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0aaddb9_cfbf046a
PS1, Line 376: unsigned int decision;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c1ab6ce_0c5814c4
PS1, Line 377: bool out_bit=0;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79843aac_9caf3bc8
PS1, Line 378:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba85b924_e05db597
PS1, Line 379: while(sample_nr>0){
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc7ee93b_4b25d8b4
PS1, Line 380: sample_nr--;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3477f6f_f956487c
PS1, Line 381: decision = (trans_table[sample_nr][state_nr]>0);
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d6af7b2c_e385cfde
PS1, Line 382:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3853e4db_bcd3a90f
PS1, Line 383: if(decision != out_bit)
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ba87194_c3d11a12
PS1, Line 384: output[sample_nr]=-trans_table[sample_nr][state_nr];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed25fef3_72c8019a
PS1, Line 385: else
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/81bc2acb_6edab099
PS1, Line 386: output[sample_nr]=trans_table[sample_nr][state_nr];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93bcd35f_846bd7f5
PS1, Line 387:
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95504d15_7ea9e435
PS1, Line 388: out_bit = out_bit ^ real_imag ^ parity_table[state_nr];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a22aa961_a22ae9ec
PS1, Line 389: state_nr = prev_table[state_nr][decision];
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72753e0c_48ca644c
PS1, Line 390: real_imag = !real_imag;
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d486fbc_1afa69b5
PS1, Line 391: }
DOS line endings
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1505):
https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13f52779_b79c4e7d
PS1, Line 392: }
DOS line endings
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f
Gerrit-Change-Number: 30415
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ill-fated ipcv2 for mstrx
by Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 )
Change subject: ill-fated ipcv2 for mstrx
......................................................................
Patch Set 1:
(232 comments)
File Transceiver52M/device/ipc2/IPCDevice.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/faf18f78_3b209a88
PS1, Line 40: protected:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/da8d7c47_5fd8a540
PS1, Line 41: std::vector<smpl_buf *> rx_buffers;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f69eb1be_69eaf196
PS1, Line 41: std::vector<smpl_buf *> rx_buffers;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b9107110_710b313e
PS1, Line 41: std::vector<smpl_buf *> rx_buffers;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cbbd83e0_d13e25d2
PS1, Line 41: std::vector<smpl_buf *> rx_buffers;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72a2874e_a3f1954f
PS1, Line 48: std::vector<double> tx_gains, rx_gains;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6979dd75_8841521b
PS1, Line 48: std::vector<double> tx_gains, rx_gains;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d05158dd_fb2c4e9e
PS1, Line 48: std::vector<double> tx_gains, rx_gains;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7db861c9_8de7fd5f
PS1, Line 57: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9e90e2aa_c0d4de9f
PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/88e59e92_82680afd
PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e73d2cce_f61ca6c4
PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e0507434_8aadde25
PS1, Line 60: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/08c161e8_bb98c15d
PS1, Line 64: virtual int open(const std::string &args, int ref, bool swap_channels) override;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/67482bc7_a94fb6e3
PS1, Line 67: virtual bool start() override;
Bad function definition - virtual bool start() should probably be virtual bool start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e878f243_24916a65
PS1, Line 70: virtual bool stop() override;
Bad function definition - virtual bool stop() should probably be virtual bool stop(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7df02f44_d668940e
PS1, Line 73: enum TxWindowType getWindowType() override
Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/992891d8_db1f3c9a
PS1, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/507b7ee6_79626fcf
PS1, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/caa4c961_e0b82ea9
PS1, Line 87: virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/41d143a0_80f7ded6
PS1, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/27ea8225_ec0d95cd
PS1, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/666021b0_eccdcd2e
PS1, Line 97: virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/49d88170_f87ddf0a
PS1, Line 98: TIMESTAMP timestamp = 0xffffffff) override;
Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3351f992_ffd7be67
PS1, Line 116: virtual double fullScaleInputValue() override
Bad function definition - virtual double fullScaleInputValue() should probably be virtual double fullScaleInputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/93771c33_90a1f643
PS1, Line 122: virtual double fullScaleOutputValue() override
Bad function definition - virtual double fullScaleOutputValue() should probably be virtual double fullScaleOutputValue(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a161827f_06e035fd
PS1, Line 154: virtual bool setRxAntenna(const std::string &ant, size_t chan = 0) override;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/4f0cb189_c3bd5331
PS1, Line 160: virtual bool setTxAntenna(const std::string &ant, size_t chan = 0) override;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a2b65b79_834023a0
PS1, Line 166: virtual bool requiresRadioAlign() override;
Bad function definition - virtual bool requiresRadioAlign() should probably be virtual bool requiresRadioAlign(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/03bedd64_63b903c6
PS1, Line 180: virtual inline double getSampleRate() override
Bad function definition - virtual inline double getSampleRate() should probably be virtual inline double getSampleRate(void)
File Transceiver52M/device/ipc2/ipcif.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1b4d5bbd_29008425
PS1, Line 35: using sample_t = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1b2b40b0_699fd266
PS1, Line 35: using sample_t = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/48cb7dde_91a4b7c2
PS1, Line 37: std::atomic<bool> ms_connected;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a3fbf5c4_9313d15b
PS1, Line 37: std::atomic<bool> ms_connected;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9d885201_4dc2bf4a
PS1, Line 37: std::atomic<bool> ms_connected;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a8e81637_e3113ace
PS1, Line 39: shm::sema r;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b692d8e5_30a41e2b
PS1, Line 40: shm::sema w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6cac1365_2d9e0cab
PS1, Line 41: std::atomic<uint64_t> ts;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/603a594a_36f213e5
PS1, Line 41: std::atomic<uint64_t> ts;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2f59e436_fe52c740
PS1, Line 41: std::atomic<uint64_t> ts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b7f1fc7a_69b1c861
PS1, Line 42: std::atomic<uint64_t> ts_req;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7e7ba404_581d44fa
PS1, Line 42: std::atomic<uint64_t> ts_req;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/48f357b6_912a4f3a
PS1, Line 42: std::atomic<uint64_t> ts_req;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/12ec6fd1_6ef7ee5f
PS1, Line 43: std::atomic<size_t> len_written_sps; // ->
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3564acc8_ebdd6fcf
PS1, Line 43: std::atomic<size_t> len_written_sps; // ->
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d59929e4_6c981aca
PS1, Line 43: std::atomic<size_t> len_written_sps; // ->
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f682e3dc_f23fb5ca
PS1, Line 47: shm::sema r;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/47c17d48_8e5fa5fb
PS1, Line 48: shm::sema w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b930362b_8721c36e
PS1, Line 49: std::atomic<uint64_t> ts;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9f982104_deeec94a
PS1, Line 49: std::atomic<uint64_t> ts;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b8074b27_515476bf
PS1, Line 49: std::atomic<uint64_t> ts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c4f0433a_2a4a6394
PS1, Line 50: std::atomic<uint64_t> ts_req;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5e4c73e8_82739732
PS1, Line 50: std::atomic<uint64_t> ts_req;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/62830640_67a1c69d
PS1, Line 50: std::atomic<uint64_t> ts_req;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/590e9e5c_da6c4596
PS1, Line 51: std::atomic<size_t> len_written_sps;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9ad3d947_9b8fda3c
PS1, Line 51: std::atomic<size_t> len_written_sps;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/032ab91f_f574d9aa
PS1, Line 51: std::atomic<size_t> len_written_sps;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6f137bf4_7a1585c7
PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89bb5ddb_d9b18b04
PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/54d96d29_df6d3e34
PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5a6c5c6e_4d8a0841
PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9c61ab70_a8449ad0
PS1, Line 58: template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f34afbd6_a839699a
PS1, Line 60: using stype = typename std::make_signed<A>::type;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/36db1e31_f6681fab
PS1, Line 60: using stype = typename std::make_signed<A>::type;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7ece2b1d_4f899fb8
PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b001c953_7656615f
PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ff41568e_d7fd9071
PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2e69f945_32b57171
PS1, Line 61: return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c3a56e88_be00741e
PS1, Line 90: template <unsigned int num_bursts> class ulburstprovider {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/310e18b9_633a28e2
PS1, Line 90: template <unsigned int num_bursts> class ulburstprovider {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/975d32e8_d6acda13
PS1, Line 91: std::mutex ul_q_m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8c6ff45c_7a7398e3
PS1, Line 98: void cur_buf_done()
Bad function definition - void cur_buf_done() should probably be void cur_buf_done(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/abe16f1d_66a88857
PS1, Line 98: void cur_buf_done()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/99e0c51a_1dd96696
PS1, Line 103: bool is_empty()
Bad function definition - bool is_empty() should probably be bool is_empty(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/98a2aa1c_27d25c70
PS1, Line 103: bool is_empty()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/de023be0_d76497e8
PS1, Line 107: void reset()
Bad function definition - void reset() should probably be void reset(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/57c93392_307d6a96
PS1, Line 107: void reset()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd616170_033aaccb
PS1, Line 109: for (auto &i : foo)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96f7b2bd_3b06f62d
PS1, Line 113: ulentry &find_free_at_end()
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9cb1d4fe_bd0fbddf
PS1, Line 123: void push_back(ulentry &e)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f4c3864a_cd39c420
PS1, Line 123: void push_back(ulentry &e)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/75a0769a_a22c2094
PS1, Line 130: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/673db00e_ce570434
PS1, Line 131: void add(ulentry &e)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/39da4ffa_71b81bcc
PS1, Line 131: void add(ulentry &e)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c785a7e0_498f33d0
PS1, Line 133: std::lock_guard<std::mutex> foo(ul_q_m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d714364e_44e3059b
PS1, Line 133: std::lock_guard<std::mutex> foo(ul_q_m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/49418a20_21c97e5b
PS1, Line 133: std::lock_guard<std::mutex> foo(ul_q_m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/deb7feac_97c57f8d
PS1, Line 136: void get(uint64_t requested_ts, unsigned int req_len_in_sps, sample_t *buf, unsigned int max_buf_write_len)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0afc5520_5c14c39f
PS1, Line 138: std::lock_guard<std::mutex> g(ul_q_m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5cb43d88_00d8b808
PS1, Line 138: std::lock_guard<std::mutex> g(ul_q_m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e94aae72_ce5fccdf
PS1, Line 138: std::lock_guard<std::mutex> g(ul_q_m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c995a2a1_b3a813bd
PS1, Line 203: shm::shm<shm_if> m;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e50c228d_f4bb6911
PS1, Line 203: shm::shm<shm_if> m;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/78164afb_a2619e0e
PS1, Line 203: shm::shm<shm_if> m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cd209117_38482000
PS1, Line 206: ulburstprovider<10> p;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/783d6c2d_b32df518
PS1, Line 206: ulburstprovider<10> p;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/136259d0_54500fb7
PS1, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/46bfa34c_21bacf57
PS1, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/56a7c510_8c1402bb
PS1, Line 208: template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3f08fdbd_df063cbe
PS1, Line 217: shm::mtx_log::print_guard() << "\tr @" << direction.ts.load() << " " << readoffset_sps << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5deb2d8e_bdcb2b5d
PS1, Line 235: shm::mtx_log::print_guard() << "\tr+ " << *read_ts << " " << howmany_sps << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/56c7c09f_37751282
PS1, Line 247: shm::mtx_log::print_guard() << "\tr++ " << *read_ts << " " << howmany_sps << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/81437850_877af9b7
PS1, Line 249: } else {
else is not generally useful after a break or return
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/95d532c2_9ba61f3e
PS1, Line 263: shm::mtx_log::print_guard()
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e1bd5e81_5f0fe87d
PS1, Line 270: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab367ed9_735f408d
PS1, Line 275: bool create()
Bad function definition - bool create() should probably be bool create(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c1f7f3f3_24ee5f6d
PS1, Line 275: bool create()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/99d97af4_c10dfc68
PS1, Line 281: bool connect()
Bad function definition - bool connect() should probably be bool connect(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8a569ff6_0ad86d1b
PS1, Line 281: bool connect()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f60377a1_0fc6fdc9
PS1, Line 289: bool good()
Bad function definition - bool good() should probably be bool good(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6353524e_0c0bd3e3
PS1, Line 289: bool good()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/80475acb_8ed1ec9b
PS1, Line 293: bool is_connected()
Bad function definition - bool is_connected() should probably be bool is_connected(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c7155efd_5931a8f7
PS1, Line 293: bool is_connected()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/38122db5_c4a32d88
PS1, Line 299: void read_dl(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/418406bb_06ce036a
PS1, Line 305: void read_ul(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f0f33af9_290941f5
PS1, Line 309: // return;
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/54a026bc_a08db990
PS1, Line 314: void write_dl(size_t howmany_sps, uint64_t write_ts, sample_t *inbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0a0cc41d_b082e43e
PS1, Line 316: auto &dl = ptr->dl;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e2c028bf_9be23356
PS1, Line 325: shm::sema_wait_guard g(dl.w, dl.r);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/03b0fc44_b8f56c2b
PS1, Line 331: shm::mtx_log::print_guard() << std::endl
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/50c3d639_1a937ad2
PS1, Line 336: void write_ul(size_t howmany_sps_sps, uint64_t write_ts, sample_t *inbuf)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b049e060_0a12ff93
PS1, Line 338: auto &ul = ptr->ul;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/794dac31_79323e42
PS1, Line 351: shm::mtx_log::print_guard() << std::endl
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fd9b08bb_e5225a11
PS1, Line 356: void drive_tx()
Bad function definition - void drive_tx() should probably be void drive_tx(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/61488fb1_bba7f263
PS1, Line 356: void drive_tx()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c4bd8fba_ed7fd4dc
PS1, Line 358: auto &ul = ptr->ul;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6b54fe19_23780f4a
PS1, Line 384: void signal_read_start()
Bad function definition - void signal_read_start() should probably be void signal_read_start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a4da10c3_f74d5e2b
PS1, Line 384: void signal_read_start()
open brace '{' following function definitions go on the next line
File Transceiver52M/device/ipc2/shmif.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1b7dbc6a_2d4f9e8f
PS1, Line 46: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8c083523_82714d9b
PS1, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/591ce811_b64ba584
PS1, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/022a0800_235c9a1b
PS1, Line 49: std::lock_guard<std::mutex> guard(thread_print_lock);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2cb0a9f6_be0a9126
PS1, Line 50: std::cerr << str();
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72933e3a_24cd22d4
PS1, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96f42e91_3d10bb14
PS1, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/02eb618e_74874020
PS1, Line 57: template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/79d2b144_36b28c4c
PS1, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &))
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5b9516d2_3a29038a
PS1, Line 62: constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &))
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b608f401_5d461917
PS1, Line 73: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3c72ab1d_b46c6541
PS1, Line 89: void lock()
Bad function definition - void lock() should probably be void lock(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6168b6f6_4d5cd647
PS1, Line 89: void lock()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8082436a_e82146a0
PS1, Line 94: bool try_lock()
Bad function definition - bool try_lock() should probably be bool try_lock(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9eb03bf6_daa5a3ce
PS1, Line 94: bool try_lock()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/813b617d_bb0810b5
PS1, Line 99: void unlock()
Bad function definition - void unlock() should probably be void unlock(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6bbc2f6a_411cf0d0
PS1, Line 99: void unlock()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/def2b641_14fc2dd4
PS1, Line 104: pthread_mutex_t *p()
Bad function definition - pthread_mutex_t *p() should probably be pthread_mutex_t *p(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/df47252f_076a8602
PS1, Line 104: pthread_mutex_t *p()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/564a05c0_fcddf8bd
PS1, Line 109: shmmutex &operator=(const shmmutex &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9039e2e5_e026b35e
PS1, Line 109: shmmutex &operator=(const shmmutex &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/47f1348e_f41ef512
PS1, Line 115: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c12647c3_a69ff939
PS1, Line 130: void wait(shmmutex *lock)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/817489f5_f3742b53
PS1, Line 135: void signal()
Bad function definition - void signal() should probably be void signal(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/72f3323f_713e300b
PS1, Line 135: void signal()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/da823f35_64c3271f
PS1, Line 140: void signal_all()
Bad function definition - void signal_all() should probably be void signal_all(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ef8323e7_7a935b3f
PS1, Line 140: void signal_all()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ba8b3c75_7fa86b2f
PS1, Line 145: shmcond &operator=(const shmcond &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/712164c8_b2de9079
PS1, Line 145: shmcond &operator=(const shmcond &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1d29dca2_b85af691
PS1, Line 149: shmmutex &m;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6f9dd390_d74f1a12
PS1, Line 150: shmcond &s;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/af20f095_f52d6222
PS1, Line 152: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/76139a73_55e8ee36
PS1, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ca08be2f_47f41cf7
PS1, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/631d17b5_d496185f
PS1, Line 154: explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/61331542_bca4d452
PS1, Line 165: signal_guard &operator=(const signal_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/143d0c12_df9be473
PS1, Line 165: signal_guard &operator=(const signal_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/140c1c80_8900a9f9
PS1, Line 169: shmmutex &m;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/78512a2d_c31bf64b
PS1, Line 171: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/db6dab36_89a9406f
PS1, Line 173: explicit mutex_guard(shmmutex &m) : m(m)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d4d22ab8_1fb85e1b
PS1, Line 182: mutex_guard &operator=(const mutex_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a8e03339_5da0763a
PS1, Line 182: mutex_guard &operator=(const mutex_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/701b2f6d_1cf99a77
PS1, Line 186: std::atomic<int> value;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/854190c8_6e5e987a
PS1, Line 186: std::atomic<int> value;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/93503d51_ba408a55
PS1, Line 186: std::atomic<int> value;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7721f677_8a237cff
PS1, Line 190: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ce064d68_e8213f4a
PS1, Line 198: void wait()
Bad function definition - void wait() should probably be void wait(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f651b64d_11bd25a4
PS1, Line 198: void wait()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2259fecb_442146bc
PS1, Line 202: void wait(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fdba8b0a_00a6ad2a
PS1, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/45dbaaab_da28562f
PS1, Line 204: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1abede98_ca99a563
PS1, Line 205: mutex_guard g(m);
function definition argument 'm' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/80952fea_25547cb1
PS1, Line 210: void wait_and_reset()
Bad function definition - void wait_and_reset() should probably be void wait_and_reset(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6ea7712a_38e72f42
PS1, Line 210: void wait_and_reset()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/595bbe7b_6cfba558
PS1, Line 214: void wait_and_reset(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/157d4220_2d5c47d7
PS1, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/dd063074_14221f5e
PS1, Line 216: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cc84898d_20baf114
PS1, Line 217: mutex_guard g(m);
function definition argument 'm' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/f4400fd8_d06be084
PS1, Line 223: void set()
Bad function definition - void set() should probably be void set(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/e70912a4_4629ec31
PS1, Line 223: void set()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/01aa0533_7b069011
PS1, Line 227: void set(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/0282c5de_60b08046
PS1, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c5676052_f0b4fd61
PS1, Line 229: mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d004ea89_93e83d9c
PS1, Line 230: mutex_guard g(m);
function definition argument 'm' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/3d65daef_d35a76d9
PS1, Line 234: void reset_unsafe()
Bad function definition - void reset_unsafe() should probably be void reset_unsafe(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/23fa7cfb_86288edb
PS1, Line 234: void reset_unsafe()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/6020f137_521133fd
PS1, Line 238: bool check_unsafe(int v)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/8af80bdc_8687baed
PS1, Line 243: sema &operator=(const sema &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/81d5d6c8_2b443de6
PS1, Line 243: sema &operator=(const sema &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/69a924e9_8b2dafd8
PS1, Line 247: sema &a;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/cfbbe01d_32e26ff2
PS1, Line 248: sema &b;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/995dd13e_5957bcf1
PS1, Line 250: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a0315420_729979e4
PS1, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9c09e1ff_32fbd6cf
PS1, Line 252: explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/89c213e4_f9242f39
PS1, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/999672fc_5e31a25a
PS1, Line 261: sema_wait_guard &operator=(const sema_wait_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7c630848_2193cf4b
PS1, Line 265: sema &a;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a74e400b_ea4b3e69
PS1, Line 266: sema &b;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/10b57a15_4a4479c4
PS1, Line 268: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/afc3dd65_953719c4
PS1, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a3b06361_b9300cae
PS1, Line 270: explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/2f7d5271_57395807
PS1, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete;
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/9e3d3262_f923306d
PS1, Line 279: sema_signal_guard &operator=(const sema_signal_guard &) = delete;
spaces required around that '=' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d4edb02b_409eb610
PS1, Line 282: template <typename IFT> class shm {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/00a7e5a6_69b1d24d
PS1, Line 282: template <typename IFT> class shm {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b18896f4_6e759e1e
PS1, Line 287: int ipc_shm_setup(const char *shm_name)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/1a0503dc_9dd1f393
PS1, Line 293: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) {
Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/29dc7ec8_e2a85cbd
PS1, Line 310: shmptr = new (ptr) IFT(); //static_cast<IFT *>(ptr);
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/96430888_d69dbf40
PS1, Line 315: int ipc_shm_connect(const char *shm_name)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/99bd7396_b995416b
PS1, Line 321: if ((fd = shm_open(shm_name, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR)) < 0) {
Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/93482a09_4be20edf
PS1, Line 339: shmptr = static_cast<IFT *>(ptr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/5f50bb97_4450ea8f
PS1, Line 339: shmptr = static_cast<IFT *>(ptr);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d735996c_a35a65ba
PS1, Line 339: shmptr = static_cast<IFT *>(ptr);
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ab39457b_0ece9f1f
PS1, Line 344: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/7840db88_5ce8d4ca
PS1, Line 348: strncpy((char *)shmname, name, 512);
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b7cc284a_d9bfb239
PS1, Line 350: void create()
Bad function definition - void create() should probably be void create(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/a48f2fd9_8b9db6b1
PS1, Line 350: void create()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/d10aa3e7_1993c519
PS1, Line 355: void open()
Bad function definition - void open() should probably be void open(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/186221ff_5aa1f0ce
PS1, Line 355: void open()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/c2e3cabd_4e83605d
PS1, Line 360: bool isgood() const
Bad function definition - bool isgood() should probably be bool isgood(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/87617113_0c31b708
PS1, Line 364: void close()
Bad function definition - void close() should probably be void close(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/b4456f6b_48c15615
PS1, Line 364: void close()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/ad6daf91_32144a1e
PS1, Line 369: IFT *p()
Bad function definition - IFT *p() should probably be IFT *p(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1504):
https://gerrit.osmocom.org/c/osmo-trx/+/30414/comment/fd443659_128f8239
PS1, Line 369: IFT *p()
open brace '{' following function definitions go on the next line
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ms-trx support
by Jenkins Builder
Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
Patch Set 1:
(408 comments)
File Transceiver52M/ms/bladerf_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/301ce7d7_7ed6cfc8
PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08a8afc4_5b2ba3a8
PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16f36076_513dd188
PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01bea4ec_7230dc08
PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e675d0e6_9718d66d
PS1, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
spaces required around that '&&' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5faf79a_84304375
PS1, Line 44: out << '(' << std::forward<Arg>(arg);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d908d42_6f5f60e4
PS1, Line 44: out << '(' << std::forward<Arg>(arg);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78a8f0f8_8acb2a5c
PS1, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... };
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/154531ec_43bf2cde
PS1, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... };
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01981329_f3ce9af4
PS1, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
space prohibited between function name and open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9bdb9cf7_821efbf4
PS1, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d62cfb92_211c1bd5
PS1, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b8bdcb9_52667f40
PS1, Line 52: template <class R, class... Args>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8c4edfe7_52cefc12
PS1, Line 52: template <class R, class... Args>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fe1db58_e9836067
PS1, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line,
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6318e05a_3dfef53f
PS1, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line,
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf6dd794_9c27d17a
PS1, Line 56: R rval = func(std::forward<Args>(args)...);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d9721a3_6e2ef504
PS1, Line 56: R rval = func(std::forward<Args>(args)...);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6056e394_536aaf0d
PS1, Line 57: if (rval != 0) {
suspect code indent for conditional statements (8, 26)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c962abe7_b164aa10
PS1, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':'
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ece88b78_e0e5d340
PS1, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__)
__func__ should be used instead of gcc specific __FUNCTION__
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c28afd41_2c4456c7
PS1, Line 69: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f06d08e5_93a83bba
PS1, Line 69: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63189dea_e3d1bf5d
PS1, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6bb5aadd_f6b619ce
PS1, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf012ab9_6309c48e
PS1, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!");
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22a249c9_50bd86e8
PS1, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!");
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/02cd1b21_7fbb7b12
PS1, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!");
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8ab72df_407feeac
PS1, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!");
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1ee1ccdf_2b1f1909
PS1, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/939af6a4_2bd3faf0
PS1, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d1567216_e6f68775
PS1, Line 82: blade_usb_message<T> m[SZ];
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f6105ea_616e26f6
PS1, Line 82: blade_usb_message<T> m[SZ];
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/964463cd_bc433ceb
PS1, Line 83: int actual_samples_per_msg()
Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3efd1c5f_b4984842
PS1, Line 83: int actual_samples_per_msg()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d8120ba_fd063611
PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82e0e1de_488c5df7
PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6008f4ec_00c212c4
PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fd6c900_8504f04f
PS1, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78132836_ee953dfb
PS1, Line 87: int actual_samples_per_buffer()
Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/051277aa_a37eb15d
PS1, Line 87: int actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/01769f58_01a1e64d
PS1, Line 91: int samples_per_buffer()
Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efaef42d_2999ba4f
PS1, Line 91: int samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a0db27b_e000b09e
PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7b58e8a_e317eef3
PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxB)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81a562ef_ef4b8e0d
PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28c9fe46_6c129f82
PS1, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/53cb9e14_51e8a58d
PS1, Line 95: int num_msgs_per_buffer()
Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36b12ae6_46146924
PS1, Line 95: int num_msgs_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3f1ee94_8bcc0572
PS1, Line 99: auto get_first_ts()
Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85ca58f5_9d382110
PS1, Line 99: auto get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d2a2315b_47c10ed6
PS1, Line 103: constexpr auto *getsampleoffset(int ofs)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2314ebc0_685e4e43
PS1, Line 109: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b32c82b2_39ed8ae0
PS1, Line 118: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99edde0b_8692f8c3
PS1, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1166ba10_a7a7409a
PS1, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31e3b4c4_f1eabc7a
PS1, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f40f8255_59b4032c
PS1, Line 178: static blade_otw_buffer<SZ / 512, T> x;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb22ab73_89802fee
PS1, Line 178: static blade_otw_buffer<SZ / 512, T> x;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9baee26d_ccd18a3a
PS1, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80dc2994_8f4c8263
PS1, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x);
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8de2500_2077d78b
PS1, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a799672_df328cf9
PS1, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59f92ec7_5e6e79da
PS1, Line 185: template <typename T> struct blade_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e6d41f75_7ec4f481
PS1, Line 185: template <typename T> struct blade_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab4a0d97_0588984c
PS1, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c8110999_33b766d0
PS1, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/195b14fa_d79e36d2
PS1, Line 202: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9773256d_6a1e9558
PS1, Line 223: void close_device()
Bad function definition - void close_device() should probably be void close_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e75d2bb_3626816b
PS1, Line 223: void close_device()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05f36874_985c3bd0
PS1, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6aa3c78e_119ba458
PS1, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/573e0a61_ba791209
PS1, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual;
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b2d90d2e_d49ff7bf
PS1, Line 250: std::cerr << "open failed, device missing?" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71208f5e_a2f62333
PS1, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f377375_694adc76
PS1, Line 271: std::cerr << "unable to lock refclk!" << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f089d25_ec2a22df
PS1, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f287a6d_69d65a2a
PS1, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/09dbe486_e5c9f1e3
PS1, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e8ca0784_f15328d8
PS1, Line 316: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a991272f_7f9c64fb
PS1, Line 318: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9053bb89_aac2f11d
PS1, Line 320: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4de598a_3094df6a
PS1, Line 323: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcc4ecf9_a88fde9c
PS1, Line 325: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14cd08b2_8411d9cb
PS1, Line 327: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76303387_3fcf4894
PS1, Line 330: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/149efb8c_a7d66365
PS1, Line 335: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4ebe99d_7f028b9f
PS1, Line 338: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6eb53714_f95a6f41
PS1, Line 340: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cbdd29d5_2025ad77
PS1, Line 343: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3dd9e8a7_b78dadb8
PS1, Line 346: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cd5d26d4_3b495644
PS1, Line 348: msleep(15);
msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/521602c2_c630e488
PS1, Line 351: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f6ae613_ab4da7df
PS1, Line 356: static void check_timestamp(dev_buf_t *rcd)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/30b84aeb_5cda4ea7
PS1, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) {
suspect code indent for conditional statements (16, 34)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/174ad80b_de954a6a
PS1, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " "
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a20ad618_fa1c6192
PS1, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20b1d771_b671fdd8
PS1, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f54cab92_218d1e0b
PS1, Line 377: void *samples, size_t num_samples, void *user_data) -> void * {
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58ee0d83_a0ca2729
PS1, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9ecf1219_d61b1067
PS1, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3c379c0_45f13802
PS1, Line 397: void *samples, size_t num_samples, void *user_data) -> void * {
spaces prohibited around that '->' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e310768_126066e9
PS1, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bda9e2f_b43cef6b
PS1, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47ca03f3_efc013a3
PS1, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1567cc5e_7c6f90b5
PS1, Line 410: auto fn = [this] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63aab3aa_eb97a5b4
PS1, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aa56d10f_03ae9cf5
PS1, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/545e5612_aaf912c3
PS1, Line 422: auto fn = [this] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/08fd9bc4_2fb9d25a
PS1, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25cb3aa6_d6683eb8
PS1, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/14fac554_de2c2187
PS1, Line 435: //get empty bufer from list
'bufer' may be misspelled - perhaps 'buffer'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9db1e49a_ea6fe9d4
PS1, Line 436: tx_buf_q_type::elem_t rcd;
labels should not be indented
File Transceiver52M/ms/ipc_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c54bbdf6_d4cdeb06
PS1, Line 38: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/daf18400_2bed079c
PS1, Line 38: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e22466e9_0769f938
PS1, Line 45: auto actual_samples_per_buffer()
Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e54dab24_2d28d3db
PS1, Line 45: auto actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0afc2910_b9eab8c8
PS1, Line 49: long get_first_ts()
Bad function definition - long get_first_ts() should probably be long get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/466329d2_bafb9e77
PS1, Line 49: long get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56feb6f9_d962ea9a
PS1, Line 53: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f23088c8_f7a8757a
PS1, Line 58: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b7e6417_609ce6e0
PS1, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db770060_9d26b5d4
PS1, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/691248ab_6fe4bddd
PS1, Line 71: template <typename T> struct ipc_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44b9787b_5bbce496
PS1, Line 71: template <typename T> struct ipc_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80aa389c_e1406a4f
PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d6a19bcc_3e60def3
PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37d938aa_aa1898b3
PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb7b1257_2acce708
PS1, Line 76: std::vector<blade_sample_type *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c75148b7_56fa1bd2
PS1, Line 92: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ffa89cb7_f7f058b4
PS1, Line 99: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7d55c422_a3be8e50
PS1, Line 106: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f39a0a03_78f9706f
PS1, Line 111: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2fd44612_70f63f64
PS1, Line 119: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9315089b_76fd5027
PS1, Line 127: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a6e065d_07da1742
PS1, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f9b607a_f3f9f282
PS1, Line 137: void *rx_cb(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d17e052_5c95c31e
PS1, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf };
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75764492_cbd4b50d
PS1, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf };
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3d69e3c_2e5f84d1
PS1, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1a19c76a_be13c44b
PS1, Line 166: auto fn = [this, burst_handler] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6b9df0_58f5c06a
PS1, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb923f6b_6e18e1ea
PS1, Line 177: auto fn = [] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05c7bf4e_5ef5ea00
PS1, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86894aa3_698fbb39
PS1, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a39540d_7992d228
PS1, Line 193: void signal_start()
Bad function definition - void signal_start() should probably be void signal_start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/beab08b0_65c5e97e
PS1, Line 193: void signal_start()
open brace '{' following function definitions go on the next line
File Transceiver52M/ms/itrq.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a40b1748_e9aeafb8
PS1, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf58fb03_4671cd1d
PS1, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efb5b464_6d81a601
PS1, Line 52: std::condition_variable cond_r, cond_w;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b9af9f8_b6615fe6
PS1, Line 53: std::mutex lr, lw;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63ace79c_56b17246
PS1, Line 54: std::atomic_int r_flag, w_flag;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/192ee704_54eb2b0e
PS1, Line 56: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d51d3ccf_1d47342d
PS1, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0)
Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e52fe76_801f2d65
PS1, Line 65: ssize_t spsc_check_r()
Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/472302d0_59b7a8b0
PS1, Line 65: ssize_t spsc_check_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0d76b57_36c4a98d
PS1, Line 67: std::unique_lock<std::mutex> lk(lr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7e365ea_635201f2
PS1, Line 67: std::unique_lock<std::mutex> lk(lr);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc0265fd_3dd08d08
PS1, Line 67: std::unique_lock<std::mutex> lk(lr);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ecc82fbe_a0eb1403
PS1, Line 73: ssize_t spsc_check_w()
Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/25c38939_4f8c7beb
PS1, Line 73: ssize_t spsc_check_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18e8412b_e65d2f31
PS1, Line 75: std::unique_lock<std::mutex> lk(lw);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8616ff9f_553740c9
PS1, Line 75: std::unique_lock<std::mutex> lk(lw);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb8f3d1c_03c86f0e
PS1, Line 75: std::unique_lock<std::mutex> lk(lw);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c89dac6_b2c1ca27
PS1, Line 81: void spsc_notify_r()
Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9aaba957_d3160e5f
PS1, Line 81: void spsc_notify_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7795df8_16d48f24
PS1, Line 83: std::unique_lock<std::mutex> lk(lr);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a3786239_1f8f5e35
PS1, Line 83: std::unique_lock<std::mutex> lk(lr);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b57715ee_68fbdb6a
PS1, Line 83: std::unique_lock<std::mutex> lk(lr);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1c47424_1ff2e83d
PS1, Line 87: void spsc_notify_w()
Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e81bdba3_6f2be5fa
PS1, Line 87: void spsc_notify_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8dc3426a_275a3870
PS1, Line 89: std::unique_lock<std::mutex> lk(lw);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78ed56bb_2cf51434
PS1, Line 89: std::unique_lock<std::mutex> lk(lw);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e3459026_207c06ac
PS1, Line 89: std::unique_lock<std::mutex> lk(lw);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/abc3dabb_9fbc75ea
PS1, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/05284692_ea8ea07f
PS1, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e79ca070_8187c70f
PS1, Line 99: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/597f2530_557ca964
PS1, Line 100: explicit spsc_efd_detail()
Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1498c20_ad3e294f
PS1, Line 111: ssize_t spsc_check_r()
Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9be71eb_027f43b3
PS1, Line 111: ssize_t spsc_check_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32796c89_19706f34
PS1, Line 116: ssize_t spsc_check_w()
Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d8a04bd_b4735503
PS1, Line 116: ssize_t spsc_check_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e766b06_09664752
PS1, Line 121: void spsc_notify_r()
Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/634adde1_8f337d61
PS1, Line 121: void spsc_notify_r()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47a6e82e_5e696a25
PS1, Line 126: void spsc_notify_w()
Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfb5eeba_28410b4e
PS1, Line 126: void spsc_notify_w()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f435ccf3_c56467fc
PS1, Line 131: int get_r_efd()
Bad function definition - int get_r_efd() should probably be int get_r_efd(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9249a9c_5ddc9c44
PS1, Line 131: int get_r_efd()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c48de86e_dbe7f5bf
PS1, Line 135: int get_w_efd()
Bad function definition - int get_w_efd() should probably be int get_w_efd(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c8c731e_05308e1d
PS1, Line 135: int get_w_efd()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9721164e_d5ed5b39
PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/079a3f73_233d02bf
PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/28806554_53dcc5ba
PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/702271f9_353206e8
PS1, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7aaa8c5_73b12601
PS1, Line 142: class spsc : public T<block_read, block_write> {
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99493986_53707b94
PS1, Line 142: class spsc : public T<block_read, block_write> {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e120f5e1_1f726d8d
PS1, Line 144: std::atomic<unsigned int> readptr;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d34b077d_291a6d7b
PS1, Line 144: std::atomic<unsigned int> readptr;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5961918_7982c4e4
PS1, Line 144: std::atomic<unsigned int> readptr;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7dd54bef_600af7ac
PS1, Line 145: std::atomic<unsigned int> writeptr;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7d0b0481_9a8c641e
PS1, Line 145: std::atomic<unsigned int> writeptr;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc79892b_c5365fac
PS1, Line 145: std::atomic<unsigned int> writeptr;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c535969_2ec0d346
PS1, Line 149: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/16e8844f_8e97353c
PS1, Line 150: using base_t = T<block_read, block_write>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fe2bc7d_0f9e003a
PS1, Line 150: using base_t = T<block_read, block_write>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/305ce30f_8f70a680
PS1, Line 152: explicit spsc() : readptr(0), writeptr(0)
Bad function definition - explicit spsc() should probably be explicit spsc(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56737532_d05bfc8a
PS1, Line 163: bool spsc_push(const ELEM *elem)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d6b04f7_469b17b9
PS1, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b83b97ee_892c276f
PS1, Line 176: base_t::spsc_notify_r(); /* fine after release */
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/71f9b123_cbbecd2a
PS1, Line 183: bool spsc_pop(ELEM *elem)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9b80b366_e2b56d3f
PS1, Line 195: base_t::spsc_notify_w();
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3043ddd_dc9801a1
PS1, Line 202: ssize_t spsc_prep_pop()
Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f4299147_3f6cba0e
PS1, Line 202: ssize_t spsc_prep_pop()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3454dde2_151969dc
PS1, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c08a57a9_61392d71
PS1, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4993ba93_f02177fd
PS1, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {};
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fdbbd050_9a1c24e5
PS1, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {};
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/15a8fb04_4e3bd526
PS1, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5fc6db9c_1a0aa9b9
PS1, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4cde2496_56afe477
PS1, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
adding a line without newline at end of file
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35b6ce23_e973a6df
PS1, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78d7f45f_56d9f026
PS1, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
spaces required around that '>' (ctx:VxW)
File Transceiver52M/ms/logging.cpp:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58c0929e_df0ee555
PS1, Line 83: .enabled = 0,
trailing whitespace
File Transceiver52M/ms/ms.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d65ecbf8_d8376c7b
PS1, Line 34: #define BASET blade_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d39d9f27_d057b972
PS1, Line 34: #define BASET blade_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/41a86583_973a21ae
PS1, Line 37: #define BASET uhd_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e72dde31_db26f166
PS1, Line 37: #define BASET uhd_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df6b1bde_2c32d5d6
PS1, Line 40: #define BASET ipc_hw<ms_trx>
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d139ca74_0208ec25
PS1, Line 40: #define BASET ipc_hw<ms_trx>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ec87ccbe_9a214938
PS1, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dfcc88f7_a74109cc
PS1, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f34dfc8_cb6137b8
PS1, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max)
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/935c1713_b3ab6a52
PS1, Line 60: template <typename DST_T, typename SRC_T, typename ST>
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79e68de3_a992c7ea
PS1, Line 60: template <typename DST_T, typename SRC_T, typename ST>
spaces required around that '>' (ctx:VxE)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd3e5b7a_54045c3f
PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8394694_12b06794
PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d076a1d5_d1529c37
PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/aae9ce48_d916d378
PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6499b796_7a43c2dd
PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d21e3e47_71098a72
PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c88434a5_56af990a
PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18da3d8b_d478c0fd
PS1, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
spaces required around that '>' (ctx:OxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44e72462_eca7d6ef
PS1, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len)
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f501fa47_666e4273
PS1, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len)
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/64d83cde_dd7b4229
PS1, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc376c22_743b138a
PS1, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR);
spaces required around that '>' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/215d7852_373306e5
PS1, Line 75: GSM::Time gsmts;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8ff77589_9618d4c7
PS1, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8be4f8d_0ca85f71
PS1, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/04a95bba_e4d28e0a
PS1, Line 87: std::ostream null_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/27aff2c7_d975e140
PS1, Line 89: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a9d17a6_5942e9e5
PS1, Line 90: dummylog() : null_stream(this){};
space required before the open brace '{'
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a49bd9f9_d80107e8
PS1, Line 92: std::ostream &operator()()
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19fdc277_761b7e19
PS1, Line 92: std::ostream &operator()()
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ceac5ba1_4c895bfd
PS1, Line 104: GSM::Time global_time_keeper;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03e2889e_9e2d54d2
PS1, Line 106: std::mutex m;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9a60dd8_b04b4a44
PS1, Line 108: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a7bc769_ef60a158
PS1, Line 113: void set(GSM::Time t, int64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/873483ae_dccf9053
PS1, Line 115: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b69d80a4_978c49f8
PS1, Line 115: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/87c52991_b77df29b
PS1, Line 115: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b137272_6db2b612
PS1, Line 119: void inc_both()
Bad function definition - void inc_both() should probably be void inc_both(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/454a7caf_5da9472c
PS1, Line 119: void inc_both()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/efc9b098_7bb34677
PS1, Line 121: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/42c29045_751d8254
PS1, Line 121: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e655276f_b4fa02f6
PS1, Line 121: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fcf9df63_1ebf32e9
PS1, Line 125: void inc_and_update(int64_t new_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5e18186c_a4619166
PS1, Line 127: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f94053bf_7d33d025
PS1, Line 127: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7799adbd_b1473cfd
PS1, Line 127: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48375d69_29d5e966
PS1, Line 132: void inc_and_update_safe(int64_t new_ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82d3b2c2_acd4f8b2
PS1, Line 134: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b9a470c6_3ed35c52
PS1, Line 134: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e116a931_c5dad632
PS1, Line 134: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/083ebfa3_43edb5f3
PS1, Line 142: void dec_by_one()
Bad function definition - void dec_by_one() should probably be void dec_by_one(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44f97cd9_9b3a3442
PS1, Line 142: void dec_by_one()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86c34a2a_4d61a9eb
PS1, Line 144: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c05abb3e_af917fb5
PS1, Line 144: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8046fd7_16ea16ee
PS1, Line 144: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/584e27f5_35d7917c
PS1, Line 148: auto get_ts()
Bad function definition - auto get_ts() should probably be auto get_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4853b4c9_c236d8ae
PS1, Line 148: auto get_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/767ee6a6_b921d194
PS1, Line 150: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e43f29ce_da3ead7c
PS1, Line 150: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/370bb821_67accdcf
PS1, Line 150: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/94073af6_8d8236fa
PS1, Line 153: auto gsmtime()
Bad function definition - auto gsmtime() should probably be auto gsmtime(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1101986_18019820
PS1, Line 153: auto gsmtime()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/12a8413c_7ffbfbb2
PS1, Line 155: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60621d30_673401e6
PS1, Line 155: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3eb5ac7_e6140418
PS1, Line 155: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/499d4927_9d705bdb
PS1, Line 158: void get_both(GSM::Time *t, int64_t *ts)
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3de5e2b6_ec4766e3
PS1, Line 158: void get_both(GSM::Time *t, int64_t *ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b375110_6df9083f
PS1, Line 160: std::lock_guard<std::mutex> g(m);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9e3760e1_ae2f7b53
PS1, Line 160: std::lock_guard<std::mutex> g(m);
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/82255939_8eb3d8e8
PS1, Line 160: std::lock_guard<std::mutex> g(m);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80c6c57b_cf59499b
PS1, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f541de2_fadc0f76
PS1, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8f031d52_44e76319
PS1, Line 176: std::thread rx_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/616999b9_7d2882b0
PS1, Line 177: std::thread tx_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cbd69a0_75cd13e3
PS1, Line 178: std::thread *calcrval_task;
need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5504c484_a550396d
PS1, Line 178: std::thread *calcrval_task;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5c0ef1ab_c9091643
PS1, Line 189: std::atomic<bool> rcv_done;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f89b471_26bbc774
PS1, Line 189: std::atomic<bool> rcv_done;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23077ac2_968434a0
PS1, Line 189: std::atomic<bool> rcv_done;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/591305be_a83102aa
PS1, Line 190: std::atomic<bool> sch_thread_done;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1dee4091_864b6e01
PS1, Line 190: std::atomic<bool> sch_thread_done;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1223e246_e4152e6e
PS1, Line 190: std::atomic<bool> sch_thread_done;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/925f126b_54dfd381
PS1, Line 197: void start();
Bad function definition - void start() should probably be void start(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/19d6c92e_31f71adc
PS1, Line 198: std::atomic<bool> upper_is_ready;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/deeb7108_8c37f669
PS1, Line 198: std::atomic<bool> upper_is_ready;
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1b08c2ef_837e7a81
PS1, Line 198: std::atomic<bool> upper_is_ready;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f217aa7_b1dc2fe7
PS1, Line 201: bool handle_sch_or_nb();
Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7d33626_0ed06c08
PS1, Line 207: int init_device();
Bad function definition - int init_device() should probably be int init_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/965dac1a_30824d87
PS1, Line 208: int init_dev_and_streams();
Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/67805988_665e05fa
PS1, Line 209: void stop_threads();
Bad function definition - void stop_threads() should probably be void stop_threads(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/44d50bf2_5149fa16
PS1, Line 211: void *tx_cb();
Bad function definition - void *tx_cb() should probably be void *tx_cb(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/381a128c_7e83dcbb
PS1, Line 212: void maybe_update_gain(one_burst &brst);
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c13b9979_e8e86a4c
PS1, Line 225: bh_fn_t rx_bh();
Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad808354_f86047e5
PS1, Line 226: bh_fn_t tx_bh();
Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60a2ad9d_c5f6d991
PS1, Line 229: void set_ta(int val)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cf418435_bbf337ae
PS1, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83b1961e_6f811538
PS1, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype,
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c5183d2_c2df9c6b
PS1, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/801d5967_6774036d
PS1, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno);
labels should not be indented
File Transceiver52M/ms/ms_rx_burst.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c56c7cc_7fa218ab
PS1, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale);
adding a line without newline at end of file
File Transceiver52M/ms/ms_upper.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7213c8f_edc77838
PS1, Line 44: bool driveControl();
Bad function definition - bool driveControl() should probably be bool driveControl(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f06cbdcf_c0dc974f
PS1, Line 45: void driveReceiveFIFO();
Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3cfdc50_42432fb3
PS1, Line 46: void driveTx();
Bad function definition - void driveTx() should probably be void driveTx(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af574952_68c5ab1a
PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e7e5a58d_eb955538
PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a1cea60e_5d2e21b3
PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48741846_45c4d958
PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
function definition argument 'int' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83e3fb27_0b4e5b29
PS1, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
function definition argument 'int' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b94c85e1_52fd85bc
PS1, Line 50: std::thread thr_control, thr_rx, thr_tx;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/455cb909_eabbcc02
PS1, Line 52: public:
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e67088d9_69e1dccb
PS1, Line 53: void start_threads();
Bad function definition - void start_threads() should probably be void start_threads(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bc68e2d_7259925d
PS1, Line 54: void start_lower_ms();
Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61211e94_6dd40260
PS1, Line 56: upper_trx(){};
space required before the open brace '{'
File Transceiver52M/ms/sch.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/443eed6e_9706ba60
PS1, Line 130: int gsm_fcch_check_ts(int ts, int fn) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/125adda5_fb3963f0
PS1, Line 134: int gsm_sch_check_ts(int ts, int fn) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9352bb4b_4be9805a
PS1, Line 205: #if 1
Consider removing the #if 1 and its #endif
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f275701b_8fba1c0d
PS1, Line 210: float a, b, c, d, ang, avg = 0.0f;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f6defda_fabd227a
PS1, Line 235: ang = b - a;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5a340882_2f3bfee6
PS1, Line 237: if (ang > M_PI)
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/654de55d_8ba7a168
PS1, Line 238: ang -= 2 * M_PI;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/561454a4_ae39c6ba
PS1, Line 239: else if (ang < -M_PI)
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/11fca725_2be43cf7
PS1, Line 240: ang += 2 * M_PI;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5683fa52_0d94b7b6
PS1, Line 242: avg += ang;
'ang' may be misspelled - perhaps 'and'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6bd3bd59_6d216316
PS1, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f5610906_ac7aee74
PS1, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6ee80b5d_9239c3c2
PS1, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/732121ab_9ecc6408
PS1, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
"foo* bar" should be "foo *bar"
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5b43028c_59b07a90
PS1, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/77c0945a_25d8c39d
PS1, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8dc9e9f_7ccd5f21
PS1, Line 314: static __attribute__((constructor)) void init()
Bad function definition - void init() should probably be void init(void)
File Transceiver52M/ms/uhd_specific.h:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d08b327a_9f8b7b2c
PS1, Line 35: using blade_sample_type = std::complex<int16_t>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bb2cf9c1_2ae6e05c
PS1, Line 35: using blade_sample_type = std::complex<int16_t>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3b26fec6_360059e4
PS1, Line 41: uhd::rx_metadata_t *md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/94cda8ec_519594ab
PS1, Line 43: auto actual_samples_per_buffer()
Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/413b8ea4_d5889f9d
PS1, Line 43: auto actual_samples_per_buffer()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ddea827_cf4c8b35
PS1, Line 47: long get_first_ts()
Bad function definition - long get_first_ts() should probably be long get_first_ts(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/848f2347_92c71b88
PS1, Line 47: long get_first_ts()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/57ccc6fc_1d2c0ddd
PS1, Line 51: int readall(blade_sample_type *outaddr)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fc70be74_28c9067c
PS1, Line 56: int read_n(blade_sample_type *outaddr, int start, int num)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/09971353_e75781c8
PS1, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c278d934_928a93b9
PS1, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>;
spaces required around that '>' (ctx:VxO)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d67521a_f2a981f0
PS1, Line 69: template <typename T> struct uhd_hw {
spaces required around that '<' (ctx:WxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/637f711c_332bbaa4
PS1, Line 69: template <typename T> struct uhd_hw {
spaces required around that '>' (ctx:VxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3261757c_e2608a3a
PS1, Line 70: uhd::usrp::multi_usrp::sptr dev;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f222fdfe_04b7ab37
PS1, Line 71: uhd::rx_streamer::sptr rx_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f2e0bff_55255261
PS1, Line 72: uhd::tx_streamer::sptr tx_stream;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f719c36c_eedc9d24
PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c0868317_7a81547c
PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f6bb05f_982f250a
PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0acc953_ae9e35b3
PS1, Line 74: std::vector<blade_sample_type *> pkt_ptrs;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a90de279_f6609c98
PS1, Line 90: void close_device()
Bad function definition - void close_device() should probably be void close_device(void)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6a75ba3_3383e88f
PS1, Line 90: void close_device()
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/314b1835_9e689fe6
PS1, Line 95: bool tuneTx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9748f253_40f167a0
PS1, Line 102: bool tuneRx(double freq, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f8e216c_3b3c0b4c
PS1, Line 109: bool tuneRxOffset(double offset, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/096aaaf1_ba77b8be
PS1, Line 114: double setRxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/824eab77_c6bc3e68
PS1, Line 122: double setTxGain(double dB, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/474c972a_6a419c16
PS1, Line 130: int setPowerAttenuation(int atten, size_t chan = 0)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9439b519_ec31eef5
PS1, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/79def50a_00a498a1
PS1, Line 145: std::string args = {};
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7517389a_cfc54473
PS1, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/412385d4_b19b17be
PS1, Line 153: uhd::tune_request_t tune_request(freq, 0);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c92c8e7a_41d13972
PS1, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms));
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17c4a48c_746015e4
PS1, Line 164: uhd::stream_args_t stream_args("sc16", "sc16");
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a4a0234e_a2c96c33
PS1, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16");
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/74376215_85e3f7a0
PS1, Line 177: void *rx_cb(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a73375dc_dff67b05
PS1, Line 182: uhd::rx_metadata_t md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfb4eb24_3af1105e
PS1, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1e88918_6b8dcda2
PS1, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4d5e215b_1a083e50
PS1, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror());
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/055c876c_4b8756b2
PS1, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b05aa8bf_58b9bd3f
PS1, Line 211: auto fn = [this, burst_handler] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/606a84e7_809d91c3
PS1, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/270d661e_e7c27982
PS1, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7cb63d98_67d20081
PS1, Line 227: auto fn = [] {
space prohibited before open square bracket '['
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2daa4ac5_88f74c48
PS1, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
open brace '{' following function definitions go on the next line
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18dfb3e0_9ca9aaa1
PS1, Line 234: uhd::tx_metadata_t m = {};
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ab5d0165_f821b4ed
PS1, Line 239: std::vector<void *> ptrs(1, buffer);
spaces required around that '<' (ctx:VxV)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3edc6ee2_b42f5263
PS1, Line 239: std::vector<void *> ptrs(1, buffer);
need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/481e9f1b_787d70a5
PS1, Line 239: std::vector<void *> ptrs(1, buffer);
spaces required around that '>' (ctx:OxW)
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff1995f3_4e0ced24
PS1, Line 239: std::vector<void *> ptrs(1, buffer);
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a660f80_6cdd329b
PS1, Line 243: uhd::async_metadata_t async_md;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/64a23066_d5d2cbc0
PS1, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl;
labels should not be indented
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1502):
https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c3680243_929f7ba0
PS1, Line 251: };
adding a line without newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Comment-Date: Thu, 01 Dec 2022 11:01:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: vita demod by piotr krysik, modified
by Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 )
Change subject: vita demod by piotr krysik, modified
......................................................................
vita demod by piotr krysik, modified
Had a few rounds of extensive cleanup. Uses gcc multiversioning for x86
targets.
Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f
---
A Transceiver52M/grgsm_vitac/constants.h
A Transceiver52M/grgsm_vitac/grgsm_vitac.cpp
A Transceiver52M/grgsm_vitac/grgsm_vitac.h
A Transceiver52M/grgsm_vitac/viterbi_detector.cc
A Transceiver52M/grgsm_vitac/viterbi_detector.h
5 files changed, 959 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/15/30415/1
diff --git a/Transceiver52M/grgsm_vitac/constants.h b/Transceiver52M/grgsm_vitac/constants.h
new file mode 100644
index 0000000..0bcfd59
--- /dev/null
+++ b/Transceiver52M/grgsm_vitac/constants.h
@@ -0,0 +1,142 @@
+#pragma once
+/* -*- c++ -*- */
+/*
+ * @file
+ * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com>
+ * @section LICENSE
+ *
+ * Gr-gsm is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3, or (at your option)
+ * any later version.
+ *
+ * Gr-gsm is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with gr-gsm; see the file COPYING. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include <complex>
+
+#define gr_complex std::complex<float>
+
+
+#define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second
+#define GSM_SYMBOL_PERIOD (1.0/GSM_SYMBOL_RATE) //seconds per symbol
+
+//Burst timing
+#define TAIL_BITS 3
+#define GUARD_BITS 8
+#define GUARD_FRACTIONAL 0.25 //fractional part of guard period
+#define GUARD_PERIOD GUARD_BITS + GUARD_FRACTIONAL
+#define DATA_BITS 57 //size of 1 data block in normal burst
+#define STEALING_BIT 1
+#define N_TRAIN_BITS 26
+#define N_SYNC_BITS 64
+#define USEFUL_BITS 142 //(2*(DATA_BITS+STEALING_BIT) + N_TRAIN_BITS )
+#define FCCH_BITS USEFUL_BITS
+#define BURST_SIZE (USEFUL_BITS+2*TAIL_BITS)
+#define ACCESS_BURST_SIZE 88
+#define PROCESSED_CHUNK BURST_SIZE+2*GUARD_PERIOD
+
+#define SCH_DATA_LEN 39
+#define TS_BITS (TAIL_BITS+USEFUL_BITS+TAIL_BITS+GUARD_BITS) //a full TS (156 bits)
+#define TS_PER_FRAME 8
+#define FRAME_BITS (TS_PER_FRAME * TS_BITS + 2) // 156.25 * 8
+#define FCCH_POS TAIL_BITS
+#define SYNC_POS (TAIL_BITS + 39)
+#define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence
+ //aren't used for channel impulse response estimation
+#define TRAIN_BEGINNING 5
+#define SAFETY_MARGIN 6 //
+
+#define FCCH_HITS_NEEDED (USEFUL_BITS - 4)
+#define FCCH_MAX_MISSES 1
+#define FCCH_MAX_FREQ_OFFSET 100
+
+#define CHAN_IMP_RESP_LENGTH 5
+
+#define MAX_SCH_ERRORS 10 //maximum number of subsequent sch errors after which gsm receiver goes to find_next_fcch state
+
+typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type;
+typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type;
+
+static const unsigned char SYNC_BITS[] = {
+ 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0,
+ 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1,
+ 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1,
+ 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1
+};
+
+const unsigned FCCH_FRAMES[] = { 0, 10, 20, 30, 40 };
+const unsigned SCH_FRAMES[] = { 1, 11, 21, 31, 41 };
+
+const unsigned BCCH_FRAMES[] = { 2, 3, 4, 5 }; //!!the receiver shouldn't care about logical
+ //!!channels so this will be removed from this header
+const unsigned TEST_CCH_FRAMES[] = { 2, 3, 4, 5, 6, 7, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 22, 23, 24, 25, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39, 42, 43, 44, 45, 46, 47, 48, 49 };
+const unsigned TRAFFIC_CHANNEL_F[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24 };
+const unsigned TEST51[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50 };
+
+
+#define TSC0 0
+#define TSC1 1
+#define TSC2 2
+#define TSC3 3
+#define TSC4 4
+#define TSC5 5
+#define TSC6 6
+#define TSC7 7
+#define TS_DUMMY 8
+
+#define TRAIN_SEQ_NUM 9
+
+#define TIMESLOT0 0
+#define TIMESLOT1 1
+#define TIMESLOT2 2
+#define TIMESLOT3 3
+#define TIMESLOT4 4
+#define TIMESLOT5 5
+#define TIMESLOT6 6
+#define TIMESLOT7 7
+
+
+static const unsigned char train_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS] = {
+ {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
+ {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1},
+ {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0},
+ {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0},
+ {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1},
+ {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0},
+ {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1},
+ {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0},
+ {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY
+};
+
+
+//Dummy burst 0xFB 76 0A 4E 09 10 1F 1C 5C 5C 57 4A 33 39 E9 F1 2F A8
+static const unsigned char dummy_burst[] = {
+ 0, 0, 0,
+ 1, 1, 1, 1, 1, 0, 1, 1, 0, 1,
+ 1, 1, 0, 1, 1, 0, 0, 0, 0, 0,
+ 1, 0, 1, 0, 0, 1, 0, 0, 1, 1,
+ 1, 0, 0, 0, 0, 0, 1, 0, 0, 1,
+ 0, 0, 0, 1, 0, 0, 0, 0, 0, 0,
+ 0, 1, 1, 1, 1, 1, 0, 0,
+
+ 0, 1, 1, 1, 0, 0, 0, 1, 0, 1,
+ 1, 1, 0, 0, 0, 1, 0, 1, 1, 1,
+ 0, 0, 0, 1, 0, 1,
+
+ 0, 1, 1, 1, 0, 1, 0, 0, 1, 0,
+ 1, 0, 0, 0, 1, 1, 0, 0, 1, 1,
+ 0, 0, 1, 1, 1, 0, 0, 1, 1, 1,
+ 1, 0, 1, 0, 0, 1, 1, 1, 1, 1,
+ 0, 0, 0, 1, 0, 0, 1, 0, 1, 1,
+ 1, 1, 1, 0, 1, 0, 1, 0,
+ 0, 0, 0
+};
diff --git a/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp
new file mode 100644
index 0000000..aa2ab6f
--- /dev/null
+++ b/Transceiver52M/grgsm_vitac/grgsm_vitac.cpp
@@ -0,0 +1,299 @@
+/* -*- c++ -*- */
+/*
+ * @file
+ * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com>
+ * @author Contributions by sysmocom - s.f.m.c. GmbH / Eric Wild <ewild(a)sysmocom.de>
+ * @section LICENSE
+ *
+ * Gr-gsm is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3, or (at your option)
+ * any later version.
+ *
+ * Gr-gsm is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with gr-gsm; see the file COPYING. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include "constants.h"
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+#include <complex>
+
+
+#include <algorithm>
+#include <string.h>
+#include <iostream>
+#include <numeric>
+#include <vector>
+#include <fstream>
+
+#include "viterbi_detector.h"
+#include "grgsm_vitac.h"
+
+//signalVector mChanResp;
+gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst
+gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst
+const int d_chan_imp_length = CHAN_IMP_RESP_LENGTH;
+
+void initvita() {
+
+ /**
+ * Prepare SCH sequence bits
+ *
+ * (TS_BITS + 2 * GUARD_PERIOD)
+ * Burst and two guard periods
+ * (one guard period is an arbitrary overlap)
+ */
+ gmsk_mapper(SYNC_BITS, N_SYNC_BITS,
+ d_sch_training_seq, gr_complex(0.0, -1.0));
+ for (auto &i : d_sch_training_seq)
+ i = conj(i);
+
+ /* Prepare bits of training sequences */
+ for (int i = 0; i < TRAIN_SEQ_NUM; i++) {
+ /**
+ * If first bit of the sequence is 0
+ * => first symbol is 1, else -1
+ */
+ gr_complex startpoint = train_seq[i][0] == 0 ?
+ gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0);
+ gmsk_mapper(train_seq[i], N_TRAIN_BITS,
+ d_norm_training_seq[i], startpoint);
+ for (auto &i : d_norm_training_seq[i])
+ i = conj(i);
+ }
+
+}
+
+MULTI_VER_TARGET_ATTR
+void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary)
+{
+ std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR);
+ unsigned int stop_states[2] = { 4, 12 };
+ gr_complex filtered_burst[BURST_SIZE];
+ gr_complex rhh[CHAN_IMP_RESP_LENGTH];
+ float output[BURST_SIZE];
+ int start_state = 3;
+
+ // if(burst_start < 0 ||burst_start > 10)
+ // fprintf(stderr, "bo %d\n", burst_start);
+
+ // burst_start = burst_start >= 0 ? burst_start : 0;
+
+ autocorrelation(chan_imp_resp, &rhh_temp[0], d_chan_imp_length * d_OSR);
+ for (int ii = 0; ii < d_chan_imp_length; ii++)
+ rhh[ii] = conj(rhh_temp[ii * d_OSR]);
+
+ mafi(&input[burst_start], BURST_SIZE, chan_imp_resp,
+ d_chan_imp_length * d_OSR, filtered_burst);
+
+ viterbi_detector(filtered_burst, BURST_SIZE, rhh,
+ start_state, stop_states, 2, output);
+
+ for (int i = 0; i < BURST_SIZE; i++)
+ output_binary[i] = output[i] * -127; // pre flip bits!
+}
+
+void
+gmsk_mapper(const unsigned char* input,
+ int nitems, gr_complex* gmsk_output, gr_complex start_point)
+{
+ gr_complex j = gr_complex(0.0, 1.0);
+ gmsk_output[0] = start_point;
+
+ int previous_symbol = 2 * input[0] - 1;
+ int current_symbol;
+ int encoded_symbol;
+
+ for (int i = 1; i < nitems; i++) {
+ /* Change bits representation to NRZ */
+ current_symbol = 2 * input[i] - 1;
+
+ /* Differentially encode */
+ encoded_symbol = current_symbol * previous_symbol;
+
+ /* And do GMSK mapping */
+ gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0)
+ * gmsk_output[i - 1];
+
+ previous_symbol = current_symbol;
+ }
+}
+
+gr_complex
+correlate_sequence(const gr_complex* sequence,
+ int length, const gr_complex* input)
+{
+ gr_complex result(0.0, 0.0);
+
+ for (int ii = 0; ii < length; ii++)
+ result += sequence[ii] * input[ii * d_OSR];
+
+ return conj(result) / gr_complex(length, 0);
+}
+
+/* Computes autocorrelation for positive arguments */
+inline void
+autocorrelation(const gr_complex* input,
+ gr_complex* out, int nitems)
+{
+ for (int k = nitems - 1; k >= 0; k--) {
+ out[k] = gr_complex(0, 0);
+ for (int i = k; i < nitems; i++)
+ out[k] += input[i] * conj(input[i - k]);
+ }
+}
+
+inline void
+mafi(const gr_complex* input, int nitems,
+ gr_complex* filter, int filter_length, gr_complex* output)
+{
+ for (int n = 0; n < nitems; n++) {
+ int a = n * d_OSR;
+ output[n] = 0;
+
+ for (int ii = 0; ii < filter_length; ii++) {
+ if ((a + ii) >= nitems * d_OSR)
+ break;
+
+ output[n] += input[a + ii] * filter[ii];
+ }
+ }
+}
+
+int get_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, int search_center, int search_start_pos,
+ int search_stop_pos, gr_complex *tseq, int tseqlen, float *corr_max)
+{
+ std::vector<gr_complex> correlation_buffer;
+ std::vector<float> window_energy_buffer;
+ std::vector<float> power_buffer;
+
+ for (int ii = search_start_pos; ii < search_stop_pos; ii++) {
+ gr_complex correlation = correlate_sequence(tseq, tseqlen, &input[ii]);
+ correlation_buffer.push_back(correlation);
+ power_buffer.push_back(std::pow(abs(correlation), 2));
+ }
+
+ int strongest_corr_nr = max_element(power_buffer.begin(), power_buffer.end()) - power_buffer.begin();
+
+ /* Compute window energies */
+ auto window_energy_start_offset = strongest_corr_nr - 6 * d_OSR;
+ window_energy_start_offset = window_energy_start_offset < 0 ? 0 : window_energy_start_offset; //can end up out of range..
+ auto window_energy_end_offset = strongest_corr_nr + 6 * d_OSR + d_chan_imp_length * d_OSR;
+ auto iter = power_buffer.begin() + window_energy_start_offset;
+ auto iter_end = power_buffer.begin() + window_energy_end_offset;
+ while (iter != iter_end) {
+ std::vector<float>::iterator iter_ii = iter;
+ bool loop_end = false;
+ float energy = 0;
+
+ int len = d_chan_imp_length * d_OSR;
+ for (int ii = 0; ii < len; ii++, iter_ii++) {
+ if (iter_ii == power_buffer.end()) {
+ loop_end = true;
+ break;
+ }
+
+ energy += (*iter_ii);
+ }
+
+ if (loop_end)
+ break;
+
+ window_energy_buffer.push_back(energy);
+ iter++;
+ }
+
+ /* Calculate the strongest window number */
+ int strongest_window_nr = window_energy_start_offset +
+ max_element(window_energy_buffer.begin(), window_energy_buffer.end()) -
+ window_energy_buffer.begin();
+
+ // auto window_search_start = window_energy_buffer.begin() + strongest_corr_nr - 5* d_OSR;
+ // auto window_search_end = window_energy_buffer.begin() + strongest_corr_nr + 10* d_OSR;
+ // window_search_end = window_search_end >= window_energy_buffer.end() ? window_energy_buffer.end() : window_search_end;
+
+ // /* Calculate the strongest window number */
+ // int strongest_window_nr = max_element(window_search_start, window_search_end /* - d_chan_imp_length * d_OSR*/) - window_energy_buffer.begin();
+
+ // if (strongest_window_nr < 0)
+ // strongest_window_nr = 0;
+
+ float max_correlation = 0;
+ for (int ii = 0; ii < d_chan_imp_length * d_OSR; ii++) {
+ gr_complex correlation = correlation_buffer[strongest_window_nr + ii];
+ if (abs(correlation) > max_correlation)
+ max_correlation = abs(correlation);
+ chan_imp_resp[ii] = correlation;
+ }
+
+ *corr_max = max_correlation;
+
+ /**
+ * Compute first sample position, which corresponds
+ * to the first sample of the impulse response
+ */
+ return search_start_pos + strongest_window_nr - search_center * d_OSR;
+}
+
+/*
+
+3 + 57 + 1 + 26 + 1 + 57 + 3 + 8.25
+
+search center = 3 + 57 + 1 + 5 (due to tsc 5+16+5 split)
+this is +-5 samples around (+5 beginning) of truncated t16 tsc
+
+*/
+int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc)
+{
+ const int search_center = TRAIN_POS;
+ const int search_start_pos = (search_center - 5) * d_OSR + 1;
+ const int search_stop_pos = (search_center + 5 + d_chan_imp_length) * d_OSR;
+ const auto tseq = &d_norm_training_seq[bcc][TRAIN_BEGINNING];
+ const auto tseqlen = N_TRAIN_BITS - (2 * TRAIN_BEGINNING);
+ return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen,
+ corr_max);
+}
+
+/*
+
+3 tail | 39 data | 64 tsc | 39 data | 3 tail | 8.25 guard
+start 3+39 - 10
+end 3+39 + SYNC_SEARCH_RANGE
+
+*/
+int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp)
+{
+ const int search_center = SYNC_POS + TRAIN_BEGINNING;
+ const int search_start_pos = (search_center - 10) * d_OSR;
+ const int search_stop_pos = (search_center + SYNC_SEARCH_RANGE) * d_OSR;
+ const auto tseq = &d_sch_training_seq[TRAIN_BEGINNING];
+ const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING);
+
+ // strongest_window_nr + chan_imp_resp_center + SYNC_POS *d_OSR - 48 * d_OSR - 2 * d_OSR + 2 ;
+ float corr_max;
+ return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen,
+ &corr_max);
+}
+
+int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max)
+{
+ const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING);
+ const int search_center = SYNC_POS + TRAIN_BEGINNING;
+ const int search_start_pos = 0;
+ // FIXME: proper end offset
+ const int search_stop_pos = len - (N_SYNC_BITS*8);
+ auto tseq = &d_sch_training_seq[TRAIN_BEGINNING];
+
+ return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen,
+ corr_max);
+}
\ No newline at end of file
diff --git a/Transceiver52M/grgsm_vitac/grgsm_vitac.h b/Transceiver52M/grgsm_vitac/grgsm_vitac.h
new file mode 100644
index 0000000..41fe4b6
--- /dev/null
+++ b/Transceiver52M/grgsm_vitac/grgsm_vitac.h
@@ -0,0 +1,62 @@
+#pragma once
+/* -*- c++ -*- */
+/*
+ * @file
+ * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com>
+ * @section LICENSE
+ *
+ * Gr-gsm is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3, or (at your option)
+ * any later version.
+ *
+ * Gr-gsm is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with gr-gsm; see the file COPYING. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+#include <vector>
+#include "constants.h"
+
+#if defined(__has_attribute)
+#if __has_attribute(target_clones) && defined(__x86_64) && true
+#define MULTI_VER_TARGET_ATTR __attribute__((target_clones("avx", "sse4.2", "sse3", "sse2", "sse", "default")))
+#else
+#define MULTI_VER_TARGET_ATTR
+#endif
+#endif
+
+#define SYNC_SEARCH_RANGE 30
+const int d_OSR(4);
+
+void initvita();
+
+int process_vita_burst(gr_complex *input, int tsc, unsigned char *output_binary);
+int process_vita_sc_burst(gr_complex *input, int tsc, unsigned char *output_binary, int *offset);
+
+MULTI_VER_TARGET_ATTR
+void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary);
+void gmsk_mapper(const unsigned char *input, int nitems, gr_complex *gmsk_output, gr_complex start_point);
+gr_complex correlate_sequence(const gr_complex *sequence, int length, const gr_complex *input);
+inline void autocorrelation(const gr_complex *input, gr_complex *out, int nitems);
+inline void mafi(const gr_complex *input, int nitems, gr_complex *filter, int filter_length, gr_complex *output);
+int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp);
+int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc);
+int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max);
+
+enum class btype { NB, SCH };
+struct fdata {
+ btype t;
+ unsigned int fn;
+ int tn;
+ int bcc;
+ std::string fpath;
+ std::vector<gr_complex> data;
+ unsigned int data_start_offset;
+};
\ No newline at end of file
diff --git a/Transceiver52M/grgsm_vitac/viterbi_detector.cc b/Transceiver52M/grgsm_vitac/viterbi_detector.cc
new file mode 100644
index 0000000..beee386
--- /dev/null
+++ b/Transceiver52M/grgsm_vitac/viterbi_detector.cc
@@ -0,0 +1,392 @@
+/* -*- c++ -*- */
+/*
+ * @file
+ * @author (C) 2009 by Piotr Krysik <ptrkrysik(a)gmail.com>
+ * @section LICENSE
+ *
+ * Gr-gsm is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3, or (at your option)
+ * any later version.
+ *
+ * Gr-gsm is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with gr-gsm; see the file COPYING. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+/*
+ * viterbi_detector:
+ * This part does the detection of received sequnece.
+ * Employed algorithm is viterbi Maximum Likehood Sequence Estimation.
+ * At this moment it gives hard decisions on the output, but
+ * it was designed with soft decisions in mind.
+ *
+ * SYNTAX: void viterbi_detector(
+ * const gr_complex * input,
+ * unsigned int samples_num,
+ * gr_complex * rhh,
+ * unsigned int start_state,
+ * const unsigned int * stop_states,
+ * unsigned int stops_num,
+ * float * output)
+ *
+ * INPUT: input: Complex received signal afted matched filtering.
+ * samples_num: Number of samples in the input table.
+ * rhh: The autocorrelation of the estimated channel
+ * impulse response.
+ * start_state: Number of the start point. In GSM each burst
+ * starts with sequence of three bits (0,0,0) which
+ * indicates start point of the algorithm.
+ * stop_states: Table with numbers of possible stop states.
+ * stops_num: Number of possible stop states
+ *
+ *
+ * OUTPUT: output: Differentially decoded hard output of the algorithm:
+ * -1 for logical "0" and 1 for logical "1"
+ *
+ * SUB_FUNC: none
+ *
+ * TEST(S): Tested with real world normal burst.
+ */
+
+#include "constants.h"
+#include <cmath>
+
+#define PATHS_NUM (1 << (CHAN_IMP_RESP_LENGTH-1))
+
+void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output)
+{
+ float increment[8];
+ float path_metrics1[16];
+ float path_metrics2[16];
+ float paths_difference;
+ float * new_path_metrics;
+ float * old_path_metrics;
+ float * tmp;
+ float trans_table[BURST_SIZE][16];
+ float pm_candidate1, pm_candidate2;
+ bool real_imag;
+ float input_symbol_real, input_symbol_imag;
+ unsigned int i, sample_nr;
+
+/*
+* Setup first path metrics, so only state pointed by start_state is possible.
+* Start_state metric is equal to zero, the rest is written with some very low value,
+* which makes them practically impossible to occur.
+*/
+ for(i=0; i<PATHS_NUM; i++){
+ path_metrics1[i]=(-10e30);
+ }
+ path_metrics1[start_state]=0;
+
+/*
+* Compute Increment - a table of values which does not change for subsequent input samples.
+* Increment is table of reference levels for computation of branch metrics:
+* branch metric = (+/-)received_sample (+/-) reference_level
+*/
+ increment[0] = -rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real();
+ increment[1] = rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real();
+ increment[2] = -rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real();
+ increment[3] = rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real();
+ increment[4] = -rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real();
+ increment[5] = rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real();
+ increment[6] = -rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real();
+ increment[7] = rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real();
+
+
+/*
+* Computation of path metrics and decisions (Add-Compare-Select).
+* It's composed of two parts: one for odd input samples (imaginary numbers)
+* and one for even samples (real numbers).
+* Each part is composed of independent (parallelisable) statements like
+* this one:
+* pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2];
+* pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5];
+* paths_difference=pm_candidate2-pm_candidate1;
+* new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+* trans_table[sample_nr][1] = paths_difference;
+* This is very good point for optimisations (SIMD or OpenMP) as it's most time
+* consuming part of this function.
+*/
+ sample_nr=0;
+ old_path_metrics=path_metrics1;
+ new_path_metrics=path_metrics2;
+ while(sample_nr<samples_num){
+ //Processing imag states
+ real_imag=1;
+ input_symbol_imag = input[sample_nr].imag();
+
+ pm_candidate1 = old_path_metrics[0] +input_symbol_imag -increment[2];
+ pm_candidate2 = old_path_metrics[8] +input_symbol_imag +increment[5];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][0] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2];
+ pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][1] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[1] +input_symbol_imag -increment[3];
+ pm_candidate2 = old_path_metrics[9] +input_symbol_imag +increment[4];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][2] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[1] -input_symbol_imag +increment[3];
+ pm_candidate2 = old_path_metrics[9] -input_symbol_imag -increment[4];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][3] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[2] +input_symbol_imag -increment[0];
+ pm_candidate2 = old_path_metrics[10] +input_symbol_imag +increment[7];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][4] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[2] -input_symbol_imag +increment[0];
+ pm_candidate2 = old_path_metrics[10] -input_symbol_imag -increment[7];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][5] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[3] +input_symbol_imag -increment[1];
+ pm_candidate2 = old_path_metrics[11] +input_symbol_imag +increment[6];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][6] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[3] -input_symbol_imag +increment[1];
+ pm_candidate2 = old_path_metrics[11] -input_symbol_imag -increment[6];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][7] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[4] +input_symbol_imag -increment[6];
+ pm_candidate2 = old_path_metrics[12] +input_symbol_imag +increment[1];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][8] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[4] -input_symbol_imag +increment[6];
+ pm_candidate2 = old_path_metrics[12] -input_symbol_imag -increment[1];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][9] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[5] +input_symbol_imag -increment[7];
+ pm_candidate2 = old_path_metrics[13] +input_symbol_imag +increment[0];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][10] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[5] -input_symbol_imag +increment[7];
+ pm_candidate2 = old_path_metrics[13] -input_symbol_imag -increment[0];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][11] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[6] +input_symbol_imag -increment[4];
+ pm_candidate2 = old_path_metrics[14] +input_symbol_imag +increment[3];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][12] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[6] -input_symbol_imag +increment[4];
+ pm_candidate2 = old_path_metrics[14] -input_symbol_imag -increment[3];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][13] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[7] +input_symbol_imag -increment[5];
+ pm_candidate2 = old_path_metrics[15] +input_symbol_imag +increment[2];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][14] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[7] -input_symbol_imag +increment[5];
+ pm_candidate2 = old_path_metrics[15] -input_symbol_imag -increment[2];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][15] = paths_difference;
+ tmp=old_path_metrics;
+ old_path_metrics=new_path_metrics;
+ new_path_metrics=tmp;
+
+ sample_nr++;
+ if(sample_nr==samples_num)
+ break;
+
+ //Processing real states
+ real_imag=0;
+ input_symbol_real = input[sample_nr].real();
+
+ pm_candidate1 = old_path_metrics[0] -input_symbol_real -increment[7];
+ pm_candidate2 = old_path_metrics[8] -input_symbol_real +increment[0];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][0] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[0] +input_symbol_real +increment[7];
+ pm_candidate2 = old_path_metrics[8] +input_symbol_real -increment[0];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][1] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[1] -input_symbol_real -increment[6];
+ pm_candidate2 = old_path_metrics[9] -input_symbol_real +increment[1];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][2] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[1] +input_symbol_real +increment[6];
+ pm_candidate2 = old_path_metrics[9] +input_symbol_real -increment[1];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][3] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[2] -input_symbol_real -increment[5];
+ pm_candidate2 = old_path_metrics[10] -input_symbol_real +increment[2];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][4] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[2] +input_symbol_real +increment[5];
+ pm_candidate2 = old_path_metrics[10] +input_symbol_real -increment[2];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][5] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[3] -input_symbol_real -increment[4];
+ pm_candidate2 = old_path_metrics[11] -input_symbol_real +increment[3];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][6] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[3] +input_symbol_real +increment[4];
+ pm_candidate2 = old_path_metrics[11] +input_symbol_real -increment[3];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][7] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[4] -input_symbol_real -increment[3];
+ pm_candidate2 = old_path_metrics[12] -input_symbol_real +increment[4];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][8] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[4] +input_symbol_real +increment[3];
+ pm_candidate2 = old_path_metrics[12] +input_symbol_real -increment[4];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][9] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[5] -input_symbol_real -increment[2];
+ pm_candidate2 = old_path_metrics[13] -input_symbol_real +increment[5];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][10] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[5] +input_symbol_real +increment[2];
+ pm_candidate2 = old_path_metrics[13] +input_symbol_real -increment[5];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][11] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[6] -input_symbol_real -increment[1];
+ pm_candidate2 = old_path_metrics[14] -input_symbol_real +increment[6];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][12] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[6] +input_symbol_real +increment[1];
+ pm_candidate2 = old_path_metrics[14] +input_symbol_real -increment[6];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][13] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[7] -input_symbol_real -increment[0];
+ pm_candidate2 = old_path_metrics[15] -input_symbol_real +increment[7];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][14] = paths_difference;
+
+ pm_candidate1 = old_path_metrics[7] +input_symbol_real +increment[0];
+ pm_candidate2 = old_path_metrics[15] +input_symbol_real -increment[7];
+ paths_difference=pm_candidate2-pm_candidate1;
+ new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2;
+ trans_table[sample_nr][15] = paths_difference;
+
+ tmp=old_path_metrics;
+ old_path_metrics=new_path_metrics;
+ new_path_metrics=tmp;
+
+ sample_nr++;
+ }
+
+/*
+* Find the best from the stop states by comparing their path metrics.
+* Not every stop state is always possible, so we are searching in
+* a subset of them.
+*/
+ unsigned int best_stop_state;
+ float stop_state_metric, max_stop_state_metric;
+ best_stop_state = stop_states[0];
+ max_stop_state_metric = old_path_metrics[best_stop_state];
+ for(i=1; i< stops_num; i++){
+ stop_state_metric = old_path_metrics[stop_states[i]];
+ if(stop_state_metric > max_stop_state_metric){
+ max_stop_state_metric = stop_state_metric;
+ best_stop_state = stop_states[i];
+ }
+ }
+
+/*
+* This table was generated with hope that it gives a litle speedup during
+* traceback stage.
+* Received bit is related to the number of state in the trellis.
+* I've numbered states so their parity (number of ones) is related
+* to a received bit.
+*/
+ static const unsigned int parity_table[PATHS_NUM] = { 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, };
+
+/*
+* Table of previous states in the trellis diagram.
+* For GMSK modulation every state has two previous states.
+* Example:
+* previous_state_nr1 = prev_table[current_state_nr][0]
+* previous_state_nr2 = prev_table[current_state_nr][1]
+*/
+ static const unsigned int prev_table[PATHS_NUM][2] = { {0,8}, {0,8}, {1,9}, {1,9}, {2,10}, {2,10}, {3,11}, {3,11}, {4,12}, {4,12}, {5,13}, {5,13}, {6,14}, {6,14}, {7,15}, {7,15}, };
+
+/*
+* Traceback and differential decoding of received sequence.
+* Decisions stored in trans_table are used to restore best path in the trellis.
+*/
+ sample_nr=samples_num;
+ unsigned int state_nr=best_stop_state;
+ unsigned int decision;
+ bool out_bit=0;
+
+ while(sample_nr>0){
+ sample_nr--;
+ decision = (trans_table[sample_nr][state_nr]>0);
+
+ if(decision != out_bit)
+ output[sample_nr]=-trans_table[sample_nr][state_nr];
+ else
+ output[sample_nr]=trans_table[sample_nr][state_nr];
+
+ out_bit = out_bit ^ real_imag ^ parity_table[state_nr];
+ state_nr = prev_table[state_nr][decision];
+ real_imag = !real_imag;
+ }
+}
diff --git a/Transceiver52M/grgsm_vitac/viterbi_detector.h b/Transceiver52M/grgsm_vitac/viterbi_detector.h
new file mode 100644
index 0000000..2595343
--- /dev/null
+++ b/Transceiver52M/grgsm_vitac/viterbi_detector.h
@@ -0,0 +1,64 @@
+/* -*- c++ -*- */
+/*
+ * @file
+ * @author (C) 2009 Piotr Krysik <ptrkrysik(a)gmail.com>
+ * @section LICENSE
+ *
+ * Gr-gsm is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 3, or (at your option)
+ * any later version.
+ *
+ * Gr-gsm is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with gr-gsm; see the file COPYING. If not, write to
+ * the Free Software Foundation, Inc., 51 Franklin Street,
+ * Boston, MA 02110-1301, USA.
+ */
+
+/*
+ * viterbi_detector:
+ * This part does the detection of received sequnece.
+ * Employed algorithm is viterbi Maximum Likehood Sequence Estimation.
+ * At this moment it gives hard decisions on the output, but
+ * it was designed with soft decisions in mind.
+ *
+ * SYNTAX: void viterbi_detector(
+ * const gr_complex * input,
+ * unsigned int samples_num,
+ * gr_complex * rhh,
+ * unsigned int start_state,
+ * const unsigned int * stop_states,
+ * unsigned int stops_num,
+ * float * output)
+ *
+ * INPUT: input: Complex received signal afted matched filtering.
+ * samples_num: Number of samples in the input table.
+ * rhh: The autocorrelation of the estimated channel
+ * impulse response.
+ * start_state: Number of the start point. In GSM each burst
+ * starts with sequence of three bits (0,0,0) which
+ * indicates start point of the algorithm.
+ * stop_states: Table with numbers of possible stop states.
+ * stops_num: Number of possible stop states
+ *
+ *
+ * OUTPUT: output: Differentially decoded hard output of the algorithm:
+ * -1 for logical "0" and 1 for logical "1"
+ *
+ * SUB_FUNC: none
+ *
+ * TEST(S): Tested with real world normal burst.
+ */
+
+#ifndef INCLUDED_VITERBI_DETECTOR_H
+#define INCLUDED_VITERBI_DETECTOR_H
+#include "constants.h"
+
+void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output);
+
+#endif /* INCLUDED_VITERBI_DETECTOR_H */
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f
Gerrit-Change-Number: 30415
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ms-trx support
by Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 )
Change subject: ms-trx support
......................................................................
ms-trx support
This is basically a trxcon that includes a transceiver, and can just
be used with existing and future apps supporting the trxcon interface,
i.e. mobile or ccch_scan.
Supports bladerf and uhd, binaries are automatically built if those libs
are detected + the osmocom-bb submodule exists.
Currently using hardcoded sched/prios aimed at a setup with working,
reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3,
not 2, not any other version)
Additionally builds test tools used for development: osmo-trx-syncthing*
Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
---
M .gitignore
M Makefile.am
M Transceiver52M/Makefile.am
A Transceiver52M/ms/bladerf_specific.h
A Transceiver52M/ms/ipc_specific.h
A Transceiver52M/ms/itrq.h
A Transceiver52M/ms/l1ctl_server.c
A Transceiver52M/ms/l1ctl_server_cb.cpp
A Transceiver52M/ms/logging.cpp
A Transceiver52M/ms/ms.cpp
A Transceiver52M/ms/ms.h
A Transceiver52M/ms/ms_rx_burst.h
A Transceiver52M/ms/ms_rx_burst_test.cpp
A Transceiver52M/ms/ms_rx_lower.cpp
A Transceiver52M/ms/ms_upper.cpp
A Transceiver52M/ms/ms_upper.h
A Transceiver52M/ms/sch.c
A Transceiver52M/ms/sch.h
A Transceiver52M/ms/uhd_specific.h
M configure.ac
20 files changed, 3,730 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/1
diff --git a/.gitignore b/.gitignore
index 35a1b46..0b33e0f 100644
--- a/.gitignore
+++ b/.gitignore
@@ -7,6 +7,13 @@
Transceiver52M/osmo-trx-lms
Transceiver52M/osmo-trx-ipc
Transceiver52M/osmo-trx-blade
+Transceiver52M/osmo-trx-ipc2
+Transceiver52M/osmo-trx-syncthing-blade
+Transceiver52M/osmo-trx-syncthing-uhd
+Transceiver52M/osmo-trx-syncthing-ipc
+Transceiver52M/osmo-trx-ms-blade
+Transceiver52M/osmo-trx-ms-uhd
+Transceiver52M/osmo-trx-ms-ipc
Transceiver52M/device/ipc/uhddev_ipc.cpp
.clang-format
diff --git a/Makefile.am b/Makefile.am
index 6a3a955..7636b46 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -26,8 +26,15 @@
#AM_CXXFLAGS = -Wall -O2 -NDEBUG -pthread
#AM_CFLAGS = -Wall -O2 -NDEBUG -pthread
+SUBDIRS =
+
+if ENABLE_MS_TRX
+ SUBDIRS += osmocom-bb/src/host/trxcon
+endif
+
# Order must be preserved
-SUBDIRS = \
+SUBDIRS += \
+ osmocom-bb/src/host/trxcon \
CommonLibs \
GSM \
Transceiver52M \
diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am
index 3f84d3d..5649d15 100644
--- a/Transceiver52M/Makefile.am
+++ b/Transceiver52M/Makefile.am
@@ -23,9 +23,9 @@
SUBDIRS = arch device
-AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/arch/common -I${srcdir}/device/common
-AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS)
-AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS)
+AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/arch/common -I${srcdir}/device/common -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/
+AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/
+AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOCTRL_CFLAGS) $(LIBOSMOVTY_CFLAGS) -I$(top_srcdir)/osmocom-bb/src/host/trxcon/include/
noinst_LTLIBRARIES = libtransceiver_common.la
@@ -40,7 +40,9 @@
ChannelizerBase.cpp \
Channelizer.cpp \
Synthesis.cpp \
- proto_trxd.c
+ proto_trxd.c \
+ grgsm_vitac/grgsm_vitac.cpp \
+ grgsm_vitac/viterbi_detector.cc
libtransceiver_common_la_SOURCES = \
$(COMMON_SOURCES) \
@@ -61,7 +63,9 @@
ChannelizerBase.h \
Channelizer.h \
Synthesis.h \
- proto_trxd.h
+ proto_trxd.h \
+ grgsm_vitac/viterbi_detector.h \
+ grgsm_vitac/constants.h
COMMON_LDADD = \
libtransceiver_common.la \
@@ -70,9 +74,26 @@
$(COMMON_LA) \
$(FFTWF_LIBS) \
$(LIBOSMOCORE_LIBS) \
+ $(LIBOSMOCODING_LIBS) \
$(LIBOSMOCTRL_LIBS) \
$(LIBOSMOVTY_LIBS)
+TRXCON_LDADD = \
+ $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libl1sched.a \
+ $(top_builddir)/osmocom-bb/src/host/trxcon/src/.libs/libtrxcon.a
+
+MS_SOURCES = \
+ ms/sch.c \
+ ms/ms.cpp \
+ ms/ms_rx_lower.cpp
+
+noinst_HEADERS += \
+ ms/ms.h \
+ ms/bladerf_specific.h \
+ ms/uhd_specific.h \
+ ms/ms_upper.h \
+ ms/itrq.h
+
bin_PROGRAMS =
if DEVICE_UHD
@@ -83,6 +104,26 @@
$(COMMON_LDADD) \
$(UHD_LIBS)
osmo_trx_uhd_CPPFLAGS = $(AM_CPPFLAGS) $(UHD_CFLAGS)
+
+if ENABLE_MS_TRX
+bin_PROGRAMS += osmo-trx-ms-uhd
+osmo_trx_ms_uhd_SOURCES = $(MS_SOURCES) ms/ms_upper.cpp ms/l1ctl_server.c ms/logging.cpp ms/l1ctl_server_cb.cpp
+osmo_trx_ms_uhd_LDADD = \
+ $(builddir)/device/uhd/libdevice.la \
+ $(COMMON_LDADD) \
+ $(UHD_LIBS) \
+ $(TRXCON_LDADD)
+osmo_trx_ms_uhd_CPPFLAGS = $(AM_CPPFLAGS) $(UHD_CFLAGS) -DBUILDUHD
+
+bin_PROGRAMS += osmo-trx-syncthing-uhd
+osmo_trx_syncthing_uhd_SOURCES = $(MS_SOURCES) ms/ms_rx_burst_test.cpp
+osmo_trx_syncthing_uhd_LDADD = \
+ $(builddir)/device/uhd/libdevice.la \
+ $(COMMON_LDADD) \
+ $(UHD_LIBS) \
+ $(TRXCON_LDADD)
+osmo_trx_syncthing_uhd_CPPFLAGS = $(AM_CPPFLAGS) $(UHD_CFLAGS) -DSYNCTHINGONLY -DBUILDUHD
+endif
endif
if DEVICE_USRP1
@@ -114,6 +155,25 @@
$(BLADE_LIBS)
osmo_trx_blade_CPPFLAGS = $(AM_CPPFLAGS) $(LMS_CFLAGS)
+if ENABLE_MS_TRX
+bin_PROGRAMS += osmo-trx-ms-blade
+osmo_trx_ms_blade_SOURCES = $(MS_SOURCES) ms/ms_upper.cpp ms/l1ctl_server.c ms/logging.cpp ms/l1ctl_server_cb.cpp
+osmo_trx_ms_blade_LDADD = \
+ $(builddir)/device/bladerf/libdevice.la \
+ $(COMMON_LDADD) \
+ $(BLADE_LIBS) \
+ $(TRXCON_LDADD)
+osmo_trx_ms_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DBUILDBLADE
+
+bin_PROGRAMS += osmo-trx-syncthing-blade
+osmo_trx_syncthing_blade_SOURCES = $(MS_SOURCES) ms/ms_rx_burst_test.cpp
+osmo_trx_syncthing_blade_LDADD = \
+ $(builddir)/device/bladerf/libdevice.la \
+ $(COMMON_LDADD) \
+ $(BLADE_LIBS) \
+ $(TRXCON_LDADD)
+osmo_trx_syncthing_blade_CPPFLAGS = $(AM_CPPFLAGS) $(BLADE_CFLAGS) -DSYNCTHINGONLY -DBUILDBLADE -I../device/ipc
+endif
endif
if DEVICE_IPC
@@ -123,5 +183,24 @@
$(builddir)/device/ipc/libdevice.la \
$(COMMON_LDADD)
osmo_trx_ipc_CPPFLAGS = $(AM_CPPFLAGS)
-endif
+# bin_PROGRAMS += osmo-trx-ipc2
+# osmo_trx_ipc2_SOURCES = osmo-trx.cpp
+# osmo_trx_ipc2_LDADD = \
+# $(builddir)/device/ipc2/libdevice.la \
+# $(COMMON_LDADD)
+# osmo_trx_ipc2_CPPFLAGS = $(AM_CPPFLAGS)
+# if ENABLE_MS_TRX
+# bin_PROGRAMS += osmo-trx-ms-ipc
+# osmo_trx_ms_ipc_SOURCES = $(MS_SOURCES) ms/ms_upper.cpp
+# osmo_trx_ms_ipc_LDADD = \
+# $(COMMON_LDADD) \
+# $(TRXCON_LDADD)
+# osmo_trx_ms_ipc_CPPFLAGS = $(AM_CPPFLAGS) -DBUILDIPC -I./device/ipc2 -I../device/ipc2
+
+# bin_PROGRAMS += osmo-trx-syncthing-ipc
+# osmo_trx_syncthing_ipc_SOURCES = $(MS_SOURCES) ms/ms_rx_burst_test.cpp
+# osmo_trx_syncthing_ipc_LDADD = $(COMMON_LDADD)
+# osmo_trx_syncthing_ipc_CPPFLAGS = $(AM_CPPFLAGS) -DSYNCTHINGONLY -DBUILDIPC -I./device/ipc2 -I../device/ipc2
+# endif
+endif
diff --git a/Transceiver52M/ms/bladerf_specific.h b/Transceiver52M/ms/bladerf_specific.h
new file mode 100644
index 0000000..edfb40f
--- /dev/null
+++ b/Transceiver52M/ms/bladerf_specific.h
@@ -0,0 +1,445 @@
+#pragma once
+
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include "itrq.h"
+#include <atomic>
+#include <complex>
+#include <cstdint>
+#include <functional>
+#include <iostream>
+#include <cassert>
+#include <cstring>
+
+#include <libbladeRF.h>
+#include <Timeval.h>
+#include <unistd.h>
+
+const size_t BLADE_BUFFER_SIZE = 1024 * 1;
+const size_t BLADE_NUM_BUFFERS = 32 * 1;
+const size_t NUM_TRANSFERS = 16 * 2;
+const int SAMPLE_SCALE_FACTOR = 15; // actually 16 but sigproc complains about clipping..
+
+template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args)
+{
+ out << '(' << std::forward<Arg>(arg);
+ (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... };
+ out << ')' << std::endl;
+}
+
+template <class R, class... Args> using RvalFunc = R (*)(Args...);
+
+// specialisation for funcs which return a value
+template <class R, class... Args>
+R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line,
+ Args... args)
+{
+ R rval = func(std::forward<Args>(args)...);
+ if (rval != 0) {
+ std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':'
+ << funcname << ':' << fname;
+ expand_args(std::cerr, args...);
+ }
+ return rval;
+}
+
+// only macros can pass a func name string
+#define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__)
+
+#pragma pack(push, 1)
+using blade_sample_type = std::complex<int16_t>;
+enum class blade_speed_buffer_type { HS, SS };
+template <blade_speed_buffer_type T> struct blade_usb_message {
+ uint32_t reserved;
+ uint64_t ts;
+ uint32_t meta_flags;
+ blade_sample_type d[(T == blade_speed_buffer_type::SS ? 512 : 256) - 4];
+};
+
+static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!");
+static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!");
+template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer {
+ static_assert((SZ >= 2 && !(SZ % 2)), "min size is 2x usb buffer!");
+ blade_usb_message<T> m[SZ];
+ int actual_samples_per_msg()
+ {
+ return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0]));
+ }
+ int actual_samples_per_buffer()
+ {
+ return SZ * actual_samples_per_msg();
+ }
+ int samples_per_buffer()
+ {
+ return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0]));
+ }
+ int num_msgs_per_buffer()
+ {
+ return SZ;
+ }
+ auto get_first_ts()
+ {
+ return m[0].ts;
+ }
+ constexpr auto *getsampleoffset(int ofs)
+ {
+ auto full = ofs / actual_samples_per_msg();
+ auto rem = ofs % actual_samples_per_msg();
+ return &m[full].d[rem];
+ }
+ int readall(blade_sample_type *outaddr)
+ {
+ blade_sample_type *addr = outaddr;
+ for (int i = 0; i < SZ; i++) {
+ memcpy(addr, &m[i].d[0], actual_samples_per_msg() * sizeof(blade_sample_type));
+ addr += actual_samples_per_msg();
+ }
+ return actual_samples_per_buffer();
+ }
+ int read_n(blade_sample_type *outaddr, int start, int num)
+ {
+ assert((start + num) <= actual_samples_per_buffer());
+ assert(start >= 0);
+
+ if (!num)
+ return 0;
+
+ // which buffer?
+ int start_buf_idx = (start > 0) ? start / actual_samples_per_msg() : 0;
+ // offset from actual buffer start
+ auto start_offset_in_buf = (start - (start_buf_idx * actual_samples_per_msg()));
+ auto samp_rem_in_first_buf = actual_samples_per_msg() - start_offset_in_buf;
+ auto remaining_first_buf = num > samp_rem_in_first_buf ? samp_rem_in_first_buf : num;
+
+ memcpy(outaddr, &m[start_buf_idx].d[start_offset_in_buf],
+ remaining_first_buf * sizeof(blade_sample_type));
+ outaddr += remaining_first_buf;
+
+ auto remaining = num - remaining_first_buf;
+
+ if (!remaining)
+ return num;
+
+ start_buf_idx++;
+
+ auto rem_full_bufs = remaining / actual_samples_per_msg();
+ remaining -= rem_full_bufs * actual_samples_per_msg();
+
+ for (int i = 0; i < rem_full_bufs; i++) {
+ memcpy(outaddr, &m[start_buf_idx++].d[0], actual_samples_per_msg() * sizeof(blade_sample_type));
+ outaddr += actual_samples_per_msg();
+ }
+
+ if (remaining)
+ memcpy(outaddr, &m[start_buf_idx].d[0], remaining * sizeof(blade_sample_type));
+ return num;
+ }
+ int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts)
+ {
+ assert(num <= actual_samples_per_buffer());
+ int len_rem = num;
+ for (int i = 0; i < SZ; i++) {
+ m[i] = {};
+ m[i].ts = first_ts + i * actual_samples_per_msg();
+ if (len_rem) {
+ int max_to_copy =
+ len_rem > actual_samples_per_msg() ? actual_samples_per_msg() : len_rem;
+ memcpy(&m[i].d[0], in, max_to_copy * sizeof(blade_sample_type));
+ len_rem -= max_to_copy;
+ in += actual_samples_per_msg();
+ }
+ }
+ return num;
+ }
+};
+#pragma pack(pop)
+
+template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper {
+ static_assert((SZ >= 1024 && ((SZ & (SZ - 1)) == 0)), "only buffer size multiples of 1024 allowed!");
+ static blade_otw_buffer<SZ / 512, T> x;
+};
+
+using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x);
+// using buf_in_use = blade_otw_buffer<2, blade_speed_buffer_type::SS>;
+using bh_fn_t = std::function<int(dev_buf_t *)>;
+
+template <typename T> struct blade_hw {
+ struct bladerf *dev;
+ struct bladerf_stream *rx_stream;
+ struct bladerf_stream *tx_stream;
+ // using pkt2buf = blade_otw_buffer<2, blade_speed_buffer_type::SS>;
+ using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>;
+ const unsigned int rxFullScale, txFullScale;
+ const int rxtxdelay;
+
+ float rxgain, txgain;
+
+ struct ms_trx_config {
+ int tx_freq;
+ int rx_freq;
+ int sample_rate;
+ int bandwidth;
+
+ public:
+ ms_trx_config() : tx_freq(881e6), rx_freq(926e6), sample_rate(((1625e3 / 6) * 4)), bandwidth(1e6)
+ {
+ }
+ } cfg;
+
+ struct buf_mgmt {
+ void **rx_samples;
+ void **tx_samples;
+ tx_buf_q_type bufptrqueue;
+
+ } buf_mgmt;
+
+ virtual ~blade_hw()
+ {
+ close_device();
+ }
+ blade_hw() : rxFullScale(2047), txFullScale(2047), rxtxdelay(-60)
+ {
+ }
+
+ void close_device()
+ {
+ if (dev) {
+ if (rx_stream) {
+ bladerf_deinit_stream(rx_stream);
+ }
+
+ if (tx_stream) {
+ bladerf_deinit_stream(tx_stream);
+ }
+
+ bladerf_enable_module(dev, BLADERF_MODULE_RX, false);
+ bladerf_enable_module(dev, BLADERF_MODULE_TX, false);
+
+ bladerf_close(dev);
+ dev = NULL;
+ }
+ }
+
+ int init_device(bh_fn_t rxh, bh_fn_t txh)
+ {
+ struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual;
+
+ bladerf_log_set_verbosity(BLADERF_LOG_LEVEL_DEBUG);
+ bladerf_set_usb_reset_on_open(true);
+ blade_check(bladerf_open, &dev, "");
+ if (!dev) {
+ std::cerr << "open failed, device missing?" << std::endl;
+ exit(0);
+ }
+ if (bladerf_device_speed(dev) != bladerf_dev_speed::BLADERF_DEVICE_SPEED_SUPER) {
+ std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl;
+ return -1;
+ }
+
+ blade_check(bladerf_set_tuning_mode, dev, bladerf_tuning_mode::BLADERF_TUNING_MODE_FPGA);
+
+ bool is_locked;
+ blade_check(bladerf_set_pll_enable, dev, true);
+ blade_check(bladerf_set_pll_refclk, dev, 10000000UL);
+ for (int i = 0; i < 20; i++) {
+ usleep(50 * 1000);
+ bladerf_get_pll_lock_state(dev, &is_locked);
+
+ if (is_locked)
+ break;
+ }
+ if (!is_locked) {
+ std::cerr << "unable to lock refclk!" << std::endl;
+ return -1;
+ }
+
+ blade_check(bladerf_set_rational_sample_rate, dev, BLADERF_CHANNEL_RX(0), &rate, &actual);
+ blade_check(bladerf_set_rational_sample_rate, dev, BLADERF_CHANNEL_TX(0), &rate, &actual);
+
+ blade_check(bladerf_set_frequency, dev, BLADERF_CHANNEL_RX(0), (bladerf_frequency)cfg.rx_freq);
+ blade_check(bladerf_set_frequency, dev, BLADERF_CHANNEL_TX(0), (bladerf_frequency)cfg.tx_freq);
+
+ blade_check(bladerf_set_bandwidth, dev, BLADERF_CHANNEL_RX(0), (bladerf_bandwidth)cfg.bandwidth,
+ (bladerf_bandwidth *)NULL);
+ blade_check(bladerf_set_bandwidth, dev, BLADERF_CHANNEL_TX(0), (bladerf_bandwidth)cfg.bandwidth,
+ (bladerf_bandwidth *)NULL);
+
+ blade_check(bladerf_set_gain_mode, dev, BLADERF_CHANNEL_RX(0), BLADERF_GAIN_MGC);
+ blade_check(bladerf_set_gain, dev, BLADERF_CHANNEL_RX(0), (bladerf_gain)30);
+ blade_check(bladerf_set_gain, dev, BLADERF_CHANNEL_TX(0), (bladerf_gain)30);
+ usleep(1000);
+ blade_check(bladerf_enable_module, dev, BLADERF_MODULE_RX, true);
+ usleep(1000);
+ blade_check(bladerf_enable_module, dev, BLADERF_MODULE_TX, true);
+ usleep(1000);
+ blade_check(bladerf_init_stream, &rx_stream, dev, getrxcb(rxh), &buf_mgmt.rx_samples, BLADE_NUM_BUFFERS,
+ BLADERF_FORMAT_SC16_Q11_META, BLADE_BUFFER_SIZE, NUM_TRANSFERS, (void *)this);
+
+ blade_check(bladerf_init_stream, &tx_stream, dev, gettxcb(txh), &buf_mgmt.tx_samples, BLADE_NUM_BUFFERS,
+ BLADERF_FORMAT_SC16_Q11_META, BLADE_BUFFER_SIZE, NUM_TRANSFERS, (void *)this);
+
+ for (int i = 0; i < BLADE_NUM_BUFFERS; i++) {
+ auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples);
+ buf_mgmt.bufptrqueue.spsc_push(&cur_buffer[i]);
+ }
+
+ setRxGain(20);
+ setTxGain(30);
+
+ usleep(1000);
+
+ // bladerf_set_stream_timeout(dev, BLADERF_TX, 4);
+ // bladerf_set_stream_timeout(dev, BLADERF_RX, 4);
+
+ return 0;
+ }
+
+ bool tuneTx(double freq, size_t chan = 0)
+ {
+ msleep(15);
+ blade_check(bladerf_set_frequency, dev, BLADERF_CHANNEL_TX(0), (bladerf_frequency)freq);
+ msleep(15);
+ return true;
+ };
+ bool tuneRx(double freq, size_t chan = 0)
+ {
+ msleep(15);
+ blade_check(bladerf_set_frequency, dev, BLADERF_CHANNEL_RX(0), (bladerf_frequency)freq);
+ msleep(15);
+ return true;
+ };
+ bool tuneRxOffset(double offset, size_t chan = 0)
+ {
+ return true;
+ };
+
+ double setRxGain(double dB, size_t chan = 0)
+ {
+ rxgain = dB;
+ msleep(15);
+ blade_check(bladerf_set_gain, dev, BLADERF_CHANNEL_RX(0), (bladerf_gain)dB);
+ msleep(15);
+ return dB;
+ };
+ double setTxGain(double dB, size_t chan = 0)
+ {
+ txgain = dB;
+ msleep(15);
+ blade_check(bladerf_set_gain, dev, BLADERF_CHANNEL_TX(0), (bladerf_gain)dB);
+ msleep(15);
+ return dB;
+ };
+ int setPowerAttenuation(int atten, size_t chan = 0)
+ {
+ return atten;
+ };
+
+ static void check_timestamp(dev_buf_t *rcd)
+ {
+ static bool first = true;
+ static uint64_t last_ts;
+ if (first) {
+ first = false;
+ last_ts = rcd->m[0].ts;
+ } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) {
+ std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " "
+ << last_ts + rcd->actual_samples_per_buffer() << " " << rcd->m[0].ts << std::endl;
+ last_ts = rcd->m[0].ts;
+ } else {
+ last_ts = rcd->m[0].ts;
+ }
+ }
+
+ bladerf_stream_cb getrxcb(bh_fn_t rxbh)
+ {
+ // C cb -> no capture!
+ static auto rxbhfn = rxbh;
+ return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
+ void *samples, size_t num_samples, void *user_data) -> void * {
+ // struct blade_hw *trx = (struct blade_hw *)user_data;
+ static int to_skip = 0;
+ dev_buf_t *rcd = (dev_buf_t *)samples;
+
+ if (to_skip < 120) // prevents weird overflows on startup
+ to_skip++;
+ else {
+ check_timestamp(rcd);
+ rxbhfn(rcd);
+ }
+
+ return samples;
+ };
+ }
+ bladerf_stream_cb gettxcb(bh_fn_t txbh)
+ {
+ // C cb -> no capture!
+ static auto txbhfn = txbh;
+ return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta,
+ void *samples, size_t num_samples, void *user_data) -> void * {
+ struct blade_hw *trx = (struct blade_hw *)user_data;
+ auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples);
+
+ if (samples) // put buffer address back into queue, ready to be reused
+ trx->buf_mgmt.bufptrqueue.spsc_push(&ptr);
+
+ return BLADERF_STREAM_NO_DATA;
+ };
+ }
+
+ auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
+ {
+ auto fn = [this] {
+ int status;
+ status = bladerf_stream(rx_stream, BLADERF_RX_X1);
+ if (status < 0)
+ std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
+
+ return NULL;
+ };
+ return fn;
+ }
+ auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
+ {
+ auto fn = [this] {
+ int status;
+ status = bladerf_stream(tx_stream, BLADERF_TX_X1);
+ if (status < 0)
+ std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl;
+
+ return NULL;
+ };
+ return fn;
+ }
+
+ void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
+ {
+ //get empty bufer from list
+ tx_buf_q_type::elem_t rcd;
+
+ while (!buf_mgmt.bufptrqueue.spsc_pop(&rcd))
+ buf_mgmt.bufptrqueue.spsc_prep_pop();
+ assert(rcd != nullptr);
+
+ rcd->write_n_burst(buffer, len, ts + rxtxdelay); // blade xa4 specific delay!
+ blade_check(bladerf_submit_stream_buffer_nb, tx_stream, (void *)rcd);
+ }
+};
diff --git a/Transceiver52M/ms/ipc_specific.h b/Transceiver52M/ms/ipc_specific.h
new file mode 100644
index 0000000..c79e743
--- /dev/null
+++ b/Transceiver52M/ms/ipc_specific.h
@@ -0,0 +1,197 @@
+#pragma once
+
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include <cassert>
+#include <complex>
+#include <cstring>
+#include <functional>
+#include <iostream>
+#include <thread>
+
+#include <Timeval.h>
+#include <vector>
+
+// #define MTX_LOG_ENABLED
+#include <ipcif.h>
+
+// typedef unsigned long long TIMESTAMP;
+using blade_sample_type = std::complex<int16_t>;
+const int SAMPLE_SCALE_FACTOR = 1;
+
+struct uhd_buf_wrap {
+ uint64_t ts;
+ uint32_t num_samps;
+ blade_sample_type *buf;
+ auto actual_samples_per_buffer()
+ {
+ return num_samps;
+ }
+ long get_first_ts()
+ {
+ return ts; //md->time_spec.to_ticks(rxticks);
+ }
+ int readall(blade_sample_type *outaddr)
+ {
+ memcpy(outaddr, buf, num_samps * sizeof(blade_sample_type));
+ return num_samps;
+ }
+ int read_n(blade_sample_type *outaddr, int start, int num)
+ {
+ // assert(start >= 0);
+ auto to_read = std::min((int)num_samps - start, num);
+ // assert(to_read >= 0);
+ memcpy(outaddr, buf + start, to_read * sizeof(blade_sample_type));
+ return to_read;
+ }
+};
+
+using dev_buf_t = uhd_buf_wrap;
+using bh_fn_t = std::function<int(dev_buf_t *)>;
+
+template <typename T> struct ipc_hw {
+ // uhd::usrp::multi_usrp::sptr dev;
+ // uhd::rx_streamer::sptr rx_stream;
+ // uhd::tx_streamer::sptr tx_stream;
+ blade_sample_type *one_pkt_buf;
+ std::vector<blade_sample_type *> pkt_ptrs;
+ size_t rx_spp;
+ double rxticks;
+ const unsigned int rxFullScale, txFullScale;
+ const int rxtxdelay;
+ float rxgain, txgain;
+ trxmsif m;
+
+ virtual ~ipc_hw()
+ {
+ delete[] one_pkt_buf;
+ }
+ ipc_hw() : rxFullScale(32767), txFullScale(32767), rxtxdelay(0)
+ {
+ }
+
+ bool tuneTx(double freq, size_t chan = 0)
+ {
+ msleep(25);
+ // dev->set_tx_freq(freq, chan);
+ msleep(25);
+ return true;
+ };
+ bool tuneRx(double freq, size_t chan = 0)
+ {
+ msleep(25);
+ // dev->set_rx_freq(freq, chan);
+ msleep(25);
+ return true;
+ };
+ bool tuneRxOffset(double offset, size_t chan = 0)
+ {
+ return true;
+ };
+
+ double setRxGain(double dB, size_t chan = 0)
+ {
+ rxgain = dB;
+ msleep(25);
+ // dev->set_rx_gain(dB, chan);
+ msleep(25);
+ return dB;
+ };
+ double setTxGain(double dB, size_t chan = 0)
+ {
+ txgain = dB;
+ msleep(25);
+ // dev->set_tx_gain(dB, chan);
+ msleep(25);
+ return dB;
+ };
+ int setPowerAttenuation(int atten, size_t chan = 0)
+ {
+ return atten;
+ };
+
+ int init_device(bh_fn_t rxh, bh_fn_t txh)
+ {
+ return m.connect() ? 0 : -1;
+ }
+
+ void *rx_cb(bh_fn_t burst_handler)
+ {
+ void *ret;
+ static int to_skip = 0;
+ static uint64_t last_ts;
+
+ blade_sample_type pbuf[508 * 2];
+
+ uint64_t t;
+
+ int len = 508 * 2;
+ m.read_dl(508 * 2, &t, pbuf);
+ dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf };
+
+ if (to_skip < 120) // prevents weird overflows on startup
+ to_skip++;
+ else {
+ assert(last_ts != rcd.get_first_ts());
+ burst_handler(&rcd);
+ last_ts = rcd.get_first_ts();
+ }
+
+ m.drive_tx();
+
+ return ret;
+ }
+
+ auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
+ {
+ auto fn = [this, burst_handler] {
+ pthread_setname_np(pthread_self(), "rxrun");
+
+ while (1) {
+ rx_cb(burst_handler);
+ }
+ };
+ return fn;
+ }
+ auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
+ {
+ auto fn = [] {
+ // wait_for_shm_open();
+ // dummy
+ };
+ return fn;
+ }
+ void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
+ {
+ // FIXME: missing
+ }
+
+ void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
+ {
+ pthread_setname_np(pthread_self(), name);
+
+ }
+ void signal_start()
+ {
+ m.signal_read_start();
+ }
+};
diff --git a/Transceiver52M/ms/itrq.h b/Transceiver52M/ms/itrq.h
new file mode 100644
index 0000000..62ee848
--- /dev/null
+++ b/Transceiver52M/ms/itrq.h
@@ -0,0 +1,213 @@
+#pragma once
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include <atomic>
+
+#include <condition_variable>
+#include <mutex>
+#include <sys/eventfd.h>
+#include <unistd.h>
+
+#include <stdatomic.h>
+#include <stdbool.h>
+#include <stdlib.h>
+
+/*
+classic lamport circular lockfree spsc queue:
+every "side" only writes its own ptr, but may read the other sides ptr
+
+notify reader using eventfd as soon as element is added, reader then reads until
+read fails
+-> reader pops in a loop until FALSE and might get spurious events because it
+read before it was notified, which is fine
+-> writing pushes *the same data* in a loop until TRUE, blocks
+
+shutting this down requires
+1) to stop reading and pushing
+2) ONE side to take care of the eventfds
+*/
+
+namespace spsc_detail
+{
+template <bool block_read, bool block_write> class spsc_cond_detail {
+ std::condition_variable cond_r, cond_w;
+ std::mutex lr, lw;
+ std::atomic_int r_flag, w_flag;
+
+ public:
+ explicit spsc_cond_detail() : r_flag(0), w_flag(0)
+ {
+ }
+
+ ~spsc_cond_detail()
+ {
+ }
+
+ ssize_t spsc_check_r()
+ {
+ std::unique_lock<std::mutex> lk(lr);
+ while (r_flag == 0)
+ cond_r.wait(lk);
+ r_flag--;
+ return 1;
+ }
+ ssize_t spsc_check_w()
+ {
+ std::unique_lock<std::mutex> lk(lw);
+ while (w_flag == 0)
+ cond_w.wait(lk);
+ w_flag--;
+ return 1;
+ }
+ void spsc_notify_r()
+ {
+ std::unique_lock<std::mutex> lk(lr);
+ r_flag++;
+ cond_r.notify_one();
+ }
+ void spsc_notify_w()
+ {
+ std::unique_lock<std::mutex> lk(lw);
+ w_flag++;
+ cond_w.notify_one();
+ }
+};
+
+// originally designed for select loop integration
+template <bool block_read, bool block_write> class spsc_efd_detail {
+ int efd_r, efd_w; /* eventfds used to block/notify readers/writers */
+
+ public:
+ explicit spsc_efd_detail()
+ : efd_r(eventfd(0, block_read ? 0 : EFD_NONBLOCK)), efd_w(eventfd(1, block_write ? 0 : EFD_NONBLOCK))
+ {
+ }
+
+ ~spsc_efd_detail()
+ {
+ close(efd_r);
+ close(efd_w);
+ }
+
+ ssize_t spsc_check_r()
+ {
+ uint64_t efdr;
+ return read(efd_r, &efdr, sizeof(uint64_t));
+ }
+ ssize_t spsc_check_w()
+ {
+ uint64_t efdr;
+ return read(efd_w, &efdr, sizeof(uint64_t));
+ }
+ void spsc_notify_r()
+ {
+ uint64_t efdu = 1;
+ write(efd_r, &efdu, sizeof(uint64_t));
+ }
+ void spsc_notify_w()
+ {
+ uint64_t efdu = 1;
+ write(efd_w, &efdu, sizeof(uint64_t));
+ }
+ int get_r_efd()
+ {
+ return efd_r;
+ }
+ int get_w_efd()
+ {
+ return efd_w;
+ }
+};
+
+template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T>
+class spsc : public T<block_read, block_write> {
+ static_assert(SZ > 0, "queues need a size...");
+ std::atomic<unsigned int> readptr;
+ std::atomic<unsigned int> writeptr;
+
+ ELEM buf[SZ];
+
+ public:
+ using base_t = T<block_read, block_write>;
+ using elem_t = ELEM;
+ explicit spsc() : readptr(0), writeptr(0)
+ {
+ }
+
+ ~spsc()
+ {
+ }
+
+ /*! Adds element to the queue by copying the data.
+ * \param[in] elem input buffer, must match the originally configured queue buffer size!.
+ * \returns true if queue was not full and element was successfully pushed */
+ bool spsc_push(const ELEM *elem)
+ {
+ size_t cur_wp, cur_rp;
+ cur_wp = writeptr.load(std::memory_order_relaxed);
+ cur_rp = readptr.load(std::memory_order_acquire);
+ if ((cur_wp + 1) % SZ == cur_rp) {
+ if (block_write)
+ base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */
+ return false;
+ }
+ buf[cur_wp] = *elem;
+ writeptr.store((cur_wp + 1) % SZ, std::memory_order_release);
+ if (block_read)
+ base_t::spsc_notify_r(); /* fine after release */
+ return true;
+ }
+
+ /*! Removes element from the queue by copying the data.
+ * \param[in] elem output buffer, must match the originally configured queue buffer size!.
+ * \returns true if queue was not empty and element was successfully removed */
+ bool spsc_pop(ELEM *elem)
+ {
+ size_t cur_wp, cur_rp;
+ cur_wp = writeptr.load(std::memory_order_acquire);
+ cur_rp = readptr.load(std::memory_order_relaxed);
+
+ if (cur_wp == cur_rp) /* blocks via prep_pop */
+ return false;
+
+ *elem = buf[cur_rp];
+ readptr.store((cur_rp + 1) % SZ, std::memory_order_release);
+ if (block_write)
+ base_t::spsc_notify_w();
+ return true;
+ }
+
+ /*! Reads the read-fd of the queue, which, depending on settings passed on queue creation, blocks.
+ * This function can be used to deliberately wait for a non-empty queue on the read side.
+ * \returns result of reading the fd. */
+ ssize_t spsc_prep_pop()
+ {
+ return base_t::spsc_check_r();
+ }
+};
+
+} // namespace spsc_detail
+
+template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
+class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {};
+template <unsigned int SZ, typename ELEM, bool block_read, bool block_write>
+class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {};
\ No newline at end of file
diff --git a/Transceiver52M/ms/l1ctl_server.c b/Transceiver52M/ms/l1ctl_server.c
new file mode 100644
index 0000000..9e9083f
--- /dev/null
+++ b/Transceiver52M/ms/l1ctl_server.c
@@ -0,0 +1,275 @@
+/*
+ * OsmocomBB <-> SDR connection bridge
+ * UNIX socket server for L1CTL
+ *
+ * (C) 2013 by Sylvain Munaut <tnt(a)246tNt.com>
+ * (C) 2016-2017 by Vadim Yanitskiy <axilirator(a)gmail.com>
+ * (C) 2022 by by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>
+ *
+ * All Rights Reserved
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ */
+
+#include <stdio.h>
+#include <errno.h>
+#include <unistd.h>
+#include <stdlib.h>
+#include <string.h>
+
+#include <sys/un.h>
+#include <arpa/inet.h>
+#include <sys/socket.h>
+
+#include <osmocom/core/talloc.h>
+#include <osmocom/core/select.h>
+#include <osmocom/core/socket.h>
+#include <osmocom/core/write_queue.h>
+
+#include <osmocom/bb/trxcon/logging.h>
+#include <osmocom/bb/trxcon/l1ctl_server.h>
+
+#define LOGP_CLI(cli, cat, level, fmt, args...) LOGP(cat, level, "%s" fmt, (cli)->log_prefix, ##args)
+
+static int l1ctl_client_read_cb(struct osmo_fd *ofd)
+{
+ struct l1ctl_client *client = (struct l1ctl_client *)ofd->data;
+ struct msgb *msg;
+ uint16_t len;
+ int rc;
+
+ /* Attempt to read from socket */
+ rc = read(ofd->fd, &len, L1CTL_MSG_LEN_FIELD);
+ if (rc != L1CTL_MSG_LEN_FIELD) {
+ if (rc <= 0) {
+ LOGP_CLI(client, DL1D, LOGL_NOTICE, "L1CTL connection error: read() failed (rc=%d): %s\n", rc,
+ strerror(errno));
+ } else {
+ LOGP_CLI(client, DL1D, LOGL_NOTICE, "L1CTL connection error: short read\n");
+ rc = -EIO;
+ }
+ l1ctl_client_conn_close(client);
+ return rc;
+ }
+
+ /* Check message length */
+ len = ntohs(len);
+ if (len > L1CTL_LENGTH) {
+ LOGP_CLI(client, DL1D, LOGL_ERROR, "Length is too big: %u\n", len);
+ return -EINVAL;
+ }
+
+ /* Allocate a new msg */
+ msg = msgb_alloc_headroom(L1CTL_LENGTH + L1CTL_HEADROOM, L1CTL_HEADROOM, "l1ctl_rx_msg");
+ if (!msg) {
+ LOGP_CLI(client, DL1D, LOGL_ERROR, "Failed to allocate msg\n");
+ return -ENOMEM;
+ }
+
+ msg->l1h = msgb_put(msg, len);
+ rc = read(ofd->fd, msg->l1h, msgb_l1len(msg));
+ if (rc != len) {
+ LOGP_CLI(client, DL1D, LOGL_ERROR, "Can not read data: len=%d < rc=%d: %s\n", len, rc, strerror(errno));
+ msgb_free(msg);
+ return rc;
+ }
+
+ /* Debug print */
+ LOGP_CLI(client, DL1D, LOGL_DEBUG, "RX: '%s'\n", osmo_hexdump(msg->data, msg->len));
+
+ /* Call L1CTL handler */
+ client->server->cfg->conn_read_cb(client, msg);
+
+ return 0;
+}
+
+static int l1ctl_client_write_cb(struct osmo_fd *ofd, struct msgb *msg)
+{
+ struct l1ctl_client *client = (struct l1ctl_client *)ofd->data;
+ int len;
+
+ if (ofd->fd <= 0)
+ return -EINVAL;
+
+ len = write(ofd->fd, msg->data, msg->len);
+ if (len != msg->len) {
+ LOGP_CLI(client, DL1D, LOGL_ERROR, "Failed to write data: written (%d) < msg_len (%d)\n", len,
+ msg->len);
+ return -1;
+ }
+
+ return 0;
+}
+
+/* Connection handler */
+static int l1ctl_server_conn_cb(struct osmo_fd *sfd, unsigned int flags)
+{
+ struct l1ctl_server *server = (struct l1ctl_server *)sfd->data;
+ struct l1ctl_client *client;
+ int rc, client_fd;
+
+ client_fd = accept(sfd->fd, NULL, NULL);
+ if (client_fd < 0) {
+ LOGP(DL1C, LOGL_ERROR,
+ "Failed to accept() a new connection: "
+ "%s\n",
+ strerror(errno));
+ return client_fd;
+ }
+
+ if (server->cfg->num_clients_max > 0 /* 0 means unlimited */ &&
+ server->num_clients >= server->cfg->num_clients_max) {
+ LOGP(DL1C, LOGL_NOTICE,
+ "L1CTL server cannot accept more "
+ "than %u connection(s)\n",
+ server->cfg->num_clients_max);
+ close(client_fd);
+ return -ENOMEM;
+ }
+
+ client = talloc_zero(server, struct l1ctl_client);
+ if (client == NULL) {
+ LOGP(DL1C, LOGL_ERROR, "Failed to allocate an L1CTL client\n");
+ close(client_fd);
+ return -ENOMEM;
+ }
+
+ /* Init the client's write queue */
+ osmo_wqueue_init(&client->wq, 100);
+ INIT_LLIST_HEAD(&client->wq.bfd.list);
+
+ client->wq.write_cb = &l1ctl_client_write_cb;
+ client->wq.read_cb = &l1ctl_client_read_cb;
+ osmo_fd_setup(&client->wq.bfd, client_fd, OSMO_FD_READ, &osmo_wqueue_bfd_cb, client, 0);
+
+ /* Register the client's write queue */
+ rc = osmo_fd_register(&client->wq.bfd);
+ if (rc != 0) {
+ LOGP(DL1C, LOGL_ERROR, "Failed to register a new connection fd\n");
+ close(client->wq.bfd.fd);
+ talloc_free(client);
+ return rc;
+ }
+
+ llist_add_tail(&client->list, &server->clients);
+ client->id = server->next_client_id++;
+ client->server = server;
+ server->num_clients++;
+
+ LOGP(DL1C, LOGL_NOTICE, "L1CTL server got a new connection (id=%u)\n", client->id);
+
+ if (client->server->cfg->conn_accept_cb != NULL)
+ client->server->cfg->conn_accept_cb(client);
+
+ return 0;
+}
+
+int l1ctl_client_send(struct l1ctl_client *client, struct msgb *msg)
+{
+ uint8_t *len;
+
+ /* Debug print */
+ LOGP_CLI(client, DL1D, LOGL_DEBUG, "TX: '%s'\n", osmo_hexdump(msg->data, msg->len));
+
+ if (msg->l1h != msg->data)
+ LOGP_CLI(client, DL1D, LOGL_INFO, "Message L1 header != Message Data\n");
+
+ /* Prepend 16-bit length before sending */
+ len = msgb_push(msg, L1CTL_MSG_LEN_FIELD);
+ osmo_store16be(msg->len - L1CTL_MSG_LEN_FIELD, len);
+
+ if (osmo_wqueue_enqueue(&client->wq, msg) != 0) {
+ LOGP_CLI(client, DL1D, LOGL_ERROR, "Failed to enqueue msg!\n");
+ msgb_free(msg);
+ return -EIO;
+ }
+
+ return 0;
+}
+
+void l1ctl_client_conn_close(struct l1ctl_client *client)
+{
+ struct l1ctl_server *server = client->server;
+
+ LOGP_CLI(client, DL1C, LOGL_NOTICE, "Closing L1CTL connection\n");
+
+ if (server->cfg->conn_close_cb != NULL)
+ server->cfg->conn_close_cb(client);
+
+ /* Close connection socket */
+ osmo_fd_unregister(&client->wq.bfd);
+ close(client->wq.bfd.fd);
+ client->wq.bfd.fd = -1;
+
+ /* Clear pending messages */
+ osmo_wqueue_clear(&client->wq);
+
+ client->server->num_clients--;
+ llist_del(&client->list);
+ talloc_free(client);
+
+ /* If this was the last client, reset the client IDs generator to 0.
+ * This way avoid assigning huge unreadable client IDs like 26545. */
+ if (llist_empty(&server->clients))
+ server->next_client_id = 0;
+}
+
+struct l1ctl_server *l1ctl_server_alloc(void *ctx, const struct l1ctl_server_cfg *cfg)
+{
+ struct l1ctl_server *server;
+ int rc;
+
+ LOGP(DL1C, LOGL_NOTICE, "Init L1CTL server (sock_path=%s)\n", cfg->sock_path);
+
+ server = talloc(ctx, struct l1ctl_server);
+ OSMO_ASSERT(server != NULL);
+
+ *server = (struct l1ctl_server){
+ .clients = LLIST_HEAD_INIT(server->clients),
+ .cfg = cfg,
+ };
+
+ /* conn_read_cb shall not be NULL */
+ OSMO_ASSERT(cfg->conn_read_cb != NULL);
+
+ /* Bind connection handler */
+ osmo_fd_setup(&server->ofd, -1, OSMO_FD_READ, &l1ctl_server_conn_cb, server, 0);
+
+ rc = osmo_sock_unix_init_ofd(&server->ofd, SOCK_STREAM, 0, cfg->sock_path, OSMO_SOCK_F_BIND);
+ if (rc < 0) {
+ LOGP(DL1C, LOGL_ERROR, "Could not create UNIX socket: %s\n", strerror(errno));
+ talloc_free(server);
+ return NULL;
+ }
+
+ return server;
+}
+
+void l1ctl_server_free(struct l1ctl_server *server)
+{
+ LOGP(DL1C, LOGL_NOTICE, "Shutdown L1CTL server\n");
+
+ /* Close all client connections */
+ while (!llist_empty(&server->clients)) {
+ struct l1ctl_client *client = llist_entry(server->clients.next, struct l1ctl_client, list);
+ l1ctl_client_conn_close(client);
+ }
+
+ /* Unbind listening socket */
+ if (server->ofd.fd != -1) {
+ osmo_fd_unregister(&server->ofd);
+ close(server->ofd.fd);
+ server->ofd.fd = -1;
+ }
+
+ talloc_free(server);
+}
diff --git a/Transceiver52M/ms/l1ctl_server_cb.cpp b/Transceiver52M/ms/l1ctl_server_cb.cpp
new file mode 100644
index 0000000..5013871
--- /dev/null
+++ b/Transceiver52M/ms/l1ctl_server_cb.cpp
@@ -0,0 +1,77 @@
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+extern "C" {
+#include <osmocom/bb/trxcon/trxcon.h>
+#include <osmocom/bb/trxcon/trxcon_fsm.h>
+#include <osmocom/bb/trxcon/l1ctl_server.h>
+}
+
+static struct l1ctl_server_cfg server_cfg;
+static struct l1ctl_server *server = NULL;
+namespace trxcon
+{
+extern struct trxcon_inst *g_trxcon;
+}
+
+static int l1ctl_rx_cb(struct l1ctl_client *l1c, struct msgb *msg)
+{
+ struct trxcon_inst *trxcon = (struct trxcon_inst *)l1c->priv;
+
+ return trxcon_l1ctl_receive(trxcon, msg);
+}
+
+static void l1ctl_conn_accept_cb(struct l1ctl_client *l1c)
+{
+ l1c->log_prefix = talloc_strdup(l1c, trxcon::g_trxcon->log_prefix);
+ l1c->priv = trxcon::g_trxcon;
+ trxcon::g_trxcon->l2if = l1c;
+}
+
+static void l1ctl_conn_close_cb(struct l1ctl_client *l1c)
+{
+ struct trxcon_inst *trxcon = (struct trxcon_inst *)l1c->priv;
+
+ if (trxcon == NULL || trxcon->fi == NULL)
+ return;
+
+ osmo_fsm_inst_dispatch(trxcon->fi, TRXCON_EV_L2IF_FAILURE, NULL);
+}
+
+namespace trxcon
+{
+void trxc_l1ctl_init(void *tallctx)
+{
+ /* Start the L1CTL server */
+ server_cfg = (struct l1ctl_server_cfg){
+ .sock_path = "/tmp/osmocom_l2",
+ .num_clients_max = 1,
+ .conn_read_cb = &l1ctl_rx_cb,
+ .conn_accept_cb = &l1ctl_conn_accept_cb,
+ .conn_close_cb = &l1ctl_conn_close_cb,
+ };
+
+ server = l1ctl_server_alloc(tallctx, &server_cfg);
+ if (server == NULL) {
+ return;
+ }
+}
+} // namespace trxcon
\ No newline at end of file
diff --git a/Transceiver52M/ms/logging.cpp b/Transceiver52M/ms/logging.cpp
new file mode 100644
index 0000000..0857c65
--- /dev/null
+++ b/Transceiver52M/ms/logging.cpp
@@ -0,0 +1,103 @@
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+extern "C" {
+#include <osmocom/core/application.h>
+#include <osmocom/bb/trxcon/logging.h>
+#include <osmocom/bb/trxcon/trxcon.h>
+#include <osmocom/bb/l1sched/l1sched.h>
+
+}
+static const int trxcon_log_cfg[] = {
+ [TRXCON_LOGC_FSM] = DAPP,
+ [TRXCON_LOGC_L1C] = DL1C,
+ [TRXCON_LOGC_L1D] = DL1D,
+ [TRXCON_LOGC_SCHC] = DSCH,
+ [TRXCON_LOGC_SCHD] = DSCHD,
+};
+
+static struct log_info_cat trxcon_log_info_cat[] = {
+ [DAPP] = {
+ .name = "DAPP",
+ .color = "\033[1;35m",
+ .description = "Application",
+ .loglevel = LOGL_NOTICE, .enabled = 1,
+ },
+ [DL1C] = {
+ .name = "DL1C",
+ .color = "\033[1;31m",
+ .description = "Layer 1 control interface",
+ .loglevel = LOGL_NOTICE, .enabled = 1,
+ },
+ [DL1D] = {
+ .name = "DL1D",
+ .color = "\033[1;31m",
+ .description = "Layer 1 data",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 1,
+ },
+ [DTRXC] = {
+ .name = "DTRXC",
+ .color = "\033[1;33m",
+ .description = "Transceiver control interface",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 1,
+ },
+ [DTRXD] = {
+ .name = "DTRXD",
+ .color = "\033[1;33m",
+ .description = "Transceiver data interface",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 1,
+ },
+ [DSCH] = {
+ .name = "DSCH",
+ .color = "\033[1;36m",
+ .description = "Scheduler management",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 0,
+ },
+ [DSCHD] = {
+ .name = "DSCHD",
+ .color = "\033[1;36m",
+ .description = "Scheduler data",
+ .loglevel = LOGL_NOTICE,
+ .enabled = 0,
+ },
+};
+
+static struct log_info trxcon_log_info = {
+ .cat = trxcon_log_info_cat,
+ .num_cat = ARRAY_SIZE(trxcon_log_info_cat),
+};
+
+namespace trxcon
+{
+
+void trxc_log_init(void *tallctx)
+{
+ osmo_init_logging2(tallctx, &trxcon_log_info);
+ // log_parse_category_mask(osmo_stderr_target, "");
+
+ trxcon_set_log_cfg(&trxcon_log_cfg[0], ARRAY_SIZE(trxcon_log_cfg));
+}
+
+} // namespace trxcon
diff --git a/Transceiver52M/ms/ms.cpp b/Transceiver52M/ms/ms.cpp
new file mode 100644
index 0000000..3a62ed0
--- /dev/null
+++ b/Transceiver52M/ms/ms.cpp
@@ -0,0 +1,339 @@
+
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+#include "GSMCommon.h"
+#include <atomic>
+#include <cassert>
+#include <complex>
+#include <iostream>
+#include <cstdlib>
+#include <cstdio>
+#include <thread>
+#include <fstream>
+
+#include "sigProcLib.h"
+
+#include "ms.h"
+#include "ms_rx_burst.h"
+#include "grgsm_vitac/grgsm_vitac.h"
+
+extern "C" {
+#include "sch.h"
+#include "convolve.h"
+#include "convert.h"
+}
+
+dummylog ms_trx::dummy_log;
+
+#ifdef DBGXX
+const int offsetrange = 200;
+const int offset_start = -15;
+static int offset_ctr = 0;
+#endif
+
+void tx_test(ms_trx *t, ts_hitter_q_t *q, unsigned int *tsc)
+{
+ sched_param sch_params;
+ sch_params.sched_priority = sched_get_priority_max(SCHED_FIFO);
+ pthread_setschedparam(pthread_self(), SCHED_FIFO, &sch_params);
+
+ auto burst = genRandAccessBurst(0, 4, 0);
+ scaleVector(*burst, t->txFullScale * 0.7);
+
+ // float -> int16
+ blade_sample_type burst_buf[burst->size()];
+ convert_and_scale<int16_t, float>(burst_buf, burst->begin(), burst->size() * 2, 1);
+
+ while (1) {
+ GSM::Time target;
+ while (!q->spsc_pop(&target)) {
+ q->spsc_prep_pop();
+ }
+
+ std::cerr << std::endl << "\x1B[32m hitting " << target.FN() << "\033[0m" << std::endl;
+
+ int timing_advance = 0;
+ int64_t now_ts;
+ GSM::Time now_time;
+ target.incTN(3); // ul dl offset
+ int target_fn = target.FN();
+ int target_tn = target.TN();
+ t->timekeeper.get_both(&now_time, &now_ts);
+
+ auto diff_fn = GSM::FNDelta(target_fn, now_time.FN());
+ int diff_tn = (target_tn - (int)now_time.TN()) % 8;
+ auto tosend = GSM::Time(diff_fn, 0);
+
+ if (diff_tn > 0)
+ tosend.incTN(diff_tn);
+ else if (diff_tn < 0)
+ tosend.decTN(-diff_tn);
+
+ // in thory fn equal and tn+3 equal is also a problem...
+ if (diff_fn < 0 || (diff_fn == 0 && (now_time.TN() - target_tn < 1))) {
+ std::cerr << "## TX too late?! fn DIFF:" << diff_fn << " tn LOCAL: " << now_time.TN()
+ << " tn OTHER: " << target_tn << std::endl;
+ return;
+ }
+
+ auto check = now_time + tosend;
+ int64_t send_ts =
+ now_ts + tosend.FN() * 8 * ONE_TS_BURST_LEN + tosend.TN() * ONE_TS_BURST_LEN - timing_advance;
+
+#ifdef DBGXX
+ std::cerr << "## fn DIFF: " << diff_fn << " ## tn DIFF: " << diff_tn << " tn LOCAL: " << now_time.TN()
+ << " tn OTHER: " << target_tn << " tndiff" << diff_tn << " tosend:" << tosend.FN() << ":"
+ << tosend.TN() << " calc: " << check.FN() << ":" << check.TN() << " target: " << target.FN()
+ << ":" << target.TN() << " ts now: " << now_ts << " target ts:" << send_ts << std::endl;
+#endif
+
+ unsigned int pad = 4 * 25;
+ blade_sample_type buf2[burst->size() + pad];
+ memset(buf2, 0, pad * sizeof(blade_sample_type));
+ memcpy(&buf2[pad], burst_buf, burst->size() * sizeof(blade_sample_type));
+
+ assert(target.FN() == check.FN());
+ assert(target.TN() == check.TN());
+ assert(target.FN() % 51 == 21);
+#ifdef DBGXX
+ auto this_offset = offset_start + (offset_ctr++ % offsetrange);
+ std::cerr << "-- O " << this_offset << std::endl;
+ send_ts = now_ts - timing_advance +
+ ((target.FN() * 8 + (int)target.TN()) - (now_time.FN() * 8 + (int)now_time.TN())) *
+ ONE_TS_BURST_LEN;
+#endif
+ t->submit_burst_ts(buf2, burst->size() + pad, send_ts - pad);
+#ifdef DBGXX
+ signalVector test(burst->size() + pad);
+ convert_and_scale<float, int16_t>(test.begin(), buf2, burst->size() * 2 + pad, 1.f / float(scale));
+ estim_burst_params ebp;
+ auto det = detectAnyBurst(test, 0, 4, 4, CorrType::RACH, 40, &ebp);
+ if (det > 0)
+ std::cerr << "## Y " << ebp.toa << std::endl;
+ else
+ std::cerr << "## NOOOOOOOOO " << ebp.toa << std::endl;
+#endif
+ }
+}
+#ifdef SYNCTHINGONLY
+template <typename A> auto parsec(std::vector<std::string> &v, A &itr, std::string arg, bool *rv)
+{
+ if (*itr == arg) {
+ *rv = true;
+ return true;
+ }
+ return false;
+}
+
+template <typename A, typename B, typename C>
+bool parsec(std::vector<std::string> &v, A &itr, std::string arg, B f, C *rv)
+{
+ if (*itr == arg) {
+ itr++;
+ if (itr != v.end()) {
+ *rv = f(itr->c_str());
+ return true;
+ }
+ }
+ return false;
+}
+template <typename A> bool parsec(std::vector<std::string> &v, A &itr, std::string arg, int scale, int *rv)
+{
+ return parsec(
+ v, itr, arg, [scale](const char *v) -> auto{ return atoi(v) * scale; }, rv);
+}
+template <typename A> bool parsec(std::vector<std::string> &v, A &itr, std::string arg, int scale, unsigned int *rv)
+{
+ return parsec(
+ v, itr, arg, [scale](const char *v) -> auto{ return atoi(v) * scale; }, rv);
+}
+
+int main(int argc, char *argv[])
+{
+ cpu_set_t cpuset;
+
+ CPU_ZERO(&cpuset);
+ CPU_SET(2, &cpuset);
+
+ auto rv = pthread_setaffinity_np(pthread_self(), sizeof(cpuset), &cpuset);
+ if (rv < 0) {
+ std::cerr << "affinity: errreur! " << std::strerror(errno);
+ return 0;
+ }
+
+ unsigned int default_tx_freq(881000 * 1000), default_rx_freq(926000 * 1000);
+ unsigned int grx = 20, gtx = 20;
+ bool tx_flag = false;
+ pthread_setname_np(pthread_self(), "main");
+ convolve_init();
+ convert_init();
+ sigProcLibSetup();
+ initvita();
+
+ int status = 0;
+ auto trx = new ms_trx();
+ trx->do_auto_gain = true;
+
+ std::vector<std::string> args(argv + 1, argv + argc);
+ for (auto i = args.begin(); i != args.end(); ++i) {
+ parsec(args, i, "-r", 1000, &default_rx_freq);
+ parsec(args, i, "-t", 1000, &default_tx_freq);
+ parsec(args, i, "-gr", 1, &grx);
+ parsec(args, i, "-gt", 1, >x);
+ parsec(args, i, "-tx", &tx_flag);
+ }
+
+ std::cerr << "usage: " << argv[0] << " <rxfreq in khz, i.e. 926000> [txfreq in khz, i.e. 881000] [TX]"
+ << std::endl
+ << "rx" << (argc == 1 ? " (default) " : " ") << default_rx_freq << "hz, tx " << default_tx_freq
+ << "hz" << std::endl
+ << "gain rx " << grx << " gain tx " << gtx << std::endl
+ << (tx_flag ? "##!!## RACH TX ACTIVE ##!!##" : "-- no rach tx --") << std::endl;
+
+ status = trx->init_dev_and_streams();
+ if (status < 0)
+ return status;
+ trx->tuneRx(default_rx_freq);
+ trx->tuneTx(default_tx_freq);
+ trx->setRxGain(grx);
+ trx->setTxGain(gtx);
+
+ if (status == 0) {
+ // FIXME: hacks! needs exit flag for detached threads!
+
+ std::thread(rcv_bursts_test, &trx->rxqueue, &trx->mTSC, trx->rxFullScale).detach();
+ if (tx_flag)
+ std::thread(tx_test, trx, &trx->ts_hitter_q, &trx->mTSC).detach();
+ trx->start();
+ do {
+ sleep(1);
+ } while (1);
+
+ trx->stop_threads();
+ }
+ delete trx;
+
+ return status;
+}
+#endif
+
+int ms_trx::init_dev_and_streams()
+{
+ int status = 0;
+ status = base::init_device(rx_bh(), tx_bh());
+ if (status < 0) {
+ std::cerr << "failed to init dev!" << std::endl;
+ return -1;
+ }
+ return status;
+}
+
+bh_fn_t ms_trx::rx_bh()
+{
+ return [this](dev_buf_t *rcd) -> int {
+ if (this->search_for_sch(rcd) == SCH_STATE::FOUND)
+ this->grab_bursts(rcd);
+ return 0;
+ };
+}
+
+bh_fn_t ms_trx::tx_bh()
+{
+ return [this](dev_buf_t *rcd) -> int {
+#pragma unused(rcd)
+ auto y = this;
+#pragma unused(y)
+ /* nothing to do here */
+ return 0;
+ };
+}
+
+void ms_trx::start()
+{
+ auto fn = get_rx_burst_handler_fn(rx_bh());
+ rx_task = std::thread(fn);
+ set_name_aff_sched(rx_task.native_handle(), "rxrun", 2, SCHED_FIFO, sched_get_priority_max(SCHED_FIFO) - 2);
+
+ usleep(1000);
+ auto fn2 = get_tx_burst_handler_fn(tx_bh());
+ tx_task = std::thread(fn2);
+ set_name_aff_sched(tx_task.native_handle(), "txrun", 2, SCHED_FIFO, sched_get_priority_max(SCHED_FIFO) - 1);
+}
+
+void ms_trx::set_upper_ready(bool is_ready)
+{
+ upper_is_ready = is_ready;
+}
+
+void ms_trx::stop_threads()
+{
+ std::cerr << "killing threads...\r\n" << std::endl;
+ close_device();
+ rx_task.join();
+ tx_task.join();
+}
+
+void ms_trx::submit_burst(blade_sample_type *buffer, int len, GSM::Time target)
+{
+ int64_t now_ts;
+ GSM::Time now_time;
+ target.incTN(3); // ul dl offset
+ int target_fn = target.FN();
+ int target_tn = target.TN();
+ timekeeper.get_both(&now_time, &now_ts);
+
+ auto diff_fn = GSM::FNDelta(target_fn, now_time.FN());
+ int diff_tn = (target_tn - (int)now_time.TN()) % 8;
+ auto tosend = GSM::Time(diff_fn, 0);
+
+ if (diff_tn > 0)
+ tosend.incTN(diff_tn);
+ else
+ tosend.decTN(-diff_tn);
+
+ // in thory fn equal and tn+3 equal is also a problem...
+ if (diff_fn < 0 || (diff_fn == 0 && (now_time.TN() - target_tn < 1))) {
+ std::cerr << "## TX too late?! fn DIFF:" << diff_fn << " tn LOCAL: " << now_time.TN()
+ << " tn OTHER: " << target_tn << std::endl;
+ return;
+ }
+
+ auto check = now_time + tosend;
+ int64_t send_ts = now_ts + tosend.FN() * 8 * ONE_TS_BURST_LEN + tosend.TN() * ONE_TS_BURST_LEN - timing_advance;
+#ifdef DBGXX
+ std::cerr << "## fn DIFF: " << diff_fn << " ## tn DIFF: " << diff_tn << " tn LOCAL/OTHER: " << now_time.TN()
+ << "/" << target_tn << " tndiff" << diff_tn << " tosend:" << tosend.FN() << ":" << tosend.TN()
+ << " check: " << check.FN() << ":" << check.TN() << " target: " << target.FN() << ":" << target.TN()
+ << " ts now: " << now_ts << " target ts:" << send_ts << std::endl;
+#endif
+#if 1
+ unsigned int pad = 4 * 4;
+ blade_sample_type buf2[len + pad];
+ memset(buf2, 0, pad * sizeof(blade_sample_type));
+ memcpy(&buf2[pad], buffer, len * sizeof(blade_sample_type));
+
+ assert(target.FN() == check.FN());
+ assert(target.TN() == check.TN());
+ submit_burst_ts(buf2, len + pad, send_ts - pad);
+#else
+ submit_burst_ts(buffer, len, send_ts);
+#endif
+}
diff --git a/Transceiver52M/ms/ms.h b/Transceiver52M/ms/ms.h
new file mode 100644
index 0000000..8b781a3
--- /dev/null
+++ b/Transceiver52M/ms/ms.h
@@ -0,0 +1,264 @@
+#pragma once
+
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include <atomic>
+#include <cassert>
+#include <complex>
+#include <cstdint>
+#include <mutex>
+#include <iostream>
+#include <thread>
+
+#if defined(BUILDBLADE)
+#include "bladerf_specific.h"
+#define BASET blade_hw<ms_trx>
+#elif defined(BUILDUHD)
+#include "uhd_specific.h"
+#define BASET uhd_hw<ms_trx>
+#elif defined(BUILDIPC)
+#include "ipc_specific.h"
+#define BASET ipc_hw<ms_trx>
+#else
+#error wat? no device..
+#endif
+
+#include "GSMCommon.h"
+#include "itrq.h"
+
+const unsigned int ONE_TS_BURST_LEN = (3 + 58 + 26 + 58 + 3 + 8.25) * 4 /*sps*/;
+const unsigned int NUM_RXQ_FRAMES = 1; // rx thread <-> upper rx queue
+const unsigned int SCH_LEN_SPS = (ONE_TS_BURST_LEN * 8 /*ts*/ * 12 /*frames*/);
+
+template <typename T> void clamp_array(T *start2, unsigned int len, T max)
+{
+ for (int i = 0; i < len; i++) {
+ const T t1 = start2[i] < -max ? -max : start2[i];
+ const T t2 = t1 > max ? max : t1;
+ start2[i] = t2;
+ }
+}
+template <typename DST_T, typename SRC_T, typename ST>
+void convert_and_scale(void *dst, void *src, unsigned int src_len, ST scale)
+{
+ for (unsigned int i = 0; i < src_len; i++)
+ reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale;
+}
+template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len)
+{
+ return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR);
+}
+
+struct one_burst {
+ one_burst()
+ {
+ }
+ GSM::Time gsmts;
+ union {
+ blade_sample_type burst[ONE_TS_BURST_LEN];
+ char sch_bits[148];
+ };
+};
+
+using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>;
+
+enum class SCH_STATE { SEARCHING, FOUND };
+
+class dummylog : private std::streambuf {
+ std::ostream null_stream;
+
+ public:
+ dummylog() : null_stream(this){};
+ ~dummylog() override{};
+ std::ostream &operator()()
+ {
+ return null_stream;
+ }
+ int overflow(int c) override
+ {
+ return c;
+ }
+};
+
+// keeps relationship between gsm time and (continuously adjusted) ts
+class time_keeper {
+ GSM::Time global_time_keeper;
+ int64_t global_ts_keeper;
+ std::mutex m;
+
+ public:
+ time_keeper() : global_time_keeper(0), global_ts_keeper(0)
+ {
+ }
+
+ void set(GSM::Time t, int64_t ts)
+ {
+ std::lock_guard<std::mutex> g(m);
+ global_time_keeper = t;
+ global_ts_keeper = ts;
+ }
+ void inc_both()
+ {
+ std::lock_guard<std::mutex> g(m);
+ global_time_keeper.incTN(1);
+ global_ts_keeper += ONE_TS_BURST_LEN;
+ }
+ void inc_and_update(int64_t new_ts)
+ {
+ std::lock_guard<std::mutex> g(m);
+ global_time_keeper.incTN(1);
+ global_ts_keeper = new_ts;
+ // std::cerr << "u " << new_ts << std::endl;
+ }
+ void inc_and_update_safe(int64_t new_ts)
+ {
+ std::lock_guard<std::mutex> g(m);
+ auto diff = new_ts - global_ts_keeper;
+ assert(diff < 1.5 * ONE_TS_BURST_LEN);
+ assert(diff > 0.5 * ONE_TS_BURST_LEN);
+ global_time_keeper.incTN(1);
+ global_ts_keeper = new_ts;
+ // std::cerr << "s " << new_ts << std::endl;
+ }
+ void dec_by_one()
+ {
+ std::lock_guard<std::mutex> g(m);
+ global_time_keeper.decTN(1);
+ global_ts_keeper -= ONE_TS_BURST_LEN;
+ }
+ auto get_ts()
+ {
+ std::lock_guard<std::mutex> g(m);
+ return global_ts_keeper;
+ }
+ auto gsmtime()
+ {
+ std::lock_guard<std::mutex> g(m);
+ return global_time_keeper;
+ }
+ void get_both(GSM::Time *t, int64_t *ts)
+ {
+ std::lock_guard<std::mutex> g(m);
+ *t = global_time_keeper;
+ *ts = global_ts_keeper;
+ }
+};
+
+using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>;
+
+struct ms_trx : public BASET {
+ using base = BASET;
+ static dummylog dummy_log;
+ unsigned int mTSC;
+ unsigned int mBSIC;
+ int timing_advance;
+ bool do_auto_gain;
+
+ std::thread rx_task;
+ std::thread tx_task;
+ std::thread *calcrval_task;
+
+ // provides bursts to upper rx thread
+ rx_queue_t rxqueue;
+#ifdef SYNCTHINGONLY
+ ts_hitter_q_t ts_hitter_q;
+#endif
+ blade_sample_type *first_sch_buf;
+ blade_sample_type *burst_copy_buffer;
+
+ uint64_t first_sch_buf_rcv_ts;
+ std::atomic<bool> rcv_done;
+ std::atomic<bool> sch_thread_done;
+
+ int64_t temp_ts_corr_offset = 0;
+ int64_t first_sch_ts_start = -1;
+
+ time_keeper timekeeper;
+
+ void start();
+ std::atomic<bool> upper_is_ready;
+ void set_upper_ready(bool is_ready);
+
+ bool handle_sch_or_nb();
+ bool handle_sch(bool first = false);
+ bool decode_sch(float *bits, bool update_global_clock);
+ SCH_STATE search_for_sch(dev_buf_t *rcd);
+ void grab_bursts(dev_buf_t *rcd) __attribute__((optnone));
+
+ int init_device();
+ int init_dev_and_streams();
+ void stop_threads();
+ void *rx_cb(ms_trx *t);
+ void *tx_cb();
+ void maybe_update_gain(one_burst &brst);
+
+ ms_trx()
+ : timing_advance(0), do_auto_gain(false), rxqueue(), first_sch_buf(new blade_sample_type[SCH_LEN_SPS]),
+ burst_copy_buffer(new blade_sample_type[ONE_TS_BURST_LEN]), rcv_done{ false }, sch_thread_done{ false }
+ {
+ }
+
+ virtual ~ms_trx()
+ {
+ delete[] burst_copy_buffer;
+ delete[] first_sch_buf;
+ }
+ bh_fn_t rx_bh();
+ bh_fn_t tx_bh();
+
+ void submit_burst(blade_sample_type *buffer, int len, GSM::Time);
+ void set_ta(int val)
+ {
+ assert(val > -127 && val < 128);
+ timing_advance = val * 4;
+ }
+
+ void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio)
+ {
+ set_name_aff_sched(pthread_self(), name, cpunum, schedtype, prio);
+ }
+
+ void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype,
+ int prio)
+ {
+ pthread_setname_np(h, name);
+
+ cpu_set_t cpuset;
+
+ CPU_ZERO(&cpuset);
+ CPU_SET(cpunum, &cpuset);
+
+ auto rv = pthread_setaffinity_np(h, sizeof(cpuset), &cpuset);
+ if (rv < 0) {
+ std::cerr << name << " affinity: errreur! " << std::strerror(errno);
+ return exit(0);
+ }
+
+ sched_param sch_params;
+ sch_params.sched_priority = prio;
+ rv = pthread_setschedparam(h, schedtype, &sch_params);
+ if (rv < 0) {
+ std::cerr << name << " sched: errreur! " << std::strerror(errno);
+ return exit(0);
+ }
+ }
+};
diff --git a/Transceiver52M/ms/ms_rx_burst.h b/Transceiver52M/ms/ms_rx_burst.h
new file mode 100644
index 0000000..764a69e
--- /dev/null
+++ b/Transceiver52M/ms/ms_rx_burst.h
@@ -0,0 +1,25 @@
+#pragma once
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include "ms.h"
+
+void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale);
\ No newline at end of file
diff --git a/Transceiver52M/ms/ms_rx_burst_test.cpp b/Transceiver52M/ms/ms_rx_burst_test.cpp
new file mode 100644
index 0000000..69fca5e
--- /dev/null
+++ b/Transceiver52M/ms/ms_rx_burst_test.cpp
@@ -0,0 +1,207 @@
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+#include "ms.h"
+#include "sigProcLib.h"
+#include "signalVector.h"
+#include "grgsm_vitac/grgsm_vitac.h"
+extern "C" {
+#include "sch.h"
+}
+
+#if !defined(SYNCTHINGONLY) || !defined(NODAMNLOG)
+#define DBGLG(...) ms_trx::dummy_log()
+#else
+#define DBGLG(...) std::cerr
+#endif
+
+#if !defined(SYNCTHINGONLY)
+#define DBGLG2(...) ms_trx::dummy_log()
+#else
+#define DBGLG2(...) std::cerr
+#endif
+
+static bool decode_sch(float *bits, bool update_global_clock)
+{
+ struct sch_info sch;
+ ubit_t info[GSM_SCH_INFO_LEN];
+ sbit_t data[GSM_SCH_CODED_LEN];
+
+ float_to_sbit(&bits[3], &data[0], 62, 39);
+ float_to_sbit(&bits[106], &data[39], 62, 39);
+
+ if (!gsm_sch_decode(info, data)) {
+ gsm_sch_parse(info, &sch);
+
+ DBGLG() << "SCH : Decoded values" << std::endl;
+ DBGLG() << " BSIC: " << sch.bsic << std::endl;
+ DBGLG() << " TSC: " << (sch.bsic & 0x7) << std::endl;
+ DBGLG() << " T1 : " << sch.t1 << std::endl;
+ DBGLG() << " T2 : " << sch.t2 << std::endl;
+ DBGLG() << " T3p : " << sch.t3p << std::endl;
+ DBGLG() << " FN : " << gsm_sch_to_fn(&sch) << std::endl;
+ return true;
+ }
+ return false;
+}
+
+static void check_rcv_fn(GSM::Time t, bool first, unsigned int &lastfn, unsigned int &fnbm)
+{
+ if (first && t.TN() == 0) {
+ lastfn = t.FN();
+ fnbm = 1 << 0;
+ first = false;
+ }
+ if (!first && t.FN() != lastfn) {
+ if (fnbm != 255)
+ std::cerr << "rx " << lastfn << ":" << fnbm << " " << __builtin_popcount(fnbm) << std::endl;
+ lastfn = t.FN();
+ fnbm = 1 << t.TN();
+ }
+
+ fnbm |= 1 << t.TN();
+}
+
+static void handle_it(one_burst &e, signalVector &burst, unsigned int tsc, int scale)
+{
+ memset(burst.begin(), 0, burst.size() * sizeof(std::complex<float>));
+ const auto is_sch = gsm_sch_check_ts(e.gsmts.TN(), e.gsmts.FN());
+ const auto is_fcch = gsm_fcch_check_ts(e.gsmts.TN(), e.gsmts.FN());
+
+ if (is_fcch)
+ return;
+
+ if (is_sch) {
+ char outbin[148];
+ convert_and_scale_default<float, int16_t>(burst.begin(), e.burst, ONE_TS_BURST_LEN * 2);
+ std::stringstream dbgout;
+#if 0
+ {
+ struct estim_burst_params ebp;
+ auto rv2 = detectSCHBurst(burst, 4, 4, sch_detect_type::SCH_DETECT_FULL, &ebp);
+ auto bits = demodAnyBurst(burst, SCH, 4, &ebp);
+ // clamp_array(bits->begin(), 148, 1.5f);
+ for (auto &i : *bits)
+ i = (i > 0 ? 1 : -1);
+
+ auto rv = decode_sch(bits->begin(), false);
+ dbgout << "U DET@" << (rv2 ? "yes " : " ") << "Timing offset " << ebp.toa
+ << " symbols, DECODE: " << (rv ? "yes" : "---") << " ";
+
+ delete bits;
+ }
+#endif
+ {
+ convert_and_scale<float, float>(burst.begin(), burst.begin(), ONE_TS_BURST_LEN * 2,
+ 1.f / float(scale));
+
+ std::complex<float> channel_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR];
+ auto ss = reinterpret_cast<std::complex<float> *>(burst.begin());
+ int d_c0_burst_start = get_sch_chan_imp_resp(ss, &channel_imp_resp[0]);
+ detect_burst(ss, &channel_imp_resp[0], d_c0_burst_start, outbin);
+
+ SoftVector bits;
+ bits.resize(148);
+ for (int i = 0; i < 148; i++) {
+ bits[i] = (!outbin[i]); // < 1 ? -1 : 1;
+ }
+
+ auto rv = decode_sch(bits.begin(), false);
+ dbgout << "U SCH@"
+ << " " << e.gsmts.FN() << ":" << e.gsmts.TN() << " " << d_c0_burst_start
+ << " DECODE:" << (rv ? "yes" : "---") << std::endl;
+ }
+
+ DBGLG() << dbgout.str();
+ return;
+ }
+#if 1
+ convert_and_scale<float, int16_t>(burst.begin(), e.burst, ONE_TS_BURST_LEN * 2, 1.f / float(scale));
+ // std::cerr << "@" << tsc << " " << e.gsmts.FN() << ":" << e.gsmts.TN() << " " << ebp.toa << " "
+ // << std::endl;
+
+ char outbin[148];
+ auto ss = reinterpret_cast<std::complex<float> *>(burst.begin());
+ float ncmax, dcmax;
+ std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR], chan_imp_resp2[CHAN_IMP_RESP_LENGTH * d_OSR];
+ auto normal_burst_start = get_norm_chan_imp_resp(ss, &chan_imp_resp[0], &ncmax, tsc);
+ auto dummy_burst_start = get_norm_chan_imp_resp(ss, &chan_imp_resp2[0], &dcmax, TS_DUMMY);
+ auto is_nb = ncmax > dcmax;
+
+ DBGLG() << " U " << (is_nb ? "NB" : "DB") << "@ o nb: " << normal_burst_start << " o db: " << dummy_burst_start
+ << std::endl;
+
+ if (is_nb)
+ detect_burst(ss, &chan_imp_resp[0], normal_burst_start, outbin);
+ else
+ detect_burst(ss, &chan_imp_resp2[0], dummy_burst_start, outbin);
+ ;
+#ifdef DBGXX
+ // auto bits = SoftVector(148);
+ // for (int i = 0; i < 148; i++)
+ // (bits)[i] = outbin[i] < 1 ? -1 : 1;
+#endif
+#endif
+}
+
+void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale)
+{
+ static bool first = true;
+ unsigned int lastfn = 0;
+ unsigned int fnbm = 0;
+ signalVector burst(ONE_TS_BURST_LEN, 100, 100);
+
+ cpu_set_t cpuset;
+
+ CPU_ZERO(&cpuset);
+ CPU_SET(1, &cpuset);
+
+ auto rv = pthread_setaffinity_np(pthread_self(), sizeof(cpuset), &cpuset);
+ if (rv < 0) {
+ std::cerr << "affinity: errreur! " << std::strerror(errno);
+ exit(0);
+ }
+
+ int prio = sched_get_priority_max(SCHED_RR);
+ struct sched_param param;
+ param.sched_priority = prio;
+ rv = sched_setscheduler(0, SCHED_RR, ¶m);
+ if (rv < 0) {
+ std::cerr << "scheduler: errreur! " << std::strerror(errno);
+ exit(0);
+ }
+
+ while (1) {
+ one_burst e;
+ while (!q->spsc_pop(&e)) {
+ q->spsc_prep_pop();
+ }
+
+ check_rcv_fn(e.gsmts, first, lastfn, fnbm);
+
+ handle_it(e, burst, *tsc, scale);
+#ifdef DBGXX
+ rv = detectSCHBurst(*burst, 4, 4, sch_detect_type::SCH_DETECT_FULL, &ebp);
+ if (rv > 0)
+ std::cerr << "#" << e.gsmts.FN() << ":" << e.gsmts.TN() << " " << ebp.toa << std::endl;
+ sched_yield();
+#endif
+ }
+}
\ No newline at end of file
diff --git a/Transceiver52M/ms/ms_rx_lower.cpp b/Transceiver52M/ms/ms_rx_lower.cpp
new file mode 100644
index 0000000..780ab42
--- /dev/null
+++ b/Transceiver52M/ms/ms_rx_lower.cpp
@@ -0,0 +1,343 @@
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include "sigProcLib.h"
+#include "signalVector.h"
+#include <atomic>
+#include <cassert>
+#include <complex>
+#include <iostream>
+#include <future>
+
+#include "ms.h"
+#include "grgsm_vitac/grgsm_vitac.h"
+
+extern "C" {
+#include "sch.h"
+}
+
+#ifdef LOG
+#undef LOG
+#endif
+
+#if !defined(SYNCTHINGONLY) //|| !defined(NODAMNLOG)
+#define DBGLG(...) ms_trx::dummy_log()
+#else
+#define DBGLG(...) std::cerr
+#endif
+
+#if !defined(SYNCTHINGONLY) || !defined(NODAMNLOG)
+#define DBGLG2(...) ms_trx::dummy_log()
+#else
+#define DBGLG2(...) std::cerr
+#endif
+
+#define PRINT_Q_OVERFLOW
+bool ms_trx::decode_sch(float *bits, bool update_global_clock)
+{
+ int fn;
+ struct sch_info sch;
+ ubit_t info[GSM_SCH_INFO_LEN];
+ sbit_t data[GSM_SCH_CODED_LEN];
+
+ float_to_sbit(&bits[3], &data[0], 1, 39);
+ float_to_sbit(&bits[106], &data[39], 1, 39);
+
+ if (!gsm_sch_decode(info, data)) {
+ gsm_sch_parse(info, &sch);
+
+ if (update_global_clock) {
+ DBGLG() << "SCH : Decoded values" << std::endl;
+ DBGLG() << " BSIC: " << sch.bsic << std::endl;
+ DBGLG() << " TSC: " << (sch.bsic & 0x7) << std::endl;
+ DBGLG() << " T1 : " << sch.t1 << std::endl;
+ DBGLG() << " T2 : " << sch.t2 << std::endl;
+ DBGLG() << " T3p : " << sch.t3p << std::endl;
+ DBGLG() << " FN : " << gsm_sch_to_fn(&sch) << std::endl;
+ }
+
+ fn = gsm_sch_to_fn(&sch);
+ if (fn < 0) { // how? wh?
+ DBGLG() << "SCH : Failed to convert FN " << std::endl;
+ return false;
+ }
+
+ if (update_global_clock) {
+ mBSIC = sch.bsic;
+ mTSC = sch.bsic & 0x7;
+ timekeeper.set(fn, 0);
+ // global_time_keeper.FN(fn);
+ // global_time_keeper.TN(0);
+ }
+#ifdef SYNCTHINGONLY
+ else {
+ int t3 = sch.t3p * 10 + 1;
+ if (t3 == 11) {
+ // timeslot hitter attempt @ fn 21 in mf
+ DBGLG2() << "sch @ " << t3 << std::endl;
+ auto e = GSM::Time(fn, 0);
+ e += 10;
+ ts_hitter_q.spsc_push(&e);
+ }
+ }
+#endif
+
+ return true;
+ }
+ return false;
+}
+
+void ms_trx::maybe_update_gain(one_burst &brst)
+{
+ static_assert((sizeof(brst.burst) / sizeof(brst.burst[0])) == ONE_TS_BURST_LEN, "wtf, buffer size mismatch?");
+ const int avgburst_num = 8 * 20; // ~ 50*4.5ms = 90ms?
+ static_assert(avgburst_num * 577 > (50 * 1000), "can't update faster then blade wait time?");
+ const unsigned int rx_max_cutoff = (rxFullScale * 2) / 3;
+ static int gain_check = 0;
+ static float runmean = 0;
+ float sum = 0;
+ for (auto i : brst.burst)
+ sum += abs(i.real()) + abs(i.imag());
+ sum /= ONE_TS_BURST_LEN * 2;
+
+ runmean = gain_check ? (runmean * (gain_check + 2) - 1 + sum) / (gain_check + 2) : sum;
+
+ if (gain_check == avgburst_num - 1) {
+ DBGLG2() << "\x1B[32m #RXG \033[0m" << rxgain << " " << runmean << " " << sum << std::endl;
+ auto gainoffset = runmean < (rxFullScale / 4 ? 4 : 2);
+ gainoffset = runmean < (rxFullScale / 2 ? 2 : 1);
+ float newgain = runmean < rx_max_cutoff ? rxgain + gainoffset : rxgain - gainoffset;
+ // FIXME: gian cutoff
+ if (newgain != rxgain && newgain <= 60)
+ std::thread([this, newgain] { setRxGain(newgain); }).detach();
+ runmean = 0;
+ }
+ gain_check = (gain_check + 1) % avgburst_num;
+}
+
+static char sch_demod_bits[148];
+
+bool ms_trx::handle_sch_or_nb()
+{
+ one_burst brst;
+ const auto current_gsm_time = timekeeper.gsmtime();
+ const auto is_sch = gsm_sch_check_ts(current_gsm_time.TN(), current_gsm_time.FN());
+ const auto is_fcch = gsm_fcch_check_ts(current_gsm_time.TN(), current_gsm_time.FN());
+#pragma unused(is_fcch)
+
+ //either pass burst to upper layer for demod, OR pass demodded SCH to upper layer so we don't waste time processing it twice
+ brst.gsmts = current_gsm_time;
+
+ if (!is_sch) {
+ memcpy(brst.burst, burst_copy_buffer, sizeof(blade_sample_type) * ONE_TS_BURST_LEN);
+ } else {
+ handle_sch(false);
+ memcpy(brst.sch_bits, sch_demod_bits, sizeof(sch_demod_bits));
+ }
+#ifndef SYNCTHINGONLY
+ if (upper_is_ready) { // this is blocking, so only submit if there is a reader - only if upper exists!
+#endif
+ while (!rxqueue.spsc_push(&brst))
+ ;
+#ifndef SYNCTHINGONLY
+ }
+#endif
+
+ if (do_auto_gain)
+ maybe_update_gain(brst);
+
+ return false;
+}
+
+static float sch_acq_buffer[SCH_LEN_SPS * 2];
+
+bool ms_trx::handle_sch(bool is_first_sch_acq)
+{
+ auto current_gsm_time = timekeeper.gsmtime();
+ const auto buf_len = is_first_sch_acq ? SCH_LEN_SPS : ONE_TS_BURST_LEN;
+ const auto which_in_buffer = is_first_sch_acq ? first_sch_buf : burst_copy_buffer;
+ const auto which_out_buffer = is_first_sch_acq ? sch_acq_buffer : &sch_acq_buffer[40 * 2];
+ const auto ss = reinterpret_cast<std::complex<float> *>(which_out_buffer);
+ std::complex<float> channel_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR];
+
+ int start;
+ memset((void *)&sch_acq_buffer[0], 0, sizeof(sch_acq_buffer));
+ if (is_first_sch_acq) {
+ float max_corr = 0;
+ convert_and_scale<float, int16_t>(which_out_buffer, which_in_buffer, buf_len * 2,
+ 1.f / float(rxFullScale));
+ start = get_sch_buffer_chan_imp_resp(ss, &channel_imp_resp[0], buf_len, &max_corr);
+ detect_burst(&ss[start], &channel_imp_resp[0], 0, sch_demod_bits);
+ } else {
+ convert_and_scale<float, int16_t>(which_out_buffer, which_in_buffer, buf_len * 2,
+ 1.f / float(rxFullScale));
+ start = get_sch_chan_imp_resp(ss, &channel_imp_resp[0]);
+ start = start < 39 ? start : 39;
+ start = start > -39 ? start : -39;
+ detect_burst(&ss[start], &channel_imp_resp[0], 0, sch_demod_bits);
+ }
+
+ SoftVector bitss(148);
+ for (int i = 0; i < 148; i++) {
+ bitss[i] = (sch_demod_bits[i]);
+ }
+
+ auto sch_decode_success = decode_sch(bitss.begin(), is_first_sch_acq);
+
+ if (sch_decode_success) {
+ const auto ts_offset_symb = 0;
+ if (is_first_sch_acq) {
+ // update ts to first sample in sch buffer, to allow delay calc for current ts
+ first_sch_ts_start = first_sch_buf_rcv_ts + start - (ts_offset_symb * 4) - 1;
+ } else if (abs(start) > 1) {
+ // continuous sch tracking, only update if off too much
+ temp_ts_corr_offset += -start;
+ std::cerr << "offs: " << start << " " << temp_ts_corr_offset << std::endl;
+ }
+
+ return true;
+ } else {
+ DBGLG2() << "L SCH : \x1B[31m decode fail \033[0m @ toa:" << start << " " << current_gsm_time.FN()
+ << ":" << current_gsm_time.TN() << std::endl;
+ }
+ return false;
+}
+
+__attribute__((xray_never_instrument)) SCH_STATE ms_trx::search_for_sch(dev_buf_t *rcd)
+{
+ static unsigned int sch_pos = 0;
+ if (sch_thread_done)
+ return SCH_STATE::FOUND;
+
+ if (rcv_done)
+ return SCH_STATE::SEARCHING;
+
+ auto to_copy = SCH_LEN_SPS - sch_pos;
+
+ if (SCH_LEN_SPS == to_copy) // first time
+ first_sch_buf_rcv_ts = rcd->get_first_ts();
+
+ if (!to_copy) {
+ sch_pos = 0;
+ rcv_done = true;
+ std::thread([this] {
+ set_name_aff_sched("sch_search", 1, SCHED_FIFO, sched_get_priority_max(SCHED_FIFO) - 5);
+
+ auto ptr = reinterpret_cast<const int16_t *>(first_sch_buf);
+ const auto target_val = rxFullScale / 8;
+ float sum = 0;
+ for (int i = 0; i < SCH_LEN_SPS * 2; i++)
+ sum += std::abs(ptr[i]);
+ sum /= SCH_LEN_SPS * 2;
+
+ //FIXME: arbitrary value, gain cutoff
+ if (sum > target_val || rxgain >= 60) // enough ?
+ sch_thread_done = this->handle_sch(true);
+ else {
+ std::cerr << "\x1B[32m #RXG \033[0m gain " << rxgain << " -> " << rxgain + 4
+ << " sample avg:" << sum << " target: >=" << target_val << std::endl;
+ setRxGain(rxgain + 4);
+ }
+
+ if (!sch_thread_done)
+ rcv_done = false; // retry!
+ return (bool)sch_thread_done;
+ }).detach();
+ }
+
+ auto spsmax = rcd->actual_samples_per_buffer();
+ if (to_copy > spsmax)
+ sch_pos += rcd->readall(first_sch_buf + sch_pos);
+ else
+ sch_pos += rcd->read_n(first_sch_buf + sch_pos, 0, to_copy);
+
+ return SCH_STATE::SEARCHING;
+}
+
+void ms_trx::grab_bursts(dev_buf_t *rcd)
+{
+ // partial burst samples read from the last buffer
+ static int partial_rdofs = 0;
+ static bool first_call = true;
+ int to_skip = 0;
+
+ // round up to next burst by calculating the time between sch detection and now
+ if (first_call) {
+ const auto next_burst_start = rcd->get_first_ts() - first_sch_ts_start;
+ const auto fullts = next_burst_start / ONE_TS_BURST_LEN;
+ const auto fracts = next_burst_start % ONE_TS_BURST_LEN;
+ to_skip = ONE_TS_BURST_LEN - fracts;
+
+ for (int i = 0; i < fullts; i++)
+ timekeeper.inc_and_update(first_sch_ts_start + i * ONE_TS_BURST_LEN);
+
+ if (fracts)
+ timekeeper.inc_both();
+ // timekeeper.inc_and_update(first_sch_ts_start + 1 * ONE_TS_BURST_LEN);
+
+ timekeeper.dec_by_one(); // oops, off by one?
+
+ timekeeper.set(timekeeper.gsmtime(), rcd->get_first_ts() - ONE_TS_BURST_LEN + to_skip);
+
+ DBGLG() << "this ts: " << rcd->get_first_ts() << " diff full TN: " << fullts << " frac TN: " << fracts
+ << " GSM now: " << timekeeper.gsmtime().FN() << ":" << timekeeper.gsmtime().TN() << " is sch? "
+ << gsm_sch_check_fn(timekeeper.gsmtime().FN()) << std::endl;
+ first_call = false;
+ }
+
+ if (partial_rdofs) {
+ auto first_remaining = ONE_TS_BURST_LEN - partial_rdofs;
+ auto rd = rcd->read_n(burst_copy_buffer + partial_rdofs, 0, first_remaining);
+ if (rd != first_remaining) {
+ partial_rdofs += rd;
+ return;
+ }
+
+ timekeeper.inc_and_update_safe(rcd->get_first_ts() - partial_rdofs);
+ handle_sch_or_nb();
+ to_skip = first_remaining;
+ }
+
+ // apply sample rate slippage compensation
+ to_skip -= temp_ts_corr_offset;
+
+ // FIXME: happens rarely, read_n start -1 blows up
+ // this is fine: will just be corrected one buffer later
+ if (to_skip < 0)
+ to_skip = 0;
+ else
+ temp_ts_corr_offset = 0;
+
+ const auto left_after_burst = rcd->actual_samples_per_buffer() - to_skip;
+
+ const int full = left_after_burst / ONE_TS_BURST_LEN;
+ const int frac = left_after_burst % ONE_TS_BURST_LEN;
+
+ for (int i = 0; i < full; i++) {
+ rcd->read_n(burst_copy_buffer, to_skip + i * ONE_TS_BURST_LEN, ONE_TS_BURST_LEN);
+ timekeeper.inc_and_update_safe(rcd->get_first_ts() + to_skip + i * ONE_TS_BURST_LEN);
+ handle_sch_or_nb();
+ }
+
+ if (frac)
+ rcd->read_n(burst_copy_buffer, to_skip + full * ONE_TS_BURST_LEN, frac);
+ partial_rdofs = frac;
+}
diff --git a/Transceiver52M/ms/ms_upper.cpp b/Transceiver52M/ms/ms_upper.cpp
new file mode 100644
index 0000000..dd25fd2
--- /dev/null
+++ b/Transceiver52M/ms/ms_upper.cpp
@@ -0,0 +1,451 @@
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include "sigProcLib.h"
+#include "ms.h"
+#include <signalVector.h>
+#include <radioVector.h>
+#include <radioInterface.h>
+#include "grgsm_vitac/grgsm_vitac.h"
+
+extern "C" {
+#include <osmocom/core/select.h>
+#include "sch.h"
+#include "convolve.h"
+#include "convert.h"
+#include "proto_trxd.h"
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <string.h>
+#include <getopt.h>
+#include <unistd.h>
+#include <signal.h>
+#include <errno.h>
+#include <time.h>
+
+#ifdef LSANDEBUG
+void __lsan_do_recoverable_leak_check();
+#endif
+}
+
+#include "ms_upper.h"
+
+namespace trxcon
+{
+extern "C" {
+#include <osmocom/core/fsm.h>
+#include <osmocom/core/msgb.h>
+#include <osmocom/core/talloc.h>
+#include <osmocom/core/signal.h>
+#include <osmocom/core/select.h>
+#include <osmocom/core/gsmtap_util.h>
+#include <osmocom/core/gsmtap.h>
+
+// #include <osmocom/core/application.h>
+#include <osmocom/core/logging.h>
+#include <osmocom/bb/trxcon/logging.h>
+
+#include <osmocom/bb/trxcon/trxcon.h>
+#include <osmocom/bb/trxcon/trxcon_fsm.h>
+#include <osmocom/bb/trxcon/phyif.h>
+#include <osmocom/bb/trxcon/trx_if.h>
+#include <osmocom/bb/trxcon/l1ctl_server.h>
+
+#include <osmocom/bb/l1sched/l1sched.h>
+// #include <osmocom/bb/l1sched/logging.h>
+}
+struct trxcon_inst *g_trxcon;
+// trx_instance *trxcon_instance; // local handle
+struct internal_q_tx_buf {
+ trxcon_phyif_burst_req r;
+ uint8_t buf[148];
+};
+using tx_queue_t = spsc_cond<8 * 1, internal_q_tx_buf, true, false>;
+using cmd_queue_t = spsc_cond<8 * 1, trxcon_phyif_cmd, true, false>;
+using cmdr_queue_t = spsc_cond<8 * 1, trxcon_phyif_rsp, false, false>;
+static tx_queue_t txq;
+static cmd_queue_t cmdq_to_phy;
+static cmdr_queue_t cmdq_from_phy;
+
+extern void trxc_log_init(void *tallctx);
+extern void trxc_l1ctl_init(void *tallctx);
+
+} // namespace trxcon
+
+#ifdef LOG
+#undef LOG
+#define LOG(...) upper_trx::dummy_log()
+#endif
+
+#define DBGLG(...) upper_trx::dummy_log()
+
+void upper_trx::start_threads()
+{
+ thr_control = std::thread([this] {
+ set_name_aff_sched("upper_ctrl", 1, SCHED_RR, sched_get_priority_max(SCHED_RR));
+ while (1) {
+ driveControl();
+ }
+ });
+ msleep(1);
+ thr_tx = std::thread([this] {
+ set_name_aff_sched("upper_tx", 1, SCHED_FIFO, sched_get_priority_max(SCHED_FIFO) - 1);
+ while (1) {
+ driveTx();
+ }
+ });
+
+ // atomic ensures data is not written to q until loop reads
+ start_lower_ms();
+
+ set_name_aff_sched("upper_rx", 1, SCHED_FIFO, sched_get_priority_max(SCHED_RR) - 5);
+ while (1) {
+ // set_upper_ready(true);
+ driveReceiveFIFO();
+ osmo_select_main(1);
+
+ trxcon::trxcon_phyif_rsp r;
+ if (trxcon::cmdq_from_phy.spsc_pop(&r)) {
+ DBGLG() << "HAVE RESP:" << r.type << std::endl;
+ trxcon_phyif_handle_rsp(trxcon::g_trxcon, &r);
+ }
+ }
+
+#ifdef LSANDEBUG
+ std::thread([this] {
+ set_name_aff_sched("leakcheck", 1, SCHED_FIFO, sched_get_priority_max(SCHED_FIFO) - 10);
+
+ while (1) {
+ std::this_thread::sleep_for(std::chrono::seconds{ 5 });
+ __lsan_do_recoverable_leak_check();
+ }
+ }).detach();
+#endif
+}
+
+void upper_trx::start_lower_ms()
+{
+ ms_trx::start();
+}
+
+bool upper_trx::pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset)
+{
+ float pow, avg = 1.0;
+ static complex workbuf[40 + 625 + 40];
+ static signalVector sv(workbuf, 40, 625);
+ one_burst e;
+ auto ss = reinterpret_cast<std::complex<float> *>(&workbuf[40]);
+ memset((void *)&workbuf[0], 0, sizeof(workbuf));
+ // assert(sv.begin() == &workbuf[40]);
+
+ while (!rxqueue.spsc_pop(&e)) {
+ rxqueue.spsc_prep_pop();
+ }
+
+ wTime = e.gsmts;
+
+ const auto is_sch = gsm_sch_check_ts(wTime.TN(), wTime.FN());
+ const auto is_fcch = gsm_fcch_check_ts(wTime.TN(), wTime.FN());
+
+ trxcon::trxcon_phyif_rtr_ind i = { static_cast<uint32_t>(wTime.FN()), static_cast<uint8_t>(wTime.TN()) };
+ trxcon::trxcon_phyif_rtr_rsp r = {};
+ trxcon_phyif_handle_rtr_ind(trxcon::g_trxcon, &i, &r);
+ if (!(r.flags & TRXCON_PHYIF_RTR_F_ACTIVE))
+ return false;
+
+ if (is_fcch) {
+ // return trash
+ return true;
+ }
+
+ if (is_sch) {
+ for (int i = 0; i < 148; i++)
+ (demodded_softbits)[i] = (e.sch_bits[i]);
+ RSSI = 10;
+ timingOffset = 0;
+ return true;
+ }
+
+ convert_and_scale<float, int16_t>(ss, e.burst, ONE_TS_BURST_LEN * 2, 1.f / float(rxFullScale));
+
+ pow = energyDetect(sv, 20 * 4 /*sps*/);
+ if (pow < -1) {
+ LOG(ALERT) << "Received empty burst";
+ return false;
+ }
+
+ avg = sqrt(pow);
+ {
+ float ncmax;
+ std::complex<float> chan_imp_resp[CHAN_IMP_RESP_LENGTH * d_OSR];
+ auto normal_burst_start = get_norm_chan_imp_resp(ss, &chan_imp_resp[0], &ncmax, mTSC);
+#ifdef DBGXX
+ float dcmax;
+ std::complex<float> chan_imp_resp2[CHAN_IMP_RESP_LENGTH * d_OSR];
+ auto dummy_burst_start = get_norm_chan_imp_resp(ss, &chan_imp_resp2[0], &dcmax, TS_DUMMY);
+ auto is_nb = ncmax > dcmax;
+ // DBGLG() << " U " << (is_nb ? "NB" : "DB") << "@ o nb: " << normal_burst_start
+ // << " o db: " << dummy_burst_start << std::endl;
+#endif
+ normal_burst_start = normal_burst_start < 39 ? normal_burst_start : 39;
+ normal_burst_start = normal_burst_start > -39 ? normal_burst_start : -39;
+#ifdef DBGXX
+ // fprintf(stderr, "%s %d\n", (is_nb ? "N":"D"), burst_time.FN());
+ // if (is_nb)
+#endif
+ detect_burst(ss, &chan_imp_resp[0], normal_burst_start, demodded_softbits);
+#ifdef DBGXX
+ // else
+ // detect_burst(ss, &chan_imp_resp2[0], dummy_burst_start, outbin);
+#endif
+ }
+ RSSI = (int)floor(20.0 * log10(rxFullScale / avg));
+ timingOffset = (int)round(0);
+
+ return true;
+}
+
+void upper_trx::driveReceiveFIFO()
+{
+ int RSSI;
+ int TOA; // in 1/256 of a symbol
+ GSM::Time burstTime;
+
+ if (!mOn)
+ return;
+
+ if (pullRadioVector(burstTime, RSSI, TOA)) {
+ // trxcon::trx_data_rx_handler(trxcon::trxcon_instance, (uint8_t *)&response);
+ trxcon::trxcon_phyif_burst_ind bi;
+ bi.fn = burstTime.FN();
+ bi.tn = burstTime.TN();
+ bi.rssi = RSSI;
+ bi.toa256 = TOA;
+ bi.burst = (sbit_t *)demodded_softbits;
+ bi.burst_len = sizeof(demodded_softbits);
+ // trxcon_phyif_handle_clock_ind(trxcon::g_trxcon, bi.fn);
+ trxcon_phyif_handle_burst_ind(trxcon::g_trxcon, &bi);
+ }
+
+ struct trxcon::trxcon_phyif_rts_ind rts {
+ static_cast<uint32_t>(burstTime.FN()), static_cast<uint8_t>(burstTime.TN())
+ };
+ trxcon_phyif_handle_rts_ind(trxcon::g_trxcon, &rts);
+}
+
+void upper_trx::driveTx()
+{
+ trxcon::internal_q_tx_buf e;
+ while (!trxcon::txq.spsc_pop(&e)) {
+ trxcon::txq.spsc_prep_pop();
+ }
+
+ trxcon::internal_q_tx_buf *burst = &e;
+
+#ifdef TXDEBUG
+ DBGLG() << "got burst!" << burst->r.fn << ":" << burst->ts << " current: " << timekeeper.gsmtime().FN()
+ << " dff: " << (int64_t)((int64_t)timekeeper.gsmtime().FN() - (int64_t)burst->r.fn) << std::endl;
+#endif
+
+ auto currTime = GSM::Time(burst->r.fn, burst->r.tn);
+ int RSSI = (int)burst->r.pwr;
+
+ static BitVector newBurst(gSlotLen);
+ BitVector::iterator itr = newBurst.begin();
+ auto *bufferItr = burst->buf;
+ while (itr < newBurst.end())
+ *itr++ = *bufferItr++;
+
+ auto txburst = modulateBurst(newBurst, 8 + (currTime.TN() % 4 == 0), 4);
+ scaleVector(*txburst, txFullScale * pow(10, -RSSI / 10));
+
+ // float -> int16
+ blade_sample_type burst_buf[txburst->size()];
+ convert_and_scale<int16_t, float>(burst_buf, txburst->begin(), txburst->size() * 2, 1);
+#ifdef TXDEBUG
+ auto check = signalVector(txburst->size(), 40);
+ convert_and_scale<float, int16_t, 1>(check.begin(), burst_buf, txburst->size() * 2);
+ estim_burst_params ebp;
+ auto d = detectAnyBurst(check, 2, 4, 4, CorrType::RACH, 40, &ebp);
+ if (d)
+ DBGLG() << "RACH D! " << ebp.toa << std::endl;
+ else
+ DBGLG() << "RACH NOOOOOOOOOO D! " << ebp.toa << std::endl;
+
+ // memory read --binary --outfile /tmp/mem.bin &burst_buf[0] --count 2500 --force
+#endif
+ submit_burst(burst_buf, txburst->size(), currTime);
+ delete txburst;
+}
+
+static const char *cmd2str(trxcon::trxcon_phyif_cmd_type c)
+{
+ switch (c) {
+ case trxcon::TRXCON_PHYIF_CMDT_RESET:
+ return "TRXCON_PHYIF_CMDT_RESET";
+ case trxcon::TRXCON_PHYIF_CMDT_POWERON:
+ return "TRXCON_PHYIF_CMDT_POWERON";
+ case trxcon::TRXCON_PHYIF_CMDT_POWEROFF:
+ return "TRXCON_PHYIF_CMDT_POWEROFF";
+ case trxcon::TRXCON_PHYIF_CMDT_MEASURE:
+ return "TRXCON_PHYIF_CMDT_MEASURE";
+ case trxcon::TRXCON_PHYIF_CMDT_SETFREQ_H0:
+ return "TRXCON_PHYIF_CMDT_SETFREQ_H0";
+ case trxcon::TRXCON_PHYIF_CMDT_SETFREQ_H1:
+ return "TRXCON_PHYIF_CMDT_SETFREQ_H1";
+ case trxcon::TRXCON_PHYIF_CMDT_SETSLOT:
+ return "TRXCON_PHYIF_CMDT_SETSLOT";
+ case trxcon::TRXCON_PHYIF_CMDT_SETTA:
+ return "TRXCON_PHYIF_CMDT_SETTA";
+ default:
+ return "UNKNOWN COMMAND!";
+ }
+}
+
+static void print_cmd(trxcon::trxcon_phyif_cmd_type c)
+{
+ DBGLG() << cmd2str(c) << std::endl;
+}
+
+bool upper_trx::driveControl()
+{
+ trxcon::trxcon_phyif_rsp r;
+ trxcon::trxcon_phyif_cmd cmd;
+ while (!trxcon::cmdq_to_phy.spsc_pop(&cmd)) {
+ trxcon::cmdq_to_phy.spsc_prep_pop();
+ }
+ print_cmd(cmd.type);
+
+ switch (cmd.type) {
+ case trxcon::TRXCON_PHYIF_CMDT_RESET:
+ break;
+ case trxcon::TRXCON_PHYIF_CMDT_POWERON:
+
+ if (!mOn) {
+ // start_ms();
+ set_upper_ready(true);
+ mOn = true;
+ }
+ break;
+ case trxcon::TRXCON_PHYIF_CMDT_POWEROFF:
+ // set_upper_ready(false);
+ set_ta(0);
+ break;
+ case trxcon::TRXCON_PHYIF_CMDT_MEASURE:
+ r.type = trxcon::trxcon_phyif_cmd_type::TRXCON_PHYIF_CMDT_MEASURE;
+ r.param.measure.band_arfcn = cmd.param.measure.band_arfcn;
+ r.param.measure.dbm = -80;
+ tuneRx(trxcon::gsm_arfcn2freq10(cmd.param.measure.band_arfcn, 0) * 1000 * 100);
+ tuneTx(trxcon::gsm_arfcn2freq10(cmd.param.measure.band_arfcn, 1) * 1000 * 100);
+ trxcon::cmdq_from_phy.spsc_push(&r);
+ break;
+ case trxcon::TRXCON_PHYIF_CMDT_SETFREQ_H0:
+ // gsm_arfcn2band_rc(uint16_t arfcn, enum gsm_band *band)
+ tuneRx(trxcon::gsm_arfcn2freq10(cmd.param.setfreq_h0.band_arfcn, 0) * 1000 * 100);
+ tuneTx(trxcon::gsm_arfcn2freq10(cmd.param.setfreq_h0.band_arfcn, 1) * 1000 * 100);
+
+ break;
+ case trxcon::TRXCON_PHYIF_CMDT_SETFREQ_H1:
+ break;
+ case trxcon::TRXCON_PHYIF_CMDT_SETSLOT:
+ break;
+ case trxcon::TRXCON_PHYIF_CMDT_SETTA:
+ set_ta(cmd.param.setta.ta);
+ break;
+ }
+ return false;
+}
+
+// trxcon C call(back) if
+extern "C" {
+int trxcon_phyif_handle_burst_req(void *phyif, const struct trxcon::trxcon_phyif_burst_req *br)
+{
+ if (br->burst_len == 0) // dummy/nope
+ return 0;
+ assert(br->burst != 0);
+
+ trxcon::internal_q_tx_buf b;
+ b.r = *br;
+ memcpy(b.buf, (void *)br->burst, br->burst_len);
+ trxcon::txq.spsc_push(&b);
+ return 0;
+}
+
+int trxcon_phyif_handle_cmd(void *phyif, const struct trxcon::trxcon_phyif_cmd *cmd)
+{
+ DBGLG() << "TOP C: " << cmd2str(cmd->type) << std::endl;
+ trxcon::cmdq_to_phy.spsc_push(cmd);
+ // q for resp polling happens in main loop
+ return 0;
+}
+
+void trxcon_phyif_close(void *phyif)
+{
+}
+
+void trxcon_l1ctl_close(struct trxcon::trxcon_inst *trxcon)
+{
+ /* Avoid use-after-free: both *fi and *trxcon are children of
+ * the L2IF (L1CTL connection), so we need to re-parent *fi
+ * to NULL before calling l1ctl_client_conn_close(). */
+ talloc_steal(NULL, trxcon->fi);
+ trxcon::l1ctl_client_conn_close((struct trxcon::l1ctl_client *)trxcon->l2if);
+}
+
+int trxcon_l1ctl_send(struct trxcon::trxcon_inst *trxcon, struct trxcon::msgb *msg)
+{
+ struct trxcon::l1ctl_client *l1c = (struct trxcon::l1ctl_client *)trxcon->l2if;
+
+ return trxcon::l1ctl_client_send(l1c, msg);
+}
+}
+
+int main(int argc, char *argv[])
+{
+ auto tall_trxcon_ctx = talloc_init("trxcon context");
+ trxcon::msgb_talloc_ctx_init(tall_trxcon_ctx, 0);
+ trxcon::trxc_log_init(tall_trxcon_ctx);
+
+ trxcon::g_trxcon = trxcon::trxcon_inst_alloc(tall_trxcon_ctx, 0, 3);
+ trxcon::g_trxcon->gsmtap = 0;
+ trxcon::g_trxcon->phyif = (void *)0x1234;
+
+ pthread_setname_np(pthread_self(), "main_trxc");
+ convolve_init();
+ convert_init();
+ sigProcLibSetup();
+ initvita();
+
+ int status = 0;
+ auto trx = new upper_trx();
+ trx->do_auto_gain = true;
+
+ status = trx->init_dev_and_streams();
+ trx->set_name_aff_sched("main", 3, SCHED_FIFO, sched_get_priority_max(SCHED_FIFO) - 5);
+
+ trxcon::trxc_l1ctl_init(tall_trxcon_ctx);
+
+ trx->start_threads();
+
+ return status;
+}
diff --git a/Transceiver52M/ms/ms_upper.h b/Transceiver52M/ms/ms_upper.h
new file mode 100644
index 0000000..a8a86a4
--- /dev/null
+++ b/Transceiver52M/ms/ms_upper.h
@@ -0,0 +1,57 @@
+
+#pragma once
+
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+#include <netdb.h>
+#include <sys/socket.h>
+#include <arpa/inet.h>
+
+#include "GSMCommon.h"
+#include "radioClock.h"
+#include "ms.h"
+
+namespace trxcon
+{
+extern "C" {
+#include <osmocom/bb/trxcon/phyif.h>
+#include <osmocom/bb/trxcon/trx_if.h>
+}
+} // namespace trxcon
+class upper_trx : public ms_trx {
+ bool mOn;
+ char demodded_softbits[444];
+
+ // void driveControl();
+ bool driveControl();
+ void driveReceiveFIFO();
+ void driveTx();
+
+ bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone));
+
+ std::thread thr_control, thr_rx, thr_tx;
+
+ public:
+ void start_threads();
+ void start_lower_ms();
+
+ upper_trx(){};
+};
diff --git a/Transceiver52M/ms/sch.c b/Transceiver52M/ms/sch.c
new file mode 100644
index 0000000..d05c4e2
--- /dev/null
+++ b/Transceiver52M/ms/sch.c
@@ -0,0 +1,324 @@
+/*
+ * (C) 2013 by Andreas Eversberg <jolly(a)eversberg.eu>
+ * (C) 2015 by Alexander Chemeris <Alexander.Chemeris(a)fairwaves.co>
+ * (C) 2016 by Tom Tsou <tom.tsou(a)ettus.com>
+ * (C) 2017 by Harald Welte <laforge(a)gnumonks.org>
+ * (C) 2022 by 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> / Eric Wild <ewild(a)sysmocom.de>
+ *
+ * All Rights Reserved
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <complex.h>
+#include <stdio.h>
+#include <math.h>
+#include <string.h>
+
+#include <osmocom/core/bits.h>
+#include <osmocom/core/conv.h>
+#include <osmocom/core/utils.h>
+#include <osmocom/core/crcgen.h>
+#include <osmocom/coding/gsm0503_coding.h>
+#include <osmocom/coding/gsm0503_parity.h>
+
+#include "sch.h"
+
+/* GSM 04.08, 9.1.30 Synchronization channel information */
+struct sch_packed_info {
+ ubit_t t1_hi[2];
+ ubit_t bsic[6];
+ ubit_t t1_md[8];
+ ubit_t t3p_hi[2];
+ ubit_t t2[5];
+ ubit_t t1_lo[1];
+ ubit_t t3p_lo[1];
+} __attribute__((packed));
+
+struct sch_burst {
+ sbit_t tail0[3];
+ sbit_t data0[39];
+ sbit_t etsc[64];
+ sbit_t data1[39];
+ sbit_t tail1[3];
+ sbit_t guard[8];
+} __attribute__((packed));
+
+static const uint8_t sch_next_output[][2] = {
+ { 0, 3 }, { 1, 2 }, { 0, 3 }, { 1, 2 },
+ { 3, 0 }, { 2, 1 }, { 3, 0 }, { 2, 1 },
+ { 3, 0 }, { 2, 1 }, { 3, 0 }, { 2, 1 },
+ { 0, 3 }, { 1, 2 }, { 0, 3 }, { 1, 2 },
+};
+
+static const uint8_t sch_next_state[][2] = {
+ { 0, 1 }, { 2, 3 }, { 4, 5 }, { 6, 7 },
+ { 8, 9 }, { 10, 11 }, { 12, 13 }, { 14, 15 },
+ { 0, 1 }, { 2, 3 }, { 4, 5 }, { 6, 7 },
+ { 8, 9 }, { 10, 11 }, { 12, 13 }, { 14, 15 },
+};
+
+static const struct osmo_conv_code gsm_conv_sch = {
+ .N = 2,
+ .K = 5,
+ .len = GSM_SCH_UNCODED_LEN,
+ .next_output = sch_next_output,
+ .next_state = sch_next_state,
+};
+
+#define GSM_MAX_BURST_LEN 157 * 4
+#define GSM_SYM_RATE (1625e3 / 6) * 4
+
+/* Pre-generated FCCH measurement tone */
+static complex float fcch_ref[GSM_MAX_BURST_LEN];
+
+int float_to_sbit(const float *in, sbit_t *out, float scale, int len)
+{
+ int i;
+
+ for (i = 0; i < len; i++) {
+ out[i] = (in[i] - 0.5f) * scale;
+ }
+
+ return 0;
+}
+
+/* Check if FN contains a FCCH burst */
+int gsm_fcch_check_fn(int fn)
+{
+ int fn51 = fn % 51;
+
+ switch (fn51) {
+ case 0:
+ case 10:
+ case 20:
+ case 30:
+ case 40:
+ return 1;
+ }
+
+ return 0;
+}
+
+/* Check if FN contains a SCH burst */
+int gsm_sch_check_fn(int fn)
+{
+ int fn51 = fn % 51;
+
+ switch (fn51) {
+ case 1:
+ case 11:
+ case 21:
+ case 31:
+ case 41:
+ return 1;
+ }
+
+ return 0;
+}
+
+int gsm_fcch_check_ts(int ts, int fn) {
+ return ts == 0 && gsm_fcch_check_fn(fn);
+}
+
+int gsm_sch_check_ts(int ts, int fn) {
+ return ts == 0 && gsm_sch_check_fn(fn);
+}
+
+/* SCH (T1, T2, T3p) to full FN value */
+int gsm_sch_to_fn(struct sch_info *sch)
+{
+ int t1 = sch->t1;
+ int t2 = sch->t2;
+ int t3p = sch->t3p;
+
+ if ((t1 < 0) || (t2 < 0) || (t3p < 0))
+ return -1;
+ int tt;
+ int t3 = t3p * 10 + 1;
+
+ if (t3 < t2)
+ tt = (t3 + 26) - t2;
+ else
+ tt = (t3 - t2) % 26;
+
+ return t1 * 51 * 26 + tt * 51 + t3;
+}
+
+/* Parse encoded SCH message */
+int gsm_sch_parse(const uint8_t *info, struct sch_info *desc)
+{
+ struct sch_packed_info *p = (struct sch_packed_info *) info;
+
+ desc->bsic = (p->bsic[0] << 0) | (p->bsic[1] << 1) |
+ (p->bsic[2] << 2) | (p->bsic[3] << 3) |
+ (p->bsic[4] << 4) | (p->bsic[5] << 5);
+
+ desc->t1 = (p->t1_lo[0] << 0) | (p->t1_md[0] << 1) |
+ (p->t1_md[1] << 2) | (p->t1_md[2] << 3) |
+ (p->t1_md[3] << 4) | (p->t1_md[4] << 5) |
+ (p->t1_md[5] << 6) | (p->t1_md[6] << 7) |
+ (p->t1_md[7] << 8) | (p->t1_hi[0] << 9) |
+ (p->t1_hi[1] << 10);
+
+ desc->t2 = (p->t2[0] << 0) | (p->t2[1] << 1) |
+ (p->t2[2] << 2) | (p->t2[3] << 3) |
+ (p->t2[4] << 4);
+
+ desc->t3p = (p->t3p_lo[0] << 0) | (p->t3p_hi[0] << 1) |
+ (p->t3p_hi[1] << 2);
+
+ return 0;
+}
+
+/* From osmo-bts */
+int gsm_sch_decode(uint8_t *info, sbit_t *data)
+{
+ int rc;
+ ubit_t uncoded[GSM_SCH_UNCODED_LEN];
+
+ osmo_conv_decode(&gsm_conv_sch, data, uncoded);
+
+ rc = osmo_crc16gen_check_bits(&gsm0503_sch_crc10,
+ uncoded, GSM_SCH_INFO_LEN,
+ uncoded + GSM_SCH_INFO_LEN);
+ if (rc)
+ return -1;
+
+ memcpy(info, uncoded, GSM_SCH_INFO_LEN * sizeof(ubit_t));
+
+ return 0;
+}
+
+#define FCCH_TAIL_BITS_LEN 3*4
+#define FCCH_DATA_LEN 100*4// 142
+#if 1
+/* Compute FCCH frequency offset */
+double org_gsm_fcch_offset(float *burst, int len)
+{
+ int i, start, end;
+ float a, b, c, d, ang, avg = 0.0f;
+ double freq;
+
+ if (len > GSM_MAX_BURST_LEN)
+ len = GSM_MAX_BURST_LEN;
+
+ for (i = 0; i < len; i++) {
+ a = burst[2 * i + 0];
+ b = burst[2 * i + 1];
+ c = crealf(fcch_ref[i]);
+ d = cimagf(fcch_ref[i]);
+
+ burst[2 * i + 0] = a * c - b * d;
+ burst[2 * i + 1] = a * d + b * c;
+ }
+
+ start = FCCH_TAIL_BITS_LEN;
+ end = start + FCCH_DATA_LEN;
+
+ for (i = start; i < end; i++) {
+ a = cargf(burst[2 * (i - 1) + 0] +
+ burst[2 * (i - 1) + 1] * I);
+ b = cargf(burst[2 * i + 0] +
+ burst[2 * i + 1] * I);
+
+ ang = b - a;
+
+ if (ang > M_PI)
+ ang -= 2 * M_PI;
+ else if (ang < -M_PI)
+ ang += 2 * M_PI;
+
+ avg += ang;
+ }
+
+ avg /= (float) (end - start);
+ freq = avg / (2 * M_PI) * GSM_SYM_RATE;
+
+ return freq;
+}
+
+
+static const int L1 = 3;
+static const int L2 = 32;
+static const int N1 = 92;
+static const int N2 = 92;
+
+static struct { int8_t r; int8_t s; } P_inv_table[3+32];
+
+void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) {
+ for (int i = 0; i < L1; i++)
+ for (int j = 0; j < L2; j++)
+ if (P == L2 * i - L1 * j) {
+ *r = i;
+ *s = j;
+ return;
+ }
+}
+
+
+float ac_sum_with_lag( complex float* in, int lag, int offset, int N) {
+ complex float v = 0 + 0*I;
+ int total_offset = offset + lag;
+ for (int s = 0; s < N; s++)
+ v += in[s + total_offset] * conjf(in[s + total_offset - lag]);
+ return cargf(v);
+}
+
+
+double gsm_fcch_offset(float *burst, int len)
+{
+ int start;
+
+ const float fs = 13. / 48. * 1e6 * 4;
+ const float expected_fcch_val = ((2 * M_PI) / (fs)) * 67700;
+
+ if (len > GSM_MAX_BURST_LEN)
+ len = GSM_MAX_BURST_LEN;
+
+ start = FCCH_TAIL_BITS_LEN+10 * 4;
+ float alpha_one = ac_sum_with_lag((complex float*)burst, L1, start, N1);
+ float alpha_two = ac_sum_with_lag((complex float*)burst, L2, start, N2);
+
+ float P_unrounded = (L1 * alpha_two - L2 * alpha_one) / (2 * M_PI);
+ int P = roundf(P_unrounded);
+
+ int8_t r = 0, s = 0;
+ pinv(P, &r, &s, L1, L2);
+
+ float omegal1 = (alpha_one + 2 * M_PI * r) / L1;
+ float omegal2 = (alpha_two + 2 * M_PI * s) / L2;
+
+ float rv = org_gsm_fcch_offset(burst, len);
+ //return rv;
+
+ float reval = GSM_SYM_RATE / (2 * M_PI) * (expected_fcch_val - (omegal1+omegal2)/2);
+ //fprintf(stderr, "XX rv %f %f %f %f\n", rv, reval, omegal1 / (2 * M_PI) * fs, omegal2 / (2 * M_PI) * fs);
+
+ //fprintf(stderr, "XX rv %f %f\n", rv, reval);
+
+ return -reval;
+}
+#endif
+/* Generate FCCH measurement tone */
+static __attribute__((constructor)) void init()
+{
+ int i;
+ double freq = 0.25;
+
+ for (i = 0; i < GSM_MAX_BURST_LEN; i++) {
+ fcch_ref[i] = sin(2 * M_PI * freq * (double) i) +
+ cos(2 * M_PI * freq * (double) i) * I;
+ }
+
+}
diff --git a/Transceiver52M/ms/sch.h b/Transceiver52M/ms/sch.h
new file mode 100644
index 0000000..1af2114
--- /dev/null
+++ b/Transceiver52M/ms/sch.h
@@ -0,0 +1,48 @@
+#pragma once
+/*
+ * (C) 2013 by Andreas Eversberg <jolly(a)eversberg.eu>
+ * (C) 2015 by Alexander Chemeris <Alexander.Chemeris(a)fairwaves.co>
+ * (C) 2016 by Tom Tsou <tom.tsou(a)ettus.com>
+ * (C) 2017 by Harald Welte <laforge(a)gnumonks.org>
+ * (C) 2022 by 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de> / Eric Wild <ewild(a)sysmocom.de>
+ *
+ * All Rights Reserved
+ *
+ * SPDX-License-Identifier: GPL-2.0+
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ */
+
+#include <osmocom/core/bits.h>
+
+struct sch_info {
+ int bsic;
+ int t1;
+ int t2;
+ int t3p;
+};
+
+#define GSM_SCH_INFO_LEN 25
+#define GSM_SCH_UNCODED_LEN 35
+#define GSM_SCH_CODED_LEN 78
+
+int gsm_sch_decode(uint8_t *sb_info, sbit_t *burst);
+int gsm_sch_parse(const uint8_t *sb_info, struct sch_info *desc);
+int gsm_sch_to_fn(struct sch_info *sch);
+int gsm_sch_check_fn(int fn);
+int gsm_fcch_check_fn(int fn);
+int gsm_fcch_check_ts(int ts, int fn);
+int gsm_sch_check_ts(int ts, int fn);
+
+double gsm_fcch_offset(float *burst, int len);
+
+int float_to_sbit(const float *in, sbit_t *out, float scale, int len);
+
diff --git a/Transceiver52M/ms/uhd_specific.h b/Transceiver52M/ms/uhd_specific.h
new file mode 100644
index 0000000..ed1a72a
--- /dev/null
+++ b/Transceiver52M/ms/uhd_specific.h
@@ -0,0 +1,251 @@
+#pragma once
+
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#include <uhd/version.hpp>
+#include <uhd/usrp/multi_usrp.hpp>
+#include <uhd/types/metadata.hpp>
+#include <complex>
+#include <cstring>
+#include <iostream>
+#include <thread>
+
+#include <Timeval.h>
+#include <vector>
+
+using blade_sample_type = std::complex<int16_t>;
+const int SAMPLE_SCALE_FACTOR = 1;
+
+struct uhd_buf_wrap {
+ double rxticks;
+ size_t num_samps;
+ uhd::rx_metadata_t *md;
+ blade_sample_type *buf;
+ auto actual_samples_per_buffer()
+ {
+ return num_samps;
+ }
+ long get_first_ts()
+ {
+ return md->time_spec.to_ticks(rxticks);
+ }
+ int readall(blade_sample_type *outaddr)
+ {
+ memcpy(outaddr, buf, num_samps * sizeof(blade_sample_type));
+ return num_samps;
+ }
+ int read_n(blade_sample_type *outaddr, int start, int num)
+ {
+ assert(start >= 0);
+ auto to_read = std::min((int)num_samps - start, num);
+ assert(to_read >= 0);
+ memcpy(outaddr, buf + start, to_read * sizeof(blade_sample_type));
+ return to_read;
+ }
+};
+
+using dev_buf_t = uhd_buf_wrap;
+using bh_fn_t = std::function<int(dev_buf_t *)>;
+
+template <typename T> struct uhd_hw {
+ uhd::usrp::multi_usrp::sptr dev;
+ uhd::rx_streamer::sptr rx_stream;
+ uhd::tx_streamer::sptr tx_stream;
+ blade_sample_type *one_pkt_buf;
+ std::vector<blade_sample_type *> pkt_ptrs;
+ size_t rx_spp;
+ double rxticks;
+ const unsigned int rxFullScale, txFullScale;
+ const int rxtxdelay;
+ float rxgain, txgain;
+ volatile bool stop_me_flag;
+
+ virtual ~uhd_hw()
+ {
+ delete[] one_pkt_buf;
+ }
+ uhd_hw() : rxFullScale(32767), txFullScale(32767), rxtxdelay(-67), stop_me_flag(false)
+ {
+ }
+
+ void close_device()
+ {
+ stop_me_flag = true;
+ }
+
+ bool tuneTx(double freq, size_t chan = 0)
+ {
+ msleep(25);
+ dev->set_tx_freq(freq, chan);
+ msleep(25);
+ return true;
+ };
+ bool tuneRx(double freq, size_t chan = 0)
+ {
+ msleep(25);
+ dev->set_rx_freq(freq, chan);
+ msleep(25);
+ return true;
+ };
+ bool tuneRxOffset(double offset, size_t chan = 0)
+ {
+ return true;
+ };
+
+ double setRxGain(double dB, size_t chan = 0)
+ {
+ rxgain = dB;
+ msleep(25);
+ dev->set_rx_gain(dB, chan);
+ msleep(25);
+ return dB;
+ };
+ double setTxGain(double dB, size_t chan = 0)
+ {
+ txgain = dB;
+ msleep(25);
+ dev->set_tx_gain(dB, chan);
+ msleep(25);
+ return dB;
+ };
+ int setPowerAttenuation(int atten, size_t chan = 0)
+ {
+ return atten;
+ };
+
+ int init_device(bh_fn_t rxh, bh_fn_t txh)
+ {
+ auto const lock_delay_ms = 500;
+ auto const mcr = 26e6;
+ auto const rate = (1625e3 / 6) * 4;
+ auto const ref = "external";
+ auto const gain = 35;
+ auto const freq = 931.4e6; // 936.8e6
+ auto bw = 0.5e6;
+ auto const channel = 0;
+ std::string args = {};
+
+ dev = uhd::usrp::multi_usrp::make(args);
+ std::cout << "Using Device: " << dev->get_pp_string() << std::endl;
+ dev->set_clock_source(ref);
+ dev->set_master_clock_rate(mcr);
+ dev->set_rx_rate(rate, channel);
+ dev->set_tx_rate(rate, channel);
+ uhd::tune_request_t tune_request(freq, 0);
+ dev->set_rx_freq(tune_request, channel);
+ dev->set_rx_gain(gain, channel);
+ dev->set_tx_gain(60, channel);
+ dev->set_rx_bandwidth(bw, channel);
+ dev->set_tx_bandwidth(bw, channel);
+
+ while (!(dev->get_rx_sensor("lo_locked", channel).to_bool() &&
+ dev->get_mboard_sensor("ref_locked").to_bool()))
+ std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms));
+
+ uhd::stream_args_t stream_args("sc16", "sc16");
+ rx_stream = dev->get_rx_stream(stream_args);
+ uhd::stream_args_t stream_args2("sc16", "sc16");
+ tx_stream = dev->get_tx_stream(stream_args2);
+
+ rx_spp = rx_stream->get_max_num_samps();
+ rxticks = dev->get_rx_rate();
+ assert(rxticks == dev->get_tx_rate());
+ one_pkt_buf = new blade_sample_type[rx_spp];
+ pkt_ptrs = { 1, &one_pkt_buf[0] };
+ return 0;
+ }
+
+ void *rx_cb(bh_fn_t burst_handler)
+ {
+ void *ret;
+ static int to_skip = 0;
+
+ uhd::rx_metadata_t md;
+ auto num_rx_samps = rx_stream->recv(pkt_ptrs.front(), rx_spp, md, 1.0, true);
+
+ if (md.error_code == uhd::rx_metadata_t::ERROR_CODE_TIMEOUT) {
+ std::cerr << boost::format("Timeout while streaming") << std::endl;
+ exit(0);
+ }
+ if (md.error_code == uhd::rx_metadata_t::ERROR_CODE_OVERFLOW) {
+ std::cerr << boost::format("Got an overflow indication\n") << std::endl;
+ exit(0);
+ }
+ if (md.error_code != uhd::rx_metadata_t::ERROR_CODE_NONE) {
+ std::cerr << str(boost::format("Receiver error: %s") % md.strerror());
+ exit(0);
+ }
+
+ dev_buf_t rcd = { rxticks, num_rx_samps, &md, &one_pkt_buf[0] };
+
+ if (to_skip < 120) // prevents weird overflows on startup
+ to_skip++;
+ else {
+ burst_handler(&rcd);
+ }
+
+ return ret;
+ }
+
+ auto get_rx_burst_handler_fn(bh_fn_t burst_handler)
+ {
+ auto fn = [this, burst_handler] {
+ pthread_setname_np(pthread_self(), "rxrun");
+
+ uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS);
+ stream_cmd.stream_now = true;
+ stream_cmd.time_spec = uhd::time_spec_t();
+ rx_stream->issue_stream_cmd(stream_cmd);
+
+ while (!stop_me_flag) {
+ rx_cb(burst_handler);
+ }
+ };
+ return fn;
+ }
+ auto get_tx_burst_handler_fn(bh_fn_t burst_handler)
+ {
+ auto fn = [] {
+ // dummy
+ };
+ return fn;
+ }
+ void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts)
+ {
+ uhd::tx_metadata_t m = {};
+ m.end_of_burst = true;
+ m.start_of_burst = true;
+ m.has_time_spec = true;
+ m.time_spec = m.time_spec.from_ticks(ts + rxtxdelay, rxticks); // uhd specific b210 delay!
+ std::vector<void *> ptrs(1, buffer);
+
+ tx_stream->send(ptrs, len, m, 1.0);
+#ifdef DBGXX
+ uhd::async_metadata_t async_md;
+ bool tx_ack = false;
+ while (!tx_ack && tx_stream->recv_async_msg(async_md)) {
+ tx_ack = (async_md.event_code == uhd::async_metadata_t::EVENT_CODE_BURST_ACK);
+ }
+ std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl;
+#endif
+ }
+};
\ No newline at end of file
diff --git a/configure.ac b/configure.ac
index 020f7e3..6ce9ad4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -327,6 +327,14 @@
AC_MSG_RESULT([CXXFLAGS="$CXXFLAGS"])
AC_MSG_RESULT([LDFLAGS="$LDFLAGS"])
+AM_CONDITIONAL(ENABLE_MS_TRX, [test -d osmocom-bb])
+
+if ENABLE_MS_TRX; then
+ AC_MSG_NOTICE(["Enabling ms-trx..."])
+ AC_CONFIG_SUBDIRS([osmocom-bb/src/host/trxcon])
+fi
+
+
dnl Output files
AC_CONFIG_FILES([\
Makefile \
@@ -353,8 +361,7 @@
doc/examples/Makefile \
contrib/Makefile \
contrib/systemd/Makefile \
+ doc/manuals/Makefile \
+ contrib/osmo-trx.spec \
])
-
-AC_OUTPUT(
- doc/manuals/Makefile
- contrib/osmo-trx.spec)
+AC_OUTPUT
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: osmocom-bb for ms-trx side trxcon integration
by Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30412 )
Change subject: osmocom-bb for ms-trx side trxcon integration
......................................................................
osmocom-bb for ms-trx side trxcon integration
Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61
---
A .gitmodules
A osmocom-bb
2 files changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/12/30412/1
diff --git a/.gitmodules b/.gitmodules
new file mode 100644
index 0000000..bc94e80
--- /dev/null
+++ b/.gitmodules
@@ -0,0 +1,4 @@
+[submodule "osmocom-bb"]
+ path = osmocom-bb
+ url = https://gitea.osmocom.org/phone-side/osmocom-bb.git
+ branch = a4aac5c3554559c2c994609f90b92a9daf6e8a89
diff --git a/osmocom-bb b/osmocom-bb
new file mode 160000
index 0000000..a4aac5c
--- /dev/null
+++ b/osmocom-bb
@@ -0,0 +1 @@
+Subproject commit a4aac5c3554559c2c994609f90b92a9daf6e8a89
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30412
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61
Gerrit-Change-Number: 30412
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: rename noisevector class -> avgvector
by Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30411 )
Change subject: rename noisevector class -> avgvector
......................................................................
rename noisevector class -> avgvector
The vectors feature is averaging, and not adding noise.
Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927
---
M Transceiver52M/Transceiver.h
M Transceiver52M/radioVector.cpp
M Transceiver52M/radioVector.h
3 files changed, 9 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/11/30411/1
diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h
index 45a4159..0389e60 100644
--- a/Transceiver52M/Transceiver.h
+++ b/Transceiver52M/Transceiver.h
@@ -80,7 +80,7 @@
/* Received noise energy levels */
float mNoiseLev;
- noiseVector mNoises;
+ avgVector mNoises;
/* Shadowed downlink attenuation */
int mPower;
diff --git a/Transceiver52M/radioVector.cpp b/Transceiver52M/radioVector.cpp
index 68e42c5..acefc97 100644
--- a/Transceiver52M/radioVector.cpp
+++ b/Transceiver52M/radioVector.cpp
@@ -76,22 +76,25 @@
return true;
}
-noiseVector::noiseVector(size_t size)
+avgVector::avgVector(size_t size)
: std::vector<float>(size), itr(0)
{
}
-float noiseVector::avg() const
+float avgVector::avg() const
{
float val = 0.0;
+ if (!size())
+ return 0.0f;
+
for (size_t i = 0; i < size(); i++)
val += (*this)[i];
return val / (float) size();
}
-bool noiseVector::insert(float val)
+bool avgVector::insert(float val)
{
if (!size())
return false;
diff --git a/Transceiver52M/radioVector.h b/Transceiver52M/radioVector.h
index 84e3987..90db626 100644
--- a/Transceiver52M/radioVector.h
+++ b/Transceiver52M/radioVector.h
@@ -48,9 +48,9 @@
GSM::Time mTime;
};
-class noiseVector : std::vector<float> {
+class avgVector : std::vector<float> {
public:
- noiseVector(size_t size = 0);
+ avgVector(size_t size = 0);
bool insert(float val);
float avg() const;
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30411
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927
Gerrit-Change-Number: 30411
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ignore vscode dirs
by Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30410 )
Change subject: ignore vscode dirs
......................................................................
ignore vscode dirs
Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c
---
M .gitignore
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/10/30410/1
diff --git a/.gitignore b/.gitignore
index fec8fab..74e1d00 100644
--- a/.gitignore
+++ b/.gitignore
@@ -75,3 +75,6 @@
!contrib/osmo-trx.spec.in
utils/osmo-prbs-tool
+/.qtc_clangd/*
+/.cache/*
+/.vscode/*
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30410
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c
Gerrit-Change-Number: 30410
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: bladerf xa4 support
by Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 )
Change subject: bladerf xa4 support
......................................................................
bladerf xa4 support
This is not really finished, there are multiple reasons to not use this:
1) main clock is not a gsm multiple, so it will continously drift
2) small buffer sizes lead to tx gaps that are hard to detect and break
everything.
Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac
---
M .gitignore
M Transceiver52M/Makefile.am
M Transceiver52M/device/Makefile.am
A Transceiver52M/device/bladerf/Makefile.am
A Transceiver52M/device/bladerf/bladerf.cpp
A Transceiver52M/device/bladerf/bladerf.h
M configure.ac
7 files changed, 960 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/30413/1
diff --git a/.gitignore b/.gitignore
index 74e1d00..35a1b46 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,6 +6,7 @@
Transceiver52M/osmo-trx-usrp1
Transceiver52M/osmo-trx-lms
Transceiver52M/osmo-trx-ipc
+Transceiver52M/osmo-trx-blade
Transceiver52M/device/ipc/uhddev_ipc.cpp
.clang-format
diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am
index 7dad159..3f84d3d 100644
--- a/Transceiver52M/Makefile.am
+++ b/Transceiver52M/Makefile.am
@@ -105,6 +105,17 @@
osmo_trx_lms_CPPFLAGS = $(AM_CPPFLAGS) $(LMS_CFLAGS)
endif
+if DEVICE_BLADE
+bin_PROGRAMS += osmo-trx-blade
+osmo_trx_blade_SOURCES = osmo-trx.cpp
+osmo_trx_blade_LDADD = \
+ $(builddir)/device/bladerf/libdevice.la \
+ $(COMMON_LDADD) \
+ $(BLADE_LIBS)
+osmo_trx_blade_CPPFLAGS = $(AM_CPPFLAGS) $(LMS_CFLAGS)
+
+endif
+
if DEVICE_IPC
bin_PROGRAMS += osmo-trx-ipc
osmo_trx_ipc_SOURCES = osmo-trx.cpp
diff --git a/Transceiver52M/device/Makefile.am b/Transceiver52M/device/Makefile.am
index 93ba7e3..9af18f7 100644
--- a/Transceiver52M/device/Makefile.am
+++ b/Transceiver52M/device/Makefile.am
@@ -17,3 +17,7 @@
if DEVICE_LMS
SUBDIRS += lms
endif
+
+if DEVICE_BLADE
+SUBDIRS += bladerf
+endif
diff --git a/Transceiver52M/device/bladerf/Makefile.am b/Transceiver52M/device/bladerf/Makefile.am
new file mode 100644
index 0000000..e9917af
--- /dev/null
+++ b/Transceiver52M/device/bladerf/Makefile.am
@@ -0,0 +1,11 @@
+include $(top_srcdir)/Makefile.common
+
+AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/../common
+AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS) $(LIBOSMOVTY_CFLAGS) $(BLADE_CFLAGS)
+
+noinst_HEADERS = bladerf.h
+
+noinst_LTLIBRARIES = libdevice.la
+
+libdevice_la_SOURCES = bladerf.cpp
+libdevice_la_LIBADD = $(top_builddir)/Transceiver52M/device/common/libdevice_common.la
diff --git a/Transceiver52M/device/bladerf/bladerf.cpp b/Transceiver52M/device/bladerf/bladerf.cpp
new file mode 100644
index 0000000..3aa6d1d
--- /dev/null
+++ b/Transceiver52M/device/bladerf/bladerf.cpp
@@ -0,0 +1,733 @@
+/*
+ * Copyright 2022 sysmocom - s.f.m.c. GmbH
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * SPDX-License-Identifier: AGPL-3.0+
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * See the COPYING file in the main directory for details.
+ */
+
+#include <map>
+#include <libbladeRF.h>
+#include "radioDevice.h"
+#include "bladerf.h"
+#include "Threads.h"
+#include "Logger.h"
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+extern "C" {
+#include <osmocom/core/utils.h>
+#include <osmocom/gsm/gsm_utils.h>
+#include <osmocom/vty/cpu_sched_vty.h>
+}
+
+#define SAMPLE_BUF_SZ (1 << 20)
+
+/*
+ * USRP version dependent device timings
+ */
+
+#define B2XX_TIMING_4_4SPS 6.18462e-5
+
+#define CHKRET() \
+ { \
+ if (status != 0) \
+ fprintf(stderr, "%s:%s:%d %s\n", __FILE__, __FUNCTION__, __LINE__, bladerf_strerror(status)); \
+ }
+
+/*
+ * Tx / Rx sample offset values. In a perfect world, there is no group delay
+ * though analog components, and behaviour through digital filters exactly
+ * matches calculated values. In reality, there are unaccounted factors,
+ * which are captured in these empirically measured (using a loopback test)
+ * timing correction values.
+ *
+ * Notes:
+ * USRP1 with timestamps is not supported by UHD.
+ */
+
+/* Device Type, Tx-SPS, Rx-SPS */
+typedef std::tuple<blade_dev_type, int, int> dev_key;
+
+/* Device parameter descriptor */
+struct dev_desc {
+ unsigned channels;
+ double mcr;
+ double rate;
+ double offset;
+ std::string str;
+};
+
+static const std::map<dev_key, dev_desc> dev_param_map{
+ { std::make_tuple(blade_dev_type::BLADE2, 4, 4), { 1, 26e6, GSMRATE, B2XX_TIMING_4_4SPS, "B200 4 SPS" } },
+};
+
+typedef std::tuple<blade_dev_type, enum gsm_band> dev_band_key;
+typedef std::map<dev_band_key, dev_band_desc>::const_iterator dev_band_map_it;
+static const std::map<dev_band_key, dev_band_desc> dev_band_nom_power_param_map{
+ { std::make_tuple(blade_dev_type::BLADE2, GSM_BAND_850), { 89.75, 13.3, -7.5 } },
+ { std::make_tuple(blade_dev_type::BLADE2, GSM_BAND_900), { 89.75, 13.3, -7.5 } },
+ { std::make_tuple(blade_dev_type::BLADE2, GSM_BAND_1800), { 89.75, 7.5, -11.0 } },
+ { std::make_tuple(blade_dev_type::BLADE2, GSM_BAND_1900), { 89.75, 7.7, -11.0 } },
+};
+
+/* So far measurements done for B210 show really close to linear relationship
+ * between gain and real output power, so we simply adjust the measured offset
+ */
+static double TxGain2TxPower(const dev_band_desc &desc, double tx_gain_db)
+{
+ return desc.nom_out_tx_power - (desc.nom_uhd_tx_gain - tx_gain_db);
+}
+static double TxPower2TxGain(const dev_band_desc &desc, double tx_power_dbm)
+{
+ return desc.nom_uhd_tx_gain - (desc.nom_out_tx_power - tx_power_dbm);
+}
+
+blade_device::blade_device(size_t tx_sps, size_t rx_sps, InterfaceType iface, size_t chan_num, double lo_offset,
+ const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths)
+ : RadioDevice(tx_sps, rx_sps, iface, chan_num, lo_offset, tx_paths, rx_paths), dev(nullptr), rx_gain_min(0.0),
+ rx_gain_max(0.0), band_ass_curr_sess(false), band((enum gsm_band)0), tx_spp(0), rx_spp(0), started(false),
+ aligned(false), drop_cnt(0), prev_ts(0), ts_initial(0), ts_offset(0), async_event_thrd(NULL)
+{
+}
+
+blade_device::~blade_device()
+{
+ if (dev) {
+ bladerf_enable_module(dev, BLADERF_CHANNEL_RX(0), false);
+ bladerf_enable_module(dev, BLADERF_CHANNEL_TX(0), false);
+ }
+
+ stop();
+
+ for (size_t i = 0; i < rx_buffers.size(); i++)
+ delete rx_buffers[i];
+}
+
+void blade_device::assign_band_desc(enum gsm_band req_band)
+{
+ dev_band_map_it it;
+
+ it = dev_band_nom_power_param_map.find(dev_band_key(dev_type, req_band));
+ if (it == dev_band_nom_power_param_map.end()) {
+ dev_desc desc = dev_param_map.at(dev_key(dev_type, tx_sps, rx_sps));
+ LOGC(DDEV, ERROR) << "No Power parameters exist for device " << desc.str << " on band "
+ << gsm_band_name(req_band) << ", using B210 ones as fallback";
+ it = dev_band_nom_power_param_map.find(dev_band_key(blade_dev_type::BLADE2, req_band));
+ }
+ OSMO_ASSERT(it != dev_band_nom_power_param_map.end())
+ band_desc = it->second;
+}
+
+bool blade_device::set_band(enum gsm_band req_band)
+{
+ if (band_ass_curr_sess && req_band != band) {
+ LOGC(DDEV, ALERT) << "Requesting band " << gsm_band_name(req_band) << " different from previous band "
+ << gsm_band_name(band);
+ return false;
+ }
+
+ if (req_band != band) {
+ band = req_band;
+ assign_band_desc(band);
+ }
+ band_ass_curr_sess = true;
+ return true;
+}
+
+void blade_device::get_dev_band_desc(dev_band_desc &desc)
+{
+ if (band == 0) {
+ LOGC(DDEV, ERROR)
+ << "Power parameters requested before Tx Frequency was set! Providing band 900 by default...";
+ assign_band_desc(GSM_BAND_900);
+ }
+ desc = band_desc;
+}
+
+void blade_device::init_gains()
+{
+ double tx_gain_min, tx_gain_max;
+ int status;
+
+ const struct bladerf_range *r;
+ bladerf_get_gain_range(dev, BLADERF_RX, &r);
+
+ rx_gain_min = r->min;
+ rx_gain_max = r->max;
+ LOGC(DDEV, INFO) << "Supported Rx gain range [" << rx_gain_min << "; " << rx_gain_max << "]";
+
+ for (size_t i = 0; i < rx_gains.size(); i++) {
+ double gain = (rx_gain_min + rx_gain_max) / 2;
+ status = bladerf_set_gain_mode(dev, BLADERF_CHANNEL_RX(i), BLADERF_GAIN_MGC);
+ CHKRET()
+ bladerf_gain_mode m;
+ bladerf_get_gain_mode(dev, BLADERF_CHANNEL_RX(i), &m);
+ LOGC(DDEV, INFO) << (m == BLADERF_GAIN_MANUAL ? "gain manual" : "gain AUTO");
+
+ status = bladerf_set_gain(dev, BLADERF_CHANNEL_RX(i), 0); //gain);
+ CHKRET()
+ int actual_gain;
+ status = bladerf_get_gain(dev, BLADERF_CHANNEL_RX(i), &actual_gain);
+ CHKRET()
+ LOGC(DDEV, INFO) << "Default setting Rx gain for channel " << i << " to " << gain << " scale "
+ << r->scale << " actual " << actual_gain;
+ rx_gains[i] = actual_gain;
+
+ status = bladerf_set_gain(dev, BLADERF_CHANNEL_RX(i), 0); //gain);
+ CHKRET()
+ status = bladerf_get_gain(dev, BLADERF_CHANNEL_RX(i), &actual_gain);
+ CHKRET()
+ LOGC(DDEV, INFO) << "Default setting Rx gain for channel " << i << " to " << gain << " scale "
+ << r->scale << " actual " << actual_gain;
+ rx_gains[i] = actual_gain;
+ }
+
+ status = bladerf_get_gain_range(dev, BLADERF_TX, &r);
+ CHKRET()
+ tx_gain_min = r->min;
+ tx_gain_max = r->max;
+ LOGC(DDEV, INFO) << "Supported Tx gain range [" << tx_gain_min << "; " << tx_gain_max << "]";
+
+ for (size_t i = 0; i < tx_gains.size(); i++) {
+ double gain = (tx_gain_min + tx_gain_max) / 2;
+ status = bladerf_set_gain(dev, BLADERF_CHANNEL_TX(i), 30); //gain);
+ CHKRET()
+ int actual_gain;
+ status = bladerf_get_gain(dev, BLADERF_CHANNEL_TX(i), &actual_gain);
+ CHKRET()
+ LOGC(DDEV, INFO) << "Default setting Tx gain for channel " << i << " to " << gain << " scale "
+ << r->scale << " actual " << actual_gain;
+ tx_gains[i] = actual_gain;
+ }
+
+ return;
+}
+
+void blade_device::set_rates()
+{
+ //dev_desc desc = dev_param_map.at(dev_key(dev_type, tx_sps, rx_sps));
+
+ struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)), 6 }, actual;
+ auto status = bladerf_set_rational_sample_rate(dev, BLADERF_CHANNEL_RX(0), &rate, &actual);
+ CHKRET()
+ status = bladerf_set_rational_sample_rate(dev, BLADERF_CHANNEL_TX(0), &rate, &actual);
+ CHKRET()
+
+ tx_rate = rx_rate = (double)rate.num / (double)rate.den;
+
+ LOGC(DDEV, INFO) << "Rates set to" << tx_rate << " / " << rx_rate;
+
+ bladerf_set_bandwidth(dev, BLADERF_CHANNEL_RX(0), (bladerf_bandwidth)2e6, (bladerf_bandwidth *)NULL);
+ bladerf_set_bandwidth(dev, BLADERF_CHANNEL_TX(0), (bladerf_bandwidth)2e6, (bladerf_bandwidth *)NULL);
+
+ ts_offset = 60; //static_cast<TIMESTAMP>(desc.offset * rx_rate);
+ //LOGC(DDEV, INFO) << "Rates configured for " << desc.str;
+}
+
+double blade_device::setRxGain(double db, size_t chan)
+{
+ if (chan >= rx_gains.size()) {
+ LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;
+ return 0.0f;
+ }
+
+ bladerf_set_gain(dev, BLADERF_CHANNEL_RX(chan), 30); //db);
+ int actual_gain;
+ bladerf_get_gain(dev, BLADERF_CHANNEL_RX(chan), &actual_gain);
+
+ rx_gains[chan] = actual_gain;
+
+ LOGC(DDEV, INFO) << "Set RX gain to " << rx_gains[chan] << "dB (asked for " << db << "dB)";
+
+ return rx_gains[chan];
+}
+
+double blade_device::getRxGain(size_t chan)
+{
+ if (chan >= rx_gains.size()) {
+ LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;
+ return 0.0f;
+ }
+
+ return rx_gains[chan];
+}
+
+double blade_device::rssiOffset(size_t chan)
+{
+ double rssiOffset;
+ dev_band_desc desc;
+
+ if (chan >= rx_gains.size()) {
+ LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;
+ return 0.0f;
+ }
+
+ get_dev_band_desc(desc);
+ rssiOffset = rx_gains[chan] + desc.rxgain2rssioffset_rel;
+ return rssiOffset;
+}
+
+double blade_device::setPowerAttenuation(int atten, size_t chan)
+{
+ double tx_power, db;
+ dev_band_desc desc;
+
+ if (chan >= tx_gains.size()) {
+ LOGC(DDEV, ALERT) << "Requested non-existent channel" << chan;
+ return 0.0f;
+ }
+
+ get_dev_band_desc(desc);
+ tx_power = desc.nom_out_tx_power - atten;
+ db = TxPower2TxGain(desc, tx_power);
+
+ bladerf_set_gain(dev, BLADERF_CHANNEL_TX(chan), 30); //db);
+ int actual_gain;
+ bladerf_get_gain(dev, BLADERF_CHANNEL_RX(chan), &actual_gain);
+
+ tx_gains[chan] = actual_gain;
+
+ LOGC(DDEV, INFO)
+ << "Set TX gain to " << tx_gains[chan] << "dB, ~" << TxGain2TxPower(desc, tx_gains[chan]) << " dBm "
+ << "(asked for " << db << " dB, ~" << tx_power << " dBm)";
+
+ return desc.nom_out_tx_power - TxGain2TxPower(desc, tx_gains[chan]);
+}
+double blade_device::getPowerAttenuation(size_t chan)
+{
+ dev_band_desc desc;
+ if (chan >= tx_gains.size()) {
+ LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;
+ return 0.0f;
+ }
+
+ get_dev_band_desc(desc);
+ return desc.nom_out_tx_power - TxGain2TxPower(desc, tx_gains[chan]);
+}
+
+int blade_device::getNominalTxPower(size_t chan)
+{
+ dev_band_desc desc;
+ get_dev_band_desc(desc);
+
+ return desc.nom_out_tx_power;
+}
+
+int blade_device::open(const std::string &args, int ref, bool swap_channels)
+{
+ bladerf_log_set_verbosity(BLADERF_LOG_LEVEL_VERBOSE);
+ bladerf_set_usb_reset_on_open(true);
+ auto success = bladerf_open(&dev, args.c_str());
+ if (success != 0) {
+ struct bladerf_devinfo *info;
+ auto num_devs = bladerf_get_device_list(&info);
+ LOGC(DDEV, ALERT) << "No bladerf devices found with identifier '" << args << "'";
+ if (num_devs) {
+ for (int i = 0; i < num_devs; i++)
+ LOGC(DDEV, ALERT) << "Found device:" << info[i].product << " serial " << info[i].serial;
+ }
+
+ return -1;
+ }
+ if (strcmp("bladerf2", bladerf_get_board_name(dev))) {
+ LOGC(DDEV, ALERT) << "Only BladeRF2 supported! found:" << bladerf_get_board_name(dev);
+ return -1;
+ }
+
+ dev_type = blade_dev_type::BLADE2;
+ tx_window = TX_WINDOW_FIXED;
+
+ struct bladerf_devinfo info;
+ bladerf_get_devinfo(dev, &info);
+ // Use the first found device
+ LOGC(DDEV, INFO) << "Using discovered bladerf device " << info.serial;
+
+ tx_freqs.resize(chans);
+ rx_freqs.resize(chans);
+ tx_gains.resize(chans);
+ rx_gains.resize(chans);
+ rx_buffers.resize(chans);
+
+ switch (ref) {
+ case REF_INTERNAL:
+ case REF_EXTERNAL:
+ break;
+ default:
+ LOGC(DDEV, ALERT) << "Invalid reference type";
+ return -1;
+ }
+
+ if (ref == REF_EXTERNAL) {
+ bool is_locked;
+ int status = bladerf_set_pll_enable(dev, true);
+ CHKRET()
+ status = bladerf_set_pll_refclk(dev, 10000000);
+ CHKRET()
+ for (int i = 0; i < 20; i++) {
+ usleep(50 * 1000);
+ status = bladerf_get_pll_lock_state(dev, &is_locked);
+ CHKRET()
+ if (is_locked)
+ break;
+ }
+ if (!is_locked) {
+ LOGC(DDEV, ALERT) << "unable to lock refclk!";
+ return -1;
+ }
+ }
+
+ LOGC(DDEV, INFO) << "Selected clock source is " << ((ref == REF_INTERNAL) ? "internal" : "external 10Mhz");
+
+ set_rates();
+
+ /*
+ 1ts = 3/5200s
+ 1024*2 = small gap(~180us) every 9.23ms = every 16 ts? -> every 2 frames
+ 1024*1 = large gap(~627us) every 9.23ms = every 16 ts? -> every 2 frames
+
+ rif convertbuffer = 625*4 = 2500 -> 4 ts
+ rif rxtxbuf = 4 * segment(625*4) = 10000 -> 16 ts
+*/
+ const unsigned int num_buffers = 256;
+ const unsigned int buffer_size = 1024 * 4; /* Must be a multiple of 1024 */
+ const unsigned int num_transfers = 32;
+ const unsigned int timeout_ms = 3500;
+
+ bladerf_sync_config(dev, BLADERF_RX_X1, BLADERF_FORMAT_SC16_Q11_META, num_buffers, buffer_size, num_transfers,
+ timeout_ms);
+
+ bladerf_sync_config(dev, BLADERF_TX_X1, BLADERF_FORMAT_SC16_Q11_META, num_buffers, buffer_size, num_transfers,
+ timeout_ms);
+
+ /* Number of samples per over-the-wire packet */
+ tx_spp = rx_spp = buffer_size;
+
+ // Create receive buffer
+ size_t buf_len = SAMPLE_BUF_SZ / sizeof(uint32_t);
+ for (size_t i = 0; i < rx_buffers.size(); i++)
+ rx_buffers[i] = new smpl_buf(buf_len);
+
+ // Create vector buffer
+ pkt_bufs = std::vector<std::vector<short> >(chans, std::vector<short>(2 * rx_spp));
+ for (size_t i = 0; i < pkt_bufs.size(); i++)
+ pkt_ptrs.push_back(&pkt_bufs[i].front());
+
+ // Initialize and shadow gain values
+ init_gains();
+
+ return NORMAL;
+}
+
+bool blade_device::restart()
+{
+ /* Allow 100 ms delay to align multi-channel streams */
+ double delay = 0.2;
+ int status;
+
+ status = bladerf_enable_module(dev, BLADERF_CHANNEL_RX(0), true);
+ CHKRET()
+ status = bladerf_enable_module(dev, BLADERF_CHANNEL_TX(0), true);
+ CHKRET()
+
+ bladerf_timestamp now;
+ status = bladerf_get_timestamp(dev, BLADERF_RX, &now);
+ ts_initial = now + rx_rate * delay;
+ LOGC(DDEV, INFO) << "Initial timestamp " << ts_initial << std::endl;
+
+ return true;
+}
+
+bool blade_device::start()
+{
+ LOGC(DDEV, INFO) << "Starting USRP...";
+
+ if (started) {
+ LOGC(DDEV, ERROR) << "Device already started";
+ return false;
+ }
+
+ // Start streaming
+ if (!restart())
+ return false;
+
+ started = true;
+ return true;
+}
+
+bool blade_device::stop()
+{
+ if (!started)
+ return false;
+
+ /* reset internal buffer timestamps */
+ for (size_t i = 0; i < rx_buffers.size(); i++)
+ rx_buffers[i]->reset();
+
+ band_ass_curr_sess = false;
+
+ started = false;
+ return true;
+}
+
+int blade_device::readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun)
+{
+ ssize_t rc;
+ uint64_t ts;
+
+ if (bufs.size() != chans) {
+ LOGC(DDEV, ALERT) << "Invalid channel combination " << bufs.size();
+ return -1;
+ }
+
+ *overrun = false;
+ *underrun = false;
+
+ // Shift read time with respect to transmit clock
+ timestamp += ts_offset;
+
+ ts = timestamp;
+ LOGC(DDEV, DEBUG) << "Requested timestamp = " << ts;
+
+ // Check that timestamp is valid
+ rc = rx_buffers[0]->avail_smpls(timestamp);
+ if (rc < 0) {
+ LOGC(DDEV, ERROR) << rx_buffers[0]->str_code(rc);
+ LOGC(DDEV, ERROR) << rx_buffers[0]->str_status(timestamp);
+ return 0;
+ }
+
+ struct bladerf_metadata meta = {};
+ meta.timestamp = ts;
+ //static bool first_rx = true;
+ // meta.timestamp = (first_rx) ? ts : 0;
+ // meta.flags = (!first_rx) ? 0:BLADERF_META_FLAG_RX_NOW;
+ // if(first_rx)
+ // first_rx = false;
+
+ // Receive samples from the usrp until we have enough
+ while (rx_buffers[0]->avail_smpls(timestamp) < len) {
+ thread_enable_cancel(false);
+ int status = bladerf_sync_rx(dev, pkt_ptrs[0], len, &meta, 200U);
+ thread_enable_cancel(true);
+
+ if (status != 0)
+ std::cerr << "RX fucked: " << bladerf_strerror(status);
+ if (meta.flags & BLADERF_META_STATUS_OVERRUN)
+ std::cerr << "RX fucked OVER: " << bladerf_strerror(status);
+
+ size_t num_smpls = meta.actual_count;
+ ;
+ ts = meta.timestamp;
+
+ for (size_t i = 0; i < rx_buffers.size(); i++) {
+ rc = rx_buffers[i]->write((short *)&pkt_bufs[i].front(), num_smpls, ts);
+
+ // Continue on local overrun, exit on other errors
+ if ((rc < 0)) {
+ LOGC(DDEV, ERROR) << rx_buffers[i]->str_code(rc);
+ LOGC(DDEV, ERROR) << rx_buffers[i]->str_status(timestamp);
+ if (rc != smpl_buf::ERROR_OVERFLOW)
+ return 0;
+ }
+ }
+ meta = {};
+ meta.timestamp = ts + num_smpls;
+ }
+
+ // We have enough samples
+ for (size_t i = 0; i < rx_buffers.size(); i++) {
+ rc = rx_buffers[i]->read(bufs[i], len, timestamp);
+ if ((rc < 0) || (rc != len)) {
+ LOGC(DDEV, ERROR) << rx_buffers[i]->str_code(rc);
+ LOGC(DDEV, ERROR) << rx_buffers[i]->str_status(timestamp);
+ return 0;
+ }
+ }
+
+ return len;
+}
+
+int blade_device::writeSamples(std::vector<short *> &bufs, int len, bool *underrun, unsigned long long timestamp)
+{
+ *underrun = false;
+ static bool first_tx = true;
+ struct bladerf_metadata meta = {};
+ if (first_tx) {
+ meta.timestamp = timestamp;
+ meta.flags = BLADERF_META_FLAG_TX_BURST_START;
+ first_tx = false;
+ }
+
+ thread_enable_cancel(false);
+ int status = bladerf_sync_tx(dev, (const void *)bufs[0], len, &meta, 200U);
+ //size_t num_smpls = tx_stream->send(bufs, len, metadata);
+ thread_enable_cancel(true);
+
+ if (status != 0)
+ std::cerr << "TX fucked: " << bladerf_strerror(status);
+
+ // LOGCHAN(0, DDEV, INFO) << "tx " << timestamp << " " << len << " t+l: "<< timestamp+len << std::endl;
+
+ return len;
+}
+
+bool blade_device::updateAlignment(TIMESTAMP timestamp)
+{
+ return true;
+}
+
+bool blade_device::set_freq(double freq, size_t chan, bool tx)
+{
+ if (tx) {
+ bladerf_set_frequency(dev, BLADERF_CHANNEL_TX(chan), freq);
+ bladerf_frequency f;
+ bladerf_get_frequency(dev, BLADERF_CHANNEL_TX(chan), &f);
+ tx_freqs[chan] = f;
+ } else {
+ bladerf_set_frequency(dev, BLADERF_CHANNEL_RX(chan), freq);
+ bladerf_frequency f;
+ bladerf_get_frequency(dev, BLADERF_CHANNEL_RX(chan), &f);
+ rx_freqs[chan] = f;
+ }
+ LOGCHAN(chan, DDEV, INFO) << "set_freq(" << freq << ", " << (tx ? "TX" : "RX") << "): " << std::endl;
+
+ return true;
+}
+
+bool blade_device::setTxFreq(double wFreq, size_t chan)
+{
+ uint16_t req_arfcn;
+ enum gsm_band req_band;
+
+ if (chan >= tx_freqs.size()) {
+ LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;
+ return false;
+ }
+ ScopedLock lock(tune_lock);
+
+ req_arfcn = gsm_freq102arfcn(wFreq / 1000 / 100, 0);
+ if (req_arfcn == 0xffff) {
+ LOGCHAN(chan, DDEV, ALERT) << "Unknown ARFCN for Tx Frequency " << wFreq / 1000 << " kHz";
+ return false;
+ }
+ if (gsm_arfcn2band_rc(req_arfcn, &req_band) < 0) {
+ LOGCHAN(chan, DDEV, ALERT)
+ << "Unknown GSM band for Tx Frequency " << wFreq << " Hz (ARFCN " << req_arfcn << " )";
+ return false;
+ }
+
+ if (!set_band(req_band))
+ return false;
+
+ if (!set_freq(wFreq, chan, true))
+ return false;
+
+ return true;
+}
+
+bool blade_device::setRxFreq(double wFreq, size_t chan)
+{
+ uint16_t req_arfcn;
+ enum gsm_band req_band;
+
+ if (chan >= rx_freqs.size()) {
+ LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;
+ return false;
+ }
+ ScopedLock lock(tune_lock);
+
+ req_arfcn = gsm_freq102arfcn(wFreq / 1000 / 100, 1);
+ if (req_arfcn == 0xffff) {
+ LOGCHAN(chan, DDEV, ALERT) << "Unknown ARFCN for Rx Frequency " << wFreq / 1000 << " kHz";
+ return false;
+ }
+ if (gsm_arfcn2band_rc(req_arfcn, &req_band) < 0) {
+ LOGCHAN(chan, DDEV, ALERT)
+ << "Unknown GSM band for Rx Frequency " << wFreq << " Hz (ARFCN " << req_arfcn << " )";
+ return false;
+ }
+
+ if (!set_band(req_band))
+ return false;
+
+ return set_freq(wFreq, chan, false);
+}
+
+double blade_device::getTxFreq(size_t chan)
+{
+ if (chan >= tx_freqs.size()) {
+ LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;
+ return 0.0;
+ }
+
+ return tx_freqs[chan];
+}
+
+double blade_device::getRxFreq(size_t chan)
+{
+ if (chan >= rx_freqs.size()) {
+ LOGC(DDEV, ALERT) << "Requested non-existent channel " << chan;
+ return 0.0;
+ }
+
+ return rx_freqs[chan];
+}
+
+bool blade_device::requiresRadioAlign()
+{
+ return false;
+}
+
+GSM::Time blade_device::minLatency()
+{
+ /* Empirical data from a handful of
+ relatively recent machines shows that the B100 will underrun when
+ the transmit threshold is reduced to a time of 6 and a half frames,
+ so we set a minimum 7 frame threshold. */
+ return GSM::Time(6, 7);
+}
+
+TIMESTAMP blade_device::initialWriteTimestamp()
+{
+ return ts_initial;
+}
+
+TIMESTAMP blade_device::initialReadTimestamp()
+{
+ return ts_initial;
+}
+
+double blade_device::fullScaleInputValue()
+{
+ return (double)2047;
+}
+
+double blade_device::fullScaleOutputValue()
+{
+ return (double)2047;
+}
+
+#ifndef IPCMAGIC
+RadioDevice *RadioDevice::make(size_t tx_sps, size_t rx_sps, InterfaceType iface, size_t chans, double lo_offset,
+ const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths)
+{
+ return new blade_device(tx_sps, rx_sps, iface, chans, lo_offset, tx_paths, rx_paths);
+}
+#endif
diff --git a/Transceiver52M/device/bladerf/bladerf.h b/Transceiver52M/device/bladerf/bladerf.h
new file mode 100644
index 0000000..07b7d6a
--- /dev/null
+++ b/Transceiver52M/device/bladerf/bladerf.h
@@ -0,0 +1,188 @@
+/*
+ * Copyright 2022 sysmocom - s.f.m.c. GmbH
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * SPDX-License-Identifier: AGPL-3.0+
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ * See the COPYING file in the main directory for details.
+ */
+
+#pragma once
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include "radioDevice.h"
+#include "smpl_buf.h"
+
+extern "C" {
+#include <osmocom/gsm/gsm_utils.h>
+}
+
+#include <bladerf.h>
+
+enum class blade_dev_type { BLADE1, BLADE2 };
+
+struct dev_band_desc {
+ /* Maximum UHD Tx Gain which can be set/used without distorting the
+ output signal, and the resulting real output power measured when that
+ gain is used. Correct measured values only provided for B210 so far. */
+ double nom_uhd_tx_gain; /* dB */
+ double nom_out_tx_power; /* dBm */
+ /* Factor used to infer base real RSSI offset on the Rx path based on current
+ configured RxGain. The resulting rssiOffset is added to the per burst
+ calculated energy in upper layers. These values were empirically
+ found and may change based on multiple factors, see OS#4468.
+ rssiOffset = rxGain + rxgain2rssioffset_rel;
+ */
+ double rxgain2rssioffset_rel; /* dB */
+};
+
+class blade_device : public RadioDevice {
+ public:
+ blade_device(size_t tx_sps, size_t rx_sps, InterfaceType type, size_t chan_num, double offset,
+ const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
+ ~blade_device();
+
+ int open(const std::string &args, int ref, bool swap_channels);
+ bool start();
+ bool stop();
+ bool restart();
+ enum TxWindowType getWindowType()
+ {
+ return tx_window;
+ }
+
+ int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun);
+
+ int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp);
+
+ bool updateAlignment(TIMESTAMP timestamp);
+
+ bool setTxFreq(double wFreq, size_t chan);
+ bool setRxFreq(double wFreq, size_t chan);
+
+ TIMESTAMP initialWriteTimestamp();
+ TIMESTAMP initialReadTimestamp();
+
+ double fullScaleInputValue();
+ double fullScaleOutputValue();
+
+ double setRxGain(double db, size_t chan);
+ double getRxGain(size_t chan);
+ double maxRxGain(void)
+ {
+ return rx_gain_max;
+ }
+ double minRxGain(void)
+ {
+ return rx_gain_min;
+ }
+ double rssiOffset(size_t chan);
+
+ double setPowerAttenuation(int atten, size_t chan);
+ double getPowerAttenuation(size_t chan = 0);
+
+ int getNominalTxPower(size_t chan = 0);
+
+ double getTxFreq(size_t chan);
+ double getRxFreq(size_t chan);
+ double getRxFreq();
+
+ bool setRxAntenna(const std::string &ant, size_t chan)
+ {
+ return {};
+ };
+ std::string getRxAntenna(size_t chan)
+ {
+ return {};
+ };
+ bool setTxAntenna(const std::string &ant, size_t chan)
+ {
+ return {};
+ };
+ std::string getTxAntenna(size_t chan)
+ {
+ return {};
+ };
+
+ bool requiresRadioAlign();
+
+ GSM::Time minLatency();
+
+ inline double getSampleRate()
+ {
+ return tx_rate;
+ }
+
+ /** Receive and process asynchronous message
+ @return true if message received or false on timeout or error
+ */
+ bool recv_async_msg();
+
+ enum err_code {
+ ERROR_TIMING = -1,
+ ERROR_TIMEOUT = -2,
+ ERROR_UNRECOVERABLE = -3,
+ ERROR_UNHANDLED = -4,
+ };
+
+ protected:
+ struct bladerf *dev;
+ void *usrp_dev;
+
+ enum TxWindowType tx_window;
+ enum blade_dev_type dev_type;
+
+ double tx_rate, rx_rate;
+
+ double rx_gain_min, rx_gain_max;
+
+ std::vector<double> tx_gains, rx_gains;
+ std::vector<double> tx_freqs, rx_freqs;
+ bool band_ass_curr_sess; /* true if "band" was set after last POWEROFF */
+ enum gsm_band band;
+ struct dev_band_desc band_desc;
+ size_t tx_spp, rx_spp;
+
+ bool started;
+ bool aligned;
+
+ size_t drop_cnt;
+ uint64_t prev_ts;
+
+ TIMESTAMP ts_initial, ts_offset;
+ std::vector<smpl_buf *> rx_buffers;
+ /* Sample buffers used to receive samples: */
+ std::vector<std::vector<short> > pkt_bufs;
+ /* Used to call UHD API: Buffer pointer of each elem in pkt_ptrs will
+ point to corresponding buffer of vector pkt_bufs. */
+ std::vector<short *> pkt_ptrs;
+
+ void init_gains();
+ void set_channels(bool swap);
+ void set_rates();
+ bool flush_recv(size_t num_pkts);
+
+ bool set_freq(double freq, size_t chan, bool tx);
+ void get_dev_band_desc(dev_band_desc &desc);
+ bool set_band(enum gsm_band req_band);
+ void assign_band_desc(enum gsm_band req_band);
+
+ Thread *async_event_thrd;
+ Mutex tune_lock;
+};
diff --git a/configure.ac b/configure.ac
index 37444a5..020f7e3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -138,6 +138,11 @@
[enable IPC])
])
+AC_ARG_WITH(bladerf, [
+ AS_HELP_STRING([--with-bladerf],
+ [enable bladeRF])
+])
+
AC_ARG_WITH(singledb, [
AS_HELP_STRING([--with-singledb],
[enable single daughterboard use on USRP1])
@@ -195,6 +200,10 @@
)
])
+AS_IF([test "x$with_bladerf" = "xyes"], [
+ PKG_CHECK_MODULES(BLADE, libbladeRF >= 2.0)
+])
+
AS_IF([test "x$with_singledb" = "xyes"], [
AC_DEFINE(SINGLEDB, 1, Define to 1 for single daughterboard)
])
@@ -248,6 +257,7 @@
AM_CONDITIONAL(DEVICE_USRP1, [test "x$with_usrp1" = "xyes"])
AM_CONDITIONAL(DEVICE_LMS, [test "x$with_lms" = "xyes"])
AM_CONDITIONAL(DEVICE_IPC, [test "x$with_ipc" = "xyes"])
+AM_CONDITIONAL(DEVICE_BLADE, [test "x$with_bladerf" = "xyes"])
AM_CONDITIONAL(ARCH_ARM, [test "x$with_neon" = "xyes" || test "x$with_neon_vfpv4" = "xyes"])
AM_CONDITIONAL(ARCH_ARM_A15, [test "x$with_neon_vfpv4" = "xyes"])
@@ -333,6 +343,8 @@
Transceiver52M/device/usrp1/Makefile \
Transceiver52M/device/lms/Makefile \
Transceiver52M/device/ipc/Makefile \
+ Transceiver52M/device/ipc2/Makefile \
+ Transceiver52M/device/bladerf/Makefile \
tests/Makefile \
tests/CommonLibs/Makefile \
tests/Transceiver52M/Makefile \
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac
Gerrit-Change-Number: 30413
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-trx[master]: ill-fated ipcv2 for mstrx
by Hoernchen
Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 )
Change subject: ill-fated ipcv2 for mstrx
......................................................................
ill-fated ipcv2 for mstrx
The problem here is that the ipc if requires reducing the clock ind
inteval to a few fn/ts on the trx side to work at all, but scheduling
still does not work out, unless you start driving the IF using the tx
side, at which point the approach is useless, because it does not really
do more than a burst loopback that is easier to do with the higher
layers/interfaces.
The code is still useful should there be a reason to continue working on
this.
Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5
---
M Transceiver52M/device/Makefile.am
A Transceiver52M/device/ipc2/IPCDevice.cpp
A Transceiver52M/device/ipc2/IPCDevice.h
A Transceiver52M/device/ipc2/Makefile.am
A Transceiver52M/device/ipc2/ipcif.h
A Transceiver52M/device/ipc2/shmif.h
6 files changed, 1,281 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/14/30414/1
diff --git a/Transceiver52M/device/Makefile.am b/Transceiver52M/device/Makefile.am
index 9af18f7..1fe7a8e 100644
--- a/Transceiver52M/device/Makefile.am
+++ b/Transceiver52M/device/Makefile.am
@@ -3,7 +3,7 @@
SUBDIRS = common
if DEVICE_IPC
-SUBDIRS += ipc
+SUBDIRS += ipc ipc2
endif
if DEVICE_USRP1
diff --git a/Transceiver52M/device/ipc2/IPCDevice.cpp b/Transceiver52M/device/ipc2/IPCDevice.cpp
new file mode 100644
index 0000000..0fc25c8
--- /dev/null
+++ b/Transceiver52M/device/ipc2/IPCDevice.cpp
@@ -0,0 +1,318 @@
+/*
+* Copyright 2022 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>
+* Author: Eric Wild <ewild(a)sysmocom.de>
+*
+* SPDX-License-Identifier: AGPL-3.0+
+*
+* This program is free software: you can redistribute it and/or modify
+* it under the terms of the GNU Affero General Public License as published by
+* the Free Software Foundation, either version 3 of the License, or
+* (at your option) any later version.
+*
+* This program is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+* GNU Affero General Public License for more details.
+*
+* You should have received a copy of the GNU Affero General Public License
+* along with this program. If not, see <http://www.gnu.org/licenses/>.
+* See the COPYING file in the main directory for details.
+*/
+
+#include <sys/time.h>
+#include <osmocom/core/timer_compat.h>
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include "Logger.h"
+#include "Threads.h"
+#include "IPCDevice.h"
+#include "smpl_buf.h"
+
+#define SAMPLE_BUF_SZ (1 << 20)
+static const auto ONE_BIT_DURATION ((12./5200.)/(156.25*4.));
+static const auto ONE_SAMPLE_DURATION_US ((ONE_BIT_DURATION/4.)*1000*1000);
+using namespace std;
+
+IPCDevice2::IPCDevice2(size_t tx_sps, size_t rx_sps, InterfaceType iface, size_t chan_num, double lo_offset,
+ const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths)
+ : RadioDevice(tx_sps, rx_sps, iface, chan_num, lo_offset, tx_paths, rx_paths), rx_buffers(chans),
+ started(false), tx_gains(chans), rx_gains(chans)
+{
+ LOGC(DDEV, INFO) << "creating IPC device...";
+
+ if (!(tx_sps == 4) || !(rx_sps == 4)) {
+ LOGC(DDEV, FATAL) << "IPC shm if create failed!";
+ exit(0);
+ }
+
+ /* Set up per-channel Rx timestamp based Ring buffers */
+ for (size_t i = 0; i < rx_buffers.size(); i++)
+ rx_buffers[i] = new smpl_buf(SAMPLE_BUF_SZ / sizeof(uint32_t));
+
+ if (!m.create()) {
+ LOGC(DDEV, FATAL) << "IPC shm if create failed!";
+ exit(0);
+ }
+}
+
+IPCDevice2::~IPCDevice2()
+{
+ LOGC(DDEV, INFO) << "Closing IPC device";
+ /* disable all channels */
+
+ for (size_t i = 0; i < rx_buffers.size(); i++)
+ delete rx_buffers[i];
+}
+
+int IPCDevice2::open(const std::string &args, int ref, bool swap_channels)
+{
+ std::string k, v;
+
+ /* configure antennas */
+ if (!set_antennas()) {
+ LOGC(DDEV, FATAL) << "IPC antenna setting failed";
+ goto out_close;
+ }
+
+ return iface == MULTI_ARFCN ? MULTI_ARFCN : NORMAL;
+
+out_close:
+ LOGC(DDEV, FATAL) << "Error in IPC open, closing";
+ return -1;
+}
+
+bool IPCDevice2::start()
+{
+ LOGC(DDEV, INFO) << "starting IPC...";
+
+ if (started) {
+ LOGC(DDEV, ERR) << "Device already started";
+ return true;
+ }
+
+ int max_bufs_to_flush = 120;
+ flush_recv(max_bufs_to_flush);
+
+ started = true;
+ return true;
+}
+
+bool IPCDevice2::stop()
+{
+ if (!started)
+ return true;
+
+ LOGC(DDEV, NOTICE) << "All channels stopped, terminating...";
+
+ /* reset internal buffer timestamps */
+ for (size_t i = 0; i < rx_buffers.size(); i++)
+ rx_buffers[i]->reset();
+
+ started = false;
+ return true;
+}
+
+double IPCDevice2::maxRxGain()
+{
+ return 70;
+}
+
+double IPCDevice2::minRxGain()
+{
+ return 0;
+}
+
+int IPCDevice2::getNominalTxPower(size_t chan)
+{
+ return 10;
+}
+
+double IPCDevice2::setPowerAttenuation(int atten, size_t chan)
+{
+ return atten;
+}
+
+double IPCDevice2::getPowerAttenuation(size_t chan)
+{
+ return 0;
+}
+
+double IPCDevice2::setRxGain(double dB, size_t chan)
+{
+ if (dB > maxRxGain())
+ dB = maxRxGain();
+ if (dB < minRxGain())
+ dB = minRxGain();
+
+ LOGCHAN(chan, DDEV, NOTICE) << "Setting RX gain to " << dB << " dB";
+
+ return dB;
+}
+
+bool IPCDevice2::flush_recv(size_t num_pkts)
+{
+ ts_initial = 10000;
+
+ LOGC(DDEV, INFO) << "Initial timestamp " << ts_initial << std::endl;
+ return true;
+}
+
+bool IPCDevice2::setRxAntenna(const std::string &ant, size_t chan)
+{
+ return true;
+}
+
+std::string IPCDevice2::getRxAntenna(size_t chan)
+{
+ return "";
+}
+
+bool IPCDevice2::setTxAntenna(const std::string &ant, size_t chan)
+{
+ return true;
+}
+
+std::string IPCDevice2::getTxAntenna(size_t chan)
+{
+ return "";
+}
+
+bool IPCDevice2::requiresRadioAlign()
+{
+ return false;
+}
+
+GSM::Time IPCDevice2::minLatency()
+{
+ /* UNUSED */
+ return GSM::Time(0, 0);
+}
+
+/** Returns the starting write Timestamp*/
+TIMESTAMP IPCDevice2::initialWriteTimestamp(void)
+{
+ return ts_initial;
+}
+
+/** Returns the starting read Timestamp*/
+TIMESTAMP IPCDevice2::initialReadTimestamp(void)
+{
+ return ts_initial;
+}
+
+static timespec readtime, writetime;
+static void wait_for_sample_time(timespec* last, unsigned int len) {
+ #if 1
+ timespec ts, diff;
+ clock_gettime(CLOCK_MONOTONIC, &ts);
+ timespecsub(&ts, last, &diff);
+ auto elapsed_us = (diff.tv_sec * 1000000) + (diff.tv_nsec / 1000);
+ auto max_wait_us = ONE_SAMPLE_DURATION_US * len;
+ if(elapsed_us < max_wait_us)
+ usleep(max_wait_us-elapsed_us);
+ *last = ts;
+ #else
+ usleep(ONE_SAMPLE_DURATION_US * 625);
+ #endif
+}
+
+// NOTE: Assumes sequential reads
+int IPCDevice2::readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun)
+{
+ int rc, num_smpls; //, expect_smpls;
+ ssize_t avail_smpls;
+ unsigned int i = 0;
+
+ *overrun = false;
+ *underrun = false;
+
+ timestamp += 0;
+
+ /* Check that timestamp is valid */
+ rc = rx_buffers[0]->avail_smpls(timestamp);
+ if (rc < 0) {
+ LOGC(DDEV, ERROR) << rx_buffers[0]->str_code(rc);
+ LOGC(DDEV, ERROR) << rx_buffers[0]->str_status(timestamp);
+ return 0;
+ }
+
+ /* Receive samples from HW until we have enough */
+ while ((avail_smpls = rx_buffers[i]->avail_smpls(timestamp)) < len) {
+ uint64_t recv_timestamp = timestamp;
+
+ m.read_ul(len - avail_smpls, &recv_timestamp, reinterpret_cast<sample_t *>(bufs[0]));
+ num_smpls = len - avail_smpls;
+ wait_for_sample_time(&readtime, num_smpls);
+
+ if (num_smpls == -ETIMEDOUT)
+ continue;
+
+ LOGCHAN(i, DDEV, DEBUG)
+ "Received timestamp = " << (TIMESTAMP)recv_timestamp << " (" << num_smpls << ")";
+
+ rc = rx_buffers[i]->write(bufs[i], num_smpls, (TIMESTAMP)recv_timestamp);
+ if (rc < 0) {
+ LOGCHAN(i, DDEV, ERROR)
+ << rx_buffers[i]->str_code(rc) << " num smpls: " << num_smpls << " chan: " << i;
+ LOGCHAN(i, DDEV, ERROR) << rx_buffers[i]->str_status(timestamp);
+ if (rc != smpl_buf::ERROR_OVERFLOW)
+ return 0;
+ }
+ }
+
+ /* We have enough samples */
+
+ rc = rx_buffers[i]->read(bufs[i], len, timestamp);
+ if ((rc < 0) || (rc != len)) {
+ LOGCHAN(i, DDEV, ERROR) << rx_buffers[i]->str_code(rc) << ". " << rx_buffers[i]->str_status(timestamp)
+ << ", (len=" << len << ")";
+ return 0;
+ }
+
+ return len;
+}
+
+int IPCDevice2::writeSamples(std::vector<short *> &bufs, int len, bool *underrun, unsigned long long timestamp)
+{
+ *underrun = false;
+
+ LOGCHAN(0, DDEV, DEBUG) << "send buffer of len " << len << " timestamp " << std::hex << timestamp;
+
+ // rc = ipc_shm_enqueue(shm_io_tx_streams[i], timestamp, len, (uint16_t *)bufs[i]);
+ m.write_dl(len, timestamp, reinterpret_cast<sample_t *>(bufs[0]));
+ wait_for_sample_time(&writetime, len);
+
+ return len;
+}
+
+bool IPCDevice2::updateAlignment(TIMESTAMP timestamp)
+{
+ return true;
+}
+
+bool IPCDevice2::setTxFreq(double wFreq, size_t chan)
+{
+ return true;
+}
+
+bool IPCDevice2::setRxFreq(double wFreq, size_t chan)
+{
+ return true;
+}
+
+RadioDevice *RadioDevice::make(size_t tx_sps, size_t rx_sps, InterfaceType iface, size_t chans, double lo_offset,
+ const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths)
+{
+ if (tx_sps != rx_sps) {
+ LOGC(DDEV, ERROR) << "IPC Requires tx_sps == rx_sps";
+ return NULL;
+ }
+ if (lo_offset != 0.0) {
+ LOGC(DDEV, ERROR) << "IPC doesn't support lo_offset";
+ return NULL;
+ }
+ return new IPCDevice2(tx_sps, rx_sps, iface, chans, lo_offset, tx_paths, rx_paths);
+}
diff --git a/Transceiver52M/device/ipc2/IPCDevice.h b/Transceiver52M/device/ipc2/IPCDevice.h
new file mode 100644
index 0000000..6286979
--- /dev/null
+++ b/Transceiver52M/device/ipc2/IPCDevice.h
@@ -0,0 +1,186 @@
+/*
+* Copyright 2022 sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>
+* Author: Eric Wild <ewild(a)sysmocom.de>
+*
+* SPDX-License-Identifier: AGPL-3.0+
+*
+* This program is free software: you can redistribute it and/or modify
+* it under the terms of the GNU Affero General Public License as published by
+* the Free Software Foundation, either version 3 of the License, or
+* (at your option) any later version.
+*
+* This program is distributed in the hope that it will be useful,
+* but WITHOUT ANY WARRANTY; without even the implied warranty of
+* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+* GNU Affero General Public License for more details.
+*
+* You should have received a copy of the GNU Affero General Public License
+* along with this program. If not, see <http://www.gnu.org/licenses/>.
+* See the COPYING file in the main directory for details.
+*/
+
+#ifndef _IPC_DEVICE_H_
+#define _IPC_DEVICE_H_
+
+
+#include <climits>
+#include <string>
+
+#ifdef HAVE_CONFIG_H
+#include "config.h"
+#endif
+
+#include "radioDevice.h"
+#include "ipcif.h"
+
+class smpl_buf;
+
+class IPCDevice2 : public RadioDevice {
+ trxmsif m;
+ protected:
+ std::vector<smpl_buf *> rx_buffers;
+ double actualSampleRate;
+
+ bool started;
+
+ TIMESTAMP ts_initial;
+
+ std::vector<double> tx_gains, rx_gains;
+
+ bool flush_recv(size_t num_pkts);
+ void update_stream_stats_rx(size_t chan, bool *overrun);
+ void update_stream_stats_tx(size_t chan, bool *underrun);
+
+ bool send_chan_wait_rsp(uint32_t chan, struct msgb *msg_to_send, uint32_t expected_rsp_msg_id);
+ bool send_all_chan_wait_rsp(uint32_t msgid_to_send, uint32_t msgid_to_expect);
+
+ public:
+ /** Object constructor */
+ IPCDevice2(size_t tx_sps, size_t rx_sps, InterfaceType iface, size_t chan_num, double lo_offset,
+ const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths);
+ virtual ~IPCDevice2() override;
+
+ /** Instantiate the IPC */
+ virtual int open(const std::string &args, int ref, bool swap_channels) override;
+
+ /** Start the IPC */
+ virtual bool start() override;
+
+ /** Stop the IPC */
+ virtual bool stop() override;
+
+ /* FIXME: any != USRP1 will do for now... */
+ enum TxWindowType getWindowType() override
+ {
+ return TX_WINDOW_FIXED;
+ }
+
+ /**
+ Read samples from the IPC.
+ @param buf preallocated buf to contain read result
+ @param len number of samples desired
+ @param overrun Set if read buffer has been overrun, e.g. data not being read fast enough
+ @param timestamp The timestamp of the first samples to be read
+ @param underrun Set if IPC does not have data to transmit, e.g. data not being sent fast enough
+ @return The number of samples actually read
+ */
+ virtual int readSamples(std::vector<short *> &buf, int len, bool *overrun, TIMESTAMP timestamp = 0xffffffff,
+ bool *underrun = NULL) override;
+ /**
+ Write samples to the IPC.
+ @param buf Contains the data to be written.
+ @param len number of samples to write.
+ @param underrun Set if IPC does not have data to transmit, e.g. data not being sent fast enough
+ @param timestamp The timestamp of the first sample of the data buffer.
+ @return The number of samples actually written
+ */
+ virtual int writeSamples(std::vector<short *> &bufs, int len, bool *underrun,
+ TIMESTAMP timestamp = 0xffffffff) override;
+
+ /** Update the alignment between the read and write timestamps */
+ virtual bool updateAlignment(TIMESTAMP timestamp) override;
+
+ /** Set the transmitter frequency */
+ virtual bool setTxFreq(double wFreq, size_t chan = 0) override;
+
+ /** Set the receiver frequency */
+ virtual bool setRxFreq(double wFreq, size_t chan = 0) override;
+
+ /** Returns the starting write Timestamp*/
+ virtual TIMESTAMP initialWriteTimestamp(void) override;
+
+ /** Returns the starting read Timestamp*/
+ virtual TIMESTAMP initialReadTimestamp(void) override;
+
+ /** returns the full-scale transmit amplitude **/
+ virtual double fullScaleInputValue() override
+ {
+ return (double)SHRT_MAX * 1;
+ }
+
+ /** returns the full-scale receive amplitude **/
+ virtual double fullScaleOutputValue() override
+ {
+ return (double)SHRT_MAX * 1;
+ }
+
+ /** sets the receive chan gain, returns the gain setting **/
+ virtual double setRxGain(double dB, size_t chan = 0) override;
+
+ /** get the current receive gain */
+ virtual double getRxGain(size_t chan = 0) override
+ {
+ return rx_gains[chan];
+ }
+
+ /** return maximum Rx Gain **/
+ virtual double maxRxGain(void) override;
+
+ /** return minimum Rx Gain **/
+ virtual double minRxGain(void) override;
+
+ /* FIXME: return rx_gains[chan] ? receive factor from IPC Driver? */
+ double rssiOffset(size_t chan) override
+ {
+ return 0.0f;
+ };
+
+ double setPowerAttenuation(int atten, size_t chan) override;
+ double getPowerAttenuation(size_t chan = 0) override;
+
+ virtual int getNominalTxPower(size_t chan = 0) override;
+
+ /** sets the RX path to use, returns true if successful and false otherwise */
+ virtual bool setRxAntenna(const std::string &ant, size_t chan = 0) override;
+
+ /* return the used RX path */
+ virtual std::string getRxAntenna(size_t chan = 0) override;
+
+ /** sets the RX path to use, returns true if successful and false otherwise */
+ virtual bool setTxAntenna(const std::string &ant, size_t chan = 0) override;
+
+ /* return the used RX path */
+ virtual std::string getTxAntenna(size_t chan = 0) override;
+
+ /** return whether user drives synchronization of Tx/Rx of USRP */
+ virtual bool requiresRadioAlign() override;
+
+ /** return whether user drives synchronization of Tx/Rx of USRP */
+ virtual GSM::Time minLatency() override;
+
+ /** Return internal status values */
+ virtual inline double getTxFreq(size_t chan = 0) override
+ {
+ return 0;
+ }
+ virtual inline double getRxFreq(size_t chan = 0) override
+ {
+ return 0;
+ }
+ virtual inline double getSampleRate() override
+ {
+ return actualSampleRate;
+ }
+};
+
+#endif // _IPC_DEVICE_H_
diff --git a/Transceiver52M/device/ipc2/Makefile.am b/Transceiver52M/device/ipc2/Makefile.am
new file mode 100644
index 0000000..ec5d533
--- /dev/null
+++ b/Transceiver52M/device/ipc2/Makefile.am
@@ -0,0 +1,14 @@
+include $(top_srcdir)/Makefile.common
+
+AM_CPPFLAGS = -Wall $(STD_DEFINES_AND_INCLUDES) -I${srcdir}/../common
+AM_CFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS)
+AM_CXXFLAGS = -lpthread $(LIBOSMOCORE_CFLAGS)
+AM_LDFLAGS = -lpthread -lrt
+
+noinst_HEADERS = IPCDevice.h
+
+noinst_LTLIBRARIES = libdevice.la
+
+libdevice_la_SOURCES = IPCDevice.cpp
+libdevice_la_LIBADD = $(top_builddir)/Transceiver52M/device/common/libdevice_common.la
+libdevice_la_CXXFLAGS = $(AM_CXXFLAGS) -DIPCMAGIC
diff --git a/Transceiver52M/device/ipc2/ipcif.h b/Transceiver52M/device/ipc2/ipcif.h
new file mode 100644
index 0000000..72f4c28
--- /dev/null
+++ b/Transceiver52M/device/ipc2/ipcif.h
@@ -0,0 +1,387 @@
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#pragma once
+
+#include <atomic>
+#include <complex>
+#include <cassert>
+#include <deque>
+#include <mutex>
+#include <vector>
+
+#include "shmif.h"
+
+const int max_ul_rdlen = 1024 * 10;
+const int max_dl_rdlen = 1024 * 10;
+using sample_t = std::complex<int16_t>;
+struct shm_if {
+ std::atomic<bool> ms_connected;
+ struct {
+ shm::sema r;
+ shm::sema w;
+ std::atomic<uint64_t> ts;
+ std::atomic<uint64_t> ts_req;
+ std::atomic<size_t> len_written_sps; // ->
+ sample_t buffer[max_ul_rdlen];
+ } ul;
+ struct {
+ shm::sema r;
+ shm::sema w;
+ std::atomic<uint64_t> ts;
+ std::atomic<uint64_t> ts_req;
+ std::atomic<size_t> len_written_sps;
+ sample_t buffer[max_dl_rdlen];
+ } dl;
+};
+
+// unique up to signed_type/2 diff
+// ex: uint8/int8 (250, 0) = -6
+template <typename A> auto unsigned_diff(A a, A b) -> typename std::make_signed<A>::type
+{
+ using stype = typename std::make_signed<A>::type;
+ return (a > b) ? static_cast<stype>(a - b) : -static_cast<stype>(b - a);
+};
+
+constexpr inline int samp2byte(int v)
+{
+ return v * sizeof(sample_t);
+}
+constexpr inline int byte2samp(int v)
+{
+ return v / sizeof(sample_t);
+}
+
+struct ulentry {
+ bool done;
+ uint64_t ts;
+ unsigned int len_in_sps;
+ unsigned int read_pos_in_sps;
+ sample_t buf[1000];
+};
+/*
+ write: find read index +.. until marked free = "end" of current list
+
+ check:
+ within begin, end AND not free?
+ y:
+ copy (chunk)
+ if chunk advance burst buf ptr
+ n: next, advance, remove old.
+ */
+template <unsigned int num_bursts> class ulburstprovider {
+ std::mutex ul_q_m;
+ // std::deque<ulentry> ul_q;
+
+ // classic circular buffer
+ ulentry foo[num_bursts];
+ int current_index; // % num_bursts
+
+ void cur_buf_done()
+ {
+ foo[current_index].done = true;
+ current_index = current_index + 1 % num_bursts;
+ }
+ bool is_empty()
+ {
+ return foo[current_index].done = true;
+ }
+ void reset()
+ {
+ for (auto &i : foo)
+ i = {};
+ current_index = 0;
+ }
+ ulentry &find_free_at_end()
+ {
+ for (int i = current_index, max_to_search = 0; max_to_search < num_bursts;
+ i = (i + 1 % num_bursts), max_to_search++) {
+ if (foo[i].done)
+ return foo[i];
+ }
+ return foo[0]; // FIXME actually broken, q full, wat do?
+ }
+
+ void push_back(ulentry &e)
+ {
+ auto free_buf = find_free_at_end();
+ free_buf = e;
+ e.done = false;
+ }
+
+ public:
+ void add(ulentry &e)
+ {
+ std::lock_guard<std::mutex> foo(ul_q_m);
+ push_back(e);
+ }
+ void get(uint64_t requested_ts, unsigned int req_len_in_sps, sample_t *buf, unsigned int max_buf_write_len)
+ {
+ std::lock_guard<std::mutex> g(ul_q_m);
+
+ /*
+ 1) if empty return
+ 2) if not empty prune stale bursts
+ 3) if only future bursts also return and zero buf
+ */
+ for (int i = current_index, max_to_search = 0; max_to_search < num_bursts;
+ i = (i + 1 % num_bursts), max_to_search++) {
+ auto cur_entry = foo[i];
+ if (is_empty()) { // might be empty due to advance below!
+ memset(buf, 0, samp2byte(req_len_in_sps));
+ return;
+ }
+
+ if (cur_entry.ts + cur_entry.len_in_sps < requested_ts) { // remove late bursts
+ if (i == current_index) // only advance if we are at the front
+ cur_buf_done();
+ else
+ assert(true);
+ } else if (cur_entry.ts >= requested_ts + byte2samp(max_buf_write_len)) { // not in range
+ memset(buf, 0, samp2byte(req_len_in_sps));
+ return;
+
+ // FIXME: what about requested_ts <= entry.ts <= ts + reqlen?
+ } else {
+ // requested_ts <= cur_entry.ts <= requested_ts + byte2samp(max_write_len)
+
+ auto before_sps = unsigned_diff(cur_entry.ts, requested_ts);
+
+ // at least one whole buffer before our most recent "head" burst?
+ // set 0, return.
+ if (-before_sps >= byte2samp(max_buf_write_len)) {
+ memset(buf, 0, samp2byte(req_len_in_sps));
+ return;
+ }
+ // less than one full buffer before: pad 0
+ auto to_pad_sps = -before_sps;
+ memset(buf, 0, samp2byte(to_pad_sps));
+ requested_ts += to_pad_sps;
+ req_len_in_sps -= to_pad_sps;
+
+ if (!req_len_in_sps)
+ return;
+
+ // actual burst data after possible 0 pad
+ auto max_sps_to_write = std::min(cur_entry.len_in_sps, req_len_in_sps);
+ memcpy(&buf[samp2byte(to_pad_sps)], cur_entry.buf, samp2byte(max_sps_to_write));
+ requested_ts += max_sps_to_write;
+ req_len_in_sps -= max_sps_to_write;
+ cur_entry.read_pos_in_sps += max_sps_to_write;
+
+ //this buf is done...
+ if (cur_entry.read_pos_in_sps == cur_entry.len_in_sps) {
+ cur_buf_done();
+ }
+
+ if (!req_len_in_sps)
+ return;
+ }
+ }
+ }
+};
+
+class trxmsif {
+ shm::shm<shm_if> m;
+ shm_if *ptr;
+
+ ulburstprovider<10> p;
+
+ template <typename T> void read(T &direction, size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
+ {
+ static int readoffset_sps;
+ // auto &direction = ptr->dl;
+ auto buf = &direction.buffer[0];
+ size_t len_avail_sps = direction.len_written_sps.load();
+
+ auto left_to_read = len_avail_sps - readoffset_sps;
+
+ shm::mtx_log::print_guard() << "\tr @" << direction.ts.load() << " " << readoffset_sps << std::endl;
+
+ // no data, wait for new buffer, maybe some data left afterwards
+ if (!left_to_read) {
+ assert(readoffset_sps == len_avail_sps);
+ readoffset_sps = 0;
+ direction.r.reset_unsafe();
+ direction.ts_req = (*read_ts);
+ direction.w.set(1);
+ direction.r.wait_and_reset(1);
+ assert(*read_ts != direction.ts.load());
+ // shm::sema_guard g(dl.r, dl.w);
+ *read_ts = direction.ts.load();
+ len_avail_sps = direction.len_written_sps.load();
+ readoffset_sps += howmany_sps;
+ assert(len_avail_sps >= howmany_sps);
+ memcpy(outbuf, buf, samp2byte(howmany_sps));
+
+ shm::mtx_log::print_guard() << "\tr+ " << *read_ts << " " << howmany_sps << std::endl;
+ return;
+ }
+
+ *read_ts = direction.ts.load() + readoffset_sps;
+ left_to_read = len_avail_sps - readoffset_sps;
+
+ // data left from prev read
+ if (left_to_read >= howmany_sps) {
+ memcpy(outbuf, &buf[readoffset_sps], samp2byte(howmany_sps));
+ readoffset_sps += howmany_sps;
+
+ shm::mtx_log::print_guard() << "\tr++ " << *read_ts << " " << howmany_sps << std::endl;
+ return;
+ } else {
+ memcpy(outbuf, &buf[readoffset_sps], samp2byte(left_to_read));
+ readoffset_sps = 0;
+ auto still_left_to_read = howmany_sps - left_to_read;
+ {
+ direction.r.reset_unsafe();
+ direction.ts_req = (*read_ts);
+ direction.w.set(1);
+ direction.r.wait_and_reset(1);
+ assert(*read_ts != direction.ts.load());
+ len_avail_sps = direction.len_written_sps.load();
+ assert(len_avail_sps >= still_left_to_read);
+ memcpy(&outbuf[left_to_read], buf, samp2byte(still_left_to_read));
+ readoffset_sps += still_left_to_read;
+ shm::mtx_log::print_guard()
+ << "\tr+++2 " << *read_ts << " " << howmany_sps << " " << still_left_to_read
+ << " new @" << direction.ts.load() << std::endl;
+ }
+ }
+ }
+
+ public:
+ trxmsif() : m("trx-ms-if")
+ {
+ }
+
+ bool create()
+ {
+ m.create();
+ ptr = m.p();
+ return m.isgood();
+ }
+ bool connect()
+ {
+ m.open();
+ ptr = m.p();
+ ptr->ms_connected = true;
+ ptr->dl.w.set(1);
+ return m.isgood();
+ }
+ bool good()
+ {
+ return m.isgood();
+ }
+ bool is_connected()
+ {
+ return ptr->ms_connected == true;
+ }
+
+ /* is being read from ms side */
+ void read_dl(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
+ {
+ return read(ptr->dl, howmany_sps, read_ts, outbuf);
+ }
+
+ /* is being read from trx/network side */
+ void read_ul(size_t howmany_sps, uint64_t *read_ts, sample_t *outbuf)
+ {
+ // if (ptr->ms_connected != true) {
+ memset(outbuf, 0, samp2byte(howmany_sps));
+ // return;
+ // }
+ // return read(ptr->ul, howmany_sps, read_ts, outbuf);
+ }
+
+ void write_dl(size_t howmany_sps, uint64_t write_ts, sample_t *inbuf)
+ {
+ auto &dl = ptr->dl;
+ auto buf = &dl.buffer[0];
+ if (ptr->ms_connected != true)
+ return;
+
+ assert(sizeof(dl.buffer) >= samp2byte(howmany_sps));
+ // print_guard() << "####w " << std::endl;
+
+ {
+ shm::sema_wait_guard g(dl.w, dl.r);
+
+ memcpy(buf, inbuf, samp2byte(howmany_sps));
+ dl.ts.store(write_ts);
+ dl.len_written_sps.store(howmany_sps);
+ }
+ shm::mtx_log::print_guard() << std::endl
+ << "####w+ " << write_ts << " " << howmany_sps << std::endl
+ << std::endl;
+ }
+
+ void write_ul(size_t howmany_sps_sps, uint64_t write_ts, sample_t *inbuf)
+ {
+ auto &ul = ptr->ul;
+ assert(sizeof(ul.buffer) >= samp2byte(howmany_sps_sps));
+ // print_guard() << "####w " << std::endl;
+
+ ulentry e;
+ e.ts = write_ts;
+ e.len_in_sps = howmany_sps_sps;
+ e.done = false;
+ e.read_pos_in_sps = 0;
+ assert(sizeof(e.buf) >= samp2byte(howmany_sps_sps));
+ memcpy(e.buf, inbuf, samp2byte(howmany_sps_sps));
+ p.add(e);
+
+ shm::mtx_log::print_guard() << std::endl
+ << "####q+ " << write_ts << " " << howmany_sps_sps << std::endl
+ << std::endl;
+ }
+
+ void drive_tx()
+ {
+ auto &ul = ptr->ul;
+ auto buf = &ul.buffer[0];
+ const auto max_write_len = sizeof(ul.buffer);
+
+ // ul_q_m.lock();
+ // ul_q.push_front(e);
+ // ul_q_m.unlock();
+ // ul.w.wait_and_reset();
+
+ // no read waiting for a write
+ if (!ul.w.check_unsafe(1))
+ return;
+
+ // FIXME: store written, notify after get!
+
+ auto requested_ts = ul.ts_req.load();
+
+ p.get(requested_ts, byte2samp(max_write_len), buf, max_write_len);
+
+ // memset(buf, 0, max_write_len);
+ ul.ts.store(requested_ts);
+ ul.len_written_sps.store(byte2samp(max_write_len));
+ ul.w.reset_unsafe();
+ ul.r.set(1);
+ }
+
+ void signal_read_start()
+ { /* nop */
+ }
+};
diff --git a/Transceiver52M/device/ipc2/shmif.h b/Transceiver52M/device/ipc2/shmif.h
new file mode 100644
index 0000000..89413ab
--- /dev/null
+++ b/Transceiver52M/device/ipc2/shmif.h
@@ -0,0 +1,375 @@
+/*
+ * (C) 2022 by sysmocom s.f.m.c. GmbH <info(a)sysmocom.de>
+ * All Rights Reserved
+ *
+ * Author: Eric Wild <ewild(a)sysmocom.de>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+#pragma once
+
+#include <atomic>
+#include <iostream>
+#include <cassert>
+#include <cstring>
+#include <mutex>
+#include <sstream>
+#include <unistd.h>
+#include <sys/mman.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <pthread.h>
+#include <cerrno>
+
+namespace shm
+{
+
+namespace mtx_log
+{
+#if defined(MTX_LOG_ENABLED)
+ class print_guard : public std::ostringstream {
+ static std::mutex thread_print_lock;
+
+ public:
+ ~print_guard()
+ {
+ std::lock_guard<std::mutex> guard(thread_print_lock);
+ std::cerr << str();
+ }
+ };
+
+#else
+ struct print_guard {};
+
+ template <typename T> constexpr print_guard operator<<(const print_guard dummy, T &&value)
+ {
+ return dummy;
+ }
+
+ constexpr print_guard operator<<(const print_guard &dummy, std::ostream &(*f)(std::ostream &))
+ {
+ return dummy;
+ }
+
+#endif
+} // namespace mtx_log
+
+class shmmutex {
+ pthread_mutex_t mutex;
+
+ public:
+ shmmutex()
+ {
+ pthread_mutexattr_t attr;
+ pthread_mutexattr_init(&attr);
+ pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);
+ pthread_mutexattr_setrobust(&attr, PTHREAD_MUTEX_ROBUST);
+ pthread_mutex_init(&mutex, &attr);
+ pthread_mutexattr_destroy(&attr);
+ }
+
+ ~shmmutex()
+ {
+ pthread_mutex_destroy(&mutex);
+ }
+
+ void lock()
+ {
+ pthread_mutex_lock(&mutex);
+ }
+
+ bool try_lock()
+ {
+ return pthread_mutex_trylock(&mutex);
+ }
+
+ void unlock()
+ {
+ pthread_mutex_unlock(&mutex);
+ }
+
+ pthread_mutex_t *p()
+ {
+ return &mutex;
+ }
+ shmmutex(const shmmutex &) = delete;
+ shmmutex &operator=(const shmmutex &) = delete;
+};
+
+class shmcond {
+ pthread_cond_t cond;
+
+ public:
+ shmcond()
+ {
+ pthread_condattr_t attr;
+ pthread_condattr_init(&attr);
+ pthread_condattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);
+ pthread_cond_init(&cond, &attr);
+ pthread_condattr_destroy(&attr);
+ }
+
+ ~shmcond()
+ {
+ pthread_cond_destroy(&cond);
+ }
+
+ void wait(shmmutex *lock)
+ {
+ pthread_cond_wait(&cond, lock->p());
+ }
+
+ void signal()
+ {
+ pthread_cond_signal(&cond);
+ }
+
+ void signal_all()
+ {
+ pthread_cond_broadcast(&cond);
+ }
+ shmcond(const shmcond &) = delete;
+ shmcond &operator=(const shmcond &) = delete;
+};
+
+class signal_guard {
+ shmmutex &m;
+ shmcond &s;
+
+ public:
+ signal_guard() = delete;
+ explicit signal_guard(shmmutex &m, shmcond &wait_for, shmcond &to_signal) : m(m), s(to_signal)
+ {
+ m.lock();
+ wait_for.wait(&m);
+ }
+ ~signal_guard()
+ {
+ s.signal();
+ m.unlock();
+ }
+ signal_guard(const signal_guard &) = delete;
+ signal_guard &operator=(const signal_guard &) = delete;
+};
+
+class mutex_guard {
+ shmmutex &m;
+
+ public:
+ mutex_guard() = delete;
+ explicit mutex_guard(shmmutex &m) : m(m)
+ {
+ m.lock();
+ }
+ ~mutex_guard()
+ {
+ m.unlock();
+ }
+ mutex_guard(const mutex_guard &) = delete;
+ mutex_guard &operator=(const mutex_guard &) = delete;
+};
+
+class sema {
+ std::atomic<int> value;
+ shmmutex m;
+ shmcond c;
+
+ public:
+ sema() : value(0)
+ {
+ }
+ explicit sema(int v) : value(v)
+ {
+ }
+
+ void wait()
+ {
+ wait(1);
+ }
+ void wait(int v)
+ {
+ mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
+ mutex_guard g(m);
+ assert(value <= v);
+ while (value != v)
+ c.wait(&m);
+ }
+ void wait_and_reset()
+ {
+ wait_and_reset(1);
+ }
+ void wait_and_reset(int v)
+ {
+ mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
+ mutex_guard g(m);
+ assert(value <= v);
+ while (value != v)
+ c.wait(&m);
+ value = 0;
+ }
+ void set()
+ {
+ set(1);
+ }
+ void set(int v)
+ {
+ mtx_log::print_guard() << __FUNCTION__ << value << std::endl;
+ mutex_guard g(m);
+ value = v;
+ c.signal();
+ }
+ void reset_unsafe()
+ {
+ value = 0;
+ }
+ bool check_unsafe(int v)
+ {
+ return value == v;
+ }
+ sema(const sema &) = delete;
+ sema &operator=(const sema &) = delete;
+};
+
+class sema_wait_guard {
+ sema &a;
+ sema &b;
+
+ public:
+ sema_wait_guard() = delete;
+ explicit sema_wait_guard(sema &wait, sema &signal) : a(wait), b(signal)
+ {
+ a.wait_and_reset(1);
+ }
+ ~sema_wait_guard()
+ {
+ b.set(1);
+ }
+ sema_wait_guard(const sema_wait_guard &) = delete;
+ sema_wait_guard &operator=(const sema_wait_guard &) = delete;
+};
+
+class sema_signal_guard {
+ sema &a;
+ sema &b;
+
+ public:
+ sema_signal_guard() = delete;
+ explicit sema_signal_guard(sema &wait, sema &signal) : a(wait), b(signal)
+ {
+ a.wait_and_reset(1);
+ }
+ ~sema_signal_guard()
+ {
+ b.set(1);
+ }
+ sema_signal_guard(const sema_signal_guard &) = delete;
+ sema_signal_guard &operator=(const sema_signal_guard &) = delete;
+};
+
+template <typename IFT> class shm {
+ char shmname[512];
+ size_t IFT_sz = sizeof(IFT);
+ IFT *shmptr;
+ bool good;
+ int ipc_shm_setup(const char *shm_name)
+ {
+ int fd;
+ int rc;
+ void *ptr;
+
+ if ((fd = shm_open(shm_name, O_CREAT | O_RDWR | O_TRUNC, S_IRUSR | S_IWUSR)) < 0) {
+ rc = -errno;
+ return rc;
+ }
+
+ if (ftruncate(fd, IFT_sz) < 0) {
+ rc = -errno;
+ shm_unlink(shm_name);
+ ::close(fd);
+ }
+
+ if ((ptr = mmap(NULL, IFT_sz, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0)) == MAP_FAILED) {
+ rc = -errno;
+ shm_unlink(shm_name);
+ ::close(fd);
+ }
+
+ shmptr = new (ptr) IFT(); //static_cast<IFT *>(ptr);
+ ::close(fd);
+ return 0;
+ }
+
+ int ipc_shm_connect(const char *shm_name)
+ {
+ int fd;
+ int rc;
+ void *ptr;
+
+ if ((fd = shm_open(shm_name, O_CREAT | O_RDWR, S_IRUSR | S_IWUSR)) < 0) {
+ rc = -errno;
+ return rc;
+ }
+
+ struct stat shm_stat;
+ if (fstat(fd, &shm_stat) < 0) {
+ rc = -errno;
+ shm_unlink(shm_name);
+ ::close(fd);
+ }
+
+ if ((ptr = mmap(NULL, shm_stat.st_size, PROT_READ | PROT_WRITE, MAP_SHARED, fd, 0)) == MAP_FAILED) {
+ rc = -errno;
+ shm_unlink(shm_name);
+ ::close(fd);
+ }
+
+ shmptr = static_cast<IFT *>(ptr);
+ ::close(fd);
+ return 0;
+ }
+
+ public:
+ using IFT_t = IFT;
+ explicit shm(const char *name) : good(false)
+ {
+ strncpy((char *)shmname, name, 512);
+ }
+ void create()
+ {
+ if (ipc_shm_setup(shmname) == 0)
+ good = true;
+ }
+ void open()
+ {
+ if (ipc_shm_connect(shmname) == 0)
+ good = true;
+ }
+ bool isgood() const
+ {
+ return good;
+ }
+ void close()
+ {
+ if (isgood())
+ shm_unlink(shmname);
+ }
+ IFT *p()
+ {
+ return shmptr;
+ }
+};
+
+} // namespace shm
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5
Gerrit-Change-Number: 30414
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-MessageType: newchange
1 year, 5 months
- 1
- 0
Change in osmo-bsc[master]: vty: Write amount of timeouts elapsed for a paging request
by daniel
Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30402 )
Change subject: vty: Write amount of timeouts elapsed for a paging request
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30402
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a
Gerrit-Change-Number: 30402
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 10:02:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-bsc[master]: paging: Optimize retrieving number of request per paging group
by daniel
Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30370 )
Change subject: paging: Optimize retrieving number of request per paging group
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30370/comment/358be808_41c43869
PS4, Line 93: bts_pag_st->initial_req_pgroup_counts[req->pgroup]--;
> Yup, I already had this in mind thanks!
Done
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30370
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531
Gerrit-Change-Number: 30370
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 10:01:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-bsc[master]: paging: Replace reqs waiting for retransmission with new incoming ini...
by daniel
Attention is currently required from: pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30347 )
Change subject: paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full
......................................................................
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30347
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d
Gerrit-Change-Number: 30347
Gerrit-PatchSet: 7
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 09:58:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans
by daniel
Attention is currently required from: osmith, fixeria, pespin.
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 )
Change subject: paging: Split paging queue into 2 queues: initial and retrans
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/osmo-bsc/paging.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/bdb3dfe7_cb65a7a1
PS1, Line 216:
> wrong indentation
Is there a way to include this in our lint job?
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747
Gerrit-Change-Number: 30363
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 01 Dec 2022 09:56:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
1 year, 5 months
- 1
- 0
Change in osmo-ci[master]: jobs/osmocom-release-tarballs: update clone url
by osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30393 )
Change subject: jobs/osmocom-release-tarballs: update clone url
......................................................................
jobs/osmocom-release-tarballs: update clone url
Use gerrit.osmocom.org so we don't have a delay.
Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Git_infrastructure
Change-Id: I4391016fda1584fa7d423521802458dca9b1b7ec
---
M jobs/osmocom-release-tarballs.yml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/jobs/osmocom-release-tarballs.yml b/jobs/osmocom-release-tarballs.yml
index fad7462..ee83ea4 100644
--- a/jobs/osmocom-release-tarballs.yml
+++ b/jobs/osmocom-release-tarballs.yml
@@ -26,7 +26,7 @@
- git:
branches:
- '$BRANCH_DOCKER_PLAYGROUND'
- url: https://gitea.osmocom.org/osmocom/docker-playground
+ url: https://gerrit.osmocom.org/docker-playground
git-config-name: 'Jenkins Builder'
git-config-email: 'jenkins(a)osmocom.org'
# Don't wipe workspace to keep generated release tarballs
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30393
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I4391016fda1584fa7d423521802458dca9b1b7ec
Gerrit-Change-Number: 30393
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged
1 year, 5 months
- 1
- 0