Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30737 )
Change subject: library/L1CTL_Types: eliminate warning about missing 'h0h1' field
......................................................................
Patch Set 1:
(1 comment)
File library/L1CTL_Types.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30737/comment/6d20d848_f540…
PS1, Line 653: h0h1 := -,
> what does this "-" do here?
Explicitly tells the compiler that this field is intentionally unitialized here.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30737
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I73c86eea4708823e9c004a5b830793ce705dcb75
Gerrit-Change-Number: 30737
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 13:30:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: Hoernchen, fixeria, pespin.
Hello Jenkins Builder, laforge, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-trx/+/30416
to look at the new patch set (#26).
Change subject: ms-trx support
......................................................................
ms-trx support
This is basically a trxcon that includes a transceiver, and can just
be used with existing and future apps supporting the trxcon interface,
i.e. mobile or ccch_scan.
Supports bladerf and uhd.
Currently using hardcoded sched/prios aimed at a setup with working,
reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3,
not 2, not any other version)
Additionally builds test tools used for development: osmo-trx-syncthing*
see https://osmocom.org/projects/baseband/wiki/MS-side_GPRS for the
project description and details
Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
---
M .gitignore
M .gitmodules
M Makefile.am
M Transceiver52M/Makefile.am
A Transceiver52M/ms/bladerf_specific.h
A Transceiver52M/ms/itrq.h
A Transceiver52M/ms/l1ctl_server.c
A Transceiver52M/ms/l1ctl_server_cb.cpp
A Transceiver52M/ms/logging.c
A Transceiver52M/ms/ms.cpp
A Transceiver52M/ms/ms.h
A Transceiver52M/ms/ms_rx_burst.h
A Transceiver52M/ms/ms_rx_burst_test.cpp
A Transceiver52M/ms/ms_rx_lower.cpp
A Transceiver52M/ms/ms_upper.cpp
A Transceiver52M/ms/ms_upper.h
A Transceiver52M/ms/sch.c
A Transceiver52M/ms/sch.h
A Transceiver52M/ms/uhd_specific.h
M configure.ac
M contrib/jenkins.sh
M osmocom-bb
22 files changed, 3,473 insertions(+), 9 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/26
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84
Gerrit-Change-Number: 30416
Gerrit-PatchSet: 26
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30724 )
Change subject: gsm_08_58: add IEI to signal HR GSM RTP format via RSL
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
BLocking until detailed explanation is provided on why is this needed.
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30724
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I843c8a0cbe5898311f3af3294cec7c8bc96c4eb8
Gerrit-Change-Number: 30724
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 13:05:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/30728 )
Change subject: rsl.adoc: add info about RSL_IE_OSMO_HR_GSM_RTP_FMT
......................................................................
Patch Set 2: Code-Review-1
(2 comments)
File doc/manuals/abis/rsl.adoc:
https://gerrit.osmocom.org/c/osmo-bts/+/30728/comment/cc59fb63_c826c405
PS2, Line 1096: On the receiving side (Downlink) osmoBTS will always accept both formats. The format
OsmoBTS
https://gerrit.osmocom.org/c/osmo-bts/+/30728/comment/9c4a0498_d53c51f7
PS2, Line 1106: (Bits 7 - 1 are reserved for future use and must be set to zero.)
so how does the BSC know which format does the BTS support? It just selects one without knowing which ones are supported?
Why does OsmoBSC need to know which format is going to be used?
Can this simply be configured in OsmoBSC or inferred from bts type in osmo-bsc.cfg?
I'm not sure having an extension IE is the way to go here. Let's try to understand better the motivations and requirements first.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/30728
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I1d40f688ad1729efffee846e7f9efd06cf64ce28
Gerrit-Change-Number: 30728
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 13:05:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/30716 )
Change subject: trau_sync: add Ericsson RBS GPRS TRAU synchronization pattern (16kbps)
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmo-abis/+/30716/comment/07477726_dcddf33c
PS1, Line 10: introduces a propritary synchronization pattern. There are slightly different
> Done
I still see "propritary" written there?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/30716
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: I8398f8bbfc51530e37c4328f25155b774394e779
Gerrit-Change-Number: 30716
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 12:58:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
Gerrit-MessageType: comment