December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-gsm-tester[master]: templates: osmo-msc: modernize

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30421 ) Change subject: templates: osmo-msc: modernize ...................................................................... templates: osmo-msc: modernize Configure the mgw in the mgw node, and drop the obsolete commands endpoint-range and bts-base. Fix for: | Error occurred during reading the below line: | mgw bts-base 8000 | | % MGCP commands outside of 'mgw' nodes are deprecated. You should consider reading User Manual and migrating to 'mgw' node. Change-Id: I077c4cd4c593da776a306117ad2a898a82d91064 --- M src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl 1 file changed, 4 insertions(+), 5 deletions(-) Approvals: pespin: Looks good to me, approved; Verified diff --git a/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl index 39cde5f..1b91672 100644 --- a/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl @@ -18,6 +18,10 @@ long name ${msc.net.long_name} encryption ${msc.net.encryption} authentication ${msc.net.authentication} + mgw 0 + remote-ip ${mgw.ip_address.addr} + remote-port 2427 + local-ip ${msc.ip_address.addr} cs7 instance 0 point-code 0.0.1 asp asp0 2905 0 m3ua @@ -27,11 +31,6 @@ asp asp0 routing-key 1 0.0.1 msc - mgw remote-ip ${mgw.ip_address.addr} - mgw remote-port 2427 - mgw local-ip ${msc.ip_address.addr} - mgw endpoint-range 1 31 - mgw bts-base 8000 osmux ${msc.use_osmux} assign-tmsi %if msc.get('emergency_call_msisdn', None) is not None: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I077c4cd4c593da776a306117ad2a898a82d91064 Gerrit-Change-Number: 30421 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: osmo-gsm-tester: fix getting latest commit

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30420 ) Change subject: osmo-gsm-tester: fix getting latest commit ...................................................................... osmo-gsm-tester: fix getting latest commit Get the latest commit from gerrit.osmocom.org, because after we moved repositories from git.osmocom.org it currently answers with a 404. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Git_infrastructure Change-Id: I0e2215d067dec1e2327f765b5a97ba7512812647 --- M osmo-gsm-tester/Dockerfile 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/osmo-gsm-tester/Dockerfile b/osmo-gsm-tester/Dockerfile index 36fc20e..bb6f521 100644 --- a/osmo-gsm-tester/Dockerfile +++ b/osmo-gsm-tester/Dockerfile @@ -160,8 +160,8 @@ ARG OSMO_GSM_TESTER_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-gsm-tester.git -ADD http://git.osmocom.org/osmo-gsm-tester/patch?h=$OSMO_GSM_TESTER_BRANCH /tmp/commit +RUN git clone https://gerrit.osmocom.org/osmo-gsm-tester.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-gsm-tester/+/$OSMO_GSM_TEST… /tmp/commit RUN cd osmo-gsm-tester && \ git fetch && git checkout $OSMO_GSM_TESTER_BRANCH && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0e2215d067dec1e2327f765b5a97ba7512812647 Gerrit-Change-Number: 30420 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: fix default branch

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30423 ) Change subject: jobs/osmo-gsm-tester virtual: fix default branch ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4ad1ce71fd5b5b57a65267e0be51755f7495b07d Gerrit-Change-Number: 30423 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 15:22:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: don't limit to deb9

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30426 ) Change subject: jobs/osmo-gsm-tester virtual: don't limit to deb9 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8e7ffa65b4ff6d1816ad167367b0f6ff8c00e64b Gerrit-Change-Number: 30426 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 15:21:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-gsm-tester[master]: templates: osmo-msc: modernize

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30421 ) Change subject: templates: osmo-msc: modernize ...................................................................... Patch Set 1: Verified+1 Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I077c4cd4c593da776a306117ad2a898a82d91064 Gerrit-Change-Number: 30421 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 15:21:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: osmo-gsm-tester: fix getting latest commit

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/30420 ) Change subject: osmo-gsm-tester: fix getting latest commit ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0e2215d067dec1e2327f765b5a97ba7512812647 Gerrit-Change-Number: 30420 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 15:20:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: send mails on error

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30429 ) Change subject: jobs/osmo-gsm-tester virtual: send mails on error ...................................................................... jobs/osmo-gsm-tester virtual: send mails on error Change-Id: If91644a3dfea1af259f7a511a7784cf32d8d23ea --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/29/30429/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index f6692ee..0d6cc47 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -261,6 +261,9 @@ - junit: results: 'trial-*/last_run/trial-*.xml' allow-empty-results: true + - email: + notify-every-unstable-build: true + recipients: jenkins-notifications(a)lists.osmocom.org parameters: - string: name: "OSMO_GSM_TESTER_OPTS" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30429 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: If91644a3dfea1af259f7a511a7784cf32d8d23ea Gerrit-Change-Number: 30429 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester: remove old test result early

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30428 ) Change subject: jobs/osmo-gsm-tester: remove old test result early ...................................................................... jobs/osmo-gsm-tester: remove old test result early The virtual osmo-gsm-tester has been failing for a long time, but the test results were still green. This was because the job failed before it removed old test results, and so those were used. Remove the old results as early as possible to prevent this in the future. Change-Id: I23f2f7b24fe41bbded2e05abbe6ea5e717b88e9e --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/28/30428/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 0e866ac..f6692ee 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -171,8 +171,8 @@ branch-pattern: '**' builders: - shell: | - # make sure no bin artifacts from a previous run remain - rm -f *.tgz *.md5 + # make sure no test results/bin artifacts from a previous run remain + rm -rf trial-* *.tgz *.md5 - copy_artifact_all - shell: !include-raw: osmo-gsm-tester_run-gerrit.sh publishers: @@ -193,8 +193,8 @@ - timed: "H 23 * * *" builders: - shell: | - # make sure no bin artifacts from a previous run remain - rm -f *.tgz *.md5 + # make sure no test results/bin artifacts from a previous run remain + rm -rf trial-* *.tgz *.md5 - copy_artifact_all - copy_artifact: repo: osmo-gsm-tester_build-osmocom-bb @@ -218,8 +218,8 @@ - timed: "H 22 * * *" builders: - shell: | - # make sure no bin artifacts from a previous run remain - rm -f *.tgz *.md5 + # make sure no test results/bin artifacts from a previous run remain + rm -rf trial-* *.tgz *.md5 - copy_artifact_all - copy_artifact: repo: osmo-gsm-tester_build-osmocom-bb -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30428 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I23f2f7b24fe41bbded2e05abbe6ea5e717b88e9e Gerrit-Change-Number: 30428 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: fix default branch

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30423 ) Change subject: jobs/osmo-gsm-tester virtual: fix default branch ...................................................................... jobs/osmo-gsm-tester virtual: fix default branch Change it to "master" instead of "origin/master" to prepare for building the docker image right before running it. The Makefile from docker-playground.git picks up the OSMO_GSM_TESTER_BRANCH environment variable and expects it to be in that format. Change-Id: I4ad1ce71fd5b5b57a65267e0be51755f7495b07d --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/23/30423/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 6b9df3e..9e50f6e 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -258,5 +258,5 @@ description: "pass additional command line options to osmo-gsm-tester.py, e.g. to select specific suites:scenarios. Default: leave empty." - string: name: "OSMO_GSM_TESTER_BRANCH" - default: "origin/master" + default: "master" description: "Which branch/sha should be used for testing" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30423 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4ad1ce71fd5b5b57a65267e0be51755f7495b07d Gerrit-Change-Number: 30423 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: use literal style

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30424 ) Change subject: jobs/osmo-gsm-tester virtual: use literal style ...................................................................... jobs/osmo-gsm-tester virtual: use literal style Use literal style instead of folded style in the shell argument of osmo-gsm-tester_virtual as otherwise new lines behave unintuitively. Related: https://yaml-multiline.info/ Change-Id: I862a0ed24bae2c713e857a459797e1a978df0560 --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/24/30424/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 9e50f6e..bff2a9b 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -223,7 +223,7 @@ - copy_artifact_all - copy_artifact: repo: osmo-gsm-tester_build-osmocom-bb - - shell: > + - shell: | unlink osmo-gsm-tester/sysmocom/resources.conf || true ln -s resources.conf.virtual osmo-gsm-tester/sysmocom/resources.conf -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30424 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I862a0ed24bae2c713e857a459797e1a978df0560 Gerrit-Change-Number: 30424 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester: clone from gerrit git url

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30422 ) Change subject: jobs/osmo-gsm-tester: clone from gerrit git url ...................................................................... jobs/osmo-gsm-tester: clone from gerrit git url Use the gerrit git url instead of the gitea one so we don't have a sync delay. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Git_infrastructure Change-Id: I586fdd55ded6c3776cacd6760d88aa455da22990 --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/22/30422/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 73a49db..6b9df3e 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -32,7 +32,7 @@ name: osmo-gsm-tester-repo scm: - git: - url: https://gitea.osmocom.org/cellular-infrastructure/osmo-gsm-tester + url: https://gerrit.osmocom.org/osmo-gsm-tester branches: - ${OSMO_GSM_TESTER_BRANCH} wipe-workspace: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30422 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I586fdd55ded6c3776cacd6760d88aa455da22990 Gerrit-Change-Number: 30422 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: fix opts desciption

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30427 ) Change subject: jobs/osmo-gsm-tester virtual: fix opts desciption ...................................................................... jobs/osmo-gsm-tester virtual: fix opts desciption The default value is what it says in the line above, not empty. Change-Id: I5ce8a47b43525dcca6bf54184a48f11b0c87c19e --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/27/30427/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 739bb61..0e866ac 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -265,7 +265,7 @@ - string: name: "OSMO_GSM_TESTER_OPTS" default: "-s netreg_mass" - description: "pass additional command line options to osmo-gsm-tester.py, e.g. to select specific suites:scenarios. Default: leave empty." + description: "pass additional command line options to osmo-gsm-tester.py, e.g. to select specific suites:scenarios" - string: name: "OSMO_GSM_TESTER_BRANCH" default: "master" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30427 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I5ce8a47b43525dcca6bf54184a48f11b0c87c19e Gerrit-Change-Number: 30427 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: don't limit to deb9

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30426 ) Change subject: jobs/osmo-gsm-tester virtual: don't limit to deb9 ...................................................................... jobs/osmo-gsm-tester virtual: don't limit to deb9 Related: OS#5793 Change-Id: I8e7ffa65b4ff6d1816ad167367b0f6ff8c00e64b --- M jobs/osmo-gsm-tester-runner.yml 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/26/30426/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index 814c0c9..739bb61 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -211,7 +211,7 @@ - job: name: 'osmo-gsm-tester_virtual' defaults: runner - node: 'osmocom-master-debian9' + node: 'osmocom-master' scm: - 'osmo-gsm-tester-repo' triggers: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30426 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8e7ffa65b4ff6d1816ad167367b0f6ff8c00e64b Gerrit-Change-Number: 30426 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: jobs/osmo-gsm-tester virtual: fix docker img

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30425 ) Change subject: jobs/osmo-gsm-tester virtual: fix docker img ...................................................................... jobs/osmo-gsm-tester virtual: fix docker img Build the docker image right before using it, instead of building it in another jenkins job update-osmo-ci-on-slaves via osmo-ci-docker-rebuild.sh. The logic in osmo-ci-docker-rebuild.sh was broken. I didn't realize at the time that this image is only used for the virtual osmo-gsm-tester, not the physical ones. But only the machines running the physical osmo-gsm-tester have the /var/tmp/osmo-gsm-tester/state path. The virtual osmo-gsm-tester isn't running on these machines but on generic jenkins nodes. Building the image right before using it makes sense for this job, as it is the only user of the image. If it was already built from the same Dockerfile, a cached version is used. Fix for: Unable to find image 'osmocom-build/osmo-gsm-tester:latest' locally Fixes: 9139e76b ("osmo-ci-docker-rebuild: don't always build osmo-gsm-tester") Change-Id: Icad9459de1d3a3a4e65ecacf7f903433bb504cc9 --- M jobs/osmo-gsm-tester-runner.yml M scripts/osmo-ci-docker-rebuild.sh 2 files changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/25/30425/1 diff --git a/jobs/osmo-gsm-tester-runner.yml b/jobs/osmo-gsm-tester-runner.yml index bff2a9b..814c0c9 100644 --- a/jobs/osmo-gsm-tester-runner.yml +++ b/jobs/osmo-gsm-tester-runner.yml @@ -224,6 +224,16 @@ - copy_artifact: repo: osmo-gsm-tester_build-osmocom-bb - shell: | + # Build the docker image + rm -rf docker-playground + git clone \ + --depth=1 \ + --branch="$DOCKER_PLAYGROUND_BRANCH" \ + https://gerrit.osmocom.org/docker-playground \ + docker-playground + git -C docker-playground log --oneline + make -C docker-playground/osmo-gsm-tester + unlink osmo-gsm-tester/sysmocom/resources.conf || true ln -s resources.conf.virtual osmo-gsm-tester/sysmocom/resources.conf @@ -260,3 +270,7 @@ name: "OSMO_GSM_TESTER_BRANCH" default: "master" description: "Which branch/sha should be used for testing" + - string: + name: "DOCKER_PLAYGROUND_BRANCH" + default: "master" + description: "Which branch/sha should be used for building the osmo-gsm-tester docker container" diff --git a/scripts/osmo-ci-docker-rebuild.sh b/scripts/osmo-ci-docker-rebuild.sh index 9c2aae6..f409d45 100755 --- a/scripts/osmo-ci-docker-rebuild.sh +++ b/scripts/osmo-ci-docker-rebuild.sh @@ -10,8 +10,3 @@ "debian-bullseye-erlang" \ "debian-bullseye-jenkins" fi - -if [ -d "/var/tmp/osmo-gsm-tester/state" ]; then - docker_images_require \ - "osmo-gsm-tester" -fi -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icad9459de1d3a3a4e65ecacf7f903433bb504cc9 Gerrit-Change-Number: 30425 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-gsm-tester[master]: templates: osmo-msc: modernize

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30421 ) Change subject: templates: osmo-msc: modernize ...................................................................... templates: osmo-msc: modernize Configure the mgw in the mgw node, and drop the obsolete commands endpoint-range and bts-base. Fix for: | Error occurred during reading the below line: | mgw bts-base 8000 | | % MGCP commands outside of 'mgw' nodes are deprecated. You should consider reading User Manual and migrating to 'mgw' node. Change-Id: I077c4cd4c593da776a306117ad2a898a82d91064 --- M src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester refs/changes/21/30421/1 diff --git a/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl b/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl index 39cde5f..1b91672 100644 --- a/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl +++ b/src/osmo_gsm_tester/templates/osmo-msc.cfg.tmpl @@ -18,6 +18,10 @@ long name ${msc.net.long_name} encryption ${msc.net.encryption} authentication ${msc.net.authentication} + mgw 0 + remote-ip ${mgw.ip_address.addr} + remote-port 2427 + local-ip ${msc.ip_address.addr} cs7 instance 0 point-code 0.0.1 asp asp0 2905 0 m3ua @@ -27,11 +31,6 @@ asp asp0 routing-key 1 0.0.1 msc - mgw remote-ip ${mgw.ip_address.addr} - mgw remote-port 2427 - mgw local-ip ${msc.ip_address.addr} - mgw endpoint-range 1 31 - mgw bts-base 8000 osmux ${msc.use_osmux} assign-tmsi %if msc.get('emergency_call_msisdn', None) is not None: -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/30421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-tester Gerrit-Branch: master Gerrit-Change-Id: I077c4cd4c593da776a306117ad2a898a82d91064 Gerrit-Change-Number: 30421 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in docker-playground[master]: osmo-gsm-tester: fix getting latest commit

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/30420 ) Change subject: osmo-gsm-tester: fix getting latest commit ...................................................................... osmo-gsm-tester: fix getting latest commit Get the latest commit from gerrit.osmocom.org, because after we moved repositories from git.osmocom.org it currently answers with a 404. Related: https://osmocom.org/projects/cellular-infrastructure/wiki/Git_infrastructure Change-Id: I0e2215d067dec1e2327f765b5a97ba7512812647 --- M osmo-gsm-tester/Dockerfile 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/20/30420/1 diff --git a/osmo-gsm-tester/Dockerfile b/osmo-gsm-tester/Dockerfile index 36fc20e..bb6f521 100644 --- a/osmo-gsm-tester/Dockerfile +++ b/osmo-gsm-tester/Dockerfile @@ -160,8 +160,8 @@ ARG OSMO_GSM_TESTER_BRANCH="master" -RUN git clone git://git.osmocom.org/osmo-gsm-tester.git -ADD http://git.osmocom.org/osmo-gsm-tester/patch?h=$OSMO_GSM_TESTER_BRANCH /tmp/commit +RUN git clone https://gerrit.osmocom.org/osmo-gsm-tester.git +ADD https://gerrit.osmocom.org/plugins/gitiles/osmo-gsm-tester/+/$OSMO_GSM_TEST… /tmp/commit RUN cd osmo-gsm-tester && \ git fetch && git checkout $OSMO_GSM_TESTER_BRANCH && \ -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/30420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I0e2215d067dec1e2327f765b5a97ba7512812647 Gerrit-Change-Number: 30420 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: bladerf xa4 support

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:54:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: vita demod by piotr krysik, modified

by Hoernchen

Attention is currently required from: pespin, fixeria. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 ) Change subject: vita demod by piotr krysik, modified ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57c38754_c059e099 PS2, Line 7: by piotr krysik > Commit message should ideally state where the code is imported from, including the commit hash if it […] Done File Transceiver52M/grgsm_vitac/viterbi_detector.cc: https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c83d3f0f_fdee178b PS2, Line 1: /* -*- c++ -*- */ > All files are named ".cpp", why is this one named ". […] nothing to fix here, this file is a literal copy of the grgsm code and it should stay that way, also obove. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:43:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: bladerf xa4 support

by Hoernchen

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 2: (2 comments) File Transceiver52M/device/bladerf/bladerf.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/62fe1f31_f2262ca9 PS1, Line 432: // Initialize and shadow gain values > The file is literally copypasted from the b210 code and those comments are useless anyway... Done https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/cc218d2d_eff7db90 PS1, Line 727: #ifndef IPCMAGIC > This is related to the ipc interface test that uses the uhd backend for the ipc side,which is where […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:42:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: vita demod by piotr krysik, modified

by Jenkins Builder

Attention is currently required from: Hoernchen. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30415 ) Change subject: vita demod by piotr krysik, modified ...................................................................... Patch Set 3: (946 comments) File Transceiver52M/grgsm_vitac/constants.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/519f5b70_2a20c3f8 PS3, Line 1: #pragma once DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a7a9edb_081c96f6 PS3, Line 2: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4842db4e_25d2176f PS3, Line 3: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/75dfaff7_1cbb6ba1 PS3, Line 4: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/80e59fd4_996fc48f PS3, Line 5: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38007f1c_6cf154c8 PS3, Line 6: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d88a76a2_ebdedfc9 PS3, Line 7: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/144a0d5e_8682cb1e PS3, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ff485b2_765ec3d4 PS3, Line 9: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b79dea44_b443ff97 PS3, Line 10: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70bd6958_b10d371a PS3, Line 11: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53507dda_39322efe PS3, Line 12: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8aa27162_ada89389 PS3, Line 13: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4169b984_1dadf4f3 PS3, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb294409_e2dad96f PS3, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e4a38a92_eb27e322 PS3, Line 16: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/31ac21f4_739d4788 PS3, Line 17: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/265efeff_0ca31062 PS3, Line 18: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d89ecb6_049e3b3d PS3, Line 19: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1ad25a4_63e7efdc PS3, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/989c7b31_8f078268 PS3, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0ca1a9a1_62f91bb3 PS3, Line 21: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d1ece50_396b38c8 PS3, Line 22: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aa010cbc_5360897e PS3, Line 23: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/03911975_e9e86fec PS3, Line 24: #include <complex> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c845c77e_82a09c8e PS3, Line 25: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed7f18c6_9107a15c PS3, Line 26: #define gr_complex std::complex<float> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/098a1a54_4ddab551 PS3, Line 26: #define gr_complex std::complex<float> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/22ee556c_23927c17 PS3, Line 26: #define gr_complex std::complex<float> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/adf882bf_65c042af PS3, Line 27: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19f7e955_f3236830 PS3, Line 28: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4107d592_af94e9bf PS3, Line 29: #define GSM_SYMBOL_RATE (1625000.0/6.0) //symbols per second trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b827e5b0_bd1243a1 PS3, Line 30: #define GSM_SYMBOL_PERIOD (1.0/GSM_SYMBOL_RATE) //seconds per symbol trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b3ce18d_e9f3b0ea PS3, Line 31: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/627c7a87_a0c30220 PS3, Line 32: //Burst timing trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e7577f13_7a08a152 PS3, Line 33: #define TAIL_BITS 3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/943b79b4_f84dd9e1 PS3, Line 34: #define GUARD_BITS 8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21dc6de7_9b4731e4 PS3, Line 35: #define GUARD_FRACTIONAL 0.25 //fractional part of guard period trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc3911a0_e40bf25c PS3, Line 36: #define GUARD_PERIOD GUARD_BITS + GUARD_FRACTIONAL DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/710d7d8f_ec7dfbf4 PS3, Line 37: #define DATA_BITS 57 //size of 1 data block in normal burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab0c846a_906e70df PS3, Line 38: #define STEALING_BIT 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3093062_d1e9e1fb PS3, Line 39: #define N_TRAIN_BITS 26 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d2f6c15_9b85a8b7 PS3, Line 40: #define N_SYNC_BITS 64 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9cc582a6_ecee97a5 PS3, Line 41: #define USEFUL_BITS 142 //(2*(DATA_BITS+STEALING_BIT) + N_TRAIN_BITS ) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a3a1008_9d043bd0 PS3, Line 42: #define FCCH_BITS USEFUL_BITS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df3234c7_3fbf2c4d PS3, Line 43: #define BURST_SIZE (USEFUL_BITS+2*TAIL_BITS) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c28e69cf_a406aa3e PS3, Line 44: #define ACCESS_BURST_SIZE 88 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d7ce09f_8d9374db PS3, Line 45: #define PROCESSED_CHUNK BURST_SIZE+2*GUARD_PERIOD DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4fdebb3d_102c8515 PS3, Line 46: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bfec958_878c7d60 PS3, Line 47: #define SCH_DATA_LEN 39 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/646461e3_5348735f PS3, Line 48: #define TS_BITS (TAIL_BITS+USEFUL_BITS+TAIL_BITS+GUARD_BITS) //a full TS (156 bits) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/12ffdaa8_9001c0a4 PS3, Line 49: #define TS_PER_FRAME 8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0e41187_1a8dcc3e PS3, Line 50: #define FRAME_BITS (TS_PER_FRAME * TS_BITS + 2) // 156.25 * 8 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1480165_2c6e40d4 PS3, Line 51: #define FCCH_POS TAIL_BITS DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3df69348_64ce6ce4 PS3, Line 52: #define SYNC_POS (TAIL_BITS + 39) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1dedf4c0_e4641f73 PS3, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c83ff25c_109c6a5c PS3, Line 53: #define TRAIN_POS ( TAIL_BITS + (DATA_BITS+STEALING_BIT) + 5) //first 5 bits of a training sequence space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35a84e34_bd46d887 PS3, Line 54: //aren't used for channel impulse response estimation trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c749a67d_9794469d PS3, Line 55: #define TRAIN_BEGINNING 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad4a58fd_35d218ea PS3, Line 56: #define SAFETY_MARGIN 6 // trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b69566d_e7383210 PS3, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d48d42a_c84ae030 PS3, Line 58: #define FCCH_HITS_NEEDED (USEFUL_BITS - 4) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d387134c_96844e59 PS3, Line 59: #define FCCH_MAX_MISSES 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f66e1cc4_73e74854 PS3, Line 60: #define FCCH_MAX_FREQ_OFFSET 100 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b01d6ba_3a74a81c PS3, Line 61: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6399d33f_db52a9e6 PS3, Line 62: #define CHAN_IMP_RESP_LENGTH 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/734a7fec_f289ff32 PS3, Line 63: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84088376_6f555181 PS3, Line 64: #define MAX_SCH_ERRORS 10 //maximum number of subsequent sch errors after which gsm receiver goes to find_next_fcch state trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ee26514b_9d77dbe1 PS3, Line 65: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ecc47b6a_71322e56 PS3, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f165ab5_314ba8ad PS3, Line 66: typedef enum { empty, fcch_burst, sch_burst, normal_burst, rach_burst, dummy, dummy_or_normal, normal_or_noise } burst_type; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0286ea30_f026d4dd PS3, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c087289e_d7ce659e PS3, Line 67: typedef enum { unknown, multiframe_26, multiframe_51 } multiframe_type; do not add new typedefs Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88d14c93_6bb93e23 PS3, Line 68: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5840cdaf_e9d47d17 PS3, Line 69: static const unsigned char SYNC_BITS[] = { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c80e8b8f_51e13f92 PS3, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a8bdf61e_797f6792 PS3, Line 70: 1, 0, 1, 1, 1, 0, 0, 1, 0, 1, 1, 0, 0, 0, 1, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd685256_034c9fd5 PS3, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65196d83_8d46bf68 PS3, Line 71: 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 1, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fef780b_6086d938 PS3, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6882232a_922bd89c PS3, Line 72: 0, 0, 1, 0, 1, 1, 0, 1, 0, 1, 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d8b1a96_d8f45930 PS3, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be00cd77_7fac66e9 PS3, Line 73: 0, 1, 1, 1, 0, 1, 1, 0, 0, 0, 0, 1, 1, 0, 1, 1 please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56b38362_596983b4 PS3, Line 74: }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfee7d16_9c1eafca PS3, Line 75: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/80d1ce24_e6281d92 PS3, Line 76: const unsigned FCCH_FRAMES[] = { 0, 10, 20, 30, 40 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e371e1c6_b3ec6786 PS3, Line 77: const unsigned SCH_FRAMES[] = { 1, 11, 21, 31, 41 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05d0148f_268c6063 PS3, Line 78: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d84d183a_ccd3e8ba PS3, Line 79: const unsigned BCCH_FRAMES[] = { 2, 3, 4, 5 }; //!!the receiver shouldn't care about logical trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/408f3072_c70fab74 PS3, Line 80: //!!channels so this will be removed from this header trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1b4a8a34_2bf7abbd PS3, Line 81: const unsigned TEST_CCH_FRAMES[] = { 2, 3, 4, 5, 6, 7, 8, 9, 12, 13, 14, 15, 16, 17, 18, 19, 22, 23, 24, 25, 26, 27, 28, 29, 32, 33, 34, 35, 36, 37, 38, 39, 42, 43, 44, 45, 46, 47, 48, 49 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9940c3f3_c91d8d67 PS3, Line 82: const unsigned TRAFFIC_CHANNEL_F[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff4d8d1e_ee65e37f PS3, Line 83: const unsigned TEST51[] = { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31, 32, 33, 34, 35, 36, 37, 38, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c337d53b_83f52e1a PS3, Line 84: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/93c94ba2_0f72128f PS3, Line 85: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35613168_b9ebb059 PS3, Line 86: #define TSC0 0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fd7e4836_7835a763 PS3, Line 87: #define TSC1 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65745c9b_cf8e96e4 PS3, Line 88: #define TSC2 2 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfaf1e32_420a5592 PS3, Line 89: #define TSC3 3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15f51a2f_1a9afad5 PS3, Line 90: #define TSC4 4 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66373faa_7da2e110 PS3, Line 91: #define TSC5 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d03f8b30_1f372e1b PS3, Line 92: #define TSC6 6 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77402768_7773a65a PS3, Line 93: #define TSC7 7 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9f6fdb3_934e7fa6 PS3, Line 94: #define TS_DUMMY 8 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6490f288_d4d11ad1 PS3, Line 95: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f3ab86ed_42704c50 PS3, Line 96: #define TRAIN_SEQ_NUM 9 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54c8dc87_dc299b89 PS3, Line 97: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01b5a0a0_048359e0 PS3, Line 98: #define TIMESLOT0 0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec128405_5dee214a PS3, Line 99: #define TIMESLOT1 1 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70fca779_0fcd70f2 PS3, Line 100: #define TIMESLOT2 2 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb42394d_d26631b3 PS3, Line 101: #define TIMESLOT3 3 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/450f6745_bf969d9f PS3, Line 102: #define TIMESLOT4 4 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9a6a8ec_4bbdda02 PS3, Line 103: #define TIMESLOT5 5 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c5657d3_d259a9f4 PS3, Line 104: #define TIMESLOT6 6 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fcc73a1d_0e51f61d PS3, Line 105: #define TIMESLOT7 7 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97b15515_f2839b05 PS3, Line 106: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c5a3fd0f_2950645d PS3, Line 107: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1a5e4f8_3edb3466 PS3, Line 108: static const unsigned char train_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS] = { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82e9368d_5e158bee PS3, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10c861fa_72d4c38b PS3, Line 109: {0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 0, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/33a00ebb_5ff44b3e PS3, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/adb2031f_b889b524 PS3, Line 110: {0, 0, 1, 0, 1, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9758c14a_7b7f32ba PS3, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/599bdcc7_d89b5e20 PS3, Line 111: {0, 1, 0, 0, 0, 0, 1, 1, 1, 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, 0, 0, 0, 1, 1, 1, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e20d5b39_6eb7bb0b PS3, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61ec141b_5bb37627 PS3, Line 112: {0, 1, 0, 0, 0, 1, 1, 1, 1, 0, 1, 1, 0, 1, 0, 0, 0, 1, 0, 0, 0, 1, 1, 1, 1, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4323ba89_3cd51e3c PS3, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/648fb32a_779922ff PS3, Line 113: {0, 0, 0, 1, 1, 0, 1, 0, 1, 1, 1, 0, 0, 1, 0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d7f156c9_32618bb4 PS3, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37e1dffe_b8f84ff0 PS3, Line 114: {0, 1, 0, 0, 1, 1, 1, 0, 1, 0, 1, 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, 1, 1, 0, 1, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/612a250f_38ece580 PS3, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/909e9314_ff798a43 PS3, Line 115: {1, 0, 1, 0, 0, 1, 1, 1, 1, 1, 0, 1, 1, 0, 0, 0, 1, 0, 1, 0, 0, 1, 1, 1, 1, 1}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1f3dca2_aa854cc8 PS3, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0}, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94714898_3dcc87ff PS3, Line 116: {1, 1, 1, 0, 1, 1, 1, 1, 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, 1, 0, 1, 1, 1, 1, 0, 0}, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d88491e5_0e9447b9 PS3, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f50d5e8a_ca161bb0 PS3, Line 117: {0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, 0, 0, 0, 1, 0, 1} // DUMMY please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d2988494_4d0fba54 PS3, Line 118: }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc8b4c37_e68f01be PS3, Line 119: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0220da44_881de942 PS3, Line 120: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37bb08a9_4e2054d2 PS3, Line 121: //Dummy burst 0xFB 76 0A 4E 09 10 1F 1C 5C 5C 57 4A 33 39 E9 F1 2F A8 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a67fa457_ab0bb1f2 PS3, Line 122: static const unsigned char dummy_burst[] = { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/274b40b7_24767beb PS3, Line 123: 0, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61925abf_e5724480 PS3, Line 123: 0, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/91c0f806_000ab3b8 PS3, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49dfa0c8_15053199 PS3, Line 124: 1, 1, 1, 1, 1, 0, 1, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef791d4d_2a4de513 PS3, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1d98957_42795aa0 PS3, Line 125: 1, 1, 0, 1, 1, 0, 0, 0, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/672c9633_5f32c41c PS3, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/562bc42c_d336db46 PS3, Line 126: 1, 0, 1, 0, 0, 1, 0, 0, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/250e120a_271717c3 PS3, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1d2f82f_6b4895e4 PS3, Line 127: 1, 0, 0, 0, 0, 0, 1, 0, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/07ffa6fc_d42d428c PS3, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43896e02_ad15b8f5 PS3, Line 128: 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8420bba0_28a917d3 PS3, Line 129: 0, 1, 1, 1, 1, 1, 0, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09da7f6d_75fdda75 PS3, Line 129: 0, 1, 1, 1, 1, 1, 0, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69f942b5_c75fdbcf PS3, Line 130: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b2695c3_e4becc2f PS3, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/161e1b7c_a5dda3ba PS3, Line 131: 0, 1, 1, 1, 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c02f44d_27c8ca14 PS3, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f02f834_b7692c4c PS3, Line 132: 1, 1, 0, 0, 0, 1, 0, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e641699c_45cdfb3f PS3, Line 133: 0, 0, 0, 1, 0, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed9f3c54_cd28c8a9 PS3, Line 133: 0, 0, 0, 1, 0, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb2e0d43_a1bf0eb9 PS3, Line 134: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85c65ba9_3fcd6db9 PS3, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b6265ea5_99ce5e8a PS3, Line 135: 0, 1, 1, 1, 0, 1, 0, 0, 1, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9ac8e204_cbb4fdcb PS3, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9456f723_4099c195 PS3, Line 136: 1, 0, 0, 0, 1, 1, 0, 0, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4118e24_ea10ca20 PS3, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/134daeaa_373a10c3 PS3, Line 137: 0, 0, 1, 1, 1, 0, 0, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8212ef11_8d36adbb PS3, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1c9f68a9_26dd8fae PS3, Line 138: 1, 0, 1, 0, 0, 1, 1, 1, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63676fdd_a3cf0bb8 PS3, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98eb7925_458cc21d PS3, Line 139: 0, 0, 0, 1, 0, 0, 1, 0, 1, 1, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4b1058c7_403f925a PS3, Line 140: 1, 1, 1, 0, 1, 0, 1, 0, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c90d442b_a622627a PS3, Line 140: 1, 1, 1, 0, 1, 0, 1, 0, please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0970e760_706f1fe4 PS3, Line 141: 0, 0, 0 DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92e3cda9_e1726df8 PS3, Line 141: 0, 0, 0 please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/300dff43_e68a96d2 PS3, Line 142: }; DOS line endings File Transceiver52M/grgsm_vitac/grgsm_vitac.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/382d5ff7_835d0781 PS3, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bdc6b35_f0082d5c PS3, Line 38: void initvita(); Bad function definition - void initvita() should probably be void initvita(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad6b135a_0d369adf PS3, Line 59: std::string fpath; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65737d9a_d1925e35 PS3, Line 60: std::vector<gr_complex> data; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be6216ba_820cdfd7 PS3, Line 60: std::vector<gr_complex> data; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/de70841a_8ea9f9fc PS3, Line 60: std::vector<gr_complex> data; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/201912e0_cb879b8c PS3, Line 62: }; adding a line without newline at end of file File Transceiver52M/grgsm_vitac/grgsm_vitac.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f1a57f6_1cda4d44 PS3, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0969a97_f91642a8 PS3, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6221f6d2_383b0a1e PS3, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/434aa87c_58801632 PS3, Line 4: * @author (C) 2009-2017 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76552417_dc9ba0d6 PS3, Line 5: * @author Contributions by sysmocom - s.f.m.c. GmbH / Eric Wild <ewild(a)sysmocom.de> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/772e6272_d732b5a8 PS3, Line 6: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45cd1c16_a5035881 PS3, Line 7: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9a07ff42_25adb761 PS3, Line 8: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e9d5e8c6_1d4ee704 PS3, Line 9: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba65e762_07abc8f5 PS3, Line 10: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae5099a9_97be38bb PS3, Line 11: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f863e2c_135f3318 PS3, Line 12: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63ac44f5_544c07dd PS3, Line 13: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0e5da0b_af3007e8 PS3, Line 14: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32063ca1_c211c888 PS3, Line 15: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/feabf137_0a6abef2 PS3, Line 16: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26ac41c7_1601b55c PS3, Line 17: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87dddb84_f6e1144c PS3, Line 18: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ffdd6780_f85eb4c9 PS3, Line 19: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5f4bccb_2003f611 PS3, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/74f1a26c_13809d46 PS3, Line 20: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/afd8e2d7_cc9b6541 PS3, Line 21: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6c158217_4816a319 PS3, Line 22: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc928e47_1153221d PS3, Line 23: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c7edbbe5_7ec5946b PS3, Line 24: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0049b479_c82cb2f1 PS3, Line 25: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eaabddf7_fed0f26d PS3, Line 26: #ifdef HAVE_CONFIG_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/90bcb99f_6d4f9fa5 PS3, Line 27: #include "config.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/737b24e9_61422ed8 PS3, Line 28: #endif DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2f878da7_d16eb9a7 PS3, Line 29: #include <complex> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7b9ccb9_4c19b8cc PS3, Line 30: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a74fc131_3668bb27 PS3, Line 31: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d63eff6a_7dbe77c9 PS3, Line 32: #include <algorithm> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad3018cd_fec02aaa PS3, Line 33: #include <string.h> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/80b86cb2_7f768e86 PS3, Line 34: #include <iostream> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0faea20_5817cb98 PS3, Line 35: #include <numeric> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63e2ef52_08cd5b23 PS3, Line 36: #include <vector> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3efe269_7d93212a PS3, Line 37: #include <fstream> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13b11c04_4ccfa701 PS3, Line 38: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba529ead_11a9ff8c PS3, Line 39: #include "viterbi_detector.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9946d0cb_13286eaa PS3, Line 40: #include "grgsm_vitac.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fcf43011_4d0d4bb1 PS3, Line 41: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51a20e17_41900442 PS3, Line 42: //signalVector mChanResp; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ff85446f_3b5776fd PS3, Line 43: gr_complex d_sch_training_seq[N_SYNC_BITS]; ///<encoded training sequence of a SCH burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0461420_2e44049d PS3, Line 44: gr_complex d_norm_training_seq[TRAIN_SEQ_NUM][N_TRAIN_BITS]; ///<encoded training sequences of a normal and dummy burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/46c4320e_c26dea17 PS3, Line 45: const int d_chan_imp_length = CHAN_IMP_RESP_LENGTH; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ca26744_8966b9b4 PS3, Line 46: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9b22725_eb6ec548 PS3, Line 47: void initvita() { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6fa9dfb_9aae998a PS3, Line 48: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e52cc1e5_289e89b0 PS3, Line 49: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5eb04fcc_7fe18c8c PS3, Line 50: * Prepare SCH sequence bits trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a35bb86c_8852b889 PS3, Line 51: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c7ad75a_0bab3b55 PS3, Line 52: * (TS_BITS + 2 * GUARD_PERIOD) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/07020d1d_386c09de PS3, Line 53: * Burst and two guard periods trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/455715f7_3332522a PS3, Line 54: * (one guard period is an arbitrary overlap) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/678b1040_61d20797 PS3, Line 55: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/924e69b0_28eb1456 PS3, Line 56: gmsk_mapper(SYNC_BITS, N_SYNC_BITS, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab0d9f3d_50c95149 PS3, Line 57: d_sch_training_seq, gr_complex(0.0, -1.0)); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3abc1791_2724af7b PS3, Line 58: for (auto &i : d_sch_training_seq) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1cafd63_3768d2c1 PS3, Line 59: i = conj(i); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54aa60bb_d61f37b5 PS3, Line 60: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea3c5268_d1915a15 PS3, Line 61: /* Prepare bits of training sequences */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1cc16c2e_0dfd2061 PS3, Line 62: for (int i = 0; i < TRAIN_SEQ_NUM; i++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06fa95e9_0fa4d71a PS3, Line 63: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1a3b284f_561ecf8d PS3, Line 64: * If first bit of the sequence is 0 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2e3665d_a8bda5d3 PS3, Line 65: * => first symbol is 1, else -1 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc251918_7d82872b PS3, Line 66: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8ca4d060_f65005b4 PS3, Line 67: gr_complex startpoint = train_seq[i][0] == 0 ? DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8cd2854_7b626082 PS3, Line 68: gr_complex(1.0, 0.0) : gr_complex(-1.0, 0.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7619db9d_63a7d399 PS3, Line 69: gmsk_mapper(train_seq[i], N_TRAIN_BITS, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/124ead64_5a255580 PS3, Line 70: d_norm_training_seq[i], startpoint); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8ff59c6b_39cd550a PS3, Line 71: for (auto &i : d_norm_training_seq[i]) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/81f94d2c_b06f87bf PS3, Line 72: i = conj(i); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/72c5ff26_a668bb5b PS3, Line 73: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d4944ac_b728e808 PS3, Line 74: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54cff608_238617b7 PS3, Line 75: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3635daf_1938d6ba PS3, Line 76: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77c8b7bc_0f73cfa0 PS3, Line 77: MULTI_VER_TARGET_ATTR DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f10d3dfd_ff49ca37 PS3, Line 78: void detect_burst(const gr_complex *input, gr_complex *chan_imp_resp, int burst_start, char *output_binary) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fbe1dbc6_822707e8 PS3, Line 79: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40c07bd3_bddfed79 PS3, Line 80: std::vector<gr_complex> rhh_temp(CHAN_IMP_RESP_LENGTH * d_OSR); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c324249c_ebbfcfec PS3, Line 81: unsigned int stop_states[2] = { 4, 12 }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/45592198_07cdd50b PS3, Line 82: gr_complex filtered_burst[BURST_SIZE]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a071bd9b_1ffd160d PS3, Line 83: gr_complex rhh[CHAN_IMP_RESP_LENGTH]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65a5281b_a62e9d6a PS3, Line 84: float output[BURST_SIZE]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8002e6c6_2f257b50 PS3, Line 85: int start_state = 3; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dbef558_bed98bed PS3, Line 86: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fe647fe7_1a0380d3 PS3, Line 87: // if(burst_start < 0 ||burst_start > 10) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40f21f5a_3469af6d PS3, Line 88: // fprintf(stderr, "bo %d\n", burst_start); trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2cf39bd3_76f6cbc3 PS3, Line 89: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/15f7f7e7_f03e3de9 PS3, Line 90: // burst_start = burst_start >= 0 ? burst_start : 0; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2cac09a3_77b1fa43 PS3, Line 91: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86df286b_0b7decdc PS3, Line 92: autocorrelation(chan_imp_resp, &rhh_temp[0], d_chan_imp_length * d_OSR); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f60ed44_a4e6f502 PS3, Line 93: for (int ii = 0; ii < d_chan_imp_length; ii++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8fbec567_e2866f75 PS3, Line 94: rhh[ii] = conj(rhh_temp[ii * d_OSR]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b84e3607_7ab5af68 PS3, Line 95: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/30b68ad4_0b57005a PS3, Line 96: mafi(&input[burst_start], BURST_SIZE, chan_imp_resp, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae0e9b6f_dbd78cee PS3, Line 97: d_chan_imp_length * d_OSR, filtered_burst); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/341903da_0a2719b4 PS3, Line 98: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab67138a_ad6c4b23 PS3, Line 99: viterbi_detector(filtered_burst, BURST_SIZE, rhh, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d41bff08_ea6f08e2 PS3, Line 100: start_state, stop_states, 2, output); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a680aa1d_21fba8ce PS3, Line 101: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0cc20b54_30e7aa8c PS3, Line 102: for (int i = 0; i < BURST_SIZE; i++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48e8a92f_245bf457 PS3, Line 103: output_binary[i] = output[i] * -127; // pre flip bits! trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b68f4cd1_9d678d04 PS3, Line 104: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c5b866d_578b7a00 PS3, Line 105: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c94939af_81a2ae54 PS3, Line 106: void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/258757e1_beb520d7 PS3, Line 107: gmsk_mapper(const unsigned char* input, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9da758c_a2f5b0f2 PS3, Line 108: int nitems, gr_complex* gmsk_output, gr_complex start_point) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b951da93_ee6dcb29 PS3, Line 109: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02924b7a_6460f172 PS3, Line 110: gr_complex j = gr_complex(0.0, 1.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/316a00fc_e59dedf0 PS3, Line 111: gmsk_output[0] = start_point; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d04e5046_8eb5fd9a PS3, Line 112: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b7edd6c_b7524c86 PS3, Line 113: int previous_symbol = 2 * input[0] - 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7866719b_4afda48d PS3, Line 114: int current_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f8f28e35_867ec03c PS3, Line 115: int encoded_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8d30b8e_476411e0 PS3, Line 116: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58cf6e49_c8249118 PS3, Line 117: for (int i = 1; i < nitems; i++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f4826b67_178e35e0 PS3, Line 118: /* Change bits representation to NRZ */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7c6b05a7_46a4188c PS3, Line 119: current_symbol = 2 * input[i] - 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0356508_f7ab6a06 PS3, Line 120: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6284a024_18d75e56 PS3, Line 121: /* Differentially encode */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5488b33c_76763be4 PS3, Line 122: encoded_symbol = current_symbol * previous_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6cf8b6b_73fc0e19 PS3, Line 123: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c679df49_0dbfe340 PS3, Line 124: /* And do GMSK mapping */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42e27d12_9f10b515 PS3, Line 125: gmsk_output[i] = j * gr_complex(encoded_symbol, 0.0) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8087f193_a5ea5c45 PS3, Line 126: * gmsk_output[i - 1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e4a3199_60ecbc3c PS3, Line 127: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4495cb8b_66f98d7d PS3, Line 128: previous_symbol = current_symbol; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2880322_e21465de PS3, Line 129: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a4666d7_e69c419d PS3, Line 130: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed3a6865_91785361 PS3, Line 131: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be6e1ccd_4b8fc1ae PS3, Line 132: gr_complex DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d314a110_34e2ab40 PS3, Line 133: correlate_sequence(const gr_complex* sequence, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cadfb978_b6ea0316 PS3, Line 134: int length, const gr_complex* input) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/04569eda_6f728cd8 PS3, Line 135: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c7cc045_fa424cd0 PS3, Line 136: gr_complex result(0.0, 0.0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/291a6d47_b5fb8720 PS3, Line 137: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/04e0467e_d71c4db4 PS3, Line 138: for (int ii = 0; ii < length; ii++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86357947_45f09763 PS3, Line 139: result += sequence[ii] * input[ii * d_OSR]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/776b7a9c_87254bcb PS3, Line 140: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e132fb36_59452fec PS3, Line 141: return conj(result) / gr_complex(length, 0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f9e886f_cc11d017 PS3, Line 142: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8efe1e5_2cff968f PS3, Line 143: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a2bca73a_baeddfb0 PS3, Line 144: /* Computes autocorrelation for positive arguments */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/412d966d_ba9fbbcb PS3, Line 145: inline void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4137963_8c35a4d2 PS3, Line 146: autocorrelation(const gr_complex* input, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6eed540_2b0e53b0 PS3, Line 147: gr_complex* out, int nitems) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a97808e3_21625f5f PS3, Line 148: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a632af4_b4555d1e PS3, Line 149: for (int k = nitems - 1; k >= 0; k--) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3607cbb_f7dc24e3 PS3, Line 150: out[k] = gr_complex(0, 0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/87297b01_f9202f22 PS3, Line 151: for (int i = k; i < nitems; i++) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36418966_93720241 PS3, Line 152: out[k] += input[i] * conj(input[i - k]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05062ec4_bc787f4e PS3, Line 153: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9bd824d_ecdb2006 PS3, Line 154: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/179b54b3_553a0967 PS3, Line 155: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5bf5fe8_369dbe44 PS3, Line 156: inline void DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0f8d6b4_c1283246 PS3, Line 157: mafi(const gr_complex* input, int nitems, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb18aaf2_eda99be9 PS3, Line 158: gr_complex* filter, int filter_length, gr_complex* output) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e7c3ebf_42cf8f03 PS3, Line 159: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06e4ee60_8f4ed07f PS3, Line 160: for (int n = 0; n < nitems; n++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/07ac1992_c2386fe0 PS3, Line 161: int a = n * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2ee4e948_d3a7af31 PS3, Line 162: output[n] = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1bc48e2a_3f5d29de PS3, Line 163: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b87322de_b09a51f6 PS3, Line 164: for (int ii = 0; ii < filter_length; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e169f853_f88a0017 PS3, Line 165: if ((a + ii) >= nitems * d_OSR) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bacb5641_70034bcc PS3, Line 166: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2a94356_36e25b0b PS3, Line 167: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8718ad5c_64eff812 PS3, Line 168: output[n] += input[a + ii] * filter[ii]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a07eb828_10f9c9a1 PS3, Line 169: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfa900de_20d98cc5 PS3, Line 170: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6f8e22ac_38e075e0 PS3, Line 171: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b735d7b7_af1434ed PS3, Line 172: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/62785317_024126a4 PS3, Line 173: int get_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, int search_center, int search_start_pos, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aabcef55_e0048a07 PS3, Line 174: int search_stop_pos, gr_complex *tseq, int tseqlen, float *corr_max) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c98ee05_faab9468 PS3, Line 175: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea4925f5_8e0d1152 PS3, Line 176: std::vector<gr_complex> correlation_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d61be857_38fd5a8c PS3, Line 177: std::vector<float> window_energy_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8c4c14cb_c0b659d9 PS3, Line 178: std::vector<float> power_buffer; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/01673ee3_162b4db2 PS3, Line 179: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fbc46ed5_271ce47d PS3, Line 180: for (int ii = search_start_pos; ii < search_stop_pos; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a28ce6c1_c8513734 PS3, Line 181: gr_complex correlation = correlate_sequence(tseq, tseqlen, &input[ii]); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2c8c691_bfb53e14 PS3, Line 182: correlation_buffer.push_back(correlation); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11838de1_86710aae PS3, Line 183: power_buffer.push_back(std::pow(abs(correlation), 2)); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4af365d8_a24ceab2 PS3, Line 184: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58407c51_5cc59e03 PS3, Line 185: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/139beb9f_2a134377 PS3, Line 186: int strongest_corr_nr = max_element(power_buffer.begin(), power_buffer.end()) - power_buffer.begin(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/987b31fe_303a13da PS3, Line 187: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77920c44_0d24c32d PS3, Line 188: /* Compute window energies */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ed4fe791_c4cd5048 PS3, Line 189: auto window_energy_start_offset = strongest_corr_nr - 6 * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6978d9a1_d3989f09 PS3, Line 190: window_energy_start_offset = window_energy_start_offset < 0 ? 0 : window_energy_start_offset; //can end up out of range.. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3926262_4505623f PS3, Line 191: auto window_energy_end_offset = strongest_corr_nr + 6 * d_OSR + d_chan_imp_length * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29bec182_0427b9a5 PS3, Line 192: auto iter = power_buffer.begin() + window_energy_start_offset; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c3c83986_15e4b8f9 PS3, Line 193: auto iter_end = power_buffer.begin() + window_energy_end_offset; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7bcc6671_c6c09a3f PS3, Line 194: while (iter != iter_end) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67c07758_9a673c2e PS3, Line 195: std::vector<float>::iterator iter_ii = iter; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1f74e514_1763198d PS3, Line 196: bool loop_end = false; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f539abbc_1b948cc3 PS3, Line 197: float energy = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7194d7f0_0747ab41 PS3, Line 198: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d31526d5_c8598c2e PS3, Line 199: int len = d_chan_imp_length * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bf3812b2_3ca419e9 PS3, Line 200: for (int ii = 0; ii < len; ii++, iter_ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/656192db_104f64db PS3, Line 201: if (iter_ii == power_buffer.end()) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9294aff_9d6c216a PS3, Line 202: loop_end = true; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b74c74e_932aef98 PS3, Line 203: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1ef2d8d7_111e7679 PS3, Line 204: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3dba79d9_bbaf0b14 PS3, Line 205: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3faffd1a_b4ef7473 PS3, Line 206: energy += (*iter_ii); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e75fc08c_8a395426 PS3, Line 207: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad08311d_7997ba73 PS3, Line 208: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/80086df1_ede17c55 PS3, Line 209: if (loop_end) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4cc3eca_d479e1a4 PS3, Line 210: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3e3d76e_b72eb044 PS3, Line 211: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a7d3c923_ae466abf PS3, Line 212: window_energy_buffer.push_back(energy); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c00720e4_f974581b PS3, Line 213: iter++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56cd56f0_d0a7b032 PS3, Line 214: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36b5e352_ed9260e9 PS3, Line 215: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9e32b9cd_d04a04d9 PS3, Line 216: /* Calculate the strongest window number */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e887605d_58780e69 PS3, Line 217: int strongest_window_nr = window_energy_start_offset + DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e4f8021_82366426 PS3, Line 218: max_element(window_energy_buffer.begin(), window_energy_buffer.end()) - DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9a3232f8_aa7019da PS3, Line 219: window_energy_buffer.begin(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/702f5ad5_12e61e40 PS3, Line 220: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8feb580b_ab19a08d PS3, Line 221: // auto window_search_start = window_energy_buffer.begin() + strongest_corr_nr - 5* d_OSR; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d8959b8_641e10c6 PS3, Line 222: // auto window_search_end = window_energy_buffer.begin() + strongest_corr_nr + 10* d_OSR; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63d4962d_184f8856 PS3, Line 223: // window_search_end = window_search_end >= window_energy_buffer.end() ? window_energy_buffer.end() : window_search_end; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e926262_0e00d3d7 PS3, Line 224: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e9dcab6_d843624b PS3, Line 225: // /* Calculate the strongest window number */ trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f66127a_a278a580 PS3, Line 226: // int strongest_window_nr = max_element(window_search_start, window_search_end /* - d_chan_imp_length * d_OSR*/) - window_energy_buffer.begin(); trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be89a9a9_56f2da6f PS3, Line 227: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc4d309b_ebca819a PS3, Line 228: // if (strongest_window_nr < 0) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1e8b734_6407d6ac PS3, Line 229: // strongest_window_nr = 0; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f94067af_6f219d8a PS3, Line 230: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/73ddc210_dacf2ea6 PS3, Line 231: float max_correlation = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6afd982d_8ce950e5 PS3, Line 232: for (int ii = 0; ii < d_chan_imp_length * d_OSR; ii++) { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/79e3b586_cc753846 PS3, Line 233: gr_complex correlation = correlation_buffer[strongest_window_nr + ii]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5abf4aa4_923e6269 PS3, Line 234: if (abs(correlation) > max_correlation) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a639adb9_1ec7ee99 PS3, Line 235: max_correlation = abs(correlation); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2eb2bee_2ca7a57c PS3, Line 236: chan_imp_resp[ii] = correlation; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ed4df72_9e7b384d PS3, Line 237: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7aab926f_c56556cc PS3, Line 238: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05d48376_a4763e14 PS3, Line 239: *corr_max = max_correlation; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/569bb0cc_33f5ded0 PS3, Line 240: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26304c4c_3ad3b512 PS3, Line 241: /** trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/613ff9ce_5dda7612 PS3, Line 242: * Compute first sample position, which corresponds trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5ed37848_891ce43c PS3, Line 243: * to the first sample of the impulse response trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d63a199_e7706dfc PS3, Line 244: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8838e92e_71345970 PS3, Line 245: return search_start_pos + strongest_window_nr - search_center * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d5ab922_48e130dd PS3, Line 246: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c8908dab_30f4e979 PS3, Line 247: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db34c72b_716fdedd PS3, Line 248: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/678a10b8_adef5db4 PS3, Line 249: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d9c18853_2dec3790 PS3, Line 250: 3 + 57 + 1 + 26 + 1 + 57 + 3 + 8.25 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b44234ad_b45cf2ce PS3, Line 251: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/948591d8_3ffd5287 PS3, Line 252: search center = 3 + 57 + 1 + 5 (due to tsc 5+16+5 split) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/712dbb11_241929ce PS3, Line 253: this is +-5 samples around (+5 beginning) of truncated t16 tsc trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/19b1b195_57aa07fd PS3, Line 254: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e6d0061_19ce60e7 PS3, Line 255: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5f8347dc_3114db9f PS3, Line 256: int get_norm_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, float *corr_max, int bcc) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1150f59b_9957ec3e PS3, Line 257: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/44a4ddd3_26dfd6eb PS3, Line 258: const int search_center = TRAIN_POS; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1c002f7_0a9e65b8 PS3, Line 259: const int search_start_pos = (search_center - 5) * d_OSR + 1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/243a9b54_72c563cf PS3, Line 260: const int search_stop_pos = (search_center + 5 + d_chan_imp_length) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c83cce28_f52a4855 PS3, Line 261: const auto tseq = &d_norm_training_seq[bcc][TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b842e069_ceafeed4 PS3, Line 262: const auto tseqlen = N_TRAIN_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/541b4817_0a100332 PS3, Line 263: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1761030d_92bbd40f PS3, Line 264: corr_max); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4353aebf_bcbeeba5 PS3, Line 265: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d70da8dd_9d4584ac PS3, Line 266: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c761c50d_0edf193d PS3, Line 267: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2954d3e6_b83d0192 PS3, Line 268: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1e5e35f_7ef03056 PS3, Line 269: 3 tail | 39 data | 64 tsc | 39 data | 3 tail | 8.25 guard trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58cade17_b375aab7 PS3, Line 270: start 3+39 - 10 trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/22e4a03a_217943d1 PS3, Line 271: end 3+39 + SYNC_SEARCH_RANGE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/571973fb_f8dd5017 PS3, Line 272: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10a1214e_b54673bc PS3, Line 273: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4f2ec18c_f4f959ee PS3, Line 274: int get_sch_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1157edd_d2105a93 PS3, Line 275: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/777dd4c9_49b64b76 PS3, Line 276: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1adffc8c_36b62a65 PS3, Line 277: const int search_start_pos = (search_center - 10) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f92c1abe_b1215735 PS3, Line 278: const int search_stop_pos = (search_center + SYNC_SEARCH_RANGE) * d_OSR; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d31a53cd_96fcdd50 PS3, Line 279: const auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d8055f55_9d2e16e5 PS3, Line 280: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e6b3417_2358b11d PS3, Line 281: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd1618a5_f293c064 PS3, Line 282: // strongest_window_nr + chan_imp_resp_center + SYNC_POS *d_OSR - 48 * d_OSR - 2 * d_OSR + 2 ; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c523089_ef3ca283 PS3, Line 283: float corr_max; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfcd011a_be9fbea6 PS3, Line 284: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e670e2a_85baf035 PS3, Line 285: &corr_max); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1082a329_fa1bd43a PS3, Line 286: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c42f89f0_297526cf PS3, Line 287: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e346df4_680f122f PS3, Line 288: int get_sch_buffer_chan_imp_resp(const gr_complex *input, gr_complex *chan_imp_resp, unsigned int len, float *corr_max) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a267f79f_2751d1c8 PS3, Line 289: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42865dde_0e46db93 PS3, Line 290: const auto tseqlen = N_SYNC_BITS - (2 * TRAIN_BEGINNING); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82929ba6_dbddde7d PS3, Line 291: const int search_center = SYNC_POS + TRAIN_BEGINNING; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ce4503b_220358f0 PS3, Line 292: const int search_start_pos = 0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/09487e5d_f02e5b6a PS3, Line 293: // FIXME: proper end offset trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/074ccd4f_3c69c651 PS3, Line 294: const int search_stop_pos = len - (N_SYNC_BITS*8); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aa0b6e67_27190090 PS3, Line 295: auto tseq = &d_sch_training_seq[TRAIN_BEGINNING]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ee62b152_b4729ee1 PS3, Line 296: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a3a83f5d_89fc53d0 PS3, Line 297: return get_chan_imp_resp(input, chan_imp_resp, search_center, search_start_pos, search_stop_pos, tseq, tseqlen, DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d47da7d_12bc7343 PS3, Line 298: corr_max); DOS line endings File Transceiver52M/grgsm_vitac/viterbi_detector.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cc8da0ff_e158d322 PS3, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f812dbe_c433387e PS3, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5045e15_1721b4f3 PS3, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98756fa6_a08abbe0 PS3, Line 4: * @author (C) 2009 Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bc441fdc_c7d63745 PS3, Line 5: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d1fe0bf_c1b26aa2 PS3, Line 6: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/94b5aa48_761911d7 PS3, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9324256e_45eee077 PS3, Line 8: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9fb503a2_ef3b5aec PS3, Line 9: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b5289177_f06055e3 PS3, Line 10: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1580e15d_a5a7ad66 PS3, Line 11: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/02b180fb_858f601d PS3, Line 12: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c00ae49e_0205cd74 PS3, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4c326670_fdcc2cfa PS3, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4a46afb_99ad0461 PS3, Line 15: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/44eeaea7_843721f4 PS3, Line 16: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9a6f5de5_5d4d752b PS3, Line 17: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8fed45f8_7e7de5b3 PS3, Line 18: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e216e15d_fa206574 PS3, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ee7fe7cc_221bb9f2 PS3, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7fce3c34_3d737953 PS3, Line 20: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84429be6_3dd34bc5 PS3, Line 21: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/940fae45_3c113297 PS3, Line 22: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b89f694a_a8d2c4f7 PS3, Line 23: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/afcb541e_74ff6e6e PS3, Line 24: * viterbi_detector: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1dd0a502_4f41fed3 PS3, Line 25: * This part does the detection of received sequnece. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3caf30f_bfeff46a PS3, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/338da7e7_f216c5c3 PS3, Line 27: * At this moment it gives hard decisions on the output, but trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e45728a_6cbe202d PS3, Line 28: * it was designed with soft decisions in mind. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9e40bc52_06378a71 PS3, Line 29: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6ace9104_b7d7b170 PS3, Line 30: * SYNTAX: void viterbi_detector( trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/946e3118_fb868967 PS3, Line 31: * const gr_complex * input, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/59630dad_1d95988d PS3, Line 32: * unsigned int samples_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/864ec411_8f57f5f7 PS3, Line 33: * gr_complex * rhh, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85277b70_b7079908 PS3, Line 34: * unsigned int start_state, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af53e95a_52ec3a7e PS3, Line 35: * const unsigned int * stop_states, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f1ff4cc_0ca900cb PS3, Line 36: * unsigned int stops_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c6451425_08d1c3cf PS3, Line 37: * float * output) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e826261_ecc126a8 PS3, Line 38: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8decb550_1e67f09f PS3, Line 39: * INPUT: input: Complex received signal afted matched filtering. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b502e093_44c8999a PS3, Line 40: * samples_num: Number of samples in the input table. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2f72aec2_690ad683 PS3, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05e2f1ab_2778719a PS3, Line 42: * impulse response. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89073700_44efb27b PS3, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/051152b1_acd2d622 PS3, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fdea9c6a_7cc6577e PS3, Line 45: * indicates start point of the algorithm. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f1736ecf_fd569340 PS3, Line 46: * stop_states: Table with numbers of possible stop states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5bda0084_f8cd2d0b PS3, Line 47: * stops_num: Number of possible stop states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1c23466_0478bbdf PS3, Line 48: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/613758ce_c939bf33 PS3, Line 49: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57cb0520_f90752f4 PS3, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76c03c94_0c0b97d3 PS3, Line 51: * -1 for logical "0" and 1 for logical "1" trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/918ccd55_167ca878 PS3, Line 52: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a99a8f3b_312f2e9a PS3, Line 53: * SUB_FUNC: none trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ac5d42d3_5e57322c PS3, Line 54: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1b8a4100_58330a4f PS3, Line 55: * TEST(S): Tested with real world normal burst. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e6f68981_35d47235 PS3, Line 56: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/33cb1ebc_25f15241 PS3, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/179bc4ca_2630603d PS3, Line 58: #ifndef INCLUDED_VITERBI_DETECTOR_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d47f17cb_51029c8d PS3, Line 59: #define INCLUDED_VITERBI_DETECTOR_H DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/228181a7_95db02d1 PS3, Line 60: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/020f2da7_20db41ea PS3, Line 61: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aad46c3a_900c3e67 PS3, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e023a8b8_b6f55da4 PS3, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cf2ca289_8ecc09bc PS3, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/675cce90_4fe09478 PS3, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5250d3b6_bf95d573 PS3, Line 62: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output); "foo * bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/85a00e2c_87bee036 PS3, Line 63: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b0d650f2_a0289e4c PS3, Line 64: #endif /* INCLUDED_VITERBI_DETECTOR_H */ DOS line endings File Transceiver52M/grgsm_vitac/viterbi_detector.cc: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5519801b_fc90aae9 PS3, Line 1: /* -*- c++ -*- */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0374f5c4_c8677b8c PS3, Line 2: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fa98f6d_3540e6dc PS3, Line 3: * @file trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10c0454e_c8eea552 PS3, Line 4: * @author (C) 2009 by Piotr Krysik <ptrkrysik(a)gmail.com> trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5c470b80_7204c894 PS3, Line 5: * @section LICENSE trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b44f403a_52f39498 PS3, Line 6: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b8793732_cceed715 PS3, Line 7: * Gr-gsm is free software; you can redistribute it and/or modify trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4cf10099_3f8d9cc3 PS3, Line 8: * it under the terms of the GNU General Public License as published by trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e223ed19_9fc31741 PS3, Line 9: * the Free Software Foundation; either version 3, or (at your option) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47246e84_e3bd4e9f PS3, Line 10: * any later version. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1df0ef87_b2f4c330 PS3, Line 11: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fba651c_b14c8ae6 PS3, Line 12: * Gr-gsm is distributed in the hope that it will be useful, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a066b211_7b936904 PS3, Line 13: * but WITHOUT ANY WARRANTY; without even the implied warranty of trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b62bbf29_c8fe47a6 PS3, Line 14: * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e278a50e_ff7aa688 PS3, Line 15: * GNU General Public License for more details. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb0b0428_a0728443 PS3, Line 16: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f0ebff1d_efdb9d00 PS3, Line 17: * You should have received a copy of the GNU General Public License trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df3f6d30_64d671cb PS3, Line 18: * along with gr-gsm; see the file COPYING. If not, write to trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6bd9af3_daf1a71b PS3, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06cca92a_f437ca69 PS3, Line 19: * the Free Software Foundation, Inc., 51 Franklin Street, Do not include the paragraph about writing to the Free Software Foundation's mailing address from the sample GPL notice. The FSF has changed addresses in the past, and may do so again. This Osmocom project should already include a copy of the (A)GPL. Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c4fae301_b2948890 PS3, Line 20: * Boston, MA 02110-1301, USA. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8fc9da77_3cb694c0 PS3, Line 21: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d7add488_ce52ced5 PS3, Line 22: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/db6a44dc_c8e2c27a PS3, Line 23: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c78922bc_d3c282f5 PS3, Line 24: * viterbi_detector: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a4cbfb95_26e04b45 PS3, Line 25: * This part does the detection of received sequnece. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d9e95941_bf44feb8 PS3, Line 26: * Employed algorithm is viterbi Maximum Likehood Sequence Estimation. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/65402c76_83fc7a65 PS3, Line 27: * At this moment it gives hard decisions on the output, but trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8832cd45_e8359dc9 PS3, Line 28: * it was designed with soft decisions in mind. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/285193c9_374191dd PS3, Line 29: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8880fd19_236023f3 PS3, Line 30: * SYNTAX: void viterbi_detector( trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9733302e_561d46e0 PS3, Line 31: * const gr_complex * input, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a935653a_c692e59b PS3, Line 32: * unsigned int samples_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a22b910f_6793a4f0 PS3, Line 33: * gr_complex * rhh, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aeb3176b_1ce04a55 PS3, Line 34: * unsigned int start_state, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/26206f61_c5456b2c PS3, Line 35: * const unsigned int * stop_states, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ca5b57da_cd561b9c PS3, Line 36: * unsigned int stops_num, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e66b81ce_7e3feba3 PS3, Line 37: * float * output) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2b276616_84b1b9ba PS3, Line 38: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1365c23_32d23f02 PS3, Line 39: * INPUT: input: Complex received signal afted matched filtering. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c5f56e9f_aaaf1f4a PS3, Line 40: * samples_num: Number of samples in the input table. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/922a9b11_f4bdbe08 PS3, Line 41: * rhh: The autocorrelation of the estimated channel trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfc7fbe8_a237efce PS3, Line 42: * impulse response. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/292220e7_174b0122 PS3, Line 43: * start_state: Number of the start point. In GSM each burst trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ace4cabb_b2a39fcb PS3, Line 44: * starts with sequence of three bits (0,0,0) which trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c79eb07a_82ac54db PS3, Line 45: * indicates start point of the algorithm. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c5deedf8_fc104e05 PS3, Line 46: * stop_states: Table with numbers of possible stop states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f1d19cc_8df529ea PS3, Line 47: * stops_num: Number of possible stop states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/61246a3a_3b8fa48e PS3, Line 48: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebaecc0a_51c7577d PS3, Line 49: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/090c99e3_7734c513 PS3, Line 50: * OUTPUT: output: Differentially decoded hard output of the algorithm: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/569c5c4f_294fc7a3 PS3, Line 51: * -1 for logical "0" and 1 for logical "1" trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/020d5a50_ddcd27f7 PS3, Line 52: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e289577f_9a488393 PS3, Line 53: * SUB_FUNC: none trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/63a9e082_fcd1331e PS3, Line 54: * trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/73ea51e9_75d09049 PS3, Line 55: * TEST(S): Tested with real world normal burst. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88b4f930_c928dd23 PS3, Line 56: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d284132c_c27c1ca6 PS3, Line 57: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/717b7807_4cde8172 PS3, Line 58: #include "constants.h" DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1948671d_f2288c0e PS3, Line 59: #include <cmath> DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3e07a87b_1c440f90 PS3, Line 60: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/473ecdd0_8dfbbf78 PS3, Line 61: #define PATHS_NUM (1 << (CHAN_IMP_RESP_LENGTH-1)) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e795da7e_6218308b PS3, Line 62: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0dd495f6_9e87a317 PS3, Line 63: void viterbi_detector(const gr_complex * input, unsigned int samples_num, gr_complex * rhh, unsigned int start_state, const unsigned int * stop_states, unsigned int stops_num, float * output) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0d8f8bd3_21906824 PS3, Line 64: { DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/021b725d_d27e2ceb PS3, Line 65: float increment[8]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df28a8b7_4418cb8c PS3, Line 66: float path_metrics1[16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/334a7e45_8274d286 PS3, Line 67: float path_metrics2[16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57db5fe7_fd19cdc9 PS3, Line 68: float paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/52708eff_4bbe5d5c PS3, Line 69: float * new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab003cd5_6c05dc6e PS3, Line 70: float * old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a131131d_07bad66c PS3, Line 71: float * tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d45cbb4b_8e4a11f2 PS3, Line 72: float trans_table[BURST_SIZE][16]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f7787b89_970d7886 PS3, Line 73: float pm_candidate1, pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/40f63276_19cd134b PS3, Line 74: bool real_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b951f8b_0a46f509 PS3, Line 75: float input_symbol_real, input_symbol_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/559eae32_12de3303 PS3, Line 76: unsigned int i, sample_nr; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ef3fc283_77c77bbc PS3, Line 77: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f670444_2638a5ac PS3, Line 78: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bd89c345_ddcbcf9b PS3, Line 79: * Setup first path metrics, so only state pointed by start_state is possible. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a21ca0f5_b10f0e4d PS3, Line 80: * Start_state metric is equal to zero, the rest is written with some very low value, trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3c766aef_50ad2e28 PS3, Line 81: * which makes them practically impossible to occur. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/27b178cf_f034064c PS3, Line 82: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d67988a3_816b0d81 PS3, Line 83: for(i=0; i<PATHS_NUM; i++){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/88770f2e_c50464df PS3, Line 84: path_metrics1[i]=(-10e30); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83143d2f_35adcf06 PS3, Line 85: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3be4474e_adc46096 PS3, Line 86: path_metrics1[start_state]=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d815074b_22230e9d PS3, Line 87: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b48d78b_a2a54036 PS3, Line 88: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/08c7561d_fcd2c67f PS3, Line 89: * Compute Increment - a table of values which does not change for subsequent input samples. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e5039a45_051aeb67 PS3, Line 90: * Increment is table of reference levels for computation of branch metrics: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f956452c_513a3d3d PS3, Line 91: * branch metric = (+/-)received_sample (+/-) reference_level trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3d4b4f7a_76a4dc1e PS3, Line 92: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2081b6d3_4cdaae4d PS3, Line 93: increment[0] = -rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/32c829ab_63293eac PS3, Line 94: increment[1] = rhh[1].imag() -rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d7e24c0_4313dc6e PS3, Line 95: increment[2] = -rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6970bd72_1879a4a9 PS3, Line 96: increment[3] = rhh[1].imag() +rhh[2].real() -rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2de3a7e4_6f568bbb PS3, Line 97: increment[4] = -rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aa5dc91f_01d4bebb PS3, Line 98: increment[5] = rhh[1].imag() -rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8dd16d74_316b6a0c PS3, Line 99: increment[6] = -rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ee42da4d_0ce0bba9 PS3, Line 100: increment[7] = rhh[1].imag() +rhh[2].real() +rhh[3].imag() +rhh[4].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9dd0c60d_c15abcfb PS3, Line 101: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e7befe55_2ef054e6 PS3, Line 102: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2820d05_609b0bc8 PS3, Line 103: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/100652d1_5d9c3acc PS3, Line 104: * Computation of path metrics and decisions (Add-Compare-Select). trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c8ff6a1_d5ede6c1 PS3, Line 105: * It's composed of two parts: one for odd input samples (imaginary numbers) trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92a0ec0c_b5124455 PS3, Line 106: * and one for even samples (real numbers). trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fe158316_4b4778f4 PS3, Line 107: * Each part is composed of independent (parallelisable) statements like trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5631502f_93243065 PS3, Line 108: * this one: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4417243_28402bd1 PS3, Line 109: * pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/34df8390_2e8c48a1 PS3, Line 110: * pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dfe1b422_00293b8a PS3, Line 111: * paths_difference=pm_candidate2-pm_candidate1; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49ddfe43_a7d4c662 PS3, Line 112: * new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/637c1962_72a160f6 PS3, Line 113: * trans_table[sample_nr][1] = paths_difference; trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/314a118c_72f6a1ba PS3, Line 114: * This is very good point for optimisations (SIMD or OpenMP) as it's most time trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/377083ba_202c166c PS3, Line 115: * consuming part of this function. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/78f339a2_fc4bcdc1 PS3, Line 116: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e93a244_2909aae4 PS3, Line 117: sample_nr=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bfd54c39_74a309ae PS3, Line 118: old_path_metrics=path_metrics1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f499df2a_7b3580f4 PS3, Line 119: new_path_metrics=path_metrics2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1e97a6ad_310c746b PS3, Line 120: while(sample_nr<samples_num){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7aec79e7_68434c1d PS3, Line 121: //Processing imag states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/58a02862_8876c5af PS3, Line 122: real_imag=1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3128725e_bba59ca0 PS3, Line 123: input_symbol_imag = input[sample_nr].imag(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ad294e75_5b18e034 PS3, Line 124: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/074fe65b_59b37077 PS3, Line 125: pm_candidate1 = old_path_metrics[0] +input_symbol_imag -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89ee4732_aaa0a52c PS3, Line 126: pm_candidate2 = old_path_metrics[8] +input_symbol_imag +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a36092e_7f5d8c6a PS3, Line 127: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a408c0e_513740f1 PS3, Line 128: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d48372e_3fca99fc PS3, Line 129: trans_table[sample_nr][0] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a829d863_ead64606 PS3, Line 130: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ff5efe9_605d4a59 PS3, Line 131: pm_candidate1 = old_path_metrics[0] -input_symbol_imag +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9eb1f0ad_4807b943 PS3, Line 132: pm_candidate2 = old_path_metrics[8] -input_symbol_imag -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5008d9d2_2f3496e0 PS3, Line 133: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89901515_e9c850ce PS3, Line 134: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e1ed129_c5eeb476 PS3, Line 135: trans_table[sample_nr][1] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e07ad6f4_66afc0c5 PS3, Line 136: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/69ee0fb4_b52dcac6 PS3, Line 137: pm_candidate1 = old_path_metrics[1] +input_symbol_imag -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b3641c11_1df3d737 PS3, Line 138: pm_candidate2 = old_path_metrics[9] +input_symbol_imag +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7f760ef1_c71b83be PS3, Line 139: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e9cf77b_aca38dbd PS3, Line 140: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/537aaf46_49be7597 PS3, Line 141: trans_table[sample_nr][2] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e54463c_6de58e8e PS3, Line 142: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/66544700_a07fb92a PS3, Line 143: pm_candidate1 = old_path_metrics[1] -input_symbol_imag +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6eebbcad_468ff4ff PS3, Line 144: pm_candidate2 = old_path_metrics[9] -input_symbol_imag -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb81844a_21cb451a PS3, Line 145: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f27d5e48_4eb26d8d PS3, Line 146: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/025e3b33_b27e0c9c PS3, Line 147: trans_table[sample_nr][3] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0bd93b73_ca43cb07 PS3, Line 148: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/437c7b1e_411933f5 PS3, Line 149: pm_candidate1 = old_path_metrics[2] +input_symbol_imag -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/70338322_7998ade6 PS3, Line 150: pm_candidate2 = old_path_metrics[10] +input_symbol_imag +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a2ff584_cbcb2287 PS3, Line 151: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0500bcb8_7773d36f PS3, Line 152: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/83bef26b_d2765850 PS3, Line 153: trans_table[sample_nr][4] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9407ce98_197909eb PS3, Line 154: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/37af9ff2_b738d964 PS3, Line 155: pm_candidate1 = old_path_metrics[2] -input_symbol_imag +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d259639_3344dba7 PS3, Line 156: pm_candidate2 = old_path_metrics[10] -input_symbol_imag -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bb99104e_e969b0ed PS3, Line 157: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/17221f7a_c9948850 PS3, Line 158: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b1292e5c_e0a420d3 PS3, Line 159: trans_table[sample_nr][5] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2438db48_e45d228f PS3, Line 160: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0570da52_54c11a28 PS3, Line 161: pm_candidate1 = old_path_metrics[3] +input_symbol_imag -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/98718a08_d81a826b PS3, Line 162: pm_candidate2 = old_path_metrics[11] +input_symbol_imag +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/07ea9ccf_42b89e2f PS3, Line 163: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/578ae128_b4b704ee PS3, Line 164: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9ab78a9_f1ea833d PS3, Line 165: trans_table[sample_nr][6] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1561e532_edbad5a3 PS3, Line 166: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b1c47445_92c38472 PS3, Line 167: pm_candidate1 = old_path_metrics[3] -input_symbol_imag +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/845e7420_810dac2a PS3, Line 168: pm_candidate2 = old_path_metrics[11] -input_symbol_imag -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/05579af2_d3233ac0 PS3, Line 169: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3ae49b89_a231ae9c PS3, Line 170: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4bfc1922_d5e1ca6e PS3, Line 171: trans_table[sample_nr][7] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/82f68201_0a7cd86e PS3, Line 172: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/602da7bc_bf97d9e3 PS3, Line 173: pm_candidate1 = old_path_metrics[4] +input_symbol_imag -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f465f29_8ba1fbbb PS3, Line 174: pm_candidate2 = old_path_metrics[12] +input_symbol_imag +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d7fe6de8_f5767886 PS3, Line 175: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af497b7f_e3cb89d7 PS3, Line 176: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b22b8cda_cda1ec05 PS3, Line 177: trans_table[sample_nr][8] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f6c04282_115ad075 PS3, Line 178: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7a7ab9ae_5f40be57 PS3, Line 179: pm_candidate1 = old_path_metrics[4] -input_symbol_imag +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a6ae049d_a7e2fab7 PS3, Line 180: pm_candidate2 = old_path_metrics[12] -input_symbol_imag -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e8a57fca_5093f863 PS3, Line 181: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47367dc3_62663ca5 PS3, Line 182: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a258c05b_fae61c48 PS3, Line 183: trans_table[sample_nr][9] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8f769bbc_f0befbb0 PS3, Line 184: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13ba34cc_1a96839d PS3, Line 185: pm_candidate1 = old_path_metrics[5] +input_symbol_imag -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/783c80d8_ef279309 PS3, Line 186: pm_candidate2 = old_path_metrics[13] +input_symbol_imag +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/946b90a9_f0055199 PS3, Line 187: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/936a4bab_4359613e PS3, Line 188: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b46dc9b1_efd3faf6 PS3, Line 189: trans_table[sample_nr][10] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7b4ea0b9_9710339d PS3, Line 190: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/57c9c0a4_c4178a68 PS3, Line 191: pm_candidate1 = old_path_metrics[5] -input_symbol_imag +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/47c1234d_4a1fb0b4 PS3, Line 192: pm_candidate2 = old_path_metrics[13] -input_symbol_imag -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a900798e_04593f83 PS3, Line 193: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7fe30e45_f97b9cfd PS3, Line 194: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e3198c3_58311a96 PS3, Line 195: trans_table[sample_nr][11] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54b56258_a7a88ae0 PS3, Line 196: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a13d23e1_7d0a9565 PS3, Line 197: pm_candidate1 = old_path_metrics[6] +input_symbol_imag -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3b6eeec5_c9f839a3 PS3, Line 198: pm_candidate2 = old_path_metrics[14] +input_symbol_imag +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be3c65bc_590ff535 PS3, Line 199: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e90a7e1c_d1143ece PS3, Line 200: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6aae9cfc_9a60018b PS3, Line 201: trans_table[sample_nr][12] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/97941eeb_10bc2d2c PS3, Line 202: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fdcc6926_a03b44ce PS3, Line 203: pm_candidate1 = old_path_metrics[6] -input_symbol_imag +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e25ab601_da268bdd PS3, Line 204: pm_candidate2 = old_path_metrics[14] -input_symbol_imag -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d3db4607_1f1c8015 PS3, Line 205: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/95017a7b_a0c6cd3f PS3, Line 206: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13bf05ab_1cdf1845 PS3, Line 207: trans_table[sample_nr][13] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f97237ee_2a9f92ec PS3, Line 208: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5a4c6fb_7a372741 PS3, Line 209: pm_candidate1 = old_path_metrics[7] +input_symbol_imag -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8de2fe0e_f47aff1a PS3, Line 210: pm_candidate2 = old_path_metrics[15] +input_symbol_imag +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/21375008_cc8d538d PS3, Line 211: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42b723f1_debe906e PS3, Line 212: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/013b59fc_692e1586 PS3, Line 213: trans_table[sample_nr][14] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ae859249_f55cc564 PS3, Line 214: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d1666610_b9254338 PS3, Line 215: pm_candidate1 = old_path_metrics[7] -input_symbol_imag +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/38113f11_7d69a61a PS3, Line 216: pm_candidate2 = old_path_metrics[15] -input_symbol_imag -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c1c1269a_08024fd0 PS3, Line 217: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a1c2603b_9db3ba53 PS3, Line 218: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0d642db3_0b2fa2b3 PS3, Line 219: trans_table[sample_nr][15] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/48a28aaa_f9b1f294 PS3, Line 220: tmp=old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/336550c9_574e57ee PS3, Line 221: old_path_metrics=new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0c50b6fa_9398f137 PS3, Line 222: new_path_metrics=tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/76c5c77c_f4991c27 PS3, Line 223: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/77b57c56_35ce06f2 PS3, Line 224: sample_nr++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f59dba88_887e58e8 PS3, Line 225: if(sample_nr==samples_num) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53aed782_f5efdffb PS3, Line 226: break; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0663ac0b_4d90b4ad PS3, Line 227: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c906a44_830a7460 PS3, Line 228: //Processing real states trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/732dc9d5_2f4e3ed7 PS3, Line 229: real_imag=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d36e66e0_7f763999 PS3, Line 230: input_symbol_real = input[sample_nr].real(); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/86b086d1_3986d4a2 PS3, Line 231: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/eb368c56_9fdc0705 PS3, Line 232: pm_candidate1 = old_path_metrics[0] -input_symbol_real -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/baf05db3_23504aca PS3, Line 233: pm_candidate2 = old_path_metrics[8] -input_symbol_real +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fc1ddb56_8f6eba5c PS3, Line 234: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/51cf072d_b3a6a235 PS3, Line 235: new_path_metrics[0]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e577bef3_a148053a PS3, Line 236: trans_table[sample_nr][0] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4635384_3404f5fb PS3, Line 237: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/36a3008d_bc5cbc4a PS3, Line 238: pm_candidate1 = old_path_metrics[0] +input_symbol_real +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/549e11c1_6788ecda PS3, Line 239: pm_candidate2 = old_path_metrics[8] +input_symbol_real -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6d0d94fc_b5e5f926 PS3, Line 240: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10b29c92_6da8448e PS3, Line 241: new_path_metrics[1]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ce6799e3_57fa261f PS3, Line 242: trans_table[sample_nr][1] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ece16d79_7d82e8b1 PS3, Line 243: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/49ee34d1_edf100e9 PS3, Line 244: pm_candidate1 = old_path_metrics[1] -input_symbol_real -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/07daf5af_8fac2e0e PS3, Line 245: pm_candidate2 = old_path_metrics[9] -input_symbol_real +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/67824a8c_7f279cbf PS3, Line 246: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a0c5676e_c9c24fb7 PS3, Line 247: new_path_metrics[2]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6a648afa_36801fbf PS3, Line 248: trans_table[sample_nr][2] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/373948e8_ce3ed160 PS3, Line 249: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa825e60_d6c0a83d PS3, Line 250: pm_candidate1 = old_path_metrics[1] +input_symbol_real +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/60ba6804_ddfed697 PS3, Line 251: pm_candidate2 = old_path_metrics[9] +input_symbol_real -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6bd351f1_b0b676dc PS3, Line 252: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8d7c412b_988dc9a3 PS3, Line 253: new_path_metrics[3]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5d7c4a7f_b495b96f PS3, Line 254: trans_table[sample_nr][3] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7eea70cc_131e20e7 PS3, Line 255: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8fbad9d0_c86b9fbc PS3, Line 256: pm_candidate1 = old_path_metrics[2] -input_symbol_real -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/120ba21e_5fa58231 PS3, Line 257: pm_candidate2 = old_path_metrics[10] -input_symbol_real +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/92e32d82_4317a3d9 PS3, Line 258: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/3f4659e9_a8220020 PS3, Line 259: new_path_metrics[4]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f159f9b7_7480d105 PS3, Line 260: trans_table[sample_nr][4] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9b188ed_cf4d25ec PS3, Line 261: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/53041bdc_943191d5 PS3, Line 262: pm_candidate1 = old_path_metrics[2] +input_symbol_real +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/632ae331_ee140193 PS3, Line 263: pm_candidate2 = old_path_metrics[10] +input_symbol_real -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ebf39766_62a368ba PS3, Line 264: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b59ea5ad_64a0f64b PS3, Line 265: new_path_metrics[5]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a35bc6e_8128a11c PS3, Line 266: trans_table[sample_nr][5] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ea8b9109_32040f19 PS3, Line 267: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fbd43fb4_0082f8fa PS3, Line 268: pm_candidate1 = old_path_metrics[3] -input_symbol_real -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e0ebf34b_4ce184db PS3, Line 269: pm_candidate2 = old_path_metrics[11] -input_symbol_real +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/729ce444_7afe1b32 PS3, Line 270: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e18bbe42_eb501fd8 PS3, Line 271: new_path_metrics[6]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/13f62ba5_e4543f8c PS3, Line 272: trans_table[sample_nr][6] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f9644353_27b222ae PS3, Line 273: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e1bca687_6931c202 PS3, Line 274: pm_candidate1 = old_path_metrics[3] +input_symbol_real +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/18c0860a_06d40400 PS3, Line 275: pm_candidate2 = old_path_metrics[11] +input_symbol_real -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8743d354_90843fab PS3, Line 276: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a9216c4d_29b38a22 PS3, Line 277: new_path_metrics[7]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/557f3250_4088736a PS3, Line 278: trans_table[sample_nr][7] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c614481f_41c62849 PS3, Line 279: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b4665523_5590cd37 PS3, Line 280: pm_candidate1 = old_path_metrics[4] -input_symbol_real -increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/56b1f4ab_4db8d722 PS3, Line 281: pm_candidate2 = old_path_metrics[12] -input_symbol_real +increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/603c7741_7358cd7c PS3, Line 282: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5534e58b_a7df7347 PS3, Line 283: new_path_metrics[8]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/96691c26_d298451d PS3, Line 284: trans_table[sample_nr][8] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9b599396_171c75ff PS3, Line 285: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/fa757329_16aec5fc PS3, Line 286: pm_candidate1 = old_path_metrics[4] +input_symbol_real +increment[3]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b7e2adb8_1ffe1854 PS3, Line 287: pm_candidate2 = old_path_metrics[12] +input_symbol_real -increment[4]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/af79d5d4_fb2ba33b PS3, Line 288: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cb7eb0ed_ed483293 PS3, Line 289: new_path_metrics[9]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/84a48369_0d0afdea PS3, Line 290: trans_table[sample_nr][9] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/31a2aab8_a078a1fb PS3, Line 291: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/14906a8f_29f49fea PS3, Line 292: pm_candidate1 = old_path_metrics[5] -input_symbol_real -increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0a149568_c03f0552 PS3, Line 293: pm_candidate2 = old_path_metrics[13] -input_symbol_real +increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/11ddc67c_212b54bb PS3, Line 294: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5880a414_edfc3db4 PS3, Line 295: new_path_metrics[10]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b9bb4f5f_f68977c6 PS3, Line 296: trans_table[sample_nr][10] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ac179ff0_9b3f9d05 PS3, Line 297: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/be6e3fdc_ca0f2334 PS3, Line 298: pm_candidate1 = old_path_metrics[5] +input_symbol_real +increment[2]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/50dbea7e_a9336983 PS3, Line 299: pm_candidate2 = old_path_metrics[13] +input_symbol_real -increment[5]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f5081c64_4d70f3c0 PS3, Line 300: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2e801172_7faa1732 PS3, Line 301: new_path_metrics[11]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5fb9e3ff_22fb38eb PS3, Line 302: trans_table[sample_nr][11] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f64ecdf6_32dc1ba1 PS3, Line 303: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab9e6a11_a59628a4 PS3, Line 304: pm_candidate1 = old_path_metrics[6] -input_symbol_real -increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d534b72_419a48f5 PS3, Line 305: pm_candidate2 = old_path_metrics[14] -input_symbol_real +increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7fa34097_d4d5bdc9 PS3, Line 306: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9f6c781b_c6063e3a PS3, Line 307: new_path_metrics[12]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/89235038_d5253fd9 PS3, Line 308: trans_table[sample_nr][12] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/54eeb9a3_1be770f7 PS3, Line 309: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab8e6db6_4bea36d3 PS3, Line 310: pm_candidate1 = old_path_metrics[6] +input_symbol_real +increment[1]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/571b8dc6_2a5505b6 PS3, Line 311: pm_candidate2 = old_path_metrics[14] +input_symbol_real -increment[6]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5bee35ab_06468128 PS3, Line 312: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e41bff4b_d831c519 PS3, Line 313: new_path_metrics[13]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/10337df5_4a5d0af5 PS3, Line 314: trans_table[sample_nr][13] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4e8878af_0d9a6bcd PS3, Line 315: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cadc9c1c_99ab122f PS3, Line 316: pm_candidate1 = old_path_metrics[7] -input_symbol_real -increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/acd045f0_c0878f90 PS3, Line 317: pm_candidate2 = old_path_metrics[15] -input_symbol_real +increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ba9dc47e_cdebd354 PS3, Line 318: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1d105989_2a784156 PS3, Line 319: new_path_metrics[14]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2138f895_2b3df372 PS3, Line 320: trans_table[sample_nr][14] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0f81fd16_9805e31b PS3, Line 321: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8a27ecae_eb282711 PS3, Line 322: pm_candidate1 = old_path_metrics[7] +input_symbol_real +increment[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2c2e0de6_63fd6e43 PS3, Line 323: pm_candidate2 = old_path_metrics[15] +input_symbol_real -increment[7]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ab280d1e_4d3e3449 PS3, Line 324: paths_difference=pm_candidate2-pm_candidate1; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a82f3da6_e2e5ffcc PS3, Line 325: new_path_metrics[15]=(paths_difference<0) ? pm_candidate1 : pm_candidate2; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e6dcd0e_1ae9ba18 PS3, Line 326: trans_table[sample_nr][15] = paths_difference; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c5d8f9cb_437b60e1 PS3, Line 327: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9d5f4329_aff693f0 PS3, Line 328: tmp=old_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0e8f603f_780eccf9 PS3, Line 329: old_path_metrics=new_path_metrics; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/00cc33bb_ab7a0dea PS3, Line 330: new_path_metrics=tmp; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9e48581b_372a665f PS3, Line 331: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/deb31669_9d7d288a PS3, Line 332: sample_nr++; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d236a6f1_8513e8c9 PS3, Line 333: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c71fe23c_49cf8d72 PS3, Line 334: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b56788f7_74f7a20c PS3, Line 335: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b2c9f34c_13721c0e PS3, Line 336: * Find the best from the stop states by comparing their path metrics. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4adf201e_437c17b4 PS3, Line 337: * Not every stop state is always possible, so we are searching in trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/55959ff0_2b0d4878 PS3, Line 338: * a subset of them. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/59251b65_7a950f95 PS3, Line 339: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/42d45cac_3a02d940 PS3, Line 340: unsigned int best_stop_state; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/df58f169_8e537b44 PS3, Line 341: float stop_state_metric, max_stop_state_metric; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/39fa6461_571f0df1 PS3, Line 342: best_stop_state = stop_states[0]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2637384f_b88fa737 PS3, Line 343: max_stop_state_metric = old_path_metrics[best_stop_state]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6e44dc7f_d15ea49c PS3, Line 344: for(i=1; i< stops_num; i++){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/f410b162_ea6bf02a PS3, Line 345: stop_state_metric = old_path_metrics[stop_states[i]]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/9c6b7f82_837fba9a PS3, Line 346: if(stop_state_metric > max_stop_state_metric){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/650f3404_cb697fd9 PS3, Line 347: max_stop_state_metric = stop_state_metric; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2a7e0795_d3eb6d80 PS3, Line 348: best_stop_state = stop_states[i]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4087ba22_28e15eed PS3, Line 349: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/dc3d5db0_06b5fea3 PS3, Line 350: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c9351193_b17e8c81 PS3, Line 351: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/06e00f29_b625a7fa PS3, Line 352: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/c0130938_98d6dadb PS3, Line 353: * This table was generated with hope that it gives a litle speedup during trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a8ce55d5_fc1c1c56 PS3, Line 354: * traceback stage. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2228e9b7_eff70101 PS3, Line 355: * Received bit is related to the number of state in the trellis. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/364a18d5_6ecc68db PS3, Line 356: * I've numbered states so their parity (number of ones) is related trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/43705703_edfb37bd PS3, Line 357: * to a received bit. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4615a822_948a0d50 PS3, Line 358: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5efbdb2a_94633238 PS3, Line 359: static const unsigned int parity_table[PATHS_NUM] = { 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, 0, 1, 1, 0, }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/35ca2287_194cfe9d PS3, Line 360: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5a2a588e_1199dc17 PS3, Line 361: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ed223e2_909cbc97 PS3, Line 362: * Table of previous states in the trellis diagram. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7ffcc0f5_3215365c PS3, Line 363: * For GMSK modulation every state has two previous states. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1b5b2648_c3a433f0 PS3, Line 364: * Example: trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/632b4934_99031061 PS3, Line 365: * previous_state_nr1 = prev_table[current_state_nr][0] trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/5e93efe4_ab565f38 PS3, Line 366: * previous_state_nr2 = prev_table[current_state_nr][1] trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/29d7ab08_19ce5d02 PS3, Line 367: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6fc3d6f3_51dc366a PS3, Line 368: static const unsigned int prev_table[PATHS_NUM][2] = { {0,8}, {0,8}, {1,9}, {1,9}, {2,10}, {2,10}, {3,11}, {3,11}, {4,12}, {4,12}, {5,13}, {5,13}, {6,14}, {6,14}, {7,15}, {7,15}, }; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/7e5480bc_e6335afb PS3, Line 369: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/e197afb8_30cd5442 PS3, Line 370: /* trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/bcc5007b_5ed1410f PS3, Line 371: * Traceback and differential decoding of received sequence. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/a749c456_7e83d250 PS3, Line 372: * Decisions stored in trans_table are used to restore best path in the trellis. trailing whitespace Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/4ce750bc_29197da4 PS3, Line 373: */ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/04c5e092_39d30ba3 PS3, Line 374: sample_nr=samples_num; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8b08de8f_17768a3d PS3, Line 375: unsigned int state_nr=best_stop_state; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/026809d8_c1b5f5d6 PS3, Line 376: unsigned int decision; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b81ce8ee_80da897a PS3, Line 377: bool out_bit=0; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/aaa52a6a_443a7117 PS3, Line 378: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/8af65257_1c40192e PS3, Line 379: while(sample_nr>0){ DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ddbdf480_dbe9a425 PS3, Line 380: sample_nr--; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/b27c3c7f_f0ce26a4 PS3, Line 381: decision = (trans_table[sample_nr][state_nr]>0); DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/453b0364_4567f4b1 PS3, Line 382: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/6f8cb40d_2b2e1fbb PS3, Line 383: if(decision != out_bit) DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/ec903891_f1c01f50 PS3, Line 384: output[sample_nr]=-trans_table[sample_nr][state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/cbe7b60c_7123392b PS3, Line 385: else DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/781b00e1_13ff0ebf PS3, Line 386: output[sample_nr]=trans_table[sample_nr][state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/846d603b_45c4bca6 PS3, Line 387: DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0b3f08d3_c542f812 PS3, Line 388: out_bit = out_bit ^ real_imag ^ parity_table[state_nr]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/d4be30d7_5e5460d5 PS3, Line 389: state_nr = prev_table[state_nr][decision]; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/1104a687_48f95208 PS3, Line 390: real_imag = !real_imag; DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/0fb630d1_a9a37cb2 PS3, Line 391: } DOS line endings Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1518): https://gerrit.osmocom.org/c/osmo-trx/+/30415/comment/2d47f90a_ca0d48be PS3, Line 392: } DOS line endings -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:39:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: ms-trx support

by Jenkins Builder

Attention is currently required from: Hoernchen, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 4: (408 comments) File Transceiver52M/ms/bladerf_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e4fbe3d1_0d9f0738 PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/49642581_07ec61e8 PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b866c7d3_5749d330 PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/464ad5c1_3a9c5f9c PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e9fcc2aa_b0cc1718 PS4, Line 42: template <typename Arg, typename... Args> void expand_args(std::ostream &out, Arg &&arg, Args &&...args) spaces required around that '&&' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0eae803_df27e1f2 PS4, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b0e89890_7bc88a8f PS4, Line 44: out << '(' << std::forward<Arg>(arg); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f8db839_96e8defc PS4, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d49fcb8_79d9fad3 PS4, Line 45: (void)(int[]){ 0, (void((out << "," << std::forward<Args>(args))), 0)... }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b90d1efd_eac5a697 PS4, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dcd54475_204ec63a PS4, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/673d5810_1854b34d PS4, Line 49: template <class R, class... Args> using RvalFunc = R (*)(Args...); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2637fb62_819fdb80 PS4, Line 52: template <class R, class... Args> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0e2d93f9_94094f60 PS4, Line 52: template <class R, class... Args> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbf092c1_55b156a7 PS4, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3238be6b_f92ce5a1 PS4, Line 53: R exec_and_check(RvalFunc<R, Args...> func, const char *fname, const char *finame, const char *funcname, int line, spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5bdf4196_e805fa3f PS4, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/348b6ff5_24db686a PS4, Line 56: R rval = func(std::forward<Args>(args)...); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f87d21e0_5ad7bbbe PS4, Line 57: if (rval != 0) { suspect code indent for conditional statements (8, 26) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bd533151_2135cc71 PS4, Line 58: std::cerr << ((rval >= 0) ? "OK:" : bladerf_strerror(rval)) << ':' << finame << ':' << line << ':' labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7f129fd2_a317c458 PS4, Line 66: #define blade_check(func, ...) exec_and_check(func, #func, __FILE__, __FUNCTION__, __LINE__, __VA_ARGS__) __func__ should be used instead of gcc specific __FUNCTION__ Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23f561f1_dc96be17 PS4, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7ddecf5_eab95877 PS4, Line 69: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a400ec35_fdb602d4 PS4, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/72b8c62b_643c86bb PS4, Line 71: template <blade_speed_buffer_type T> struct blade_usb_message { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5678d0e_02a58d50 PS4, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/07135060_7c58bc1c PS4, Line 78: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::SS>) == 2048, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6551fd6d_a61e4b5e PS4, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/252478cc_32608f52 PS4, Line 79: static_assert(sizeof(blade_usb_message<blade_speed_buffer_type::HS>) == 1024, "blade buffer mismatch!"); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a75b036c_fec16dc4 PS4, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dacfb9da_be469f57 PS4, Line 80: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d3ad476_6bbdc0f4 PS4, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e121d65_ede6b47d PS4, Line 82: blade_usb_message<T> m[SZ]; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e004635_9b602e43 PS4, Line 83: int actual_samples_per_msg() Bad function definition - int actual_samples_per_msg() should probably be int actual_samples_per_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c62e3311_edc46120 PS4, Line 83: int actual_samples_per_msg() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f3cae76e_abc1f194 PS4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0714f8ec_b83bb5d4 PS4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0332ac93_0a1caab4 PS4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35248f58_830d1c9b PS4, Line 85: return sizeof(blade_usb_message<T>::d) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/398d2899_244d6ff4 PS4, Line 87: int actual_samples_per_buffer() Bad function definition - int actual_samples_per_buffer() should probably be int actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5f73b704_6d863e79 PS4, Line 87: int actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b7dd993_bc6945ea PS4, Line 91: int samples_per_buffer() Bad function definition - int samples_per_buffer() should probably be int samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea513452_0ec389d9 PS4, Line 91: int samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a6c4815c_f9316241 PS4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8100dbab_ce9c08fa PS4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxB) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bd9d75e_51615d55 PS4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/94683692_6b34f318 PS4, Line 93: return SZ * sizeof(blade_usb_message<T>) / sizeof(typeof(blade_usb_message<T>::d[0])); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/988c50b6_782a2bdb PS4, Line 95: int num_msgs_per_buffer() Bad function definition - int num_msgs_per_buffer() should probably be int num_msgs_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f23760a6_9d41eb73 PS4, Line 95: int num_msgs_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9f2e0076_b9319256 PS4, Line 99: auto get_first_ts() Bad function definition - auto get_first_ts() should probably be auto get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5569e490_61b3ab8a PS4, Line 99: auto get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9e44604_f87c8dd7 PS4, Line 103: constexpr auto *getsampleoffset(int ofs) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9cd08604_4cddb0ed PS4, Line 109: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ead71ee3_d284a5ee PS4, Line 118: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dad25988_36d68148 PS4, Line 156: int write_n_burst(blade_sample_type *in, int num, uint64_t first_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23a4f2ad_20211ec3 PS4, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fe1c094a_114536d7 PS4, Line 176: template <unsigned int SZ, blade_speed_buffer_type T> struct blade_otw_buffer_helper { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5cc2f7a9_58994f42 PS4, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0d3cae54_92efef6c PS4, Line 178: static blade_otw_buffer<SZ / 512, T> x; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e85c4c12_3c187667 PS4, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48e07691_399e4aa7 PS4, Line 181: using dev_buf_t = typeof(blade_otw_buffer_helper<BLADE_BUFFER_SIZE, blade_speed_buffer_type::SS>::x); spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/228b7e04_5bb66dfe PS4, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa02c71b_650b5b34 PS4, Line 183: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1375b381_8daddac0 PS4, Line 185: template <typename T> struct blade_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/33646ba1_ceefb28b PS4, Line 185: template <typename T> struct blade_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f7425543_2a44f835 PS4, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/23c78a22_94298175 PS4, Line 190: using tx_buf_q_type = spsc_cond<BLADE_NUM_BUFFERS, dev_buf_t *, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fb909010_285bac9d PS4, Line 202: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f1625c65_d52d4e7d PS4, Line 223: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1815a0bc_a8462679 PS4, Line 223: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e6efef2d_c3fb5e09 PS4, Line 242: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60a1a9ed_4895e0c3 PS4, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6141f6c2_4913ce59 PS4, Line 244: struct bladerf_rational_rate rate = { 0, static_cast<uint64_t>((1625e3 * 4)) * 64, 6 * 64 }, actual; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e0807d26_b764a788 PS4, Line 250: std::cerr << "open failed, device missing?" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47f88011_ecea9030 PS4, Line 254: std::cerr << "open failed, only superspeed (usb3) supported!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/105845e8_0d7716ed PS4, Line 271: std::cerr << "unable to lock refclk!" << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a039c05_06ba381f PS4, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7fc3ca55_aa64da27 PS4, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8b23312_413ef22b PS4, Line 301: auto cur_buffer = reinterpret_cast<tx_buf_q_type::elem_t *>(buf_mgmt.tx_samples); spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/143ab462_3c8cd39b PS4, Line 316: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/96545469_ee9ad298 PS4, Line 318: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6b9038d1_c62bd61d PS4, Line 320: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9853127_cbcc8222 PS4, Line 323: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e9a0ba8a_f5a1f9da PS4, Line 325: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0573b829_f96790a1 PS4, Line 327: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/986a12ee_6fef211c PS4, Line 330: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e8325665_72308c03 PS4, Line 335: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eeaf98ed_c577c2c8 PS4, Line 338: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5631c143_e4babd92 PS4, Line 340: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4883c42_9b20210d PS4, Line 343: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/283694a8_967c5af2 PS4, Line 346: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bbaec33_e3230bca PS4, Line 348: msleep(15); msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/77865371_870c1aae PS4, Line 351: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63113973_f50dbb75 PS4, Line 356: static void check_timestamp(dev_buf_t *rcd) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/35facc8a_f549b0e3 PS4, Line 363: } else if (last_ts + rcd->actual_samples_per_buffer() != rcd->m[0].ts) { suspect code indent for conditional statements (16, 34) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c988091_cdc9de15 PS4, Line 364: std::cerr << "RX Overrun!" << last_ts << " " << rcd->actual_samples_per_buffer() << " " labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36b2a704_9648b2ba PS4, Line 372: bladerf_stream_cb getrxcb(bh_fn_t rxbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9d9763eb_cc42bf17 PS4, Line 376: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a3a7c73d_c4c4aa55 PS4, Line 377: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/50d09f42_43be1638 PS4, Line 392: bladerf_stream_cb gettxcb(bh_fn_t txbh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0b515c8f_766ab88b PS4, Line 396: return [](struct bladerf *dev, struct bladerf_stream *stream, struct bladerf_metadata *meta, space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8dd460a_89e0c889 PS4, Line 397: void *samples, size_t num_samples, void *user_data) -> void * { spaces prohibited around that '->' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb38a84e_5de0b01d PS4, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0ffb85e2_80d22efa PS4, Line 399: auto ptr = reinterpret_cast<tx_buf_q_type::elem_t>(samples); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/db199f79_764dd8ea PS4, Line 408: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/764d4f7f_071636a1 PS4, Line 410: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc1a6719_7ce1655e PS4, Line 414: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a826018_257abfe5 PS4, Line 420: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f848075_b5db0624 PS4, Line 422: auto fn = [this] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a406c7f1_48dd215d PS4, Line 426: std::cerr << "rx stream error! " << bladerf_strerror(status) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22c1ef4f_cdb239c3 PS4, Line 433: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/430080b3_5020d8ab PS4, Line 435: //get empty bufer from list 'bufer' may be misspelled - perhaps 'buffer'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/13e5105f_5f1b48d5 PS4, Line 436: tx_buf_q_type::elem_t rcd; labels should not be indented File Transceiver52M/ms/ipc_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/012eb27e_9828a68d PS4, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/67aa7e2c_10d0af2e PS4, Line 38: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/83f56ccf_540ba082 PS4, Line 45: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d8dee05_9211c458 PS4, Line 45: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e48f9258_7dcbb966 PS4, Line 49: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f2ef3e5_199df7cf PS4, Line 49: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29a8477f_5c79132e PS4, Line 53: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b5bd36a8_8ec23adf PS4, Line 58: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/89fff5a4_3e2d7c08 PS4, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d8a7656_2fd4712a PS4, Line 69: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cb125f12_44de0e07 PS4, Line 71: template <typename T> struct ipc_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c5a255d1_bd5bbf77 PS4, Line 71: template <typename T> struct ipc_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cadb0c40_448f5f44 PS4, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58aae964_0b18c3ff PS4, Line 76: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bdb19b4_e4dabc79 PS4, Line 76: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36a3cd74_98f51df2 PS4, Line 76: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6f167cd7_f20ddbca PS4, Line 92: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/363fd994_46598945 PS4, Line 99: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b275091a_aff5566d PS4, Line 106: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8ccc41d_9f198391 PS4, Line 111: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d64a6609_587150fd PS4, Line 119: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/36042a9f_51447c87 PS4, Line 127: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dec7eb5d_3584fce5 PS4, Line 132: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/93efede9_ffe77510 PS4, Line 137: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/30284523_8d782d09 PS4, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5a94372_33ed9d4c PS4, Line 149: dev_buf_t rcd = { t, static_cast<uint32_t>(len), pbuf }; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1293d271_53f47f2a PS4, Line 164: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b1d297ee_7e504fe0 PS4, Line 166: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a33ca87_4c5d9f2e PS4, Line 175: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5c43df5_67a5db35 PS4, Line 177: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d43452d_27fb5d21 PS4, Line 183: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b838241d_12e71cc2 PS4, Line 188: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a4f7e097_0b9fe1ab PS4, Line 193: void signal_start() Bad function definition - void signal_start() should probably be void signal_start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/860d9a64_d2c0b06a PS4, Line 193: void signal_start() open brace '{' following function definitions go on the next line File Transceiver52M/ms/itrq.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a0923c2_1b823e7b PS4, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/932f2975_1867398c PS4, Line 51: template <bool block_read, bool block_write> class spsc_cond_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/99081c48_17b764f4 PS4, Line 52: std::condition_variable cond_r, cond_w; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e252952d_38f043a1 PS4, Line 53: std::mutex lr, lw; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d34bb523_51332e0c PS4, Line 54: std::atomic_int r_flag, w_flag; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/faaa0581_7090fb61 PS4, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca6c865a_0bb4aae9 PS4, Line 57: explicit spsc_cond_detail() : r_flag(0), w_flag(0) Bad function definition - explicit spsc_cond_detail() should probably be explicit spsc_cond_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/965ba94c_09032b43 PS4, Line 65: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0558065d_1767f27a PS4, Line 65: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f48eaa8_fce369ae PS4, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a444b097_b5923383 PS4, Line 67: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/33289b64_d73fafe5 PS4, Line 67: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/18a4d521_0a45641c PS4, Line 73: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/563954a6_d9820948 PS4, Line 73: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/61b51df2_408e596d PS4, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d4c8aba_aebf1763 PS4, Line 75: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d8339bc3_d5353885 PS4, Line 75: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7e3675e0_b88198ec PS4, Line 81: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7882480e_ebb217f7 PS4, Line 81: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8a23ebff_a512d7db PS4, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d84d3f53_31189a5f PS4, Line 83: std::unique_lock<std::mutex> lk(lr); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85e7cfdf_db9894bb PS4, Line 83: std::unique_lock<std::mutex> lk(lr); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9569393_ef87dddd PS4, Line 87: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/37a410e8_9d951f13 PS4, Line 87: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/59ec3afa_82bc146c PS4, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/234f6e66_7d4b9969 PS4, Line 89: std::unique_lock<std::mutex> lk(lw); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b380731b_bb4374ef PS4, Line 89: std::unique_lock<std::mutex> lk(lw); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/afb1b0f2_b5222af3 PS4, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/03d9ffcd_f5ecd359 PS4, Line 96: template <bool block_read, bool block_write> class spsc_efd_detail { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce546c82_b14e1f6c PS4, Line 99: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7488991a_4dea578a PS4, Line 100: explicit spsc_efd_detail() Bad function definition - explicit spsc_efd_detail() should probably be explicit spsc_efd_detail(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e1c4e612_b4d7b724 PS4, Line 111: ssize_t spsc_check_r() Bad function definition - ssize_t spsc_check_r() should probably be ssize_t spsc_check_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/66f47105_647c00fb PS4, Line 111: ssize_t spsc_check_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56711eb9_dd44dac2 PS4, Line 116: ssize_t spsc_check_w() Bad function definition - ssize_t spsc_check_w() should probably be ssize_t spsc_check_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5457774d_30ea42cc PS4, Line 116: ssize_t spsc_check_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/20170785_ae7ca8bf PS4, Line 121: void spsc_notify_r() Bad function definition - void spsc_notify_r() should probably be void spsc_notify_r(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b301bd1f_c6046e14 PS4, Line 121: void spsc_notify_r() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/af5ffa1c_d067749e PS4, Line 126: void spsc_notify_w() Bad function definition - void spsc_notify_w() should probably be void spsc_notify_w(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4cc88c8_8567eeba PS4, Line 126: void spsc_notify_w() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a56d12bc_d2c436cf PS4, Line 131: int get_r_efd() Bad function definition - int get_r_efd() should probably be int get_r_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f05949be_50034ba0 PS4, Line 131: int get_r_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7417c894_faf4de9a PS4, Line 135: int get_w_efd() Bad function definition - int get_w_efd() should probably be int get_w_efd(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5465e245_f05ec879 PS4, Line 135: int get_w_efd() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7e12560_47a64221 PS4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5483259c_a5cf7729 PS4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8bdf9b28_04ca0a1c PS4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/48eef795_4a365bf7 PS4, Line 141: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write, template <bool, bool> class T> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c3c7ed0_626ff455 PS4, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1c97d2a9_d87a7edb PS4, Line 142: class spsc : public T<block_read, block_write> { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f74079e1_cf84e3a6 PS4, Line 144: std::atomic<unsigned int> readptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/498fa507_c1850fbd PS4, Line 144: std::atomic<unsigned int> readptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d5f6df7e_319925ee PS4, Line 144: std::atomic<unsigned int> readptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/70e9692f_055c4a7d PS4, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/039b2282_1e9e80f4 PS4, Line 145: std::atomic<unsigned int> writeptr; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e39b20e1_b7ad0d0d PS4, Line 145: std::atomic<unsigned int> writeptr; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/29dde0de_a8fd6910 PS4, Line 149: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cccf0e07_96094b81 PS4, Line 150: using base_t = T<block_read, block_write>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/56a6883c_f25b9a95 PS4, Line 150: using base_t = T<block_read, block_write>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/604cbddb_13524c6f PS4, Line 152: explicit spsc() : readptr(0), writeptr(0) Bad function definition - explicit spsc() should probably be explicit spsc(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a7577ea2_7fae4b5e PS4, Line 163: bool spsc_push(const ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7b4b8d8a_ef042a8d PS4, Line 170: base_t::spsc_check_w(); /* blocks, ensures next (!) call succeeds */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b62c39cd_8e85ef02 PS4, Line 176: base_t::spsc_notify_r(); /* fine after release */ labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b5047f52_41461dea PS4, Line 183: bool spsc_pop(ELEM *elem) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1991f800_32822b22 PS4, Line 195: base_t::spsc_notify_w(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/58feac33_8c9a94df PS4, Line 202: ssize_t spsc_prep_pop() Bad function definition - ssize_t spsc_prep_pop() should probably be ssize_t spsc_prep_pop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3c2bf332_919b66a6 PS4, Line 202: ssize_t spsc_prep_pop() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8d5381ad_98236070 PS4, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d34cb61_c600f721 PS4, Line 210: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2e5b2631_91de41ba PS4, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/22ef33ae_c657ea5c PS4, Line 211: class spsc_evfd : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_efd_detail> {}; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/84e478ec_33ea3544 PS4, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6130c64f_7ca6b792 PS4, Line 212: template <unsigned int SZ, typename ELEM, bool block_read, bool block_write> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4253c014_57facb05 PS4, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; adding a line without newline at end of file Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1bcd0724_1ce7d607 PS4, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bc6524ba_0e7de2a0 PS4, Line 213: class spsc_cond : public spsc_detail::spsc<SZ, ELEM, block_read, block_write, spsc_detail::spsc_cond_detail> {}; spaces required around that '>' (ctx:VxW) File Transceiver52M/ms/logging.cpp: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3a8fcf85_a2b08870 PS4, Line 83: .enabled = 0, trailing whitespace File Transceiver52M/ms/ms.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92c4d93b_a13d4592 PS4, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2b3555bd_9cb0dacd PS4, Line 34: #define BASET blade_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df403a2f_f04dc1da PS4, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/136aa062_04a11670 PS4, Line 37: #define BASET uhd_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/746a2841_54f6371e PS4, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea27b54f_c5e4b519 PS4, Line 40: #define BASET ipc_hw<ms_trx> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/334480fb_9a2258e8 PS4, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/219d9af0_4745c322 PS4, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f02b120a_75956860 PS4, Line 52: template <typename T> void clamp_array(T *start2, unsigned int len, T max) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fa7508a4_2b0a07a1 PS4, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4e0b5c93_68f7adf4 PS4, Line 60: template <typename DST_T, typename SRC_T, typename ST> spaces required around that '>' (ctx:VxE) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae4b94bb_d514ceac PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/54bdc554_610c14ec PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfa4955b_127d1999 PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a5c56a0_2e0fe28f PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b174c065_890337fb PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f90e74e0_3aa23517 PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ea8bcffc_2dfc9026 PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1367311c_2e814d29 PS4, Line 64: reinterpret_cast<DST_T *>(dst)[i] = static_cast<DST_T>((reinterpret_cast<SRC_T *>(src)[i])) * scale; spaces required around that '>' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63d26a38_95b53f4d PS4, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d78e9bb_304a634a PS4, Line 66: template <typename DST_T, typename SRC_T> void convert_and_scale_default(void *dst, void *src, unsigned int src_len) spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f750f316_c84111b6 PS4, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ff18c897_0e44b039 PS4, Line 68: return convert_and_scale<DST_T, SRC_T>(dst, src, src_len, SAMPLE_SCALE_FACTOR); spaces required around that '>' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a880da7d_e71f4341 PS4, Line 75: GSM::Time gsmts; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0ab49a15_a2f64398 PS4, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f39b5da2_e40bd394 PS4, Line 82: using rx_queue_t = spsc_cond<8 * NUM_RXQ_FRAMES, one_burst, true, true>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6c6fa4cd_d6b2e9f4 PS4, Line 87: std::ostream null_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0f5d9aca_3682f2c6 PS4, Line 89: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8985bb81_38c409b3 PS4, Line 90: dummylog() : null_stream(this){}; space required before the open brace '{' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/a055764f_a81a8509 PS4, Line 92: std::ostream &operator()() need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7f043ff_4566380b PS4, Line 92: std::ostream &operator()() labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e774949b_c4b04f11 PS4, Line 104: GSM::Time global_time_keeper; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f0cfa136_e5634a2b PS4, Line 106: std::mutex m; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/33d5f41f_1f91fbe8 PS4, Line 108: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9644af96_87b9b7c7 PS4, Line 113: void set(GSM::Time t, int64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/582d4cd1_68b34f8f PS4, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/45a4262a_4ea8d352 PS4, Line 115: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0052cc0f_70336e0f PS4, Line 115: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d37448f_4bce3dbe PS4, Line 119: void inc_both() Bad function definition - void inc_both() should probably be void inc_both(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/10c2312c_a51ba08a PS4, Line 119: void inc_both() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7bf103d7_b7c0ccbf PS4, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dbb79027_2f021127 PS4, Line 121: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8f6cf25_a00c5486 PS4, Line 121: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fffd56fd_de309817 PS4, Line 125: void inc_and_update(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/43a3d6d8_8ed45925 PS4, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/302871f5_42afa40a PS4, Line 127: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4187f74e_9dd02053 PS4, Line 127: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c363c11f_0e192b5d PS4, Line 132: void inc_and_update_safe(int64_t new_ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75888cf0_896420d4 PS4, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df7f4e7a_7057f208 PS4, Line 134: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/60dc5b49_21f81f99 PS4, Line 134: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/80000da7_fc59f9d5 PS4, Line 142: void dec_by_one() Bad function definition - void dec_by_one() should probably be void dec_by_one(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ead67dbb_4f39a2d3 PS4, Line 142: void dec_by_one() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4c89aa24_b97adf03 PS4, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5614c6f1_1c873bba PS4, Line 144: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d4aef9e3_a81f56a3 PS4, Line 144: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca19cabc_3e1a7f0a PS4, Line 148: auto get_ts() Bad function definition - auto get_ts() should probably be auto get_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eccc46e7_8ac8b3f0 PS4, Line 148: auto get_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b525391b_98386d2a PS4, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/450f37e7_44054efe PS4, Line 150: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2a1d3b62_1a48975d PS4, Line 150: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/392c0c6f_82a7a8e7 PS4, Line 153: auto gsmtime() Bad function definition - auto gsmtime() should probably be auto gsmtime(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d9cb40f8_fbf92b4e PS4, Line 153: auto gsmtime() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cfb0e0c3_c45fa299 PS4, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bc4fea31_19c9f68b PS4, Line 155: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/57bbd756_7328eeb9 PS4, Line 155: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d79ed7fb_571590ce PS4, Line 158: void get_both(GSM::Time *t, int64_t *ts) need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1dac4eeb_a369dd88 PS4, Line 158: void get_both(GSM::Time *t, int64_t *ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1488fb25_324aaf2a PS4, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/c91b0151_5a73d1b7 PS4, Line 160: std::lock_guard<std::mutex> g(m); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f15aef69_34ad9179 PS4, Line 160: std::lock_guard<std::mutex> g(m); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/108bfb86_cccac2c7 PS4, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/30bc0907_aeb53021 PS4, Line 166: using ts_hitter_q_t = spsc_cond<64, GSM::Time, true, false>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ae0e1721_21c97aed PS4, Line 176: std::thread rx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b4376944_3bcafadc PS4, Line 177: std::thread tx_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dc1086ea_5b58ae78 PS4, Line 178: std::thread *calcrval_task; need consistent spacing around '*' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/81309834_9289f8b2 PS4, Line 178: std::thread *calcrval_task; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75da6e39_788f160e PS4, Line 189: std::atomic<bool> rcv_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/870a73bb_f61a426b PS4, Line 189: std::atomic<bool> rcv_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31842f2f_47f5808b PS4, Line 189: std::atomic<bool> rcv_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c29eec6_6b8634df PS4, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/202d6e47_8cbe50d8 PS4, Line 190: std::atomic<bool> sch_thread_done; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/63f32876_05191f89 PS4, Line 190: std::atomic<bool> sch_thread_done; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8ddb3eb_6cf2a823 PS4, Line 197: void start(); Bad function definition - void start() should probably be void start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6eb1a3b5_2423f8c2 PS4, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4f2b92a5_dc50b79a PS4, Line 198: std::atomic<bool> upper_is_ready; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ed13e737_92be18eb PS4, Line 198: std::atomic<bool> upper_is_ready; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2fc27bb1_7332acfd PS4, Line 201: bool handle_sch_or_nb(); Bad function definition - bool handle_sch_or_nb() should probably be bool handle_sch_or_nb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/47f53459_a4445732 PS4, Line 207: int init_device(); Bad function definition - int init_device() should probably be int init_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d2fbc01_e3865830 PS4, Line 208: int init_dev_and_streams(); Bad function definition - int init_dev_and_streams() should probably be int init_dev_and_streams(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4b3d19e1_d3ca1eb7 PS4, Line 209: void stop_threads(); Bad function definition - void stop_threads() should probably be void stop_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2eb57e97_1d65ce2a PS4, Line 211: void *tx_cb(); Bad function definition - void *tx_cb() should probably be void *tx_cb(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6ca641ff_aedffe2f PS4, Line 212: void maybe_update_gain(one_burst &brst); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/57707337_b57c36f8 PS4, Line 225: bh_fn_t rx_bh(); Bad function definition - bh_fn_t rx_bh() should probably be bh_fn_t rx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e373074_851dcdf3 PS4, Line 226: bh_fn_t tx_bh(); Bad function definition - bh_fn_t tx_bh() should probably be bh_fn_t tx_bh(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d314657_a327cd42 PS4, Line 229: void set_ta(int val) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e5662384_406d10e4 PS4, Line 235: void set_name_aff_sched(const char *name, int cpunum, int schedtype, int prio) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b8f8e78a_bcd275c4 PS4, Line 240: void set_name_aff_sched(std::thread::native_handle_type h, const char *name, int cpunum, int schedtype, open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ad5f97d5_7098d80d PS4, Line 252: std::cerr << name << " affinity: errreur! " << std::strerror(errno); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/da8d97c2_04d47572 PS4, Line 260: std::cerr << name << " sched: errreur! " << std::strerror(errno); labels should not be indented File Transceiver52M/ms/ms_rx_burst.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bf6bc36b_86a3f20e PS4, Line 25: void rcv_bursts_test(rx_queue_t *q, unsigned int *tsc, int scale); adding a line without newline at end of file File Transceiver52M/ms/ms_upper.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/90f8d2c9_1b27d209 PS4, Line 44: bool driveControl(); Bad function definition - bool driveControl() should probably be bool driveControl(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cbcfab5d_739eeb40 PS4, Line 45: void driveReceiveFIFO(); Bad function definition - void driveReceiveFIFO() should probably be void driveReceiveFIFO(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/096f4076_1875a61d PS4, Line 46: void driveTx(); Bad function definition - void driveTx() should probably be void driveTx(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/143c09c8_be62241c PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/85857abe_76b371c3 PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8216a6a2_bdaf2f5a PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7844069d_363aa08e PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/981f4c38_67ebda0e PS4, Line 48: bool pullRadioVector(GSM::Time &wTime, int &RSSI, int &timingOffset) __attribute__((optnone)); function definition argument 'int' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f88bd0bd_e708762b PS4, Line 50: std::thread thr_control, thr_rx, thr_tx; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ca6d5b58_b96ba933 PS4, Line 52: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd69099d_b33a248d PS4, Line 53: void start_threads(); Bad function definition - void start_threads() should probably be void start_threads(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5ad30313_13ee267b PS4, Line 54: void start_lower_ms(); Bad function definition - void start_lower_ms() should probably be void start_lower_ms(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3e806a26_3d47e93c PS4, Line 56: upper_trx(){}; space required before the open brace '{' File Transceiver52M/ms/sch.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8919dc75_78a49634 PS4, Line 130: int gsm_fcch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4a0038a8_7b7becc0 PS4, Line 134: int gsm_sch_check_ts(int ts, int fn) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/bfe8f1eb_d02b27ec PS4, Line 205: #if 1 Consider removing the #if 1 and its #endif Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f8383c1e_5905f49f PS4, Line 210: float a, b, c, d, ang, avg = 0.0f; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3aa84301_a70d654c PS4, Line 235: ang = b - a; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/702ddc3c_c1f2c84b PS4, Line 237: if (ang > M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eb6d9f7b_3d1e23d9 PS4, Line 238: ang -= 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eba55abe_a7f27444 PS4, Line 239: else if (ang < -M_PI) 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/75c89e05_3398e884 PS4, Line 240: ang += 2 * M_PI; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/589cc63a_42137108 PS4, Line 242: avg += ang; 'ang' may be misspelled - perhaps 'and'? Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/407e9cc7_97614d20 PS4, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1f2e9dd1_309b5ac3 PS4, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/572dfcd8_6eb64dbd PS4, Line 259: void pinv(int P, int8_t* r, int8_t* s, int L1, int L2) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0bad2ad0_d42845ab PS4, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9a50d475_2bbfcf48 PS4, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6cfa77bf_bf9cf38a PS4, Line 270: float ac_sum_with_lag( complex float* in, int lag, int offset, int N) { space prohibited after that open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b599d44e_55c6adb2 PS4, Line 314: static __attribute__((constructor)) void init() Bad function definition - void init() should probably be void init(void) File Transceiver52M/ms/uhd_specific.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b7b95643_49719c96 PS4, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1546e22b_8b53a493 PS4, Line 35: using blade_sample_type = std::complex<int16_t>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/706d54eb_86c0cfe4 PS4, Line 41: uhd::rx_metadata_t *md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b563b4dc_5b7ba6c8 PS4, Line 43: auto actual_samples_per_buffer() Bad function definition - auto actual_samples_per_buffer() should probably be auto actual_samples_per_buffer(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f6c6497_875f0ef3 PS4, Line 43: auto actual_samples_per_buffer() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/309b0818_a4faab71 PS4, Line 47: long get_first_ts() Bad function definition - long get_first_ts() should probably be long get_first_ts(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/225b0d2b_6288c7a0 PS4, Line 47: long get_first_ts() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/68f0e848_0ed7f80b PS4, Line 51: int readall(blade_sample_type *outaddr) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4476c175_2765e0c7 PS4, Line 56: int read_n(blade_sample_type *outaddr, int start, int num) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f983f62f_c4d28670 PS4, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e17fede8_2c4ee921 PS4, Line 67: using bh_fn_t = std::function<int(dev_buf_t *)>; spaces required around that '>' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2215ac88_13f089c4 PS4, Line 69: template <typename T> struct uhd_hw { spaces required around that '<' (ctx:WxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d30102c2_bdcb967f PS4, Line 69: template <typename T> struct uhd_hw { spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0c96334b_f663c05d PS4, Line 70: uhd::usrp::multi_usrp::sptr dev; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e8bfadc6_90e82626 PS4, Line 71: uhd::rx_streamer::sptr rx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/964c9ccc_af1df233 PS4, Line 72: uhd::tx_streamer::sptr tx_stream; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d81c4884_b27050af PS4, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/92f90106_90b1dbb1 PS4, Line 74: std::vector<blade_sample_type *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/dd1a0b5c_a92e64b7 PS4, Line 74: std::vector<blade_sample_type *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2d7f5c6c_5f46808d PS4, Line 74: std::vector<blade_sample_type *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4187062d_8821effe PS4, Line 90: void close_device() Bad function definition - void close_device() should probably be void close_device(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f69c36a_bee628bf PS4, Line 90: void close_device() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/929845ba_73446dab PS4, Line 95: bool tuneTx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6fc061ff_83703c9e PS4, Line 102: bool tuneRx(double freq, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d187f6de_9d9bb43b PS4, Line 109: bool tuneRxOffset(double offset, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/62e3837a_0ee9cfc9 PS4, Line 114: double setRxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9888dce8_4e6ef144 PS4, Line 122: double setTxGain(double dB, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e916fc1a_4ccc7816 PS4, Line 130: int setPowerAttenuation(int atten, size_t chan = 0) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/13d9d6a3_13bb68c0 PS4, Line 135: int init_device(bh_fn_t rxh, bh_fn_t txh) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/90dd63fe_76543117 PS4, Line 145: std::string args = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/750a55ee_bc163bea PS4, Line 148: std::cout << "Using Device: " << dev->get_pp_string() << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/492fbf42_0306e4a8 PS4, Line 153: uhd::tune_request_t tune_request(freq, 0); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/cba3bd7d_f0593e7f PS4, Line 162: std::this_thread::sleep_for(std::chrono::milliseconds(lock_delay_ms)); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ce5a8ecb_f91ec7d2 PS4, Line 164: uhd::stream_args_t stream_args("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d3102800_201fe8c0 PS4, Line 166: uhd::stream_args_t stream_args2("sc16", "sc16"); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/64f67bf6_764a5bce PS4, Line 177: void *rx_cb(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/5d55f2fe_b88d6f98 PS4, Line 182: uhd::rx_metadata_t md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1d093052_b73d29ef PS4, Line 186: std::cerr << boost::format("Timeout while streaming") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/032baf98_744a75a3 PS4, Line 190: std::cerr << boost::format("Got an overflow indication\n") << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/df0faf8c_754cffc2 PS4, Line 194: std::cerr << str(boost::format("Receiver error: %s") % md.strerror()); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2447c177_849f468f PS4, Line 209: auto get_rx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/eaef6c1c_64c29ae9 PS4, Line 211: auto fn = [this, burst_handler] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/4761d444_31eca120 PS4, Line 214: uhd::stream_cmd_t stream_cmd(uhd::stream_cmd_t::STREAM_MODE_START_CONTINUOUS); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/ba8b1b42_6569e1e4 PS4, Line 225: auto get_tx_burst_handler_fn(bh_fn_t burst_handler) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/145336ee_cfe770e1 PS4, Line 227: auto fn = [] { space prohibited before open square bracket '[' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/6d59a9b9_90e94ae8 PS4, Line 232: void submit_burst_ts(blade_sample_type *buffer, int len, uint64_t ts) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/1eb7354f_545176b7 PS4, Line 234: uhd::tx_metadata_t m = {}; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fb6cce9d_ea898f7d PS4, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8e9dab80_6ee037c4 PS4, Line 239: std::vector<void *> ptrs(1, buffer); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/b3e2bb41_a10a728a PS4, Line 239: std::vector<void *> ptrs(1, buffer); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/21b7ba3e_e2719417 PS4, Line 239: std::vector<void *> ptrs(1, buffer); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/9641279f_94d130cf PS4, Line 243: uhd::async_metadata_t async_md; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/e278f517_40fee58e PS4, Line 248: std::cout << (tx_ack ? "yay" : "nay") << " " << async_md.time_spec.to_ticks(rxticks) << std::endl; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1517): https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/78f6461d_4ba31637 PS4, Line 251: }; adding a line without newline at end of file -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 4 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:39:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: bladerf xa4 support

by Jenkins Builder

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 2: (57 comments) File Transceiver52M/device/bladerf/bladerf.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/02758b33_3ec9d528 PS2, Line 56: public: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/570b87e8_38196db0 PS2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/91011ee4_c30b98a0 PS2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/09de9f83_c4f8205e PS2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/730481f2_fc42c4ed PS2, Line 58: const std::vector<std::string> &tx_paths, const std::vector<std::string> &rx_paths); spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/948c4825_d9543cbb PS2, Line 61: int open(const std::string &args, int ref, bool swap_channels); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c4aec15c_e418a07c PS2, Line 62: bool start(); Bad function definition - bool start() should probably be bool start(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c9994346_110097dd PS2, Line 63: bool stop(); Bad function definition - bool stop() should probably be bool stop(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/92b1c31b_09b776fb PS2, Line 64: bool restart(); Bad function definition - bool restart() should probably be bool restart(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/365dc44c_ff36e14e PS2, Line 65: enum TxWindowType getWindowType() Bad function definition - enum TxWindowType getWindowType() should probably be enum TxWindowType getWindowType(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/82c17625_c4aefe04 PS2, Line 65: enum TxWindowType getWindowType() open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/6ae539ec_d802a982 PS2, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/b43b20f4_8c2159d3 PS2, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/f5fe67fb_61f667c1 PS2, Line 70: int readSamples(std::vector<short *> &bufs, int len, bool *overrun, TIMESTAMP timestamp, bool *underrun); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/35c5ac04_bbfe16a1 PS2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/dca826b1_bcdad5b0 PS2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/b4b013fa_ee6a6977 PS2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/76a7739e_3c2a7ec6 PS2, Line 72: int writeSamples(std::vector<short *> &bufs, int len, bool *underrun, TIMESTAMP timestamp); function definition argument 'short *' should also have an identifier name Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/83479c1b_52849f40 PS2, Line 79: TIMESTAMP initialWriteTimestamp(); Bad function definition - TIMESTAMP initialWriteTimestamp() should probably be TIMESTAMP initialWriteTimestamp(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/059feb11_73612ef3 PS2, Line 80: TIMESTAMP initialReadTimestamp(); Bad function definition - TIMESTAMP initialReadTimestamp() should probably be TIMESTAMP initialReadTimestamp(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/73c834a7_ce03f917 PS2, Line 82: double fullScaleInputValue(); Bad function definition - double fullScaleInputValue() should probably be double fullScaleInputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c5416cf5_188db17e PS2, Line 83: double fullScaleOutputValue(); Bad function definition - double fullScaleOutputValue() should probably be double fullScaleOutputValue(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/56bbd38d_dee844b3 PS2, Line 87: double maxRxGain(void) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/30b3a93d_09cea634 PS2, Line 91: double minRxGain(void) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/c326538f_bf8dc6fd PS2, Line 104: double getRxFreq(); Bad function definition - double getRxFreq() should probably be double getRxFreq(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d0eba465_e01ead07 PS2, Line 106: bool setRxAntenna(const std::string &ant, size_t chan) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/78c5e56e_da57aea2 PS2, Line 106: bool setRxAntenna(const std::string &ant, size_t chan) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/18cf4bc8_96d6dfb6 PS2, Line 110: std::string getRxAntenna(size_t chan) labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/39bf4831_4c638f9d PS2, Line 114: bool setTxAntenna(const std::string &ant, size_t chan) need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/8c69f395_c764fe88 PS2, Line 114: bool setTxAntenna(const std::string &ant, size_t chan) open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/2af965db_3573f1e5 PS2, Line 118: std::string getTxAntenna(size_t chan) labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ce00226f_2a66c5d6 PS2, Line 123: bool requiresRadioAlign(); Bad function definition - bool requiresRadioAlign() should probably be bool requiresRadioAlign(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/64fad0d2_ee6858a2 PS2, Line 125: GSM::Time minLatency(); labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/94dd65fb_1df681ae PS2, Line 127: inline double getSampleRate() Bad function definition - double getSampleRate() should probably be double getSampleRate(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/6e23a67b_4d031d4a PS2, Line 135: bool recv_async_msg(); Bad function definition - bool recv_async_msg() should probably be bool recv_async_msg(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a157531a_84b71590 PS2, Line 144: protected: labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3d924f0a_20d291d9 PS2, Line 155: std::vector<double> tx_gains, rx_gains; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/aa06279f_45c7fe60 PS2, Line 155: std::vector<double> tx_gains, rx_gains; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5ce8f427_6ae9e494 PS2, Line 155: std::vector<double> tx_gains, rx_gains; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/8b86ad03_25bdf820 PS2, Line 156: std::vector<double> tx_freqs, rx_freqs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a335ddb6_be0aed72 PS2, Line 156: std::vector<double> tx_freqs, rx_freqs; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e1f1d98b_f7a8fb50 PS2, Line 156: std::vector<double> tx_freqs, rx_freqs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/ac5a8082_1c6ae147 PS2, Line 169: std::vector<smpl_buf *> rx_buffers; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3c52f881_b1f956a5 PS2, Line 169: std::vector<smpl_buf *> rx_buffers; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/e08cb8b8_0e9c6189 PS2, Line 169: std::vector<smpl_buf *> rx_buffers; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/afa4c1e6_d73c4b4c PS2, Line 169: std::vector<smpl_buf *> rx_buffers; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/63f48f26_531de063 PS2, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/96fdeaf0_432ace4d PS2, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/3ee04ce3_3500d8a7 PS2, Line 171: std::vector<std::vector<short> > pkt_bufs; spaces required around that '>' (ctx:VxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/d469be2c_43f28e35 PS2, Line 171: std::vector<std::vector<short> > pkt_bufs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/b448a38e_07ba6ed0 PS2, Line 174: std::vector<short *> pkt_ptrs; spaces required around that '<' (ctx:VxV) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/7d64db75_28444d4b PS2, Line 174: std::vector<short *> pkt_ptrs; need consistent spacing around '*' (ctx:WxO) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/584261a6_83ed9e3d PS2, Line 174: std::vector<short *> pkt_ptrs; spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/7973fcea_02e25b9b PS2, Line 174: std::vector<short *> pkt_ptrs; labels should not be indented Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/a7564172_0b158a38 PS2, Line 176: void init_gains(); Bad function definition - void init_gains() should probably be void init_gains(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/b2ec9065_953fc2dc PS2, Line 178: void set_rates(); Bad function definition - void set_rates() should probably be void set_rates(void) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1516): https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/7f13033e_79b8ca05 PS2, Line 182: void get_dev_band_desc(dev_band_desc &desc); need consistent spacing around '&' (ctx:WxV) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?) -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:39:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: vita demod by piotr krysik, modified

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 to look at the new patch set (#3). Change subject: vita demod by piotr krysik, modified ...................................................................... vita demod by piotr krysik, modified Grabbed from gr-gsm 2de47e28ce1fb9a518337bfc0add36c8e3cff5eb Had a few rounds of extensive cleanup (not the va itself). Uses gcc multiversioning for x86 targets. Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f --- A Transceiver52M/grgsm_vitac/constants.h A Transceiver52M/grgsm_vitac/grgsm_vitac.cpp A Transceiver52M/grgsm_vitac/grgsm_vitac.h A Transceiver52M/grgsm_vitac/viterbi_detector.cc A Transceiver52M/grgsm_vitac/viterbi_detector.h 5 files changed, 959 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/15/30415/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5466c522cf4de984a4810ec46df43a10b52ed78f Gerrit-Change-Number: 30415 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: bladerf xa4 support

by Hoernchen

Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 to look at the new patch set (#2). Change subject: bladerf xa4 support ...................................................................... bladerf xa4 support This is not really finished, there are multiple reasons to not use this: 1) main clock is not a gsm multiple, so it will continously drift 2) small buffer sizes lead to tx gaps that are hard to detect and break everything. Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac --- M .gitignore M Transceiver52M/Makefile.am M Transceiver52M/device/Makefile.am A Transceiver52M/device/bladerf/Makefile.am A Transceiver52M/device/bladerf/bladerf.cpp A Transceiver52M/device/bladerf/bladerf.h M configure.ac 7 files changed, 920 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/13/30413/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: bladerf xa4 support

by Hoernchen

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 1: (1 comment) File Transceiver52M/device/bladerf/bladerf.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/edb8462c_7592e075 PS1, Line 727: #ifndef IPCMAGIC > what's this for? This is related to the ipc interface test that uses the uhd backend for the ipc side,which is where the file is copied from. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:23:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: vty: Write amount of timeouts elapsed for a paging request

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30402 ) Change subject: vty: Write amount of timeouts elapsed for a paging request ...................................................................... vty: Write amount of timeouts elapsed for a paging request Related: SYS#6200 Change-Id: I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a --- M src/osmo-bsc/bsc_vty.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve osmith: Looks good to me, approved laforge: Looks good to me, approved diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index 2be5932..cc9de74 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -1044,7 +1044,7 @@ static void paging_dump_vty(struct vty *vty, struct gsm_paging_request *pag) { - vty_out(vty, "Paging on BTS %u%s", pag->bts->nr, VTY_NEWLINE); + vty_out(vty, "Paging on BTS %u (%u request timeouts)%s", pag->bts->nr, pag->attempts, VTY_NEWLINE); bsc_subscr_dump_vty(vty, pag->bsub); } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a Gerrit-Change-Number: 30402 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Replace reqs waiting for retransmission with new incoming ini...

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30347 ) Change subject: paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full ...................................................................... paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full If queue size (in transmit delay of requests) is too long (above threshold) when a new initial incoming request arrives, instead of directly discarding it, see if we can drop a pending retransmission and insert the new one instead, in order to avoid losing initial requests. This is done under the assumption that it is more important to transmit intial requests than to retransmit already transmitted ones. The rationale is that there's lower chances that an MS which didn't answer lately will answer now (aka being reachable at the cell), so it's better to allocate resources for new requests (new MS) which may be available in the cell. Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d Related: OS#5552 --- M src/osmo-bsc/net_init.c M src/osmo-bsc/paging.c M tests/timer.vty 3 files changed, 19 insertions(+), 11 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c index 75dcbf3..ad2f8c4 100644 --- a/src/osmo-bsc/net_init.c +++ b/src/osmo-bsc/net_init.c @@ -77,8 +77,9 @@ { .T = -3111, .default_val = 4, .desc = "Wait time after lchan was released in error (should be T3111 + 2s)" }, { .T = -3113, .default_val = PAGING_THRESHOLD_X3113_DEFAULT_SEC, .desc = "Maximum Paging Request Transmit Delay Threshold: " \ - "If the estimated transmit delay of the messages of the paging queue surpasses this threshold, new incoming " - "paging requests are discarded, hence limiting the size of the queue and maximum delay of its scheduled requests. " + "If the estimated transmit delay of the messages in the paging queue surpasses this threshold, then new incoming " + "paging requests will if possible replace a request in retransmission state from the queue or otherwise be discarded, " + "hence limiting the size of the queue and maximum delay of its scheduled requests. " "X3113 also serves as the upper boundary for dynamic T3113 when estimating the expected maximum delay to get a response" }, { .T = -3210, .default_val = 20, .desc = "After L3 Complete, wait for MSC to confirm" }, {} diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index fda508e..657665c 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -509,13 +509,6 @@ rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_PAGING_ATTEMPTED)); - /* Don't try to queue more requests than we can realistically handle within X3113 seconds, - * see PAGING_THRESHOLD_X3113_DEFAULT_SEC. */ - if (paging_pending_requests_nr(bts) > paging_estimate_available_slots(bts, x3113_s)) { - rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_PAGING_OVERLOAD)); - return -ENOSPC; - } - /* Find if we already have one for the given subscriber on this BTS: */ if (bsc_subscr_find_req_by_bts(params->bsub, bts)) { LOG_PAGING_BTS(params, bts, DPAG, LOGL_INFO, "Paging request already pending for this subscriber\n"); @@ -523,6 +516,20 @@ return -EEXIST; } + /* Don't try to queue more requests than we can realistically handle within X3113 seconds, + * see PAGING_THRESHOLD_X3113_DEFAULT_SEC. */ + if (paging_pending_requests_nr(bts) > paging_estimate_available_slots(bts, x3113_s)) { + struct gsm_paging_request *first_retrans_req; + rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_PAGING_OVERLOAD)); + /* Need to drop a retrans from the queue if possible, in order to make space for the new initial req. */ + if (bts_entry->retrans_req_list_len == 0) { + /* There are no retrans to be replaced by this initial request, discard it. */ + return -ENOSPC; + } + first_retrans_req = llist_first_entry(&bts_entry->retrans_req_list, struct gsm_paging_request, entry); + paging_remove_request(first_retrans_req); + } + /* The incoming new req will be stored in initial_req_list giving higher prio * to it over retransmissions. This avoids new subscribers being paged to * be delayed if the paging queue is full due to a lot of retranmissions. diff --git a/tests/timer.vty b/tests/timer.vty index 731d134..9573a09 100644 --- a/tests/timer.vty +++ b/tests/timer.vty @@ -35,7 +35,7 @@ net: X18 = 60000 ms Forget-sum period for all_allocated:* rate counters: after this amount of idle time, forget internally cumulated time remainders. Zero to always keep remainders. See also X16, X17. (default: 60000 ms) net: X25 = 5 s Timeout for initial user data after an MSC initiated an SCCP connection to the BSS (default: 5 s) net: X3111 = 4 s Wait time after lchan was released in error (should be T3111 + 2s) (default: 4 s) -net: X3113 = 60 s Maximum Paging Request Transmit Delay Threshold: If the estimated transmit delay of the messages of the paging queue surpasses this threshold, new incoming paging requests are discarded, hence limiting the size of the queue and maximum delay of its scheduled requests. X3113 also serves as the upper boundary for dynamic T3113 when estimating the expected maximum delay to get a response (default: 60 s) +net: X3113 = 60 s Maximum Paging Request Transmit Delay Threshold: If the estimated transmit delay of the messages in the paging queue surpasses this threshold, then new incoming paging requests will if possible replace a request in retransmission state from the queue or otherwise be discarded, hence limiting the size of the queue and maximum delay of its scheduled requests. X3113 also serves as the upper boundary for dynamic T3113 when estimating the expected maximum delay to get a response (default: 60 s) net: X3210 = 20 s After L3 Complete, wait for MSC to confirm (default: 20 s) mgw: X2427 = 5 s timeout for MGCP response from MGW (default: 5 s) @@ -90,7 +90,7 @@ net: X18 = 60000 ms Forget-sum period for all_allocated:* rate counters: after this amount of idle time, forget internally cumulated time remainders. Zero to always keep remainders. See also X16, X17. (default: 60000 ms) net: X25 = 5 s Timeout for initial user data after an MSC initiated an SCCP connection to the BSS (default: 5 s) net: X3111 = 4 s Wait time after lchan was released in error (should be T3111 + 2s) (default: 4 s) -net: X3113 = 60 s Maximum Paging Request Transmit Delay Threshold: If the estimated transmit delay of the messages of the paging queue surpasses this threshold, new incoming paging requests are discarded, hence limiting the size of the queue and maximum delay of its scheduled requests. X3113 also serves as the upper boundary for dynamic T3113 when estimating the expected maximum delay to get a response (default: 60 s) +net: X3113 = 60 s Maximum Paging Request Transmit Delay Threshold: If the estimated transmit delay of the messages in the paging queue surpasses this threshold, then new incoming paging requests will if possible replace a request in retransmission state from the queue or otherwise be discarded, hence limiting the size of the queue and maximum delay of its scheduled requests. X3113 also serves as the upper boundary for dynamic T3113 when estimating the expected maximum delay to get a response (default: 60 s) net: X3210 = 20 s After L3 Complete, wait for MSC to confirm (default: 20 s) mgw: X2427 = 5 s timeout for MGCP response from MGW (default: 5 s) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d Gerrit-Change-Number: 30347 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Optimize retrieving number of request per paging group

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30370 ) Change subject: paging: Optimize retrieving number of request per paging group ...................................................................... paging: Optimize retrieving number of request per paging group This patch caches the counts of initial paging requests for each paging group. This count is needed to estimate T3113 when a new incoming paging request is received and it has to be inserted into the queue. With this there's no need to traverse the whole initial_req_list every time a new incoming paging request is receiving, potentially saving lots of iteration and hence lots of CPU when the queue is long. Related: SYS#6200 Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531 --- M include/osmocom/bsc/paging.h M src/osmo-bsc/paging.c 2 files changed, 17 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h index b10c398..15eb49e 100644 --- a/include/osmocom/bsc/paging.h +++ b/include/osmocom/bsc/paging.h @@ -61,6 +61,9 @@ */ #define PAGING_THRESHOLD_X3113_DEFAULT_SEC 60 +#define MAX_PAGING_BLOCKS_CCCH 9 +#define MAX_BS_PA_MFRMS 9 + struct bsc_paging_params { enum bsc_paging_reason reason; struct bsc_msc_data *msc; @@ -117,6 +120,9 @@ /* Number of requests in pending_requests_len */ unsigned int retrans_req_list_len; + /* Number of requests in initial_req_list, indexed by pgroup. */ + unsigned int initial_req_pgroup_counts[MAX_PAGING_BLOCKS_CCCH * MAX_BS_PA_MFRMS]; + struct gsm_bts *bts; struct osmo_timer_list work_timer; diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 657665c..e6f6fe4 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -88,10 +88,12 @@ osmo_timer_del(&req->T3113); llist_del(&req->entry); - if (req->attempts == 0) + if (req->attempts == 0) { bts_pag_st->initial_req_list_len--; - else + bts_pag_st->initial_req_pgroup_counts[req->pgroup]--; + } else { bts_pag_st->retrans_req_list_len--; + } osmo_stat_item_dec(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_PAGING_REQ_QUEUE_LENGTH), 1); bsc_subscr_remove_active_paging_request(req->bsub, req); talloc_free(req); @@ -220,6 +222,7 @@ if (request->attempts == 0) { /* req is removed from initial_req_list and inserted into retrans_req_list, update list lengths: */ bts_pag_st->initial_req_list_len--; + bts_pag_st->initial_req_pgroup_counts[request->pgroup]--; bts_pag_st->retrans_req_list_len++; } llist_del(&request->entry); @@ -503,9 +506,8 @@ struct gsm_paging_request *req; unsigned int t3113_timeout_s; unsigned int x3113_s = osmo_tdef_get(bts->network->T_defs, -3113, OSMO_TDEF_S, -1); - unsigned int reqs_before = 0, reqs_before_same_pgroup = 0; - uint8_t pgroup = gsm0502_calc_paging_group(&bts->si_common.chan_desc, - str_to_imsi(params->bsub->imsi)); + uint8_t pgroup; + unsigned int reqs_before, reqs_before_same_pgroup; rate_ctr_inc(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_PAGING_ATTEMPTED)); @@ -530,21 +532,9 @@ paging_remove_request(first_retrans_req); } - /* The incoming new req will be stored in initial_req_list giving higher prio - * to it over retransmissions. This avoids new subscribers being paged to - * be delayed if the paging queue is full due to a lot of retranmissions. - * Retranmissions usually mean MS are not reachable/available, so the - * rationale here is to prioritize new subs which may be available. - * - * Count initial reqs already stored in initial_req_list, since those - * will be scheduled for transmission before current incoming req and - need to be taken into account when calculating T3113 for it. - */ - llist_for_each_entry(req, &bts_entry->initial_req_list, entry) { - reqs_before++; - if (req->pgroup == pgroup) - reqs_before_same_pgroup++; - } + pgroup = gsm0502_calc_paging_group(&bts->si_common.chan_desc, str_to_imsi(params->bsub->imsi)); + reqs_before = bts_entry->initial_req_list_len; + reqs_before_same_pgroup = bts_entry->initial_req_pgroup_counts[pgroup]; LOG_PAGING_BTS(params, bts, DPAG, LOGL_DEBUG, "Start paging\n"); req = talloc_zero(tall_paging_ctx, struct gsm_paging_request); @@ -559,6 +549,7 @@ bsc_subscr_add_active_paging_request(req->bsub, req); bts_entry->initial_req_list_len++; + bts_entry->initial_req_pgroup_counts[req->pgroup]++; osmo_stat_item_inc(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_PAGING_REQ_QUEUE_LENGTH), 1); llist_add_tail(&req->entry, &bts_entry->initial_req_list); -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531 Gerrit-Change-Number: 30370 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... paging: Split paging queue into 2 queues: initial and retrans Initial requests: paging requests which haven't been yet transmitted Retrans requests: paging requests which have already been transmitted at least once. Until now one queue was used (llist) to store both. The initial requests were stored at the start of the queue in FIFO order. After the last initial requests, the retrans requests followed also in FIFO. This ordering was used in order to prioritze scheduling of initial paging requests over retransmit paging requests. In the end, having both types in the same list only make code handling the list more complex. Hence, this patch splits the shared llist into 2 llists. Related: SYS#6200 Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 --- M include/osmocom/bsc/paging.h M src/osmo-bsc/bsc_vty.c M src/osmo-bsc/paging.c M tests/paging/paging_test.c M tests/paging/paging_test.ok 5 files changed, 504 insertions(+), 241 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved laforge: Looks good to me, approved diff --git a/include/osmocom/bsc/paging.h b/include/osmocom/bsc/paging.h index dd1bb9e..b10c398 100644 --- a/include/osmocom/bsc/paging.h +++ b/include/osmocom/bsc/paging.h @@ -108,10 +108,15 @@ * to the gsm_bts, a timer and some more state. */ struct gsm_bts_paging_state { - /* pending requests */ - struct llist_head pending_requests; + /* pending requests (initial paging request, no retransmits) */ + struct llist_head initial_req_list; + /* Number of requests in initial_req_list */ + unsigned int initial_req_list_len; + /* pending requests (already transmitted at least once) */ + struct llist_head retrans_req_list; /* Number of requests in pending_requests_len */ - unsigned int pending_requests_len; + unsigned int retrans_req_list_len; + struct gsm_bts *bts; struct osmo_timer_list work_timer; diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c index c5b60d1..2be5932 100644 --- a/src/osmo-bsc/bsc_vty.c +++ b/src/osmo-bsc/bsc_vty.c @@ -1052,7 +1052,9 @@ { struct gsm_paging_request *pag; - llist_for_each_entry(pag, &bts->paging.pending_requests, entry) + llist_for_each_entry(pag, &bts->paging.initial_req_list, entry) + paging_dump_vty(vty, pag); + llist_for_each_entry(pag, &bts->paging.retrans_req_list, entry) paging_dump_vty(vty, pag); } diff --git a/src/osmo-bsc/paging.c b/src/osmo-bsc/paging.c index 4fa1884..fda508e 100644 --- a/src/osmo-bsc/paging.c +++ b/src/osmo-bsc/paging.c @@ -88,12 +88,15 @@ osmo_timer_del(&req->T3113); llist_del(&req->entry); - bts_pag_st->pending_requests_len--; + if (req->attempts == 0) + bts_pag_st->initial_req_list_len--; + else + bts_pag_st->retrans_req_list_len--; osmo_stat_item_dec(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_PAGING_REQ_QUEUE_LENGTH), 1); bsc_subscr_remove_active_paging_request(req->bsub, req); talloc_free(req); - if (llist_empty(&bts_pag_st->pending_requests)) + if (llist_empty(&bts_pag_st->initial_req_list) && llist_empty(&bts_pag_st->retrans_req_list)) osmo_timer_del(&bts_pag_st->work_timer); } @@ -208,6 +211,148 @@ return bts->paging.free_chans_need > count; } +static void paging_req_timeout_retrans(struct gsm_paging_request *request, const struct timespec *now) +{ + struct gsm_bts_paging_state *bts_pag_st = &request->bts->paging; + page_ms(request); + paging_set_available_slots(request->bts, bts_pag_st->available_slots - 1); + + if (request->attempts == 0) { + /* req is removed from initial_req_list and inserted into retrans_req_list, update list lengths: */ + bts_pag_st->initial_req_list_len--; + bts_pag_st->retrans_req_list_len++; + } + llist_del(&request->entry); + llist_add_tail(&request->entry, &bts_pag_st->retrans_req_list); + + request->last_attempt_ts = *now; + request->attempts++; +} + +/* Returns number of paged initial requests (up to max_page_req_per_iter). + * Returning work_done=false means the work timer has been scheduled internally and the caller should avoid processing + * further requests right now. + */ +static unsigned int step_page_initial_reqs(struct gsm_bts_paging_state *bts_pag_st, unsigned int max_page_req_per_iter, + const struct timespec *now, bool *work_done) +{ + struct gsm_paging_request *request, *request2; + unsigned int num_paged = 0; + + llist_for_each_entry_safe(request, request2, &bts_pag_st->initial_req_list, entry) { + /* We run out of available slots. Wait until next CCCH Load Ind + * arrives or credit_timer triggers to keep processing requests. + */ + if (bts_pag_st->available_slots == 0) { + LOG_PAGING_BTS(request, request->bts, DPAG, LOGL_INFO, + "Paging delayed: waiting for available slots at BTS\n"); + *work_done = false; + return num_paged; + } + + if (num_paged == max_page_req_per_iter) { + goto sched_next_iter; + } + + /* we need to determine the number of free channels */ + if (bts_pag_st->free_chans_need != -1 && + can_send_pag_req(request->bts, request->chan_type) != 0) { + LOG_PAGING_BTS(request, request->bts, DPAG, LOGL_INFO, + "Paging delayed: not enough free channels (<%d)\n", + bts_pag_st->free_chans_need); + goto sched_next_iter; + } + + /* handle the paging request now */ + paging_req_timeout_retrans(request, now); + num_paged++; + } + + *work_done = true; + return num_paged; + +sched_next_iter: + LOG_BTS(bts_pag_st->bts, DPAG, LOGL_DEBUG, "Scheduling next batch in %lld.%06lds (available_slots=%u)\n", + (long long)initial_period.tv_sec, initial_period.tv_nsec / 1000, + bts_pag_st->available_slots); + osmo_timer_schedule(&bts_pag_st->work_timer, initial_period.tv_sec, initial_period.tv_nsec / 1000); + *work_done = false; + return num_paged; +} + +static unsigned int step_page_retrans_reqs(struct gsm_bts_paging_state *bts_pag_st, unsigned int max_page_req_per_iter, + const struct timespec *now) +{ + struct gsm_paging_request *request, *initial_request; + unsigned int num_paged = 0; + struct timespec retrans_ts; + + /* do while loop: Try send at most first max_page_req_per_iter paging + * requests. Since transmitted requests are re-appended at the end of + * the list, we check until we find the first req again, in order to + * avoid retransmitting repeated requests until next time paging is + * scheduled. */ + initial_request = llist_first_entry_or_null(&bts_pag_st->retrans_req_list, + struct gsm_paging_request, entry); + if (!initial_request) + return num_paged; + + request = initial_request; + do { + /* We run out of available slots. Wait until next CCCH Load Ind + * arrives or credit_timer triggers to keep processing requests. + */ + if (bts_pag_st->available_slots == 0) { + LOG_PAGING_BTS(request, request->bts, DPAG, LOGL_INFO, + "Paging delayed: waiting for available slots at BTS\n"); + return num_paged; + } + + /* we need to determine the number of free channels */ + if (bts_pag_st->free_chans_need != -1 && + can_send_pag_req(request->bts, request->chan_type) != 0) { + LOG_PAGING_BTS(request, request->bts, DPAG, LOGL_INFO, + "Paging delayed: not enough free channels (<%d)\n", + bts_pag_st->free_chans_need); + goto sched_next_iter; + } + + /* Check if time to retransmit has elapsed. Otherwise, wait until its time to retransmit. */ + timespecadd(&request->last_attempt_ts, &retrans_period, &retrans_ts); + if (timespeccmp(now, &retrans_ts, <)) { + struct timespec tdiff; + timespecsub(&retrans_ts, now, &tdiff); + LOG_PAGING_BTS(request, request->bts, DPAG, LOGL_DEBUG, + "Paging delayed: retransmission happens in %lld.%06lds\n", + (long long)tdiff.tv_sec, tdiff.tv_nsec / 1000); + osmo_timer_schedule(&bts_pag_st->work_timer, tdiff.tv_sec, tdiff.tv_nsec / 1000); + return num_paged; + } + + if (num_paged >= max_page_req_per_iter) + goto sched_next_iter; + + /* handle the paging request now */ + paging_req_timeout_retrans(request, now); + num_paged++; + + request = llist_first_entry(&bts_pag_st->retrans_req_list, + struct gsm_paging_request, entry); + } while (request != initial_request); + + /* Reaching this code paths means all retrans request have been scheduled (and intial_req_list is empty). + * Hence, reeschedule ourselves to now + retrans_period. */ + osmo_timer_schedule(&bts_pag_st->work_timer, retrans_period.tv_sec, retrans_period.tv_nsec / 1000); + return num_paged; + +sched_next_iter: + LOG_BTS(bts_pag_st->bts, DPAG, LOGL_DEBUG, "Scheduling next batch in %lld.%06lds (available_slots=%u)\n", + (long long)initial_period.tv_sec, initial_period.tv_nsec / 1000, + bts_pag_st->available_slots); + osmo_timer_schedule(&bts_pag_st->work_timer, initial_period.tv_sec, initial_period.tv_nsec / 1000); + return num_paged; +} + /* * This is kicked by the periodic PAGING LOAD Indicator * coming from abis_rsl.c @@ -217,86 +362,30 @@ */ static void paging_handle_pending_requests(struct gsm_bts_paging_state *paging_bts) { - struct gsm_paging_request *request, *initial_request; - unsigned int num_paged = 0; - struct gsm_bts *bts = paging_bts->bts; - struct timespec now, retrans_ts; + unsigned int num_paged_initial, num_paged_retrans = 0; + unsigned int max_page_req_per_iter = MAX_PAGE_REQ_PER_ITER; + struct timespec now; + bool work_done = false; /* * Determine if the pending_requests list is empty and * return then. */ - if (llist_empty(&paging_bts->pending_requests)) { - /* since the list is empty, no need to reschedule the timer */ + if (llist_empty(&paging_bts->initial_req_list) && + llist_empty(&paging_bts->retrans_req_list)) { + /* since the lists are empty, no need to reschedule the timer */ return; } osmo_clock_gettime(CLOCK_MONOTONIC, &now); paging_bts->last_sched_ts = now; - /* do while loop: Try send at most first MAX_PAGE_REQ_PER_ITER paging - * requests (or before if there are no more available slots). Since - * transmitted requests are re-appended at the end of the list, we check - * until we find the first req again, in order to avoid retransmitting - * repeated requests until next time paging is scheduled. */ - initial_request = llist_first_entry(&paging_bts->pending_requests, - struct gsm_paging_request, entry); - request = initial_request; - do { - /* We run out of available slots. Wait until next CCCH Load Ind - * arrives or credit_timer triggers to keep processing requests. - */ - if (paging_bts->available_slots == 0) { - LOG_PAGING_BTS(request, request->bts, DPAG, LOGL_INFO, - "Paging delayed: waiting for available slots at BTS\n"); - return; - } + num_paged_initial = step_page_initial_reqs(paging_bts, max_page_req_per_iter, &now, &work_done); + if (work_done) /* All work done for initial requests, work on retransmissions now: */ + num_paged_retrans = step_page_retrans_reqs(paging_bts, max_page_req_per_iter - num_paged_initial, &now); - /* we need to determine the number of free channels */ - if (paging_bts->free_chans_need != -1 && - can_send_pag_req(request->bts, request->chan_type) != 0) { - LOG_PAGING_BTS(request, request->bts, DPAG, LOGL_INFO, - "Paging delayed: not enough free channels (<%d)\n", - paging_bts->free_chans_need); - goto sched_next_iter; - } - - /* If we reach around back of the queue (retransmitions), check - * if time to retransmit has elapsed. Otherwise, wait until its - * time to retransmit. */ - if (request->attempts > 0) { - timespecadd(&request->last_attempt_ts, &retrans_period, &retrans_ts); - if (timespeccmp(&now, &retrans_ts, <)) { - struct timespec tdiff; - timespecsub(&retrans_ts, &now, &tdiff); - LOG_PAGING_BTS(request, request->bts, DPAG, LOGL_DEBUG, - "Paging delayed: retransmission happens in %lld.%06lds\n", - (long long)tdiff.tv_sec, tdiff.tv_nsec / 1000); - osmo_timer_schedule(&paging_bts->work_timer, tdiff.tv_sec, tdiff.tv_nsec / 1000); - return; - } - } - - /* handle the paging request now */ - page_ms(request); - paging_set_available_slots(bts, paging_bts->available_slots - 1); - request->last_attempt_ts = now; - request->attempts++; - num_paged++; - - llist_del(&request->entry); - llist_add_tail(&request->entry, &paging_bts->pending_requests); - request = llist_first_entry(&paging_bts->pending_requests, - struct gsm_paging_request, entry); - } while (request != initial_request && num_paged < MAX_PAGE_REQ_PER_ITER); - - /* Once done iterating, prepare next scheduling: */ -sched_next_iter: - LOG_BTS(bts, DPAG, LOGL_DEBUG, "Paged %u subscribers during last iteration. " - "Scheduling next batch in %lld.%06lds (available_slots=%u)\n", - num_paged, (long long)initial_period.tv_sec, initial_period.tv_nsec / 1000, - paging_bts->available_slots); - osmo_timer_schedule(&paging_bts->work_timer, initial_period.tv_sec, initial_period.tv_nsec / 1000); + LOG_BTS(paging_bts->bts, DPAG, LOGL_DEBUG, "Paged %u subscribers (%u initial, %u retrans) during last iteration\n", + num_paged_initial + num_paged_retrans, num_paged_initial, num_paged_retrans); } static void paging_worker(void *data) @@ -312,7 +401,8 @@ bts->paging.bts = bts; bts->paging.free_chans_need = -1; paging_set_available_slots(bts, 0); - INIT_LLIST_HEAD(&bts->paging.pending_requests); + INIT_LLIST_HEAD(&bts->paging.initial_req_list); + INIT_LLIST_HEAD(&bts->paging.retrans_req_list); osmo_timer_setup(&bts->paging.work_timer, paging_worker, &bts->paging); osmo_timer_setup(&bts->paging.credit_timer, paging_give_credit, &bts->paging); } @@ -410,7 +500,7 @@ static int _paging_request(const struct bsc_paging_params *params, struct gsm_bts *bts) { struct gsm_bts_paging_state *bts_entry = &bts->paging; - struct gsm_paging_request *req, *last_initial_req = NULL; + struct gsm_paging_request *req; unsigned int t3113_timeout_s; unsigned int x3113_s = osmo_tdef_get(bts->network->T_defs, -3113, OSMO_TDEF_S, -1); unsigned int reqs_before = 0, reqs_before_same_pgroup = 0; @@ -433,26 +523,20 @@ return -EEXIST; } - /* Find the last not-yet-ever-once-transmitted request; the new request - * will be added immediately after it, giving higher prio to initial - * transmissions (no retrans). This avoids new subscribers being paged to + /* The incoming new req will be stored in initial_req_list giving higher prio + * to it over retransmissions. This avoids new subscribers being paged to * be delayed if the paging queue is full due to a lot of retranmissions. * Retranmissions usually mean MS are not reachable/available, so the * rationale here is to prioritize new subs which may be available. + * + * Count initial reqs already stored in initial_req_list, since those + * will be scheduled for transmission before current incoming req and + need to be taken into account when calculating T3113 for it. */ - llist_for_each_entry(req, &bts_entry->pending_requests, entry) { - if (req->attempts == 0) { - /* Keep counting no-retransmits (general and per same pgroup): */ - last_initial_req = req; - reqs_before++; - if (req->pgroup == pgroup) - reqs_before_same_pgroup++; - continue; - } - /* Here first retransmit in queue is reached: last_initial_req points - * to last initial (non-retrans) req if there was any, NULL otherwise. - */ - break; + llist_for_each_entry(req, &bts_entry->initial_req_list, entry) { + reqs_before++; + if (req->pgroup == pgroup) + reqs_before_same_pgroup++; } LOG_PAGING_BTS(params, bts, DPAG, LOGL_DEBUG, "Start paging\n"); @@ -467,13 +551,9 @@ osmo_timer_setup(&req->T3113, paging_T3113_expired, req); bsc_subscr_add_active_paging_request(req->bsub, req); - bts_entry->pending_requests_len++; + bts_entry->initial_req_list_len++; osmo_stat_item_inc(osmo_stat_item_group_get_item(bts->bts_statg, BTS_STAT_PAGING_REQ_QUEUE_LENGTH), 1); - /* there's no initial req (attempts==0), add to the start of the list */ - if (last_initial_req == NULL) - llist_add(&req->entry, &bts_entry->pending_requests); - else/* Add in the middle of the list after last_initial_req */ - __llist_add(&req->entry, &last_initial_req->entry, last_initial_req->entry.next); + llist_add_tail(&req->entry, &bts_entry->initial_req_list); t3113_timeout_s = calculate_timer_3113(req, reqs_before, reqs_before_same_pgroup, x3113_s); osmo_timer_schedule(&req->T3113, t3113_timeout_s, 0); @@ -481,10 +561,10 @@ /* Trigger scheduler if needed: */ if (!osmo_timer_pending(&bts_entry->work_timer)) { paging_handle_pending_requests(bts_entry); - } else if (last_initial_req == NULL) { + } else if (bts_entry->initial_req_list_len == 1) { /* Worker timer is armed -> there was already one req before - * last_initial_req is NULL -> There were no initial requests in - * the list, aka the timer is waiting for retransmition, + * bts_entry->initial_req_list_len == 1 -> There were no initial requests + * in the list, aka the timer is waiting for retransmition, * which is a longer period. * Let's recaculate the time to adapt it to initial_period: */ struct timespec now, elapsed, tdiff; @@ -622,7 +702,7 @@ /*! Count the number of pending paging requests on given BTS */ unsigned int paging_pending_requests_nr(const struct gsm_bts *bts) { - return bts->paging.pending_requests_len; + return bts->paging.initial_req_list_len + bts->paging.retrans_req_list_len; } /*! Flush all paging requests at a given BTS for a given MSC (or NULL if all MSC should be flushed). */ @@ -630,14 +710,19 @@ { struct gsm_paging_request *req, *req2; int num_cancelled = 0; + int i; - llist_for_each_entry_safe(req, req2, &bts->paging.pending_requests, entry) { - if (msc && req->msc != msc) - continue; - /* now give up the data structure */ - LOG_PAGING_BTS(req, bts, DPAG, LOGL_DEBUG, "Stop paging (flush)\n"); - paging_remove_request(req); - num_cancelled++; + struct llist_head *lists[] = { &bts->paging.initial_req_list, &bts->paging.retrans_req_list }; + + for (i = 0; i < ARRAY_SIZE(lists); i++) { + llist_for_each_entry_safe(req, req2, lists[i], entry) { + if (msc && req->msc != msc) + continue; + /* now give up the data structure */ + LOG_PAGING_BTS(req, bts, DPAG, LOGL_DEBUG, "Stop paging (flush)\n"); + paging_remove_request(req); + num_cancelled++; + } } rate_ctr_add(rate_ctr_group_get_ctr(bts->bts_ctrs, BTS_CTR_PAGING_MSC_FLUSH), num_cancelled); diff --git a/tests/paging/paging_test.c b/tests/paging/paging_test.c index 679c851..80aaee1 100644 --- a/tests/paging/paging_test.c +++ b/tests/paging/paging_test.c @@ -142,7 +142,7 @@ clock_inc(0, nearest_ms*1000); clock_debug("select()"); osmo_select_main_ctx(0); - if (llist_empty(&bts->paging.pending_requests)) { + if (llist_empty(&bts->paging.initial_req_list) && llist_empty(&bts->paging.retrans_req_list)) { fprintf(stderr, "ERROR: some request timed out before being sent! %u\n", _sent_pg_cmd_rsl); OSMO_ASSERT(0); } @@ -174,7 +174,7 @@ clock_inc(0, nearest_ms*1000); clock_debug("select()"); osmo_select_main_ctx(0); - if (llist_empty(&bts->paging.pending_requests)) { + if (llist_empty(&bts->paging.initial_req_list) && llist_empty(&bts->paging.retrans_req_list)) { fprintf(stderr, "ERROR: some request timed out before being sent! %u\n", _sent_pg_cmd_rsl); OSMO_ASSERT(0); } @@ -208,7 +208,7 @@ clock_inc(0, nearest_ms*1000); clock_debug("select()"); osmo_select_main_ctx(0); - if (llist_empty(&bts->paging.pending_requests)) { + if (llist_empty(&bts->paging.initial_req_list) && llist_empty(&bts->paging.retrans_req_list)) { fprintf(stderr, "ERROR: some request timed out before being sent! %u\n", _sent_pg_cmd_rsl); OSMO_ASSERT(0); } diff --git a/tests/paging/paging_test.ok b/tests/paging/paging_test.ok index 52cddfe..93cb162 100644 --- a/tests/paging/paging_test.ok +++ b/tests/paging/paging_test.ok @@ -7,7 +7,8 @@ (msc=-1) Paging: subscr-IMSI-1234000000: (bts=0) Paging request: T3113 expires in 9 seconds (estimated 9) (msc=-1) Paging: subscr-IMSI-1234000000: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000000 -(bts=0) Paged 1 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=66) +(msc=-1) Paging: subscr-IMSI-1234000000: (bts=0) Paging delayed: retransmission happens in 0.500000s +(bts=0) Paged 1 subscribers (1 initial, 0 retrans) during last iteration (bts=0) Estimated 2039 paging available_slots over 60 seconds (msc=-1) Paging: subscr-IMSI-1234000001: (bts=0) Start paging (msc=-1) Paging: subscr-IMSI-1234000001: (bts=0) Paging request: T3113 expires in 9 seconds (estimated 9) @@ -1527,7 +1528,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000009 (msc=-1) Paging: subscr-IMSI-1234000010: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000010 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=56) +(bts=0) Scheduling next batch in 0.250000s (available_slots=56) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={0.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000011: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000011 @@ -1549,7 +1551,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000019 (msc=-1) Paging: subscr-IMSI-1234000020: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000020 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=46) +(bts=0) Scheduling next batch in 0.250000s (available_slots=46) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={0.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000021: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000021 @@ -1571,7 +1574,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000029 (msc=-1) Paging: subscr-IMSI-1234000030: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000030 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=36) +(bts=0) Scheduling next batch in 0.250000s (available_slots=36) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000031: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000031 @@ -1593,7 +1597,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000039 (msc=-1) Paging: subscr-IMSI-1234000040: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000040 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=26) +(bts=0) Scheduling next batch in 0.250000s (available_slots=26) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000041: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000041 @@ -1615,7 +1620,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000049 (msc=-1) Paging: subscr-IMSI-1234000050: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000050 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=16) +(bts=0) Scheduling next batch in 0.250000s (available_slots=16) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000051: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000051 @@ -1637,7 +1643,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000059 (msc=-1) Paging: subscr-IMSI-1234000060: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000060 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000061: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000061 @@ -1652,6 +1659,7 @@ (msc=-1) Paging: subscr-IMSI-1234000066: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000066 (msc=-1) Paging: subscr-IMSI-1234000067: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={2.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -1675,7 +1683,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000075 (msc=-1) Paging: subscr-IMSI-1234000076: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000076 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={2.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000077: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000077 @@ -1697,7 +1706,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000085 (msc=-1) Paging: subscr-IMSI-1234000086: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000086 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={2.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000087: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000087 @@ -1719,7 +1729,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000095 (msc=-1) Paging: subscr-IMSI-1234000096: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000096 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={2.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000097: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000097 @@ -1741,7 +1752,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000105 (msc=-1) Paging: subscr-IMSI-1234000106: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000106 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={3.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000107: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000107 @@ -1763,7 +1775,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000115 (msc=-1) Paging: subscr-IMSI-1234000116: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000116 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={3.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000117: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000117 @@ -1785,7 +1798,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000125 (msc=-1) Paging: subscr-IMSI-1234000126: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000126 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={3.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000127: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000127 @@ -1802,6 +1816,7 @@ (msc=-1) Paging: subscr-IMSI-1234000133: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000133 (msc=-1) Paging: subscr-IMSI-1234000134: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={4.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -1825,7 +1840,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000142 (msc=-1) Paging: subscr-IMSI-1234000143: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000143 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={4.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000144: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000144 @@ -1847,7 +1863,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000152 (msc=-1) Paging: subscr-IMSI-1234000153: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000153 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={4.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000154: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000154 @@ -1869,7 +1886,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000162 (msc=-1) Paging: subscr-IMSI-1234000163: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000163 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={4.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000164: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000164 @@ -1891,7 +1909,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000172 (msc=-1) Paging: subscr-IMSI-1234000173: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000173 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={5.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000174: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000174 @@ -1913,7 +1932,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000182 (msc=-1) Paging: subscr-IMSI-1234000183: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000183 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={5.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000184: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000184 @@ -1935,7 +1955,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000192 (msc=-1) Paging: subscr-IMSI-1234000193: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000193 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={5.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000194: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000194 @@ -1952,6 +1973,7 @@ (msc=-1) Paging: subscr-IMSI-1234000200: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000200 (msc=-1) Paging: subscr-IMSI-1234000201: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={6.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -1975,7 +1997,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000209 (msc=-1) Paging: subscr-IMSI-1234000210: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000210 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={6.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000211: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000211 @@ -1997,7 +2020,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000219 (msc=-1) Paging: subscr-IMSI-1234000220: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000220 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={6.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000221: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000221 @@ -2019,7 +2043,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000229 (msc=-1) Paging: subscr-IMSI-1234000230: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000230 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={6.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000231: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000231 @@ -2041,7 +2066,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000239 (msc=-1) Paging: subscr-IMSI-1234000240: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000240 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={7.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000241: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000241 @@ -2063,7 +2089,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000249 (msc=-1) Paging: subscr-IMSI-1234000250: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000250 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={7.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000251: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000251 @@ -2085,7 +2112,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000259 (msc=-1) Paging: subscr-IMSI-1234000260: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000260 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={7.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000261: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000261 @@ -2102,6 +2130,7 @@ (msc=-1) Paging: subscr-IMSI-1234000267: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000267 (msc=-1) Paging: subscr-IMSI-1234000268: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={8.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -2125,7 +2154,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000276 (msc=-1) Paging: subscr-IMSI-1234000277: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000277 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={8.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000278: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000278 @@ -2147,7 +2177,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000286 (msc=-1) Paging: subscr-IMSI-1234000287: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000287 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={8.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000288: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000288 @@ -2169,7 +2200,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000296 (msc=-1) Paging: subscr-IMSI-1234000297: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000297 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={8.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000298: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000298 @@ -2191,7 +2223,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000306 (msc=-1) Paging: subscr-IMSI-1234000307: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000307 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={9.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000308: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000308 @@ -2213,7 +2246,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000316 (msc=-1) Paging: subscr-IMSI-1234000317: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000317 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000015: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000014: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000013: (bts=0) T3113 expired @@ -2251,7 +2285,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000326 (msc=-1) Paging: subscr-IMSI-1234000327: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000327 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={9.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000328: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000328 @@ -2268,6 +2303,7 @@ (msc=-1) Paging: subscr-IMSI-1234000334: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000334 (msc=-1) Paging: subscr-IMSI-1234000335: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={10.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -2291,7 +2327,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000343 (msc=-1) Paging: subscr-IMSI-1234000344: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000344 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000042: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000041: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000040: (bts=0) T3113 expired @@ -2340,7 +2377,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000353 (msc=-1) Paging: subscr-IMSI-1234000354: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000354 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={10.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000355: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000355 @@ -2362,7 +2400,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000363 (msc=-1) Paging: subscr-IMSI-1234000364: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000364 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={10.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000365: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000365 @@ -2384,7 +2423,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000373 (msc=-1) Paging: subscr-IMSI-1234000374: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000374 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={11.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000375: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000375 @@ -2406,7 +2446,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000383 (msc=-1) Paging: subscr-IMSI-1234000384: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000384 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000076: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000075: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000074: (bts=0) T3113 expired @@ -2462,7 +2503,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000393 (msc=-1) Paging: subscr-IMSI-1234000394: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000394 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={11.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000395: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000395 @@ -2479,6 +2521,7 @@ (msc=-1) Paging: subscr-IMSI-1234000401: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000401 (msc=-1) Paging: subscr-IMSI-1234000402: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={12.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -2502,7 +2545,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000410 (msc=-1) Paging: subscr-IMSI-1234000411: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000411 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000111: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000110: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000109: (bts=0) T3113 expired @@ -2559,7 +2603,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000420 (msc=-1) Paging: subscr-IMSI-1234000421: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000421 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={12.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000422: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000422 @@ -2581,7 +2626,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000430 (msc=-1) Paging: subscr-IMSI-1234000431: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000431 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={12.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000432: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000432 @@ -2603,7 +2649,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000440 (msc=-1) Paging: subscr-IMSI-1234000441: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000441 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={13.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000442: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000442 @@ -2625,7 +2672,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000450 (msc=-1) Paging: subscr-IMSI-1234000451: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000451 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000146: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000145: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000144: (bts=0) T3113 expired @@ -2682,7 +2730,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000460 (msc=-1) Paging: subscr-IMSI-1234000461: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000461 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={13.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000462: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000462 @@ -2699,6 +2748,7 @@ (msc=-1) Paging: subscr-IMSI-1234000468: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000468 (msc=-1) Paging: subscr-IMSI-1234000469: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={14.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -2722,7 +2772,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000477 (msc=-1) Paging: subscr-IMSI-1234000478: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000478 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000181: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000180: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000179: (bts=0) T3113 expired @@ -2779,7 +2830,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000487 (msc=-1) Paging: subscr-IMSI-1234000488: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000488 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={14.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000489: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000489 @@ -2801,7 +2853,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000497 (msc=-1) Paging: subscr-IMSI-1234000498: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000498 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={14.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000499: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000499 @@ -2823,7 +2876,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000189 (msc=-1) Paging: subscr-IMSI-1234000190: (bts=0) Going to send paging command for ch. type 0 (attempt 1) abis_rsl_sendmsg: Paging CMD IMSI-1234000190 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (1 initial, 9 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000191: (bts=0) Stop paging (flush) (msc=-1) Paging: subscr-IMSI-1234000192: (bts=0) Stop paging (flush) (msc=-1) Paging: subscr-IMSI-1234000193: (bts=0) Stop paging (flush) @@ -3153,7 +3207,8 @@ (msc=-1) Paging: subscr-IMSI-123400000000: (bts=0) Paging request: T3113 expires in 9 seconds (estimated 9) (msc=-1) Paging: subscr-IMSI-123400000000: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400000000 -(bts=0) Paged 1 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=66) +(msc=-1) Paging: subscr-IMSI-123400000000: (bts=0) Paging delayed: retransmission happens in 0.500000s +(bts=0) Paged 1 subscribers (1 initial, 0 retrans) during last iteration (bts=0) Estimated 2039 paging available_slots over 60 seconds (msc=-1) Paging: subscr-IMSI-123400000040: (bts=0) Start paging (msc=-1) Paging: subscr-IMSI-123400000040: (bts=0) Paging request: T3113 expires in 9 seconds (estimated 9) @@ -4673,7 +4728,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400000360 (msc=-1) Paging: subscr-IMSI-123400000400: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400000400 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=56) +(bts=0) Scheduling next batch in 0.250000s (available_slots=56) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={0.500000}: select() (msc=-1) Paging: subscr-IMSI-123400000440: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400000440 @@ -4695,7 +4751,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400000760 (msc=-1) Paging: subscr-IMSI-123400000800: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400000800 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=46) +(bts=0) Scheduling next batch in 0.250000s (available_slots=46) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={0.750000}: select() (msc=-1) Paging: subscr-IMSI-123400000840: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400000840 @@ -4717,7 +4774,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400001160 (msc=-1) Paging: subscr-IMSI-123400001200: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400001200 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=36) +(bts=0) Scheduling next batch in 0.250000s (available_slots=36) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.000000}: select() (msc=-1) Paging: subscr-IMSI-123400001240: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400001240 @@ -4739,7 +4797,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400001560 (msc=-1) Paging: subscr-IMSI-123400001600: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400001600 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=26) +(bts=0) Scheduling next batch in 0.250000s (available_slots=26) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.250000}: select() (msc=-1) Paging: subscr-IMSI-123400001640: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400001640 @@ -4761,7 +4820,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400001960 (msc=-1) Paging: subscr-IMSI-123400002000: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400002000 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=16) +(bts=0) Scheduling next batch in 0.250000s (available_slots=16) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.500000}: select() (msc=-1) Paging: subscr-IMSI-123400002040: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400002040 @@ -4783,7 +4843,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400002360 (msc=-1) Paging: subscr-IMSI-123400002400: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400002400 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.750000}: select() (msc=-1) Paging: subscr-IMSI-123400002440: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400002440 @@ -4798,6 +4859,7 @@ (msc=-1) Paging: subscr-IMSI-123400002640: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400002640 (msc=-1) Paging: subscr-IMSI-123400002680: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={2.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -4821,7 +4883,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400003000 (msc=-1) Paging: subscr-IMSI-123400003040: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400003040 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={2.250000}: select() (msc=-1) Paging: subscr-IMSI-123400003080: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400003080 @@ -4843,7 +4906,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400003400 (msc=-1) Paging: subscr-IMSI-123400003440: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400003440 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={2.500000}: select() (msc=-1) Paging: subscr-IMSI-123400003480: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400003480 @@ -4865,7 +4929,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400003800 (msc=-1) Paging: subscr-IMSI-123400003840: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400003840 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={2.750000}: select() (msc=-1) Paging: subscr-IMSI-123400003880: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400003880 @@ -4887,7 +4952,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400004200 (msc=-1) Paging: subscr-IMSI-123400004240: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400004240 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={3.000000}: select() (msc=-1) Paging: subscr-IMSI-123400004280: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400004280 @@ -4909,7 +4975,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400004600 (msc=-1) Paging: subscr-IMSI-123400004640: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400004640 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={3.250000}: select() (msc=-1) Paging: subscr-IMSI-123400004680: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400004680 @@ -4931,7 +4998,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400005000 (msc=-1) Paging: subscr-IMSI-123400005040: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400005040 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={3.500000}: select() (msc=-1) Paging: subscr-IMSI-123400005080: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400005080 @@ -4948,6 +5016,7 @@ (msc=-1) Paging: subscr-IMSI-123400005320: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400005320 (msc=-1) Paging: subscr-IMSI-123400005360: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={4.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -4971,7 +5040,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400005680 (msc=-1) Paging: subscr-IMSI-123400005720: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400005720 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={4.250000}: select() (msc=-1) Paging: subscr-IMSI-123400005760: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400005760 @@ -4993,7 +5063,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400006080 (msc=-1) Paging: subscr-IMSI-123400006120: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400006120 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={4.500000}: select() (msc=-1) Paging: subscr-IMSI-123400006160: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400006160 @@ -5015,7 +5086,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400006480 (msc=-1) Paging: subscr-IMSI-123400006520: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400006520 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={4.750000}: select() (msc=-1) Paging: subscr-IMSI-123400006560: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400006560 @@ -5037,7 +5109,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400006880 (msc=-1) Paging: subscr-IMSI-123400006920: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400006920 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={5.000000}: select() (msc=-1) Paging: subscr-IMSI-123400006960: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400006960 @@ -5059,7 +5132,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400007280 (msc=-1) Paging: subscr-IMSI-123400007320: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400007320 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={5.250000}: select() (msc=-1) Paging: subscr-IMSI-123400007360: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400007360 @@ -5081,7 +5155,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400007680 (msc=-1) Paging: subscr-IMSI-123400007720: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400007720 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={5.500000}: select() (msc=-1) Paging: subscr-IMSI-123400007760: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400007760 @@ -5098,6 +5173,7 @@ (msc=-1) Paging: subscr-IMSI-123400008000: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400008000 (msc=-1) Paging: subscr-IMSI-123400008040: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={6.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -5121,7 +5197,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400008360 (msc=-1) Paging: subscr-IMSI-123400008400: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400008400 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={6.250000}: select() (msc=-1) Paging: subscr-IMSI-123400008440: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400008440 @@ -5143,7 +5220,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400008760 (msc=-1) Paging: subscr-IMSI-123400008800: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400008800 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={6.500000}: select() (msc=-1) Paging: subscr-IMSI-123400008840: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400008840 @@ -5165,7 +5243,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400009160 (msc=-1) Paging: subscr-IMSI-123400009200: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400009200 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={6.750000}: select() (msc=-1) Paging: subscr-IMSI-123400009240: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400009240 @@ -5187,7 +5266,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400009560 (msc=-1) Paging: subscr-IMSI-123400009600: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400009600 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={7.000000}: select() (msc=-1) Paging: subscr-IMSI-123400009640: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400009640 @@ -5209,7 +5289,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400009960 (msc=-1) Paging: subscr-IMSI-123400010000: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400010000 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={7.250000}: select() (msc=-1) Paging: subscr-IMSI-123400010040: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400010040 @@ -5231,7 +5312,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400010360 (msc=-1) Paging: subscr-IMSI-123400010400: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400010400 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={7.500000}: select() (msc=-1) Paging: subscr-IMSI-123400010440: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400010440 @@ -5248,6 +5330,7 @@ (msc=-1) Paging: subscr-IMSI-123400010680: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400010680 (msc=-1) Paging: subscr-IMSI-123400010720: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={8.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -5271,7 +5354,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400011040 (msc=-1) Paging: subscr-IMSI-123400011080: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400011080 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={8.250000}: select() (msc=-1) Paging: subscr-IMSI-123400011120: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400011120 @@ -5293,7 +5377,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400011440 (msc=-1) Paging: subscr-IMSI-123400011480: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400011480 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={8.500000}: select() (msc=-1) Paging: subscr-IMSI-123400011520: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400011520 @@ -5315,7 +5400,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400011840 (msc=-1) Paging: subscr-IMSI-123400011880: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400011880 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={8.750000}: select() (msc=-1) Paging: subscr-IMSI-123400011920: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400011920 @@ -5337,7 +5423,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400012240 (msc=-1) Paging: subscr-IMSI-123400012280: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400012280 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={9.000000}: select() (msc=-1) Paging: subscr-IMSI-123400012320: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400012320 @@ -5359,7 +5446,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400012640 (msc=-1) Paging: subscr-IMSI-123400012680: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400012680 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-123400000360: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-123400000320: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-123400000280: (bts=0) T3113 expired @@ -5391,7 +5479,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400013040 (msc=-1) Paging: subscr-IMSI-123400013080: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400013080 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={9.500000}: select() (msc=-1) Paging: subscr-IMSI-123400013120: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400013120 @@ -5408,6 +5497,7 @@ (msc=-1) Paging: subscr-IMSI-123400013360: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400013360 (msc=-1) Paging: subscr-IMSI-123400013400: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={10.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -5431,7 +5521,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400013720 (msc=-1) Paging: subscr-IMSI-123400013760: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400013760 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={10.250000}: select() (msc=-1) Paging: subscr-IMSI-123400013800: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400013800 @@ -5453,7 +5544,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400014120 (msc=-1) Paging: subscr-IMSI-123400014160: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400014160 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={10.500000}: select() (msc=-1) Paging: subscr-IMSI-123400014200: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400014200 @@ -5475,7 +5567,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400014520 (msc=-1) Paging: subscr-IMSI-123400014560: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400014560 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={10.750000}: select() (msc=-1) Paging: subscr-IMSI-123400014600: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400014600 @@ -5497,7 +5590,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400014920 (msc=-1) Paging: subscr-IMSI-123400014960: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400014960 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={11.000000}: select() (msc=-1) Paging: subscr-IMSI-123400015000: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400015000 @@ -5519,7 +5613,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400015320 (msc=-1) Paging: subscr-IMSI-123400015360: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400015360 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-123400000680: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-123400000640: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-123400000600: (bts=0) T3113 expired @@ -5549,7 +5644,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400015720 (msc=-1) Paging: subscr-IMSI-123400015760: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400015760 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={11.500000}: select() (msc=-1) Paging: subscr-IMSI-123400015800: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400015800 @@ -5566,6 +5662,7 @@ (msc=-1) Paging: subscr-IMSI-123400016040: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400016040 (msc=-1) Paging: subscr-IMSI-123400016080: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={12.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -5589,7 +5686,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400016400 (msc=-1) Paging: subscr-IMSI-123400016440: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400016440 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-123400001000: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-123400000960: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-123400000920: (bts=0) T3113 expired @@ -5619,7 +5717,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400016800 (msc=-1) Paging: subscr-IMSI-123400016840: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400016840 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={12.500000}: select() (msc=-1) Paging: subscr-IMSI-123400016880: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400016880 @@ -5641,7 +5740,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400017200 (msc=-1) Paging: subscr-IMSI-123400017240: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400017240 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={12.750000}: select() (msc=-1) Paging: subscr-IMSI-123400017280: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400017280 @@ -5663,7 +5763,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400017600 (msc=-1) Paging: subscr-IMSI-123400017640: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400017640 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={13.000000}: select() (msc=-1) Paging: subscr-IMSI-123400017680: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400017680 @@ -5685,7 +5786,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400018000 (msc=-1) Paging: subscr-IMSI-123400018040: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400018040 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Scheduling next batch in 0.250000s (available_slots=17) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={13.250000}: select() (msc=-1) Paging: subscr-IMSI-123400018080: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400018080 @@ -5707,7 +5809,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400018400 (msc=-1) Paging: subscr-IMSI-123400018440: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400018440 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Scheduling next batch in 0.250000s (available_slots=7) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={13.500000}: select() (msc=-1) Paging: subscr-IMSI-123400018480: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400018480 @@ -5724,6 +5827,7 @@ (msc=-1) Paging: subscr-IMSI-123400018720: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400018720 (msc=-1) Paging: subscr-IMSI-123400018760: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 7 subscribers (7 initial, 0 retrans) during last iteration sys={14.000000}: select() (bts=0) Estimated 67 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 67) @@ -5747,7 +5851,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400019080 (msc=-1) Paging: subscr-IMSI-123400019120: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400019120 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Scheduling next batch in 0.250000s (available_slots=57) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-123400001320: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-123400001280: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-123400001240: (bts=0) T3113 expired @@ -5777,7 +5882,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400019480 (msc=-1) Paging: subscr-IMSI-123400019520: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400019520 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Scheduling next batch in 0.250000s (available_slots=47) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={14.500000}: select() (msc=-1) Paging: subscr-IMSI-123400019560: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400019560 @@ -5799,7 +5905,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400019880 (msc=-1) Paging: subscr-IMSI-123400019920: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400019920 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Scheduling next batch in 0.250000s (available_slots=37) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={14.750000}: select() (msc=-1) Paging: subscr-IMSI-123400019960: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-123400019960 @@ -5821,7 +5928,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-123400001640 (msc=-1) Paging: subscr-IMSI-123400001680: (bts=0) Going to send paging command for ch. type 0 (attempt 1) abis_rsl_sendmsg: Paging CMD IMSI-123400001680 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Scheduling next batch in 0.250000s (available_slots=27) +(bts=0) Paged 10 subscribers (1 initial, 9 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-123400001720: (bts=0) Stop paging (flush) (msc=-1) Paging: subscr-IMSI-123400001760: (bts=0) Stop paging (flush) (msc=-1) Paging: subscr-IMSI-123400001800: (bts=0) Stop paging (flush) @@ -6298,7 +6406,8 @@ (msc=-1) Paging: subscr-IMSI-1234000000: (bts=0) Paging request: T3113 expires in 9 seconds (estimated 9) (msc=-1) Paging: subscr-IMSI-1234000000: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000000 -(bts=0) Paged 1 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=66) +(msc=-1) Paging: subscr-IMSI-1234000000: (bts=0) Paging delayed: retransmission happens in 0.500000s +(bts=0) Paged 1 subscribers (1 initial, 0 retrans) during last iteration (bts=0) Estimated 509 paging available_slots over 60 seconds (msc=-1) Paging: subscr-IMSI-1234000001: (bts=0) Start paging (msc=-1) Paging: subscr-IMSI-1234000001: (bts=0) Paging request: T3113 expires in 9 seconds (estimated 9) @@ -7818,7 +7927,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000009 (msc=-1) Paging: subscr-IMSI-1234000010: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000010 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=56) +(bts=0) Scheduling next batch in 0.250000s (available_slots=56) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={0.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000011: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000011 @@ -7840,7 +7950,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000019 (msc=-1) Paging: subscr-IMSI-1234000020: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000020 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=46) +(bts=0) Scheduling next batch in 0.250000s (available_slots=46) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={0.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000021: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000021 @@ -7862,7 +7973,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000029 (msc=-1) Paging: subscr-IMSI-1234000030: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000030 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=36) +(bts=0) Scheduling next batch in 0.250000s (available_slots=36) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000031: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000031 @@ -7884,7 +7996,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000039 (msc=-1) Paging: subscr-IMSI-1234000040: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000040 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=26) +(bts=0) Scheduling next batch in 0.250000s (available_slots=26) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000041: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000041 @@ -7906,7 +8019,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000049 (msc=-1) Paging: subscr-IMSI-1234000050: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000050 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=16) +(bts=0) Scheduling next batch in 0.250000s (available_slots=16) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.500000}: select() (msc=-1) Paging: subscr-IMSI-1234000051: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000051 @@ -7928,7 +8042,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000059 (msc=-1) Paging: subscr-IMSI-1234000060: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000060 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={1.750000}: select() (msc=-1) Paging: subscr-IMSI-1234000061: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000061 @@ -7943,6 +8058,7 @@ (msc=-1) Paging: subscr-IMSI-1234000066: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000066 (msc=-1) Paging: subscr-IMSI-1234000067: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={2.000000}: select() (bts=0) Estimated 16 paging available_slots over 2 seconds (bts=0) Timeout waiting for CCCH Load Indication, assuming BTS is below Load Threshold (available_slots 0 -> 16) @@ -7966,7 +8082,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000075 (msc=-1) Paging: subscr-IMSI-1234000076: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000076 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={2.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000077: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000077 @@ -7981,6 +8098,7 @@ (msc=-1) Paging: subscr-IMSI-1234000082: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000082 (msc=-1) Paging: subscr-IMSI-1234000083: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={3.1000000}: select() sys={4.000000}: select() (bts=0) Estimated 16 paging available_slots over 2 seconds @@ -8005,7 +8123,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000091 (msc=-1) Paging: subscr-IMSI-1234000092: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000092 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={4.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000093: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000093 @@ -8020,6 +8139,7 @@ (msc=-1) Paging: subscr-IMSI-1234000098: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000098 (msc=-1) Paging: subscr-IMSI-1234000099: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={5.1000000}: select() sys={6.000000}: select() (bts=0) Estimated 16 paging available_slots over 2 seconds @@ -8044,7 +8164,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000107 (msc=-1) Paging: subscr-IMSI-1234000108: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000108 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={6.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000109: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000109 @@ -8059,6 +8180,7 @@ (msc=-1) Paging: subscr-IMSI-1234000114: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000114 (msc=-1) Paging: subscr-IMSI-1234000115: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={7.1000000}: select() sys={8.000000}: select() (bts=0) Estimated 16 paging available_slots over 2 seconds @@ -8083,7 +8205,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000123 (msc=-1) Paging: subscr-IMSI-1234000124: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000124 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={8.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000125: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000125 @@ -8098,6 +8221,7 @@ (msc=-1) Paging: subscr-IMSI-1234000130: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000130 (msc=-1) Paging: subscr-IMSI-1234000131: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={9.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000004: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000003: (bts=0) T3113 expired @@ -8127,7 +8251,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000139 (msc=-1) Paging: subscr-IMSI-1234000140: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000140 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000012: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000011: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000010: (bts=0) T3113 expired @@ -8150,6 +8275,7 @@ (msc=-1) Paging: subscr-IMSI-1234000146: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000146 (msc=-1) Paging: subscr-IMSI-1234000147: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={11.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000021: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000020: (bts=0) T3113 expired @@ -8183,7 +8309,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000155 (msc=-1) Paging: subscr-IMSI-1234000156: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000156 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000030: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000029: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000028: (bts=0) T3113 expired @@ -8207,6 +8334,7 @@ (msc=-1) Paging: subscr-IMSI-1234000162: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000162 (msc=-1) Paging: subscr-IMSI-1234000163: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={13.1000000}: select() sys={14.000000}: select() (bts=0) Estimated 16 paging available_slots over 2 seconds @@ -8231,7 +8359,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000171 (msc=-1) Paging: subscr-IMSI-1234000172: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000172 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000036: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000035: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000034: (bts=0) T3113 expired @@ -8252,6 +8381,7 @@ (msc=-1) Paging: subscr-IMSI-1234000178: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000178 (msc=-1) Paging: subscr-IMSI-1234000179: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={15.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000045: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000044: (bts=0) T3113 expired @@ -8285,7 +8415,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000187 (msc=-1) Paging: subscr-IMSI-1234000188: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000188 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000050: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000049: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000048: (bts=0) T3113 expired @@ -8305,6 +8436,7 @@ (msc=-1) Paging: subscr-IMSI-1234000194: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000194 (msc=-1) Paging: subscr-IMSI-1234000195: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={17.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000051: (bts=0) T3113 expired sys={18.000000}: select() @@ -8330,7 +8462,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000203 (msc=-1) Paging: subscr-IMSI-1234000204: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000204 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000061: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000060: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000059: (bts=0) T3113 expired @@ -8355,6 +8488,7 @@ (msc=-1) Paging: subscr-IMSI-1234000210: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000210 (msc=-1) Paging: subscr-IMSI-1234000211: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={19.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000069: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000068: (bts=0) T3113 expired @@ -8387,7 +8521,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000219 (msc=-1) Paging: subscr-IMSI-1234000220: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000220 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000070: (bts=0) T3113 expired sys={20.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000221: (bts=0) Going to send paging command for ch. type 0 (attempt 0) @@ -8403,6 +8538,7 @@ (msc=-1) Paging: subscr-IMSI-1234000226: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000226 (msc=-1) Paging: subscr-IMSI-1234000227: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={21.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000075: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000074: (bts=0) T3113 expired @@ -8432,7 +8568,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000235 (msc=-1) Paging: subscr-IMSI-1234000236: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000236 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000085: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000084: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000083: (bts=0) T3113 expired @@ -8457,6 +8594,7 @@ (msc=-1) Paging: subscr-IMSI-1234000242: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000242 (msc=-1) Paging: subscr-IMSI-1234000243: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={23.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000090: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000089: (bts=0) T3113 expired @@ -8486,7 +8624,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000251 (msc=-1) Paging: subscr-IMSI-1234000252: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000252 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000091: (bts=0) T3113 expired sys={24.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000253: (bts=0) Going to send paging command for ch. type 0 (attempt 0) @@ -8502,6 +8641,7 @@ (msc=-1) Paging: subscr-IMSI-1234000258: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000258 (msc=-1) Paging: subscr-IMSI-1234000259: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={25.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000099: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000098: (bts=0) T3113 expired @@ -8534,7 +8674,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000267 (msc=-1) Paging: subscr-IMSI-1234000268: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000268 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000109: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000108: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000107: (bts=0) T3113 expired @@ -8559,6 +8700,7 @@ (msc=-1) Paging: subscr-IMSI-1234000274: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000274 (msc=-1) Paging: subscr-IMSI-1234000275: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={27.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000110: (bts=0) T3113 expired sys={28.000000}: select() @@ -8584,7 +8726,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000283 (msc=-1) Paging: subscr-IMSI-1234000284: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000284 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000115: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000114: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000113: (bts=0) T3113 expired @@ -8604,6 +8747,7 @@ (msc=-1) Paging: subscr-IMSI-1234000290: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000290 (msc=-1) Paging: subscr-IMSI-1234000291: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={29.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000124: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000123: (bts=0) T3113 expired @@ -8637,7 +8781,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000299 (msc=-1) Paging: subscr-IMSI-1234000300: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000300 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000130: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000129: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000128: (bts=0) T3113 expired @@ -8658,6 +8803,7 @@ (msc=-1) Paging: subscr-IMSI-1234000306: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000306 (msc=-1) Paging: subscr-IMSI-1234000307: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={31.000000}: select() sys={32.000000}: select() (bts=0) Estimated 16 paging available_slots over 2 seconds @@ -8682,7 +8828,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000315 (msc=-1) Paging: subscr-IMSI-1234000316: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000316 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000139: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000138: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000137: (bts=0) T3113 expired @@ -8706,6 +8853,7 @@ (msc=-1) Paging: subscr-IMSI-1234000322: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000322 (msc=-1) Paging: subscr-IMSI-1234000323: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={33.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000148: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000147: (bts=0) T3113 expired @@ -8739,7 +8887,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000331 (msc=-1) Paging: subscr-IMSI-1234000332: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000332 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000150: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000149: (bts=0) T3113 expired sys={34.250000}: select() @@ -8756,6 +8905,7 @@ (msc=-1) Paging: subscr-IMSI-1234000338: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000338 (msc=-1) Paging: subscr-IMSI-1234000339: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={35.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000154: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000153: (bts=0) T3113 expired @@ -8784,7 +8934,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000347 (msc=-1) Paging: subscr-IMSI-1234000348: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000348 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000164: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000163: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000162: (bts=0) T3113 expired @@ -8809,6 +8960,7 @@ (msc=-1) Paging: subscr-IMSI-1234000354: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000354 (msc=-1) Paging: subscr-IMSI-1234000355: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={37.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000170: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000169: (bts=0) T3113 expired @@ -8839,7 +8991,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000363 (msc=-1) Paging: subscr-IMSI-1234000364: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000364 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={38.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000365: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000365 @@ -8854,6 +9007,7 @@ (msc=-1) Paging: subscr-IMSI-1234000370: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000370 (msc=-1) Paging: subscr-IMSI-1234000371: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={39.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000178: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000177: (bts=0) T3113 expired @@ -8886,7 +9040,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000379 (msc=-1) Paging: subscr-IMSI-1234000380: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000380 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000188: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000187: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000186: (bts=0) T3113 expired @@ -8911,6 +9066,7 @@ (msc=-1) Paging: subscr-IMSI-1234000386: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000386 (msc=-1) Paging: subscr-IMSI-1234000387: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={41.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000190: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000189: (bts=0) T3113 expired @@ -8937,7 +9093,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000395 (msc=-1) Paging: subscr-IMSI-1234000396: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000396 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000194: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000193: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000192: (bts=0) T3113 expired @@ -8956,6 +9113,7 @@ (msc=-1) Paging: subscr-IMSI-1234000402: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000402 (msc=-1) Paging: subscr-IMSI-1234000403: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={43.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000203: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000202: (bts=0) T3113 expired @@ -8989,7 +9147,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000411 (msc=-1) Paging: subscr-IMSI-1234000412: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000412 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000210: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000209: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000208: (bts=0) T3113 expired @@ -9011,6 +9170,7 @@ (msc=-1) Paging: subscr-IMSI-1234000418: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000418 (msc=-1) Paging: subscr-IMSI-1234000419: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={45.000000}: select() sys={46.000000}: select() (bts=0) Estimated 16 paging available_slots over 2 seconds @@ -9035,7 +9195,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000427 (msc=-1) Paging: subscr-IMSI-1234000428: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000428 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000218: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000217: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000216: (bts=0) T3113 expired @@ -9058,6 +9219,7 @@ (msc=-1) Paging: subscr-IMSI-1234000434: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000434 (msc=-1) Paging: subscr-IMSI-1234000435: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={47.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000227: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000226: (bts=0) T3113 expired @@ -9091,7 +9253,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000443 (msc=-1) Paging: subscr-IMSI-1234000444: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000444 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000230: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000229: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000228: (bts=0) T3113 expired @@ -9109,6 +9272,7 @@ (msc=-1) Paging: subscr-IMSI-1234000450: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000450 (msc=-1) Paging: subscr-IMSI-1234000451: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={49.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000233: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000232: (bts=0) T3113 expired @@ -9136,7 +9300,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000459 (msc=-1) Paging: subscr-IMSI-1234000460: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000460 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000243: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000242: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000241: (bts=0) T3113 expired @@ -9161,6 +9326,7 @@ (msc=-1) Paging: subscr-IMSI-1234000466: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000466 (msc=-1) Paging: subscr-IMSI-1234000467: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={51.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000250: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000249: (bts=0) T3113 expired @@ -9192,7 +9358,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000475 (msc=-1) Paging: subscr-IMSI-1234000476: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000476 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration sys={52.250000}: select() (msc=-1) Paging: subscr-IMSI-1234000477: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000477 @@ -9207,6 +9374,7 @@ (msc=-1) Paging: subscr-IMSI-1234000482: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000482 (msc=-1) Paging: subscr-IMSI-1234000483: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={53.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000257: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000256: (bts=0) T3113 expired @@ -9238,7 +9406,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000491 (msc=-1) Paging: subscr-IMSI-1234000492: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000492 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (10 initial, 0 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000267: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000266: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000265: (bts=0) T3113 expired @@ -9263,6 +9432,7 @@ (msc=-1) Paging: subscr-IMSI-1234000498: (bts=0) Going to send paging command for ch. type 0 (attempt 0) abis_rsl_sendmsg: Paging CMD IMSI-1234000498 (msc=-1) Paging: subscr-IMSI-1234000499: (bts=0) Paging delayed: waiting for available slots at BTS +(bts=0) Paged 6 subscribers (6 initial, 0 retrans) during last iteration sys={55.000000}: select() (msc=-1) Paging: subscr-IMSI-1234000270: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000269: (bts=0) T3113 expired @@ -9290,7 +9460,8 @@ abis_rsl_sendmsg: Paging CMD IMSI-1234000278 (msc=-1) Paging: subscr-IMSI-1234000279: (bts=0) Going to send paging command for ch. type 0 (attempt 1) abis_rsl_sendmsg: Paging CMD IMSI-1234000279 -(bts=0) Paged 10 subscribers during last iteration. Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Scheduling next batch in 0.250000s (available_slots=6) +(bts=0) Paged 10 subscribers (1 initial, 9 retrans) during last iteration (msc=-1) Paging: subscr-IMSI-1234000273: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000272: (bts=0) T3113 expired (msc=-1) Paging: subscr-IMSI-1234000271: (bts=0) T3113 expired -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: ms-trx support

by fixeria

Attention is currently required from: Hoernchen, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30416 ) Change subject: ms-trx support ...................................................................... Patch Set 3: (21 comments) File Transceiver52M/ms/ms_upper.h: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/de8e74a6_3a259a08 PS3, Line 1: ws https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/0a302518_73cc4d5c PS3, Line 36: trx_if do you really need/use TRXC/TRXD here? File Transceiver52M/ms/ms_upper.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32a010d7_8a17baca PS3, Line 61: #include <osmocom/core/gsmtap_util.h> you're not using GSMTAP API here... https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/226cc199_31255475 PS3, Line 64: // #include <osmocom/core/application.h> removeme https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/93fc1081_e6a4c799 PS3, Line 71: trx_if do you really need/use TRXC/TRXD here? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/fef1b6b3_90d5b9f3 PS3, Line 74: #include <osmocom/bb/l1sched/l1sched.h> I don't see any l1sched_* API used in this file. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/7aa85f32_4e0185b4 PS3, Line 177: return trash can you clarify this a bit further? thrash? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/8b6afa5b_a3a7daf3 PS3, Line 184: RSSI = 10 why 10? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3aeccd0b_dd0bd268 PS3, Line 223: timingOffset = (int)round(0); TODO/FIXME? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/164d3c60_0da5723e PS3, Line 238: trx_data_rx_handler removeme https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3f5c1c4f_7ee4a937 PS3, Line 246: trxcon_phyif_handle_clock_ind removeme https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/d43344cf_b38b007c PS3, Line 304: case trxcon::TRXCON_PHYIF_CMDT_RESET Better use value-string for that. Ideally such a value string should be part of libtrxcon, so it's always in sync with the TRXCON_PHYIF_CMDT_* values. https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/2faadf5a_771fc6f7 PS3, Line 352: set_ta Shouldn't this be done on receipt of TRXCON_PHYIF_CMDT_RESET instead? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/86b41add_7e99a70e PS3, Line 357: dbm = -80 please add a FIXME or TODO, so it's clear that the measurement logic is missing https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/3d17174c_41e5bdcd PS3, Line 364: gsm_arfcn2freq10 careful, this function may return 0xffff https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/76523f1d_1714766d PS3, Line 385: assert OSMO_ASSERT? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/32cb86c8_4b13670b PS3, Line 425: trxcon it's not trxcon app anymore https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/46c73659_9bc25e02 PS3, Line 429: 3 pass 0 to avoid confusion, we're not using fn_advance here https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/17f43833_0f042a41 PS3, Line 430: gsmtap = 0; gsmtap is a pointer, so = NULL https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/f9efc989_1a4b0ef7 PS3, Line 431: 0x1234 What's this? Why not NULL? https://gerrit.osmocom.org/c/osmo-trx/+/30416/comment/31d216f3_ce23d1ec PS3, Line 433: trxc I would avoid using 'trxc' here to avoid confusion with the TRXC protocol. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 14:08:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: vty: Write amount of timeouts elapsed for a paging request

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30402 ) Change subject: vty: Write amount of timeouts elapsed for a paging request ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a Gerrit-Change-Number: 30402 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:44:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Optimize retrieving number of request per paging group

by laforge

Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30370 ) Change subject: paging: Optimize retrieving number of request per paging group ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531 Gerrit-Change-Number: 30370 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:44:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Replace reqs waiting for retransmission with new incoming ini...

by laforge

Attention is currently required from: neels, pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30347 ) Change subject: paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d Gerrit-Change-Number: 30347 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:43:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Split paging queue into 2 queues: initial and retrans

by laforge

Attention is currently required from: pespin, daniel. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30363 ) Change subject: paging: Split paging queue into 2 queues: initial and retrans ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30363/comment/fdf6f1dc_453418b5 PS1, Line 1045: static void paging_dump_vty(struct vty *vty, struct gsm_paging_request *pag) : { : vty_out(vty, "Paging on BTS %u%s", pag->bts->nr, VTY_NEWLINE); : bsc_subscr_dump_vty(vty, pag->bsub); : } : : static void bts_paging_dump_vty(struct vty *vty, struct gsm_bts *bts) : { : struct gsm_paging_request *pag; : : llist_for_each_entry(pag, &bts->paging.initial_req_list, entry) : paging_dump_vty(vty, pag); : llist_for_each_entry(pag, &bts->paging.retrans_req_list, entry) : paging_dump_vty(vty, pag); > Will be submitted as Change-ID I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30363 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib68f2169e3790aea4ac77ec20ad79f242b7c2747 Gerrit-Change-Number: 30363 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:42:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: vty: Write amount of timeouts elapsed for a paging request

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30402 ) Change subject: vty: Write amount of timeouts elapsed for a paging request ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30402 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55c84c0d20fc4120b7b4cdd06ed95a8847a6600a Gerrit-Change-Number: 30402 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:41:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Optimize retrieving number of request per paging group

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30370 ) Change subject: paging: Optimize retrieving number of request per paging group ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30370 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6994127827d120a0b4dd3de51e1ddde39f2fe531 Gerrit-Change-Number: 30370 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:41:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: osmocom-bb for ms-trx side trxcon integration

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30412 ) Change subject: osmocom-bb for ms-trx side trxcon integration ...................................................................... osmocom-bb for ms-trx side trxcon integration Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61 --- A .gitmodules A osmocom-bb 2 files changed, 5 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved diff --git a/.gitmodules b/.gitmodules new file mode 100644 index 0000000..bc94e80 --- /dev/null +++ b/.gitmodules @@ -0,0 +1,4 @@ +[submodule "osmocom-bb"] + path = osmocom-bb + url = https://gitea.osmocom.org/phone-side/osmocom-bb.git + branch = a4aac5c3554559c2c994609f90b92a9daf6e8a89 diff --git a/osmocom-bb b/osmocom-bb new file mode 160000 index 0000000..a4aac5c --- /dev/null +++ b/osmocom-bb @@ -0,0 +1 @@ +Subproject commit a4aac5c3554559c2c994609f90b92a9daf6e8a89 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61 Gerrit-Change-Number: 30412 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible/coverity: extract into subdirectory

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30418 ) Change subject: ansible/coverity: extract into subdirectory ...................................................................... ansible/coverity: extract into subdirectory The tarball provided by coverity doesn't have the same version in the name as in the directory inside the tarball. Tarball: cov-analysis-linux64-2022.06.tar.gz Directory: cov-analysis-linux64-2022.6.0 Work around this by extracting it into a subdirectory and using glob to match the directory name. Related: OS#5793 Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b --- M ansible/roles/install-coverity/tasks/main.yml 1 file changed, 7 insertions(+), 8 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/roles/install-coverity/tasks/main.yml b/ansible/roles/install-coverity/tasks/main.yml index 5baf6f3..4047fb8 100644 --- a/ansible/roles/install-coverity/tasks/main.yml +++ b/ansible/roles/install-coverity/tasks/main.yml @@ -13,9 +13,9 @@ ignore_errors: yes tags: [coverity] -- name: create /opt/coverity +- name: create /opt/coverity/{{ coverity_version }}/ file: - path: /opt/coverity/ + path: /opt/coverity/{{ coverity_version }}/ state: directory when: coverity_copy.failed == False tags: [coverity] @@ -23,16 +23,15 @@ - name: unpack coverity unarchive: src: "/tmp/{{ coverity_installer_file }}" - dest: /opt/coverity/ + dest: /opt/coverity/{{ coverity_version }} remote_src: yes when: coverity_copy.failed == False tags: [coverity] -- name: create link /opt/coverity/last - file: - src: /opt/coverity/cov-analysis-linux64-{{ coverity_version }} - dest: /opt/coverity/current - state: link +- name: create link /opt/coverity/current + shell: ln -sf /opt/coverity/{{ coverity_version }}/* /opt/coverity/current + args: + warn: false when: coverity_copy.failed == False tags: [coverity] -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b Gerrit-Change-Number: 30418 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: hosts: update coverity-slaves

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30419 ) Change subject: hosts: update coverity-slaves ...................................................................... hosts: update coverity-slaves Remove the deb9 lxcs as they are being retired, and add two deb11 lxcs. Coverity is quite big with 1.2 GiB, so deploying and upgrading this takes some time. Having it on two hosts should be enough. Related: OS#5793 Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0 --- M ansible/hosts 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/hosts b/ansible/hosts index e1756be..cc19dfe 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -3,9 +3,8 @@ osmo-gsm-tester-prod ansible_host=10.9.25.107 [coverity-slaves] -admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 -build2-deb9build-ansible ansible_host=2a01:4f8:10b:2ad9::1:6 -host2-deb9build-ansible ansible_host=2a01:4f8:120:8470::1:3 +build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 +build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 [jenkins-slaves] admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 osmocom_jenkins_slave_fstrim=True -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0 Gerrit-Change-Number: 30419 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: coverity: update version to 22.06

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30417 ) Change subject: ansible: coverity: update version to 22.06 ...................................................................... ansible: coverity: update version to 22.06 Coverity doesn't make the old version available for download and will probably deprecate the previous version at some point. I'm about to install it on new hosts, so upgrade to the latest version while at it. Related: OS#5793 Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4 --- M ansible/roles/install-coverity/defaults/main.yml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/roles/install-coverity/defaults/main.yml b/ansible/roles/install-coverity/defaults/main.yml index d7a8082..4a74887 100644 --- a/ansible/roles/install-coverity/defaults/main.yml +++ b/ansible/roles/install-coverity/defaults/main.yml @@ -1,4 +1,4 @@ --- -coverity_version: 2021.12.1 +coverity_version: 2022.06 coverity_installer_file: "cov-analysis-linux64-{{ coverity_version }}.tar.gz" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4 Gerrit-Change-Number: 30417 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: osmocom-bb for ms-trx side trxcon integration

by Hoernchen

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30412 ) Change subject: osmocom-bb for ms-trx side trxcon integration ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61 Gerrit-Change-Number: 30412 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:40:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: hosts: update coverity-slaves

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30419 ) Change subject: hosts: update coverity-slaves ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30419 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I02d43d7cbdbcba5581aa5da0a1effa3db7b445c0 Gerrit-Change-Number: 30419 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:40:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible/coverity: extract into subdirectory

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30418 ) Change subject: ansible/coverity: extract into subdirectory ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30418 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I2b96d1e47f2697706a042937b2852f0fc5032a7b Gerrit-Change-Number: 30418 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:39:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-ci[master]: ansible: coverity: update version to 22.06

by laforge

Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30417 ) Change subject: ansible: coverity: update version to 22.06 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30417 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id5700a9e5a46a9cfafc9959f5b77f9e21dd956b4 Gerrit-Change-Number: 30417 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:39:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-bsc[master]: paging: Replace reqs waiting for retransmission with new incoming ini...

by osmith

Attention is currently required from: neels, pespin, daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/30347 ) Change subject: paging: Replace reqs waiting for retransmission with new incoming inital req if queue is full ...................................................................... Patch Set 7: Code-Review+1 (4 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/f1ad7abe_4ec1b831 PS1, Line 14: is it > . Done https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/eee93fdb_04989c7f PS1, Line 16: than > that Done Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/7ac40bf1_4584e3e7 PS7, Line 22: OS SYS File src/osmo-bsc/net_init.c: https://gerrit.osmocom.org/c/osmo-bsc/+/30347/comment/c0de5a73_cd6ef2d4 PS6, Line 81: random > Maybe just remove "random" here completely? I was looking through the code to find the call to rand […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/30347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Idfd93254ae456b1ee08416e05479488299dd063d Gerrit-Change-Number: 30347 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:35:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: bladerf xa4 support

by Hoernchen

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30413 ) Change subject: bladerf xa4 support ...................................................................... Patch Set 1: (1 comment) File Transceiver52M/device/bladerf/bladerf.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30413/comment/5e0da52d_be86a1c5 PS1, Line 432: // Initialize and shadow gain values > use comment style: /* */ The file is literally copypasted from the b210 code and those comments are useless anyway... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30413 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I455c34bb9520d5f09eeb1ac76fceb4bdea94d1ac Gerrit-Change-Number: 30413 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:34:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: ill-fated ipcv2 for mstrx

by Hoernchen

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30414 ) Change subject: ill-fated ipcv2 for mstrx ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > so the outcome is that this is actually not going to be used for now? […] Oh i am fine with dropping it and leaving it in a branch. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30414 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I8f582c7c06fed8d1dcc5ea52472a97dc313fdde5 Gerrit-Change-Number: 30414 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:31:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: osmocom-bb for ms-trx side trxcon integration

by Hoernchen

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30412 ) Change subject: osmocom-bb for ms-trx side trxcon integration ...................................................................... Patch Set 1: (1 comment) File .gitmodules: https://gerrit.osmocom.org/c/osmo-trx/+/30412/comment/d85ef2a6_6f76820a PS1, Line 4: branch = a4aac5c3554559c2c994609f90b92a9daf6e8a89 > I wonder shouldn't this be set to track master in general? We can adjust it at any time, but right now I'd rather have a known working version. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30412 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I784a3d66b68f6458056d92db2ec596755b704e61 Gerrit-Change-Number: 30412 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 01 Dec 2022 13:29:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: rename noisevector class -> avgvector

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30411 ) Change subject: rename noisevector class -> avgvector ...................................................................... rename noisevector class -> avgvector The vectors feature is averaging, and not adding noise. Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927 --- M Transceiver52M/Transceiver.h M Transceiver52M/radioVector.cpp M Transceiver52M/radioVector.h 3 files changed, 9 insertions(+), 6 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve; Verified fixeria: Looks good to me, approved diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h index 45a4159..0389e60 100644 --- a/Transceiver52M/Transceiver.h +++ b/Transceiver52M/Transceiver.h @@ -80,7 +80,7 @@ /* Received noise energy levels */ float mNoiseLev; - noiseVector mNoises; + avgVector mNoises; /* Shadowed downlink attenuation */ int mPower; diff --git a/Transceiver52M/radioVector.cpp b/Transceiver52M/radioVector.cpp index 68e42c5..acefc97 100644 --- a/Transceiver52M/radioVector.cpp +++ b/Transceiver52M/radioVector.cpp @@ -76,22 +76,25 @@ return true; } -noiseVector::noiseVector(size_t size) +avgVector::avgVector(size_t size) : std::vector<float>(size), itr(0) { } -float noiseVector::avg() const +float avgVector::avg() const { float val = 0.0; + if (!size()) + return 0.0f; + for (size_t i = 0; i < size(); i++) val += (*this)[i]; return val / (float) size(); } -bool noiseVector::insert(float val) +bool avgVector::insert(float val) { if (!size()) return false; diff --git a/Transceiver52M/radioVector.h b/Transceiver52M/radioVector.h index 84e3987..90db626 100644 --- a/Transceiver52M/radioVector.h +++ b/Transceiver52M/radioVector.h @@ -48,9 +48,9 @@ GSM::Time mTime; }; -class noiseVector : std::vector<float> { +class avgVector : std::vector<float> { public: - noiseVector(size_t size = 0); + avgVector(size_t size = 0); bool insert(float val); float avg() const; -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30411 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I05def8ab9ea7a2cece8db09c36c303e13ef40927 Gerrit-Change-Number: 30411 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

Change in osmo-trx[master]: ignore vscode dirs

by Hoernchen

Hoernchen has submitted this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30410 ) Change subject: ignore vscode dirs ...................................................................... ignore vscode dirs Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c --- M .gitignore 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve Hoernchen: Looks good to me, approved diff --git a/.gitignore b/.gitignore index fec8fab..74e1d00 100644 --- a/.gitignore +++ b/.gitignore @@ -75,3 +75,6 @@ !contrib/osmo-trx.spec.in utils/osmo-prbs-tool +/.qtc_clangd/* +/.cache/* +/.vscode/* -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30410 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Iad9fd20924b7cfc6dbbfb708aa9c692a3cab574c Gerrit-Change-Number: 30410 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

1 year, 5 months

1
0
0 0

2024

2023

2022

gerrit-log December 2022