December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-trx[master]: clean up mutex, scopedlock, and signal classes

by Hoernchen

Attention is currently required from: Hoernchen. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30486 to look at the new patch set (#3). Change subject: clean up mutex, scopedlock, and signal classes ...................................................................... clean up mutex, scopedlock, and signal classes This also uncovers very interesting design decisions like the copying of mutexes and condition vars depending on recursive locks that were previously hidden by shady c function calls.. We have perfectly good c++11 versions for all of that. While we're at it, also use the initialization list for the other (still copy constructable) vectors, which cleans up the radio interfaces. Change-Id: Idc9e3b1144c5b93f5dad2f8e0e30f1058477aa52 --- M CommonLibs/Interthread.h M CommonLibs/Threads.cpp M CommonLibs/Threads.h M Transceiver52M/Transceiver.cpp M Transceiver52M/Transceiver.h M Transceiver52M/device/common/radioDevice.h M Transceiver52M/device/ipc/IPCDevice.cpp M Transceiver52M/radioBuffer.cpp M Transceiver52M/radioInterface.cpp M Transceiver52M/radioInterface.h M Transceiver52M/radioInterfaceMulti.cpp M Transceiver52M/radioInterfaceResamp.cpp M tests/CommonLibs/InterthreadTest.cpp 13 files changed, 96 insertions(+), 237 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/86/30486/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idc9e3b1144c5b93f5dad2f8e0e30f1058477aa52 Gerrit-Change-Number: 30486 Gerrit-PatchSet: 3 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: clean up mutex, scopedlock, and signal classes

by pespin

Attention is currently required from: Hoernchen. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30486 ) Change subject: clean up mutex, scopedlock, and signal classes ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File tests/CommonLibs/InterthreadTest.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30486/comment/79d5bc91_e34f3ba2 PS2, Line 35: if not suing it, just drop it? -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idc9e3b1144c5b93f5dad2f8e0e30f1058477aa52 Gerrit-Change-Number: 30486 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Dec 2022 10:21:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/README: modernize

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30481 ) Change subject: jobs/README: modernize ...................................................................... jobs/README: modernize Remove outdated debian 9 related information, update section on labels. Change-Id: I6616f4bdacc90c295db7996855e9aa2b48172b43 --- M jobs/README.adoc 1 file changed, 15 insertions(+), 26 deletions(-) Approvals: osmith: Verified pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/README.adoc b/jobs/README.adoc index bea1d9f..2533563 100644 --- a/jobs/README.adoc +++ b/jobs/README.adoc @@ -5,8 +5,6 @@ Install jenkins-job-builder: -For debian 9, see troubleshooting below. Otherwise: - apt-get install jenkins-job-builder Have a jenkins-job-builder.ini file. One of @@ -74,30 +72,21 @@ Also be aware that jobs are only actually updated when anything changed. -- debian 9 - -For jenkins-job-builder to work on debian 9: - -add 'testing' to /etc/apt/sources.list like - - deb http://ftp.de.debian.org/debian/ testing main - -then - - sudo apt-get update - sudo apt-get -t testing install python-jenkins - sudo apt-get install jenkins-job-builder - -and make sure to *not* pick the python3 versions -(or you'll need to add catching of HTTPError to jenkins/__init__.py in -'def maybe_add_crumb') - *Jenkins labels* -The build jobs are using labels to specify on which nodes the job should be run. -Please use the following labels +Most jenkins jobs should run a docker container and install all required +dependencies inside that, so we don't need to install them on the jenkins node. +These jobs don't need to set a label, they can just run on any generic jenkins +node that has docker available. So if you add a new job, you probably don't +need a label at all. -- osmocom-master-debian8: are nodes which can build osmocom-master and is a debian 8 -- osmocom-master-debian9: are nodes which can build osmocom-master and is a debian 9 -- osmocom-gerrit-debian8: are nodes which can build osmocom-gerrit and is a debian 8 -- osmocom-gerrit-debian9: are nodes which can build osmocom-gerrit and is a debian 9 +Existing jobs typically have a label set by the topic they belong to, e.g.: +- osmocom-master +- osmocom-gerrit +- ttcn3 + +Other labels indicate specific software/hardware works here, e.g.: +- coverity +- hdlc +- osmo-gsm-tester +- podman 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6616f4bdacc90c295db7996855e9aa2b48172b43 Gerrit-Change-Number: 30481 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci: remove deb9 nodes

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30479 ) Change subject: jobs/update-osmo-ci: remove deb9 nodes ...................................................................... jobs/update-osmo-ci: remove deb9 nodes Related: OS#5793 Change-Id: Id2bf3c273848c1de12a3dce3bc007dd205bf4af7 --- M jobs/update-osmo-ci-on-slaves.yml 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: osmith: Verified pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/update-osmo-ci-on-slaves.yml b/jobs/update-osmo-ci-on-slaves.yml index e566431..9174a6f 100644 --- a/jobs/update-osmo-ci-on-slaves.yml +++ b/jobs/update-osmo-ci-on-slaves.yml @@ -6,11 +6,9 @@ type: slave name: label values: - - build2-deb9build-ansible - build2-deb10build-ansible - build2-deb11build-ansible - build3-deb11build-ansible - - gtp0-deb9build - gtp0-deb10fr - host2-deb11build-ansible - osmo-gsm-tester-prod 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id2bf3c273848c1de12a3dce3bc007dd205bf4af7 Gerrit-Change-Number: 30479 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs: retire osmocom-gerrit-debian* labels

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30480 ) Change subject: jobs: retire osmocom-gerrit-debian* labels ...................................................................... jobs: retire osmocom-gerrit-debian* labels Let the gerrit-binpkgs and gerrit-pipeline-result jobs use the "osmocom-gerrit" label. Having the -debian10/11 label previously was useful to make sure this doesn't run on an ancient python version that fails on f-strings. But since the debian9 builders were retired, this is not needed anymore. These are the only jobs that used these, so now the labels in the README can be simplified (following patch). Related: OS#5793 Change-Id: Ieee95d25e036dcd4869d89b10c281179024672e7 --- M jobs/gerrit-binpkgs.yml M jobs/gerrit-pipeline-result.yml 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: osmith: Verified pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/jobs/gerrit-binpkgs.yml b/jobs/gerrit-binpkgs.yml index 8408950..247ebad 100644 --- a/jobs/gerrit-binpkgs.yml +++ b/jobs/gerrit-binpkgs.yml @@ -13,7 +13,7 @@ - job-template: name: 'gerrit-binpkgs-{type}' project-type: freestyle - node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11 + node: osmocom-gerrit concurrent: true retry-count: 3 # scm checkout properties: diff --git a/jobs/gerrit-pipeline-result.yml b/jobs/gerrit-pipeline-result.yml index 94fc88c..e1a7a74 100644 --- a/jobs/gerrit-pipeline-result.yml +++ b/jobs/gerrit-pipeline-result.yml @@ -9,7 +9,7 @@ - job: name: 'gerrit-pipeline-result' project-type: freestyle - node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11 + node: osmocom-gerrit retry-count: 3 # scm checkout properties: - build-discarder: 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieee95d25e036dcd4869d89b10c281179024672e7 Gerrit-Change-Number: 30480 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: ansible/hosts: remove debian 9 lxcs

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30477 ) Change subject: ansible/hosts: remove debian 9 lxcs ...................................................................... ansible/hosts: remove debian 9 lxcs Related: OS#5793 Change-Id: I465d93e5254ba2f65796fcfb62ea1063a0eb72c6 --- M ansible/hosts 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve msuraev: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/ansible/hosts b/ansible/hosts index cc19dfe..5ff2ab6 100644 --- a/ansible/hosts +++ b/ansible/hosts @@ -7,14 +7,10 @@ build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 [jenkins-slaves] -admin2-deb9build ansible_host=2a01:4f8:13b:828::1:300 osmocom_jenkins_slave_fstrim=True -build2-deb9build-ansible ansible_host=2a01:4f8:10b:2ad9::1:6 osmocom_jenkins_slave_fstrim=True build2-deb10build-ansible ansible_host=2a01:4f8:10b:2ad9::1:10 osmocom_jenkins_slave_fstrim=True build2-deb11build-ansible ansible_host=2a01:4f8:10b:2ad9::1:13 osmocom_jenkins_slave_fstrim=True build3-deb11build-ansible ansible_host=2a01:4f8:212:3762::1:3 osmocom_jenkins_slave_fstrim=True -host2-deb9build-ansible ansible_host=2a01:4f8:120:8470::1:3 osmocom_jenkins_slave_fstrim=True host2-deb11build-ansible ansible_host=2a01:4f8:120:8470::1:4 osmocom_jenkins_slave_fstrim=True -gtp0-deb9build ansible_host=10.34.2.102 osmocom_jenkins_slave_fstrim=True gtp0-deb10build ansible_host=10.34.2.101 osmocom_jenkins_slave_fstrim=True gtp0-deb11build-i586 ansible_host=10.34.2.104 osmocom_jenkins_slave_fstrim=True rpi4-raspbian11build-ansible-1 ansible_host=10.9.25.50 docker_max_image_space="20 GB" 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I465d93e5254ba2f65796fcfb62ea1063a0eb72c6 Gerrit-Change-Number: 30477 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/README: modernize

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30481 ) Change subject: jobs/README: modernize ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30481 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I6616f4bdacc90c295db7996855e9aa2b48172b43 Gerrit-Change-Number: 30481 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Dec 2022 10:17:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs: retire osmocom-gerrit-debian* labels

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30480 ) Change subject: jobs: retire osmocom-gerrit-debian* labels ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30480 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ieee95d25e036dcd4869d89b10c281179024672e7 Gerrit-Change-Number: 30480 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Dec 2022 10:17:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/update-osmo-ci: remove deb9 nodes

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30479 ) Change subject: jobs/update-osmo-ci: remove deb9 nodes ...................................................................... Patch Set 2: Verified+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30479 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Id2bf3c273848c1de12a3dce3bc007dd205bf4af7 Gerrit-Change-Number: 30479 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Dec 2022 10:17:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: ansible/hosts: remove debian 9 lxcs

by osmith

Attention is currently required from: osmith. Hello Jenkins Builder, laforge, pespin, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ci/+/30477 to look at the new patch set (#6). Change subject: ansible/hosts: remove debian 9 lxcs ...................................................................... ansible/hosts: remove debian 9 lxcs Related: OS#5793 Change-Id: I465d93e5254ba2f65796fcfb62ea1063a0eb72c6 --- M ansible/hosts 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/77/30477/6 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30477 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I465d93e5254ba2f65796fcfb62ea1063a0eb72c6 Gerrit-Change-Number: 30477 Gerrit-PatchSet: 6 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022