December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-upf[master]: improve error log for unknown netinst

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30462 ) Change subject: improve error log for unknown netinst ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30462 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ifdc0e7ec0d7b62b0127a5daa76cf48a932fcaf72 Gerrit-Change-Number: 30462 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Dec 2022 14:09:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-upf[master]: tunmap: choose local GTP addr by Network Instance IEs

by laforge

Attention is currently required from: arehbein, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30461 ) Change subject: tunmap: choose local GTP addr by Network Instance IEs ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30461 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I15ee046a1c37b83b8a83527a67a6215a30106d81 Gerrit-Change-Number: 30461 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Dec 2022 14:08:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-sgsn[master]: sndcp: Put decompress handling code into helper function

by fixeria

Attention is currently required from: pespin, lynxis lazus. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 ) Change subject: sndcp: Put decompress handling code into helper function ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649 Gerrit-Change-Number: 30488 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Tue, 06 Dec 2022 13:12:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-upf[master]: fix PFCP Session Mod: Update FAR

by laforge

Attention is currently required from: arehbein, neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30464 ) Change subject: fix PFCP Session Mod: Update FAR ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Looks like it does what it says, I would capitalize the first letter of the commit title but that's […] yeah, let's not go down that rabbit hole. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I2a2c015d5615bb461b4d7b476a7c9830dc8e130f Gerrit-Change-Number: 30464 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Dec 2022 13:00:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-upf[master]: fix PFCP Session Mod: Update FAR

by arehbein

Attention is currently required from: neels. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30464 ) Change subject: fix PFCP Session Mod: Update FAR ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: Looks like it does what it says, I would capitalize the first letter of the commit title but that's just nitpicking I suppose -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30464 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I2a2c015d5615bb461b4d7b476a7c9830dc8e130f Gerrit-Change-Number: 30464 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Dec 2022 12:12:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-sgsn[master]: sndcp: Put decompress handling code into helper function

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 to look at the new patch set (#3). Change subject: sndcp: Put decompress handling code into helper function ...................................................................... sndcp: Put decompress handling code into helper function This further simplifies code and avoids duplicating it. Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649 --- M src/sgsn/gprs_sndcp.c 1 file changed, 64 insertions(+), 79 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/88/30488/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649 Gerrit-Change-Number: 30488 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-sgsn[master]: sndcp: Put decompress handling code into helper function

by pespin

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 to look at the new patch set (#2). Change subject: sndcp: Put decompress handling code into helper function ...................................................................... sndcp: Put decompress handling code into helper function This further simplifies code and avoids duplicating it. Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649 --- M src/sgsn/gprs_sndcp.c 1 file changed, 63 insertions(+), 79 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/88/30488/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649 Gerrit-Change-Number: 30488 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-sgsn[master]: sndcp: Put decompress handling code into helper function

by Jenkins Builder

Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 ) Change subject: sndcp: Put decompress handling code into helper function ...................................................................... Patch Set 1: (3 comments) File src/sgsn/gprs_sndcp.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1710): https://gerrit.osmocom.org/c/osmo-sgsn/+/30488/comment/43443734_fe8f300c PS1, Line 294: static uint8_t *decompress_segment(struct gprs_sndcp_entity *sne, void *ctx, const uint8_t* compressed_data, unsigned int compressed_data_len, unsigned int *decompressed_data_len) "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1710): https://gerrit.osmocom.org/c/osmo-sgsn/+/30488/comment/a17cc67c_1ba328d1 PS1, Line 301: DEBUGP(DSNDCP, " \n"); unnecessary whitespace before a quoted newline Robot Comment from checkpatch (run ID jenkins-gerrit-lint-1710): https://gerrit.osmocom.org/c/osmo-sgsn/+/30488/comment/7da1ce46_4762de40 PS1, Line 335: DEBUGP(DSNDCP, " \n"); unnecessary whitespace before a quoted newline -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649 Gerrit-Change-Number: 30488 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Tue, 06 Dec 2022 10:51:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-sgsn[master]: sndcp: Put decompress handling code into helper function

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 ) Change subject: sndcp: Put decompress handling code into helper function ...................................................................... sndcp: Put decompress handling code into helper function This further simplifies code and avoids duplicating it. Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649 --- M src/sgsn/gprs_sndcp.c 1 file changed, 61 insertions(+), 79 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/88/30488/1 diff --git a/src/sgsn/gprs_sndcp.c b/src/sgsn/gprs_sndcp.c index fc454db..1fef8fd 100644 --- a/src/sgsn/gprs_sndcp.c +++ b/src/sgsn/gprs_sndcp.c @@ -290,13 +290,59 @@ return NULL; } +/* Returns talloced buffer containing decompressed data, NULL on error. */ +static uint8_t *decompress_segment(struct gprs_sndcp_entity *sne, void *ctx, const uint8_t* compressed_data, unsigned int compressed_data_len, unsigned int *decompressed_data_len) +{ + int rc; + uint8_t *expnd = NULL; + *decompressed_data_len = 0; + +#if DEBUG_IP_PACKETS == 1 + DEBUGP(DSNDCP, " \n"); + DEBUGP(DSNDCP, ":::::::::::::::::::::::::::::::::::::::::::::::::::\n"); + DEBUGP(DSNDCP, "===================================================\n"); +#endif + + expnd = talloc_zero_size(ctx, compressed_data_len * MAX_DATADECOMPR_FAC + + MAX_HDRDECOMPR_INCR); + memcpy(expnd, compressed_data, compressed_data_len); + + /* Apply data decompression */ + rc = gprs_sndcp_dcomp_expand(expnd, compressed_data_len, sne->defrag.dcomp, + sne->defrag.data); + if (rc < 0) { + LOGP(DSNDCP, LOGL_ERROR, + "Data decompression failed!\n"); + talloc_free(expnd); + return NULL; + } + + /* Apply header decompression */ + rc = gprs_sndcp_pcomp_expand(expnd, rc, sne->defrag.pcomp, sne->defrag.proto); + if (rc < 0) { + LOGP(DSNDCP, LOGL_ERROR, + "TCP/IP Header decompression failed!\n"); + talloc_free(expnd); + return NULL; + } + + *decompressed_data_len = rc; + +#if DEBUG_IP_PACKETS == 1 + debug_ip_packet(expnd, *decompressed_data_len, 1, "defrag_segments()"); + DEBUGP(DSNDCP, "===================================================\n"); + DEBUGP(DSNDCP, ":::::::::::::::::::::::::::::::::::::::::::::::::::\n"); + DEBUGP(DSNDCP, " \n"); +#endif + return expnd; +} /* Perform actual defragmentation and create an output packet */ static int defrag_segments(struct gprs_sndcp_entity *sne) { struct msgb *msg; unsigned int seg_nr; uint8_t *npdu; - int npdu_len; + unsigned int npdu_len; int rc; uint8_t *expnd = NULL; @@ -337,53 +383,21 @@ * hands it off to the correct GTP tunnel + GGSN via gtp_data_req() */ /* Decompress packet */ -#if DEBUG_IP_PACKETS == 1 - DEBUGP(DSNDCP, " \n"); - DEBUGP(DSNDCP, ":::::::::::::::::::::::::::::::::::::::::::::::::::\n"); - DEBUGP(DSNDCP, "===================================================\n"); -#endif if (any_pcomp_or_dcomp_active(sgsn)) { - - expnd = talloc_zero_size(msg, npdu_len * MAX_DATADECOMPR_FAC + - MAX_HDRDECOMPR_INCR); - memcpy(expnd, npdu, npdu_len); - - /* Apply data decompression */ - rc = gprs_sndcp_dcomp_expand(expnd, npdu_len, sne->defrag.dcomp, - sne->defrag.data); - if (rc < 0) { - LOGP(DSNDCP, LOGL_ERROR, - "Data decompression failed!\n"); - talloc_free(expnd); - return -EIO; + expnd = decompress_segment(sne, msg, npdu, npdu_len, &npdu_len); + if (!expnd) { + rc = -EIO; + goto ret_free; } - - /* Apply header decompression */ - rc = gprs_sndcp_pcomp_expand(expnd, rc, sne->defrag.pcomp, - sne->defrag.proto); - if (rc < 0) { - LOGP(DSNDCP, LOGL_ERROR, - "TCP/IP Header decompression failed!\n"); - talloc_free(expnd); - return -EIO; - } - - /* Modify npu length, expnd is handed directly handed - * over to gsn_rx_sndcp_ud_ind(), see below */ - npdu_len = rc; - } else + } else { expnd = npdu; -#if DEBUG_IP_PACKETS == 1 - debug_ip_packet(expnd, npdu_len, 1, "defrag_segments()"); - DEBUGP(DSNDCP, "===================================================\n"); - DEBUGP(DSNDCP, ":::::::::::::::::::::::::::::::::::::::::::::::::::\n"); - DEBUGP(DSNDCP, " \n"); -#endif + } /* Hand off packet to gtp */ rc = sgsn_rx_sndcp_ud_ind(&sne->ra_id, sne->lle->llme->tlli, sne->nsapi, msg, npdu_len, expnd); +ret_free: /* we must free the memory we allocated above; ownership is not transferred * downwards in the call above */ msgb_free(msg); @@ -850,53 +864,21 @@ * hands it off to the correct GTP tunnel + GGSN via gtp_data_req() */ /* Decompress packet */ -#if DEBUG_IP_PACKETS == 1 - DEBUGP(DSNDCP, " \n"); - DEBUGP(DSNDCP, ":::::::::::::::::::::::::::::::::::::::::::::::::::\n"); - DEBUGP(DSNDCP, "===================================================\n"); -#endif if (any_pcomp_or_dcomp_active(sgsn)) { - - expnd = talloc_zero_size(msg, npdu_len * MAX_DATADECOMPR_FAC + - MAX_HDRDECOMPR_INCR); - memcpy(expnd, npdu, npdu_len); - - /* Apply data decompression */ - rc = gprs_sndcp_dcomp_expand(expnd, npdu_len, sne->defrag.dcomp, - sne->defrag.data); - if (rc < 0) { - LOGP(DSNDCP, LOGL_ERROR, - "Data decompression failed!\n"); - talloc_free(expnd); - return -EIO; + expnd = decompress_segment(sne, msg, npdu, npdu_len, (unsigned int *)&npdu_len); + if (!expnd) { + rc = -EIO; + goto ret_free; } - - /* Apply header decompression */ - rc = gprs_sndcp_pcomp_expand(expnd, rc, sne->defrag.pcomp, - sne->defrag.proto); - if (rc < 0) { - LOGP(DSNDCP, LOGL_ERROR, - "TCP/IP Header decompression failed!\n"); - talloc_free(expnd); - return -EIO; - } - - /* Modify npu length, expnd is handed directly handed - * over to gsn_rx_sndcp_ud_ind(), see below */ - npdu_len = rc; - } else + } else { expnd = npdu; -#if DEBUG_IP_PACKETS == 1 - debug_ip_packet(expnd, npdu_len, 1, "sndcp_llunitdata_ind()"); - DEBUGP(DSNDCP, "===================================================\n"); - DEBUGP(DSNDCP, ":::::::::::::::::::::::::::::::::::::::::::::::::::\n"); - DEBUGP(DSNDCP, " \n"); -#endif + } /* Hand off packet to gtp */ rc = sgsn_rx_sndcp_ud_ind(&sne->ra_id, lle->llme->tlli, sne->nsapi, msg, npdu_len, expnd); +ret_free: if (any_pcomp_or_dcomp_active(sgsn)) talloc_free(expnd); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/30488 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Id83f9e4a87139de2b2f64c8523460c186d5b5649 Gerrit-Change-Number: 30488 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: clean up mutex, scopedlock, and signal classes

by Hoernchen

Attention is currently required from: pespin. Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/30486 ) Change subject: clean up mutex, scopedlock, and signal classes ...................................................................... Patch Set 2: (1 comment) File tests/CommonLibs/InterthreadTest.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/30486/comment/7c8a0f38_261ead36 PS2, Line 35: > if not suing it, just drop it? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30486 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Idc9e3b1144c5b93f5dad2f8e0e30f1058477aa52 Gerrit-Change-Number: 30486 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 06 Dec 2022 10:28:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022