Attention is currently required from: neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30496 )
Change subject: nft: ensure to assign rule id only once
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30496
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I4e8c48c01fb2f5d4cfd223fe03abbf15b1a55670
Gerrit-Change-Number: 30496
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 10 Dec 2022 11:46:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/30495 )
Change subject: nft: end each rule in semicolon
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/30495
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: I6ff6f59fb24a18596aa60848fb00ac70deb1985f
Gerrit-Change-Number: 30495
Gerrit-PatchSet: 3
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 10 Dec 2022 11:46:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: neels.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/30502 )
Change subject: gtlv: decoding error: log size limited hexdump of IE
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/libosmo-gtlv/gtlv_dec_enc.c:
https://gerrit.osmocom.org/c/libosmo-pfcp/+/30502/comment/0f956279_3e1c99b4
PS4, Line 224: osmo_hexdump
We may want to have a special version of osmo_hexdump_max() in libosmocore.
--
To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/30502
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-pfcp
Gerrit-Branch: master
Gerrit-Change-Id: Ie814a117db3dfea32cf3f01cf124a2e472cb869f
Gerrit-Change-Number: 30502
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 10 Dec 2022 11:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30528 )
Change subject: obs-mirror: Keep nightly packages for 22.04, not 21.04
......................................................................
obs-mirror: Keep nightly packages for 22.04, not 21.04
We typically keep nightly builds for the latest version of each
distribution. That is correct for CentOS and Debian, but we forgot
to update Ubuntu from 21.04 to 22.04 it seems :(
Change-Id: Ic82dfc7e8c4f4a362f7d05b5bc2069d42a0bcdb2
---
M contrib/obs-mirror/obs-mirror-include.txt
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt
index 122b093..c7f43db 100644
--- a/contrib/obs-mirror/obs-mirror-include.txt
+++ b/contrib/obs-mirror/obs-mirror-include.txt
@@ -12,4 +12,4 @@
nightly/CentOS_8
nightly/Debian_11
nightly/Raspbian_11
-nightly/xUbuntu_21.04
+nightly/xUbuntu_22.04
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30528
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ic82dfc7e8c4f4a362f7d05b5bc2069d42a0bcdb2
Gerrit-Change-Number: 30528
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30529 )
Change subject: obs-mirror: Also keep nightly builds for Debian 10
......................................................................
obs-mirror: Also keep nightly builds for Debian 10
It seems that some users are running nightly builds in production on
EOL Debian 10, which we never imagined and hence didn't keep an archive
of those builds :/
Change-Id: I40c628e032e2c7ce8447657319a7c1206933c163
---
M contrib/obs-mirror/obs-mirror-include.txt
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt
index c7f43db..c69474c 100644
--- a/contrib/obs-mirror/obs-mirror-include.txt
+++ b/contrib/obs-mirror/obs-mirror-include.txt
@@ -10,6 +10,7 @@
latest/xUbuntu_22.04
nightly/CentOS_8
+nightly/Debian_10
nightly/Debian_11
nightly/Raspbian_11
nightly/xUbuntu_22.04
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30529
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I40c628e032e2c7ce8447657319a7c1206933c163
Gerrit-Change-Number: 30529
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30527 )
Change subject: obs-mirror: Keep latest build also for Ubuntu 22.04
......................................................................
obs-mirror: Keep latest build also for Ubuntu 22.04
Ubuntu 22.04 is very much a stable/maintained distribution, so we
should keep an archive of "latest" builds for it.
Change-Id: I54988915ec4bcf2ebb1e5cd23ceb049789c56bca
---
M contrib/obs-mirror/obs-mirror-include.txt
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/contrib/obs-mirror/obs-mirror-include.txt b/contrib/obs-mirror/obs-mirror-include.txt
index 6510e74..122b093 100644
--- a/contrib/obs-mirror/obs-mirror-include.txt
+++ b/contrib/obs-mirror/obs-mirror-include.txt
@@ -7,6 +7,7 @@
latest/xUbuntu_18.04
latest/xUbuntu_20.04
latest/xUbuntu_21.04
+latest/xUbuntu_22.04
nightly/CentOS_8
nightly/Debian_11
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30527
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I54988915ec4bcf2ebb1e5cd23ceb049789c56bca
Gerrit-Change-Number: 30527
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged