December 2022 - gerrit-log - lists.osmocom.org

Change in libosmo-sccp[master]: cosmetic: fix typo in comment

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/30531 ) Change subject: cosmetic: fix typo in comment ...................................................................... cosmetic: fix typo in comment Change-Id: I2e2b5ec36da9b50dcf13a0d7f497a9ca16e6a7a3 --- M src/sccp_scoc.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index be13a8f..00e677c 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1731,7 +1731,7 @@ xua->mtp.opc, osmo_ss7_pointcode_print(conn->inst->ss7, xua->mtp.opc), conn->remote_pc, osmo_ss7_pointcode_print2(conn->inst->ss7, conn->remote_pc)); /* we have received a message with invalid origin PC and thus - * apply the action indiacted in Table B.2/Q.714 */ + * apply the action indicated in Table B.2/Q.714 */ switch (xua->hdr.msg_type) { case SUA_CO_RELRE: /* RLSD */ case SUA_CO_RESRE: /* RSR */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/30531 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: I2e2b5ec36da9b50dcf13a0d7f497a9ca16e6a7a3 Gerrit-Change-Number: 30531 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmo-sccp[master]: SCOC: dump SUA header when logging "mismatching remote pc"

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/30530 ) Change subject: SCOC: dump SUA header when logging "mismatching remote pc" ...................................................................... SCOC: dump SUA header when logging "mismatching remote pc" Provide some more information in the logs when this happens Change-Id: Idd889b57e8f842e22e5ed54bea0821dcec0cd8ce --- M src/sccp_scoc.c 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved diff --git a/src/sccp_scoc.c b/src/sccp_scoc.c index cff6e80..be13a8f 100644 --- a/src/sccp_scoc.c +++ b/src/sccp_scoc.c @@ -1726,7 +1726,8 @@ struct xua_msg *xua) { LOGP(DLSCCP, LOGL_NOTICE, - "Received message for opc=%u=%s on conn with mismatching remote pc=%u=%s\n", + "Received message %s for opc=%u=%s on conn with mismatching remote pc=%u=%s\n", + xua_hdr_dump(xua, &xua_dialect_sua), xua->mtp.opc, osmo_ss7_pointcode_print(conn->inst->ss7, xua->mtp.opc), conn->remote_pc, osmo_ss7_pointcode_print2(conn->inst->ss7, conn->remote_pc)); /* we have received a message with invalid origin PC and thus -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/30530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idd889b57e8f842e22e5ed54bea0821dcec0cd8ce Gerrit-Change-Number: 30530 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in libosmo-sccp[master]: SCOC: dump SUA header when logging "mismatching remote pc"

by laforge

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/30530 ) Change subject: SCOC: dump SUA header when logging "mismatching remote pc" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/30530 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Idd889b57e8f842e22e5ed54bea0821dcec0cd8ce Gerrit-Change-Number: 30530 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sat, 10 Dec 2022 22:18:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm48_rr_rx_acch(): clarify logging messages

by laforge

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30532 ) Change subject: mobile: gsm48_rr_rx_acch(): clarify logging messages ...................................................................... mobile: gsm48_rr_rx_acch(): clarify logging messages Change-Id: Ibc2d54c2879fa28225d46222239829f699277f6c --- M src/host/layer23/src/mobile/gsm48_rr.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/host/layer23/src/mobile/gsm48_rr.c b/src/host/layer23/src/mobile/gsm48_rr.c index f0b052c..8a920ee 100644 --- a/src/host/layer23/src/mobile/gsm48_rr.c +++ b/src/host/layer23/src/mobile/gsm48_rr.c @@ -4873,13 +4873,13 @@ ind_ta = rllh->data[1]; ind_tx_power = rllh->data[3]; - LOGP(DRR, LOGL_INFO, "Indicated ta %d (actual ta %d)\n", + LOGP(DRR, LOGL_INFO, "DL SACCH indicates ta %d (actual ta %d)\n", ind_ta, ind_ta - set->alter_delay); - LOGP(DRR, LOGL_INFO, "Indicated tx_power %d\n", + LOGP(DRR, LOGL_INFO, "DL SACCH indicates tx_power %d\n", ind_tx_power); if (ind_ta != rr->cd_now.ind_ta || ind_tx_power != rr->cd_now.ind_tx_power) { - LOGP(DRR, LOGL_INFO, "setting new ta and tx_power\n"); + LOGP(DRR, LOGL_INFO, "Applying new ta and tx_power\n"); l1ctl_tx_param_req(ms, ind_ta - set->alter_delay, (set->alter_tx_power) ? set->alter_tx_power_value : ind_tx_power); -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibc2d54c2879fa28225d46222239829f699277f6c Gerrit-Change-Number: 30532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: mobile: gsm48_rr_rx_acch(): clarify logging messages

by laforge

Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30532 ) Change subject: mobile: gsm48_rr_rx_acch(): clarify logging messages ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30532 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ibc2d54c2879fa28225d46222239829f699277f6c Gerrit-Change-Number: 30532 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 10 Dec 2022 22:18:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size NSEI IE

by arehbein

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30430 ) Change subject: WIP: ns: Add test for SNS Size NSEI IE ...................................................................... Patch Set 2: (1 comment) File ns/NS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30430/comment/51d9abf0_0297… PS1, Line 70: NsIEI ns_iei_num_ipv4_ep := NS_IEI_NUM_IPv4_EP; > all module parameter must start with "mp_" so that they can easily be identfiied. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3584b7b048031c798cee9566c4cc8694bf6002ac Gerrit-Change-Number: 30430 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 10 Dec 2022 14:32:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size Num. of NSVCs IE

by arehbein

arehbein has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30432 ) Change subject: WIP: ns: Add test for SNS Size Num. of NSVCs IE ...................................................................... WIP: ns: Add test for SNS Size Num. of NSVCs IE Related: OS#5208 Change-Id: Ic69c461cdb854a1b7abd27c56d70c3cbe32e6eb7 --- M ns/NS_Tests.ttcn 1 file changed, 26 insertions(+), 0 deletions(-) diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index f57302f..2b703fc 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -640,6 +640,31 @@ f_clean_ns_codec(); } +testcase TC_sns_sgsn_sns_size_outgoing_invalid_num_of_nsvcs() runs on RAW_Test_CT { + f_init_vty(); + f_init_ns_codec(mp_nsconfig); + /* Assumption: No connections to other NSEs for SUT and testcomponent */ + const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); + const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); + const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; + const integer IDX := 0; + /* Template that would be accepted, only missing the number of IP endpoints + * (since there are no ternary operators in TTCN-3...) */ + var template (omit) PDU_NS ts_base_SNS_SIZE_configured := + ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, + num_v4 := omit, num_v6 := omit); + var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[IDX]; + ts_base_SNS_SIZE_configured.pDU_SNS_Size.nSEI_NS := ts_NS_IE_NSEI(g_nsconfig.nsei); + f_set_num_of_ip_endpoints(ts_base_SNS_SIZE_configured, g_nsconfig.nsvc[0].provider.ip.address_family); + /* Assumption: No connections to other NSEs for SUT and testcomponent and thus no other endpoints */ + const integer required_max_num_of_nsvcs := num_of_nsvcs; + const uint16_t invalid_max_num_of_nsvcs := required_max_num_of_nsvcs - 1; + ts_base_SNS_SIZE_configured.pDU_SNS_Size.maxNumberOfNSVCs := ts_SNS_IE_MaxNumOfNSVCs(invalid_max_num_of_nsvcs); + const NsCause cause := NS_CAUSE_INVALID_NR_OF_NSVCS; + f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); + f_clean_ns_codec(); +} + testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1181,6 +1206,7 @@ execute( TC_sns_sgsn_size_after_success() ); execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); execute( TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() ); + execute( TC_sns_sgsn_sns_size_outgoing_invalid_num_of_nsvcs() ); } } } null-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30432 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic69c461cdb854a1b7abd27c56d70c3cbe32e6eb7 Gerrit-Change-Number: 30432 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size NSEI IE

by arehbein

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30430 to look at the new patch set (#2). Change subject: WIP: ns: Add test for SNS Size NSEI IE ...................................................................... WIP: ns: Add test for SNS Size NSEI IE Related: OS#5208 Change-Id: I3584b7b048031c798cee9566c4cc8694bf6002ac --- M ns/NS_Tests.ttcn 1 file changed, 51 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/30/30430/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3584b7b048031c798cee9566c4cc8694bf6002ac Gerrit-Change-Number: 30430 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE

by arehbein

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 to look at the new patch set (#2). Change subject: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE ...................................................................... WIP: ns: Add test for SNS Size Num. of IP Endpoints IE Related: OS#5208 Change-Id: I85c2dc201ba485d7bfdcc70e1a5f8a890023c435 --- M ns/NS_Tests.ttcn 1 file changed, 32 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/30431/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I85c2dc201ba485d7bfdcc70e1a5f8a890023c435 Gerrit-Change-Number: 30431 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[arehbein/ttcn3-dumpcap-changes]: WIP: dumpcap-start/stop: Make script fail, not hang on sudo prompt

by arehbein

arehbein has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30127 ) Change subject: WIP: dumpcap-start/stop: Make script fail, not hang on sudo prompt ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30127 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: arehbein/ttcn3-dumpcap-changes Gerrit-Change-Id: Id160384bf624a4eb0f419cb8ba07d8b69bb693f3 Gerrit-Change-Number: 30127 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-MessageType: abandon

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022