December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ttcn3-hacks[master]: Revert "WIP: ns: Add test for SNS Size Num. of IP Endpoints IE"

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30544 ) Change subject: Revert "WIP: ns: Add test for SNS Size Num. of IP Endpoints IE" ...................................................................... Revert "WIP: ns: Add test for SNS Size Num. of IP Endpoints IE" Revert submission 30430 Reason for revert: I did not consciously merge these, maybe some misunderstanding of Gerrit UI elements. Although it really surprises me that merging could have happened that easily without me noticing Reverted Changes: I85c2dc201:WIP: ns: Add test for SNS Size Num. of IP Endpoint... I3584b7b04:WIP: ns: Add test for SNS Size NSEI IE Ic69c461cd:WIP: ns: Add test for SNS Size Num. of NSVCs IE Change-Id: I2b963d8d547b7c97ba8499921e42c57bab4ffaee --- M ns/NS_Tests.ttcn 1 file changed, 0 insertions(+), 32 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index f57302f..d5af707 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -609,37 +609,6 @@ f_clean_ns_codec(); } -testcase TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() runs on RAW_Test_CT { - f_init_vty(); - f_init_ns_codec(mp_nsconfig); - const integer IDX := 0; - const integer NUM_IP := 1; - log("f_outgoing_sns_size_invalid_num_of_ip_eps(idx=", IDX, ")"); - var NsCause cause; - /* Assumption: No connections to other NSEs for SUT and testcomponent */ - const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; - /* Template that would be accepted, only missing the number of IP endpoints - * (since there are no ternary operators in TTCN-3...) */ - var template (omit) PDU_NS ts_base_SNS_SIZE_configured := - ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, - num_v4 := omit, num_v6 := omit); - /* Send IP4 endpoints when IP6 is configured and vice versa, in effect sending an unsupported type of NS-VC endpoints. */ - if (g_nsconfig.nsvc[0].provider.ip.address_family == AF_INET) { - ts_base_SNS_SIZE_configured.pDU_SNS_Size.numberOfIP6_Endpoints := - {iEI := int2oct(enum2int(mp_ns_iei_num_ipv6_ep), 1), numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; - cause := NS_CAUSE_INVALID_NR_OF_IPv6_ENDPOINTS; - } else { - ts_base_SNS_SIZE_configured.pDU_SNS_Size.numberOfIP4_Endpoints := - {iEI := int2oct(enum2int(mp_ns_iei_num_ipv4_ep), 1), numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; - cause := NS_CAUSE_INVALID_NR_OF_IPv4_ENDPOINTS; - } - f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); - setverdict(pass); - f_clean_ns_codec(); -} - testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1180,7 +1149,6 @@ execute( TC_sns_sgsn_size_correct_port() ); execute( TC_sns_sgsn_size_after_success() ); execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); - execute( TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2b963d8d547b7c97ba8499921e42c57bab4ffaee Gerrit-Change-Number: 30544 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Revert "WIP: ns: Add test for SNS Size NSEI IE"

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30545 ) Change subject: Revert "WIP: ns: Add test for SNS Size NSEI IE" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifab74bd8ae568a3099637fb53f5fe407f85952b6 Gerrit-Change-Number: 30545 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Dec 2022 11:12:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Revert "WIP: ns: Add test for SNS Size Num. of IP Endpoints IE"

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30544 ) Change subject: Revert "WIP: ns: Add test for SNS Size Num. of IP Endpoints IE" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2b963d8d547b7c97ba8499921e42c57bab4ffaee Gerrit-Change-Number: 30544 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Dec 2022 11:12:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Revert "WIP: ns: Add test for SNS Size Num. of NSVCs IE"

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30543 ) Change subject: Revert "WIP: ns: Add test for SNS Size Num. of NSVCs IE" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I838b9b608a939ff909efe24ce3c1fdbfb539939d Gerrit-Change-Number: 30543 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Dec 2022 11:12:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE

by arehbein

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 ) Change subject: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I'm not following here. […] I really don't know what happened here. I don't recall clicking the 'submit' buttons three times in a row on three different pages (not even on one page), the last thing I remember w.r.t. this is pushing a second patchset to fix the module param. variable names. And marking your comment on that as 'done' in my reply. Does that lead to Gerrit automerge or anything like that? Or maybe it happened because I pushed the second patchset not to 'refs/for/heads' but normally (?). I opened a revert of all three commits, I suppose that needs votes from others to go through. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I85c2dc201ba485d7bfdcc70e1a5f8a890023c435 Gerrit-Change-Number: 30431 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Dec 2022 11:12:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size NSEI IE

by arehbein

arehbein has created a revert of this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30430 ) Change subject: WIP: ns: Add test for SNS Size NSEI IE ...................................................................... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30430 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3584b7b048031c798cee9566c4cc8694bf6002ac Gerrit-Change-Number: 30430 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: revert

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Revert "WIP: ns: Add test for SNS Size NSEI IE"

by arehbein

Hello Jenkins Builder, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30545 to review the following change. Change subject: Revert "WIP: ns: Add test for SNS Size NSEI IE" ...................................................................... Revert "WIP: ns: Add test for SNS Size NSEI IE" Revert submission 30430 Reason for revert: I did not consciously merge these, maybe some misunderstanding of Gerrit UI elements. Although it really surprises me that merging could have happened that easily without me noticing Reverted Changes: I85c2dc201:WIP: ns: Add test for SNS Size Num. of IP Endpoint... I3584b7b04:WIP: ns: Add test for SNS Size NSEI IE Ic69c461cd:WIP: ns: Add test for SNS Size Num. of NSVCs IE Change-Id: Ifab74bd8ae568a3099637fb53f5fe407f85952b6 --- M ns/NS_Tests.ttcn 1 file changed, 0 insertions(+), 51 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/45/30545/1 diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index d5af707..722f8ec 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -67,9 +67,6 @@ } } }; - NsIEI mp_ns_iei_num_ipv4_ep := NS_IEI_NUM_IPv4_EP; - NsIEI mp_ns_iei_num_ipv6_ep := NS_IEI_NUM_IPv6_EP; - NsIEI mp_ns_iei_nsei := NS_IEI_NSEI; } type component RAW_Test_CT extends RAW_NS_CT { @@ -562,53 +559,6 @@ /* 48.016 SNS test cases */ /* do a succesful SNS configuration */ -function f_send_expect(in integer NSCP_IDX, in template (omit) PDU_NS pdu, - in NsCause c) runs on RAW_Test_CT { - log("Expected cause: ", c); - NSCP[NSCP_IDX].send(pdu); - f_ns_exp(tr_SNS_SIZE_ACK(g_nsconfig.nsei, c), NSCP_IDX); -} - -function f_set_num_of_ip_endpoints(inout template (omit) PDU_NS base, AddressFamily af) runs on RAW_Test_CT { - const integer NUM_IP := 1; - if (af == AF_INET) { - base.pDU_SNS_Size.numberOfIP4_Endpoints := - {iEI := int2oct(enum2int(mp_ns_iei_num_ipv4_ep), 1), - numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; - } else { - base.pDU_SNS_Size.numberOfIP4_Endpoints := - {iEI := int2oct(enum2int(mp_ns_iei_num_ipv6_ep), 1), - numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; - } -} - -/* Send SNS Size PDUs with invalid IEs */ -testcase TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() runs on RAW_Test_CT { - f_init_vty(); - f_init_ns_codec(mp_nsconfig); - const integer IDX := 0; - /* Assumption: No connections to other NSEs for SUT and testcomponent */ - const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; - /* Template that would be accepted, only missing the number of IP endpoints - * (since there are no ternary operators in TTCN-3...) */ - var template (omit) PDU_NS ts_base_SNS_SIZE_configured := - ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, - num_v4 := omit, num_v6 := omit); - var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[IDX]; - - f_set_num_of_ip_endpoints(ts_base_SNS_SIZE_configured, g_nsconfig.nsvc[0].provider.ip.address_family); - /* Syntactical error here: length of 1 (has to be >=2) */ - ts_base_SNS_SIZE_configured.pDU_SNS_Size.nSEI_NS := - {iEI := int2oct(enum2int(mp_ns_iei_nsei), 1), ext := '0'B, lengthIndicator := {length1 := 1}, - nSEI := int2oct(g_nsconfig.nsei, 2)}; - const NsCause cause := NS_CAUSE_INVALID_ESSENTIAL_IE; - f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); - setverdict(pass); - f_clean_ns_codec(); -} - testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1148,7 +1098,6 @@ execute( TC_sns_sgsn_add_change_del() ); execute( TC_sns_sgsn_size_correct_port() ); execute( TC_sns_sgsn_size_after_success() ); - execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifab74bd8ae568a3099637fb53f5fe407f85952b6 Gerrit-Change-Number: 30545 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Revert "WIP: ns: Add test for SNS Size Num. of IP Endpoints IE"

by arehbein

Hello Jenkins Builder, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30544 to review the following change. Change subject: Revert "WIP: ns: Add test for SNS Size Num. of IP Endpoints IE" ...................................................................... Revert "WIP: ns: Add test for SNS Size Num. of IP Endpoints IE" Revert submission 30430 Reason for revert: I did not consciously merge these, maybe some misunderstanding of Gerrit UI elements. Although it really surprises me that merging could have happened that easily without me noticing Reverted Changes: I85c2dc201:WIP: ns: Add test for SNS Size Num. of IP Endpoint... I3584b7b04:WIP: ns: Add test for SNS Size NSEI IE Ic69c461cd:WIP: ns: Add test for SNS Size Num. of NSVCs IE Change-Id: I2b963d8d547b7c97ba8499921e42c57bab4ffaee --- M ns/NS_Tests.ttcn 1 file changed, 0 insertions(+), 32 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/30544/1 diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index f57302f..d5af707 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -609,37 +609,6 @@ f_clean_ns_codec(); } -testcase TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() runs on RAW_Test_CT { - f_init_vty(); - f_init_ns_codec(mp_nsconfig); - const integer IDX := 0; - const integer NUM_IP := 1; - log("f_outgoing_sns_size_invalid_num_of_ip_eps(idx=", IDX, ")"); - var NsCause cause; - /* Assumption: No connections to other NSEs for SUT and testcomponent */ - const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; - /* Template that would be accepted, only missing the number of IP endpoints - * (since there are no ternary operators in TTCN-3...) */ - var template (omit) PDU_NS ts_base_SNS_SIZE_configured := - ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, - num_v4 := omit, num_v6 := omit); - /* Send IP4 endpoints when IP6 is configured and vice versa, in effect sending an unsupported type of NS-VC endpoints. */ - if (g_nsconfig.nsvc[0].provider.ip.address_family == AF_INET) { - ts_base_SNS_SIZE_configured.pDU_SNS_Size.numberOfIP6_Endpoints := - {iEI := int2oct(enum2int(mp_ns_iei_num_ipv6_ep), 1), numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; - cause := NS_CAUSE_INVALID_NR_OF_IPv6_ENDPOINTS; - } else { - ts_base_SNS_SIZE_configured.pDU_SNS_Size.numberOfIP4_Endpoints := - {iEI := int2oct(enum2int(mp_ns_iei_num_ipv4_ep), 1), numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; - cause := NS_CAUSE_INVALID_NR_OF_IPv4_ENDPOINTS; - } - f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); - setverdict(pass); - f_clean_ns_codec(); -} - testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1180,7 +1149,6 @@ execute( TC_sns_sgsn_size_correct_port() ); execute( TC_sns_sgsn_size_after_success() ); execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); - execute( TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30544 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2b963d8d547b7c97ba8499921e42c57bab4ffaee Gerrit-Change-Number: 30544 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE

by arehbein

arehbein has created a revert of this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 ) Change subject: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE ...................................................................... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I85c2dc201ba485d7bfdcc70e1a5f8a890023c435 Gerrit-Change-Number: 30431 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: revert

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Revert "WIP: ns: Add test for SNS Size Num. of NSVCs IE"

by arehbein

Hello Jenkins Builder, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30543 to review the following change. Change subject: Revert "WIP: ns: Add test for SNS Size Num. of NSVCs IE" ...................................................................... Revert "WIP: ns: Add test for SNS Size Num. of NSVCs IE" Revert submission 30430 Reason for revert: I did not consciously merge these, maybe some misunderstanding of Gerrit UI elements. Although it really surprises me that merging could have happened that easily without me noticing Reverted Changes: I85c2dc201:WIP: ns: Add test for SNS Size Num. of IP Endpoint... I3584b7b04:WIP: ns: Add test for SNS Size NSEI IE Ic69c461cd:WIP: ns: Add test for SNS Size Num. of NSVCs IE Change-Id: I838b9b608a939ff909efe24ce3c1fdbfb539939d --- M ns/NS_Tests.ttcn 1 file changed, 0 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/43/30543/1 diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index 2b703fc..f57302f 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -640,31 +640,6 @@ f_clean_ns_codec(); } -testcase TC_sns_sgsn_sns_size_outgoing_invalid_num_of_nsvcs() runs on RAW_Test_CT { - f_init_vty(); - f_init_ns_codec(mp_nsconfig); - /* Assumption: No connections to other NSEs for SUT and testcomponent */ - const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; - const integer IDX := 0; - /* Template that would be accepted, only missing the number of IP endpoints - * (since there are no ternary operators in TTCN-3...) */ - var template (omit) PDU_NS ts_base_SNS_SIZE_configured := - ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, - num_v4 := omit, num_v6 := omit); - var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[IDX]; - ts_base_SNS_SIZE_configured.pDU_SNS_Size.nSEI_NS := ts_NS_IE_NSEI(g_nsconfig.nsei); - f_set_num_of_ip_endpoints(ts_base_SNS_SIZE_configured, g_nsconfig.nsvc[0].provider.ip.address_family); - /* Assumption: No connections to other NSEs for SUT and testcomponent and thus no other endpoints */ - const integer required_max_num_of_nsvcs := num_of_nsvcs; - const uint16_t invalid_max_num_of_nsvcs := required_max_num_of_nsvcs - 1; - ts_base_SNS_SIZE_configured.pDU_SNS_Size.maxNumberOfNSVCs := ts_SNS_IE_MaxNumOfNSVCs(invalid_max_num_of_nsvcs); - const NsCause cause := NS_CAUSE_INVALID_NR_OF_NSVCS; - f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); - f_clean_ns_codec(); -} - testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1206,7 +1181,6 @@ execute( TC_sns_sgsn_size_after_success() ); execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); execute( TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() ); - execute( TC_sns_sgsn_sns_size_outgoing_invalid_num_of_nsvcs() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I838b9b608a939ff909efe24ce3c1fdbfb539939d Gerrit-Change-Number: 30543 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022