December 2022 - gerrit-log - lists.osmocom.org

Change in osmo-trx[master]: clang-format: proper c++ standard

by Hoernchen

Hoernchen has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/30536 ) Change subject: clang-format: proper c++ standard ...................................................................... clang-format: proper c++ standard Change-Id: I9828093a08ed8b4c2a11f482f674368ac137d4dc --- M .clang-format 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/36/30536/1 diff --git a/.clang-format b/.clang-format index a11c325..8c68525 100644 --- a/.clang-format +++ b/.clang-format @@ -515,7 +515,7 @@ SpacesInCStyleCastParentheses: false SpacesInParentheses: false SpacesInSquareBrackets: false -Standard: Cpp03 +Standard: Cpp11 TabWidth: 8 UseTab: Always ... -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30536 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I9828093a08ed8b4c2a11f482f674368ac137d4dc Gerrit-Change-Number: 30536 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-trx[master]: ms-trx support

by Hoernchen

Attention is currently required from: Hoernchen, pespin. Hello Jenkins Builder, laforge, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 to look at the new patch set (#16). Change subject: ms-trx support ...................................................................... ms-trx support This is basically a trxcon that includes a transceiver, and can just be used with existing and future apps supporting the trxcon interface, i.e. mobile or ccch_scan. Supports bladerf and uhd, binaries are automatically built if those libs are detected + the osmocom-bb submodule exists. Currently using hardcoded sched/prios aimed at a setup with working, reliable usb and reserved cores, for example a raspi 4 (ONLY 4, not 3, not 2, not any other version) Additionally builds test tools used for development: osmo-trx-syncthing* see https://osmocom.org/projects/baseband/wiki/MS-side_GPRS for the project description and details Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 --- M .gitignore M Makefile.am M Transceiver52M/Makefile.am M Transceiver52M/grgsm_vitac/grgsm_vitac.h A Transceiver52M/ms/bladerf_specific.h A Transceiver52M/ms/itrq.h A Transceiver52M/ms/l1ctl_server.c A Transceiver52M/ms/l1ctl_server_cb.cpp A Transceiver52M/ms/logging.c A Transceiver52M/ms/ms.cpp A Transceiver52M/ms/ms.h A Transceiver52M/ms/ms_rx_burst.h A Transceiver52M/ms/ms_rx_burst_test.cpp A Transceiver52M/ms/ms_rx_lower.cpp A Transceiver52M/ms/ms_upper.cpp A Transceiver52M/ms/ms_upper.h A Transceiver52M/ms/sch.c A Transceiver52M/ms/sch.h A Transceiver52M/ms/uhd_specific.h M configure.ac M contrib/jenkins.sh 21 files changed, 3,472 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/16/30416/16 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/30416 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I36c65a8c725c4da76dc70006cd96b0a2b6878e84 Gerrit-Change-Number: 30416 Gerrit-PatchSet: 16 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: pdch_ulc_get_node(): assert if ulc pointer is null

by osmith

Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30535 ) Change subject: pdch_ulc_get_node(): assert if ulc pointer is null ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: (jenkins verification is temporarily not working for osmo-pcu, as the rpi nodes are offline: https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-pcu-build/133/console) -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2689ceaf39009c5e708d5c72e41744658681c917 Gerrit-Change-Number: 30535 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Dec 2022 11:39:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-pcu[master]: pdch_ulc_get_node(): assert if ulc pointer is null

by pespin

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/30535 ) Change subject: pdch_ulc_get_node(): assert if ulc pointer is null ...................................................................... pdch_ulc_get_node(): assert if ulc pointer is null Make crah more obvious if this condition is reached. Related: SYS#6231 Change-Id: I2689ceaf39009c5e708d5c72e41744658681c917 --- M src/pdch_ul_controller.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/35/30535/1 diff --git a/src/pdch_ul_controller.c b/src/pdch_ul_controller.c index 2ae553f..1746333 100644 --- a/src/pdch_ul_controller.c +++ b/src/pdch_ul_controller.c @@ -71,6 +71,7 @@ struct pdch_ulc_node *pdch_ulc_get_node(struct pdch_ulc *ulc, uint32_t fn) { + OSMO_ASSERT(ulc); struct rb_node *node = ulc->tree_root.rb_node; struct pdch_ulc_node *it; int res; -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/30535 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I2689ceaf39009c5e708d5c72e41744658681c917 Gerrit-Change-Number: 30535 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds,gerrit-verifications: fix node

by pespin

Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30534 ) Change subject: jobs/master-builds,gerrit-verifications: fix node ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I447dd152fcc942ec48d0bcfbadd496e879c882da Gerrit-Change-Number: 30534 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Dec 2022 11:27:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds,gerrit-verifications: fix node

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30534 ) Change subject: jobs/master-builds,gerrit-verifications: fix node ...................................................................... jobs/master-builds,gerrit-verifications: fix node Do not set a node for master-builds and gerrit-verifications to run on, as this leads to needlessly blocking slots on the jenkins nodes. Each of these jobs is a matrix job with a slave_axis. The matrix job itself can run on the "builtin" node, as it practically doesn't cause load - all it does is start other jobs in the matrix (even if there is only one other job, which is the default). Jobs started in the matrix job do run on a configured node already, as the slave_axis parameter is set. I've just noticed this problem because currently the raspberry pi nodes are offline, and so the master-osmo-trx, master-osmo-pcu and other jobs take up lots of build slots just to wait until the raspberry pi nodes come online and an actual build can start. Change-Id: I447dd152fcc942ec48d0bcfbadd496e879c882da --- M jobs/gerrit-verifications.yml M jobs/master-builds.yml 2 files changed, 1 insertion(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/30534/1 diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml index 24dc80d..10cc91b 100644 --- a/jobs/gerrit-verifications.yml +++ b/jobs/gerrit-verifications.yml @@ -31,7 +31,6 @@ # following default values can be overridden by each repo disabled: false concurrent: true - node: osmocom-gerrit # axes related defaults slave_axis: !!python/tuple [osmocom-gerrit] a1_name: a1 @@ -583,7 +582,6 @@ - job-template: name: 'gerrit-{repos}-build' project-type: matrix - node: '{node}' concurrent: '{obj:concurrent}' disabled: '{obj:disabled}' retry-count: 3 # scm checkout diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index 8be2d20..fc713ed 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -5,7 +5,6 @@ # following default values can be overridden by each repo disabled: false concurrent: true - node: 'osmocom-master' # axes related defaults slave_axis: !!python/tuple [osmocom-master] a1_name: a1 @@ -295,8 +294,7 @@ git_base_url: https://gitea.osmocom.org/satellite email: jenkins-notifications(a)lists.osmocom.org 246tnt(a)gmail.com - - osmo-gsm-manuals: - node: 'osmocom-master' + - osmo-gsm-manuals - osmo-gsm-tester: cmd: '{docker_run} {docker_img} {timeout_cmd} /build/contrib/jenkins-build-manuals.sh' @@ -495,7 +493,6 @@ sequential: '{obj:sequential}' combination-filter: | {obj:combination_filter} - node: '{obj:node}' axes: - axis: type: slave -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30534 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I447dd152fcc942ec48d0bcfbadd496e879c882da Gerrit-Change-Number: 30534 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE

by arehbein

arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 ) Change subject: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > No idea on how this ended up merged sorry. Pushing the "done" button shouldn't merge them. […] I do remember that it wasn't blocked even though I forgot the 'refs/for/heads', maybe if a change has been pushed for review previously, it doesn't get blocked the next time you push it (and lead to an auto-merge?)? I mean there's still the option that I clicked the button unconsciously but I'm pretty certain I did not. This is just puzzling me -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I85c2dc201ba485d7bfdcc70e1a5f8a890023c435 Gerrit-Change-Number: 30431 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Dec 2022 11:19:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE

by pespin

Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 ) Change subject: WIP: ns: Add test for SNS Size Num. of IP Endpoints IE ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I really don't know what happened here. […] No idea on how this ended up merged sorry. Pushing the "done" button shouldn't merge them. I suspect you pushed to master directly from your git repo, but I'd expect that to be blocked? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30431 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I85c2dc201ba485d7bfdcc70e1a5f8a890023c435 Gerrit-Change-Number: 30431 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Dec 2022 11:14:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Revert "WIP: ns: Add test for SNS Size Num. of NSVCs IE"

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30543 ) Change subject: Revert "WIP: ns: Add test for SNS Size Num. of NSVCs IE" ...................................................................... Revert "WIP: ns: Add test for SNS Size Num. of NSVCs IE" Revert submission 30430 Reason for revert: I did not consciously merge these, maybe some misunderstanding of Gerrit UI elements. Although it really surprises me that merging could have happened that easily without me noticing Reverted Changes: I85c2dc201:WIP: ns: Add test for SNS Size Num. of IP Endpoint... I3584b7b04:WIP: ns: Add test for SNS Size NSEI IE Ic69c461cd:WIP: ns: Add test for SNS Size Num. of NSVCs IE Change-Id: I838b9b608a939ff909efe24ce3c1fdbfb539939d --- M ns/NS_Tests.ttcn 1 file changed, 0 insertions(+), 26 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index 2b703fc..f57302f 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -640,31 +640,6 @@ f_clean_ns_codec(); } -testcase TC_sns_sgsn_sns_size_outgoing_invalid_num_of_nsvcs() runs on RAW_Test_CT { - f_init_vty(); - f_init_ns_codec(mp_nsconfig); - /* Assumption: No connections to other NSEs for SUT and testcomponent */ - const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; - const integer IDX := 0; - /* Template that would be accepted, only missing the number of IP endpoints - * (since there are no ternary operators in TTCN-3...) */ - var template (omit) PDU_NS ts_base_SNS_SIZE_configured := - ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, - num_v4 := omit, num_v6 := omit); - var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[IDX]; - ts_base_SNS_SIZE_configured.pDU_SNS_Size.nSEI_NS := ts_NS_IE_NSEI(g_nsconfig.nsei); - f_set_num_of_ip_endpoints(ts_base_SNS_SIZE_configured, g_nsconfig.nsvc[0].provider.ip.address_family); - /* Assumption: No connections to other NSEs for SUT and testcomponent and thus no other endpoints */ - const integer required_max_num_of_nsvcs := num_of_nsvcs; - const uint16_t invalid_max_num_of_nsvcs := required_max_num_of_nsvcs - 1; - ts_base_SNS_SIZE_configured.pDU_SNS_Size.maxNumberOfNSVCs := ts_SNS_IE_MaxNumOfNSVCs(invalid_max_num_of_nsvcs); - const NsCause cause := NS_CAUSE_INVALID_NR_OF_NSVCS; - f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); - f_clean_ns_codec(); -} - testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1206,7 +1181,6 @@ execute( TC_sns_sgsn_size_after_success() ); execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); execute( TC_sns_sgsn_sns_size_invalid_num_of_ip_eps() ); - execute( TC_sns_sgsn_sns_size_outgoing_invalid_num_of_nsvcs() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30543 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I838b9b608a939ff909efe24ce3c1fdbfb539939d Gerrit-Change-Number: 30543 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: Revert "WIP: ns: Add test for SNS Size NSEI IE"

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30545 ) Change subject: Revert "WIP: ns: Add test for SNS Size NSEI IE" ...................................................................... Revert "WIP: ns: Add test for SNS Size NSEI IE" Revert submission 30430 Reason for revert: I did not consciously merge these, maybe some misunderstanding of Gerrit UI elements. Although it really surprises me that merging could have happened that easily without me noticing Reverted Changes: I85c2dc201:WIP: ns: Add test for SNS Size Num. of IP Endpoint... I3584b7b04:WIP: ns: Add test for SNS Size NSEI IE Ic69c461cd:WIP: ns: Add test for SNS Size Num. of NSVCs IE Change-Id: Ifab74bd8ae568a3099637fb53f5fe407f85952b6 --- M ns/NS_Tests.ttcn 1 file changed, 0 insertions(+), 51 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ns/NS_Tests.ttcn b/ns/NS_Tests.ttcn index d5af707..722f8ec 100644 --- a/ns/NS_Tests.ttcn +++ b/ns/NS_Tests.ttcn @@ -67,9 +67,6 @@ } } }; - NsIEI mp_ns_iei_num_ipv4_ep := NS_IEI_NUM_IPv4_EP; - NsIEI mp_ns_iei_num_ipv6_ep := NS_IEI_NUM_IPv6_EP; - NsIEI mp_ns_iei_nsei := NS_IEI_NSEI; } type component RAW_Test_CT extends RAW_NS_CT { @@ -562,53 +559,6 @@ /* 48.016 SNS test cases */ /* do a succesful SNS configuration */ -function f_send_expect(in integer NSCP_IDX, in template (omit) PDU_NS pdu, - in NsCause c) runs on RAW_Test_CT { - log("Expected cause: ", c); - NSCP[NSCP_IDX].send(pdu); - f_ns_exp(tr_SNS_SIZE_ACK(g_nsconfig.nsei, c), NSCP_IDX); -} - -function f_set_num_of_ip_endpoints(inout template (omit) PDU_NS base, AddressFamily af) runs on RAW_Test_CT { - const integer NUM_IP := 1; - if (af == AF_INET) { - base.pDU_SNS_Size.numberOfIP4_Endpoints := - {iEI := int2oct(enum2int(mp_ns_iei_num_ipv4_ep), 1), - numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; - } else { - base.pDU_SNS_Size.numberOfIP4_Endpoints := - {iEI := int2oct(enum2int(mp_ns_iei_num_ipv6_ep), 1), - numberOfIP_Endpoints := int2oct(NUM_IP, 2)}; - } -} - -/* Send SNS Size PDUs with invalid IEs */ -testcase TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() runs on RAW_Test_CT { - f_init_vty(); - f_init_ns_codec(mp_nsconfig); - const integer IDX := 0; - /* Assumption: No connections to other NSEs for SUT and testcomponent */ - const integer sgsn_ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer ip4_endpoints := lengthof(mp_nsconfig.nsvc); - const integer num_of_nsvcs := sgsn_ip4_endpoints * ip4_endpoints; - /* Template that would be accepted, only missing the number of IP endpoints - * (since there are no ternary operators in TTCN-3...) */ - var template (omit) PDU_NS ts_base_SNS_SIZE_configured := - ts_SNS_SIZE(g_nsconfig.nsei, rst_flag := true, max_nsvcs := num_of_nsvcs, - num_v4 := omit, num_v6 := omit); - var NSVCConfiguration nsvc_cfg := g_nsconfig.nsvc[IDX]; - - f_set_num_of_ip_endpoints(ts_base_SNS_SIZE_configured, g_nsconfig.nsvc[0].provider.ip.address_family); - /* Syntactical error here: length of 1 (has to be >=2) */ - ts_base_SNS_SIZE_configured.pDU_SNS_Size.nSEI_NS := - {iEI := int2oct(enum2int(mp_ns_iei_nsei), 1), ext := '0'B, lengthIndicator := {length1 := 1}, - nSEI := int2oct(g_nsconfig.nsei, 2)}; - const NsCause cause := NS_CAUSE_INVALID_ESSENTIAL_IE; - f_send_expect(IDX, ts_base_SNS_SIZE_configured, cause); - setverdict(pass); - f_clean_ns_codec(); -} - testcase TC_sns_bss_config_success() runs on RAW_Test_CT { f_init_vty(); f_init_ns_codec(mp_nsconfig); @@ -1148,7 +1098,6 @@ execute( TC_sns_sgsn_add_change_del() ); execute( TC_sns_sgsn_size_correct_port() ); execute( TC_sns_sgsn_size_after_success() ); - execute( TC_sns_sgsn_sns_size_syntactically_wrong_NSEI() ); } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30545 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ifab74bd8ae568a3099637fb53f5fe407f85952b6 Gerrit-Change-Number: 30545 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log December 2022