November 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: ansible/install-poky-sdk: install more depends

by osmith

osmith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-ci/+/30343 ) Change subject: ansible/install-poky-sdk: install more depends ...................................................................... ansible/install-poky-sdk: install more depends Install missing depends file and gcc, and sort the list alphabetically while at it. Fixes: OS#5794 Change-Id: Ia0530859d65818e55498bc97af139b8773445dcf --- M ansible/roles/install-poky-sdk/tasks/main.yml 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/43/30343/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia0530859d65818e55498bc97af139b8773445dcf Gerrit-Change-Number: 30343 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: ansible/install-poky-sdk: install more depends

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/30343 ) Change subject: ansible/install-poky-sdk: install more depends ...................................................................... ansible/install-poky-sdk: install more depends Install missing depends file and gcc, and sort the list alphabetically while at it. Related: OS#5794 Change-Id: Ia0530859d65818e55498bc97af139b8773445dcf --- M ansible/roles/install-poky-sdk/tasks/main.yml 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/43/30343/1 diff --git a/ansible/roles/install-poky-sdk/tasks/main.yml b/ansible/roles/install-poky-sdk/tasks/main.yml index 85b3c94..548f0fb 100644 --- a/ansible/roles/install-poky-sdk/tasks/main.yml +++ b/ansible/roles/install-poky-sdk/tasks/main.yml @@ -1,9 +1,11 @@ --- -- name: install bzip2 and tar +- name: install dependencies for poky installer apt: name: - - tar - bzip2 + - file + - gcc + - tar cache_valid_time: 3600 update_cache: yes -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30343 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia0530859d65818e55498bc97af139b8773445dcf Gerrit-Change-Number: 30343 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trxcon_fsm: shorten DCH related event names

by pespin

Attention is currently required from: laforge, fixeria, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30316 ) Change subject: trxcon: trxcon_fsm: shorten DCH related event names ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie388e251677da63306e9e53d98cbcc7c34777980 Gerrit-Change-Number: 30316 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 10:46:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trxcon_fsm: separate handling of TRXCON_EV_DCH_EST_REQ

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30317 ) Change subject: trxcon: trxcon_fsm: separate handling of TRXCON_EV_DCH_EST_REQ ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8db93fcdace7aaa8bc3876b14e441304349a36d5 Gerrit-Change-Number: 30317 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 10:46:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trxcon_fsm: permit direct DCH/PDCH transitions

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30319 ) Change subject: trxcon: trxcon_fsm: permit direct DCH/PDCH transitions ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: In general I wouldn't go adding allowed transitions if there's no real code path doing those transitions. This helps readers understand the current avaialble transitions in code, not the ones specified in the specs. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30319 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I1a854e4683f102c40f1c174a291b6dc638f49b5c Gerrit-Change-Number: 30319 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 10:45:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmo-ci[master]: ansible: add {host2,build3}-deb11build-ansible

by osmith

Attention is currently required from: laforge. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/30342 ) Change subject: ansible: add {host2,build3}-deb11build-ansible ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/30342 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I15439bb85c1c03a96231ea195d6ad1679a0a1af1 Gerrit-Change-Number: 30342 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 28 Nov 2022 10:45:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trxcon_fsm: permit loop [P]DCH transitions

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30318 ) Change subject: trxcon: trxcon_fsm: permit loop [P]DCH transitions ...................................................................... Patch Set 2: (1 comment) File src/host/trxcon/src/trxcon_fsm.c: https://gerrit.osmocom.org/c/osmocom-bb/+/30318/comment/9dc875d9_ef6dd329 PS1, Line 626: | S(TRXCON_ST_PACKET_DATA), > No, it's not a separate patch. 3GPP TS 44.004, Figure 5. […] But how can you end up transitioning TRXCON_ST_PACKET_DATA -> TRXCON_ST_PACKET_DATA in current code? I see in this patch you have trxcon_st_dedicated_action() calling trxcon_st_dedicated_action() calling handle_dcch_est_req() which ends up calling osmo_fsm_inst_state_chg(fi, TRXCON_ST_DEDICATED, 0, 0);. But for TRXCON_ST_PACKET_DATA I'm unable to see such path? -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3b402ec84610a5df744d9b06e5f7dab7a9a3ddad Gerrit-Change-Number: 30318 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 10:43:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trxcon_fsm: shorten DCH related event names

by fixeria

Attention is currently required from: laforge, msuraev. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30316 ) Change subject: trxcon: trxcon_fsm: shorten DCH related event names ...................................................................... Patch Set 2: (1 comment) This change is ready for review. Patchset: PS1: > You're right, it should actually be 'DCH' (like in 3GPP TS 44.004, section 5.1). Done -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30316 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ie388e251677da63306e9e53d98cbcc7c34777980 Gerrit-Change-Number: 30316 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 28 Nov 2022 10:41:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trxcon_fsm: permit loop [P]DCH transitions

by fixeria

Attention is currently required from: pespin. Hello Jenkins Builder, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30318 to look at the new patch set (#2). Change subject: trxcon: trxcon_fsm: permit loop [P]DCH transitions ...................................................................... trxcon: trxcon_fsm: permit loop [P]DCH transitions According to 3GPP TS 44.004, Figure 5.1, it's absolutely legal to perform loop transitions in state 'DCH' (i.e. from 'DCH' to 'DCH'). This kind of transition is needed in the following cases: * on reciept of RR FREQUENCY REDEFINITION, * on reciept of RR ASSIGNMENT REQUEST, * on reciept of RR HANDOVER REQUEST, when going back from state 'DCH' to state 'BCH' is not required nor actually desired. In context of the trxcon_fsm, this applies to both TRXCON_ST_DEDICATED and TRXCON_ST_PACKET_DATA, as they both represent what's defined as 'DCH' in the Figure 5.1. Change-Id: I3b402ec84610a5df744d9b06e5f7dab7a9a3ddad Related: OS#5599 --- M src/host/trxcon/src/trxcon_fsm.c 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/18/30318/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30318 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I3b402ec84610a5df744d9b06e5f7dab7a9a3ddad Gerrit-Change-Number: 30318 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

Change in osmocom-bb[master]: trxcon: trxcon_fsm: separate handling of TRXCON_EV_DCH_EST_REQ

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, pespin, msuraev, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/30317 to look at the new patch set (#2). Change subject: trxcon: trxcon_fsm: separate handling of TRXCON_EV_DCH_EST_REQ ...................................................................... trxcon: trxcon_fsm: separate handling of TRXCON_EV_DCH_EST_REQ This new function will be re-used in a follow up patch implementing handling of TRXCON_EV_DCH_EST_REQ in TRXCON_ST_{DEDICATED,PACKET_DATA}. Change-Id: I8db93fcdace7aaa8bc3876b14e441304349a36d5 Related: OS#5599 --- M src/host/trxcon/src/trxcon_fsm.c 1 file changed, 70 insertions(+), 66 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/17/30317/2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/30317 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I8db93fcdace7aaa8bc3876b14e441304349a36d5 Gerrit-Change-Number: 30317 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 6 months

1
0
0 0

2025

2024

2023

2022

gerrit-log November 2022