October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-ci[master]: jenkins-gerrit: add note for build fails/pkgs pass

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29794 ) Change subject: jenkins-gerrit: add note for build fails/pkgs pass ...................................................................... jenkins-gerrit: add note for build fails/pkgs pass One might be wondering what happened if the build job failed, but building the binary packages succeeded. Since we run 'make check' in all cases. Add this short explanation: The build job(s) failed, but deb/rpm jobs passed. We don't enable external/vty tests when building packages, so maybe those failed. Check the logs. Related: OS#2385 Change-Id: I70027ec970a220c3ddfa766302faec7bd8752118 --- M scripts/jenkins-gerrit/pipeline_summary.py 1 file changed, 8 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve osmith: Looks good to me, approved msuraev: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/scripts/jenkins-gerrit/pipeline_summary.py b/scripts/jenkins-gerrit/pipeline_summary.py index a47ab7c..95ae821 100755 --- a/scripts/jenkins-gerrit/pipeline_summary.py +++ b/scripts/jenkins-gerrit/pipeline_summary.py @@ -156,6 +156,14 @@ summary += f"{len(jobs['passed'])} passed:\n" summary += get_jobs_list_str(jobs["passed"]) + if "build" in pipeline and "deb" in pipeline and "rpm" in pipeline and \ + not pipeline["build"]["passed"] and pipeline["deb"]["passed"] \ + and pipeline["rpm"]["passed"]: + summary += "\n" + summary += "The build job(s) failed, but deb/rpm jobs passed.\n" + summary += "We don't enable external/vty tests when building\n" + summary += "packages, so maybe those failed. Check the logs.\n" + if "lint" in pipeline and not pipeline["lint"]["passed"]: summary += "\n" summary += "Please fix the linting errors. More information:\n" -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I70027ec970a220c3ddfa766302faec7bd8752118 Gerrit-Change-Number: 29794 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jenkins-gerrit: add note for build fails/pkgs pass

by osmith

Attention is currently required from: pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29794 ) Change subject: jenkins-gerrit: add note for build fails/pkgs pass ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: > I would really avoid clogging the comments with more and more text. […] Got 2x +1, it seems this is useful for others. I'll try to not add much more text though. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29794 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I70027ec970a220c3ddfa766302faec7bd8752118 Gerrit-Change-Number: 29794 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 08:34:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: {ns,sgsn,gbproxy}: gen_links.sh: do not link unused modules

by fixeria

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29831 ) Change subject: {ns,sgsn,gbproxy}: gen_links.sh: do not link unused modules ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fddd010e2a3ce88c892887fc571ae54d84e931f Gerrit-Change-Number: 29831 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 20 Oct 2022 20:37:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: library: move IA/IAR Rest Octets to GSM_RestOctets.ttcn

by fixeria

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29817 to look at the new patch set (#5). Change subject: library: move IA/IAR Rest Octets to GSM_RestOctets.ttcn ...................................................................... library: move IA/IAR Rest Octets to GSM_RestOctets.ttcn Change-Id: Icd96fc461e37d1346950a4fa158e0421bd7330c5 --- M library/GSM_RR_Types.ttcn M library/GSM_RestOctets.ttcn M library/L1CTL_PortType.ttcn M library/LAPDm_RAW_PT.ttcn M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn M pcu/gen_links.sh M selftest/gen_links.sh 8 files changed, 271 insertions(+), 248 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/17/29817/5 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29817 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icd96fc461e37d1346950a4fa158e0421bd7330c5 Gerrit-Change-Number: 29817 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: ns: fix gen_links.sh: do not link unused modules

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29831 ) Change subject: ns: fix gen_links.sh: do not link unused modules ...................................................................... ns: fix gen_links.sh: do not link unused modules Change-Id: I8fddd010e2a3ce88c892887fc571ae54d84e931f --- M ns/gen_links.sh M ns/regen_makefile.sh 2 files changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/31/29831/1 diff --git a/ns/gen_links.sh b/ns/gen_links.sh index 42e5547..8d78ddf 100755 --- a/ns/gen_links.sh +++ b/ns/gen_links.sh @@ -50,12 +50,11 @@ gen_links $DIR $FILES DIR=../library -FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc GSM_Types.ttcn GSM_RR_Types.ttcn Osmocom_Types.ttcn RLCMAC_Templates.ttcn RLCMAC_Types.ttcn RLCMAC_CSN1_Templates.ttcn RLCMAC_CSN1_Types.ttcn RLCMAC_EncDec.cc " +FILES="Misc_Helpers.ttcn General_Types.ttcn Osmocom_VTY_Functions.ttcn Native_Functions.ttcn Native_FunctionDefs.cc GSM_Types.ttcn Osmocom_Types.ttcn " FILES+="StatsD_Types.ttcn StatsD_CodecPort.ttcn StatsD_CodecPort_CtrlFunct.ttcn StatsD_CodecPort_CtrlFunctdef.cc StatsD_Checker.ttcn " FILES+="RAW_NS.ttcnpp NS_Provider_IPL4.ttcn NS_Provider_FR.ttcn NS_Emulation.ttcnpp " FILES+="BSSGP_Emulation.ttcnpp Osmocom_Gb_Types.ttcn " -FILES+="LLC_Templates.ttcn L3_Templates.ttcn L3_Common.ttcn " -FILES+="PCUIF_Types.ttcn PCUIF_CodecPort.ttcn RAW_NS.ttcnpp " +FILES+="LLC_Templates.ttcn " gen_links $DIR $FILES ignore_pp_results diff --git a/ns/regen_makefile.sh b/ns/regen_makefile.sh index 88360d8..ad86d71 100755 --- a/ns/regen_makefile.sh +++ b/ns/regen_makefile.sh @@ -12,7 +12,6 @@ IPL4asp_discovery.cc LLC_EncDec.cc Native_FunctionDefs.cc - RLCMAC_EncDec.cc StatsD_CodecPort_CtrlFunctdef.cc TCCConversion.cc TCCInterface.cc -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29831 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8fddd010e2a3ce88c892887fc571ae54d84e931f Gerrit-Change-Number: 29831 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: gscon_pre_term: properly clear mgw ep

by fixeria

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29815 ) Change subject: gscon_pre_term: properly clear mgw ep ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29815 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I5a9a983bb6135059ec01edf054ea3f7165bb6a6f Gerrit-Change-Number: 29815 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 19:45:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Introduce test TC_mgwpool_pin_bts

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29830 ) Change subject: bsc: Introduce test TC_mgwpool_pin_bts ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29830 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: If6e5ab5e5d3478621306e716836a5c7ddd129c0d Gerrit-Change-Number: 29830 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 19:37:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Add tests for MGW pool features

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29829 ) Change subject: bsc: Add tests for MGW pool features ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29829/comment/4c371883_ad6c… PS1, Line 11845: COORD_CMD_ESTABLISHED I guess this should be private too? https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29829/comment/c1a2de1a_2840… PS1, Line 12266: /* this conditional canbe dropped once osmo-bsc >1.10.0 is released: */ Mark with TODO? Otherwise it's easy to miss this one when making a new release... -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29829 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a8c30309be406e37190dc67b6ee5af13e1b9e68 Gerrit-Change-Number: 29829 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 19:36:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: Support running several MGW node emulations

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29828 ) Change subject: bsc: Support running several MGW node emulations ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29828 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic84726c09ad3c6bea3ce6f0198db862d7dbb6dd3 Gerrit-Change-Number: 29828 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 19:31:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: bsc: rename MGW component s/VirtMSC/VirtMGW/

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29826 ) Change subject: bsc: rename MGW component s/VirtMSC/VirtMGW/ ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29826 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iad5609d691a746104933dacca62c5375063d49de Gerrit-Change-Number: 29826 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Oct 2022 19:28:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022