Attention is currently required from: laforge, pespin.
Hello osmith, Jenkins Builder, laforge, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582
to look at the new patch set (#3).
Change subject: bts: Log unexpected RSL message
......................................................................
bts: Log unexpected RSL message
This is useful when doing first look at failed tests in jenkins.
Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4
---
M bts/BTS_Tests.ttcn
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/29582/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4
Gerrit-Change-Number: 29582
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: laforge, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 )
Change subject: bts: Log unexpected RSL message
......................................................................
Patch Set 2:
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582/comment/9849155d_78b4…
PS2, Line 786: RSL PDU
> port RSL_DCHAN_PT RSL; […]
I suggest saying "RSL port message" in both cases:
* RSL.receive(RSL_Message:?) -- Rx unexpected RSL port message: ...
* RSL.receive -- Rx unexpected RSL port message
In the first case you're specifically catching a record of type RSL_Message, so you print it. In the second case you print nothing, because you're basically catching anything. Yes, all port messages carry RSL PDUs at the moment, but we may add some special ones some day...
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4
Gerrit-Change-Number: 29582
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Oct 2022 09:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: laforge, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582 )
Change subject: bts: Log unexpected RSL message
......................................................................
Patch Set 2:
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582/comment/e7c2115a_0bce…
PS2, Line 786: RSL PDU
> the problem is the overloading of the name RSL with either "RSL Port" and "RSL protocol [message|pac […]
port RSL_DCHAN_PT RSL;
type port RSL_DCHAN_PT message {
inout RSLDC_ChanRqd, RSL_Message, ASP_RSL_Unitdata;
} with { extension "internal" };
type record ASP_RSL_Unitdata {
integer conn_id optional,
IpaStreamId streamId,
RSL_Message rsl
};
SO in the end all have RSL messages, it's just that some have them inside this ASP_RSL_Unitdata record with extra info.
It's cumbersome finding a good informative name here. I don't really care about calling it one way or another here, I just want to have the message content printed. Please any of you who like it one way or another provide me with the exact string you want me to put.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29582
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6cdc53ff038858211b09c0a8eeec19603107ffe4
Gerrit-Change-Number: 29582
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 21 Oct 2022 09:10:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: pespin.
Hello osmith, Jenkins Builder, fixeria,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29829
to look at the new patch set (#2).
Change subject: bsc: Add tests for MGW pool features
......................................................................
bsc: Add tests for MGW pool features
Add a couple tests to validate some MGW pool features, like load
balancing and skip selection blocked MGWs from the pool.
Related: SYS#5987
Change-Id: I6a8c30309be406e37190dc67b6ee5af13e1b9e68
---
M bsc/BSC_Tests.ttcn
1 file changed, 113 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/29/29829/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29829
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I6a8c30309be406e37190dc67b6ee5af13e1b9e68
Gerrit-Change-Number: 29829
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: newpatchset