October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-bsc[master]: gsm48_parse_meas_rep: fix parsing multi-band list

by osmith

Attention is currently required from: neels, pespin, fixeria. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29836 ) Change subject: gsm48_parse_meas_rep: fix parsing multi-band list ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29836/comment/8b6af6d7_6ba9f7cf PS1, Line 780: for (sublist = 1; sublist <= 2; sublist++) { > I think this really is a lot easier to follow by having 2 split for loops,really. loop unrolled -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic5e4f0531e08685460948b102367825588d839ba Gerrit-Change-Number: 29836 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 14:44:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: gsm48_parse_meas_rep: fix parsing multi-band list

by osmith

Attention is currently required from: osmith, neels, fixeria. Hello Jenkins Builder, neels, fixeria, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/29836 to look at the new patch set (#2). Change subject: gsm48_parse_meas_rep: fix parsing multi-band list ...................................................................... gsm48_parse_meas_rep: fix parsing multi-band list When looking up "BCCH-FREQ-NCELL i" from the measurement report, don't treat the BCCH channel list as one list sorted by ascending ARFCN. Instead, treat it as two sub lists, one for the same band, and one for channels in different bands, as described in 3GPP TS 04.08 § 10.5.2.20. This fixes getting the wrong ARFCN from measurement reports in multi-band BSS, which leads to failing handovers. Fixes: OS#5717 Related: osmo-ttcn3-hacks I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286 Change-Id: Ic5e4f0531e08685460948b102367825588d839ba --- M include/osmocom/bsc/system_information.h M src/osmo-bsc/gsm_04_08_rr.c M src/osmo-bsc/system_information.c 3 files changed, 45 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/36/29836/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic5e4f0531e08685460948b102367825588d839ba Gerrit-Change-Number: 29836 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in pysim[master]: contrib/jenkins.sh: set PYTHONUNBUFFERED=1

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29842 ) Change subject: contrib/jenkins.sh: set PYTHONUNBUFFERED=1 ...................................................................... contrib/jenkins.sh: set PYTHONUNBUFFERED=1 Make sure all python output is printed immediatelly. Change-Id: I5d334bbc34e4df39ac54472642299c567894f449 --- M contrib/jenkins.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/42/29842/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index fbcd73c..0ade9b4 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -6,6 +6,8 @@ # * PUBLISH: upload manuals after building if set to "1" (ignored without WITH_MANUALS = "1") # +export PYTHONUNBUFFERED=1 + if [ ! -d "./pysim-testdata/" ] ; then echo "###############################################" echo "Please call from pySim-prog top directory" -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29842 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5d334bbc34e4df39ac54472642299c567894f449 Gerrit-Change-Number: 29842 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in pysim[master]: docs: allow overriding OSMO_GSM_MANUALS_DIR

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/29843 ) Change subject: docs: allow overriding OSMO_GSM_MANUALS_DIR ...................................................................... docs: allow overriding OSMO_GSM_MANUALS_DIR Related: OS#5497 Change-Id: I433217b7aa1cdcddc52a89721e03e44b417bacb1 --- M docs/Makefile 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/43/29843/1 diff --git a/docs/Makefile b/docs/Makefile index e594851..550d4e7 100644 --- a/docs/Makefile +++ b/docs/Makefile @@ -9,7 +9,7 @@ BUILDDIR = _build # for osmo-gsm-manuals -OSMO_GSM_MANUALS_DIR=$(shell pkg-config osmo-gsm-manuals --variable=osmogsmmanualsdir 2>/dev/null) +OSMO_GSM_MANUALS_DIR ?= $(shell pkg-config osmo-gsm-manuals --variable=osmogsmmanualsdir 2>/dev/null) OSMO_REPOSITORY = "pysim" UPLOAD_FILES = $(BUILDDIR)/latex/osmopysim-usermanual.pdf CLEAN_FILES = $(UPLOAD_FILES) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/29843 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I433217b7aa1cdcddc52a89721e03e44b417bacb1 Gerrit-Change-Number: 29843 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: debian-buster-jenkins: add pysim doc/lint depends

by osmith

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/29841 ) Change subject: debian-buster-jenkins: add pysim doc/lint depends ...................................................................... debian-buster-jenkins: add pysim doc/lint depends The lint and docs parts of pysim's contrib/jenkins.sh will run on a different jenkins node than the tests (which has to run on simtester). Add the depends for lint and docs to debian-buster-jenkins, so we can run them in docker. The python libraries construct, pytlv, pyyaml are needed so pylint doesn't print false errors like "Undefined variable 'TLV'". Related: OS#5497 Change-Id: Id5c75725d2fab46b29773fa4f637fa2d73fa7291 --- M debian-buster-jenkins/Dockerfile 1 file changed, 13 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/41/29841/1 diff --git a/debian-buster-jenkins/Dockerfile b/debian-buster-jenkins/Dockerfile index 01a383e..ca11719 100644 --- a/debian-buster-jenkins/Dockerfile +++ b/debian-buster-jenkins/Dockerfile @@ -52,6 +52,7 @@ graphviz \ htop \ inkscape \ + latexmk \ lcov \ libaio-dev \ libasound2-dev \ @@ -122,6 +123,7 @@ sudo \ systemd \ tcpdump \ + tex-gyre \ texinfo \ unzip \ wget \ @@ -138,10 +140,17 @@ # Install pip dependencies (keep in alphabetic order) RUN pip3 install \ - git+https://github.com/podshumok/python-smpplib.git \ - git+https://github.com/eriwen/lcov-to-cobertura-xml.git \ - pydbus \ - pysispm + 'git+https://github.com/eriwen/lcov-to-cobertura-xml.git' \ + 'git+https://github.com/osmocom/sphinx-argparse@master#egg=sphinx-argparse' \ + 'git+https://github.com/podshumok/python-smpplib.git' \ + 'construct>=2.9.51' \ + 'pydbus' \ + 'pylint' \ + 'pysispm' \ + 'pytlv' \ + 'pyyaml>=5.1' \ + 'sphinx' \ + 'sphinxcontrib-napoleon' # match the outside user RUN useradd --uid=1000 build -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29841 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Id5c75725d2fab46b29773fa4f637fa2d73fa7291 Gerrit-Change-Number: 29841 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC: add TC_meas_rep_multi_band

by pespin

Attention is currently required from: osmith, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 ) Change subject: BSC: add TC_meas_rep_multi_band ...................................................................... Patch Set 2: (2 comments) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837/comment/3e829e32_64a5… PS2, Line 11987: * correctly, the third entry has LAC 97. Before this was fixed, the Better drop the "before" references completely, that's mostly adding information about wrong behavior with if at all only adds confusion on the expected way it should work. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837/comment/2dcb3b99_43ee… PS2, Line 12013: f_bts_0_cfg(BSCVTY, don't you need to reset this at some point? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29837 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4fe6bb9e4b5a69ea6204585ebdf1f157a68a8286 Gerrit-Change-Number: 29837 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 14:14:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: osmo-ggsn-master: split RUN command

by osmith

Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29840 ) Change subject: osmo-ggsn-master: split RUN command ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I suggest adding "set -x" at the start of a long command instead, then each individual command will be printed as it runs. This makes debugging easier. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I014cb5499820a26b46714fee1a55381e9013cdad Gerrit-Change-Number: 29840 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 14:13:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: osmo-ggsn-master: split RUN command

by osmith

Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29840 ) Change subject: osmo-ggsn-master: split RUN command ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Patchset: PS1: While it looks better, this takes much longer to execute. Docker creates a snapshot of the filesystem in the docker container it is building after each RUN command. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I014cb5499820a26b46714fee1a55381e9013cdad Gerrit-Change-Number: 29840 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 14:11:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: gsm48_parse_meas_rep: fix parsing multi-band list

by pespin

Attention is currently required from: osmith, neels, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29836 ) Change subject: gsm48_parse_meas_rep: fix parsing multi-band list ...................................................................... Patch Set 1: (1 comment) File src/osmo-bsc/gsm_04_08_rr.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29836/comment/11cca611_e55710d0 PS1, Line 780: for (sublist = 1; sublist <= 2; sublist++) { I think this really is a lot easier to follow by having 2 split for loops,really. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29836 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ic5e4f0531e08685460948b102367825588d839ba Gerrit-Change-Number: 29836 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 14:10:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: osmo-ggsn-master: split RUN command

by pespin

Attention is currently required from: osmith, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29840 ) Change subject: osmo-ggsn-master: split RUN command ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I'm not really sure it makes sense to have those separate RUN statements, since it's soemthing you want to have done in one run. -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29840 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I014cb5499820a26b46714fee1a55381e9013cdad Gerrit-Change-Number: 29840 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 21 Oct 2022 14:05:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022