October 2022 - gerrit-log - lists.osmocom.org

Build failure of network:osmocom:nightly/osmo-e1d in Raspbian_10/armv7l

by OBS Notification

Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/o… Package network:osmocom:nightly/osmo-e1d failed to build in Raspbian_10/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-e1d Last lines of build log: [ 322s] [447/461] installing texlive-extra-utils-2018.20190227-2 [ 329s] [448/461] installing texlive-2018.20190227-2 [ 329s] [449/461] installing texlive-pictures-2018.20190227-2 [ 331s] [450/461] installing texlive-science-2018.20190227-2 [ 333s] [451/461] installing libgtk2.0-0-2.24.32-3 [ 333s] [452/461] installing texlive-latex-extra-2018.20190227-2 [ 339s] [453/461] installing libgtkmm-2.4-1v5-1:2.24.5-4 [ 340s] [454/461] installing libgtkspell0-2.0.16-1.2 [ 340s] [455/461] installing texlive-xetex-2018.20190227-2 [ 343s] [456/461] installing dblatex-0.3.10-2 [ 344s] [457/461] installing inkscape-0.92.4-3 [ 350s] [458/461] installing texlive-formats-extra-2018.20190227-2 [ 352s] [459/461] installing docbook-utils-0.6.14-3.3 [ 352s] Processing triggers for sgml-base (1.29) ... [ 352s] [460/461] installing asciidoc-dblatex-8.6.10-3 [ 362s] dpkg-deb (subprocess): decompressing archive member: lzma error: compressed data is corrupt [ 362s] dpkg-deb: error: <decompress> subprocess returned error exit status 2 [ 362s] dpkg: error processing archive .init_b_cache/asciidoc-dblatex.deb (--install): [ 362s] dpkg-deb --fsys-tarfile subprocess returned error exit status 2 [ 362s] Errors were encountered while processing: [ 362s] .init_b_cache/asciidoc-dblatex.deb [ 362s] exit ... [ 362s] ### VM INTERACTION START ### [ 363s] [ 330.267597] sysrq: SysRq : Power Off [ 363s] [ 330.269217] reboot: Power down [ 363s] ### VM INTERACTION END ### [ 363s] [ 363s] armbuild02 failed "build osmo-e1d_0.4.0.8.56a7.202210250053.dsc" at Tue Oct 25 03:15:56 UTC 2022. [ 363s] -- Configure notifications at https://build.opensuse.org/my/subscriptions openSUSE Build Service (https://build.opensuse.org/)

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: Add BTS setup ramping to prevent BSC overloading

by neels

Attention is currently required from: fixeria, lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29788 ) Change subject: Add BTS setup ramping to prevent BSC overloading ...................................................................... Patch Set 3: (4 comments) File include/osmocom/bsc/bts_setup_ramp.h: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/5aa50e91_c674beec PS3, Line 31: BTS_SETUP_RAMP_INIT, /** initial state */ (osmo-bsc doesn't generate doxygen, but just saying: the correct doxygen syntaxes here would be BTS_FOO, /*< foo */ because otherwise it is seen as comment for the subsequent line; or /*! foo */ BTS_FOO because osmocom has decided on '/*!' instead of the IMHO nicer '/**' ) File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/3c286c2a_1a550b19 PS1, Line 1284: "allow-bts-configuration <0-65535>", > What I actually suggest is to implement it as 'bts <0-255> bts-unblock-bringup-ramping', so that it' […] (i also prefer 'bts <0-255> foo') File src/osmo-bsc/bts_setup_ramp.c: https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/7543cc16_6dfc2e05 PS3, Line 62: * \brief Unblock a BTS from BTS setup ramping to allow it to setup and configure. please don't use '\brief', our doxygen config has AUTOBRIEF set https://gerrit.osmocom.org/c/osmo-bsc/+/29788/comment/56554042_3e428810 PS3, Line 77: * \brief Timer callback and called by bts_setup_ramp_deactivate drop \brief and end the line with a period (same below) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29788 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Id56dde6d58f3d0d20352f6c306598d2cccc6345d Gerrit-Change-Number: 29788 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 24 Oct 2022 21:52:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: bts_ipaccess_nanobts: remove unused assignment

by neels

Attention is currently required from: lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29786 ) Change subject: bts_ipaccess_nanobts: remove unused assignment ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: I thought "RSL Assignment" =) -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I811f7c596de42eff250b1882a9e2e7cdece6259d Gerrit-Change-Number: 29786 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 24 Oct 2022 21:33:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: cosmetic: Clarify and fix typos in comment

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29859 ) Change subject: cosmetic: Clarify and fix typos in comment ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29859/comment/27e26d88_550b9836 PS1, Line 1530: t also add missing ')' https://gerrit.osmocom.org/c/osmo-mgw/+/29859/comment/b5aed591_ef13d30d PS1, Line 1532: * expectation. */ (this comment describes the non-compliant behavior of osmo-mgw; we may soon have to discuss that separately, because this behavior may torpedo proper codec handling in osmo-msc... i created an issue for that: https://osmocom.org/issues/5726 ) -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29859 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibcbe7d85cf7e1912de73d59540f2dea1dfa5d98d Gerrit-Change-Number: 29859 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 21:29:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: osmux: Make sure RTP AMR feed to osmux is in octet-aligned mode

by neels

Attention is currently required from: pespin, dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29867 ) Change subject: osmux: Make sure RTP AMR feed to osmux is in octet-aligned mode ...................................................................... Patch Set 2: (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29867/comment/78ca37c0_3c2b3d8e PS2, Line 723: * boundaries. This function is used to convert between the two modes */ > Since this function was static before there was not doxygen apidoc added. […] ack, especially if this is now public libosmo-mgcp API File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29867/comment/4971680f_f3bf2a42 PS2, Line 230: /* Osmux implementation works with AMR OA only, make sure we convert to it if needed: */ i would prefer having two patches, 1) the API change to use msgb and 2) adding the conversion to OA The actual conversion to OA seems to be a very short bit that is orthogonal to the rest, reads cluttered -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifeec44241079f7a31da12745c92bfdc4fb222f3a Gerrit-Change-Number: 29867 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 20:54:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgw: Rename s/mgcp_send_rtp/mgcp_rtp_conn_dispatch_rtp/

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29865 ) Change subject: mgw: Rename s/mgcp_send_rtp/mgcp_rtp_conn_dispatch_rtp/ ...................................................................... Patch Set 1: Code-Review+1 (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29865/comment/9fd3f384_feb19791 PS1, Line 986: rs might as well fix this typo too while at it (and use full line width maybe) https://gerrit.osmocom.org/c/osmo-mgw/+/29865/comment/e1a934e8_c255362e PS1, Line 987: static int mgcp_rtp_conn_dispatch_rtp(struct mgcp_conn_rtp *conn_dst, struct msgb *msg) mgcp_conn_rtp_dispatch_rtp() the struct is called 'mgcp_conn_rtp', we have three functions in the form 'mgcp_conn_rtp_*' matching the struct name, and two mismatching 'mgcp_rtp_conn_*' -- maybe it would be better to stick with a name matching the struct name. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idaf791997b8438a4aede50f614afa0d55ad41faa Gerrit-Change-Number: 29865 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 20:45:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgw: rx_rtp(): reorder checks and handlings

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29864 ) Change subject: mgw: rx_rtp(): reorder checks and handlings ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/29864/comment/b8296e75_934230b2 PS1, Line 9: Let's first validate the origin of the message, then the content of the (you're using "Let's" regularly, but from https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards : "You should stick to the imperative form -- e.g. "add foo", "fix bar", "drop baz" -- and avoid empty phrasing like "this patch implements". This is shortest to write and, more importantly, most efficient to read for reviewers.") Patchset: PS1: I am missing the point of the patch, can you explain the motivation / the effects in the commit log? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I011a6d7d705768c32a35cec5cd7169725a21a670 Gerrit-Change-Number: 29864 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 20:38:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgw: reuse mgcp_codec_amr_mode_is_indicated() in mgcp_codec_amr_is_oc...

by neels

Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29863 ) Change subject: mgw: reuse mgcp_codec_amr_mode_is_indicated() in mgcp_codec_amr_is_octet_aligned() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: sorry, my firm opinion is to keep the function exactly as it was, it is short enough, and i prefer not mixing it with the weird/obscure aspects of that other function: osmo-mgw should not check whether a fmtp is present, just what the resulting (explicit or implicit) OA setting ends up being. In the long run i'd rather get rid of that other function instead of expanding its use. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4c18510b59fd917ed033393994b21517bf753510 Gerrit-Change-Number: 29863 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 20:31:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: AMR->IuUP: log conversion, like for the flipside

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29857 ) Change subject: AMR->IuUP: log conversion, like for the flipside ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29857 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I525685a7dedb6d5d1deecbd026844cbe23193fac Gerrit-Change-Number: 29857 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 24 Oct 2022 20:26:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: cosmetic: Fix indentation whitespace

by pespin

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29866 ) Change subject: cosmetic: Fix indentation whitespace ...................................................................... cosmetic: Fix indentation whitespace Change-Id: Ia47d30aceee0db30b403575dd696c1bec2dcf271 --- M src/osmux_input.c 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/src/osmux_input.c b/src/osmux_input.c index 2c18b20..3420e8b 100644 --- a/src/osmux_input.c +++ b/src/osmux_input.c @@ -563,9 +563,9 @@ return 0; default: /* The RTP payload type is dynamically allocated, - * although we use static ones. Assume that we always - * receive AMR traffic. - */ + * although we use static ones. Assume that we always + * receive AMR traffic. + */ /* Add this RTP to the OSMUX batch */ ret = osmux_batch_add(batch, h->batch_factor, -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29866 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ia47d30aceee0db30b403575dd696c1bec2dcf271 Gerrit-Change-Number: 29866 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022