October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-mgw[master]: osmux: Make sure RTP AMR feed to osmux is in octet-aligned mode

by pespin

Attention is currently required from: neels, dexter. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29867 ) Change subject: osmux: Make sure RTP AMR feed to osmux is in octet-aligned mode ...................................................................... Patch Set 2: (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29867/comment/0696a7a6_be0a62ee PS2, Line 723: * boundaries. This function is used to convert between the two modes */ > ack, especially if this is now public libosmo-mgcp API The libosmo-mgcp is actually internal to osmo-mgw, and IMHO should be dropped completely and merged into osmo-mgw since it causes more trouble than benefits. File src/libosmo-mgcp/mgcp_osmux.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29867/comment/11f64398_66bef826 PS2, Line 230: /* Osmux implementation works with AMR OA only, make sure we convert to it if needed: */ > i would prefer having two patches, 1) the API change to use msgb and 2) adding the conversion to OA […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29867 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ifeec44241079f7a31da12745c92bfdc4fb222f3a Gerrit-Change-Number: 29867 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Oct 2022 11:22:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: BSC_Tests: fix TC_mgwpool_pin_bts: do not leave MGW1 configured

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29872 ) Change subject: BSC_Tests: fix TC_mgwpool_pin_bts: do not leave MGW1 configured ...................................................................... BSC_Tests: fix TC_mgwpool_pin_bts: do not leave MGW1 configured For the purpose of testing MGW pooling, test cases TC_mgwpool_* configure an additional MGW instance by calling f_vty_mgw_enable() and then remove it by calling f_vty_mgw_disable(). Unlike the other two TC_mgwpool_* test cases, TC_mgwpool_pin_bts does not call f_vty_mgw_disable() - this breaks LCLS testcases executed after it. Add the missing call. Change-Id: I3157203888d704b25aabd2569035cd95d48c48b2 Fixes: 3f41e321c74eeab52ad1c8f20b006882e33cf586 Fixes: OS#5727 --- M bsc/BSC_Tests.ttcn 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/72/29872/1 diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 0c6efd1..81a1901 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -11954,6 +11954,7 @@ vc_conn2.done; f_vty_cfg_bts(BSCVTY, 0, { "no mgw pool-target" } ); + f_vty_mgw_disable(1); f_shutdown_helper(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29872 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3157203888d704b25aabd2569035cd95d48c48b2 Gerrit-Change-Number: 29872 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgw: Rename s/mgcp_send_rtp/mgcp_rtp_conn_dispatch_rtp/

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29865 ) Change subject: mgw: Rename s/mgcp_send_rtp/mgcp_rtp_conn_dispatch_rtp/ ...................................................................... Patch Set 1: (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29865/comment/a233284b_4727b8c9 PS1, Line 986: rs > might as well fix this typo too while at it (and use full line width maybe) Ack https://gerrit.osmocom.org/c/osmo-mgw/+/29865/comment/76543cf0_4acb385b PS1, Line 987: static int mgcp_rtp_conn_dispatch_rtp(struct mgcp_conn_rtp *conn_dst, struct msgb *msg) > mgcp_conn_rtp_dispatch_rtp() […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29865 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idaf791997b8438a4aede50f614afa0d55ad41faa Gerrit-Change-Number: 29865 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Oct 2022 11:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgw: rx_rtp(): reorder checks and handlings

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29864 ) Change subject: mgw: rx_rtp(): reorder checks and handlings ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/29864/comment/eb02d7fe_024e9ac0 PS1, Line 9: Let's first validate the origin of the message, then the content of the > (you're using "Let's" regularly, but from https://osmocom. […] I'd say the imperative form is specially useful in the first line since it needs to be short. But if this really annoys you I'll change it. Patchset: PS1: > I am missing the point of the patch, can you explain the motivation / the effects in the commit log? The motivation is explained in the commit log already. It makes sense to first look at the origin of the message before even start looking at its content, to avoid unexpected senders sending us potentially bad data which may cause some trouble in the app while parsing it. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I011a6d7d705768c32a35cec5cd7169725a21a670 Gerrit-Change-Number: 29864 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-CC: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Oct 2022 11:21:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: mgw: reuse mgcp_codec_amr_mode_is_indicated() in mgcp_codec_amr_is_oc...

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29863 ) Change subject: mgw: reuse mgcp_codec_amr_mode_is_indicated() in mgcp_codec_amr_is_octet_aligned() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > sorry, my firm opinion is to keep the function exactly as it was, […] Ok, if you are disturbed by this patch I'll simply abandon it, though I think the current state of things is clearer this way. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29863 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4c18510b59fd917ed033393994b21517bf753510 Gerrit-Change-Number: 29863 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Oct 2022 11:17:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: Rename and move func checking if amr mode is explicitly configured

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29861 ) Change subject: Rename and move func checking if amr mode is explicitly configured ...................................................................... Patch Set 1: (1 comment) File include/osmocom/mgcp/mgcp_codec.h: https://gerrit.osmocom.org/c/osmo-mgw/+/29861/comment/079a12dd_0d78fae0 PS1, Line 20: bool mgcp_codec_amr_mode_is_indicated(const struct mgcp_rtp_codec *codec); > problems: […] First dot: I'll rename it to mgcp_codec_amr_mode_is_indicated(). Second dot: Changing he non-compliant code logic has a lot of implications like breaking compatibility with older clients. This needs to be done carefully and it's something out of the scope of this patchset. I'm just cleaning current code maintaining logic here. Third dot: I initially thought about using this function in osmux.c but finally it seems I didn't. I'll leave it static. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29861 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I8dce3038ebccf5e1e37e2908070a67d66693a96f Gerrit-Change-Number: 29861 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Oct 2022 11:16:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-mgw[master]: cosmetic: Clarify and fix typos in comment

by pespin

Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29859 ) Change subject: cosmetic: Clarify and fix typos in comment ...................................................................... Patch Set 1: (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/29859/comment/8c815d91_e9702409 PS1, Line 1530: t > also add missing ')' Ack https://gerrit.osmocom.org/c/osmo-mgw/+/29859/comment/003c9838_0f314c51 PS1, Line 1532: * expectation. */ > (this comment describes the non-compliant behavior of osmo-mgw; we may soon have to discuss that sep […] ACK. Be it non-compliant or not, this patch and the other is clarifying what the heck osmo-mgw is doing here and sheding some light on the topic. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29859 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibcbe7d85cf7e1912de73d59540f2dea1dfa5d98d Gerrit-Change-Number: 29859 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Oct 2022 11:07:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: add ice40-usbtrace

by osmith

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29862 ) Change subject: jobs/master-builds: add ice40-usbtrace ...................................................................... jobs/master-builds: add ice40-usbtrace Related: OS#6169 Change-Id: I8872f20eabf2975aea602c9e95f66d144f74742d --- M jobs/master-builds.yml 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index e7b4c61..3371356 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -237,6 +237,10 @@ - osmo-e1-hardware: docker_img: 'registry.osmocom.org/$USER/fpga-build' cmd: 'docker pull {docker_img} && {docker_run} {docker_img} /build/contrib/jenkins.sh --publish' + - ice40-usbtrace: + git_base_url: https://gitea.osmocom.org/electronics + docker_img: 'registry.osmocom.org/$USER/fpga-build' + cmd: 'docker pull {docker_img} && {docker_run} {docker_img} /build/contrib/jenkins.sh --publish' - no2bootloader: git_base_url: https://github.com/no2fpga docker_img: 'registry.osmocom.org/$USER/fpga-build' -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8872f20eabf2975aea602c9e95f66d144f74742d Gerrit-Change-Number: 29862 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: add ice40-usbtrace

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29862 ) Change subject: jobs/master-builds: add ice40-usbtrace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8872f20eabf2975aea602c9e95f66d144f74742d Gerrit-Change-Number: 29862 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Oct 2022 11:02:40 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: jobs/master-builds: add ice40-usbtrace

by osmith

osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29862 ) Change subject: jobs/master-builds: add ice40-usbtrace ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: ah this wasn't merged yet. this is trivial though, it's already deployed and I closed the issue already, merging this as well. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29862 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I8872f20eabf2975aea602c9e95f66d144f74742d Gerrit-Change-Number: 29862 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 25 Oct 2022 11:02:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022