October 2022 - gerrit-log - lists.osmocom.org

Change in docker-playground[master]: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-remote-host'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29557 ) Change subject: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-remote-host' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29557 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib7d6e564e12db08a8dd4890426d2599b3260fa9d Gerrit-Change-Number: 29557 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:41:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-category enable-all'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29556 ) Change subject: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-category enable-all' ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19fbb75890935a338c31b7eb5e624ec988f91468 Gerrit-Change-Number: 29556 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:40:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: Better handling of send() error

by pespin

Attention is currently required from: msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29555 ) Change subject: Better handling of send() error ...................................................................... Patch Set 1: (1 comment) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29555/comment/e928417a_c2f18203 PS1, Line 1335: LOGP(DLINP, LOGL_ERROR, "error to send: %s\n", (ret == -1) ? strerror(errno) : strerror(-ret)); there's no function here returning a value < -1, so this line should be totally changed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29555 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Iaa7e16e717c56466c5d9a64deb438776ca88022e Gerrit-Change-Number: 29555 Gerrit-PatchSet: 1 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:40:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Update MNCC field validation mask.

by fixeria

Attention is currently required from: keith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/29559 ) Change subject: Update MNCC field validation mask. ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/29559/comment/e562f6ac_0c86370d PS1, Line 13: #OS5282 OS#5282 File src/libmsc/mncc.c: https://gerrit.osmocom.org/c/osmo-msc/+/29559/comment/281e3ca4_ab5eb5b4 PS1, Line 113: 0x7fff Good catch. It's indeed so easy to forget updating this mask because all other MNCC_F_* entries are defined in 'include/osmocom/msc/mncc.h', while this one lives here. I believe it's a good idea to move MNCC_F_ALL to the header. Will submit a patch on top of yours. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d Gerrit-Change-Number: 29559 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:38:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29554 ) Change subject: scripts: osmo_git_clone_url(): properly handle 'satellite/osmo-gmr' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29554 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I4d52dbf0f81332dc1856944a6a3c7376cb1e0638 Gerrit-Change-Number: 29554 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:33:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-ci[master]: coverity/prepare_source_Osmocom.sh: execute with '-xe'

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29553 ) Change subject: coverity/prepare_source_Osmocom.sh: execute with '-xe' ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29553 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Icf6546271a01cd9a3dab1ce0d1bc02807d08ad85 Gerrit-Change-Number: 29553 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 08:32:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

by keith

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 to look at the new patch set (#2). Change subject: Set MNCC_F_GCR field when the gcr is present ...................................................................... Set MNCC_F_GCR field when the gcr is present Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the MNCC field flag MNCC_F_GCR should be set when the GCR is present, but did not set it. Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692 --- M src/mncc.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/60/29560/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692 Gerrit-Change-Number: 29560 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in osmo-sip-connector[master]: Set MNCC_F_GCR field when the gcr is present

by keith

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 ) Change subject: Set MNCC_F_GCR field when the gcr is present ...................................................................... Set MNCC_F_GCR field when the gcr is present Commit bd66804082bf813a1f925c6af4df28fd664ac1de established that the MNCC field flag MNCC_F_GCR should be set when the GCR is present, but did not set it. Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692 --- M src/mncc.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/60/29560/1 diff --git a/src/mncc.c b/src/mncc.c index f302b3e..ddc1ae6 100644 --- a/src/mncc.c +++ b/src/mncc.c @@ -936,10 +936,13 @@ /* Encode the Global Call Reference (if present) */ if (call->gcr_present) { msg = msgb_alloc(sizeof(mncc.gcr), "MNCC GCR"); - if (msg == NULL || (rc = osmo_enc_gcr(msg, &call->gcr)) == 0) + if (msg == NULL || (rc = osmo_enc_gcr(msg, &call->gcr)) == 0) { LOGP(DMNCC, LOGL_ERROR, "MNCC leg(%u) failed to encode GCR\n", call->id); - else + } else { memcpy(&mncc.gcr[0], msg->data, rc); + mncc.fields |= MNCC_F_GCR; + } + msgb_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29560 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Idad3210055a0d25be6220301b965e3d4c7323692 Gerrit-Change-Number: 29560 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Update MNCC field validation mask.

by keith

keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/29559 ) Change subject: Update MNCC field validation mask. ...................................................................... Update MNCC field validation mask. In c6921e5068ba62cde67707fb3c8103919d1e0c0e, 0x4000 was added to the possible MNCC field flags, but before this commit, using it would result in an ERROR of "Unknown MNCC field mask 0x....." Related: #OS5282 Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d --- M src/libmsc/mncc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/59/29559/1 diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c index 0a38997..f446f98 100644 --- a/src/libmsc/mncc.c +++ b/src/libmsc/mncc.c @@ -110,7 +110,7 @@ * MNCC validation code. Move to libosmocore once headers are merged ************************************************************************/ -#define MNCC_F_ALL 0x3fff +#define MNCC_F_ALL 0x7fff static int check_string_terminated(const char *str, unsigned int size) { -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d Gerrit-Change-Number: 29559 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-ttcn3-hacks[master]: pcu: osmo-pcu.cfg: update GSMTAP Um logging configuration

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29558 ) Change subject: pcu: osmo-pcu.cfg: update GSMTAP Um logging configuration ...................................................................... pcu: osmo-pcu.cfg: update GSMTAP Um logging configuration Change-Id: Ia53f59da04fd30f055ee3a6a46e9afb5ecd48162 --- M pcu/osmo-pcu.cfg 1 file changed, 2 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/58/29558/1 diff --git a/pcu/osmo-pcu.cfg b/pcu/osmo-pcu.cfg index 31f8cda..f33dfd8 100644 --- a/pcu/osmo-pcu.cfg +++ b/pcu/osmo-pcu.cfg @@ -32,17 +32,5 @@ gamma 0 pcu-socket /tmp/pcu_bts neighbor resolution 127.0.0.1 - gsmtap-category dl-unknown - gsmtap-category dl-dummy - gsmtap-category dl-ctrl - gsmtap-category dl-data-gprs - gsmtap-category dl-data-egprs - gsmtap-category dl-ptcch - gsmtap-category dl-agch - gsmtap-category dl-pch - gsmtap-category ul-unknown - gsmtap-category ul-dummy - gsmtap-category ul-ctrl - gsmtap-category ul-data-gprs - gsmtap-category ul-data-egprs - gsmtap-category ul-rach + gsmtap-remote-host 127.0.0.1 + gsmtap-category enable-all -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/29558 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia53f59da04fd30f055ee3a6a46e9afb5ecd48162 Gerrit-Change-Number: 29558 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022