October 2022 - gerrit-log - lists.osmocom.org

Change in osmo-sip-connector[master]: mncc: fix MNCC_SETUP_REQ: set MNCC_F_GCR if GCR is present

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/29561 ) Change subject: mncc: fix MNCC_SETUP_REQ: set MNCC_F_GCR if GCR is present ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Haven't i seen this patch already somewhere else? -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I9dd22caef78e37543dac8a6b31a6ee349e7e5aa8 Gerrit-Change-Number: 29561 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:21:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: mncc: cosmetic: fix coding style in mncc_prim_check_sign()

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/29563 ) Change subject: mncc: cosmetic: fix coding style in mncc_prim_check_sign() ...................................................................... mncc: cosmetic: fix coding style in mncc_prim_check_sign() Change-Id: I94d9cba7aca19f28c906e05dd86bfe3020abd5b1 Related: OS#5282 --- M src/libmsc/mncc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/63/29563/1 diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c index 24e79a7..026dae0 100644 --- a/src/libmsc/mncc.c +++ b/src/libmsc/mncc.c @@ -155,7 +155,7 @@ { int rc; - if (mncc_prim->fields & ~ MNCC_F_ALL) { + if (mncc_prim->fields & ~MNCC_F_ALL) { LOGP(DMNCC, LOGL_ERROR, "Unknown MNCC field mask 0x%x\n", mncc_prim->fields); return -EINVAL; } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29563 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I94d9cba7aca19f28c906e05dd86bfe3020abd5b1 Gerrit-Change-Number: 29563 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: mncc: move MNCC_F_ALL from mncc.c to mncc.h

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/29562 ) Change subject: mncc: move MNCC_F_ALL from mncc.c to mncc.h ...................................................................... mncc: move MNCC_F_ALL from mncc.c to mncc.h Move it closer to the other MNCC_F_* entries, so that it's more likely that it gets updated when new flags are added. Change-Id: If1a12a696b87184c9eee14f475594c317927427b Related: OS#5282 --- M include/osmocom/msc/mncc.h M src/libmsc/mncc.c 2 files changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/62/29562/1 diff --git a/include/osmocom/msc/mncc.h b/include/osmocom/msc/mncc.h index 06a5dcc..8a1e4ad 100644 --- a/include/osmocom/msc/mncc.h +++ b/include/osmocom/msc/mncc.h @@ -126,6 +126,9 @@ #define MNCC_F_SIGNAL 0x2000 #define MNCC_F_GCR 0x4000 +/* UPDATEME when adding new MNCC_F_* entries above */ +#define MNCC_F_ALL 0x7fff + struct gsm_mncc { /* context based information */ uint32_t msg_type; diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c index f446f98..24e79a7 100644 --- a/src/libmsc/mncc.c +++ b/src/libmsc/mncc.c @@ -110,8 +110,6 @@ * MNCC validation code. Move to libosmocore once headers are merged ************************************************************************/ -#define MNCC_F_ALL 0x7fff - static int check_string_terminated(const char *str, unsigned int size) { int i; -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29562 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: If1a12a696b87184c9eee14f475594c317927427b Gerrit-Change-Number: 29562 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-msc[master]: Update MNCC field validation mask.

by fixeria

Attention is currently required from: keith. fixeria has uploaded a new patch set (#2) to the change originally created by keith. ( https://gerrit.osmocom.org/c/osmo-msc/+/29559 ) Change subject: Update MNCC field validation mask. ...................................................................... Update MNCC field validation mask. In c6921e5068ba62cde67707fb3c8103919d1e0c0e, 0x4000 was added to the possible MNCC field flags, but before this commit, using it would result in an ERROR of "Unknown MNCC field mask 0x....." Related: OS#5282 Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d --- M src/libmsc/mncc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/59/29559/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/29559 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I9e7d224e7f2d6d2824b2466752b6e8c994ac5a3d Gerrit-Change-Number: 29559 Gerrit-PatchSet: 2 Gerrit-Owner: keith <keith(a)rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: keith <keith(a)rhizomatica.org> Gerrit-MessageType: newpatchset

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Allocate struct osmux_out_handle through API

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29528 ) Change subject: osmux: Allocate struct osmux_out_handle through API ...................................................................... Patch Set 1: (1 comment) File src/osmux_input.c: https://gerrit.osmocom.org/c/libosmo-netif/+/29528/comment/c8102dcf_c92558ef PS1, Line 737: /* DEPRECATED: Use talloc_free() instead (will call osmux_xfrm_input_talloc_destructor()) */ > What are the benefits of using a talloc destructor? If I allocate something with talloc, then yes, I […] I chose to use a talloc destructor because it makes it easier to destroy the object when the parent object is destroy and make sure stuff is not left around. This is useful for existing users to transition to the new talloc allocated API, since they don't need necessarily to care about finding out where to destroy the object in the existing code. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29528 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I752ab031f935f04731bb1a354333f1682a1aa5bd Gerrit-Change-Number: 29528 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:19:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in osmo-sip-connector[master]: mncc: fix MNCC_SETUP_REQ: set MNCC_F_GCR if GCR is present

by fixeria

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/29561 ) Change subject: mncc: fix MNCC_SETUP_REQ: set MNCC_F_GCR if GCR is present ...................................................................... mncc: fix MNCC_SETUP_REQ: set MNCC_F_GCR if GCR is present Change-Id: I9dd22caef78e37543dac8a6b31a6ee349e7e5aa8 Related: OS#5282 --- M src/mncc.c 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/61/29561/1 diff --git a/src/mncc.c b/src/mncc.c index f302b3e..02ba2cc 100644 --- a/src/mncc.c +++ b/src/mncc.c @@ -936,10 +936,12 @@ /* Encode the Global Call Reference (if present) */ if (call->gcr_present) { msg = msgb_alloc(sizeof(mncc.gcr), "MNCC GCR"); - if (msg == NULL || (rc = osmo_enc_gcr(msg, &call->gcr)) == 0) + if (msg == NULL || (rc = osmo_enc_gcr(msg, &call->gcr)) == 0) { LOGP(DMNCC, LOGL_ERROR, "MNCC leg(%u) failed to encode GCR\n", call->id); - else + } else { memcpy(&mncc.gcr[0], msg->data, rc); + mncc.fields |= MNCC_F_GCR; + } msgb_free(msg); } -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/29561 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: I9dd22caef78e37543dac8a6b31a6ee349e7e5aa8 Gerrit-Change-Number: 29561 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newchange

2 years, 8 months

1
0
0 0

Change in osmo-bsc[master]: vty: 'hopping arfcn add': succeed if adding arfcn already in set

by pespin

Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29551 ) Change subject: vty: 'hopping arfcn add': succeed if adding arfcn already in set ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Who reads those warnings? I did in order to find out what the issue was. > I am not really sure if blindly appending hopping ARFCNs is correct. Imagine an operator wants to configure a new set. I think the existing set must be cleaned first, otherwise you may end up having a mix of old and new ARFCNs. This is really an orthogonal discussion and it's up to the user/customer to decide how do they want to do it, aka if they need a clear command or not. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/29551 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia4e70d20d48a28c46a21dd10358577e5c798744c Gerrit-Change-Number: 29551 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:15:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-remote-host'

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29557 ) Change subject: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-remote-host' ...................................................................... ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-remote-host' Change-Id: Ib7d6e564e12db08a8dd4890426d2599b3260fa9d --- M ttcn3-pcu-test/jenkins.sh M ttcn3-pcu-test/osmo-pcu.cfg 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ttcn3-pcu-test/jenkins.sh b/ttcn3-pcu-test/jenkins.sh index dd5b924..4c0455d 100755 --- a/ttcn3-pcu-test/jenkins.sh +++ b/ttcn3-pcu-test/jenkins.sh @@ -32,7 +32,7 @@ --name ${BUILD_TAG}-pcu -d \ $DOCKER_ARGS \ $REPO_USER/osmo-pcu-$IMAGE_SUFFIX \ - /bin/sh -c "/usr/local/bin/respawn.sh osmo-pcu -c /data/osmo-pcu.cfg -i 172.18.13.10 >>/data/osmo-pcu.log 2>&1" + /bin/sh -c "/usr/local/bin/respawn.sh osmo-pcu -c /data/osmo-pcu.cfg >>/data/osmo-pcu.log 2>&1" echo Starting container with PCU testsuite docker run --rm \ diff --git a/ttcn3-pcu-test/osmo-pcu.cfg b/ttcn3-pcu-test/osmo-pcu.cfg index cde87b4..4031e26 100644 --- a/ttcn3-pcu-test/osmo-pcu.cfg +++ b/ttcn3-pcu-test/osmo-pcu.cfg @@ -32,4 +32,5 @@ alpha 0 gamma 0 pcu-socket /data/unix/pcu_bts + gsmtap-remote-host 172.18.13.10 gsmtap-category enable-all -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29557 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ib7d6e564e12db08a8dd4890426d2599b3260fa9d Gerrit-Change-Number: 29557 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in docker-playground[master]: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-category enable-all'

by fixeria

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/29556 ) Change subject: ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-category enable-all' ...................................................................... ttcn3-pcu-test: osmo-pcu.cfg: use 'gsmtap-category enable-all' Change-Id: I19fbb75890935a338c31b7eb5e624ec988f91468 --- M ttcn3-pcu-test/osmo-pcu.cfg 1 file changed, 1 insertion(+), 14 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/ttcn3-pcu-test/osmo-pcu.cfg b/ttcn3-pcu-test/osmo-pcu.cfg index 733cebe..cde87b4 100644 --- a/ttcn3-pcu-test/osmo-pcu.cfg +++ b/ttcn3-pcu-test/osmo-pcu.cfg @@ -32,17 +32,4 @@ alpha 0 gamma 0 pcu-socket /data/unix/pcu_bts - gsmtap-category dl-unknown - gsmtap-category dl-dummy - gsmtap-category dl-ctrl - gsmtap-category dl-data-gprs - gsmtap-category dl-data-egprs - gsmtap-category dl-ptcch - gsmtap-category dl-agch - gsmtap-category dl-pch - gsmtap-category ul-unknown - gsmtap-category ul-dummy - gsmtap-category ul-ctrl - gsmtap-category ul-data-gprs - gsmtap-category ul-data-egprs - gsmtap-category ul-rach + gsmtap-category enable-all -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/29556 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: I19fbb75890935a338c31b7eb5e624ec988f91468 Gerrit-Change-Number: 29556 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-MessageType: merged

2 years, 8 months

1
0
0 0

Change in libosmo-netif[master]: osmux: Replace deprecated osmux_xfrm_input_* APIs in examples & tests

by fixeria

Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/29529 ) Change subject: osmux: Replace deprecated osmux_xfrm_input_* APIs in examples & tests ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/29529 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I7f3f8d40f89ffdd135a73316ee60fd429ba2a5b0 Gerrit-Change-Number: 29529 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 03 Oct 2022 09:12:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

2 years, 8 months

1
0
0 0

2025

2024

2023

2022

gerrit-log October 2022