Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29750 )
Change subject: mgcp-client: Introduce APIs to manually select mgcp_client from pool
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File include/osmocom/mgcp_client/mgcp_client_pool.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/29750/comment/786cbf0e_e61d48e6
PS2, Line 17: mgcp_client_pool_member_get
Not so obvious from the function name what this does. get what? also I wouldn't have guessed that it increases a refcounter without looking at the implementation. I know the return type explains what one will get, but still it seems a bit weird to me. I guess it fits the existing mgcp_client_pool_get. Not sure how to improve this though, and it shouldn't block this patch.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29750
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I75ce3e04cd3f6d9cc20d7b4fc0f51083780786c8
Gerrit-Change-Number: 29750
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Oct 2022 10:29:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29748 )
Change subject: mgcp-client: Rearrange order of structs and APIs in header
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29748
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I9ff9c6e1e722690835c5d59b1fa87fb7d9e3120c
Gerrit-Change-Number: 29748
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Oct 2022 10:15:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment