Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29750 )
Change subject: mgcp-client: Introduce APIs to manually select mgcp_client from pool
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/mgcp_client/mgcp_client_pool.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/29750/comment/0be3a892_c52e4234
PS2, Line 17: mgcp_client_pool_member_get
> This follows the classical get() and put() to obtain a pointer with a refcount. […]
Ack
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29750
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I75ce3e04cd3f6d9cc20d7b4fc0f51083780786c8
Gerrit-Change-Number: 29750
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Oct 2022 11:14:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment
Attention is currently required from: osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/29750 )
Change subject: mgcp-client: Introduce APIs to manually select mgcp_client from pool
......................................................................
Patch Set 2:
(1 comment)
File include/osmocom/mgcp_client/mgcp_client_pool.h:
https://gerrit.osmocom.org/c/osmo-mgw/+/29750/comment/14882030_a5674d99
PS2, Line 17: mgcp_client_pool_member_get
> Not so obvious from the function name what this does. […]
This follows the classical get() and put() to obtain a pointer with a refcount. It can also be inferred by looking at mgcp_client_pool_get() or the documentation.
--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/29750
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I75ce3e04cd3f6d9cc20d7b4fc0f51083780786c8
Gerrit-Change-Number: 29750
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 14 Oct 2022 11:11:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29753 )
Change subject: jobs/gerrit-verifications: pipeline: agent none
......................................................................
jobs/gerrit-verifications: pipeline: agent none
Don't allocate a slot on one of the jenkins nodes for running the
pipeline. The pipeline job is lightweight, it just starts other jobs
and waits for their completion.
Without this patch we got into a situation where a lot of patches were
submitted to gerrit at the same time, pipelines were started for all of
them, taking up slots, and then all of the pipelines waiting until free
slots become available before starting the actual build jobs. Thus
blocking each other until I manually stopped them.
Related: OS#2385
Change-Id: I289fcf1431a91a38fc37270e6a2f43d744c79e4f
---
M jobs/gerrit-verifications.yml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/jobs/gerrit-verifications.yml b/jobs/gerrit-verifications.yml
index 36646f8..a9616ff 100644
--- a/jobs/gerrit-verifications.yml
+++ b/jobs/gerrit-verifications.yml
@@ -384,7 +384,7 @@
# https://jenkins.osmocom.org/jenkins/scriptApproval/
dsl: |
pipeline {{
- agent {{ label "osmocom-gerrit" }}
+ agent none
stages {{
stage("Verification") {{
parallel {{
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/29753
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I289fcf1431a91a38fc37270e6a2f43d744c79e4f
Gerrit-Change-Number: 29753
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: merged