January 2022 - gerrit-log - lists.osmocom.org

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by dexter

Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 2: (2 comments) File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/b1648fea_e8cadc6b PS1, Line 59: log_initialized > Can we have this check in logp2() to avoid duplication, BTW? Unfortunately that is not possible because log_check_level() is called before logp2() by the macro. What we could do though is modify log_check_level() so that it always returns 1 when the log is not initialized and then check in logp2 buts that is also not very attractive, so I think accepting a bit of duplication is the better option. File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/d2ac706f_991a93a2 PS1, Line 765: printf > I agree with Harald here, why not fprintf(stderr, ... […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 09:31:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by dexter

Attention is currently required from: fixeria. Hello osmith, Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/26950 to look at the new patch set (#2). Change subject: logging: log to stdout when logging is not initialized ...................................................................... logging: log to stdout when logging is not initialized When the logging framework is not initialized we get an error: "ERROR: osmo_log_info == NULL! You must call log_init() before using logging in ..." There are sometimes situations where some code tries to log before logging was initialied. This is a problem because the actual log line with the debug info we need is covered up by the error message from the logging framework. Lets introduce a fallback logging function that is called when the the logging framework is not available. This function can just use printf. Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 --- M include/osmocom/core/logging.h M src/logging.c 2 files changed, 33 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/50/26950/2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: newpatchset

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > logging before explicit logging initialization: what about some low-level initialization code in __a […] makes sense, thanks -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 09:23:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by fixeria

Attention is currently required from: osmith, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 1: (1 comment) File include/osmocom/core/logging.h: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/6ff11f68_b7ecf0bd PS1, Line 59: log_initialized Can we have this check in logp2() to avoid duplication, BTW? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 09:07:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by fixeria

Attention is currently required from: osmith, dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 1: (1 comment) File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/26950/comment/aa880d44_4cb9245a PS1, Line 765: printf I agree with Harald here, why not fprintf(stderr, ...)? stdout is generally used for generating data (e.g. osmo-config-merge, osmo-gapk), while here IMO stderr is a better target. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 20 Jan 2022 09:05:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: PFCP: add DLPFCP and osmo-upf port numbers

by laforge

Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26606 ) Change subject: PFCP: add DLPFCP and osmo-upf port numbers ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: tests need to pass, but apart from this the patch could long be merged. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26606 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0a46b147ec6a76d909df28136cfd2b764b2c75ea Gerrit-Change-Number: 26606 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jan 2022 14:34:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by laforge

Attention is currently required from: osmith, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Patchset: PS1: not sure if stderr wouldn't be preferred over stdout (not sure)? I think later on the default log target also is to stderr, right? so if you have I/O redirection for logging, then both early and normal logging should use the same file descriptor. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jan 2022 14:33:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by laforge

Attention is currently required from: osmith, dexter. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > (gerrit made this a "resolved" comment, marking as "unresolved") logging before explicit logging initialization: what about some low-level initialization code in __atrribute__((constructor)) ? There will always be situations where you want to log before logging has been properly initialized, and some sane way of "early logging" at that point is ceratinly useful. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jan 2022 14:31:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by osmith

Attention is currently required from: dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I don't understand the use case, isn't this a bug in the program using libosmocore, if it attempts t […] (gerrit made this a "resolved" comment, marking as "unresolved") -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jan 2022 13:37:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

Change in libosmocore[master]: logging: log to stdout when logging is not initialized

by osmith

Attention is currently required from: laforge, pespin, dexter. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26950 ) Change subject: logging: log to stdout when logging is not initialized ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I don't understand the use case, isn't this a bug in the program using libosmocore, if it attempts to log before initializing logging? With this patch it seems that it won't complain at all about logging not being initialized, since the log_check_level -> assert_loginfo() code path isn't executed. Is this intended? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26950 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9b1b0988e02322e3e44fd4ceea3e1bc2d4df3c45 Gerrit-Change-Number: 26950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Jan 2022 13:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

3 years, 5 months

1
0
0 0

2025

2024

2023

2022

gerrit-log January 2022