Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786?usp=email )
Change subject: sctp_server: pass MME addr/port to sctp_proxy as opaque data
......................................................................
Patch Set 1:
(1 comment)
File src/sctp_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786/comment/53b281fa_1053…
:
PS1, Line 64: start_link(Aid, {MmeAddr, MmePort}) ->
I wonder what's the point in maintaining the 2
versions of the start_link here...
It's because `gen_server` is now passing both
MME address and MME port as one argument (tuple), but the existing API expects two
separate arguments. I could change the existing API rather than adding the new `/2`
wrapper, either way is fine with me.
--
To view, visit
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38786?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I1bd5f17d940173c4ec2d8d7a1d48778098008c84
Gerrit-Change-Number: 38786
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 18 Nov 2024 10:54:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>