Change in osmo-cbc[master]: Add initial SBc-AP support to osmo-cbc

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/28602 ) Change subject: Add initial SBc-AP support to osmo-cbc ...................................................................... Patch Set 11: (3 comments) File include/osmocom/cbc/cbc_data.h: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/306ccc6a_175b3cd4 PS10, Line 23: CBC_PEER_PROTO_SBcAP Well, there was one before this patch. And it's generally a good practice making patches adding new entries easier to read. In any case, I am not going to block because of that. File include/osmocom/cbc/internal.h: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/160d2fad_ea0249b6 PS10, Line 30: enum sbcap_server_event { If the meaning is not the same, why names and comments are? Just wondering. File src/sbcap_server_fsm.c: https://gerrit.osmocom.org/c/osmo-cbc/+/28602/comment/9df0ccdf_c4ee5b6e PS8, Line 303: //else Ack. Neither it's marked as FIXME nor as TODO. It's better to use #if 0 ... #else ... #endif here if it should be kept. -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/28602 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: Ib278bc1d1a74459814016fef7a8fe21cc29d46c9 Gerrit-Change-Number: 28602 Gerrit-PatchSet: 11 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Jul 2022 15:57:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment