Attention is currently required from: pespin.
osmith has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475 )
Change subject: sccp_sap_up_ran: ignore RAN until MSC is connected
......................................................................
Patch Set 2:
(2 comments)
File include/osmocom/bsc_nat/msc_fsm.h:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475/comment/0de6590c_e89b7a90
PS1, Line 24: bool msc_fsm_is_connected(struct msc *msc);
I see lots of functions msc_fsm_* being used in lots
of places, even outside "msc" object. […]
Done
File src/osmo-bsc-nat/bsc_nat_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475/comment/320d7a9c_81a53805
PS1, Line 218: if (!msc_fsm_is_connected(msc)) {
msc_is_connected. I don't care about fsm internals
here.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27475
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc-nat
Gerrit-Branch: master
Gerrit-Change-Id: Idf9501412484fa92e8836952609fba7c5443d6c9
Gerrit-Change-Number: 27475
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 11 Mar 2022 12:35:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment