Attention is currently required from: neels, pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31640 )
Change subject: rlcmac: ignore PACKET_DOWNLINK_DUMMY_CONTROL_BLOCK ......................................................................
Patch Set 1:
(1 comment)
File src/rlcmac/rlcmac.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/31640/comment/be6e4538_d61f3595 PS1, Line 392: break; /* Ignore dummy blocks */
(weird place to put a comment IMO, seems to become a habit of yours. […]
Neels: I would appreciate if you could point me to the place in https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards or in the kernel coding guidelines recommending against using inline comments. I believe it's fine for short comments and when there is only one operator in a block (like `return`, `break`, or `continue`). This is a matter of taste and I see no need discussing this.