[S] Change in libosmo-pfcp[master]: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv

Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 ) Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/libosmo-pfcp/Makefile.am: https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741/comment/0fab8daa_439c46df PS1, Line 68: gen__pfcp_ies_auto_LDFLAGS This looks weird, both before and after your patch. Local `*.la` and shared `*_LIBS` should always be in `gen__pfcp_ies_auto_LDADD`. `COVERAGE_LDFLAGS` should be in `gen__pfcp_ies_auto_LDFLAGS`. Why are they mixed up? Also, this is not the first time you're having this problem the linker picking up shared library instead of the locally built one. Last time you solved it by reordering libs, so that the `*.la` files are listed earlier than shared `_LIBS`. Now I am seeing a different workaround. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66 Gerrit-Change-Number: 31741 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Mar 2023 09:29:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment