Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email )
Change subject: epdg: fix a DTE in as_GSUP_rx_CL_REQ
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745/comment/f0541863_2f34…
:
PS1, Line 11: does not properly handle the '*' template kind:
why not making handling the "*" case in this patch properly instead?
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745/comment/98a82530_4d93…
:
PS1, Line 948: [] GSUP.receive(tr_GSUP_CL_REQ(g_pars.imsi, dom := omit, ctype := ctype))
-> value rx_gsup;
if it's possible that the domain is not transmitted, why not changing tr_GSUP_CL_REQ()
to accept a "template" instead of "template (present)"?
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38745?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I26738c8c2a0a4b9066bfb619149cbdbaf3e3b5e1
Gerrit-Change-Number: 38745
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Nov 2024 22:42:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No